Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-17 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated March 17, 2017, 8:23 a.m.) Status -- This change has been

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-17 Thread Matthieu Gallien
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix.

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Igor Poboiko
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated Март 16, 2017, 8:33 п.п.) Review request for KDE Frameworks and

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Anthony Fieroni
> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Igor Poboiko
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? I didn't see much performance issues; and from what can I see, DB size didn't

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Matthieu Gallien
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix.

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-16 Thread Igor Poboiko
> On Март 15, 2017, 8:55 д.п., Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix.

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-15 Thread Matthieu Gallien
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix.

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-15 Thread Matthieu Gallien
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. I almost forgot to ask an automatic test for your fix. Please do not ship without it. -

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-15 Thread Matthieu Gallien
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! KFileMetaData being in use by itself, IMHO Baloo problematics should not block this correction. - Matthieu --- This is an automatically generated e-mail. To reply,

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-15 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- Ship it! Ship It! - Matthieu Gallien On mars 14,

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-15 Thread Anthony Fieroni
> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to limit CPU usage or to discard it? - Anthony --- This is an automatically generated e-mail.

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-14 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- Ship it! Ship It! - Anthony Fieroni On Март 14, 2017,

Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

2017-03-14 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- Review request for KDE Frameworks and Anthony Fieroni. Repository: