D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48336. ahmadsamir added a comment. Add doxygen doc for the new method including @since REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48218=48336 BRANCH addWordToSession (branched from master) REVISION

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395530 , @pino wrote: > In D18317#395513 , @pino wrote: > > > This makes a "core" library grow a dependency on widgets -- not really a good idea, considering

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. @loh.tar: I'll think that over, thanks for the pointers :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395928 , @loh.tar wrote: > Just my thoughts: > > - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. The user

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a comment. @dhaumann: in the screenshot that's "file -> print"; the issue here is with "file -> print preview", where the extra options tabs (including "Layout") aren't added by ktexteditor. :) REPOSITORY R39 KTextEditor REVISION DETAIL

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a comment. A gentle ping. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars,

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir created this revision. ahmadsamir added a reviewer: sandsmark. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the files of the the dictionary set in defaultLanguage= can't be loaded, instead of failing silently, try to load the

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#396483 , @loh.tar wrote: > Well, I'm not a Sonnet Guru, more a normal user. Me too; your views are appreciated all the same. REPOSITORY R246 Sonnet REVISION DETAIL

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added a reviewer: sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsmark Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48218. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. arc diff verbatim REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48217=48218 BRANCH addWordToSession REVISION DETAIL

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48217. ahmadsamir added a comment. Fix commit message REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=47683=48217 BRANCH addWordToSession REVISION DETAIL https://phabricator.kde.org/D17629 AFFECTED

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

ahmadsamir created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ahmadsamir requested review of this revision. REVISION SUMMARY When a word is added to the dictionary or ignored via the spellingMenu, the BackgroundChecker

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added a dependent revision: D17630: Don't re-mark words added/ignored to the dictionary as misspelled. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Add convience method to add a word to BackgroundChecker the session of the currentDict speller. REPOSITORY

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added reviewers: davidedmundson, cullmann. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

ahmadsamir added reviewers: cullmann, davidedmundson. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17630 To: ahmadsamir, cullmann, davidedmundson Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Otherwise the print preview dialog somehow gets the text color from the current default color

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added reviewers: KTextEditor, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir updated this revision to Diff 48948. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix commit message REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18089?vs=48947=48948 BRANCH klauncher-kateSessionManager

D18089: KLauncher: handle processes exiting without error

ahmadsamir added a comment. I don't have commit access, so please commit the diff. Thanks. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

ahmadsamir updated this revision to Diff 49063. ahmadsamir retitled this revision from "KLauncher: handle process dying with exitStatus 0" to "KLauncher: handle processes exiting without error". ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Make commit and debug

D18089: KLauncher: handle processes exiting without error

ahmadsamir marked 2 inline comments as done. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in klauncher.cpp:340 > To make this less scary (since it's not an error) I would suggest > > << "exited without error, request done. status=" << Good point. Done. REPOSITORY R303

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY When a process dies with exitStatus 0, it could well be the app exited cleanly, and there's no need to display

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#437220 , @cullmann wrote: > Hi, I still don't like that we do different things in replaceText depending on the selection of the potential activeView, that makes this function harder to use correctly, as it

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir added a comment. > ! In D19161#415702 , @dhaumann wrote: > Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1 Turns out these are false positives; I

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#420599 , @loh.tar wrote: > Fix this patch also Bug 382213 ? No, it doesn't fix it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor,

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Do we still need a unit test for this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor,

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QTextFormat::FontUnderline has been deprecated upstream for a long time. It seems that for

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#424628 , @cullmann wrote: > I don't like the change to call typeChars. > > 1. that needs a valid view, activeView() might be null. > 2. replaceText is not interactive per-default, but typeChars is. >

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 52658. ahmadsamir added a comment. Change replaceText to handle inserting word completion with block selection mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18793?vs=51051=52658 BRANCH

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. I changed the diff to make replaceText handle inserting the word completion text. Is this a new behaviour? it exactly matches what users expect when they type something in block selection mode. Also why would this be opt-in? if you type something in

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54150. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: KDevelop. ahmadsamir removed subscribers: loh.tar, mwolff. ahmadsamir added a comment. Verbatim REPOSITORY R39

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54149. ahmadsamir added a comment. - Split the code responsible for inserting text in block selection from typeChars() to a new function - Don't add words where the block selection cursor is inside to the possible completion matches from the

D18793: Handle text completion with block selection mode

ahmadsamir added a subscriber: loh.tar. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, mwolff Cc: loh.tar, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking,

D18793: Handle text completion with block selection mode

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Handle text completion with block selection mode BUG: 359763 FIXED-IN: 5.56 TEST PLAN

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Ping? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop Cc: kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. In D18907#410973 , @cullmann wrote: > I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. The **this** pointer of Loader::createSpeller is const, so the

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51552. ahmadsamir added a comment. Improve api docs. Use constFind() with languageClients, as that's more efficient than searching two separate data structures. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51578. ahmadsamir added a comment. Avoid shorthand in api docs REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18907?vs=51552=51578 REVISION DETAIL https://phabricator.kde.org/D18907 AFFECTED FILES

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. I don't have commit access, so please commit the diff. Thanks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh,

D18317: Display an error message if loading a dictionary fails

ahmadsamir added a comment. I've split the changes to the Loader in https://phabricator.kde.org/D18907. And will hopefully try to handle the Ui part in this current diff. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir created this revision. ahmadsamir added reviewers: sandsmark, cullmann, dhaumann. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In Loader::createSpeller, retun early if lang isn't one of the available languages(); otherwise a

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir added a comment. In D19161#415701 , @dhaumann wrote: > This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278. Another way to test, try setting

D18163: Set the color scheme to Printing when print preview'ing

ahmadsamir updated this revision to Diff 50503. ahmadsamir retitled this revision from "KateRenderer: when printing initially set the color scheme to Printing" to "Set the color scheme to Printing when print preview'ing". ahmadsamir edited the summary of this revision. ahmadsamir edited the test

D18317: Display an error message if loading a dictionary fails

ahmadsamir updated this revision to Diff 50486. ahmadsamir retitled this revision from "Don't fail if defaultLanguage dictionary can't be loaded" to "Display an error message if loading a dictionary fails". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D18317: Display an error message if loading a dictionary fails

ahmadsamir added a reviewer: loh.tar. ahmadsamir added a subscriber: pino. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a comment. In D18163#398206 , @dhaumann wrote: > Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not. > > What is the bahavior currently when you print a page with another schema, and then

D18089: KLauncher: handle processes exiting without error

ahmadsamir added a comment. Ping. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18163: Set the color scheme to Printing for Print Preview

ahmadsamir marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18163: Set the color scheme to Printing for Print Preview

ahmadsamir updated this revision to Diff 50588. ahmadsamir retitled this revision from "Set the color scheme to Printing when print preview'ing" to "Set the color scheme to Printing for Print Preview". ahmadsamir added a comment. Use a setter REPOSITORY R39 KTextEditor CHANGES SINCE LAST

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a document gets reloaded for whatever reason, automatic spellcheck should be refreshed so as to

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in ontheflycheck.cpp:75 > Directly connect to this, refreshSpellCheck. That wouldn't work, reloaded() takes a Document pointer parameter whereas refreshSpellcheck takes a Range parameter. REPOSITORY R39 KTextEditor REVISION

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in ontheflycheck.cpp:75 > But refreshSpellCheck() has a default parameter, so this function exists > without any parameter. Afaik this should work?! In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added a comment. Qt docs say that the signal must have at least as many arguments as the slot, and there is an implicit conversion between the types of the corresponding arguments in the signal and the slot. REPOSITORY R39 KTextEditor REVISION DETAIL

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir updated this revision to Diff 60467. ahmadsamir removed a subscriber: dhaumann. ahmadsamir added a comment. Use a lambda instead of adding a standalone method REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21940?vs=60154=60467 BRANCH

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir marked 5 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann,

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added a comment. Great :). Please commit it too (as I don't have access to kde git). REPOSITORY R39 KTextEditor BRANCH document-reloaded-spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir, #ktexteditor, cullmann, dhaumann

D22276: Add an action to insert a non-indented newline

ahmadsamir added a comment. Ctrl+Enter/Return may be a too common shortcut, i.e. users probably have it already mapped to do something, so maybe we shouldn't set a default shortcut for that action... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To:

D22276: Add an action to insert a non-indented newline

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Currently pressing Enter to insert a new line, KTextEditor will, in most cases, indent the new

D22276: Add an action to insert a non-indented newline

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.h:827 > I dislike the double negation: noIndentation = false. Later even > !noIndentation. This is bad API design. > > Please change to bool indent = true. Noted. Although I'll use an enum per cullmann's

D22315: Add setting to enable/disable text drag-and-drop (on by default)

ahmadsamir added a comment. IMHO, "Enable/Disable" is already implied by the checkbox :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: ahmadsamir, dhaumann, cullmann,

D22276: Add an action to insert a non-indented newline

ahmadsamir updated this revision to Diff 61363. ahmadsamir added a comment. Use an Enum instead of bool REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22276?vs=61156=61363 BRANCH regular-newline (branched from master) REVISION DETAIL

D22276: Add an action to insert a non-indented newline

ahmadsamir updated this revision to Diff 61373. ahmadsamir added a comment. Fix action name, don't use camel case, use _ Fix comment indentation :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22276?vs=61363=61373 BRANCH regular-newline (branched

D22276: Add an action to insert a non-indented newline

ahmadsamir added a comment. If this is OK, please commit it too. Thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: bruns, mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson,

D22477: Add a config to only show completions matching word beginning

ahmadsamir added a comment. In D22477#496059 , @kossebau wrote: > Default is `false,` so does not change behaviour unless someone toggles the switch, right? > > I would rename the option to `WordCompletionMatchFromWordStartOnly` though, as

D22477: Add a config to only show completions matching word beginning

ahmadsamir updated this revision to Diff 61879. ahmadsamir added a comment. Change the diff altogether to not show the menu with "ContainsMatch" REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61807=61879 BRANCH less-trigger-happy-completions

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61881. ahmadsamir retitled this revision from "Add a config to only show completions matching word beginning" to "With auto completion don't show completions that don't match from beginning of typed word". ahmadsamir edited the summary of this revision.

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, KDevelop, cullmann, dhaumann, brauch. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Change KateKeywordCompletionModel::matchingItem to return

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61882. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Take 2 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61881=61882 BRANCH less-trigger-happy-completions (branched

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir added a comment. In D22477#496214 , @brauch wrote: > I'm not sure if this solves the right problem. > > Where I notice this issue a lot is when typing "return". The keyword completion suggests "return", and when I want a newline,

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. Ping. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel,

D23472: Enable typing soft-hyphen characters

ahmadsamir added a comment. Digging around in git log I found: https://git.reviewboard.kde.org/r/127026/ But I think that's covered by the method in QInputControl, and ktexteditor has a unit test for that; I'll see how it goes. REPOSITORY R39 KTextEditor REVISION DETAIL

D23472: Enable typing soft-hyphen characters

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The typeChars() functions filters out non-printable characters, except for: \t, \n, \r; add

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

ahmadsamir updated this revision to Diff 64708. ahmadsamir retitled this revision from "Enable typing soft-hyphen characters" to "Mimic QInputControl::isAcceptableInput() when filtering typed characters". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

ahmadsamir updated this revision to Diff 64709. ahmadsamir added a comment. Improve comment in header file REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23472?vs=64708=64709 BRANCH ahmad/soft-hyphen (branched from master) REVISION DETAIL

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#519773 , @cullmann wrote: > In D23457#519217 , @ahmadsamir wrote: > > > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what

D23708: [CopyJob] Fix crash when copying all files is skipped for an already existing dir

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In copyNextFile() if all files have been skipped QList::erase() will return end() iterator, accessing the

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? IIUC, '\s' was workedaround so as not to match a newline so that the search pattern

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#519205 , @cullmann wrote: > Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea. > Or do I misunderstand that? It's

D23457: Port regex search to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Do away with the kateregexp class; move isMultiLine() to kateregexpsearch - \s can match a

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir updated this revision to Diff 65486. ahmadsamir retitled this revision from "[CopyJob] Fix crash when copying all files is skipped for an already existing dir" to "[CopyJob] Fix crash when copying an already existing dir and pressing "Skip"". ahmadsamir edited the summary of this

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. In D23708#525848 , @dfaure wrote: > Thanks for the fix! > > Do you feel like writing a unittest for it? > JobTest::chmodFileError shows how to use

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Please commit it. Thanks. REPOSITORY R241 KIO BRANCH ahmad/copyjob (branched from master) REVISION DETAIL https://phabricator.kde.org/D23708 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel,

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir added a comment. In D23875#529442 , @dhaumann wrote: > Since this crash is in KCoreDirLister, I wonder whether we can find a unit test that reproduces this without the KFileWidget. I think the main issue here is kdirlister

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > I try (hard, there are many temptations when looking at all exisiting loop > code) to usually do not too much other improvements but stay on-topic of > commit message change, but will do an

D23902: [KCoreDirLister] replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: kde-frameworks-devel, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Also change directoriesForCanonicalPath() to return const TEST PLAN The code compiles and all tests

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > As someone who looked at a lot of commit history, my recommendation is: don't > do in the same commit. Make it a separate commit with a dedicated commit > message. > While-at-it changes are

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > Is it? > This patch as is now has 3 changes: > > - change a foreach loop over extracted key list of a QHash to then also > access values (2 discouraged things) to iterator-based for loop over the

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > Still unsure what you mean with the constness, as the QHash `shortcuts` has > been const all the time, and thus the access methods and its returned > references. If you meant the initially

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When creating multiple nested new folders, one at a time, in the "save as" dialog, where folders are created and

D23991: GIT_SILENT fix comment about passwords in debug output

ahmadsamir updated this revision to Diff 66227. ahmadsamir added a comment. Remove redundant comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23991?vs=66217=66227 BRANCH ahmad/url-debug-output-passwords (branched from master) REVISION DETAIL

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:1044 > It's generally considered bad practice to return a const value, because the > caller makes a copy anyway, so this doesn't guarantee anything. And it > removes the benefits of rvalues that can be

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir updated this revision to Diff 66073. ahmadsamir marked 7 inline comments as done. ahmadsamir retitled this revision from "[KCoreDirLister] replace foreach with range-for" to "[KCoreDirLister] replace deprecated foreach with range-for". ahmadsamir added a comment. Fix stuff

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir added a comment. Here, in the web-UI, it says authored by dfaure, as it should, but the commit still says authored by me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00n,

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir updated this revision to Diff 66104. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: chinmoyr. ahmadsamir added a comment. Refer to one bug report, the others are dupes REPOSITORY R241 KIO CHANGES

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir marked 10 inline comments as done. ahmadsamir added a comment. I think I got all the bits I missed before (sorry about the mess). But I'll sleep on it anyway, will submit in the morning (usually I find mistakes in my code when I look at it again in the morning). Thanks.

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir updated this revision to Diff 66393. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. Fix patch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23902?vs=66073=66393 BRANCH ahmad/foreach (branched from master) REVISION

  1   2   3   4   5   6   7   8   9   10   >