Re: [Kicad-developers] Hotkeys Editor

2018-01-12 Thread Wayne Stambaugh
I think the size of the hotkey edit dialog issue has been resolved although now the width seems a bit excessive. I hope this was not fixed by setting the default size of the dialog using wxFormbuilder. This seems to lead to weird sizing issues on different platforms. I'm not sure when this was

Re: [Kicad-developers] Hotkeys Editor

2018-01-12 Thread Nick Østergaard
I also don't see the advantage of using the tabbed interface, but we may consider making the default size of that dialog bigger in pcbnew. It is quite small right now. It only shows a coupel of lines of the tree view. 2018-01-12 20:47 GMT+01:00 Wayne Stambaugh : > I

Re: [Kicad-developers] Hotkeys Editor

2018-01-12 Thread Wayne Stambaugh
I actually prefer the tree view. Having to effectively change windows by clicking on a tab to see the hotkeys for different main frame window seems like extra work to me. Collapsing/expanding a tree view feels less intrusive. I'm not sure how this is any less clear than a separate tab. Tree

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Chris Pavlina
I really don't care. The original motivation was simply being able to cleanly put it as a tab inside the preferences dialog without nesting, I really didn't think putting them in a single list would make them undiscoverable (and this is the first I've heard that comment, to be honest). But I have

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Seth Hillbrand
Hi All- Sorry, this seems to have gotten off-track. Let's pause the button discussion for a moment. I'm really more concerned about the tree-list layout hiding hotkeys from users. Does anyone feel like we need the treelist here? Chris, I know this was originally your commit and I don't mean

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Andrey Kuznetsov
If that would be the intended functionality, then I'd suggest "Reset Selected" instead of "Reset". On Thu, Jan 11, 2018 at 5:01 AM, yann jautard wrote: > what about keeping four buttons : > > *Defaults* that reset all hotkeys *of the current tab* to default > > *Reset* that

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread yann jautard
what about  keeping four buttons : *Defaults* that reset all hotkeys *of the current tab* to default *Reset* that reset *the selected* hotkey only to default *Cancel* that close the window and undo the current changes *Save* that close the window and save the current changes With a tooltip

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Jeff Young
I agree that the tabs were better. And I agree that the Defaults button is a good addition. I don’t agree about the Reset button. Too much visual complexity when the user can just hit Cancel and then Edit Hotkeys again to achieve the same effect. Cheers, Jeff. > On 11 Jan 2018, at 01:07,

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Thomas Kindler
On Thu, January 11, 2018 09:37, Andrey Kuznetsov wrote: > I wonder if "Undo All" is more appropriate if all the changes during that > session are undone, as opposed to just the last one. > That's very similar to "Cancel" then. Perhaps, we can remove the Undo button entirely in this case. > On

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Andrey Kuznetsov
I wonder if "Undo All" is more appropriate if all the changes during that session are undone, as opposed to just the last one. On Thu, Jan 11, 2018 at 12:35 AM, Thomas Kindler wrote: > > On Thu, January 11, 2018 02:07, Seth Hillbrand wrote: > > I feel that there is a

Re: [Kicad-developers] Hotkeys Editor

2018-01-11 Thread Thomas Kindler
On Thu, January 11, 2018 02:07, Seth Hillbrand wrote: > I feel that there is a usability issue with the current hotkeys editor > that is a regression from the 4.0.7 hotkeys editor. > > I've attached images for both to this message. The current editor opens > with a tree view that hides the