marked as submitted.
Review request for Kopete, Laurent Montel and Pali Rohár.
Changes
---
Submitted with commit fcc69d5ad1fa6cca9d567b2f756d251d745f7c57 by Luigi Toscano
on behalf of Paulo Lieuthier to branch kf5.
Repository: kopete
Description
---
The history plugin port was not
Hi all,
In this week I have worked on improving the façade abstraction for the
history plugin's backends, and also adding a new, SQLite-based backend.
It's still in the early stages, but saving and loading recent messages
for 1:1 conversations already work. Group chats, Jabber rosters, SQL
i
lready submitted? Please,
tell me if there is anything to improve on them so we can get them merged.
Thanks,
Paulo Lieuthier
signature.asc
Description: OpenPGP digital signature
#file496733line49>
> >
> > SQL injections
Good point. I'll add that to the timeline.
- Paulo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130166/#review
Testing
---
Testbed account and test user creation and simple conversation. Only logging
was changed.
Thanks,
Paulo Lieuthier
/historyplugin.cpp 48cd98010c2f3e65ff76ce3b6e5a43c92e988478
plugins/history/historypreferences.cpp
9c64b44184923aa92fe9fb252bfc5dc4d868b908
Diff: https://git.reviewboard.kde.org/r/130166/diff/
Testing
---
I only tested 1:1 conversations so far, using the Testbed protocol.
Thanks,
Paulo
rences.cpp
9c64b44184923aa92fe9fb252bfc5dc4d868b908
Diff: https://git.reviewboard.kde.org/r/130164/diff/
Testing
---
Thanks,
Paulo Lieuthier
On 21-06-2017 11:45, Pali Rohár wrote:
On Tuesday 20 June 2017 08:38:01 Paulo Lieuthier wrote:
On 20-06-2017 05:20, Pali Rohár wrote:
On Tuesday 20 June 2017 01:24:10 Paulo Lieuthier wrote:
The new iteration:
Conversations:
* id
* subconversation_id
* account
* type (1:1, group, channel
On 20-06-2017 05:20, Pali Rohár wrote:
> On Tuesday 20 June 2017 01:24:10 Paulo Lieuthier wrote:
>> The new iteration:
>>
>> Conversations:
>> * id
>> * subconversation_id
>> * account
>> * type (1:1, group, channel)
>> * entity_identifier (id of
> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 287
> > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line287>
> >
> > it's not debug categories changes no ?:)
>
> Paulo Lieu
)
* sender_display_name (sender name, if name not available through id)
* type (text, event, file, voice clip)
* content (html)
* importance
* state
On 12-06-2017 07:33, Pali Rohár wrote:> On Sunday 11 June 2017 20:22:24
Pali Rohár wrote:
>> On Sunday 11 June 2017 19:25:52 Paulo Lieuthier wrote:
>>&
a new branch in Github [2].
Paulo Lieuthier
[1] https://git.reviewboard.kde.org/r/130164/
[2] https://github.com/paulolieuthier/kopete/commits/initial-facade
signature.asc
Description: OpenPGP digital signature
logger.cpp 66b627030f9baf78d98c010c3cc2dc3e7cc08c99
plugins/history/historyplugin.cpp 48cd98010c2f3e65ff76ce3b6e5a43c92e988478
plugins/history/historypreferences.cpp
9c64b44184923aa92fe9fb252bfc5dc4d868b908
Diff: https://git.reviewboard.kde.org/r/130164/diff/
Testing
---
Thanks,
Paulo Lieuthier
?
I removed all empty debugs. Are they worth keeping, even with no message?
> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/receivefiletask.cpp, line 173
> > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496620#file496620line
> On June 10, 2017, 1:26 p.m., Laurent Montel wrote:
> >
>
> Paulo Lieuthier wrote:
> I had already started translating those (and all others) in my main
> branch, and didn't want to mess with that here. Next review request will be
> such translation, isn&#
it is.
- Paulo Lieuthier
On June 18, 2017, 11:09 a.m., Paulo Lieuthier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
c60f3cf63
Diff: https://git.reviewboard.kde.org/r/130161/diff/
Testing
---
Testbed account and test user creation and simple conversation. Only logging
was changed.
Thanks,
Paulo Lieuthier
On 11-06-2017 08:28, Pali Rohár wrote> What does the "state" mean?
Whether the message was really sent or failed to be sent.
> Also there is missing indication about direction. How to store message
> which user of Kopete sent to IRC person? Or how to store message that
> was sent from user to
> On June 10, 2017, 1:26 p.m., Laurent Montel wrote:
> >
>
> Paulo Lieuthier wrote:
> I had already started translating those (and all others) in my main
> branch, and didn't want to mess with that here. Next review request will be
> such translation, isn&#
is complete, but I think this is a good starting point.
This next week I'll be working on the storage façade, and probably send
a few more patches regarding Qt5 and KF5 migration!
Paulo
On 06-06-2017 11:34, Pali Rohár wrote:
> Hi!
>
> On Tuesday 06 June 2017 11:05:26 Paulo Lieuthier wr
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130154/#review103308
---
Ship it!
Ship It!
- Paulo Lieuthier
On June 10, 2017
> On June 10, 2017, 1:26 p.m., Laurent Montel wrote:
> >
>
> Paulo Lieuthier wrote:
> I had already started translating those (and all others) in my main
> branch, and didn't want to mess with that here. Next review request will be
> such translation, isn&#
.reviewboard.kde.org/r/130154/#review103302
---
On June 10, 2017, noon, Paulo Lieuthier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
plugin.cpp 48cd98010
plugins/history/historypreferences.cpp 9c64b4418
Diff: https://git.reviewboard.kde.org/r/130154/diff/
Testing
---
Tested last messages appearance on reopening a chat window, using Jabber and
Test Protocol.
Thanks,
Paulo Lieuthier
l#tokenizers
On 05-06-2017 16:05, Pali Rohár wrote:
> Hi Paulo!
>
> Now one week passed and we would like to hear from you some status
> update...
>
> On Monday 29 May 2017 04:04:57 Paulo Lieuthier wrote:
>> May 29 – June 2
>> * Become familiar with Kopete’s current his
On 29-05-2017 04:41, Pali Rohár wrote:
> On Sunday 28 May 2017 23:04:57 Paulo Lieuthier wrote:
>> Hey, Pali. I thought history2 was the best option today.
>
> history2 does not support rich text messages, so no is not a good.
>
>> I just updated my
>> timetable a
On 27-05-2017 06:12, Pali Rohár wrote:
> On Friday 26 May 2017 16:41:15 Paulo Lieuthier wrote:
> > Hi all,
> >
> > I'm really sorry it took this long. I've been really busy with my
> > undergraduate thesis, as I'm graduating this semester. The final
>
[1] that I think is reasonable, but
I really need everyone's opinions and expectations about it. Is it sufficient?
Please review it and comment on the document.
I will update the timeline during the project so it stays always up to date.
Thanks,
Paulo Lieuthier
[1] https://goo.gl/vs7dwG
0
Hi everyone,
Is there a reason not to upgrade to CMake 3.0.2 or to use C++11 in Kopete code,
following KDE general path (both cmake 3.0.2 and C++11-capable GCC are present
in Debian stable repositories)?
I'm working in Kopete for GSoC (history plugin), and will be sending my schedule
in the next
Hi all,
Thanks for the oportunity. I'm finishing my timeline and will send to the ML
soon.
Congratulations, Vijay! Let's do it!
Paulo
On 05/05/17 17:25, Pali Rohár wrote:
> On Friday 05 May 2017 22:16:48 vijay krishnavanshi wrote:
>> Do we have to give updates on kde-devel also or just updates
d I'm very interested to implement them. I myself work with
implementing server to server exchange protocols in my day job.
I hope this can help me introducing myself and the ideas.
Best,
Paulo Lieuthier
On Tue, Mar 28, 2017 at 5:17 AM Pali Rohár wrote:
> On Saturday 25 March 2017 2
o ask for some help, if needed be.
Please, be my mentor or point me to someone. :)
Best,
Paulo Lieuthier
[1] https://git.reviewboard.kde.org/users/paulolieuthier/
[2]
https://docs.google.com/document/d/10l5kIePsN69Amvk9I1WYLsU3nuReVZzvtp1fyVIV22E/edit?usp=sharing
[3]
https://docs.google.com/docum
abber/jabberformtranslator.cpp 520cb45
protocols/jabber/jabberxdatawidget.cpp 5d3bd7c
Diff: https://git.reviewboard.kde.org/r/127357/diff/
Testing
---
Thanks,
Paulo Lieuthier
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/ma
shown in the referenced bug report. The
patch makes the wizzard have its size adjusted on chaging page.
Diffs
-
kopete/addaccountwizard/addaccountwizard.cpp fd0506f
Diff: https://git.reviewboard.kde.org/r/127358/diff/
Testing
---
Thanks,
Paulo Lieu
sting
---
Thanks,
Paulo Lieuthier
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
disabling word wrap. I'll keep searching.
- Paulo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127358/#review93474
-------
On Mar
have its size adjusted on chaging page.
Diffs
-
kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a
Diff: https://git.reviewboard.kde.org/r/127358/diff/
Testing
---
Thanks,
Paulo Lieuthier
___
kopete-devel mailing list
kopete-devel@kd
t.cpp 5d3bd7c
Diff: https://git.reviewboard.kde.org/r/127357/diff/
Testing
---
Thanks,
Paulo Lieuthier
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
38 matches
Mail list logo
