Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread Gleb Natapov
On Thu, Apr 11, 2013 at 05:37:33PM +0200, Borislav Petkov wrote: On Thu, Apr 11, 2013 at 05:28:18PM +0300, Gleb Natapov wrote: On Thu, Apr 11, 2013 at 02:18:15AM +0200, Borislav Petkov wrote: On Wed, Apr 10, 2013 at 03:16:39PM +0300, Gleb Natapov wrote: Right, the question is how kernel

Re: Interested in working for GSoC project

2013-04-14 Thread Jan Kiszka
On 2013-04-13 20:24, Mohit Dhingra wrote: Hi All, I am Mohit Dhingra, planning to work in GSoC project Improve nested virtualization support for x86. I got in touch with Jan (jan.kis...@web.de) few days back. As suggested by him, I am trying to write a simple unit test which tests the

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread Gleb Natapov
On Thu, Apr 11, 2013 at 02:18:15AM +0200, Borislav Petkov wrote: On Wed, Apr 10, 2013 at 03:16:39PM +0300, Gleb Natapov wrote: Right, the question is how kernel can tell QEMU that the cpuid bit is supported but should not be set unless explicitly asked by an user. Actually, this seems to

Re: [PATCH] tcm_vhost: Fix tv_cmd leak in vhost_scsi_handle_vq

2013-04-14 Thread Michael S. Tsirkin
On Tue, Apr 09, 2013 at 08:46:42AM -0700, Nicholas A. Bellinger wrote: On Tue, 2013-04-09 at 17:16 +0800, Asias He wrote: If we fail to submit the allocated tv_vmd to tcm_vhost_submission_work, we will leak the tv_vmd. Free tv_vmd on fail path. Signed-off-by: Asias He as...@redhat.com

Re: [PATCH v5 0/3] tcm_vhost hotplug

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 04:10:50PM -0700, Nicholas A. Bellinger wrote: Hi MST, Ping on this series for use with vhost-scsi-pci code..? They will need to be heading into target-pending/for-next soon to make the v3.10 window opening in t-minus 9 days. ;) --nab Let me turns this around

Re: [PATCH v10 0/7] Use eoi to track RTC interrupt delivery status

2013-04-14 Thread Gleb Natapov
On Thu, Apr 11, 2013 at 07:21:34PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com Current interrupt coalescing logci which only used by RTC has conflict with Posted Interrupt. This patch introduces a new mechinism to use eoi to track interrupt: When delivering an

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04 PM: On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: Ok, so then you prefer to add the inline functions to read/write to the vmcs12 fields, (to set the request bit if shadowed field changed) and you are not

Re: [PATCH v4 2/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-04-14 Thread Michael S. Tsirkin
On Sat, Apr 13, 2013 at 11:29:14AM +0800, Asias He wrote: This patch makes vhost_scsi_flush() wait for all the pending requests issued before the flush operation to be finished. Changes in v4: - Introduce vhost_scsi_inflight - Drop array to track flush - Use RCU to protect vs_inflight

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04 PM: On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: Ok, so then you prefer to add the inline functions to read/write to the vmcs12 fields, (to

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: On 04/12/2013 07:36 AM, Rusty Russell wrote: Sasha Levin sasha.le...@oracle.com writes: On 04/11/2013 12:36 PM, Will Deacon wrote: Hello folks, Here's the latest round of ARM fixes and updates for kvmtool. Most of this is

Re: virtio-net mq vq initialization (was: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool)

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 01:41:58PM +0100, Will Deacon wrote: Hi Rusty, On Fri, Apr 12, 2013 at 12:36:00PM +0100, Rusty Russell wrote: I'm confused. kvmtool is using too much memory, or the guest? If kvmtool, the Device Initialization section above applies to the driver, not the device.

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04 PM: On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: Ok, so then you prefer to add

Re: [PATCH] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 10:59:51PM +0800, Asias He wrote: On Fri, Apr 12, 2013 at 02:33:32PM +0300, Michael S. Tsirkin wrote: On Fri, Apr 12, 2013 at 02:25:23PM +0800, Asias He wrote: On Thu, Apr 11, 2013 at 01:47:21PM +0300, Michael S. Tsirkin wrote: On Tue, Apr 09, 2013 at 05:39:43PM

[PATCH v4 2/6] KVM: nVMX: Rework event injection and recovery

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The basic idea is to always transfer the pending event injection on vmexit into the architectural state of the VCPU and then drop it from there if it turns out that we left L2 to enter L1, i.e. if we enter prepare_vmcs12. vmcs12_save_pending_events takes

[PATCH v4 3/6] KVM: VMX: Move vmx_nmi_allowed after vmx_set_nmi_mask

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com vmx_set_nmi_mask will soon be used by vmx_nmi_allowed. No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v4 1/6] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Check if the interrupt or NMI window exit is for L1 by testing if it has the corresponding controls enabled. This is required when we allow direct injection from L0 to L2 Signed-off-by: Jan Kiszka jan.kis...@siemens.com Reviewed-by: Gleb Natapov

[PATCH v4 4/6] KVM: nVMX: Fix conditions for interrupt injection

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com If we are entering guest mode, we do not want L0 to interrupt this vmentry with all its side effects on the vmcs. Therefore, injection shall be disallowed during L1-L2 transitions, as in the previous version. However, this check is conceptually independent

[PATCH v4 6/6] KVM: nVMX: Avoid reading VM_EXIT_INTR_ERROR_CODE needlessly on nested exits

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com We only need to update vm_exit_intr_error_code if there is a valid exit interruption information and it comes with a valid error code. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |6 +- 1 files changed, 5 insertions(+),

[PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be injected has to be applied also on NMIs. The difference is that if NMI interception is on these events are consumed and blocked by the VM exit. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

[PATCH v4 0/6] KVM: nVMX: Make direct IRQ/NMI injection work

2013-04-14 Thread Jan Kiszka
Changes in this version: - reworked patch 2, 4 and 5 according to review - restored clearing of vm_entry_intr_info_field - no longer read idt_vectoring_info_field from VMCS - removed check of idt_vectoring_info_field on vmx_nmi_allowed/ vmx_interrupt_allowed - added

Re: [PATCH v10 0/7] KVM: VMX: Add Posted Interrupt supporting

2013-04-14 Thread Gleb Natapov
On Thu, Apr 11, 2013 at 07:25:09PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com The follwoing patches are adding the Posted Interrupt supporting to KVM: The first patch enables the feature 'acknowledge interrupt on vmexit'.Since it is required by Posted interrupt, we need

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Jan Kiszka
On 2013-04-14 12:07, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04 PM: On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote:

Re: Interested in working for GSoC project

2013-04-14 Thread Kashyap Chamarthy
On Sun, Apr 14, 2013 at 1:48 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-04-13 20:24, Mohit Dhingra wrote: Hi All, I am Mohit Dhingra, planning to work in GSoC project Improve nested virtualization support for x86. I got in touch with Jan (jan.kis...@web.de) few days back. As suggested

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Jan Kiszka jan.kis...@web.de wrote on 14/04/2013 01:27:10 PM: On 2013-04-14 12:07, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: On 2013-04-14 12:07, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 12/04/2013 01:48:04 PM:

[PATCH 1/2] KVM: nVMX: Validate EFER values for VM_ENTRY/EXIT_LOAD_IA32_EFER

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com As we may emulate the loading of EFER on VM-entry and VM-exit, implement the checks that VMX performs on the guest and host values on vmlaunch/ vmresume. Factor out kvm_valid_efer for this purpose which checks for set reserved bits. Signed-off-by: Jan

[PATCH 2/2] KVM: nVMX: VM_ENTRY/EXIT_LOAD_IA32_EFER overrides EFER.LMA settings

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com If we load the complete EFER MSR on entry or exit, EFER.LMA (and LME) loading is skipped. Their consistency is already checked now before starting the transition. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |4 ++-- 1 files

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov g...@redhat.com wrote on 14/04/2013 01:34:52 PM: On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: On 2013-04-14 12:07, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote:

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 14/04/2013 01:34:52 PM: On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: On 2013-04-14 12:07, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov

Re: [PATCH v4 2/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-04-14 Thread Asias He
On Sun, Apr 14, 2013 at 12:58:03PM +0300, Michael S. Tsirkin wrote: On Sat, Apr 13, 2013 at 11:29:14AM +0800, Asias He wrote: This patch makes vhost_scsi_flush() wait for all the pending requests issued before the flush operation to be finished. Changes in v4: - Introduce

Re: [PATCH] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-04-14 Thread Asias He
On Sun, Apr 14, 2013 at 01:07:51PM +0300, Michael S. Tsirkin wrote: On Fri, Apr 12, 2013 at 10:59:51PM +0800, Asias He wrote: On Fri, Apr 12, 2013 at 02:33:32PM +0300, Michael S. Tsirkin wrote: On Fri, Apr 12, 2013 at 02:25:23PM +0800, Asias He wrote: On Thu, Apr 11, 2013 at 01:47:21PM

Re: [PATCH kvm-unittests v2] x86/taskswitch2: Task switches into/out of VM86

2013-04-14 Thread Gleb Natapov
On Fri, Apr 12, 2013 at 01:14:47PM +0200, Kevin Wolf wrote: This adds a test case that jumps into VM86 by iret-ing to a TSS and back to Protected Mode using a task gate in the IDT. Signed-off-by: Kevin Wolf kw...@redhat.com Applied, thanks. Found a bug with it and

[PATCH] KVM: VMX: Fix check guest state validity if a guest is in VM86 mode

2013-04-14 Thread Gleb Natapov
If guest vcpu is in VM86 mode the vcpu state should be checked as if in real mode. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index d268677..fec7c48 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3554,7 +3554,7 @@ static bool

Re: [PATCH kvm-unit-tests 5/5] x86-run: Pull extra arguments from unittests.cfg

2013-04-14 Thread Gleb Natapov
On Mon, Mar 25, 2013 at 02:30:27PM -0400, Cole Robinson wrote: On 03/20/2013 03:06 PM, Marcelo Tosatti wrote: On Sun, Mar 17, 2013 at 07:58:56PM -0400, Cole Robinson wrote: On 03/17/2013 11:25 AM, Gleb Natapov wrote: On Fri, Mar 15, 2013 at 08:09:09PM -0400, Cole Robinson wrote: Some

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov g...@redhat.com wrote on 14/04/2013 02:16:02 PM: On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 14/04/2013 01:34:52 PM: On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: On 2013-04-14 12:07, Gleb Natapov

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 04:47:48PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 14/04/2013 02:16:02 PM: On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: Gleb Natapov g...@redhat.com wrote on 14/04/2013 01:34:52 PM: On Sun, Apr 14, 2013 at

Re: [PATCH 0/5] kvm-unittests: add pci PORT IO and MMIO speed tests

2013-04-14 Thread Gleb Natapov
On Wed, Apr 03, 2013 at 11:52:19AM +0300, Michael S. Tsirkin wrote: These patches add ability to measure speed of MMIO versus PIO, in different configurations. As I didn't want to reserve a hardcoded range of memory, I added pci bus scan support instead. Used together with the new pci-testdev

Re: virtio-net mq vq initialization

2013-04-14 Thread Sasha Levin
On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: On 04/12/2013 07:36 AM, Rusty Russell wrote: Sasha Levin sasha.le...@oracle.com writes: On 04/11/2013 12:36 PM, Will Deacon wrote: Hello folks, Here's the latest round of ARM fixes

Re: [PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:12:49PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be injected has to be applied also on NMIs. The difference is that if NMI interception is on these events are consumed and blocked by the VM exit.

Re: [PATCH v4 0/6] KVM: nVMX: Make direct IRQ/NMI injection work

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:12:44PM +0200, Jan Kiszka wrote: Changes in this version: - reworked patch 2, 4 and 5 according to review - restored clearing of vm_entry_intr_info_field - no longer read idt_vectoring_info_field from VMCS - removed check of idt_vectoring_info_field on

Re: [PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Jan Kiszka
On 2013-04-14 17:23, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:12:49PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be injected has to be applied also on NMIs. The difference is that if NMI interception is on these events are

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 11:16:46AM -0400, Sasha Levin wrote: On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: On 04/12/2013 07:36 AM, Rusty Russell wrote: Sasha Levin sasha.le...@oracle.com writes: On 04/11/2013 12:36 PM, Will

Re: virtio-net mq vq initialization

2013-04-14 Thread Sasha Levin
On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: Initializing them only when they're actually needed will do the trick here. Not initializing, adding the buffers. In the current spec, initialization is always done before DRIVER_OK. Yeah, that's better, but we're going to need a spec

Re: PCI-passthrough on AMD - OpenVox A400P

2013-04-14 Thread Daniel Bareiro
On Tuesday, 09 April 2013 12:06:25 -0600, Alex Williamson wrote: I've a cluster (active/passive) with two KVM VM with Asterisk and Pacemaker+Corosync. I wonder if anyone tried to use a OpenVox A400P card from a virtual machine. My idea is to have both nodes accessing this card. I don't

Re: [PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 05:53:05PM +0200, Jan Kiszka wrote: On 2013-04-14 17:23, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:12:49PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be injected has to be applied also on NMIs.

Re: [PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Jan Kiszka
On 2013-04-14 18:18, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 05:53:05PM +0200, Jan Kiszka wrote: On 2013-04-14 17:23, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:12:49PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be

Re: [PATCH v4 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 06:35:14PM +0200, Jan Kiszka wrote: On 2013-04-14 18:18, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 05:53:05PM +0200, Jan Kiszka wrote: On 2013-04-14 17:23, Gleb Natapov wrote: On Sun, Apr 14, 2013 at 12:12:49PM +0200, Jan Kiszka wrote: From: Jan Kiszka

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread Borislav Petkov
On Sun, Apr 14, 2013 at 10:41:07AM +0300, Gleb Natapov wrote: Currently userspace assumes that that cpuid configuration returned by KVM_GET_SUPPORTED_CPUID is the optimal one. What we want here is a way for KVM to tell userspace that it can emulate movbe though it is not optimal. Ok, I don't

Re: PCI-passthrough on AMD - OpenVox A400P

2013-04-14 Thread Daniel Bareiro
On Sunday, 14 April 2013 13:16:30 -0300, Daniel Bareiro wrote: AFAIK, Athlon64 does not support AMD-Vi, which is the IOMMU support you'd need. I will investigate this issue and then tell you. Well... I was looking if BIOS options of the motherboad (M2N32 SLI Deluxe) had some reference to

[PATCH kvm-unit-tests v2 0/4] Have x86-run parse unittests.cfg

2013-04-14 Thread Cole Robinson
First two patches are trivial bits. Rest rewrites x86-run in python, which then makes it easy to parse unittests.cfg. This makes it simpler to invoke individual unittests the same way autotest does. Kevin has a similar series[1], but I'm reposting this for completeness. [1]

[PATCH kvm-unit-tests v2 1/4] .gitignore: Add *.flat and config.mak

2013-04-14 Thread Cole Robinson
--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index ed857b7..52655e1 100644 --- a/.gitignore +++ b/.gitignore @@ -1,8 +1,10 @@ +config.mak .gdbinit *.a *.d *.o *.flat +*.elf .pc patches .stgit-* -- 1.8.1.4 -- To unsubscribe from this list:

[PATCH kvm-unit-tests v2 2/4] x86/run-kvm-unit-tests: Drop it

2013-04-14 Thread Cole Robinson
Never appears to have done anything useful --- x86/run-kvm-unit-tests | 6 -- 1 file changed, 6 deletions(-) delete mode 100644 x86/run-kvm-unit-tests diff --git a/x86/run-kvm-unit-tests b/x86/run-kvm-unit-tests deleted file mode 100644 index fed925a..000 --- a/x86/run-kvm-unit-tests

[PATCH kvm-unit-tests v2 4/4] x86-run: Pull extra arguments from unittests.cfg

2013-04-14 Thread Cole Robinson
Some tests want extra arguments as enumerated in unittests.cfg, use them. unittests.cfg also has a few sections about invoking certains tests with different combinations of options, but x86-run doesn't do anything with that. --- x86-run | 20 1 file changed, 20 insertions(+)

[PATCH kvm-unit-tests v2 3/4] Rewrite x86-run in python

2013-04-14 Thread Cole Robinson
Main motivation here is in the next patch: getting access to ConfigParser for pulling extra options out of x86/unittests.cfg. Also makes it easier to get a consistent exit code on failure. --- v2: Don't drop manual examples from README README | 14 +--- x86-run | 113

Re: [PATCH kvm-unit-tests 5/5] x86-run: Pull extra arguments from unittests.cfg

2013-04-14 Thread Cole Robinson
On 04/14/2013 09:40 AM, Gleb Natapov wrote: On Mon, Mar 25, 2013 at 02:30:27PM -0400, Cole Robinson wrote: On 03/20/2013 03:06 PM, Marcelo Tosatti wrote: On Sun, Mar 17, 2013 at 07:58:56PM -0400, Cole Robinson wrote: On 03/17/2013 11:25 AM, Gleb Natapov wrote: On Fri, Mar 15, 2013 at

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 11:59:42AM -0400, Sasha Levin wrote: On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: Initializing them only when they're actually needed will do the trick here. Not initializing, adding the buffers. In the current spec, initialization is always done before

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread H. Peter Anvin
Just to interject here... all this is about host kernel vs userspace, correct? I.e. nothing that affects the guest. I assume that the guest sees CPUID and that is what is supported. Borislav Petkov b...@alien8.de wrote: On Sun, Apr 14, 2013 at 10:41:07AM +0300, Gleb Natapov wrote: Currently

[PATCH v5 5/6] KVM: nVMX: Fix conditions for NMI injection

2013-04-14 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The logic for checking if interrupts can be injected has to be applied also on NMIs. The difference is that if NMI interception is on these events are consumed and blocked by the VM exit. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread Borislav Petkov
On Sun, Apr 14, 2013 at 11:36:29AM -0700, H. Peter Anvin wrote: Just to interject here... all this is about host kernel vs userspace, correct? I.e. nothing that affects the guest. I assume that the guest sees CPUID and that is what is supported. Actually, currently the guest sees MOVBE in

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread H. Peter Anvin
That is what I mean yes... Borislav Petkov b...@alien8.de wrote: On Sun, Apr 14, 2013 at 11:36:29AM -0700, H. Peter Anvin wrote: Just to interject here... all this is about host kernel vs userspace, correct? I.e. nothing that affects the guest. I assume that the guest sees CPUID and that is

Re: [PATCH -v2] kvm: Emulate MOVBE

2013-04-14 Thread Borislav Petkov
On Sun, Apr 14, 2013 at 11:43:03AM +0300, Gleb Natapov wrote: +#define EmulateOnUD ((u64)1 46) /* emulate if unsupported by the host */ Just rename VendorSpecific to EmulateOnUD. The meaning is the same. done. +static int em_movbe(struct x86_emulate_ctxt *ctxt) +{ + switch

Re: kvm tools: why SDL window does not exit on poweroff?

2013-04-14 Thread Lin Ming
On Fri, Apr 12, 2013 at 5:17 PM, Pekka Enberg penb...@kernel.org wrote: On Fri, Apr 12, 2013 at 10:42 AM, Lin Ming min...@gmail.com wrote: I run poweroff or halt in SDL window, but the window does not exit although guest is already halted. But qemu can exit properly. Is it because hlt

Re: virtio-net mq vq initialization

2013-04-14 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Sun, Apr 14, 2013 at 11:59:42AM -0400, Sasha Levin wrote: On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: Initializing them only when they're actually needed will do the trick here. Not initializing, adding the buffers. In the current

[PATCH] virtio-spec: document virtio-9p

2013-04-14 Thread Sasha Levin
Add basic documentation for virtio-9p. I can expand more on device operation, but I don't think there's anything significant enough for the spec to be mentioned there. Please let me know if I'm wrong. Signed-off-by: Sasha Levin sasha.le...@oracle.com --- virtio-spec.lyx | 206

Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-14 Thread Paul Mackerras
On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote: Enabling this capability connects the vcpu to the designated in-kernel MPIC. Using explicit connections between vcpus and irqchips allows for flexibility, but the main benefit at the moment is that it simplifies the code -- KVM

Re: virtio-net mq vq initialization

2013-04-14 Thread Jason Wang
On 04/14/2013 11:16 PM, Sasha Levin wrote: On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: On 04/12/2013 07:36 AM, Rusty Russell wrote: Sasha Levin sasha.le...@oracle.com writes: On 04/11/2013 12:36 PM, Will Deacon wrote: Hello

Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-14 Thread Paul Mackerras
On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote: Enabling this capability connects the vcpu to the designated in-kernel MPIC. Using explicit connections between vcpus and irqchips allows for flexibility, but the main benefit at the moment is that it simplifies the code -- KVM