[kvm-devel] [PATCH] Remove a duplicated ia32e mode vm entry control

2007-08-01 Thread Li, Xin B
Remove a duplicated ia32e mode VM Entry control definition and use the proper one. Signed-off-by: Xin Li <[EMAIL PROTECTED]> diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 49635c4..10abb57 100644 --- a/drivers/kvm/vmx.c +++ b/drivers/kvm/vmx.c @@ -1107,7 +1107,7 @@ static void enter

Re: [kvm-devel] Storing command line options in qcow2 images

2007-08-01 Thread Andrew Walrond
Jorge Lucángeli Obes wrote: > > Ideas? Suggestions? I can send the patches for the functionality > that's implemented right now. > Great idea, and one I would certainly use. I guess then on Windoze I could associate .qcow2 files with qemu and just double click to run my VMs? It would be good to

[kvm-devel] [PATCH 1/2] Rename iova to va in vmx_init() for MSR Bitmap patch using

2007-08-01 Thread Yang, Sheng
In order to repetition using temporary variable iova in MSR Bitmap patch, I rename iova in vmx_init() to va. Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.

[kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-01 Thread Yang, Sheng
Add MSR Bitmap support in VMX so that some execution of RDMSR or WRMSR won't cause a VM exit. Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> Signed-off-by: Qing He <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c | 44 +++- drivers/kvm/vmx.h |3 +++ 2 files c

[kvm-devel] [PATCH 2/5] group all prefix decoding results in a structure called x86_prefix

2007-08-01 Thread Laurent Vivier
To be able to extract easily prefix decoding from x86_emulate_memop(), group all prefix decoding results in a structure called x86_prefix. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> -- - [EMAIL PROTECTED] -- "Software is hard" - Donald Knuth Index: kvm/dr

[kvm-devel] [PATCH 3/5] extract prefix decoding part from x86_emulate_memop() to x86_decode_prefix()

2007-08-01 Thread Laurent Vivier
Extract prefix decoding part from x86_emulate_memop() to x86_decode_prefix(). Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> -- - [EMAIL PROTECTED] -- "Software is hard" - Donald Knuth Index: kvm/drivers/kvm/x86_emulate.c =

[kvm-devel] [PATCH 4/5] vmx.c uses x86_decode_prefix() instead of get_io_count().

2007-08-01 Thread Laurent Vivier
vmx.c uses x86_decode_prefix() instead of get_io_count(). Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> -- - [EMAIL PROTECTED] -- "Software is hard" - Donald Knuth Index: kvm/drivers/kvm/vmx.c =

[kvm-devel] [PATCH 1/5] change ctxt.*_base to an array ctxt.base[X86EMUL_BASE_*]

2007-08-01 Thread Laurent Vivier
To be able to extract easily prefix decoding from x86_emulate_memop(), change ctxt.*_base to an array ctxt.base[X86EMUL_BASE_*] Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> -- - [EMAIL PROTECTED] -- "Software is hard" - Donald Knuth Index: kvm/drivers/kvm/k

Re: [kvm-devel] lapic2 branch

2007-08-01 Thread Zhao, Yunfeng
Hi,Dor I cannot reproduce your issue on my test env. I can boot 64bit fc6 guest against latest lapic2 branch. My test machine is a Harwitch+paxville. The host os is RHEL5, kernel is kvm lapic2 branch with kvm build-in. How about yours? Thanks Yunfeng >-Original Message- >From: Dor Laor [m

Re: [kvm-devel] can't get usb_add to work with kvm 33. [u]

2007-08-01 Thread Andreas Jellinghaus [c]
Am Dienstag, 31. Juli 2007 schrieb Avi Kivity: > Andreas Jellinghaus wrote: > > follow up: works fine when I run qemu with -usbdevice host:1.5 > > but adding it while running with usb_add in the qemu console does > > not work. shall I file a bug for this or something? > > Does it work with -no-kvm?

[kvm-devel] [PATCH 5/5] svm.c uses x86_decode_prefix() instead of io_address() and io_get_override().

2007-08-01 Thread Laurent Vivier
svm.c uses x86_decode_prefix() instead of io_address() and io_get_override(). *** WARNING: the SVM part has not been tested because I don't have any AMD system. *** Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> -- - [EMAIL PROTECTED] -- "Software is hard" -

[kvm-devel] PATCH 0/5] Consolidate the insb/outsb emulation into x86_emulate.c

2007-08-01 Thread Laurent Vivier
[PATCH 0/5] Consolidate the insb/outsb emulation into x86_emulate.c From the TODO, this serie of patches consolidates the insb/outsb emulation into x86_emulate.c. The prefix decoding part is extracted from x86_emulate_memop() and a function called x86_decode_prefix() is created. Then, in vmx.c, h

Re: [kvm-devel] KVM hangs on start

2007-08-01 Thread Gerb Stralko
what kernel are you using? is kvm built in kernel or as modules? what version of userspace kvm are you using? What is the ouput of cat /proc/cpuinfo? Thanks On 7/31/07, Scott Lerman <[EMAIL PROTECTED]> wrote: > I installed kvm from Ubuntu's 7.04 repository. When I try start kvm with > > kvm -m

[kvm-devel] Guest crashes on boot

2007-08-01 Thread Nijskens Raf
Since I use kernel 2.6.22.1-27.fc7 on my Fedora 7, my guests keeps crashing. I tried several versions of kvm, building it myself from source, installing it from rpm's, it's all the same. On my previous kernel 2.6.21-1.3228.fc7, it worked just fine. Sometimes I do get some output on crash: [EMAI

Re: [kvm-devel] KVM and RT

2007-08-01 Thread Gregory Haskins
On Wed, 2007-08-01 at 09:56 +0300, Avi Kivity wrote: > Gregory Haskins wrote: > > Hi Team, > > I don't know if anyone here also subscribes to linux-rt-users, but it > > seems as though Ingo et. al. rejected my modifications which ran the > > smp_call() in a thread (VFCIPI). > > It's not surpri

Re: [kvm-devel] can't get usb_add to work with kvm 33. [u]

2007-08-01 Thread Andreas Jellinghaus [c]
Am Dienstag, 31. Juli 2007 schrieb Avi Kivity: > Andreas Jellinghaus wrote: > > follow up: works fine when I run qemu with -usbdevice host:1.5 > > but adding it while running with usb_add in the qemu console does > > not work. shall I file a bug for this or something? > > Does it work with -no-kvm?

Re: [kvm-devel] KVM hangs on start

2007-08-01 Thread Scott Lerman
The kernel is the current Ubuntu version, /proc/version is Linux version 2.6.20-16-generic ([EMAIL PROTECTED]) (gcc version 4.1.2 (Ubuntu 4.1.2-0ubuntu4)) #2 SMP Thu Jun 7 20:19:32 UTC 2007 The kvm version is also the one from the Ubuntu repository, which apt calls 1:16-1ubuntu2. Not certain if t

[kvm-devel] [PATCH] remove duplicate assignment in kvm_setup_pio()

2007-08-01 Thread Laurent Vivier
Line 1809 of kvm_main.c is useless, value is overwritten in line 1815: 1809 now = min(count, PAGE_SIZE / size); 1810 1811 if (!down) 1812 in_page = PAGE_SIZE - offset_in_page(address); 1813 else 1814 in_page = offset_in_page(address) + size;

Re: [kvm-devel] preclean up for live migration

2007-08-01 Thread Dong, Eddie
Avi Kivity wrote: > Dong, Eddie wrote: >> Against lapic2 >> >> This is a pre-cleanup for in kernel irqchip live migration support. >> A guest may not have APIC but still have apic_base_msr be >> save/restored in current live migration framework. >> Updated. diff --git a/drivers/kvm/irq.h b/driv

Re: [kvm-devel] lapic2 branch

2007-08-01 Thread Dor Laor
>Hi,Dor >I cannot reproduce your issue on my test env. >I can boot 64bit fc6 guest against latest lapic2 branch. >My test machine is a Harwitch+paxville. >The host os is RHEL5, kernel is kvm lapic2 branch with kvm build-in. >How about yours? > >Thanks >Yunfeng My host is FC6 with latest 2.6.23-rc1

Re: [kvm-devel] web interface?

2007-08-01 Thread Paul J R
Being a command line guy myself, I tend to agree and disagree. You can wrap up nearly all of your day-to-day tasks in a gui (be it X, web or other). Your gui may only provide 75% of the functionality of your software. The kind of thing i had in mind was more like, "hey, we got a new initrd//ker

Re: [kvm-devel] web interface?

2007-08-01 Thread Paul J R
Yeah, i did look at libvirt and it remains an option. Originally this was all going to be built around xen (I got xen running on two servers and had it changing the number of cpu's in a pv host on the fly as well as live-migrate guests and went oo). But then kvm got merged and so i went thr

Re: [kvm-devel] web interface?

2007-08-01 Thread Daniel P. Berrange
On Thu, Aug 02, 2007 at 02:25:46AM +1000, Paul J R wrote: > Yeah, i did look at libvirt and it remains an option. Originally this > was all going to be built around xen (I got xen running on two servers > and had it changing the number of cpu's in a pv host on the fly as well > as live-migrate g

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Avi Kivity
Dimitry Golubovsky wrote: > I never was able to actually _reboot_ an OS in kvm - it just hangs. > > Please follow the usual bug report procedure: what host, what cpu, what guest, what kvm, how to reproduce. -- error compiling committee.c: too many arguments to function ---

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Avi Kivity
Dimitry Golubovsky wrote: > Avi, > > OK, I'll try to summarize that. However I'd also like to make a > feature request: a virtual character device (sort of a virtual serial > line) that the guest OS might use to communicate with the QEMU > monitor. That might solve many problems. > That exists

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Dimitry Golubovsky
Avi, OK, I'll try to summarize that. However I'd also like to make a feature request: a virtual character device (sort of a virtual serial line) that the guest OS might use to communicate with the QEMU monitor. That might solve many problems. Thank you On 8/1/07, Avi Kivity <[EMAIL PROTECTED]> w

Re: [kvm-devel] kvm very slow

2007-08-01 Thread Avi Kivity
Ulrich Schreiner wrote: > hi, > > im using a 64 bit fedora7 system with a quad-core processor to host > multiple virtual machines. > > my current kernel is: > > Linux testserver 2.6.22.1-27.fc7 #1 SMP Tue Jul 17 17:19:58 EDT 2007 > x86_64 x86_64 x86_64 GNU/Linux > > (now there is a 2.6.22.1-33.fc7

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Daniel P. Berrange
On Wed, Aug 01, 2007 at 12:48:51PM -0400, Dimitry Golubovsky wrote: > OK, I'll try to summarize that. However I'd also like to make a > feature request: a virtual character device (sort of a virtual serial > line) that the guest OS might use to communicate with the QEMU > monitor. That might solve

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Daniel P. Berrange
On Wed, Aug 01, 2007 at 01:06:22PM -0400, Dimitry Golubovsky wrote: > Daniel, > > On 8/1/07, Daniel P. Berrange <[EMAIL PROTECTED]> wrote: > > > Unless you whitelist which monitor commands it can run this would be a > > significant security hole. eg a guest could run > > > > 'usb_add disk /som

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Dimitry Golubovsky
Daniel, On 8/1/07, Daniel P. Berrange <[EMAIL PROTECTED]> wrote: > Unless you whitelist which monitor commands it can run this would be a > significant security hole. eg a guest could run > > 'usb_add disk /some/path' > > To get access to arbitrary files & disks from the host. > If we assume

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Anthony Liguori
Dimitry Golubovsky wrote: > Avi, > > OK, I'll try to summarize that. However I'd also like to make a > feature request: a virtual character device (sort of a virtual serial > line) that the guest OS might use to communicate with the QEMU > monitor. That might solve many problems. > Can you prov

Re: [kvm-devel] KVM hangs on start

2007-08-01 Thread Avi Kivity
Scott Lerman wrote: > The kernel is the current Ubuntu version, /proc/version is Linux > version 2.6.20-16-generic ([EMAIL PROTECTED]) (gcc version 4.1.2 (Ubuntu > 4.1.2-0ubuntu4)) #2 SMP Thu Jun 7 20:19:32 UTC 2007 > > The kvm version is also the one from the Ubuntu repository, which apt > call

Re: [kvm-devel] preclean up for live migration

2007-08-01 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >> Dong, Eddie wrote: >> >>> Against lapic2 >>> >>> This is a pre-cleanup for in kernel irqchip live migration support. >>> A guest may not have APIC but still have apic_base_msr be >>> save/restored in current live migration framework. >>> >>>

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Dimitry Golubovsky
Anthony, On 8/1/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > > feature request: a virtual character device (sort of a virtual serial > > line) that the guest OS might use to communicate with the QEMU > > monitor. That might solve many problems. > > > > Can you provide the use-case you're look

Re: [kvm-devel] [PATCH] Hoist push_irq/pop_irq into kvm.h

2007-08-01 Thread Avi Kivity
Rusty Russell wrote: > Everyone can use push_irq() and pop_irq(), so move them to common code. > > This area is a bit raw right now due to the lapic branch, so I'll drop this for now. Sorry as it is obviously a good one. We'll revisit this once that branch is merged. -- error compiling com

Re: [kvm-devel] [PATCH] Add and use pr_unimpl for standard formatting of unimplemented features.

2007-08-01 Thread Avi Kivity
Rusty Russell wrote: > All guest-invokable printks should be ratelimited to prevent malicious > guests from flooding logs. This is a start. > > Applied, thanks. I think my earlier report of a printk flood was caused by a different bug which was since fixed. -- error compiling committee.c:

Re: [kvm-devel] [PATCH] Remove unneeded kvm_dev_open and kvm_dev_release functions.

2007-08-01 Thread Avi Kivity
Rusty Russell wrote: > Devices don't need open or release functions. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > > Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net

Re: [kvm-devel] [PATCH] lmsw sets lower 16 bits of cr0, not just lower 4

2007-08-01 Thread Avi Kivity
Rusty Russell wrote: > According to my Intel manual, although lmsw only causes an exit when > trying to set the bottom 4 bits, it is supposed to set the bottom 16 > bits of cr0. > > Well, _my_ Intel manual (2A) says: > Loads the source operand into the machine status word, bits 0 through > 15

Re: [kvm-devel] [PATCH] remove duplicate assignment in kvm_setup_pio()

2007-08-01 Thread Avi Kivity
Laurent Vivier wrote: > Line 1809 of kvm_main.c is useless, value is overwritten in line 1815: > Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Splu

Re: [kvm-devel] kvm-intel kernel panicing 2.6.22 on T7200

2007-08-01 Thread Magic Boiz
Hello list I've just tried with the lastest kvm version available, 33, and now it works. I'm also using a new kernel, this time kernel version 2.6.22. Great job guys!! On 6/14/07, Magicboiz <[EMAIL PROTECTED]> wrote: > > Hello list, > > My laptop is a Toshiba Tecra S4 (ntel(R) Core(TM)2 CPU T72

Re: [kvm-devel] [PATCH] Remove stat_set from debugfs

2007-08-01 Thread Avi Kivity
Rusty Russell wrote: > We shouldn't define stat_set on the debug attributes, since that will > cause silent failure on writing: without a set argument, userspace > will get -EACCESS. > EAPPLIED, ETHANKS. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] kvm very slow

2007-08-01 Thread Ulrich Schreiner
dmesg|grep kvm SELinux: initialized (dev kvmfs, type kvmfs), uses genfs_contexts kvm: emulating exchange as write now booting into a F7 image, after the system is ready (and in idle): top PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND 14917 root 20 0 332m 71m 66m

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Anthony Liguori
Dimitry Golubovsky wrote: > Anthony, > > On 8/1/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > > >>> feature request: a virtual character device (sort of a virtual serial >>> line) that the guest OS might use to communicate with the QEMU >>> monitor. That might solve many problems. >>> >>>

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Dimitry Golubovsky
Anthony, On 8/1/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > Why are you using a setuid wrapper instead of just changing ownership of > /dev/kvm? Ownership of /dev/kvm is adjusted to be of group "kvm" (for example) and all users allowed to use it are in the same group. It is also necessary t

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Anthony Liguori
Dimitry Golubovsky wrote: > Anthony, > > On 8/1/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > > >> Why are you using a setuid wrapper instead of just changing ownership of >> /dev/kvm? >> > > Ownership of /dev/kvm is adjusted to be of group "kvm" (for example) > and all users allowed to

Re: [kvm-devel] Ways to exit from kvm on behalf of the quest system?

2007-08-01 Thread Anthony Liguori
Dimitry Golubovsky wrote: > Anthony, > > On 8/1/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > > >> Why are you using a setuid wrapper instead of just changing ownership of >> /dev/kvm? >> > > Ownership of /dev/kvm is adjusted to be of group "kvm" (for example) > and all users allowed to

Re: [kvm-devel] [PATCH] lmsw sets lower 16 bits of cr0, not just lower 4

2007-08-01 Thread Rusty Russell
On Wed, 2007-08-01 at 21:44 +0300, Avi Kivity wrote: > Rusty Russell wrote: > > According to my Intel manual, although lmsw only causes an exit when > > trying to set the bottom 4 bits, it is supposed to set the bottom 16 > > bits of cr0. > > > > > > Well, _my_ Intel manual (2A) says: > > > Lo

Re: [kvm-devel] KVM hangs on start

2007-08-01 Thread Scott Lerman
On 8/1/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > > Scott Lerman wrote: > > The kernel is the current Ubuntu version, /proc/version is Linux > > version 2.6.20-16-generic ([EMAIL PROTECTED]) (gcc version 4.1.2 (Ubuntu > > 4.1.2-0ubuntu4)) #2 SMP Thu Jun 7 20:19:32 UTC 2007 > > > > The kvm version

[kvm-devel] vnc improvement/bugfix patches from xen

2007-08-01 Thread Matthew Kent
After some issues with qemu vnc I happened upon the patches xen carries in xen-unstable.hg/tools/ioemu/patches/. After getting them to apply cleanly they have vastly improved my experience with vnc. I've taken these, omitted any that are xen specific or add extra features to qemu, and made some pa