Re: [kvm-devel] [PATCH] [RESEND] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch fixes 1a483ef4040ed380bf69d684783d06a617073256 so that the > parent PIC pointer is used to send the edge irq0 instead of the PIC pair and > that is an incompatible pointer type as reported in : > > qemu/hw/i8259.c: In function `pic_read_irq'

Re: [kvm-devel] [PATCH] - drivers/kvm/* - remove ptr comparisons to 0

2007-11-18 Thread Avi Kivity
Joe Perches wrote: > fix sparse warnings "Using plain integer as NULL pointer" > > Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all

Re: [kvm-devel] [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator

2007-11-18 Thread Avi Kivity
Sheng Yang wrote: > From f8aca5afbc018e71dc37d2e6001bcec376499939 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Fri, 16 Nov 2007 16:29:15 +0800 > Subject: [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator > > For CR2 is unreliable and unavailable in many condition, th

Re: [kvm-devel] Unhandled vm exit with old protected mode test

2007-11-18 Thread Avi Kivity
Jan Kiszka wrote: > Hi, > > running some oldish 286 protected mode demo in kvm, I came across this > bug of kvm-52: > > unhandled vm exit: 0x8021 vcpu_id 0 > ds (0010/ p 1 dpl 3 db 0 s 1 type 3 l 0 g 0 avl 0) > > ds.base must equal ds.sel<<4 when entering real-mode on Intel

Re: [kvm-devel] [PATCH] Move kvm_vcpu_ioctl_translation implementation to arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > This is the preparation for moving mmu code to arch. Since mmu code in > arch, translation functionality should be implemented for every arch. > Xiantao > > Applied, thanks. -- error compiling committee.c: too many arguments to function --

Re: [kvm-devel] [PATCH] Split kvm_create_vm and kvm_destory_vm to support arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > KVM Portability: Add two arch hooks to handle kvm_create_vm and > kvm destroy_vm. Now, just put io_bus init and destory in common. > 1. kvm_arch_create_vm > 2. kvm_arch_destroy_vm > This doesn't apply. Is it against some older codebase? -- error compiling committee.c

Re: [kvm-devel] [PATCH 2/2] KVM: x86 emulator: Discard CR2 in x86 emulator

2007-11-15 Thread Avi Kivity
Sheng Yang wrote: > On Thursday 15 November 2007 18:15:20 Avi Kivity wrote: > >> Sheng Yang wrote: >> >>> From 9cd9d5cde7341d5e9de41b1070cea7a98e7d8cc9 Mon Sep 17 00:00:00 2001 >>> From: Sheng Yang <[EMAIL PROTECTED]> >>> Date: Thu, 15 N

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > Jerone Young wrote: > >> This is a continuation of a conversation I have been having with Izik >> Eidus on IRC today. >> >> I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h >> would then include kvm.h and would be included by files like svm.c >> instea

Re: [kvm-devel] KVM Test result, kernel e29c643.. , userspace babe269..

2007-11-15 Thread Avi Kivity
Zhao, Yunfeng wrote: > Hi, all > This is today's KVM test result against kvm.git > e29c6434dcc64992a84e1a34a16ccfc9fd623621 and kvm-userspace.git > babe2696f21a84ae2da178d3f8173e6b50cdcc8b. > 64bit host will crash when boot guests. > > One new issue > 1. 64bit host crashes when booting guests > htt

Re: [kvm-devel] [PATCH] Move KVM_CHECK_EXTENSIONMove case to arch

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > Carsten Otte wrote: > >> Zhang, Xiantao wrote: >> >>> Moving KVM_CHECK_EXTENSION case to arch, since different archs should >>> have different capabilities. >>> >> I believe we want to keep the existence of the ioctl >> KVM_CHECK_EXTENSION common. Just the ex

Re: [kvm-devel] A question about KVM_SET_MEMORY_REGION ioctl

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > Currently, KVM_SET_MEMORY_REGION ioctl is put under arch, but its > implementation is in common code . From code logic, it seems very > strange. Maybe I missed some threads about its discuss, who can tell me > the story ? Thanks a lot! :) > KVM_SET_MEMORY_REGION is obso

Re: [kvm-devel] [PATCH v2] kvm: Fix accounting of interrupts during guest execution on s390

2007-11-15 Thread Avi Kivity
timer interrupt based, we have to subtract > hardirq_offset. > > Avi, Ingo, Laurent, feedback is welcome. > > CC: Ingo Molnar <[EMAIL PROTECTED]> > CC: Avi Kivity <[EMAIL PROTECTED]> > CC: Laurent Vivier <[EMAIL PROTECTED]> > Signed-off-by: Christian Born

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: >>> For driver/kvm/kvm.h, I have a proposal before in mailing list. In >>> my proposal, we can split x86-specific code of kvm.h into current >>> x86.h, and make code in kvm.h as common. Then, we rename kvm.h to >>> kvm_comm.h, and also rename x86.h to kvm-x86.h, and meantime

Re: [kvm-devel] [PATCH v2] kvm: Fix accounting of interrupts during guest execution on s390

2007-11-15 Thread Avi Kivity
Christian Borntraeger wrote: > Am Donnerstag, 15. November 2007 schrieb Avi Kivity: > >>> + if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0)) >>> > [...] > >> What's irq_count()? Is it defined

Re: [kvm-devel] [PATCH 2/2] KVM: x86 emulator: Discard CR2 in x86 emulator

2007-11-15 Thread Avi Kivity
Sheng Yang wrote: > From 9cd9d5cde7341d5e9de41b1070cea7a98e7d8cc9 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Thu, 15 Nov 2007 15:11:58 +0800 > Subject: [PATCH 2/2] KVM: x86 emulator: Discard CR2 in x86 emulator > > For CR2 is unreliable and unavailable in many condition

Re: [kvm-devel] smp_call_function_mask not defined in UP kernel.

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > > >>> BTW, Seems current KVM source doesn't support UP kernel without kvm >>> built-in, once we build kvm modules through kvm-userspace.git. >>> >>> >> Should work, though I never tested it. Are you seeing an error? >> > > Just have a test. Seems it can't

Re: [kvm-devel] [PATCH 1/2] KVM: x86 emulator: modify 'cmpxchg8b', 'lods', 'stos' to not depend on CR2

2007-11-15 Thread Avi Kivity
Sheng Yang wrote: > From c7b60a362930679e24df27e6a412cdbdf1a55f69 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Thu, 15 Nov 2007 14:52:28 +0800 > Subject: [PATCH 1/2] KVM: x86 emulator: modify 'cmpxchg8b', 'lods', 'stos' to > not depend on CR2 > > The current 'lods' and '

Re: [kvm-devel] smp_call_function_mask not defined in UP kernel.

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Zhang, Xiantao wrote: >> >>> Hi Avi, >>>smp_call_function_mask is introduced in latest commits, but not >>> defined in UP configuration. So, it will run into compile fail when >>> k

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Izik Eidus wrote: >>> >>> >> Have kvm.h include >> > what you mean by that? > > include/asm is a symlink to include/asm-$arch, and this is where arch-specific definitions are placed in Linux. -- Do not meddle in the internals of kernels, for they are subtle and quick to pani

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Jerone Young wrote: > This is a continuation of a conversation I have been having with Izik > Eidus on IRC today. > > I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h > would then include kvm.h and would be included by files like svm.c > instead of kvm.h. > > Which kvm.h ar

Re: [kvm-devel] Running kvmctl causing seg fault on intel vt system

2007-11-14 Thread Avi Kivity
Jerone Young wrote: > I just happened to be doing some stuff with kvmctl and I decided to run > todays git tree of kvmctl on my Thinkpad T61 (with 2.0 Core 2 Dou). I > get the following when trying to run "kvmctl test/x86/vmexit.flat": > > [EMAIL PROTECTED]:/home/jerone/work/kvm-userspace/user# ./k

Re: [kvm-devel] [ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared

2007-11-14 Thread Avi Kivity
uded from > kvm-52/kernel/ioapic.c:43: > include/asm/io_apic.h:65: error: expected identifier before numeric constant > make[2]: *** > [kernel/ioapic.o] Error 1 > make[1]: *** > [kernel] Error 2 > > Ouch. Committed the following: commit 26e6e6a8681f1041b61fccdf2fdf2aacb

Re: [kvm-devel] [PATCH] 3/5 Using kvm arch support instead ofkvm_x86_ops

2007-11-14 Thread Avi Kivity
Zhang, Xiantao wrote: > Also work. But the last two patches will have some warnings about hunk > offset. Had better use the attached patches which have been rebased. > Thanks -Xiantao > Okay, applied the lot. I supplied signoffs from previous iterations of this patchset, but please keep them

Re: [kvm-devel] [PATCH] kvm: Fix accounting of interrupts during guest execution on s390

2007-11-14 Thread Avi Kivity
Christian Borntraeger wrote: > Am Mittwoch, 14. November 2007 schrieb Ingo Molnar: > >> * Christian Borntraeger <[EMAIL PROTECTED]> wrote: >> >> >>> Avi, Ingo, Laurent, >>> >>> what do you think about the following patch? >>> >> fine to me. I guess this should mostly be a NOP to KVM,

Re: [kvm-devel] [PATCH] Make kvm_run more arch friendly

2007-11-14 Thread Avi Kivity
Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1194887893 21600 > # Node ID 41925cedf395c050fb31083eeda8a08bad609169 > # Parent a40de75e2bf823c092a20009c7646bf4c026a260 > Make kvm_run more arch friendly > > This patch creates hook kvm_arch_run in kvm_

Re: [kvm-devel] kvm -kernel option (x86_64)

2007-11-14 Thread Avi Kivity
Alexander Graf wrote: > Hi, > > I just tried to run a kernel directly using the -kernel option on VMX. > This worked with the kvm modules in the vanilla 2.6.24 kernel but > breaks on the recent git. I have not tried any version in between. > This really looks like the x86 emulator is broken. >

Re: [kvm-devel] [PATCH] 3/5 Using kvm arch support instead of kvm_x86_ops

2007-11-14 Thread Avi Kivity
Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Carsten Otte wrote: >> >>> I still do strongly agree with the general idea of this patch, and >>> most of the split comes out just right now. However, there is one >>> thing I'd like to pick o

Re: [kvm-devel] [PATCH] 5/5 Move-some-x86-specific-part-from-kvm_init-to-kvm_arch

2007-11-14 Thread Avi Kivity
Zhang, Xiantao wrote: > Carsten Otte wrote: > >> I think two other functionalities need to be moved to kvm_arch_init >> which are still in common: The call to kvm_mmu_set_nonpresent_ptes() >> and the creation of kvm_vcpu_cache. This can well be done after >> merging this patch. kvm_init looks ve

Re: [kvm-devel] [PATCH] 3/5 Using kvm arch support instead of kvm_x86_ops

2007-11-14 Thread Avi Kivity
Carsten Otte wrote: > I still do strongly agree with the general idea of this patch, and > most of the split comes out just right now. However, there is one > thing I'd like to pick on: > > decache_vcpus_on_cpu should be an arch callback, and rather than > kvm_arch_vcpu_decache. There's no reaso

Re: [kvm-devel] [Patch]0/5 Rebase to latest commits V2

2007-11-14 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi Carsten, > Sorry for inconience. Attached. > I'll wait a day for more comments and apply. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsore

Re: [kvm-devel] Spawning threads in KVM/QEMU

2007-11-14 Thread Avi Kivity
Dor Laor wrote: > Anthony Liguori wrote: > >> Hi, >> >> I've been experimenting with creating IO threads for the PV device >> drivers. Unfortunately, my experiments haven't gotten very far as QEMU >> tends to hang up a bit into booting the guest whenever I spawn a thread >> that does any sor

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-13 Thread Avi Kivity
david ahern wrote: > I removed the kvm/kvm-intel modules. qemu command line was: > > /usr/local/bin/qemu-system-x86_64 -boot c -localtime -hda > /opt/kvm/images/rhel5.img -m 1536 -smp 4 -net > nic,macaddr=00:0c:29:10:10:e8,model=rtl8139 -net > tap,ifname=tap0,script=/bin/true -monitor stdio -no-

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-13 Thread Avi Kivity
david ahern wrote: > First boot has been working fine since your patch this past weekend. It's > been subsequent boots that hang. > > I added -no-kvm-irqchip to qemu command line and did not add the noapic boot > option: it's hung at 'Starting udev' again but this time it's not consuming > CPU.

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-13 Thread Avi Kivity
david ahern wrote: > I let the host stay up for 90 minutes before loading kvm and starting a VM. > On the first reboot it hangs at 'Starting udev'. > > First reboot or first boot? I thought the problem was cold starting a VM. > I added 'noapic' to the kernel boot options, and it boots fine.

Re: [kvm-devel] [PATCH 2/3] kvmclock - the host part.

2007-11-13 Thread Avi Kivity
Dong, Eddie wrote: >>> >>> After thinking for a little while, you are theoretically right. >>> In the current state, we could even be preempted between all >>> operations ;-) Maybe after avi's suggestion of moving the call to it >>> it will end up in a preempt safe region, but anyway, it's safer to

Re: [kvm-devel] sti/mov ss emulation

2007-11-13 Thread Avi Kivity
Dong, Eddie wrote: > Avi: > Maybe I am wrong, but it looks like we didn't disable > interrupt_window_open & GUEST_INTERRUPTIBILITY_INFO if the emulation > path does sti or mov from SS emulation. > Too paranoea? > Well, we should. I doubt it would affect anything, but patches to im

Re: [kvm-devel] [PATCH 2/3] kvmclock - the host part.

2007-11-13 Thread Avi Kivity
Glauber de Oliveira Costa wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Dong, Eddie escreveu: > >>> +static void kvm_write_guest_time(struct kvm_vcpu *vcpu) +{ >>> + struct timespec ts; >>> + int r; >>> + >>> + if (!vcpu->clock_gpa) >>> + return; >>> + >>> + /* U

Re: [kvm-devel] [PATCH 2/3] kvmclock - the host part.

2007-11-13 Thread Avi Kivity
Glauber de Oliveira Costa wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Avi Kivity escreveu: > >> Glauber de Oliveira Costa wrote: >> >>> This is the host part of kvm clocksource implementation. As it does >>> not include clockeve

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-13 Thread Avi Kivity
Farkas Levente wrote: > Avi Kivity wrote: > >> Farkas Levente wrote: >> >>> Avi Kivity wrote: >>> >>> >>>> Farkas Levente wrote: >>>> >>>> >>>>> first of all fully update

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-13 Thread Avi Kivity
Farkas Levente wrote: > Avi Kivity wrote: > >> Farkas Levente wrote: >> >>> david ahern wrote: >>> >>> >>>> Can you post the full qemu command that gets launched in each case? >>>> >>>>

Re: [kvm-devel] Snapshot URL seems to be down

2007-11-13 Thread Avi Kivity
Ryan Harper wrote: > I can't seem to get to the nightly snapshot url: > > http://people.qumranet.com:/avi/snapshots/ > > > It's http://people.qumranet.com/avi/snapshots/ -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. --

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-13 Thread Avi Kivity
david ahern wrote: > With kvm-52 my 32-bit host running RHEL5.1 can start an RHEL 5 SMP guest only > once. Second and subsequent attempts hang. Removing kvm and kvm_intel modules > have no affect; I need to reboot the host to get an SMP guest to start. My > similarly configured 64-bit host does

Re: [kvm-devel] smp_call_function_mask not defined in UP kernel.

2007-11-13 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi Avi, >smp_call_function_mask is introduced in latest commits, but not > defined in UP configuration. So, it will run into compile fail when > kernel is configured without smp support. Please check and do the fix > :) > I see it in my include/linux/smp.h: > > #d

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-13 Thread Avi Kivity
Farkas Levente wrote: > Avi Kivity wrote: > >> Farkas Levente wrote: >> >>> first of all fully update your centos (a bit newer kernel), then i use >>> these packages: >>> http://www.lfarkas.org/linux/packages/centos/5/x86_64/ >>> use l

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-13 Thread Avi Kivity
Farkas Levente wrote: > david ahern wrote: > >> Can you post the full qemu command that gets launched in each case? >> > > this is the current running one, the only difference when smp set is -smp 4: > > root 3270 10.3 25.8 2213976 2111868 ? Sl 16:20 30:35 > /usr/bin/qemu-kvm -M

Re: [kvm-devel] Activating Windows Vista with KVM

2007-11-12 Thread Avi Kivity
Haydn Solomon wrote: > I'm able to install Windows vista 32 bit ok, however when I try to > activate online, it seems to start the process ok but then fails with > the following error. > > "A problem occurred when Windows tried to activate. Error code > 0x80072F78" > > Any help would be apprecia

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-12 Thread Avi Kivity
Farkas Levente wrote: > first of all fully update your centos (a bit newer kernel), then i use > these packages: > http://www.lfarkas.org/linux/packages/centos/5/x86_64/ > use libvirtd and virt-manager too and start the guests from there. and > start them manually paralell (i used to reboot the hos

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Avi Kivity
Daniel P. Berrange wrote: > On Sat, Nov 10, 2007 at 09:20:36PM -0600, Anthony Liguori wrote: > >> This patch implements a very naive virtio block device backend in QEMU. >> There's a lot of room for future optimization. We need to merge a -disk >> patch >> before we can provide a mechanism to

[kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-12 Thread Avi Kivity
Small fixes and updates. Changes from kvm-51: - fix efer reload host crash on T2600 and similar processors - revert sleepy interrupt injection - fixes "Fault when IDT_Vectoring" - atomically inject real-mode interrupts - wbinvd exiting on newer Intel processors (Eddie Dong) - fixes real-time

[kvm-devel] KVM fixes for 2.6.24-rc2

2007-11-12 Thread Avi Kivity
Linus, Please pull the tree at git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus Containing some fairly critical fixes for 2.6.24's KVM, including hard host hangs on AMD. Avi Kivity (5): KVM: x86 emulator: fix 'push imm8' emulation KVM: SVM: Fix

Re: [kvm-devel] [PATCH]3/5 Using kvm_arch prefix to define functions, and replace

2007-11-12 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: > >> For the present discussion, I agree, but in general we should be >> prepared to accept some no-op callouts. >> > > Oh sure, I don't mind those. We'll have plenty of them, where other > architectu

Re: [kvm-devel] [RFC] "large" memory support for guests

2007-11-12 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch applies to kvm-51 and correct all compilation warnings > because of mismatching types for ram related variables and that were left > behind after the changes to add support for more than 2GB of memory for 32bit > guests. > Please use corre

Re: [kvm-devel] [PATCH] Fix typo in qemu-img which prevented compressed images from being created

2007-11-12 Thread Avi Kivity
Theodore Ts'o wrote: > This fix was cherry picked from the qemu CVS via > > cvs diff -r1.21 -r1.22 qemu-img.c > > I'll pull qemu-cvs real soon to get this and a bunch of other fixes. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] KVM Test result, kernel a798c61.. , userspace 5d6ea6b..

2007-11-12 Thread Avi Kivity
Zhao, Yunfeng wrote: > Old issues: > One blocker issue for PAE host: > 1. Cannot boot guests on PAE host > https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1828760&group_id=180599 > This one is a new issue, it blocks testing on PAE host. > I just pushed a fix for this. -- error c

Re: [kvm-devel] [PATCH] [v2] Fix declerations that should be in kvm-common.h & not in kvm-x86.h

2007-11-12 Thread Avi Kivity
Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1194560092 21600 > # Node ID 10991ad11487e51d327430a1a61e0d63021caf7b > # Parent 026c26ab068482aaf17deaf8cd73c1ff1db3806b > [v2] Fix declerations that should be in kvm-common.h & not in kvm-x86.h > > The

Re: [kvm-devel] KVM Test result, kernel a798c61.. , userspace 5d6ea6b..

2007-11-12 Thread Avi Kivity
Zhao, Yunfeng wrote: > 4. Error "Fault when IDT_Vectoring" while running 64bit UP vista and smp > 64bit windows guests > https://sourceforge.net/tracker/index.php?func=detail&aid=1816460&group_id=180599&atid=893831 > > This should be fixed now. I reverted the patches that introduced it and i

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-12 Thread Avi Kivity
Farkas Levente wrote: > >> Guest is clean FC6 x86_64 >> > > can you recheck it with 1 clean centos-5 x86_64 and one centos-5 i386 > both have 2GB ram and in your case 2 vcpu and try to start the guest > parallel? > > if it's still works for you then the only difference will be the > hardware o

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-12 Thread Avi Kivity
nce on large multicores. On a dual code it's basically equivalent to mainline, I guess it's okay for four-way, but above four-way you will need either mainline or a better smp_call_function_mask() (which is nontrivial but doable). > david > > > Avi Kivity wrote: > >>

Re: [kvm-devel] Cannot install Win XP on AMD X2 with kvm-51

2007-11-12 Thread Avi Kivity
Amit Shah wrote: > On Monday 12 November 2007 12:22:39 Alexey Eremenko wrote: > >> This is strange, because I have XP on AMD-64 working fine on KVM-51. >> > > A pre-installed VM works just fine. The problem is with the installation. > Does > the installation succeed for you as well with k

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-11 Thread Avi Kivity
Farkas Levente wrote: >> >>> With that change, kvm-51 compiles. I am still seeing 32-bit SMP guests >>> hang on boot for both 32-bit and 64-bit hosts (again running RHEL5.1). >>> >>> >> I still don't. Can you test the attached patch? >> > > can you tell us which cpu, memory, host an

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-11 Thread Avi Kivity
david ahern wrote: In RHEL 5.1 defines: #define CPU_TASKS_FROZEN0x0010 #define CPU_ONLINE_FROZEN (CPU_ONLINE | CPU_TASKS_FROZEN) #define CPU_DEAD_FROZEN (CPU_DEAD | CPU_TASKS_FROZEN) which means in kvm-51/kernel/external-module-compat.h the '#ifndef CPU_TASKS_FROZEN' needs to have

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-11 Thread Avi Kivity
Farkas Levente wrote: > Avi Kivity wrote: > >> Farkas Levente wrote: >> >>> Avi Kivity wrote: >>> >>> >>>> If you're having trouble on AMD systems, please try this out. >>>> >>>> &

Re: [kvm-devel] git-clone error?

2007-11-11 Thread Avi Kivity
Avi Kivity wrote: > Chen Xi wrote: > >> Hi everybody, >> >> I'm trying to clone the repository: >> >> git-clone http://www.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git kvm >> >> Fail on this: >> error: Couldn't get >> htt

Re: [kvm-devel] KVM Test result, kernel 1805646.. , userspace c79baa60.

2007-11-11 Thread Avi Kivity
Zhao, Yunfeng wrote: > Old issues: > Five Windows issues: > 2. Cannot boot 64bit Vista > "-no-kvm-irqchip" has the same issue. And "-no-kvm" gets blue screen. > https://sourceforge.net/tracker/index.php?func=detail&aid=1812072&group_ > id=180599&atid=893831 > This ought to be fixed now (some bu

Re: [kvm-devel] git-clone error?

2007-11-11 Thread Avi Kivity
Chen Xi wrote: > Hi everybody, > > I'm trying to clone the repository: > > git-clone http://www.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git kvm > > Fail on this: > error: Couldn't get > http://www.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git/refs/heads/kvm-updates > for heads/kvm-updates >

Re: [kvm-devel] rsyncing to Guest Ubuntu System

2007-11-11 Thread Avi Kivity
Clive Stewell wrote: > I have been testing KVM for eventual use in a production server > environment and am running into some trouble when I attempt to rsync my > data from the current production system to the test system. > Specifically, whenever I hit a large file, the guest freezes and I get

Re: [kvm-devel] [PATCH]3/5 Using kvm_arch prefix to define functions, and replace

2007-11-11 Thread Avi Kivity
Carsten Otte wrote: > Hollis Blanchard wrote: > >> On Thu, 2007-11-08 at 14:49 +0100, Carsten Otte wrote: >> >>> Zhang, Xiantao wrote: >>> +void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu); +void kvm_arch_vcpu_decache(struct kvm_vcpu *vcpu); +void kvm_arch_vcpu_load(stru

Re: [kvm-devel] [PATCH]3/5 Using kvm_arch prefix to definefunctions, and replace

2007-11-11 Thread Avi Kivity
Zhang, Xiantao wrote: > >> - hardware enable/disable/setup/unsetup/check_processor_compat does >> not make any sense for us: all CPUs that have been sold since the >> 1970s have proper hardware virtualization, and there's nothing to >> enable - it just works. >> > OK, Maybe we can move them t

Re: [kvm-devel] Add WBINVD exit support

2007-11-11 Thread Avi Kivity
Dong, Eddie wrote: > Add wbinvd VM Exit support to prepare for pass-through > device cache emulation and also enhance real time > responsibility. > > Applied, thanks. For our real-time users, when will processors supporting this be available? -- error compiling committee.c: too m

Re: [kvm-devel] Cannot install Win XP on AMD X2 with kvm-51

2007-11-11 Thread Avi Kivity
Amit Shah wrote: > On Friday 09 November 2007 22:49:18 Werner Opriel wrote: > >> Version: >> kvm-50 and kvm-51 >> >> Problem: >> I am not able to install a Win XP SP2 guest. >> The Guest always crashes while installing Windows XP devices at T-37 >> minutes with a blue-screen and IRQL_NOT_LES_OR_

Re: [kvm-devel] [PATCH 2/3] kvmclock - the host part.

2007-11-11 Thread Avi Kivity
Glauber de Oliveira Costa wrote: > This is the host part of kvm clocksource implementation. As it does > not include clockevents, it is a fairly simple implementation. We > only have to register a per-vcpu area, and start writting to it periodically. > > Missing live migration support (a way f

Re: [kvm-devel] [PATCH] Fix building of kvmctl

2007-11-11 Thread Avi Kivity
Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1194551969 21600 > # Node ID c08b2667a95ecd85effb1d5f5d84e235f9e8d6cc > # Parent d6fa0d16fa60ee5083877fec698b69cea840d0b0 > Fix building of kvmctl > > This patch creates the make rule needed to for the li

Re: [kvm-devel] [PATCH] Fix declerations that should be in kvm-common.h & not in kvm-x86.h

2007-11-11 Thread Avi Kivity
Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1194543880 21600 > # Node ID f87e6f60ddd69cb0ee4e0bbcaed657d2f12311ce > # Parent d6fa0d16fa60ee5083877fec698b69cea840d0b0 > Fix declerations that should be in kvm-common.h & not in kvm-x86.h > > During th

Re: [kvm-devel] Bug: cpu0 unhandled rdmsr: 0x1900 and inject_general_protection

2007-11-11 Thread Avi Kivity
TJ wrote: > Avi, thanks. The patch fixes the issue for the XO image and there are no > more MSR read errors. > > I'm still not sure why when starting the image with kvm enabled the > drawing of the GRUB screen is so painfully slow, but without kvm it is > fast. > > Grub probably uses one of the

Re: [kvm-devel] [PATCH 11 of 17] Move msrs functions to libkvm-x86.c

2007-11-11 Thread Avi Kivity
Hollis Blanchard wrote: > On Thu, 2007-11-08 at 07:54 +0200, Avi Kivity wrote: > >> Carlo Marcelo Arenas Belon wrote: >> >>> On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote: >>> >>> >>>> Move msrs funct

Re: [kvm-devel] [RFC] virtio-blk PCI backend

2007-11-11 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >>> There's no reason that the PIO operations couldn't be handled in the >>> kernel. You'll already need some level of cooperation in userspace >>> unless you plan on implementing the PCI bus in kernel spa

Re: [kvm-devel] [PATCH 1/3] include files for kvmclock

2007-11-11 Thread Avi Kivity
Gerd Hoffmann wrote: >> +/* >> + * Guest has page alignment and padding requirements. At the host, it will >> + * only lead to wasted space at the vcpu struct. For this reason, the struct >> + * is not anonymous >> + */ >> +union kvm_hv_clock { >> +struct kvm_hv_clock_s { >> +u64 ts

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-11 Thread Avi Kivity
Farkas Levente wrote: > Avi Kivity wrote: > >> If you're having trouble on AMD systems, please try this out. >> > > this version worse than kvm-50:-( > setup: > - host: > - Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz > - Intel S3000AHV >

Re: [kvm-devel] [ANNOUNCE] kvm-51 release

2007-11-11 Thread Avi Kivity
david > > > Farkas Levente wrote: > >> Avi Kivity wrote: >> >>> If you're having trouble on AMD systems, please try this out. >>> >> this version worse than kvm-50:-( >> setup: >> - host: >> - Intel(R) Core(TM)2 Qua

Re: [kvm-devel] [RFC] virtio-blk PCI backend

2007-11-08 Thread Avi Kivity
Anthony Liguori wrote: > +case VIRTIO_PCI_QUEUE_NOTIFY: > +if (val < VIRTIO_PCI_QUEUE_MAX) > +virtio_ring_kick(vdev, &vdev->vq[val]); > +break; > I see you're not using hypercalls for this, presumably for compatibility with

Re: [kvm-devel] [RFC] virtio-blk PCI backend

2007-11-08 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: > >> Anthony Liguori wrote: >> >>> Avi Kivity wrote: >>> >>>> Anthony Liguori wrote: >>>> >>>> >>>>> +case VIRTIO_PCI_QUEUE_NOTIFY: >

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-08 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >> If a pci device is capable of dma (or issuing interrupts), it will be >> useless with pv pci. > > Hrm, I think we may be talking about different things. Are you > thinking that the driver I posted allows you to do PCI pas

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-08 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >> >>> This is a PCI device that implements a transport for virtio. It >>> allows virtio >>> devices to be used by QEMU based VMMs like KVM or Xen. >>> >>>

Re: [kvm-devel] [RFC] virtio-blk PCI backend

2007-11-08 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >> >>> +case VIRTIO_PCI_QUEUE_NOTIFY: >>> +if (val < VIRTIO_PCI_QUEUE_MAX) >>> +virtio_ring_kick(vdev, &vdev->vq[val]); >>> +break; >>>

Re: [kvm-devel] Bug: cpu0 unhandled rdmsr: 0x1900 and inject_general_protection

2007-11-08 Thread Avi Kivity
TJ wrote: Trying to run the latest OLPC XO guest image with kvm-intel on 2.6.22 x86_64 (Ubuntu Gutsy) on a T7200 there are critical problems which don't occur if kvm-intel is not loaded/used. The same issue affects kvm-48, kvm-50 and kvm-51. I don't see these problems with Gutsy or Windows gues

[kvm-devel] [PATCH 5/5] KVM: SVM: Intercept the 'invd' and 'wbinvd' instructions

2007-11-08 Thread Avi Kivity
'invd' can destroy host data, and 'wbinvd' allows the guest to induce long (milliseconds) latencies. Noted by Ben Serebrin. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/svm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/d

[kvm-devel] [PATCH 0/5] KVM fixes for 2.6.24-rc2

2007-11-08 Thread Avi Kivity
I intend to submit the following patchset shortly for mainline. All fixes are for fairly serious issues, including host crashes. Several will go into -stable as well. Please review. drivers/kvm/svm.c | 18 ++ drivers/kvm/x86_emulate.c | 26 ++

[kvm-devel] [PATCH 1/5] KVM: x86 emulator: fix 'push imm8' emulation

2007-11-08 Thread Avi Kivity
'push imm8' found itself in the wrong switch somehow, so it is never executed. This fixes Windows 2003 installation. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(

[kvm-devel] [PATCH 3/5] KVM: SVM: Defer nmi processing until switch to host state is complete

2007-11-08 Thread Avi Kivity
If we stgi() too soon, nmis can reach the processor even though interrupts are disabled, catching it in a half-switched state. Delay the stgi() until we're done switching. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/svm.c |8 1 files changed, 4 inser

[kvm-devel] [PATCH 2/5] KVM: SVM: Fix SMP with kernel apic

2007-11-08 Thread Avi Kivity
AP processor needs to reset to the SIPI vector, not normal INIT. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/svm.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c index 729f1cd..3910358 100644 --- a/drive

[kvm-devel] [PATCH 4/5] KVM: x86 emulator: invd instruction

2007-11-08 Thread Avi Kivity
Emulate the 'invd' instruction (opcode 0f 08). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index da0cdd5..33b1814 1006

Re: [kvm-devel] [PATCH] make msrs functions public for x86

2007-11-08 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > This patch partially reverts 9105435f46ca4e110237eae57272e4f5deaf8dd6 so that > kvm_msr_list, kvm_get_msrs and kvm_set_msrs are again public and visible in > userspace for x86 as they are used by qemu-kvm > Applied, thanks. -- error compiling committee.c: t

Re: [kvm-devel] SMP support on AMD64

2007-11-07 Thread Avi Kivity
Alexey Eremenko wrote: > Hi Avi, > > Speaking of AMD host - with KVM-51 it doesn't crashes anymore ! > > But there is still fonts rendering problem with Fedora7/ 32-bit guests. > > Can you update the relevant bug trackers? Please add xpdyinfo output as well. -- Do not meddle in the internals

Re: [kvm-devel] [PATCH 2/3] Put the virtio under the virtualization menu

2007-11-07 Thread Avi Kivity
Anthony Liguori wrote: > This patch moves virtio under the virtualization menu and changes virtio > devices to not claim to only be for lguest. > Perhaps the virt menu needs to be split into a host-side support menu and guest-side support menu. -- Do not meddle in the internals of kernels, fo

Re: [kvm-devel] [PATCH] Add accessor for kvm->vm_fd

2007-11-07 Thread Avi Kivity
Amit Shah wrote: >>> Introduce kvm_get_vm_fd to get the VM FD >>> >> What, so you can issue ioctls like there's no tomorrow? Add function >> wrappers for your ioctls instead. >> > > Hmm. this might not be needed now since the kvm_context moved to a .h file. > It > was a static in a .

Re: [kvm-devel] FreeBSD image hangs during boot

2007-11-07 Thread Avi Kivity
Aurelien Jarno wrote: > Well the IDE code hasn't changed a lot recently, so I checked the CVS > history and easily (first test) found the commit that causes the problem: > > Last AIO patch, by Vladimir N. Oleynik. > > http://cvs.savannah.nongnu.org/viewvc/qemu/hw/ide.c?root=qemu&r1=1.64&r2=1.65 > >

Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI device passthrough support

2007-11-07 Thread Avi Kivity
Amit Shah wrote: > This patch introduces support for device passthrough > from the host to a paravirtualized guest. > > A new command-line option, -passthrough is added. > For example, to invoke it for an Ethernet device sitting at > PCI bus:dev.fn 04:08.0 with host IRQ 18, use this: > > -passthrou

Re: [kvm-devel] [PATCH] Add accessor for kvm->vm_fd

2007-11-07 Thread Avi Kivity
Amit Shah wrote: > With the declaration in libkvm.h this time: > > >From 8313b87bcab415746e6eed86ac3f5b6c562b9764 Mon Sep 17 00:00:00 2001 > From: Amit Shah <[EMAIL PROTECTED]> > Date: Thu, 8 Nov 2007 00:13:07 +0530 > Subject: [PATCH] Add accessor for kvm->vm_fd > > Introduce kvm_get_vm_fd to get t

Re: [kvm-devel] [RFC] virtio-blk PCI backend

2007-11-07 Thread Avi Kivity
Anthony Liguori wrote: > +case VIRTIO_PCI_QUEUE_NOTIFY: > + if (val < VIRTIO_PCI_QUEUE_MAX) > + virtio_ring_kick(vdev, &vdev->vq[val]); > + break; > I see you're not using hypercalls for this, presumably for compatibility with -no-kvm. Well I think I have a solution: advert

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-07 Thread Avi Kivity
Anthony Liguori wrote: > This is a PCI device that implements a transport for virtio. It allows virtio > devices to be used by QEMU based VMMs like KVM or Xen. > > Didn't see support for dma. I think that with Amit's pvdma patches you can support dma-capable devices as well without too much fu

<    14   15   16   17   18   19   20   21   22   23   >