Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Duncan Parsons
Alexander Klenin wrote: On Mon, Apr 20, 2009 at 09:29, Mattias Gaertner nc-gaert...@netcologne.de wrote: Theoretically you can define 'hint' very generic: some message about a pascal source. But then the term 'hint' becomes almost meaningless But you propose to define 'figure' as an even

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Duncan Parsons
Marc Weustink wrote: Mattias Gaertner wrote: On Sun, 19 Apr 2009 20:28:31 +1100 Alexander Klenin kle...@gmail.com wrote: 4b) Add 'Unsorted procedures' similar to 'unsorted members' I rarely have seen units where all procedure are sorted alphabetically. Then you have never

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Mattias Gaertner
On Mon, 20 Apr 2009 09:08:33 + (UTC) Duncan Parsons laza...@dsparsons.co.uk wrote: [...] Maybe it should be 'Go figure(s)'... So what have we got so far? Figures Statistics Style Hints Analytics Metrics Formatting .. Well, it's kinda all of them.. Whilst it isn't a very 'hip

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Martin Friebe
Mattias Gaertner wrote: On Mon, 20 Apr 2009 12:14:18 +1100 Alexander Klenin kle...@gmail.com wrote: (4g) again seems simple, but 'auto-fixing' can in this can make things _worse_ by hiding the problem. Consider the code (idented by '~' characters): for i := 0 to High(A) do ~~if A[i]

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Mattias Gärtner
Zitat von Martin Friebe laza...@mfriebe.de: [...] So the code explorer can scan for lines 'do' and 'then' lines where the following line is indented less or equal. Of course some programmers will switch off the equal. while a nice idea, even this is not that easy ~~if a = 1 then

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 20:50, Mattias Gaertner nc-gaert...@netcologne.de wrote: About (4d) - single line begin..end Maybe you can give an example when this is not about code formatting? I just mean that removing non-whitespace characters is not formally 'formatting'. I agree it is gray area.

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 21:27, Martin Friebe laza...@mfriebe.de wrote: Mattias Gaertner wrote: So the code explorer can scan for lines 'do' and 'then' lines where the following line is indented less or equal. Of course some programmers will switch off the equal. while a nice idea, even this

Re: [Lazarus] Figures in code explorer

2009-04-20 Thread Mattias Gaertner
On Tue, 21 Apr 2009 09:25:13 +1100 Alexander Klenin kle...@gmail.com wrote: On Mon, Apr 20, 2009 at 20:50, Mattias Gaertner nc-gaert...@netcologne.de wrote: About (4d) - single line begin..end Maybe you can give an example when this is not about code formatting? I just mean that

[Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
New figures feature is an excellent addition, thanks Paul and Mattias! It already motivated be to fix some stylistic problems in one of my projects ;-) A few questions/suggestions for improvement: 1) Where did the name came from? It is totally meaningless for me. Maybe 'Stylistic notes' or

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Mattias Gaertner
On Sun, 19 Apr 2009 20:28:31 +1100 Alexander Klenin kle...@gmail.com wrote: New figures feature is an excellent addition, thanks Paul and Mattias! It already motivated be to fix some stylistic problems in one of my projects ;-) A few questions/suggestions for improvement: 1) Where did

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Paul Ishenin
Alexander Klenin wrote: 4f) Add 'Line loo long' with default limit of perhaps 80 or 90 characters. Not a bad figure to add. I would choose only bigger limit - 100-120 chars. Best regards, Paul Ishenin. ___ Lazarus mailing list

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
On Sun, Apr 19, 2009 at 22:02, Mattias Gaertner nc-gaert...@netcologne.de wrote: A few questions/suggestions for improvement: 1) Where did the name came from? It is totally meaningless for me. See http://www.askoxford.com/concise_oed/figure?view=uk Hm. I'll quote that: figure, noun: 1 a

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Martin Friebe
Alexander Klenin wrote: On Sun, Apr 19, 2009 at 22:02, Mattias Gaertner nc-gaert...@netcologne.de wrote: A few questions/suggestions for improvement: 1) Where did the name came from? It is totally meaningless for me. See http://www.askoxford.com/concise_oed/figure?view=uk

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Marco van de Voort
On Mon, Apr 20, 2009 at 12:00:07AM +1100, Alexander Klenin wrote: However, the checks I suggested are very far from 'nazi' level. Truly nazi-checks would include things as 'begin statement never/always alone on the line', Funny that you think that is extreme. begin always alone on a newline,

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Paul Ishenin
Martin Friebe wrote: Hm, while some of them probably are most likely to be used to find possible issues, there is no need to see them as an problem indicator only. So point 1 is correct as they are a collecion of numbers figures Still, maybe they would be better named as statistics?

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 01:10, Marco van de Voort mar...@stack.nl wrote: On Mon, Apr 20, 2009 at 12:00:07AM +1100, Alexander Klenin wrote: However, the checks I suggested are very far from 'nazi' level. Truly nazi-checks would include things as 'begin statement never/always alone on the

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 01:28, Paul Ishenin webpi...@mail.ru wrote: Martin Friebe wrote: Hm, while some of them probably are most likely to be used to find possible issues, there is no need to see them as an problem indicator only. So point 1 is correct as they are a collecion of numbers

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Mattias Gaertner
On Mon, 20 Apr 2009 02:03:30 +1100 Alexander Klenin kle...@gmail.com wrote: On Mon, Apr 20, 2009 at 01:28, Paul Ishenin webpi...@mail.ru wrote: Martin Friebe wrote: Hm, while some of them probably are most likely to be used to find possible issues, there is no need to see them as an

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Marc Weustink
Mattias Gaertner wrote: On Sun, 19 Apr 2009 20:28:31 +1100 Alexander Klenin kle...@gmail.com wrote: 4b) Add 'Unsorted procedures' similar to 'unsorted members' I rarely have seen units where all procedure are sorted alphabetically. Then you have never seen mine. In order to find way in

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Marc Weustink
Paul Ishenin wrote: Alexander Klenin wrote: 4f) Add 'Line loo long' with default limit of perhaps 80 or 90 characters. Not a bad figure to add. I would choose only bigger limit - 100-120 chars. What about right margin setting ? Marc ___ Lazarus

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Mattias Gaertner
On Mon, 20 Apr 2009 00:00:07 +1100 Alexander Klenin kle...@gmail.com wrote: On Sun, Apr 19, 2009 at 22:02, Mattias Gaertner nc-gaert...@netcologne.de wrote: A few questions/suggestions for improvement: 1) Where did the name came from? It is totally meaningless for me. See

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Mattias Gaertner
On Mon, 20 Apr 2009 00:56:06 +0200 Marc Weustink m...@dommelstein.net wrote: Mattias Gaertner wrote: On Sun, 19 Apr 2009 20:28:31 +1100 Alexander Klenin kle...@gmail.com wrote: 4b) Add 'Unsorted procedures' similar to 'unsorted members' I rarely have seen units where all

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 09:29, Mattias Gaertner nc-gaert...@netcologne.de wrote: Theoretically you can define 'hint' very generic: some message about a pascal source. But then the term 'hint' becomes almost meaningless But you propose to define 'figure' as an even more generic thing: number,

Re: [Lazarus] Figures in code explorer

2009-04-19 Thread Alexander Klenin
On Mon, Apr 20, 2009 at 10:19, Mattias Gaertner nc-gaert...@netcologne.de wrote: 4c) Add 'Empty begin..end' block, probably with the same check for the comments as in (4a) 4d) Add 'Single statement in begin..end block' 4e) Add 'Too many nesting statements' and 'Too many nesting