Re: Viewrendered3 Read For Beta Testing

2020-03-29 Thread Edward K. Ream
On Sat, Mar 28, 2020 at 11:13 PM lewis wrote: > I do have nbformat installed. > Since build eb6f4ec070 I get this in console log: > -- > Empty setting name in False > set parent @settings > Leo 6.3-devel, devel branch, build eb6f4ec070 > 2020-03-28 18:58:09 -0500 > VR3: *** No Markdown

Re: Viewrendered3 Read For Beta Testing

2020-03-28 Thread lewis
I do have nbformat installed. Since build eb6f4ec070 I get this in console log: -- Empty setting name in False set parent @settings Leo 6.3-devel, devel branch, build eb6f4ec070 2020-03-28 18:58:09 -0500 VR3: *** No Markdown *** VR3: *** No nbformat [snip] However I do not get that

Re: Viewrendered3 Read For Beta Testing

2020-03-16 Thread Edward K. Ream
On Sun, Mar 15, 2020 at 4:23 PM Thomas Passin wrote: Now that's funny. I just imported qt_gui.py in my Leo outline - the same > qt_gui.py file I zipped up for you - and neither pyflakes nor pylint found > anything to complain about. Maybe your pylint settings are different from > mine. I

Re: Viewrendered3 Read For Beta Testing

2020-03-16 Thread Edward K. Ream
On Sun, Mar 15, 2020 at 3:46 PM Thomas Passin wrote: > > > On Sunday, March 15, 2020 at 11:35:26 AM UTC-4, Edward K. Ream wrote: >> >> >> In future, please run pylint on your code. It will catch these kinds of >> things. >> > > I thought that pyflakes was doing that job now. > Pyflakes and

Re: Viewrendered3 Read For Beta Testing

2020-03-15 Thread Thomas Passin
On Sunday, March 15, 2020 at 4:46:22 PM UTC-4, Thomas Passin wrote: > > > > On Sunday, March 15, 2020 at 11:35:26 AM UTC-4, Edward K. Ream wrote: >> >> >> In future, please run pylint on your code. It will catch these kinds of >> things. >> > > I thought that pyflakes was doing that job now.

Re: Viewrendered3 Read For Beta Testing

2020-03-15 Thread Thomas Passin
On Sunday, March 15, 2020 at 11:35:26 AM UTC-4, Edward K. Ream wrote: > > > In future, please run pylint on your code. It will catch these kinds of > things. > I thought that pyflakes was doing that job now. It didn't say anything. Well, I didn't run it on qt_gui.py, because I just copied it

Re: Viewrendered3 Read For Beta Testing

2020-03-15 Thread Edward K. Ream
On Sun, Mar 15, 2020 at 9:32 AM Thomas Passin wrote: > > > On Sunday, March 15, 2020 at 7:08:32 AM UTC-4, Edward K. Ream wrote: >> >> >> Your version of qt_gui was way out of date, so I made the change by hand. >> The new code is: >> > > That's so strange, because I got it right from the devel

Re: Viewrendered3 Read For Beta Testing

2020-03-15 Thread Thomas Passin
On Sunday, March 15, 2020 at 7:08:32 AM UTC-4, Edward K. Ream wrote: > > > Your version of qt_gui was way out of date, so I made the change by hand. > The new code is: > That's so strange, because I got it right from the devel branch and just added my little bit of code. Anyway, thanks

Re: Viewrendered3 Read For Beta Testing

2020-03-15 Thread Edward K. Ream
​On Sat, Mar 14, 2020 at 3:58 PM Thomas Passin wrote: Thank you, Edward! > ​You're welcome. Recent revs merge the VR3 code into both the 6.2 branch and the devel branch. This should be safe because the only real change to leo\plugins\qt_gui.py was to the ​<< load viewrendered plugin >>

Re: Viewrendered3 Read For Beta Testing

2020-03-14 Thread Thomas Passin
Thank you, Edward! On Saturday, March 14, 2020 at 4:16:39 PM UTC-4, Edward K. Ream wrote: > > > > On Sat, Mar 14, 2020 at 11:05 AM Thomas Passin > wrote: > >> Thanks, Ed, >> >> I have not been able to get my repo on GitHub straightened out so that >> you won't see large diffs in qt_gui.py from

Re: Viewrendered3 Read For Beta Testing

2020-03-14 Thread Edward K. Ream
On Sat, Mar 14, 2020 at 11:05 AM Thomas Passin wrote: > Thanks, Ed, > > I have not been able to get my repo on GitHub straightened out so that you > won't see large diffs in qt_gui.py from all those formatting changes. So > I've attached a zip file with my files and the new

Re: Viewrendered3 Read For Beta Testing

2020-03-14 Thread Thomas Passin
Thanks, Ed, I have not been able to get my repo on GitHub straightened out so that you won't see large diffs in qt_gui.py from all those formatting changes. So I've attached a zip file with my files and the new plugins/viewrendered3 directory that contains two stylesheets. Would you please

Re: Viewrendered3 Read For Beta Testing

2020-03-14 Thread Edward K. Ream
On Fri, Mar 13, 2020 at 9:48 PM Thomas Passin wrote: > I think that between the time that I modified qt_gui.py and the time that > I pushed it to my clone of the devel branch, that it got reformatted in > origin/ devel. Between my VR3 branch and my devel branch, I see many > changes in the file

Re: Viewrendered3 Read For Beta Testing

2020-03-13 Thread Thomas Passin
I think that between the time that I modified qt_gui.py and the time that I pushed it to my clone of the devel branch, that it got reformatted in origin/ devel. Between my VR3 branch and my devel branch, I see many changes in the file diffs - I'm sure they are what Edward noticed - that are

Re: Viewrendered3 Read For Beta Testing

2020-03-12 Thread Thomas Passin
On Thursday, March 12, 2020 at 6:31:16 PM UTC-4, Matt Wilkie wrote: > > Git's branching and merging always confuses me, let alone across forks. > Meaning: don't feel bad, you're not alone! > > The network graph at https://github.com/tbpassin/leo-editor/network shows > your VR3 branch (top black

Re: Viewrendered3 Read For Beta Testing

2020-03-12 Thread Matt Wilkie
Git's branching and merging always confuses me, let alone across forks. Meaning: don't feel bad, you're not alone! The network graph at https://github.com/tbpassin/leo-editor/network shows your VR3 branch (top black line for me) as starting in the middle of nowhere, not rooted to any Leo

Re: Viewrendered3 Read For Beta Testing

2020-03-12 Thread Thomas Passin
All right, I'll see if I can do that. The thing is, I was already working with a clone of the Leo repo. Github Desktop clones the repo, sets the clone up on your own Github account, and sets it to point to the Leo repo as the upstream - all those actions you would otherwise do one by one, if

Re: Viewrendered3 Read For Beta Testing

2020-03-12 Thread Edward K. Ream
On Wed, Mar 11, 2020 at 12:04 PM Thomas Passin wrote: > > Can I just clone a branch of the Leo repo? I thought - at least, using > Github Desktop - that I could only get the whole repo with all its branches. > I never use Github desktop, so I couldn't say. Yes, I recommend cloning the Leo

Re: Viewrendered3 Read For Beta Testing

2020-03-11 Thread Thomas Passin
My clone of the Leo repository already has a devel branch that I had just updated. Github Desktop seemed confused when I went to merge my private VR3 into my private devel, so I just copied the modified files into devel instead. Could that have caused what you see? The actual changes to

Re: Viewrendered3 Read For Beta Testing

2020-03-11 Thread Edward K. Ream
On Wed, Mar 11, 2020 at 8:33 AM Thomas Passin wrote: > I updated devel on my repo a few minutes ago to be level with Leo's devel, > and merged VR3 into it. Then I made a new pull request. I hope that's > what you need. Otherwise I'll need a bit of handholding... > Something's not right.

Re: Viewrendered3 Read For Beta Testing

2020-03-11 Thread Thomas Passin
I updated devel on my repo a few minutes ago to be level with Leo's devel, and merged VR3 into it. Then I made a new pull request. I hope that's what you need. Otherwise I'll need a bit of handholding... On Wednesday, March 11, 2020 at 5:36:17 AM UTC-4, Edward K. Ream wrote: > > On Tue, Mar

Re: Viewrendered3 Read For Beta Testing

2020-03-11 Thread Edward K. Ream
On Tue, Mar 10, 2020 at 12:30 PM Thomas Passin wrote: > I have submitted a pull request for the Vewrendered3 plugin. > Please resubmit this PR with it based on devel, not master. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To