[libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Anton Khirnov
It's not available on all systems and using argc/argv directly does not complicate the code much. --- libavcodec/fft-test.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 75941a1..b06b92c 100644

[libav-devel] [PATCH 4/4] graph2dot: don't use getopt().

2012-07-09 Thread Anton Khirnov
It's not available on all systems and using argc/argv directly does not complicate the code much. --- tools/graph2dot.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/tools/graph2dot.c b/tools/graph2dot.c index 6ea2f32..0a90878 100644 ---

[libav-devel] [PATCH 2/4] dct-test: don't use getopt().

2012-07-09 Thread Anton Khirnov
It's not available on all systems and using argc/argv directly does not complicate the code much. --- libavcodec/dct-test.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c index 4647642..ed9ea4e 100644 ---

[libav-devel] [PATCH 3/4] motion-test: don't use getopt().

2012-07-09 Thread Anton Khirnov
It's not available on all systems and using argc/argv directly actually makes the code simpler. --- libavcodec/motion-test.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/motion-test.c b/libavcodec/motion-test.c index bf63182..2c3a0af 100644 ---

Re: [libav-devel] [PATCH] libx264: support aspect ratio switching

2012-07-09 Thread Anton Khirnov
On Sun, 8 Jul 2012 17:33:47 +0300, Jan Ekström jee...@gmail.com wrote: From: JULIAN GARDNER joo...@btinternet.com --- libavcodec/libx264.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) Looks ok. -- Anton Khirnov ___

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t size) +{ +if (size = 0 || nmemb = INT_MAX / size) +return NULL; +return av_mallocz(nmemb * size); +} The places where this

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 18:44 +0200, Luca Barbato wrote: I thought you were making it an inline. Normal function - smaller binaries. Also, this patch already existed - less work. /Tomas ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: --- I also took the liberty to get rid of floats in matrix generation. Shouldn't that go in a separate patch? --- /dev/null +++ b/libavcodec/mss34dsp.c @@ -0,0 +1,113 @@ + +#include avcodec.h +#include mss34dsp.h stdint.h

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: --- I also took the liberty to get rid of floats in matrix generation. Shouldn't that go in a separate patch? It was mostly a matter of interface change.

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 06:42:36AM +0200, Kostya Shishkov wrote: --- Changelog |1 + doc/general.texi |2 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 + libavcodec/tscc2.c | 382 +++

[libav-devel] [PATCH 3/5] x86/cpu: implement support for xgetbv through intrinsics

2012-07-09 Thread Martin Storsjö
From: Ronald S. Bultje rsbul...@gmail.com --- This one needs double underscores. configure |2 ++ libavutil/x86/cpu.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/configure b/configure index a1506c9..76ad4c7 100755 --- a/configure +++ b/configure @@ -1169,6

[libav-devel] [PATCH 4/5] x86/cpu: implement support for cpuid through intrinsics

2012-07-09 Thread Martin Storsjö
From: Ronald S. Bultje rsbul...@gmail.com --- This one needs double underscores as well. configure |2 ++ libavutil/x86/cpu.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/configure b/configure index 76ad4c7..0f51523 100755 --- a/configure +++ b/configure

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 11:13:47AM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: --- I also took the liberty to get rid of floats in matrix generation. Shouldn't that go in

Re: [libav-devel] MSVC intrinsics patchset

2012-07-09 Thread Martin Storsjö
On Mon, 9 Jul 2012, Diego Biurrun wrote: These are the intrinsics patches for MSVC, cleaned up to account for review comments. Note that I do not have MSVC, so testing is welcome. Except for patches 3 and 4 which needed double underscores, the rest of this seems to work fine in practice.

Re: [libav-devel] [PATCH] configure: check for math functions without linking to -lm also.

2012-07-09 Thread Martin Storsjö
On Sun, 8 Jul 2012, Ronald S. Bultje wrote: Hi, On Sun, Jul 8, 2012 at 12:48 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Sat, Jul 7, 2012 at 3:57 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 07/07/2012 6:09 PM, Diego Biurrun

[libav-devel] [PATCH 1/2] configure: Support filtering ldflags just as normal cflags

2012-07-09 Thread Martin Storsjö
--- I'm not sure I managed to add it to all the necessary places, but msvc builds with this seem to work as intended. configure |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8af4b4..9409524 100755 --- a/configure +++ b/configure @@

[libav-devel] [RFC PATCH 2/2] msvc: Map -llibname to libname.lib

2012-07-09 Thread Martin Storsjö
--- This isn't intended for main git at the moment, but is included to illustrate how filter_ldflags could be used for translating -lfoo to foo.lib. With this in place, no faux -lm is added to the command line. configure |9 + 1 file changed, 9 insertions(+) diff --git a/configure

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

2012-07-09 Thread Diego Biurrun
On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: --- a/Changelog +++ b/Changelog @@ -31,6 +31,7 @@ version next: - Microsoft ATC Screen decoder +- Microsoft Expression Encoder Screen decoder --- a/doc/general.texi +++ b/doc/general.texi @@ -533,6 +533,8 @@ following

Re: [libav-devel] [PATCH 3/4] motion-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: It's not available on all systems and using argc/argv directly actually makes the code simpler. --- libavcodec/motion-test.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/motion-test.c

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: It's not available on all systems and using argc/argv directly does not complicate the code much. --- libavcodec/fft-test.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavcodec/fft-test.c

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Måns Rullgård
Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t size) +{ +if (size = 0 || nmemb = INT_MAX / size) +return NULL; +return

Re: [libav-devel] [PATCH 1/2] configure: Support filtering ldflags just as normal cflags

2012-07-09 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: --- I'm not sure I managed to add it to all the necessary places, but msvc builds with this seem to work as intended. configure |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8af4b4..9409524

Re: [libav-devel] [PATCH 2/5] lavu: use intrinsics for emms on systems lacking inline asm support

2012-07-09 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: From: Ronald S. Bultje rsbul...@gmail.com Signed-off-by: Diego Biurrun di...@biurrun.de --- configure|3 +++ libavutil/internal.h |7 +-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/configure b/configure

Re: [libav-devel] [PATCH 1/5] configure: Change the rdtsc check to a linker check

2012-07-09 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: A compile-only test could succeed with an implicit function declaration. Also move the check to the x86 section; rdtsc is x86-only. --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index

[libav-devel] [PATCH] fate: Fix running fate without zlib

2012-07-09 Thread Martin Storsjö
This conditionally enables the tests that depend on having zlib present. --- configure |2 ++ tests/Makefile|3 ++- tests/fate/lossless-video.mak |4 ++-- tests/fate/qt.mak |2 +- tests/fate/screen.mak |4 ++--

[libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
--- libavcodec/mss3.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c index 25163c6..50a8268 100644 --- a/libavcodec/mss3.c +++ b/libavcodec/mss3.c @@ -26,6 +26,7 @@ #include avcodec.h #include bytestream.h +#include

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Luca Barbato
On 07/09/2012 01:42 PM, Kostya Shishkov wrote: --- libavcodec/mss3.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) seems fine, is the table always defined? Otherwise add the proper deps. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: On 07/09/2012 01:42 PM, Kostya Shishkov wrote: --- libavcodec/mss3.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) seems fine, is the table always defined? Otherwise add the proper deps. It's

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: On 07/09/2012 01:42 PM, Kostya Shishkov wrote: --- libavcodec/mss3.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) seems

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:10 PM, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: On 07/09/2012 01:42 PM, Kostya Shishkov wrote: --- libavcodec/mss3.c | 14 ++ 1 files changed, 2

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t size) +{ +if (size = 0 || nmemb = INT_MAX / size) +

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:28 PM, Luca Barbato wrote: On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t size) +{ +

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 07/09/2012 02:28 PM, Luca Barbato wrote: On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Mon, 2012-07-09 at 14:28 +0200, Luca Barbato wrote: On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:49 PM, Måns Rullgård wrote: Luca Barbato lu_z...@gentoo.org writes: On 07/09/2012 02:28 PM, Luca Barbato wrote: On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin

Re: [libav-devel] [PATCH] mem: Don't abort on av_malloc(0) in debug mode

2012-07-09 Thread Luca Barbato
On 04/11/2012 09:34 AM, Martin Storsjö wrote: This makes the behaviour consistent between debug and release mode. --- libavutil/mem.c |2 -- 1 file changed, 2 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index bf1a542..43fe3f6 100644 --- a/libavutil/mem.c +++

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:53 PM, Tomas Härdin wrote: What about something along the lines of #define av_malloc_array(nmemb, size) \ av_malloc((size = 0 || nmemb = INT_MAX / size) ? 0 : nmemb * size); Wouldn't a static inline be better, should someone do something like

Re: [libav-devel] [PATCH 1/4] rtsp: add mode=receive/record header parse code

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c |8 libavformat/rtsp.h |3 +++ 2 files changed, 11 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 76b5df8..551884b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -749,6 +749,14

Re: [libav-devel] [PATCH 2/4] rtsp: move rtsp_read_close

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtspdec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 063e825..6226f41 100644 --- a/libavformat/rtspdec.c +++

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c |6 +++--- libavformat/rtsp.h |5 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 551884b..d4206a1 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@

[libav-devel] [PATCH] mem: introduce av_calloc and av_malloc_array

2012-07-09 Thread Luca Barbato
Both function ease allocating large arrays implementing the overflow check inside it Since pointless memsetting a potential large array is a waste of time the av_malloc_array is provided along as the av_calloc version. --- Hopefully this will make everybody happy. libavutil/mem.h | 36

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 6226f41..b603792 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -22,6 +22,7 @@ #include libavutil/avstring.h #include libavutil/intreadwrite.h #include

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Luca Barbato
On 07/09/2012 03:53 PM, Martin Storsjö wrote: +av_strlcatf(message, sizeof(message), Server: LibAVFormat %d\r\n, While at it Libavformat instead of LibAVFormat lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel

[libav-devel] [PATCH] mem: introduce av_calloc and av_malloc_array

2012-07-09 Thread Luca Barbato
Both function ease allocating large arrays implementing the overflow check inside it Since pointless memsetting a potential large array is a waste of time the av_malloc_array is provided along with the av_calloc version. --- libavutil/mem.h | 38 -- 1 files

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: +static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) +{ +RTSPState *rt = s-priv_data; +RTSPMessageHeader request = { 0 }; +int ret = 0; +char url[1024]; +RTSPStream *rtsp_st; +

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Mon, 9 Jul 2012, Luca Barbato wrote: On 07/09/2012 03:53 PM, Martin Storsjö wrote: +av_strlcatf(message, sizeof(message), Server: LibAVFormat %d\r\n, While at it Libavformat instead of LibAVFormat If he switches to LIBAVFORMAT_IDENT, that (actually Lavf) will be a part of it

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c | 30 ++- libavformat/rtsp.h | 12 ++ libavformat/rtspcodes.h | 14 ++ libavformat/rtspdec.c | 549 --- 4 files changed, 566 insertions(+), 39 deletions(-) diff --git

Re: [libav-devel] ppc{,64}-darwin FATE failures

2012-07-09 Thread Sean McGovern
On Monday, July 9, 2012, Thibaut VARENE vare...@debian.org wrote: On Fri, Jul 6, 2012 at 4:32 PM, Sean McGovern gsean...@gmail.com wrote: On Thursday, July 5, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern gsean...@gmail.com writes: On Thursday, July 5, 2012, Måns Rullgård

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: +static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) +{ +RTSPState *rt = s-priv_data; +RTSPMessageHeader request = { 0 }; +int ret = 0; +char url[1024]; +RTSPStream *rtsp_st; +

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Luca Barbato
On 07/09/2012 04:00 PM, Martin Storsjö wrote: On Mon, 9 Jul 2012, Luca Barbato wrote: On 07/09/2012 03:53 PM, Martin Storsjö wrote: +av_strlcatf(message, sizeof(message), Server: LibAVFormat %d\r\n, While at it Libavformat instead of LibAVFormat If he switches to LIBAVFORMAT_IDENT,

Re: [libav-devel] [PATCH] tcp: add initial timeout limit for incomming connections

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/tcp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 6a65860..e5be465 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -43,7 +43,7 @@ static int

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Derek Buitenhuis
On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure platform. Just make the tests conditional. -1 I'd hardly call one of the most (if not the most) widely used platforms

Re: [libav-devel] [PATCH 3/3] RTMPE protocol support

2012-07-09 Thread Martin Storsjö
Hi, When sending a patchset, please send it all as one git send-email invocation, or if not, please set the in-reply-to header properly, so that the mails get chained together properly. Now the 3 patches in this series have ended up as 3 different mail threads, making it much harder to locate

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 10:35:46AM -0400, Derek Buitenhuis wrote: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure platform. Just make the tests conditional. -1

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Luca Barbato
On 07/09/2012 04:35 PM, Derek Buitenhuis wrote: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure platform. Just make the tests conditional. -1 I'd hardly call one

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

2012-07-09 Thread Jason Garrett-Glaser
On Sun, Jul 8, 2012 at 9:42 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Sun, Jul 08, 2012 at 08:17:10PM -0700, Jason Garrett-Glaser wrote: +#define UNQUANT(val, q) ((q * val + 0x80) 8) I'd call this DEQUANT, but that's just me. I don't have preferences here, so why not. +

Re: [libav-devel] [PATCH 3/3] RTMPE protocol support

2012-07-09 Thread Samuel Pitoiset
On Mon, Jul 9, 2012 at 4:45 PM, Martin Storsjö mar...@martin.st wrote: Hi, When sending a patchset, please send it all as one git send-email invocation, or if not, please set the in-reply-to header properly, so that the mails get chained together properly. Now the 3 patches in this series

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Derek Buitenhuis
On 09/07/2012 10:55 AM, Luca Barbato wrote: I don't know how you think that giving some kind of support for an utterly broken compiler makes it not an obscure platform. The fact that Chrome will be using it (and I bet Steam too) will instantly make it widely used. :P - Derek

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 02:19:27PM +0200, Luca Barbato wrote: On 07/09/2012 02:10 PM, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: On 07/09/2012 01:42 PM, Kostya Shishkov wrote: ---

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 11:17:17AM +0200, Diego Biurrun wrote: On Mon, Jul 09, 2012 at 11:13:47AM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: --- I also took the liberty

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-09 Thread Jordi Ortiz
Ok as well, but you might try to improve the commit message. You shouldn't try to cram everything into the first line - try to make that one as short as possible while still describing the commit. If you need to say more than that, add extra full sentences below. Would it be better

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 08:06:27AM -0700, Jason Garrett-Glaser wrote: On Sun, Jul 8, 2012 at 9:42 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Sun, Jul 08, 2012 at 08:17:10PM -0700, Jason Garrett-Glaser wrote: +#define UNQUANT(val, q) ((q * val + 0x80) 8) I'd call this

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-09 Thread Martin Storsjö
On Mon, 9 Jul 2012, Jordi Ortiz wrote: Ok as well, but you might try to improve the commit message. You shouldn't try to cram everything into the first line - try to make that one as short as possible while still describing the commit. If you need to say more than that, add extra full

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 11:46:17AM +0200, Diego Biurrun wrote: On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: --- a/Changelog +++ b/Changelog @@ -31,6 +31,7 @@ version next: - Microsoft ATC Screen decoder +- Microsoft Expression Encoder Screen decoder ---

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 06:48:08PM +0200, Kostya Shishkov wrote: On Mon, Jul 09, 2012 at 11:46:17AM +0200, Diego Biurrun wrote: On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: --- a/Changelog +++ b/Changelog @@ -31,6 +31,7 @@ version next: - Microsoft ATC

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-09 Thread Jordi Ortiz
Would it be better something like: ? - rtsp: convert rtsp_open_transport_ctx() to non-static. The RTSP listen mode, which is implemented in rtspdec.c, needs this functionality and in consequence more visibility for rtsp_open_transport_ctx() is needed. - You can make it even

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

2012-07-09 Thread Kostya Shishkov
On Sat, Jul 07, 2012 at 09:38:53AM -0700, Jason Garrett-Glaser wrote: [...] This should address most of your and Diego's comments. From fdd64b45b5e0ebf220ba39593d8bf9ff87083d8f Mon Sep 17 00:00:00 2001 From: Kostya Shishkov kostya.shish...@gmail.com Date: Sat, 7 Jul 2012 13:21:52 +0200 Subject:

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Alex Converse
On Mon, Jul 9, 2012 at 7:55 AM, Luca Barbato lu_z...@gentoo.org wrote: On 07/09/2012 04:35 PM, Derek Buitenhuis wrote: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Anton Khirnov
After some discussion on IRC I think I'll drop this set and we'll go back to the original Ronald's getopt() replacement, just moved to some less controversial place like compat/. I'll send a new patch tomorrow if nobody beats me to it. -- Anton Khirnov

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure platform. Just make the tests conditional. -1 Not OK with

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Alex Converse
On Mon, Jul 9, 2012 at 1:44 PM, Måns Rullgård m...@mansr.com wrote: Derek Buitenhuis derek.buitenh...@gmail.com writes: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Alex Converse alex.conve...@gmail.com writes: ob·scure adj \äb-ˈskyu̇r, əb-\ Definition of OBSCURE 1 a : dark, dim Sure, for some meanings of those words. b : shrouded in or hidden by darkness Definitely. 2 : not readily understood or clearly expressed; also : mysterious Oh yes. A

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Alex Converse alex.conve...@gmail.com writes: On Mon, Jul 9, 2012 at 1:44 PM, Måns Rullgård m...@mansr.com wrote: Derek Buitenhuis derek.buitenh...@gmail.com writes: On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only

[libav-devel] [PATCH] dct/fft-test: use a replacement getopt() if the system has none present.

2012-07-09 Thread Anton Khirnov
From: Ronald S. Bultje rsbul...@gmail.com This allows compiling and running these tests on systems lacking a built- in version of getopt(), such as MSVC. Signed-off-by: Anton Khirnov an...@khirnov.net --- compat/getopt.c | 84 + configure

[libav-devel] [PATCH 00/39] ALAC decoder improvements

2012-07-09 Thread Justin Ruggles
- Misc clean ups and fixes - Planar output - 32-bit decoding - multi-channel decoding Andrew D'Addesio (2): alac: simplify channel interleaving alac: multi-channel decoding support Justin Ruggles (37): caf: support either old or new style ALAC magic kuki chunk caf: fix 'pakt' chunk

[libav-devel] [PATCH 01/39] caf: support either old or new style ALAC magic kuki chunk

2012-07-09 Thread Justin Ruggles
--- libavformat/cafdec.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index d5ee9be..0475175 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -121,18 +121,36 @@ static int

[libav-devel] [PATCH 02/39] caf: fix 'pakt' chunk parsing

2012-07-09 Thread Justin Ruggles
according to the CAF specification: ... the value for mChunkSize can be greater than the actual valid content of the packet table chunk --- libavformat/cafdec.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index

[libav-devel] [PATCH 03/39] caf: use int64_t for num_packets

2012-07-09 Thread Justin Ruggles
It is used to store a value read by avio_rb64(). --- libavformat/cafdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index 6e5b2c8..64ec62f 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -168,8 +168,8 @@

[libav-devel] [PATCH 04/39] avformat: move 'chan' tag parsing to mov_chan.c to share with the CAF demuxer

2012-07-09 Thread Justin Ruggles
--- libavformat/cafdec.c |6 ++ libavformat/mov.c | 39 +-- libavformat/mov_chan.c | 44 libavformat/mov_chan.h | 11 +++ 4 files changed, 62 insertions(+), 38 deletions(-) diff --git

[libav-devel] [PATCH 05/39] alac: clean up and update comments leftover from reverse-engineering

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 49 ++--- 1 files changed, 18 insertions(+), 31 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index ab9fb81..699b86a 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -70,19 +70,16 @@ typedef struct {

[libav-devel] [PATCH 07/39] alac: reduce the number of parameters to bastardized_rice_decompress()

2012-07-09 Thread Justin Ruggles
Use the ALACContext fields directly instead. --- libavcodec/alac.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 4848ea2..8824ae8 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -107,13 +107,10 @@

[libav-devel] [PATCH 06/39] alac: cosmetics: rename some ALACContext parameters

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 127 ++--- 1 files changed, 63 insertions(+), 64 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 699b86a..4848ea2 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -37,7 +37,7 @@ * 8bit

[libav-devel] [PATCH 08/39] alac: limit the rice param before passing to decode_scalar()

2012-07-09 Thread Justin Ruggles
reduces the number of parameters to decode_scalar() and slightly simplifies the code --- libavcodec/alac.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 8824ae8..76ef499 100644 --- a/libavcodec/alac.c +++

[libav-devel] [PATCH 09/39] alac: cosmetics: reindent after last commit

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 76ef499..84f7e42 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -85,16 +85,16 @@ static inline int decode_scalar(GetBitContext *gb,

[libav-devel] [PATCH 10/39] alac: adjust conditions for updating entropy decoder history

2012-07-09 Thread Justin Ruggles
avoids some unnecessary arithmetic in certain situations --- libavcodec/alac.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 84f7e42..f27992d 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -131,11 +131,11 @@

[libav-devel] [PATCH 11/39] alac: eliminate 2 unneeded local variables in bastardized_rice_decompress()

2012-07-09 Thread Justin Ruggles
x_modified is just unnecessary, and final_val can be removed by simplifying the unsigned-to-signed conversion. --- libavcodec/alac.c | 23 +++ 1 files changed, 7 insertions(+), 16 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f27992d..2aab84c 100644

[libav-devel] [PATCH 12/39] alac: conditionally set sign_modifier to 1

2012-07-09 Thread Justin Ruggles
It is already unconditionally set to 0 prior to this, so we can modify it only when needed. --- libavcodec/alac.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 2aab84c..0aeb410 100644 --- a/libavcodec/alac.c +++

[libav-devel] [PATCH 13/39] alac: remove a duplicate local variable

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 0aeb410..74da253 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -130,7 +130,6 @@ static void bastardized_rice_decompress(ALACContext *alac,

[libav-devel] [PATCH 14/39] alac: make block_size signed

2012-07-09 Thread Justin Ruggles
It does not need to be unsigned. --- libavcodec/alac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 74da253..91c94d7 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -130,7 +130,7 @@ static void

[libav-devel] [PATCH 15/39] alac: use sizeof() in memset() instead of hardcoded data size

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 91c94d7..915b7eb 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -142,7 +142,8 @@ static void bastardized_rice_decompress(ALACContext *alac,

[libav-devel] [PATCH 16/39] alac: remove unneeded conditionals in predictor_decompress_fir_adapt()

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 915b7eb..23f437f 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -198,7 +198,6 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 17/39] alac: cosmetics: reindent after last commit

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 90 ++-- 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 23f437f..840c722 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -198,71 +198,71 @@ static void

[libav-devel] [PATCH 19/39] alac: reduce the number of local variables needed in lpc prediction

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 7e940fa..997362b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -203,28 +203,27 @@ static void

[libav-devel] [PATCH 18/39] alac: simplify 1st order prediction and reading of warm-up samples

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 18 +- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 840c722..7e940fa 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -185,25 +185,17 @@ static void

[libav-devel] [PATCH 20/39] alac: simplify lpc coefficient adaptation

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 41 ++--- 1 files changed, 10 insertions(+), 31 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 997362b..f48079c 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -205,6 +205,7 @@ static void

[libav-devel] [PATCH 21/39] alac: use index into buffer_out instead of incrementing the pointer

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f48079c..eeb888e 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -201,29 +201,29 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 23/39] alac: use sizeof() in memcpy() instead of hardcoded data size

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index e2a7d79..42dfdad 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -177,7 +177,8 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 22/39] alac: factor out loading of next decoded sample in LPC prediction

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index eeb888e..e2a7d79 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -206,15 +206,16 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 24/39] alac: factor out output_size check in predictor_decompress_fir_adapt()

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 42dfdad..474531b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -173,10 +173,10 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 25/39] alac: avoid using a double-negative when checking if the frame is compressed

2012-07-09 Thread Justin Ruggles
--- libavcodec/alac.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 474531b..f803f9a 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -298,7 +298,7 @@ static int alac_decode_frame(AVCodecContext *avctx, void

  1   2   >