Re: [libav-devel] [PATCH 29/39] alac: use AVPacket fields directly in alac_decode_frame()

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-dev

Re: [libav-devel] [PATCH 18/39] alac: simplify 1st order prediction and reading of warm-up samples

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c | 18 +- > 1 files changed, 5 insertions(+), 13 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list liba

Re: [libav-devel] [PATCH 13/39] alac: remove a duplicate local variable

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.o

Re: [libav-devel] [PATCH 10/39] alac: adjust conditions for updating entropy decoder history

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > avoids some unnecessary arithmetic in certain situations > --- > libavcodec/alac.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH 09/39] alac: cosmetics: reindent after last commit

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c | 16 > 1 files changed, 8 insertions(+), 8 deletions(-) > Looks ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list

Re: [libav-devel] [PATCH 08/39] alac: limit the rice param before passing to decode_scalar()

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > reduces the number of parameters to decode_scalar() and slightly simplifies > the code > --- > libavcodec/alac.c | 16 +++- > 1 files changed, 7 insertions(+), 9 deletions(-) Looks fine. lu -- Luca Barbato Gentoo/linux http://dev.g

[libav-devel] [PATCH 10/10] mxfdec: fix off by one error.

From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 3

[libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

From: Tomas Härdin Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 91015a9..3c1a47d 100644 --- a/libavformat/mxfdec.c +++ b/libav

[libav-devel] [PATCH 08/10] mxfdec: Let pkt->pts = mxf->current_edit_unit if intra-only

From: Tomas Härdin We cannot do this in general since we could be reading a file with B-frames while lacking an index. Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/li

[libav-devel] [PATCH 07/10] mxfdec: fix frame height vs field height confusion

From: Joseph Artsimovich Reviewed-by: Tomas Härdin Reveiwed-by: Baptiste Coudurier Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxf.h|8 libavformat/mxfdec.c | 33 - 2 files changed, 40 insertions(+), 1 dele

[libav-devel] [PATCH 06/10] mxfdec: Add intra_only flag to MXFTrack

From: Tomas Härdin This allows future assumptions to be made without affecting non-intra files. Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/libavformat/m

[libav-devel] [PATCH 05/10] mxfdec: Fix Avid AirSpeed files being misinterpreted as OP1a

From: Tomas Härdin The "ECs != 1 -> OP1a" assumption was wrong. Luckily, the file that triggered that behavior had two ECs, not zero. Hence distinguishing between them is simple in this case. Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c | 14 ++

[libav-devel] [PATCH 04/10] mxfdec: Truncate packets that extend past the next edit unit

From: Tomas Härdin This fixes rare cases where OPAtom may be treated as OP1a, causing all essence to be read into RAM. Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c | 64 ++--- 1 files changed, 49 insertio

[libav-devel] [PATCH 03/10] mxfdec: set pixel format for cdci picture formats

From: Philip de Nier The properties of the CDCI Descriptor are insufficient to specify the pixel format for uncompressed picture data. SMPTE 377-1 and RP224v10 have defined a set of picture coding labels to indicate what formatting was used. This patch uses 2 labels to detect UYVY422 or YUYV422

[libav-devel] Import mxfdec

I left out the timecode ones mxfdec: set track edit rate num/den in expected order mxfdec: detect uncomp pictures using essence container mxfdec: set pixel format for cdci picture formats mxfdec: Truncate packets that extend past the next mxfdec: Fix Avid AirSpeed files being misinterpreted mxfdec

[libav-devel] [PATCH 02/10] mxfdec: detect uncomp pictures using essence container ul

From: Philip de Nier This supports detection of uncompressed picture in files that didn't include a Picture Coding Label. The lables weren't available until SMPTE 377-1 and RP224v10 Reviewed-by: Baptiste Coudurier Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat

[libav-devel] [PATCH 01/10] mxfdec: set track edit rate num/den in expected order

From: Philip de Nier This matches the order used for the index table edit rate. Reviewed-by: Baptiste Coudurier Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfd

[libav-devel] [PATCH] mem: introduce av_malloc_array and av_mallocz_array

Both function ease allocating large arrays implementing the overflow check inside it. --- I'd rather be self consistent, pick what you like best. libavutil/mem.h | 37 +++-- 1 files changed, 35 insertions(+), 2 deletions(-) diff --git a/libavutil/mem.h b/libavu

Re: [libav-devel] [PATCH 07/39] alac: reduce the number of parameters to bastardized_rice_decompress()

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > Use the ALACContext fields directly instead. > --- > libavcodec/alac.c | 16 +--- > 1 files changed, 5 insertions(+), 11 deletions(-) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _

Re: [libav-devel] [PATCH 06/39] alac: cosmetics: rename some ALACContext parameters

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c | 127 > ++--- > 1 files changed, 63 insertions(+), 64 deletions(-) Fine for me. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero __

Re: [libav-devel] [PATCH 05/39] alac: clean up and update comments leftover from reverse-engineering

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavcodec/alac.c | 49 ++--- > 1 files changed, 18 insertions(+), 31 deletions(-) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero __

Re: [libav-devel] [PATCH 02/39] caf: fix 'pakt' chunk parsing

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > according to the CAF specification: > "... the value for mChunkSize can be greater than the actual valid content > of the packet table chunk" > --- > libavformat/cafdec.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) Ok. -- Lu

Re: [libav-devel] [PATCH 01/39] caf: support either old or new style ALAC magic kuki chunk

On 07/09/2012 11:23 PM, Justin Ruggles wrote: > --- > libavformat/cafdec.c | 26 ++ > 1 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c > index d5ee9be..0475175 100644 > --- a/libavformat/cafdec.c > +++ b/libav

Re: [libav-devel] [PATCH] dct/fft-test: use a replacement getopt() if the system has none present.

On 07/09/2012 11:12 PM, Anton Khirnov wrote: > From: "Ronald S. Bultje" > > This allows compiling and running these tests on systems lacking a built- > in version of getopt(), such as MSVC. > As long everybody is happy with it. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH] dvbsubdec: Always log into a context.

On 07/10/2012 01:07 AM, Alex Converse wrote: > --- > libavcodec/dvbsubdec.c | 29 - > 1 files changed, 16 insertions(+), 13 deletions(-) > Looks good. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ li

Re: [libav-devel] [PATCH 33/39] alac: use get_bits_long() in decode_scalar()

On Mon, Jul 9, 2012 at 2:24 PM, Justin Ruggles wrote: > allows for a larger sample size than MIN_CACHE_BITS > --- > libavcodec/alac.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/alac.c b/libavcodec/alac.c > index 5f2c8a0..0e62adb 100644 > --- a

[libav-devel] [PATCH] dvbsubdec: Always log into a context.

--- libavcodec/dvbsubdec.c | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index cc14622..f5fc7f2 100644 --- a/libavcodec/dvbsubdec.c +++ b/libavcodec/dvbsubdec.c @@ -318,7 +318,7 @@ static void

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

"Ronald S. Bultje" writes: > Hi, > > On Mon, Jul 9, 2012 at 12:44 PM, Anton Khirnov wrote: >> >> After some discussion on IRC I think I'll drop this set and we'll go >> back to the original Ronald's getopt() replacement, just moved to some >> less controversial place like compat/. >> >> I'll sen

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

Hi, On Mon, Jul 9, 2012 at 12:44 PM, Anton Khirnov wrote: > > After some discussion on IRC I think I'll drop this set and we'll go > back to the original Ronald's getopt() replacement, just moved to some > less controversial place like compat/. > > I'll send a new patch tomorrow if nobody beats m

Re: [libav-devel] [PATCH 04/39] avformat: move 'chan' tag parsing to mov_chan.c to share with the CAF demuxer

On Mon, Jul 9, 2012 at 2:23 PM, Justin Ruggles wrote: > --- > libavformat/cafdec.c |6 ++ > libavformat/mov.c | 39 +-- > libavformat/mov_chan.c | 44 > libavformat/mov_chan.h | 11 +++ >

Re: [libav-devel] [PATCH 03/39] caf: use int64_t for num_packets

On Mon, Jul 9, 2012 at 2:23 PM, Justin Ruggles wrote: > It is used to store a value read by avio_rb64(). > --- > libavformat/cafdec.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > OK ___ libav-devel mailing list libav-devel@libav.or

Re: [libav-devel] [PATCH 39/39] alac: cosmetics: general pretty-printing and comment clean up

On Mon, Jul 09, 2012 at 05:24:07PM -0400, Justin Ruggles wrote: > > --- a/libavcodec/alac.c > +++ b/libavcodec/alac.c > @@ -399,10 +384,11 @@ static int decode_element(AVCodecContext *avctx, void > *data, int ch_index, > /* not compressed, easy case */ > for (i = 0; i < alac->nb

[libav-devel] [PATCH 39/39] alac: cosmetics: general pretty-printing and comment clean up

--- libavcodec/alac.c | 49 ++--- 1 files changed, 18 insertions(+), 31 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 7ad6b42..0f6b3fd 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -56,14 +56,11 @@ #define MAX_CHAN

[libav-devel] [PATCH 38/39] alac: calculate buffer size outside the loop in allocate_buffers()

--- libavcodec/alac.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index cf95959..7ad6b42 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -500,9 +500,9 @@ static av_cold int alac_decode_close(AVCodecContext *avctx) sta

[libav-devel] [PATCH 37/39] alac: change some data types to plain int

--- libavcodec/alac.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index db5633c..cf95959 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -262,8 +262,8 @@ static void lpc_prediction(int32_t *error_buffer, int32_t

[libav-devel] [PATCH 36/39] alac: cosmetics: rename some variables and function names

--- libavcodec/alac.c | 165 - 1 files changed, 75 insertions(+), 90 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 4dbfea8..db5633c 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -112,13 +112,13 @@ static cons

[libav-devel] [PATCH 35/39] alac: multi-channel decoding support

From: Andrew D'Addesio Signed-off-by: Justin Ruggles --- libavcodec/alac.c | 61 +--- 1 files changed, 43 insertions(+), 18 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 1ba7e9a..4dbfea8 100644 --- a/libavcodec/alac.c ++

[libav-devel] [PATCH 34/39] alac: split element parsing into a separate function

This will make multi-channel implementation simpler. Based partially on a patch by Andrew D'Addesio . --- libavcodec/alac.c | 121 +++- 1 files changed, 81 insertions(+), 40 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 0e62

[libav-devel] [PATCH 33/39] alac: use get_bits_long() in decode_scalar()

allows for a larger sample size than MIN_CACHE_BITS --- libavcodec/alac.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 5f2c8a0..0e62adb 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -84,7 +84,7 @@ static in

[libav-devel] [PATCH 32/39] alac: output in planar sample format

Avoids unneeded interleaving and allows for reusing the AVFrame output buffer as the internal buffer for 24-bit and 32-bit sample size. --- libavcodec/alac.c | 46 +++--- 1 files changed, 19 insertions(+), 27 deletions(-) diff --git a/libavcodec/alac.c b/

[libav-devel] [PATCH 31/39] alac: add 32-bit decoding support

--- libavcodec/alac.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index df3c314..268d592 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -424,6 +424,18 @@ static int alac_decode_frame(AVCodecContext *avctx,

[libav-devel] [PATCH 30/39] alac: simplify channel interleaving

From: Andrew D'Addesio Signed-off-by: Justin Ruggles --- libavcodec/alac.c | 57 + 1 files changed, 14 insertions(+), 43 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index ac51c2f..df3c314 100644 --- a/libavcodec/alac.c +

[libav-devel] [PATCH 28/39] alac: fix check for valid max_samples_per_frame

--- libavcodec/alac.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index db83796..1fc4dc5 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -511,9 +511,9 @@ static int alac_set_info(ALACContext *alac) bytestream2_s

[libav-devel] [PATCH 29/39] alac: use AVPacket fields directly in alac_decode_frame()

--- libavcodec/alac.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 1fc4dc5..ac51c2f 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -291,8 +291,6 @@ static void interleave_stereo_24(int32_t *buffer[MAX_CHA

[libav-devel] [PATCH 26/39] alac: move the current samples per frame to the ALACContext

This will simplify the multi-channel implementation. --- libavcodec/alac.c | 45 ++--- 1 files changed, 22 insertions(+), 23 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f803f9a..9e77f67 100644 --- a/libavcodec/alac.c +++ b/libavc

[libav-devel] [PATCH 27/39] alac: use get_sbits() to read LPC coefficients instead of casting

--- libavcodec/alac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 9e77f67..db83796 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -366,7 +366,7 @@ static int alac_decode_frame(AVCodecContext *avctx, void *data,

[libav-devel] [PATCH 25/39] alac: avoid using a double-negative when checking if the frame is compressed

--- libavcodec/alac.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 474531b..f803f9a 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -298,7 +298,7 @@ static int alac_decode_frame(AVCodecContext *avctx, void *da

[libav-devel] [PATCH 24/39] alac: factor out output_size check in predictor_decompress_fir_adapt()

--- libavcodec/alac.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 42dfdad..474531b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -173,10 +173,10 @@ static void predictor_decompress_fir_adapt(int32_t *error

[libav-devel] [PATCH 22/39] alac: factor out loading of next decoded sample in LPC prediction

--- libavcodec/alac.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index eeb888e..e2a7d79 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -206,15 +206,16 @@ static void predictor_decompress_fir_adapt(int32_t *error_

[libav-devel] [PATCH 23/39] alac: use sizeof() in memcpy() instead of hardcoded data size

--- libavcodec/alac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index e2a7d79..42dfdad 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -177,7 +177,8 @@ static void predictor_decompress_fir_adapt(int32_t *error_buffer

[libav-devel] [PATCH 21/39] alac: use index into buffer_out instead of incrementing the pointer

--- libavcodec/alac.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f48079c..eeb888e 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -201,29 +201,29 @@ static void predictor_decompress_fir_adapt(int32_t

[libav-devel] [PATCH 20/39] alac: simplify lpc coefficient adaptation

--- libavcodec/alac.c | 41 ++--- 1 files changed, 10 insertions(+), 31 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 997362b..f48079c 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -205,6 +205,7 @@ static void predictor_dec

[libav-devel] [PATCH 18/39] alac: simplify 1st order prediction and reading of warm-up samples

--- libavcodec/alac.c | 18 +- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 840c722..7e940fa 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -185,25 +185,17 @@ static void predictor_decompress_fir_adapt(int3

[libav-devel] [PATCH 19/39] alac: reduce the number of local variables needed in lpc prediction

--- libavcodec/alac.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 7e940fa..997362b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -203,28 +203,27 @@ static void predictor_decompress_fir_ada

[libav-devel] [PATCH 17/39] alac: cosmetics: reindent after last commit

--- libavcodec/alac.c | 90 ++-- 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 23f437f..840c722 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -198,71 +198,71 @@ static void

[libav-devel] [PATCH 16/39] alac: remove unneeded conditionals in predictor_decompress_fir_adapt()

--- libavcodec/alac.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 915b7eb..23f437f 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -198,7 +198,6 @@ static void predictor_decompress_fir_adapt(int32_t *error_buffer

[libav-devel] [PATCH 15/39] alac: use sizeof() in memset() instead of hardcoded data size

--- libavcodec/alac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 91c94d7..915b7eb 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -142,7 +142,8 @@ static void bastardized_rice_decompress(ALACContext *alac,

[libav-devel] [PATCH 14/39] alac: make block_size signed

It does not need to be unsigned. --- libavcodec/alac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 74da253..91c94d7 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -130,7 +130,7 @@ static void bastardized_rice_deco

[libav-devel] [PATCH 13/39] alac: remove a duplicate local variable

--- libavcodec/alac.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 0aeb410..74da253 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -130,7 +130,6 @@ static void bastardized_rice_decompress(ALACContext *alac,

[libav-devel] [PATCH 12/39] alac: conditionally set sign_modifier to 1

It is already unconditionally set to 0 prior to this, so we can modify it only when needed. --- libavcodec/alac.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 2aab84c..0aeb410 100644 --- a/libavcodec/alac.c +++ b/libavcod

[libav-devel] [PATCH 11/39] alac: eliminate 2 unneeded local variables in bastardized_rice_decompress()

x_modified is just unnecessary, and final_val can be removed by simplifying the unsigned-to-signed conversion. --- libavcodec/alac.c | 23 +++ 1 files changed, 7 insertions(+), 16 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f27992d..2aab84c 100644 -

[libav-devel] [PATCH 10/39] alac: adjust conditions for updating entropy decoder history

avoids some unnecessary arithmetic in certain situations --- libavcodec/alac.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 84f7e42..f27992d 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -131,11 +131,11 @@ sta

[libav-devel] [PATCH 09/39] alac: cosmetics: reindent after last commit

--- libavcodec/alac.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 76ef499..84f7e42 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -85,16 +85,16 @@ static inline int decode_scalar(GetBitContext *gb, i

[libav-devel] [PATCH 08/39] alac: limit the rice param before passing to decode_scalar()

reduces the number of parameters to decode_scalar() and slightly simplifies the code --- libavcodec/alac.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 8824ae8..76ef499 100644 --- a/libavcodec/alac.c +++ b/libav

[libav-devel] [PATCH 06/39] alac: cosmetics: rename some ALACContext parameters

--- libavcodec/alac.c | 127 ++--- 1 files changed, 63 insertions(+), 64 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 699b86a..4848ea2 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -37,7 +37,7 @@ * 8bit samp

[libav-devel] [PATCH 07/39] alac: reduce the number of parameters to bastardized_rice_decompress()

Use the ALACContext fields directly instead. --- libavcodec/alac.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 4848ea2..8824ae8 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -107,13 +107,10 @@ stat

[libav-devel] [PATCH 05/39] alac: clean up and update comments leftover from reverse-engineering

--- libavcodec/alac.c | 49 ++--- 1 files changed, 18 insertions(+), 31 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index ab9fb81..699b86a 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -70,19 +70,16 @@ typedef struct {

[libav-devel] [PATCH 04/39] avformat: move 'chan' tag parsing to mov_chan.c to share with the CAF demuxer

--- libavformat/cafdec.c |6 ++ libavformat/mov.c | 39 +-- libavformat/mov_chan.c | 44 libavformat/mov_chan.h | 11 +++ 4 files changed, 62 insertions(+), 38 deletions(-) diff --git a/l

[libav-devel] [PATCH 03/39] caf: use int64_t for num_packets

It is used to store a value read by avio_rb64(). --- libavformat/cafdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index 6e5b2c8..64ec62f 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -168,8 +168,8 @@

[libav-devel] [PATCH 02/39] caf: fix 'pakt' chunk parsing

according to the CAF specification: "... the value for mChunkSize can be greater than the actual valid content of the packet table chunk" --- libavformat/cafdec.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index 0475175.

[libav-devel] [PATCH 01/39] caf: support either old or new style ALAC magic kuki chunk

--- libavformat/cafdec.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index d5ee9be..0475175 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -121,18 +121,36 @@ static int read_kuki_chu

[libav-devel] [PATCH 00/39] ALAC decoder improvements

- Misc clean ups and fixes - Planar output - 32-bit decoding - multi-channel decoding Andrew D'Addesio (2): alac: simplify channel interleaving alac: multi-channel decoding support Justin Ruggles (37): caf: support either old or new style ALAC magic kuki chunk caf: fix 'pakt' chunk parsin

[libav-devel] [PATCH] dct/fft-test: use a replacement getopt() if the system has none present.

From: "Ronald S. Bultje" This allows compiling and running these tests on systems lacking a built- in version of getopt(), such as MSVC. Signed-off-by: Anton Khirnov --- compat/getopt.c | 84 + configure |2 ++ libavcodec/

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

Alex Converse writes: > On Mon, Jul 9, 2012 at 1:44 PM, Måns Rullgård wrote: >> Derek Buitenhuis writes: >> >>> On 09/07/2012 6:17 AM, Måns Rullgård wrote: I don't like this one bit. It makes the code considerably more complicated only to allow running two minor tests on an obscure >

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

Alex Converse writes: > ob·scure adj \äb-ˈskyu̇r, əb-\ > > Definition of OBSCURE > > 1 > a : dark, dim Sure, for some meanings of those words. > b : shrouded in or hidden by darkness Definitely. > 2 > : not readily understood or clearly expressed; also : mysterious Oh yes. A clear match for

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On Mon, Jul 9, 2012 at 1:44 PM, Måns Rullgård wrote: > Derek Buitenhuis writes: > >> On 09/07/2012 6:17 AM, Måns Rullgård wrote: >>> I don't like this one bit. It makes the code considerably more >>> complicated only to allow running two minor tests on an obscure >>> platform. >>> >>> Just make

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

Derek Buitenhuis writes: > On 09/07/2012 6:17 AM, Måns Rullgård wrote: >> I don't like this one bit. It makes the code considerably more >> complicated only to allow running two minor tests on an obscure >> platform. >> >> Just make the tests conditional. > > -1 > > Not OK with making FFT testi

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

After some discussion on IRC I think I'll drop this set and we'll go back to the original Ronald's getopt() replacement, just moved to some less controversial place like compat/. I'll send a new patch tomorrow if nobody beats me to it. -- Anton Khirnov __

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On Mon, Jul 9, 2012 at 7:55 AM, Luca Barbato wrote: > On 07/09/2012 04:35 PM, Derek Buitenhuis wrote: >> On 09/07/2012 6:17 AM, Måns Rullgård wrote: >>> I don't like this one bit. It makes the code considerably more >>> complicated only to allow running two minor tests on an obscure >>> platform.

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

On Sat, Jul 07, 2012 at 09:38:53AM -0700, Jason Garrett-Glaser wrote: [...] This should address most of your and Diego's comments. >From fdd64b45b5e0ebf220ba39593d8bf9ff87083d8f Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 7 Jul 2012 13:21:52 +0200 Subject: [PATCH] MS Expression Enco

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

>> >> Would it be better something like: ? >> >> - >> rtsp: convert rtsp_open_transport_ctx() to non-static. >> >> The RTSP listen mode, which is implemented in rtspdec.c, needs this >> functionality and in consequence more visibility for >> rtsp_open_transport_ctx() is needed. >> - > > > Y

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

On Mon, Jul 09, 2012 at 06:48:08PM +0200, Kostya Shishkov wrote: > On Mon, Jul 09, 2012 at 11:46:17AM +0200, Diego Biurrun wrote: > > On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: > > > > > > --- a/Changelog > > > +++ b/Changelog > > > @@ -31,6 +31,7 @@ version : > > > - Micros

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

On Mon, Jul 09, 2012 at 11:46:17AM +0200, Diego Biurrun wrote: > On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: > > > > --- a/Changelog > > +++ b/Changelog > > @@ -31,6 +31,7 @@ version : > > - Microsoft ATC Screen decoder > > +- Microsoft Expression Encoder Screen decoder > >

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

On Mon, 9 Jul 2012, Jordi Ortiz wrote: Ok as well, but you might try to improve the commit message. You shouldn't try to cram everything into the first line - try to make that one as short as possible while still describing the commit. If you need to say more than that, add extra full sentenc

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

On Mon, Jul 09, 2012 at 08:06:27AM -0700, Jason Garrett-Glaser wrote: > On Sun, Jul 8, 2012 at 9:42 PM, Kostya Shishkov > wrote: > > On Sun, Jul 08, 2012 at 08:17:10PM -0700, Jason Garrett-Glaser wrote: > >> > +#define UNQUANT(val, q) ((q * val + 0x80) >> 8) > >> > >> I'd call this DEQUANT, but th

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

> Ok as well, but you might try to improve the commit message. You shouldn't > try to cram everything into the first line - try to make that one as short as > possible while still describing the commit. If you need to say more than > that, add extra full sentences below. > Would it be better so

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

On Mon, Jul 09, 2012 at 11:17:17AM +0200, Diego Biurrun wrote: > On Mon, Jul 09, 2012 at 11:13:47AM +0200, Kostya Shishkov wrote: > > On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: > > > On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: > > > > --- > > > > I also took

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

On Mon, Jul 09, 2012 at 02:19:27PM +0200, Luca Barbato wrote: > On 07/09/2012 02:10 PM, Kostya Shishkov wrote: > > On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: > >> On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: > >>> On 07/09/2012 01:42 PM, Kostya Shishkov wrote:

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On 09/07/2012 10:55 AM, Luca Barbato wrote: > I don't know how you think that giving some kind of support for an > utterly broken compiler makes it not an obscure platform. The fact that Chrome will be using it (and I bet Steam too) will instantly make it widely used. :P - Derek _

Re: [libav-devel] [PATCH 3/3] RTMPE protocol support

On Mon, Jul 9, 2012 at 4:45 PM, Martin Storsjö wrote: > Hi, > > When sending a patchset, please send it all as one git send-email > invocation, or if not, please set the in-reply-to header properly, so that > the mails get chained together properly. Now the 3 patches in this series > have ended up

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

On Sun, Jul 8, 2012 at 9:42 PM, Kostya Shishkov wrote: > On Sun, Jul 08, 2012 at 08:17:10PM -0700, Jason Garrett-Glaser wrote: >> > +#define UNQUANT(val, q) ((q * val + 0x80) >> 8) >> >> I'd call this DEQUANT, but that's just me. > > I don't have preferences here, so why not. > >> > +for (i =

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On 07/09/2012 04:35 PM, Derek Buitenhuis wrote: > On 09/07/2012 6:17 AM, Måns Rullgård wrote: >> I don't like this one bit. It makes the code considerably more >> complicated only to allow running two minor tests on an obscure >> platform. >> >> Just make the tests conditional. > > -1 > > I'd ha

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On Mon, Jul 09, 2012 at 10:35:46AM -0400, Derek Buitenhuis wrote: > On 09/07/2012 6:17 AM, Måns Rullgård wrote: > > I don't like this one bit. It makes the code considerably more > > complicated only to allow running two minor tests on an obscure > > platform. > > > > Just make the tests conditio

Re: [libav-devel] [PATCH 3/3] RTMPE protocol support

Hi, When sending a patchset, please send it all as one git send-email invocation, or if not, please set the in-reply-to header properly, so that the mails get chained together properly. Now the 3 patches in this series have ended up as 3 different mail threads, making it much harder to locate

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

On 09/07/2012 6:17 AM, Måns Rullgård wrote: > I don't like this one bit. It makes the code considerably more > complicated only to allow running two minor tests on an obscure > platform. > > Just make the tests conditional. -1 I'd hardly call one of the most (if not the most) widely used platfo

Re: [libav-devel] [PATCH] tcp: add initial timeout limit for incomming connections

On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/tcp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 6a65860..e5be465 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -43,7 +43,7 @@ static int tcp_open(

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

On 07/09/2012 04:00 PM, Martin Storsjö wrote: > On Mon, 9 Jul 2012, Luca Barbato wrote: > >> On 07/09/2012 03:53 PM, Martin Storsjö wrote: >>> +av_strlcatf(message, sizeof(message), "Server: LibAVFormat %d\r\n", >> >> While at it Libavformat instead of LibAVFormat > > If he switches to LIBAVF

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

On Wed, 4 Jul 2012, Jordi Ortiz wrote: +static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) +{ +RTSPState *rt = s->priv_data; +RTSPMessageHeader request = { 0 }; +int ret = 0; +char url[1024]; +RTSPStream *rtsp_st; +c

Re: [libav-devel] ppc{,64}-darwin FATE failures

On Monday, July 9, 2012, Thibaut VARENE wrote: > On Fri, Jul 6, 2012 at 4:32 PM, Sean McGovern wrote: >> >> >> On Thursday, July 5, 2012, Måns Rullgård wrote: >>> Sean McGovern writes: >>> On Thursday, July 5, 2012, Måns Rullgård wrote: > Sean McGovern writes: > >> Hi folks,

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c | 30 ++- libavformat/rtsp.h | 12 ++ libavformat/rtspcodes.h | 14 ++ libavformat/rtspdec.c | 549 --- 4 files changed, 566 insertions(+), 39 deletions(-) diff --git a/libav

  1   2   >