Re: [libav-devel] [PATCH 3/4] configure: add -mimpure-text only when using gcc on Solaris x86

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 01:51:25AM -0500, Sean McGovern wrote: Greedy compiler option parsing in Solaris Studio make this option do bad things to the resulting shared library. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Should be OK. Diego

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-11-25 Thread Diego Biurrun
On Sat, Nov 24, 2012 at 03:43:04PM +0100, Christophe Gisquet wrote: PS: no idea why firefox/gmail treats those patches as octet-stream, and how to fix that. Ronald wrote about this a while back, but there seems to be no easy solution:

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Diego Biurrun
On Sat, Nov 24, 2012 at 03:58:37PM +0100, Christophe Gisquet wrote: 2012/3/4 Ronald S. Bultje rsbul...@gmail.com: Since you're working on this, would you mind adding one (or a few) fate tests so we can ensure that we don't break this while we're optimizing it? I have no idea how to do

Re: [libav-devel] [PATCH] riff: Make ff_riff_tags static and move under appropriate #ifdef

2012-11-25 Thread Diego Biurrun
On Wed, Nov 21, 2012 at 11:42:14PM +0100, Diego Biurrun wrote: The table is not used outside the file. --- libavformat/riff.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) OKed by Anton on IRC. Diego ___

Re: [libav-devel] [PATCH] Add compiler arch support for Nehalem Sandy Bridge when using suncc

2012-11-25 Thread Luca Barbato
On 11/25/2012 07:32 AM, Sean McGovern wrote: GCC does not appear to have a -march= string for Westmere, which is a bit surprising as it has a few more instructions than a Nehalem, but a few less than a Sandy Bridge. --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [libav-devel] [PATCH] Add compiler arch support for Nehalem Sandy Bridge when using suncc

2012-11-25 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: GCC does not appear to have a -march= string for Westmere, which is a bit surprising as it has a few more instructions than a Nehalem, but a few less than a Sandy Bridge. --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [libav-devel] doc: avtools-common-opts: Fix terminology concerning metric prefixes

2012-11-25 Thread Diego Biurrun
On Mon, Nov 19, 2012 at 10:53:58PM +0100, sto@web.de wrote: Am 19.11.2012 22:26, schrieb Diego Biurrun: On Mon, Nov 19, 2012 at 09:39:20PM +0100, sto@web.de wrote: 'k', 'M', and 'G' are SI (unit) prefixes or metric prefixes, not 'number postfixes'. Also, the statement regarding binary

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Christophe Gisquet
2012/11/25 Diego Biurrun di...@biurrun.de: It's really not that hard to do. First we need a sample that exercises the code in question. Do you have one or is one already in the collection? In fact, checking different fate files, I came upon: fate-lossless-wma which should exercise it. Though

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 02:54:45PM +0100, Christophe Gisquet wrote: 2012/11/25 Diego Biurrun di...@biurrun.de: It's really not that hard to do. First we need a sample that exercises the code in question. Do you have one or is one already in the collection? In fact, checking different

Re: [libav-devel] [PATCH 3/4] configure: add -mimpure-text only when using gcc on Solaris x86

2012-11-25 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: Greedy compiler option parsing in Solaris Studio make this option do bad things to the resulting shared library. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8b68bbc..10c714d 100755

[libav-devel] [PATCH] yop: fix typo

2012-11-25 Thread Justin Ruggles
From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- libavformat/yop.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/yop.c b/libavformat/yop.c index 351938b..5fe6bdc

Re: [libav-devel] [PATCH] yop: fix typo

2012-11-25 Thread Luca Barbato
On 11/25/2012 05:04 PM, Justin Ruggles wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- libavformat/yop.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libav-devel] [PATCH 17/45] x86: h264_chromamc: port to cpuflags

2012-11-25 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 12:17:41AM +0200, Diego Biurrun wrote: --- libavcodec/x86/h264_chromamc.asm | 85 +++-- 1 files changed, 44 insertions(+), 41 deletions(-) OKed by Justin on IRC. Diego ___ libav-devel

[libav-devel] [PATCH] lavc: clarify get_buffer() documentation

2012-11-25 Thread Justin Ruggles
This is needed for the AAC decoder, which may need to call get_buffer() more than once if the channel configuration changes. --- libavcodec/avcodec.h |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 58ea1bc..5e358ca

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-11-25 Thread Ronald S. Bultje
Hi, On Sun, Nov 25, 2012 at 1:18 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Nov 24, 2012 at 03:43:04PM +0100, Christophe Gisquet wrote: PS: no idea why firefox/gmail treats those patches as octet-stream, and how to fix that. Ronald wrote about this a while back, but there seems to be

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-11-25 Thread Ronald S. Bultje
Hi, On Sun, Nov 25, 2012 at 8:43 AM, Ronald S. Bultje rsbul...@gmail.com wrote: (This is kind of a pain on Fedora Whoops, I meant Mac here. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Christophe Gisquet
Hi, If, specifically, it is a test for scalarproduct_and_madd_int16 that is asked, then this means starting to test all of dsputil. Anyway, I am no longer interested in working on that fate stuff. Christophe ___ libav-devel mailing list

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-11-25 Thread Christophe Gisquet
2012/11/25 Ronald S. Bultje rsbul...@gmail.com: The solution is basically to use git send-email, not gmail. git send-email can use your gmail account as smtp, if wanted. I can help you set that up if this doesn't help enough: Windows here, which means the msmtp way. I think I managed to set

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 05:56:38PM +0100, Christophe Gisquet wrote: If, specifically, it is a test for scalarproduct_and_madd_int16 that is asked, then this means starting to test all of dsputil. No, that is not what is asked. FATE is not a unit testing framework that exercises specific

Re: [libav-devel] [PATCH 08/10] x86: af_volume: add SSE2/SSSE3/AVX-optimized s32 volume scaling

2012-11-25 Thread Christophe Gisquet
Hi, 2012/11/10 Justin Ruggles justin.rugg...@gmail.com: Well, I've tested on Atom. Can someone test on Core 2 and Nehalem? If nobody is interested in testing, then maybe only set the ssse3 version if sse2 is slow/it is atom/something? And whatever shape this ends up having, it is better than

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Christophe Gisquet
2012/11/25 Diego Biurrun di...@biurrun.de: No, that is not what is asked. FATE is not a unit testing framework that exercises specific functions in isolation. It's more of a holistic approach that exercises specific samples completely. I was looking at the dct/fft test and didn't feel like

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 06:10:03PM +0100, Christophe Gisquet wrote: 2012/11/25 Diego Biurrun di...@biurrun.de: No, that is not what is asked. FATE is not a unit testing framework that exercises specific functions in isolation. It's more of a holistic approach that exercises specific

Re: [libav-devel] [PATCH] lavc: clarify get_buffer() documentation

2012-11-25 Thread Luca Barbato
On 11/25/2012 05:41 PM, Justin Ruggles wrote: This is needed for the AAC decoder, which may need to call get_buffer() more than once if the channel configuration changes. --- libavcodec/avcodec.h |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[libav-devel] [PATCH 1/2] riff: only warn on a bad INFO chunk code size instead of failing

2012-11-25 Thread Justin Ruggles
fixes Bug 392 --- libavformat/riff.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index 11e2a64..7313092 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -726,9 +726,10 @@ int ff_read_riff_info(AVFormatContext

[libav-devel] [PATCH 2/2] riff: do not add empty metadata tags in INFO chunk

2012-11-25 Thread Justin Ruggles
--- libavformat/riff.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index 7313092..190504c 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -734,6 +734,12 @@ int ff_read_riff_info(AVFormatContext *s, int64_t size)

[libav-devel] [PATCH] dcadec: skip QMF on unused channels

2012-11-25 Thread Justin Ruggles
From: Michael Niedermayer michae...@gmx.at Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- libavcodec/dcadec.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Christophe Gisquet
2012/11/25 Diego Biurrun di...@biurrun.de: On Sun, Nov 25, 2012 at 06:10:03PM +0100, Christophe Gisquet wrote: Then we're fine already. If you want to, you could double-check by intentionally breaking your optimization and confirming that fate complains. Breaking the optimization for the

[libav-devel] [PATCH] dcadec: skip QMF on unused channels

2012-11-25 Thread Justin Ruggles
From: Michael Niedermayer michae...@gmx.at Fixes crash when downmixing in some cases. Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- libavcodec/dcadec.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 07:22:06PM +0100, Christophe Gisquet wrote: 2012/11/25 Diego Biurrun di...@biurrun.de: On Sun, Nov 25, 2012 at 06:10:03PM +0100, Christophe Gisquet wrote: Then we're fine already. If you want to, you could double-check by intentionally breaking your optimization and

Re: [libav-devel] [PATCH] dcadec: skip QMF on unused channels

2012-11-25 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: From: Michael Niedermayer michae...@gmx.at Fixes crash when downmixing in some cases. That could do with a little more explanation. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list

[libav-devel] [PATCH] dcadec: skip QMF on unused channels

2012-11-25 Thread Justin Ruggles
From: Michael Niedermayer michae...@gmx.at When the extra rear channel is present but unused, the s-channel_order_tab[] value for that channel is -1. The QMF can be skipped for the extra channel, and doing so avoids an out-of-array read on s-sample_chanptr[]. Signed-off-by: Michael Niedermayer

[libav-devel] [PATCH] configure: Drop redundant avdevice dependency declaration

2012-11-25 Thread Diego Biurrun
--- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index eb6986a..22c2640 100755 --- a/configure +++ b/configure @@ -1729,7 +1729,7 @@ scale_filter_deps=swscale yadif_filter_deps=gpl # libraries -avdevice_deps=avcodec avformat

Re: [libav-devel] [PATCH] configure: Drop redundant avdevice dependency declaration

2012-11-25 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index eb6986a..22c2640 100755 --- a/configure +++ b/configure @@ -1729,7 +1729,7 @@ scale_filter_deps=swscale yadif_filter_deps=gpl #

Re: [libav-devel] [PATCH 1/2] riff: only warn on a bad INFO chunk code size instead of failing

2012-11-25 Thread Luca Barbato
On 11/25/2012 06:42 PM, Justin Ruggles wrote: fixes Bug 392 --- libavformat/riff.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) Looks ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] configure: Drop redundant avdevice dependency declaration

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 08:22:54PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: --- a/configure +++ b/configure @@ -1729,7 +1729,7 @@ scale_filter_deps=swscale # libraries -avdevice_deps=avcodec avformat +avdevice_deps=avformat I don't know why, but

[libav-devel] [PATCH] x86: h264 qpel: use the correct number of utilized xmm regs in cglobal

2012-11-25 Thread Justin Ruggles
Should fix xmm register clobbering on win64. --- libavcodec/x86/h264_qpel_8bit.asm | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/h264_qpel_8bit.asm b/libavcodec/x86/h264_qpel_8bit.asm index eef0715..bc6c725 100644 ---

Re: [libav-devel] [PATCH] x86: h264 qpel: use the correct number of utilized xmm regs in cglobal

2012-11-25 Thread Luca Barbato
On 11/25/2012 10:13 PM, Justin Ruggles wrote: Should fix xmm register clobbering on win64. --- libavcodec/x86/h264_qpel_8bit.asm | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) Shouldn't hurt, somebody could test it? lu

Re: [libav-devel] [PATCH] configure: Drop redundant avdevice dependency declaration

2012-11-25 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Sun, Nov 25, 2012 at 08:22:54PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: --- a/configure +++ b/configure @@ -1729,7 +1729,7 @@ scale_filter_deps=swscale # libraries -avdevice_deps=avcodec avformat

Re: [libav-devel] [PATCH] configure: Drop redundant avdevice dependency declaration

2012-11-25 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Sun, Nov 25, 2012 at 09:21:50PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Sun, Nov 25, 2012 at 08:22:54PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: --- a/configure +++ b/configure @@

[libav-devel] [PATCH 1/1] h264: enable low delay only if no delayed frames were seen

2012-11-25 Thread Janne Grunau
Dropping frames is undesirable but that is the only way by which the decoder could return to low delay mode. Instead emit a warning and continue with delayed frames. Fixes a crash in fuzzed sample nasa-8s2.ts_s20033 caused by a larger than expected has_b_frames value. Low delay keeps getting

Re: [libav-devel] [PATCH 1/1] h264: enable low delay only if no delayed frames were seen

2012-11-25 Thread Ronald S. Bultje
Hi, On Sun, Nov 25, 2012 at 2:40 PM, Janne Grunau janne-li...@jannau.net wrote: Dropping frames is undesirable but that is the only way by which the decoder could return to low delay mode. Instead emit a warning and continue with delayed frames. Fixes a crash in fuzzed sample

[libav-devel] [PATCH 1/2] mov: set st-duration in mov_read_stts() only if positive

2012-11-25 Thread Janne Grunau
Although sample count and delta are in ISO 14496-12 specified as unsigned files exists were interpreting it as signed integer makes more sense (see mp4-negative-stts-problem.mp4). Fixes an assert caused by negative avg_frame_rate deduced from a negative duratoin computed in mov_read_stts() with

[libav-devel] [PATCH 2/2] mov: compute avg_frame_rate only if duration is known

2012-11-25 Thread Janne Grunau
Fixes an assert in fuzzed sample sample.mp4_s265930. --- libavformat/mov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8dbcc41..149b48e 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2073,8 +2073,9 @@ static int

Re: [libav-devel] [PATCH] x86: h264 qpel: use the correct number of utilized xmm regs in cglobal

2012-11-25 Thread Martin Storsjö
On Sun, 25 Nov 2012, Luca Barbato wrote: On 11/25/2012 10:13 PM, Justin Ruggles wrote: Should fix xmm register clobbering on win64. --- libavcodec/x86/h264_qpel_8bit.asm | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) Shouldn't hurt, somebody could test it? Tested

Re: [libav-devel] [PATCH 1/2] mov: set st-duration in mov_read_stts() only if positive

2012-11-25 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: Although sample count and delta are in ISO 14496-12 specified as unsigned files exists were interpreting it as signed integer makes more sense (see mp4-negative-stts-problem.mp4). Can someone _please_ explain how a negative duration can ever many

[libav-devel] [PATCH 1/1] flashsv: check for keyframe before using differential coding

2012-11-25 Thread Janne Grunau
Fixes a segfault in te fuzzed sample resolutionchange.flv_s211713. --- libavcodec/flashsv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index 2ba3264..ac57f9f 100644 --- a/libavcodec/flashsv.c +++ b/libavcodec/flashsv.c @@ -377,6 +377,11 @@

Re: [libav-devel] [PATCH] dcadec: skip QMF on unused channels

2012-11-25 Thread Janne Grunau
On 2012-11-25 14:19:33 -0500, Justin Ruggles wrote: From: Michael Niedermayer michae...@gmx.at When the extra rear channel is present but unused, the s-channel_order_tab[] value for that channel is -1. The QMF can be skipped for the extra channel, and doing so avoids an out-of-array read on

[libav-devel] [PATCH] x86: fix build without inline asm

2012-11-25 Thread Mans Rullgard
The qpel functions referenced here are not related to h264 and should thus never have been under CONFIG_H264QPEL. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/x86/dsputil_mmx.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff

Re: [libav-devel] [PATCH] aacdec: fix signed overflows in lcg_random()

2012-11-25 Thread Janne Grunau
On 2012-11-24 13:12:58 +, Måns Rullgård wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 59f39fd..0319790 100644 --- a/libavcodec/aacdec.c

Re: [libav-devel] [PATCH] aacdec: fix signed overflows in lcg_random()

2012-11-25 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: On 2012-11-24 13:12:58 +, Måns Rullgård wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index

Re: [libav-devel] [PATCH] x86: fix build without inline asm

2012-11-25 Thread Janne Grunau
On 2012-11-25 23:25:47 +, Måns Rullgård wrote: The qpel functions referenced here are not related to h264 and should thus never have been under CONFIG_H264QPEL. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/x86/dsputil_mmx.c | 40 +---

Re: [libav-devel] [PATCH] aacdec: fix signed overflows in lcg_random()

2012-11-25 Thread Janne Grunau
On 2012-11-25 23:35:29 +, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: On 2012-11-24 13:12:58 +, Måns Rullgård wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[libav-devel] [PATCH] configure: Add separate list for libraries and use where appropriate

2012-11-25 Thread Diego Biurrun
--- Now featuring explicit avutil dependencies for all libraries. configure | 47 +-- 1 files changed, 21 insertions(+), 26 deletions(-) diff --git a/configure b/configure index eb6986a..3d740bf 100755 --- a/configure +++ b/configure @@ -113,6

Re: [libav-devel] [PATCH] x86: fix build without inline asm

2012-11-25 Thread Diego Biurrun
On Sun, Nov 25, 2012 at 11:25:47PM +, Mans Rullgard wrote: --- a/libavcodec/x86/dsputil_mmx.c +++ b/libavcodec/x86/dsputil_mmx.c @@ -2491,13 +2491,6 @@ static void dsputil_init_sse2(DSPContext *c, AVCodecContext *avctx, H264_QPEL_FUNCS(3, 3, sse2); } -if

[libav-devel] [PATCH v2] x86: fix build without inline asm

2012-11-25 Thread Mans Rullgard
The qpel functions referenced here are not related to h264 and should thus never have been under CONFIG_H264QPEL. Signed-off-by: Mans Rullgard m...@mansr.com --- Now works without yasm too. --- libavcodec/x86/dsputil_mmx.c | 42 ++ 1 file changed, 22

Re: [libav-devel] [PATCH v2] x86: fix build without inline asm

2012-11-25 Thread Diego Biurrun
On Mon, Nov 26, 2012 at 12:30:48AM +, Mans Rullgard wrote: --- a/libavcodec/x86/dsputil_mmx.c +++ b/libavcodec/x86/dsputil_mmx.c @@ -2461,10 +2461,10 @@ static void dsputil_init_sse(DSPContext *c, AVCodecContext *avctx, int mm_flags) static void dsputil_init_sse2(DSPContext *c,

[libav-devel] [PATCH] [v3] x86: fix build without inline asm

2012-11-25 Thread Diego Biurrun
The qpel functions referenced here are not related to h264 and should thus never have been under CONFIG_H264QPEL. Signed-off-by: Mans Rullgard m...@mansr.com Signed-off-by: Diego Biurrun di...@biurrun.de --- Now with more consistent inline asm block placement. libavcodec/x86/dsputil_mmx.c |

Re: [libav-devel] [PATCH] [v3] x86: fix build without inline asm

2012-11-25 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: The qpel functions referenced here are not related to h264 and should thus never have been under CONFIG_H264QPEL. Signed-off-by: Mans Rullgard m...@mansr.com Signed-off-by: Diego Biurrun di...@biurrun.de --- Now with more consistent inline asm block

Re: [libav-devel] [PATCH 1/2] mov: set st-duration in mov_read_stts() only if positive

2012-11-25 Thread Luca Barbato
On 11/26/2012 12:03 AM, Janne Grunau wrote: Although sample count and delta are in ISO 14496-12 specified as unsigned files exists were interpreting it as signed integer makes more sense (see mp4-negative-stts-problem.mp4). Fixes an assert caused by negative avg_frame_rate deduced from a

Re: [libav-devel] [PATCH] x86: h264 qpel: use the correct number of utilized xmm regs in cglobal

2012-11-25 Thread Luca Barbato
On 11/26/2012 12:07 AM, Martin Storsjö wrote: On Sun, 25 Nov 2012, Luca Barbato wrote: On 11/25/2012 10:13 PM, Justin Ruggles wrote: Should fix xmm register clobbering on win64. --- libavcodec/x86/h264_qpel_8bit.asm | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

Re: [libav-devel] [PATCH 1/1] flashsv: check for keyframe before using differential coding

2012-11-25 Thread Kostya Shishkov
On Mon, Nov 26, 2012 at 12:11:57AM +0100, Janne Grunau wrote: Fixes a segfault in te fuzzed sample resolutionchange.flv_s211713. ^^^ the --- libavcodec/flashsv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index