[libav-devel] [PATCH] mov: Move code shared with CAF to a separate file

2017-04-01 Thread Diego Biurrun
--- Moved ff_mov_get_lpcm_codec_id to isom.h, as Martin suggested. libavformat/Makefile | 5 ++--- libavformat/isom.h | 15 ++- libavformat/mov.c | 36 libavformat/mov_esds.c | 43 +++ 4 files ch

Re: [libav-devel] [PATCH] configure: Better names for functions that sanitize input

2017-04-03 Thread Diego Biurrun
On Tue, Mar 21, 2017 at 12:25:16PM +0100, Diego Biurrun wrote: > --- > configure | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) OKed by Luca on IRC. Diego ___ libav-devel mailing list libav-devel@libav.

Re: [libav-devel] [PATCH] decode: Initialize ret before using it

2017-04-03 Thread Diego Biurrun
On Mon, Apr 03, 2017 at 09:58:15PM +0200, Vittorio Giovara wrote: > libavcodec/decode.c:608:9: warning: variable 'ret' is > used uninitialized whenever 'if' condition is false > --- > libavcodec/decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK Diego _

Re: [libav-devel] [PATCH] cfhd: Use proper ISO C printf conversion specifiers

2017-04-04 Thread Diego Biurrun
On Tue, Apr 04, 2017 at 04:39:23PM +0200, Vittorio Giovara wrote: > libavcodec/cfhd.c:258:16: warning: format specifies > type 'unsigned short' but the argument has type 'int' [-Wformat] > --- a/libavcodec/cfhd.c > +++ b/libavcodec/cfhd.c > @@ -254,11 +254,11 @@ static int parse_tag(CFHDConte

Re: [libav-devel] [PATCH] cfhd: Use proper ISO C printf conversion specifiers

2017-04-04 Thread Diego Biurrun
On Tue, Apr 04, 2017 at 05:47:35PM +0200, Vittorio Giovara wrote: > On Tue, Apr 4, 2017 at 5:10 PM, Diego Biurrun wrote: > > On Tue, Apr 04, 2017 at 04:39:23PM +0200, Vittorio Giovara wrote: > >> libavcodec/cfhd.c:258:16: warning: format specifies > >> type '

Re: [libav-devel] [PATCH 2/2] fate: add tests for divx5 with corrupted sprite data

2017-04-05 Thread Diego Biurrun
On Tue, Apr 04, 2017 at 05:12:38PM -0400, Sean McGovern wrote: > --- > Test requires the sample attached to Bugzilla #1012 stored in the path noted > below > --- > tests/fate/demux.mak |3 +++ > tests/ref/fate/avi-mpeg4-corruptsprite-demux | 21 +

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Diego Biurrun
On Wed, Apr 05, 2017 at 05:16:24PM +0200, wm4 wrote: > On Wed, 5 Apr 2017 16:27:48 +0200 > Vittorio Giovara wrote: > > On Wed, Apr 5, 2017 at 4:11 PM, wm4 wrote: > > > On Wed, 5 Apr 2017 15:35:26 +0200 > > > Vittorio Giovara wrote: > > >> --- a/libavfilter/avfiltergraph.h > > >> +++ /dev/null >

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Diego Biurrun
On Wed, Apr 05, 2017 at 03:35:26PM +0200, Vittorio Giovara wrote: > This header was public but deprecated on 2013-04-11 (lavfi 3.8.0). > --- > libavfilter/Makefile| 1 - > libavfilter/avfiltergraph.h | 29 - > 2 files changed, 30 deletions(-) > delete mode 100

Re: [libav-devel] [PATCH] configure: Escape elements being filtered

2017-04-06 Thread Diego Biurrun
On Thu, Apr 06, 2017 at 06:14:29PM +0200, Luca Barbato wrote: > The function is used to filter out ldflags arguments that may contain $. > Update filter() as well to be consistent. > --- > > Ping in form of updated patch. > > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libav-devel] new bitstream reader benchmark results (x86 + aarch64 + arm edition)

2017-04-10 Thread Diego Biurrun
On Wed, Jan 18, 2017 at 06:51:05PM +0100, Diego Biurrun wrote: Hi fellow devs, I ran benchmarks for the new bitstream reader with the scripts, binaries and samples from ftp://irenicus.troja.mff.cuni.cz/builds/ on my AMD Phenom 9950, a Raspberry Pi B+ as well as an odroid. Results are below. The

Re: [libav-devel] [PATCH 2/7] utvideodec: Support UQY2

2017-04-11 Thread Diego Biurrun
On Mon, Apr 10, 2017 at 12:42:55PM +0200, Luca Barbato wrote: > --- a/libavcodec/utvideodec.c > +++ b/libavcodec/utvideodec.c > @@ -484,28 +675,37 @@ static av_cold int decode_init(AVCodecContext *avctx) > -if (avctx->extradata_size < 16) { > +if (avctx->extradata_size >= 16) { > +a

Re: [libav-devel] [PATCH] ac3_parser: add a public function for parsing the data required by the demuxer

2017-04-11 Thread Diego Biurrun
On Thu, Mar 30, 2017 at 04:56:28PM +0200, Anton Khirnov wrote: > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -14,7 +15,8 @@ HEADERS = avcodec.h > \ > > -OBJS = allcodecs.o \ >

Re: [libav-devel] [PATCH] ac3_parser: add a public function for parsing the data required by the demuxer

2017-04-11 Thread Diego Biurrun
On Tue, Apr 11, 2017 at 10:59:37AM +0200, Diego Biurrun wrote: > On Thu, Mar 30, 2017 at 04:56:28PM +0200, Anton Khirnov wrote: > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -14,7 +15,8 @

Re: [libav-devel] [PATCH] ac3_parser: add a public function for parsing the data required by the demuxer

2017-04-11 Thread Diego Biurrun
On Thu, Mar 30, 2017 at 05:15:35PM +0200, Anton Khirnov wrote: > Quoting wm4 (2017-03-30 17:08:26) > > On Thu, 30 Mar 2017 16:56:28 +0200 > > > > Why have this when we have a wonderful parser API? > > This is a probe function, we don't want to allocate a whole parser in > it. Maybe the function'

[libav-devel] [PATCH] avcodec: add FM Screen Capture Codec decoder

2017-04-11 Thread Diego Biurrun
From: Paul B Mahol Signed-off-by: Paul B Mahol --- Applied all review comments. Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/fmvc

Re: [libav-devel] [PATCH] golomb: Simplify get_ur_golomb_jpegls

2017-04-11 Thread Diego Biurrun
On Tue, Apr 11, 2017 at 12:22:27PM +0200, Luca Barbato wrote: > The loop always consume the bit read and the new bitstream reader > can read 0 bits just fine. consume_S > --- a/libavcodec/golomb.h > +++ b/libavcodec/golomb.h > @@ -290,16 +290,10 @@ static inline int get_ur_golomb_jpegls(Bitstream

[libav-devel] [PATCH 1/2] golomb: Optimize get_ue/se_golomb

2017-04-11 Thread Diego Biurrun
From: Alexandra Hájková Do not prefetch data too often for short codes. --- libavcodec/golomb.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h index 648f924..cbb5d12 100644 --- a/libavcodec/golomb.h

[libav-devel] [PATCH 2/2] golomb: Optimize get_interleaved_ue_golomb

2017-04-11 Thread Diego Biurrun
From: Alexandra Hájková Do not prefetch data too often for short codes. --- libavcodec/golomb.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h index cbb5d12..2daedf6 100644 --- a/libavcodec/golomb.h +++ b/libavcodec/gol

Re: [libav-devel] [PATCH] golomb: Simplify get_ur_golomb_jpegls

2017-04-11 Thread Diego Biurrun
On Tue, Apr 11, 2017 at 05:32:18PM +0200, Luca Barbato wrote: > On 11/04/2017 16:49, Diego Biurrun wrote: > > Move the semicolon to the next line for readability. > > I was thinking about making that 3 lines to make it more evident > > for (i = 0; > i < limit &am

Re: [libav-devel] [PATCH 1/2] golomb: Optimize get_ue/se_golomb

2017-04-11 Thread Diego Biurrun
On Tue, Apr 11, 2017 at 05:15:50PM +0200, Hendrik Leppkes wrote: > On Tue, Apr 11, 2017 at 5:06 PM, Diego Biurrun wrote: > > From: Alexandra Hájková > > > > Do not prefetch data too often for short codes. > > --- > > libavcodec/golomb.h | 32 ---

Re: [libav-devel] [PATCH] thread: Define ff_mutex_* macros as stub functions when threads are disabled

2017-04-12 Thread Diego Biurrun
On Fri, Mar 31, 2017 at 07:35:35PM +0200, Diego Biurrun wrote: > Silences a bunch of "statement with no effect" warnings with threads disabled. > --- > > Now with stub functions, should be more correct. > > libavutil/thread.h | 8 > 1 file changed, 4 inse

Re: [libav-devel] [PATCH 7/8] utvideodec: Reuse the huffyuv add_left

2017-04-14 Thread Diego Biurrun
On Thu, Apr 13, 2017 at 04:53:06PM +0200, Luca Barbato wrote: > From: Paul B Mahol > > ~10% faster when simd is available. utvideodec: Reuse huffyuv SIMD code ~10% faster when SIMD is available. Diego ___ libav-devel mailing list libav-devel@liba

Re: [libav-devel] [PATCH 4/8] swscale: Add gbrap10 output

2017-04-14 Thread Diego Biurrun
On Thu, Apr 13, 2017 at 04:53:03PM +0200, Luca Barbato wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > Signed-off-by: Luca Barbato > --- > libswscale/output.c | 2 ++ > libswscale/utils.c | 4 ++-- > tests/ref/fate/filter-pixfmts-cop

Re: [libav-devel] [PATCH 3/8] swscale: Add input support for gbrap10 pixel format

2017-04-14 Thread Diego Biurrun
On Thu, Apr 13, 2017 at 04:53:02PM +0200, Luca Barbato wrote: > From: Paul B Mahol > > Signed-off-by: Paul B Mahol > --- > libswscale/input.c | 16 > libswscale/utils.c | 3 +++ > 2 files changed, 19 insertions(+) Hopefully OK. Diego _

[libav-devel] [PATCH 1/2] Add ClearVideo decoder

2017-04-15 Thread Diego Biurrun
From: Kostya Shishkov Only I-frames are decoded for now. Signed-off-by: Diego Biurrun --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/clearvideo.c | 385

[libav-devel] [PATCH 2/2] clearvideo: Convert to the new bitstream reader

2017-04-15 Thread Diego Biurrun
--- libavcodec/clearvideo.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/clearvideo.c b/libavcodec/clearvideo.c index 88af1a7..c4fa133 100644 --- a/libavcodec/clearvideo.c +++ b/libavcodec/clearvideo.c @@ -25,8 +25,8 @@ */ #include

Re: [libav-devel] [PATCH 2/2] hevc: Add support for bitdepth 10 for IDCT DC

2017-04-18 Thread Diego Biurrun
On Mon, Apr 17, 2017 at 07:20:36PM +0200, Alexandra Hájková wrote: > --- > libavcodec/arm/hevc_idct.S| 50 > --- > libavcodec/arm/hevcdsp_init_arm.c | 21 +++- > 2 files changed, 56 insertions(+), 15 deletions(-) hevc: arm: Add IDCT DC for

Re: [libav-devel] [PATCH] hevc: Add NEON add_residual for bitdepth 8

2017-04-18 Thread Diego Biurrun
On Tue, Apr 18, 2017 at 09:03:50AM +0200, Alexandra Hájková wrote: > From: Seppo Tomperi > > Signed-off-by: Alexandra Hájková > --- > libavcodec/arm/hevc_idct.S| 71 > +++ > libavcodec/arm/hevcdsp_init_arm.c | 15 + > 2 files changed, 86 inse

Re: [libav-devel] [PATCH] mjpeg: Report non-3 component rgb lossless as not supported

2017-04-18 Thread Diego Biurrun
On Mon, Apr 17, 2017 at 07:14:47PM +, Luca Barbato wrote: > --- a/libavcodec/mjpegdec.c > +++ b/libavcodec/mjpegdec.c > @@ -1129,6 +1129,12 @@ int ff_mjpeg_decode_sos(MJpegDecodeContext *s, const > uint8_t *mb_bitmask, > > +if (s->lossless && s->rgb && nb_components != 3) { > +av

Re: [libav-devel] [PATCH] travis: Exclude gcc for the osx target

2017-04-19 Thread Diego Biurrun
On Tue, Apr 18, 2017 at 08:26:16PM +0200, Luca Barbato wrote: > `gcc` there is still clang so it is unneded to run it twice. I cannot parse this sentence, thus I wonder what you are trying to say.. Diego ___ libav-devel mailing list libav-devel@libav.or

[libav-devel] [PATCH] swscale-test: const correctness

2017-04-19 Thread Diego Biurrun
--- The casts are somewhat ugly, but probably unavoidable... libswscale/tests/swscale.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c index 364e2a7..ece0757 100644 --- a/libswscale/tests/swsc

Re: [libav-devel] [PATCH] travis: Exclude gcc for the osx target

2017-04-19 Thread Diego Biurrun
On Wed, Apr 19, 2017 at 11:26:16AM +0300, Martin Storsjö wrote: > On Wed, 19 Apr 2017, Diego Biurrun wrote: > > >On Tue, Apr 18, 2017 at 08:26:16PM +0200, Luca Barbato wrote: > >>`gcc` there is still clang so it is unneded to run it twice. > > > >I cannot parse

Re: [libav-devel] [PATCH 1/2] Add ClearVideo decoder

2017-04-19 Thread Diego Biurrun
On Mon, Apr 17, 2017 at 12:00:59PM -0400, Vittorio Giovara wrote: > On Sat, Apr 15, 2017 at 6:31 AM, Diego Biurrun wrote: > > --- /dev/null > > +++ b/libavcodec/clearvideo.c > > @@ -0,0 +1,385 @@ > > + > > +#include "avcodec.h" > > +

Re: [libav-devel] [PATCH 1/2] hevc: Add NEON IDCT DC functions for bitdepth 8

2017-04-20 Thread Diego Biurrun
On Thu, Apr 20, 2017 at 11:04:26PM +0300, Martin Storsjö wrote: > On Thu, 20 Apr 2017, Alexandra Hájková wrote: > >From: Seppo Tomperi > >--- a/libavcodec/arm/hevcdsp_init_arm.c > >+++ b/libavcodec/arm/hevcdsp_init_arm.c > >@@ -26,8 +26,12 @@ > >#include "libavcodec/hevcdsp.h" > > > >void ff_hevc_

Re: [libav-devel] [RFC] [PATCH] pixdesc: Change color property name APIs return type

2017-04-21 Thread Diego Biurrun
On Fri, Apr 21, 2017 at 07:06:04AM +0200, wm4 wrote: > On Thu, 20 Apr 2017 11:26:10 -0400 > Vittorio Giovara wrote: > > > This should make these APIs simpler to use, and less error prone > > in case the caller does not check they are valid, and makes them > > more similar to other naming APIs. >

[libav-devel] [PATCH] Add ClearVideo decoder

2017-04-22 Thread Diego Biurrun
From: Kostya Shishkov Only I-frames are decoded for now. Signed-off-by: Diego Biurrun --- Addressed the issues pointed out by Vittorio. I must say I'm getting some second thoughts about adding an incomplete decoder to the codebase... Changelog | 1 + doc/general

[libav-devel] [PATCH 2/2] doc/examples/output: Cast pointer to the right (const) type

2017-04-22 Thread Diego Biurrun
doc/examples/output.c:512:33: warning: passing argument 2 of ‘sws_scale’ from incompatible pointer type --- I'll be glad to hear what the alternative to casting (if any) is in this case. doc/examples/output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/examples/

[libav-devel] [PATCH 1/2] doc/examples/filter_audio: const correctness

2017-04-22 Thread Diego Biurrun
doc/examples/filter_audio.c:168:17: warning: assignment discards ‘const’ qualifier from pointer target type --- doc/examples/filter_audio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c index 60fe107..4580043

Re: [libav-devel] [RFC] [PATCH] pixdesc: Change color property name APIs return type

2017-04-22 Thread Diego Biurrun
On Sat, Apr 22, 2017 at 11:25:10AM -0300, James Almer wrote: > On 4/21/2017 7:05 AM, Diego Biurrun wrote: > >On Fri, Apr 21, 2017 at 07:06:04AM +0200, wm4 wrote: > >>On Thu, 20 Apr 2017 11:26:10 -0400 > >>Vittorio Giovara wrote: > >> > >>>This shoul

Re: [libav-devel] [PATCH] Add ClearVideo decoder

2017-04-24 Thread Diego Biurrun
On Sat, Apr 22, 2017 at 01:05:01PM +0200, Diego Biurrun wrote: > --- /dev/null > +++ b/libavcodec/clearvideo.c > @@ -0,0 +1,387 @@ > +static int clv_decode_frame(AVCodecContext *avctx, void *data, > +int *got_frame, AVPacket *avpkt) > +{ > +

Re: [libav-devel] [PATCH] configure: Fix sem_timedwait probe

2017-04-24 Thread Diego Biurrun
On Sun, Apr 23, 2017 at 02:14:32PM +, Luca Barbato wrote: > It requires pthreads. configure: Add missing pthreads extralibs to sem_timedwait check > --- a/configure > +++ b/configure > @@ -4693,7 +4693,7 @@ if ! disabled pthreads && ! enabled w32threads; then > > enabled pthreads && > -

Re: [libav-devel] [PATCH] configure: Escape elements being filtered

2017-04-24 Thread Diego Biurrun
On Thu, Apr 06, 2017 at 06:14:29PM +0200, Luca Barbato wrote: > The function is used to filter out ldflags arguments that may contain $. > Update filter() as well to be consistent. configure: Properly escape arguments in filter/filter_out helper functions The arguments may contain '$', which

Re: [libav-devel] [PATCH] Add ClearVideo decoder

2017-04-25 Thread Diego Biurrun
On Mon, Apr 24, 2017 at 11:25:43AM -0300, James Almer wrote: > On 4/24/2017 11:13 AM, Diego Biurrun wrote: > > On Sat, Apr 22, 2017 at 01:05:01PM +0200, Diego Biurrun wrote: > >> --- /dev/null > >> +++ b/libavcodec/clearvideo.c > >> @@ -0,0 +1,387

[libav-devel] [PATCH] Add ClearVideo decoder

2017-04-25 Thread Diego Biurrun
From: Kostya Shishkov Only I-frames are decoded for now. Signed-off-by: Diego Biurrun --- Warn about missing Non-I-frame support. Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1

Re: [libav-devel] [PATCH 2/3] vp9_superframe_bsf: convert to the new bitstream reader

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > --- > libavcodec/vp9_superframe_bsf.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) I have this locally already, but what's the point of doing it independent of the rest of the VP9 new bitstream re

Re: [libav-devel] [PATCH 2/3] vp9_superframe_bsf: convert to the new bitstream reader

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > @@ -118,19 +118,21 @@ static int vp9_superframe_filter(AVBSFContext *ctx, > AVPacket *out) > > -profile = get_bits1(&gb); > -profile |= get_bits1(&gb) << 1; > +profile = bitstream_read(&bc, 1); > +profile |= bitst

Re: [libav-devel] [PATCH] avfoundation: update to use AVCodecParameters

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:31:34AM -0400, Vittorio Giovara wrote: > --- > libavdevice/avfoundation_dec.m | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.liba

Re: [libav-devel] [PATCH] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:08:17AM -0400, Vittorio Giovara wrote: > request_channel_layout is a decoder option and it makes no sense > to have it in a parser. > > This feature was needed in the past when the decoder was allowed > to reuse the avctx from the demuxer. Nowadays the decoder receives >

Re: [libav-devel] [PATCH 2/2] mlp_parser: Drop in-parser downmix functionality

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:38:18AM -0400, Vittorio Giovara wrote: > request_channel_layout is a decoder option and it makes no sense > to have it in a parser. > > See the previous commit for a more detailed explanation. Just copy and paste. The log message should be understandable standalone. Di

Re: [libav-devel] [PATCH 1/2] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:38:17AM -0400, Vittorio Giovara wrote: > request_channel_layout is a decoder option and it makes no sense > to have it in a parser. > > This feature was needed in the past when the decoder was allowed > to reuse the avctx from the demuxer. Nowadays the decoder receives >

[libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-04-26 Thread Diego Biurrun
This makes the currently semi-public avpriv_aac_parse_header() function private to libavcodec and adds a proper public API function to return the parts of the ADTS header required in libavformat. --- This eliminates one more ABI issue with the new bitstream reader. configure

Re: [libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 02:52:28PM -0300, James Almer wrote: > On 4/26/2017 2:02 PM, Diego Biurrun wrote: > > This makes the currently semi-public avpriv_aac_parse_header() function > > private to libavcodec and adds a proper public API function to return > > the parts of the

Re: [libav-devel] [PATCH 2/3] vp9_superframe_bsf: convert to the new bitstream reader

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 12:35:17PM +0200, Diego Biurrun wrote: > On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > > @@ -118,19 +118,21 @@ static int vp9_superframe_filter(AVBSFContext *ctx, > > AVPacket *out) > > > > -profile = get_bits1(&gb)

Re: [libav-devel] [RFC] [PATCH] pixdesc: Change color property name APIs return type

2017-04-26 Thread Diego Biurrun
On Sat, Apr 22, 2017 at 08:36:56PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2017-04-22 17:48:09) > > On Sat, Apr 22, 2017 at 11:25:10AM -0300, James Almer wrote: > > > On 4/21/2017 7:05 AM, Diego Biurrun wrote: > > > >On Fri, Apr 21, 2017 at 07:06:04AM +0

Re: [libav-devel] [PATCH] mpeg4audio: make avpriv_copy_pce_data() inline

2017-04-26 Thread Diego Biurrun
On Thu, Mar 16, 2017 at 05:48:09PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2017-03-16 17:42:42) > > On Thu, Mar 16, 2017 at 05:34:12PM +0100, Anton Khirnov wrote: > > > --- a/libavcodec/mpeg4audio.h > > > +++ b/libavcodec/mpeg4audio.h > > > @@ -1

Re: [libav-devel] [PATCH 2/3] vp9_superframe_bsf: convert to the new bitstream reader

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 09:35:00PM +0200, Luca Barbato wrote: > On 4/26/17 8:36 PM, Diego Biurrun wrote: > > On Wed, Apr 26, 2017 at 12:35:17PM +0200, Diego Biurrun wrote: > >> On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > >>> @@

[libav-devel] [PATCH] mpeg4audio: make avpriv_copy_pce_data() inline

2017-04-26 Thread Diego Biurrun
. Signed-off-by: Diego Biurrun --- - Dropped a stray comment line. - avpriv_ -> ff_ libavcodec/aac_adtstoasc_bsf.c | 2 +- libavcodec/mpeg4audio.c| 40 libavcodec/mpeg4audio.h| 40 +++- libavformat/adtsen

Re: [libav-devel] [PATCH] ac3enc: Drop unneeded extern qualifier

2017-04-27 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 06:24:08PM -0400, Vittorio Giovara wrote: > libavcodec/ac3enc.c:103:30: warning: 'extern' variable > has an initializer [-Wextern-initializer] > --- > libavcodec/ac3enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK Diego __

[libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-04-27 Thread Diego Biurrun
This makes the currently semi-public avpriv_aac_parse_header() function private to libavcodec and adds a proper public API function to return the parts of the ADTS header required in libavformat. --- Renamed stuff from aacadts_ to adts_, partly according to James' suggestion. configure

Re: [libav-devel] [PATCH] mpeg4audio: make avpriv_copy_pce_data() inline

2017-04-27 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 09:55:26PM +0200, Diego Biurrun wrote: > --- a/libavcodec/mpeg4audio.c > +++ b/libavcodec/mpeg4audio.c > @@ -145,43 +145,3 @@ int avpriv_mpeg4audio_get_config(MPEG4AudioConfig *c, > const uint8_t *buf, > -static av_always_inline unsigned int copy_bits(Pu

[libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-05-02 Thread Diego Biurrun
This makes the currently semi-public avpriv_aac_parse_header() function private to libavcodec and adds a proper public API function to return the parts of the ADTS header required in libavformat. --- Added AV_-prefix to AAC_ADTS_HEADER_SIZE constant since it now lives in an installed header accord

Re: [libav-devel] [PATCH] aac: turn off SBR after an overread occurs

2017-05-02 Thread Diego Biurrun
On Tue, May 02, 2017 at 05:52:36PM -0400, Sean McGovern wrote: > On May 2, 2017 17:35, "Hendrik Leppkes" wrote: > On Tue, May 2, 2017 at 11:25 PM, Sean McGovern wrote: > > I'm not super happy with my patch subject though. Anyone have a better > > suggestion? > > This is what Alex used for the sa

Re: [libav-devel] [PATCH] configure: rename hevc_ps to hevcparse

2017-05-03 Thread Diego Biurrun
On Tue, May 02, 2017 at 06:06:52PM -0300, James Almer wrote: > Build h2645_parse.o with it, as every hevc_ps dependency also needs it. > This is more in line with h264's h264parse module. > > Signed-off-by: James Almer > --- > configure | 10 +- > libavcodec/Makefile | 8 -

Re: [libav-devel] [PATCH 1/5] lavu: add new D3D11 pixfmt and hwcontext

2017-05-05 Thread Diego Biurrun
On Thu, May 04, 2017 at 08:44:04AM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -1712,6 +1712,7 @@ HAVE_LIST=" > $THREADS_LIST > $TOOLCHAIN_FEATURES > $TYPES_LIST > +d3d11va_lib > dos_paths > dxva2_lib > libc_msvcrt > @@ -2166,6 +2167,7 @@ zmbv_encode

Re: [libav-devel] [PATCH 5/5] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-05-05 Thread Diego Biurrun
On Thu, May 04, 2017 at 08:44:08AM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -2168,7 +2168,7 @@ zmbv_encoder_deps="zlib" > # hardware accelerators > d3d11va_deps="d3d11_h dxva_h ID3D11VideoDecoder" > d3d11va_lib_deps="d3d11va" > -dxva2_deps="dxva2api_h DXVA2_ConfigPictureDecode"

Re: [libav-devel] [PATCH 5/5] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-05-05 Thread Diego Biurrun
On Fri, May 05, 2017 at 02:13:01PM +0200, wm4 wrote: > On Fri, 5 May 2017 14:00:34 +0200 Diego Biurrun wrote: > > On Thu, May 04, 2017 at 08:44:08AM +0200, wm4 wrote: > > > --- a/configure > > > +++ b/configure > > > @@ -2168,7 +2168,7 @@ zmbv_encoder_deps=&

Re: [libav-devel] [PATCH] arm: Avoid using .dn register aliases

2017-05-09 Thread Diego Biurrun
On Tue, May 09, 2017 at 10:41:18AM +0300, Martin Storsjö wrote: > clang now (in the upcoming 5.0 version) is capable of building our > arm assembly without relying on gas-preprocessor. The VC1 MC assembly > was only built and used if the chosen assembler supported the .dn > directives though. This

Re: [libav-devel] [PATCH 196/200] aac: Allow pass-through transcoding of ambisonic audio

2017-05-09 Thread Diego Biurrun
On Mon, May 08, 2017 at 12:28:47PM -0400, Vittorio Giovara wrote: > --- a/libavcodec/libfdk-aacenc.c > +++ b/libavcodec/libfdk-aacenc.c > @@ -418,6 +425,11 @@ static const AVChannelLayout aac_ch_layouts[16] = { > AV_CHANNEL_LAYOUT_7POINT1, > #endif > +{ > +.order = AV_CHANNEL_ORDE

Re: [libav-devel] [PATCH] h264_refs: validate the SPS pointer in ff_h264_execute_ref_pic_marking()

2017-05-09 Thread Diego Biurrun
On Sun, May 07, 2017 at 06:22:47PM -0400, Sean McGovern wrote: > --- a/libavcodec/h264_refs.c > +++ b/libavcodec/h264_refs.c > @@ -557,6 +557,12 @@ int ff_h264_execute_ref_pic_marking(H264Context *h) > int current_ref_assigned = 0, err = 0; > H264Picture *av_uninit(pic); > > +if(!h-

Re: [libav-devel] [PATCH 2/4] h264_sei: parse the picture timing SEIs correctly

2017-05-19 Thread Diego Biurrun
On Fri, May 19, 2017 at 11:13:26AM -0300, James Almer wrote: > On 5/19/2017 10:47 AM, Anton Khirnov wrote: > > --- a/libavcodec/h264_sei.c > > +++ b/libavcodec/h264_sei.c > > @@ -54,21 +55,22 @@ void ff_h264_sei_uninit(H264SEIContext *h) > > > > -static int decode_picture_timing(H264SEIPictureTim

[libav-devel] [PATCH 3/3] configure: Move x86 assembler sanity check into assembler probe function

2017-05-22 Thread Diego Biurrun
This allows for more graceful fallback from NASM to Yasm if the available NASM version is too old. --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0704a05..32f8dbf 100755 --- a/configure +++ b/configure @@ -4504,13 +4504,15 @@ E

[libav-devel] [PATCH 1/3] build: Skip generating .version files when reconfiguring

2017-05-22 Thread Diego Biurrun
--- avbuild/library.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avbuild/library.mak b/avbuild/library.mak index 227e4d5..2095f61 100644 --- a/avbuild/library.mak +++ b/avbuild/library.mak @@ -1,6 +1,6 @@ include $(SRC_PATH)/avbuild/common.mak -ifeq (,$(filter %clean,

[libav-devel] [PATCH 2/3] build: Add missing zlib dependencies for several protocols

2017-05-22 Thread Diego Biurrun
--- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index d6c44cf..0704a05 100755 --- a/configure +++ b/configure @@ -2445,8 +2445,11 @@ ffrtmphttp_protocol_conflict="librtmp_protocol" ffrtmphttp_protocol_select="http_protocol" gopher_protocol_select=

Re: [libav-devel] [PATCH 001/200] Add a new channel layout API

2017-05-24 Thread Diego Biurrun
On Mon, May 22, 2017 at 04:08:53PM -0400, Vittorio Giovara wrote: > On Sat, May 20, 2017 at 7:18 AM, wm4 wrote: > > On Fri, 19 May 2017 11:25:59 -0400 > > Vittorio Giovara wrote: > > > >> >> > Also, why is this only 1 byte per channel? Seems a little > >> >> > short-sighted. > >> >> > >> >> Prob

[libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
Both libraries provide similar functionality and cannot be used together. When both are enabled one is used and the other ignored arbitrarily. Error out instead and have the user choose which library to use. --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure

[libav-devel] [PATCH 2/2] configure: Fix handling of _select dependencies

2017-05-26 Thread Diego Biurrun
The handling of _select dependencies had two issues: 1) extralibs from _select dependencies of a component were not added to the list of extralibs for that component. 2) Previously, _select components were enabled after checking dependencies for that component. However, extralibs for each co

[libav-devel] [PATCH] [RFC] Disentangle TLS protocol

2017-05-26 Thread Diego Biurrun
--- TLS is not handled like other protocols. Instead the implementation details of which crypto library is used get exposed to the user. Hiding those details allows simplifying and refactoring some code and avoiding the special-casing of TLS. This should get a slightly more elaborate log message b

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 02:06:04PM +0200, wm4 wrote: > On Fri, 26 May 2017 13:50:11 +0200 > Diego Biurrun wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored arbitrarily. Error > &

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 02:06:02PM +0200, Luca Barbato wrote: > On 5/26/17 1:50 PM, Diego Biurrun wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored arbitrarily. Error > > out inst

Re: [libav-devel] [PATCH] configure: Do not check for the __builtin_vec_vsx_ld

2017-05-26 Thread Diego Biurrun
On Wed, May 10, 2017 at 05:20:29PM +0200, Luca Barbato wrote: > --- a/configure > +++ b/configure > @@ -4452,7 +4452,14 @@ EOF > > if enabled vsx; then > check_cflags -mvsx && > -check_builtin vec_vsx_ld "altivec.h" "__builtin_vec_vsx_ld" || > disable vsx > +check_cc

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 03:12:43PM +0300, Martin Storsjö wrote: > On Fri, 26 May 2017, Diego Biurrun wrote: > >--- > >TLS is not handled like other protocols. Instead the implementation details > >of which crypto library is used get exposed to the user. Hiding those > >

[libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS pro

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
*PLEASE* do not bottom-post. On Mon, May 29, 2017 at 11:32:49AM +0200, wm4 wrote: > On Mon, 29 May 2017 10:56:36 +0200 > Diego Biurrun wrote: > > --- > > > > Log message still not perfect. > > > > No longer tries to deduplicate parts of the implementa

[libav-devel] [PATCH] cmdutils: Mark conditionally used variable as av_unused

2017-05-29 Thread Diego Biurrun
Fixes the following warning with swscale disabled: avtools/cmdutils.c:1234:28: warning: unused variable ‘pix_fmt’ [-Wunused-variable] --- avtools/cmdutils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/avtools/cmdutils.c b/avtools/cmdutils.c index b0445eb..727e283 100644

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 12:18:22PM +0200, wm4 wrote: > On Mon, 29 May 2017 12:03:26 +0200 > Diego Biurrun wrote: > > On Mon, May 29, 2017 at 11:32:49AM +0200, wm4 wrote: > > > On Mon, 29 May 2017 10:56:36 +0200 > > > Diego Biurrun wrote: > > > >

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 12:44:21PM +0200, wm4 wrote: > On Mon, 29 May 2017 12:39:12 +0200 > Diego Biurrun wrote: > > On Mon, May 29, 2017 at 12:18:22PM +0200, wm4 wrote: > > > On Mon, 29 May 2017 12:03:26 +0200 > > > Diego Biurrun wrote: > > > > On

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 09:46:08PM +0300, Martin Storsjö wrote: > On Mon, 29 May 2017, Diego Biurrun wrote: > >On Mon, May 29, 2017 at 12:44:21PM +0200, wm4 wrote: > >>On Mon, 29 May 2017 12:39:12 +0200 > >>Diego Biurrun wrote: > >>> On Mon, May 29, 2017 at

[libav-devel] [PATCH 1/2] smacker: Check that the data size is a multiple of a sample vector

2017-05-30 Thread Diego Biurrun
y: Michael Niedermayer (cherry picked from commit 4a9af07a49295e014b059c1ab624c40345af5892) Signed-off-by: Diego Biurrun --- libavcodec/smacker.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index c4b4bc7..4111c3b 100644 --- a/libavcodec/smack

[libav-devel] [PATCH 2/2] smacker: Improve error handling

2017-05-30 Thread Diego Biurrun
Return sensible error values and forward error codes. --- libavcodec/smacker.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index 4111c3b..c71ced9 100644 --- a/libavcodec/smacker.c

[libav-devel] [PATCH] smacker: Check that the data size is a multiple of a sample vector

2017-05-31 Thread Diego Biurrun
y: Michael Niedermayer (cherry picked from commit 4a9af07a49295e014b059c1ab624c40345af5892) Signed-off-by: Diego Biurrun --- Fixed error message wording and error check placement. libavcodec/smacker.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c ind

[libav-devel] [PATCH] [RFC] [v3] tls: Hide backend implementation details from users

2017-05-31 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS pro

Re: [libav-devel] [PATCH] configure: Fix the msvcrt version check for mingw

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 12:56:24PM +0300, Martin Storsjö wrote: > This was actually broken when committed in 46e3936fb04; the > test never succeeded, and thus, _aligned_malloc wasn't actually > used on legacy mingw. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doh :-(

Re: [libav-devel] [PATCH 1/2] configure: Default to _WIN32_WINNT=0x0501 as minimum, for legacy mingw

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 01:21:42PM +0300, Martin Storsjö wrote: > This makes the getaddrinfo functions visible, which aren't normally > by default on legacy mingw. > > We already force __MSVCRT_VERSION__ to an XP version. > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) probably OK Y

Re: [libav-devel] [PATCH 2/2] os_support: Remove the dynamic loading of getaddrinfo from the fallback getaddrinfo

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 01:21:43PM +0300, Martin Storsjö wrote: > If we for some unexplicable reason didn't pick up getaddrinfo > at configure, the default, IPv4-only, fallback should be good enough. > > This effectively reverts 6023d84a2b7. > --- > libavformat/os_support.c | 31 -

[libav-devel] [PATCH] [RFC] [v4] tls: Hide backend implementation details from users

2017-05-31 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS pro

Re: [libav-devel] [PATCH] avutil/md5: fix misaligned reads

2017-06-01 Thread Diego Biurrun
On Wed, May 31, 2017 at 08:16:28PM -0400, Sean McGovern wrote: > --- a/libavutil/md5.c > +++ b/libavutil/md5.c > @@ -105,11 +105,6 @@ static void body(uint32_t ABCD[4], uint32_t X[16]) > unsigned int c = ABCD[1]; > unsigned int d = ABCD[0]; > > -#if HAVE_BIGENDIAN > -for (i = 0; i <

[libav-devel] [PATCH] build: Skip generating .version files when reconfiguring

2017-06-01 Thread Diego Biurrun
The .version files are only relevant during an actual build. --- Amended the log message according to Anton's request. avbuild/library.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avbuild/library.mak b/avbuild/library.mak index 227e4d5..2095f61 100644 --- a/avbuild/lib

Re: [libav-devel] [PATCH v2] avutil/md5: fix misaligned reads

2017-06-02 Thread Diego Biurrun
On Thu, Jun 01, 2017 at 07:36:48PM -0400, Sean McGovern wrote: > --- a/libavutil/md5.c > +++ b/libavutil/md5.c > @@ -99,18 +99,14 @@ static const uint32_t T[64] = { // T[i]= > fabs(sin(i+1)<<32) > static void body(uint32_t ABCD[4], uint32_t X[16]) > { > int t; > -int i av_unused; >

[libav-devel] [PATCH] tls: Hide backend implementation details from users

2017-06-02 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS pro

Re: [libav-devel] [PATCH] tls: Hide backend implementation details from users

2017-06-02 Thread Diego Biurrun
On Fri, Jun 02, 2017 at 12:12:05PM +0300, Martin Storsjö wrote: > On Fri, 2 Jun 2017, wm4 wrote: > > >On Fri, 2 Jun 2017 10:43:58 +0200 > >Diego Biurrun wrote: > > > >>TLS is currently implemented over either OpenSSL or GnuTLS, with more > >>backends

<    2   3   4   5   6   7   8   9   10   11   >