[libav-devel] [PATCH 07/10] configure: Check whether Windows Phone specific extra ldflags are needed

2015-07-26 Thread Martin Storsjö
--- After these patches, one can do a build for Windows Phone/ARM with as little configure flags as this: --toolchain=msvc --target-os=win32 --enable-cross-compile --arch=arm --cpu=armv7-a --extra-cflags='-DWINAPI_FAMILY=WINAPI_FAMILY_PHONE_APP' --- configure | 14 ++ 1 file changed,

Re: [libav-devel] [PATCH 07/10] configure: Check whether Windows Phone specific extra ldflags are needed

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Martin Storsjö wrote: --- After these patches, one can do a build for Windows Phone/ARM with as little configure flags as this: --toolchain=msvc --target-os=win32 --enable-cross-compile --arch=arm --cpu=armv7-a --extra-cflags='-DWINAPI_FAMILY=WINAPI_FAMILY_PHON

Re: [libav-devel] [PATCH 02/10] configure: Don't force _WIN32_WINNT to an older version if targeting winphone/winrt

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : +# found in the SDK headers by default. (Alternatively, we could force +# _WIN32_WINNT to 0x0602 in that case.) Why don't you force to 0x0603 in those partition cases? Wouldn't that

Re: [libav-devel] [PATCH 05/10] configure: Enable thumb automatically when building with msvc for armv7

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 446a786..77eb8f5 100755 --- a/configure +++ b/configure @@ -4007,6 +4007,7 @@ elif enabled alpha; then elif enabled

Re: [libav-devel] [PATCH 06/10] configure: Automatically add -MD when targeting the windows phone/app subsets

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : The static CRT (libcmt.lib, as used by default or with -MT) doesn't work when targeting these API subsets. Only do this if no cflags for CRT selection have been specified, to allow users to override this de

Re: [libav-devel] [PATCH 10/10] configure: Only redirect strtoll to _strtoi64 if necessary

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : This isn't necessary any longer on MSVC 2013. I agree with the patch, but IIRC, it can still fail on MSVC 2013, if you don't have the latest version (4). Hmm, possibly, I might have used that v

Re: [libav-devel] [PATCH 01/10] dxva2/d3d11va: Set _WIN32_WINNT to 0x0602 instead of 0x0600

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Hendrik Leppkes wrote: On Sun, Jul 26, 2015 at 11:57 AM, Martin Storsjö wrote: If _WIN32_WINNT is unset, we force it to a new enough value to make sure the necessary definitions are visible. When targeting Windows Phone or Windows RT, _WIN32_WINNT should be at least

Re: [libav-devel] [PATCH] d3d11va: force WINAPI_FAMILY to WINAPI_FAMILY_DESKTOP_APP to be able to use dxva.h

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Steve Lhomme wrote: On Sun, Jul 26, 2015 at 11:23 AM, Martin Storsjö wrote: On Sun, 26 Jul 2015, Martin Storsjö wrote: From: Steve Lhomme The struct definitions in dxva.h, which are necessary in order to actually use d3d11va, are hidden when WINAPI_FAMILY targets

Re: [libav-devel] [PATCH] force WINAPI_FAMILY to WINAPI_FAMILY_DESKTOP_APP to use DVXA

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Steve Lhomme wrote: The struct definitions in dxva.h, which are necessary in order to actually use d3d11va, are hidden when WINAPI_FAMILY targets Windows Phone or WindowsRT. Building with WINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP is disallowed when targeting ARM. ("Compiling

Re: [libav-devel] [PATCH 07/10] configure: Check whether Windows Phone specific extra ldflags are needed

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Steve Lhomme wrote: On Sun, Jul 26, 2015 at 12:00 PM, Martin Storsjö wrote: On Sun, 26 Jul 2015, Martin Storsjö wrote: --- After these patches, one can do a build for Windows Phone/ARM with as little configure flags as this: --toolchain=msvc --target-os=win32 --enable

Re: [libav-devel] [PATCH 02/10] configure: Don't force _WIN32_WINNT to an older version if targeting winphone/winrt

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Steve Lhomme wrote: On Sun, Jul 26, 2015 at 12:58 PM, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : +# found in the SDK headers by default. (Alternatively, we could force +# _WIN32_WINNT to 0x0602 in that case.) Why don't you for

Re: [libav-devel] [PATCH 08/10] configure: Only add -FIstdlib.h for msvc/icl if necessary

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Steve Lhomme wrote: On Sun, Jul 26, 2015 at 11:57 AM, Martin Storsjö wrote: This is only necessary on MSVC 2010/2012 (and possibly on some ICL versions). This both avoids an extra hack on newer MSVC versions, and better documents what the extra compiler option is used for

Re: [libav-devel] [PATCH 05/10] configure: Enable thumb automatically when building with msvc for armv7

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Martin Storsjö wrote: On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 446a786..77eb8f5 100755 --- a/configure +++ b/configure @@ -4007,6

Re: [libav-devel] [PATCH] force WINAPI_FAMILY to WINAPI_FAMILY_DESKTOP_APP to use DVXA

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Martin Storsjö wrote: On Sun, 26 Jul 2015, Steve Lhomme wrote: The struct definitions in dxva.h, which are necessary in order to actually use d3d11va, are hidden when WINAPI_FAMILY targets Windows Phone or WindowsRT. Building with WINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP

[libav-devel] [PATCH] doc: Remove the now unnecessary remark about PATH and link.exe

2015-07-26 Thread Martin Storsjö
--- doc/platform.texi | 6 -- 1 file changed, 6 deletions(-) diff --git a/doc/platform.texi b/doc/platform.texi index edd7577..07c8575 100644 --- a/doc/platform.texi +++ b/doc/platform.texi @@ -168,12 +168,6 @@ Notes: @itemize -@item It is possible that coreutils' @code{link.exe} conflic

[libav-devel] [PATCH] dxva2/d3d11va: Set _WIN32_WINNT to 0x0602 instead of 0x0600

2015-07-26 Thread Martin Storsjö
If _WIN32_WINNT is unset, we force it to a new enough value to make sure the necessary definitions are visible. When targeting Windows Phone or Windows RT, _WIN32_WINNT should be at least 0x0602 - otherwise the windows headers themselves can cause errors (which technically are bugs in the headers)

[libav-devel] [PATCH] configure: Check for _M_ARMT to detect thumb when using MSVC

2015-07-26 Thread Martin Storsjö
--- Checking if _M_ARMT is defined, instead of checking _M_ARM >= 7. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index d37341e..898205b 100755 --- a/configure +++ b/configure @@ -4007,6 +4007,7 @@ elif enabled alpha; then elif enabled arm; then +

Re: [libav-devel] [PATCH] configure: Check for _M_ARMT to detect thumb when using MSVC

2015-07-26 Thread Martin Storsjö
On Sun, 26 Jul 2015, Janne Grunau wrote: On 2015-07-26 23:13:15 +0300, Martin Storsjö wrote: --- Checking if _M_ARMT is defined, instead of checking _M_ARM >= 7. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index d37341e..898205b 100755 --

[libav-devel] [PATCH] configure: Simplify, remove an unnecessary intermediate variable

2015-07-27 Thread Martin Storsjö
This simplifies recently added code from 5fd553d31. --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 215f5aa..dfab84d 100755 --- a/configure +++ b/configure @@ -4749,8 +4749,7 @@ EOF fi for pfx in "" host_; do -pfx_no_=${pfx%_}

Re: [libav-devel] [PATCH 09/10] configure: Only redefine inline to __inline for msvc if necessary

2015-07-27 Thread Martin Storsjö
On Mon, 27 Jul 2015, Janne Grunau wrote: On 2015-07-26 12:57:57 +0300, Martin Storsjö wrote: This isn't necessary on MSVC 2015 any longer. --- configure | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b67c4b5..ab174f2 100755

Re: [libav-devel] [PATCH] dxva2/d3d11va: Set _WIN32_WINNT to 0x0602 instead of 0x0600

2015-07-27 Thread Martin Storsjö
On Sun, 26 Jul 2015, Martin Storsjö wrote: If _WIN32_WINNT is unset, we force it to a new enough value to make sure the necessary definitions are visible. When targeting Windows Phone or Windows RT, _WIN32_WINNT should be at least 0x0602 - otherwise the windows headers themselves can cause

Re: [libav-devel] [PATCH 06/10] configure: Automatically add -MD when targeting the windows phone/app subsets

2015-07-28 Thread Martin Storsjö
On Sun, 26 Jul 2015, Martin Storsjö wrote: On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote: On 26 Jul, Martin Storsjö wrote : The static CRT (libcmt.lib, as used by default or with -MT) doesn't work when targeting these API subsets. Only do this if no cflags for CRT selection have

Re: [libav-devel] [PATCH 2/2] hls: Save and forward avio options

2015-07-28 Thread Martin Storsjö
On Fri, 24 Jul 2015, Luca Barbato wrote: Make possible to send the custom headers and override the user agent. Reported-by: BenWonder --- libavformat/hls.c | 90 ++- 1 file changed, 83 insertions(+), 7 deletions(-) diff --git a/libavformat/hls

Re: [libav-devel] [PATCH 0/7] blowfish/dec/rc4/xtea updates

2015-07-28 Thread Martin Storsjö
On Mon, 27 Jul 2015, James Almer wrote: This set aims at making the API of these four modules more consistent with the rest of libavutil crypto stuff by adding alloc functions as well as making the contexts opaque starting with the next lavu major version. The last three patches are untested as

Re: [libav-devel] [PATCH 2/2] hls: Save and forward avio options

2015-07-28 Thread Martin Storsjö
On Tue, 28 Jul 2015, Luca Barbato wrote: On 28/07/15 19:07, Martin Storsjö wrote: Umm, no. What happens if one of the options isn't found? av_opt_get will return an error, and the HLS demuxer will refuse to work, even though things are just fine. Keep in mind that the HLS demuxer works

Re: [libav-devel] [PATCH] hls: Save and forward avio options

2015-07-29 Thread Martin Storsjö
On Wed, 29 Jul 2015, Luca Barbato wrote: Make possible to send the custom headers and override the user agent. Reported-by: BenWonder --- Kept a single dictionary and grouped the open functions as Martin suggested. libavformat/hls.c | 91 +++

Re: [libav-devel] [PATCH 1/2] hmac: add support for SHA-2

2015-07-29 Thread Martin Storsjö
On Tue, 28 Jul 2015, James Almer wrote: Signed-off-by: James Almer --- libavutil/hmac.c | 31 ++- libavutil/hmac.h | 2 ++ 2 files changed, 28 insertions(+), 5 deletions(-) Ok with me // Martin ___ libav-devel mailing lis

Re: [libav-devel] [PATCH 2/2] fate: add test vectors for HMAC SHA and SHA-2

2015-07-29 Thread Martin Storsjö
On Tue, 28 Jul 2015, James Almer wrote: Also replace custom tests for MD5 with those published in RFC 2202 Signed-off-by: James Almer --- libavutil/hmac.c| 46 -- tests/ref/fate/hmac | 20 +--- 2 files changed, 53 insertions(+), 13

Re: [libav-devel] [PATCH 3/3] rtmpproto: use AVHMAC instead of a custom implementation

2015-07-29 Thread Martin Storsjö
On Wed, 29 Jul 2015, James Almer wrote: Signed-off-by: James Almer --- libavformat/rtmp.h | 3 --- libavformat/rtmpproto.c | 39 ++- 2 files changed, 10 insertions(+), 32 deletions(-) Ok // Martin ___ libav-d

[libav-devel] [PATCH] checkasm: Include io.h for isatty, if available

2015-07-29 Thread Martin Storsjö
configure does check for isatty, and checkasm properly checks HAVE_ISATTY, but on some platforms (e.g. WinRT), io.h needs to be included for isatty to be available. --- tests/checkasm/checkasm.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/chec

Re: [libav-devel] [PATCH] rtmpproto: free hmac context properly

2015-07-29 Thread Martin Storsjö
On Thu, 30 Jul 2015, James Almer wrote: Signed-off-by: James Almer --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 1db7495..ec4b0e7 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpp

Re: [libav-devel] [PATCH] hmac: add missing version bump and APIChanges entry

2015-07-30 Thread Martin Storsjö
On Thu, 30 Jul 2015, James Almer wrote: Signed-off-by: James Almer --- Forgot about this, my bad. doc/APIchanges | 3 +++ libavutil/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) Ok // Martin ___ libav-devel mailing list liba

Re: [libav-devel] [PATCH 1/3] rtsp: Only interpret $ as interleaved packet indicator at the start of replies

2015-07-30 Thread Martin Storsjö
On Wed, 21 Jan 2015, Luca Barbato wrote: On 21/01/15 14:41, Martin Storsjö wrote: Allow $ as character anywhere within normal RTSP replies - both within the lines, and as the first character of RTSP header lines. (The existing old comment indicated that an inline packet could start at any line

Re: [libav-devel] [PATCH 1/3] rtsp: Only interpret $ as interleaved packet indicator at the start of replies

2015-07-30 Thread Martin Storsjö
On Thu, 30 Jul 2015, Martin Storsjö wrote: On Wed, 21 Jan 2015, Luca Barbato wrote: On 21/01/15 14:41, Martin Storsjö wrote: Allow $ as character anywhere within normal RTSP replies - both within the lines, and as the first character of RTSP header lines. (The existing old comment indicated

Re: [libav-devel] [PATCH] configure: Report correctly if the program is non-existing

2015-08-03 Thread Martin Storsjö
On Mon, 3 Aug 2015, Luca Barbato wrote: Makes easier spot typos while passing --cc --as --ld to configure. --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 482be43..056147e 100755 --- a/configure +++ b/configure @@ -2932,6 +2932,9 @@ probe_cc(){

Re: [libav-devel] [PATCH] configure: Silence error messages when probing compiler.

2015-08-03 Thread Martin Storsjö
On Mon, 3 Aug 2015, Luca Barbato wrote: On 03/08/15 13:31, Luca Barbato wrote: On 03/08/15 12:44, Shiz wrote: On Xcode's clang on OS X, $cc --version will output a 'Configured with:' line to stderr, which clobbers the configure script output. As this line serves no further purpose, it should b

Re: [libav-devel] [PATCH 2/5] avstring: Const correct the return pointers of strstr-like functions

2015-08-03 Thread Martin Storsjö
On Mon, 3 Aug 2015, Luca Barbato wrote: --- libavutil/avstring.c | 5 +++-- libavutil/avstring.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) This breaks const-correctness when using these functions on non-const input data. The standard C functions strstr and similar have the sam

Re: [libav-devel] [PATCH] h264: Use AVERROR return codes instead of -1

2015-08-05 Thread Martin Storsjö
On Wed, 5 Aug 2015, Luca Barbato wrote: From: Jake Sebastian-Jones And report why it fails. Signed-off-by: Luca Barbato --- You can write comments to patches below the --- marker, I use git send-email --annotate to do that. Here your amended patch I changed the commit title and message acc

Re: [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Martin Storsjö
On Sat, 8 Aug 2015, Andreas Cadhalpun wrote: It is used in libavutil/eval.c. Is there any other user of this, anywhere? The use within libavutil is only transitionary and will/should be removed at the same time when this public symbol is removed. As Hendrik said, public data symbols are pr

Re: [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Martin Storsjö
On Sat, 8 Aug 2015, Martin Storsjö wrote: On Sat, 8 Aug 2015, Andreas Cadhalpun wrote: It is used in libavutil/eval.c. Is there any other user of this, anywhere? Ok, so after reading older mails, I see that mplayer and mplayer2 are the ones affected by this. Anyway, the agreed upon

Re: [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Martin Storsjö
On Sat, 8 Aug 2015, Andreas Cadhalpun wrote: On 08.08.2015 18:40, Martin Storsjö wrote: As Hendrik said, public data symbols are problematic from a portability point of view (they behave differently than public functions in DLLs and require jumping through extra hoops, which we've chose

[libav-devel] [PATCH 1/3] movenc: Check that frag_info entries exist in mov_write_sidx_tag

2015-08-09 Thread Martin Storsjö
This fixes crashes with pathological cases when trying to write a sidx index (via the -movflags faststart option, in combination with fragmenting options), when no fragments actually have been written. (This is possible if the empty_moov flag isn't used, so that all actual packet data is written in

[libav-devel] [PATCH 2/3] movenc: Rename reserved_moov_pos to reserved_header_pos

2015-08-09 Thread Martin Storsjö
The same field is also used for writing the sidx index header, for fragmented files, when the faststart flag is used. --- libavformat/movenc.c | 14 +++--- libavformat/movenc.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc

[libav-devel] [PATCH 3/3] movenc: Place the sidx index after the initial moov/mdat pair

2015-08-09 Thread Martin Storsjö
For fragmented files with non-empty moov, with a fragment index (sidx), place the index after the initial moov/mdat pair. Previously, for this pathological case, the index was written at the start of the file. --- libavformat/movenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfo

[libav-devel] [PATCH 4/4] movenc: Add a new flag for writing global sidx indexes for dash

2015-08-09 Thread Martin Storsjö
The double meaning of the faststart flag (moving a moov atom to the start of files, making them streamable, for non-fragmented files, vs inserting a global sidx index at the start of files for fragmented files) is confusing - see 40ed1cbf1 for explanation of its origins. Since the second meaning o

Re: [libav-devel] [PATCH 1/3] movenc: Check that frag_info entries exist in mov_write_sidx_tag

2015-08-09 Thread Martin Storsjö
On Mon, 10 Aug 2015, Luca Barbato wrote: On 09/08/15 21:45, Martin Storsjö wrote: This fixes crashes with pathological cases when trying to write a sidx index (via the -movflags faststart option, in combination with fragmenting options), when no fragments actually have been written. (This is

Re: [libav-devel] [PATCH 3/5] samplefmt: Drop a spurious const from av_samples_fill_arrays

2015-08-11 Thread Martin Storsjö
On Tue, 11 Aug 2015, Anton Khirnov wrote: Quoting Luca Barbato (2015-08-03 22:51:50) The resulting mapped array is used as non-const. --- libavutil/samplefmt.c | 2 +- libavutil/samplefmt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/samplefmt.c b/libavutil

[libav-devel] [PATCH] configure: Allow manually overriding the float ABI mode

2015-08-12 Thread Martin Storsjö
The current automatic detection might not always succeed. On Xcode 7 with -fembed-bitcode, the current detection fails. In this case, the detection is to try to compile and link a file containing '__asm__ (".eabi_attribute 28, 1");' With -fembed-bitcode, the assembler does print an error, but the

Re: [libav-devel] [PATCH] configure: Allow manually overriding the float ABI mode

2015-08-12 Thread Martin Storsjö
On Wed, 12 Aug 2015, Luca Barbato wrote: On 12/08/15 12:12, Martin Storsjö wrote: The current automatic detection might not always succeed. On Xcode 7 with -fembed-bitcode, the current detection fails. In this case, the detection is to try to compile and link a file containing '__

Re: [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-12 Thread Martin Storsjö
On Sun, 9 Aug 2015, Martin Storsjö wrote: On Sat, 8 Aug 2015, Andreas Cadhalpun wrote: On 08.08.2015 18:40, Martin Storsjö wrote: As Hendrik said, public data symbols are problematic from a portability point of view (they behave differently than public functions in DLLs and require jumping

[libav-devel] [PATCH] configure: arm: Assume softfp ABI on darwin

2015-08-13 Thread Martin Storsjö
Don't try to detect the float ABI by checking at the toolchain name or by trying to assemble and link files with eabi_attributes. This fixes the float ABI detection when building using clang with -fembed-bitcode, where the current eabi_attributes check accidentally passes. CC: libav-sta...@libav.

[libav-devel] [PATCH 3/3] libfdk-aacdec: Clean up properly if the init fails

2015-08-14 Thread Martin Storsjö
Previously most of the error paths leaked. Also add FF_CODEC_CAP_INIT_THREADSAFE while adding caps_internal; this decoder wrapper doesn't have any static data that is initialized. --- Not CCing this to stable, since FF_CODEC_CAP_INIT_CLEANUP isn't in stable. --- libavcodec/libfdk-aacdec.c | 17 ++

[libav-devel] [PATCH 1/3] libfdk-aacdec: Bump the max number of channels to 8

2015-08-14 Thread Martin Storsjö
In the latest version of fdk-aac, the decoder can output up to 8 channels; take this into account when preallocating buffers that need to fit the output from any packet. CC: libav-sta...@libav.org --- libavcodec/libfdk-aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l

[libav-devel] [PATCH 2/3] libfdk-aacdec: Always decode into an intermediate buffer

2015-08-14 Thread Martin Storsjö
For ADTS streams, the output format (number of channels, frame size) can change at any point (with the latest version of fdk-aac, the decoder seems to change format after a handful of frames, not outputting the right format immediately, for cases that worked fine with the earlier version of the lib

Re: [libav-devel] [PATCH 2/3] libfdk-aacdec: Always decode into an intermediate buffer

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: On 14/08/15 10:36, Martin Storsjö wrote: For ADTS streams, the output format (number of channels, frame size) can change at any point (with the latest version of fdk-aac, the decoder seems to change format after a handful of frames, not outputting the

Re: [libav-devel] [PATCH 2/3] libfdk-aacdec: Always decode into an intermediate buffer

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: On 14/08/15 13:21, Martin Storsjö wrote: On Fri, 14 Aug 2015, Luca Barbato wrote: On 14/08/15 10:36, Martin Storsjö wrote: For ADTS streams, the output format (number of channels, frame size) can change at any point (with the latest version of fdk

Re: [libav-devel] [PATCH] hls: Correctly compute the duration

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: Use only the video packets to compute the duration the video track is present. --- libavformat/hlsenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Why is this "correctly", what issue does it fix? // Martin _

Re: [libav-devel] [PATCH 2/3] libfdk-aacdec: Always decode into an intermediate buffer

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: On 14/08/15 16:06, Martin Storsjö wrote: Nope, and more problematically; if the lib suddenly decides to decode a whole lot more channels, it will overflow the buffer we've allocated (and it ignores the buf_size parameter that we give it). I

Re: [libav-devel] [PATCH] hls: Correctly compute the duration

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: On 14/08/15 18:45, Martin Storsjö wrote: On Fri, 14 Aug 2015, Luca Barbato wrote: Use only the video packets to compute the duration the video track is present. --- libavformat/hlsenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions

Re: [libav-devel] [PATCH] hlsenc: Use AV_TIME_BASE units for all the computations

2015-08-14 Thread Martin Storsjö
On Fri, 14 Aug 2015, Luca Barbato wrote: Do not risk mixing different timebases. CC: libav-sta...@libav.org --- Now addressing the core issue, possibly properly. Thanks a lot Martin! libavformat/hlsenc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) Loo

Re: [libav-devel] [PATCH] movenc: check for the error in the AVIOContext and write

2015-08-27 Thread Martin Storsjö
On Thu, 27 Aug 2015, Alexandra Hájková wrote: the error message if there is some error. MOV has its header at the end of the file so the output will be corrupted if writing to the output will fail before header is written. This isn't true for all mov modes, only the non-fragmented ones. Bug-

Re: [libav-devel] [PATCH 2/2] mux: properly forward errors from av_interleaved_write_frame()

2015-08-27 Thread Martin Storsjö
On Thu, 27 Aug 2015, Sean McGovern wrote: Bug-Id: 881 CC: libav-sta...@libav.org --- libavformat/mux.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mux.c b/libavformat/mux.c index 3cff264..cae8f19 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -591,6 +591,9 @@

Re: [libav-devel] [PATCH] build: Add support for travis CI

2015-08-29 Thread Martin Storsjö
On Sat, 29 Aug 2015, Luca Barbato wrote: From: Federico Tomassetti It is useful to support an eventual staging branch and to have a first layer fate-check on github pull requests. --- Now updated to be much faster, thanks again to Federico for his effort. .travis.yml | 19 +++

Re: [libav-devel] [PATCH] ismindex: Use the correct abs() version

2015-08-29 Thread Martin Storsjö
On Sat, 29 Aug 2015, Vittorio Giovara wrote: --- Related to ./libav/tools/ismindex.c:378:29: warning: absolute value function 'abs' given an argument of type 'long long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value] if (duration > 0 && a

Re: [libav-devel] [PATCH] libfdk-aacdec: Remove unused variable

2015-08-29 Thread Martin Storsjö
On Sat, 29 Aug 2015, Vittorio Giovara wrote: --- libavcodec/libfdk-aacdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c index 5ac8fb7..cdf7a05 100644 --- a/libavcodec/libfdk-aacdec.c +++ b/libavcodec/libfdk-aacdec.c @@ -209,7 +209,6 @

Re: [libav-devel] [PATCH] des: Add missing include

2015-08-29 Thread Martin Storsjö
On Sat, 29 Aug 2015, Vittorio Giovara wrote: --- Related to In file included from libavutil/des.h.c:1: /Users/GiovaraV/src/libav/libavutil/des.h:33:5: warning: 'FF_API_CRYPTO_CONTEXT' is not defined, evaluates to 0 [-Wundef] #if FF_API_CRYPTO_CONTEXT ^ Vittorio libavutil/des.h |

Re: [libav-devel] [PATCH] des: Add missing include

2015-08-30 Thread Martin Storsjö
On Sun, 30 Aug 2015, Vittorio Giovara wrote: On Sat, Aug 29, 2015 at 10:33 PM, Martin Storsjö wrote: On Sat, 29 Aug 2015, Vittorio Giovara wrote: --- Related to In file included from libavutil/des.h.c:1: /Users/GiovaraV/src/libav/libavutil/des.h:33:5: warning: 'FF_API_CRYPTO_CO

[libav-devel] [PATCH] mov: Allow more than one keyframe per trun

2015-09-05 Thread Martin Storsjö
The previous restriction was partially designed to fix certain (broken) samples from bug 215. There should be no restriction on the number of keyframes per fragment or trun. The spec suggests that all frames lacking MOV_FRAG_SAMPLE_FLAG_IS_NON_SYNC are key frames, but we require the flag MOV_FRAG_

Re: [libav-devel] [PATCH] mov: Allow more than one keyframe per trun

2015-09-07 Thread Martin Storsjö
On Mon, 7 Sep 2015, Anton Khirnov wrote: Quoting Martin Storsjö (2015-09-05 19:33:39) The previous restriction was partially designed to fix certain (broken) samples from bug 215. There should be no restriction on the number of keyframes per fragment or trun. So what happens now to those

[libav-devel] [PATCH] rtpdec: Increase the max size of the jitter buffer to 100 packets

2015-09-14 Thread Martin Storsjö
Since the actual max length of the jitter buffer is restricted by max_delay, this shouldn't harm the overall latency (assuming that max_delay is set properly), while allowing packet reordering with a larger number of packets (which may be required with high bitrate video). --- libavformat/rtpdec.h

Re: [libav-devel] [PATCH] rtpdec: Increase the max size of the jitter buffer to 100 packets

2015-09-14 Thread Martin Storsjö
On Mon, 14 Sep 2015, Luca Barbato wrote: On 14/09/15 13:49, Martin Storsjö wrote: Since the actual max length of the jitter buffer is restricted by max_delay, this shouldn't harm the overall latency (assuming that max_delay is set properly), while allowing packet reordering with a l

Re: [libav-devel] [PATCH 1/2] rtpdec: add a trace when jitter buffer is full

2015-09-15 Thread Martin Storsjö
On Mon, 14 Sep 2015, Eloi BAIL wrote: This commit adds an error trace when jitter buffer is full. It helps to understand leading decoding issues. Signed-off-by: Eloi BAIL --- libavformat/rtpdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c

Re: [libav-devel] [PATCH 2/2] rtpdec: inform jitter buffer size

2015-09-15 Thread Martin Storsjö
On Tue, 15 Sep 2015, Luca Barbato wrote: On 14/09/15 22:29, Eloi BAIL wrote: This commit print as AV_LOG_INFO the jitter buffer size. It might be the default value or the value set by application. Signed-off-by: Eloi BAIL --- libavformat/rtpdec.c | 4 1 file changed, 4 insertions(+)

Re: [libav-devel] [libav-deve] [PATCH] dcadec: scan for extensions in a separate function

2015-09-15 Thread Martin Storsjö
On Tue, 15 Sep 2015, Alexandra Hájková wrote: to make dca_decode_frame more readable --- libavcodec/dcadec.c | 118 1 file changed, 64 insertions(+), 54 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index abf762d..43765cc

Re: [libav-devel] [libav-deve] [PATCH] dcadec: scan for extensions in a separate function

2015-09-15 Thread Martin Storsjö
On Tue, 15 Sep 2015, Martin Storsjö wrote: On Tue, 15 Sep 2015, Alexandra Hájková wrote: to make dca_decode_frame more readable --- libavcodec/dcadec.c | 118 1 file changed, 64 insertions(+), 54 deletions(-) diff --git a/libavcodec

Re: [libav-devel] [PATCH V2 1/3] rtpdec: add a trace when jitter buffer is full

2015-09-15 Thread Martin Storsjö
On Tue, 15 Sep 2015, Eloi BAIL wrote: This commit adds a warning trace when jitter buffer is full. It helps to understand leading decoding issues. Signed-off-by: Eloi BAIL --- libavformat/rtpdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c

Re: [libav-devel] [PATCH V2 0/3] rtpdec: add traces about RTP jitter buffer

2015-09-16 Thread Martin Storsjö
On Tue, 15 Sep 2015, Luca Barbato wrote: On 15/09/15 17:38, Eloi BAIL wrote: This patchset adds information about jitter buffer used in rtpdec. The first patch prints as warning when jitter buffer is full. The second patch prints as verbose jitter buffer size set by default in libav headers or

Re: [libav-devel] [PATCH] rtpdec: Forward the memory failure

2015-09-16 Thread Martin Storsjö
On Wed, 16 Sep 2015, Luca Barbato wrote: And avoid a memory leak. --- I need to doublecheck what happens to buf. If we don't do *bufptr, the caller still owns the buffer (and it isn't leaked). So this seems fine to me. In practice it doesn't make much difference though since the return va

[libav-devel] [PATCH 2/2] libopenh264enc: Pass all messages from the encoder to our callback

2015-09-23 Thread Martin Storsjö
This allows changing the log level on the fly at any time. This causes all messages to actually be formatted within OpenH264 (OpenH264 only snprintf formats the log messages that actually are going to be printed, just like av_log), even ones that will be discarded by the libav log level. This coul

[libav-devel] [PATCH 1/2] libopenh264enc: Use av_log() to log messages

2015-09-23 Thread Martin Storsjö
enh264 log level. This log level, and a message logging function that invokes av_log() to actually log messages, are then set on the encoder. This contains further changes by Michael Niedermayer and Martin Storsjö. --- In addition to the cleanups done by Michael, I further fixed the coding style to

Re: [libav-devel] [PATCH] movenc: Don't require a global sidx box to write the dash brand

2015-09-23 Thread Martin Storsjö
On Wed, 23 Sep 2015, Derek Buitenhuis wrote: There's no reason this should be required. Signed-off-by: Derek Buitenhuis --- As far as I know, anyway. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index ee

Re: [libav-devel] [PATCH 2/2] libopenh264enc: Pass all messages from the encoder to our callback

2015-09-27 Thread Martin Storsjö
On Wed, 23 Sep 2015, Martin Storsjö wrote: This allows changing the log level on the fly at any time. This causes all messages to actually be formatted within OpenH264 (OpenH264 only snprintf formats the log messages that actually are going to be printed, just like av_log), even ones that will

Re: [libav-devel] [PATCH 2/2] libopenh264enc: Pass all messages from the encoder to our callback

2015-09-29 Thread Martin Storsjö
On Mon, 28 Sep 2015, Anton Khirnov wrote: Quoting Martin Storsjö (2015-09-23 11:18:15) This allows changing the log level on the fly at any time. This causes all messages to actually be formatted within OpenH264 (OpenH264 only snprintf formats the log messages that actually are going to be

Re: [libav-devel] [PATCH 2/2] build: disable symbol versioning when debugging with suncc on Solaris

2015-09-30 Thread Martin Storsjö
On Wed, 30 Sep 2015, Sean McGovern wrote: Currently, if I want to build shared libraries with suncc, I can complete the build from the following command line: ./configure --disable-static --enable-shared --cc='suncc -m64' --disable-debug If I remove --disable-debug, it complains about undefine

Re: [libav-devel] [PATCH 2/2] build: disable symbol versioning when debugging with suncc on Solaris

2015-09-30 Thread Martin Storsjö
On Thu, 1 Oct 2015, Martin Storsjö wrote: On Wed, 30 Sep 2015, Sean McGovern wrote: Currently, if I want to build shared libraries with suncc, I can complete the build from the following command line: ./configure --disable-static --enable-shared --cc='suncc -m64' --disable-debug I

[libav-devel] [PATCH] rtmpproto: Write correct flv packet sizes at the end of packets

2015-10-13 Thread Martin Storsjö
From: Michael Niedermayer In one case it was written as zero, one case left it uninitialized, missed the 11 bytes for the flv header. --- libavformat/rtmpproto.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ec4

[libav-devel] [PATCH 1/2] httpauth: Add quotes around the algorithm string

2015-10-13 Thread Martin Storsjö
From: Carl Eugen Hoyos Some overly strict implementations require this, even though it technically is incorrect according to the spec. In practice many other implementations seem to be using quotes here, including cURL. --- libavformat/httpauth.c | 5 - 1 file changed, 4 insertions(+), 1 de

[libav-devel] [PATCH 2/2] httpauth: Add space after commas in HTTP/RTSP auth header

2015-10-13 Thread Martin Storsjö
From: Andrey Utkin This fixes access to Grandstream cameras, which return 401 to ffmpeg otherwise. VLC sends Authorization: header with spaces between parameters, and it is known to work with Grandstream devices and broad range of other HTTP and RTSP servers, so author considers switching to such

Re: [libav-devel] [PATCH] w32pthreads: add pthread_once emulation

2015-10-13 Thread Martin Storsjö
On Tue, 13 Oct 2015, Hendrik Leppkes wrote: On Tue, Oct 13, 2015 at 11:56 AM, Christophe Gisquet wrote: Hi 2015-10-06 12:41 GMT+02:00 Hendrik Leppkes : +static av_unused int pthread_once(pthread_once_t *once_control, void (*init_routine)(void)) [...] +MemoryBarrier(); Th

Re: [libav-devel] [PATCH] rtmpproto: Write correct flv packet sizes at the end of packets

2015-10-13 Thread Martin Storsjö
On Tue, 13 Oct 2015, Luca Barbato wrote: From: Michael Niedermayer In one case it was written as zero, one case left it uninitialized, missed the 11 bytes for the flv header. Signed-off-by: Luca Barbato --- There is an handy define, let's not add magic numbers when there. Sure // Martin

Re: [libav-devel] [PATCH 1/2] httpauth: Add quotes around the algorithm string

2015-10-13 Thread Martin Storsjö
On Tue, 13 Oct 2015, Rémi Denis-Courmont wrote: Le 2015-10-13 12:44, Martin Storsjö a écrit : From: Carl Eugen Hoyos Some overly strict implementations require this, even though it technically is incorrect according to the spec. That's not overly strict, that's just plain brok

[libav-devel] [PATCH] movenc: Honor flush requests with delay_moov, when some tracks lack samples

2015-10-20 Thread Martin Storsjö
This also makes sure that a fragmented file without the empty_moov flag (i.e. with a non-empty initial moov fragment) actually gets written, if some of the tracks turn out to not have any samples. --- libavformat/movenc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[libav-devel] [PATCH] rtsp: Allow $ as interleaved packet indicator before a complete response header

2015-10-21 Thread Martin Storsjö
Some RTSP servers ("HiIpcam/V100R003 VodServer/1.0.0") respond to our keepalive GET_PARAMETER request by a truncated RTSP header (lacking the final empty line to indicate a complete response header). Prior to 764ec70149, this worked just fine since we reacted to the $ as interleaved packet indicato

Re: [libav-devel] [PATCH] wrapped_avframe: Use a friendlier name

2015-10-27 Thread Martin Storsjö
On Tue, 27 Oct 2015, Luca Barbato wrote: The end user reading 'wrapped_avframe' would be otherwise puzzled. Reported-By: Daemon404 --- libavcodec/wrapped_avframe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Please use proper realnames in references in commit messages, where easily

[libav-devel] [PATCH 1/2] libopenh264enc: Add an option for controlling the frame skipping

2015-10-28 Thread Martin Storsjö
This allows enabling the frame skipping, which is required for the encoder to properly hit the target bitrate. --- libavcodec/libopenh264enc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 1553b6d..302d20e 100

[libav-devel] [PATCH 2/2] libopenh264: Count and warn about the number of skipped frames

2015-10-28 Thread Martin Storsjö
--- libavcodec/libopenh264enc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 302d20e..7147715 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -39,6 +39,7 @@ typedef struct SVCContext { cha

[libav-devel] [PATCH] libopenh264enc: Add an option for controlling the frame skipping

2015-10-28 Thread Martin Storsjö
This allows enabling the frame skipping, which is required for the encoder to properly hit the target bitrate. --- Renamed the option to allow_skip_frames, to avoid potential confusion with the similarly named AVCodecContext option skip_frame, as pointed out by Clément. --- libavcodec/libopenh264e

[libav-devel] [PATCH] ff_getnameinfo: fix struct servent dependancy

2015-10-28 Thread Martin Storsjö
From: Clément Gregoire On systems lacking getservbyport, struct servent might not be defined, causing a compilation error when trying to access its member s_name (ent->s_name). There is no point in keeping the if(ent) branch when getservbyport is not available. Signed-off-by: Clément Grégoire

Re: [libav-devel] [PATCH] lavc: Deprecate rtp_callback field

2015-10-28 Thread Martin Storsjö
On Wed, 28 Oct 2015, Vittorio Giovara wrote: On Wed, Oct 28, 2015 at 4:05 PM, Luca Barbato wrote: Signed-off-by: Vittorio Giovara --- libavcodec/avcodec.h | 6 ++ libavcodec/mpegvideo_enc.c | 8 libavcodec/version.h | 3 +++ 3 files changed, 17 insertions(+) amend

[libav-devel] [PATCH] configure: Add -D_CRT_NONSTDC_NO_WARNINGS when building with msvc

2015-10-28 Thread Martin Storsjö
This silences warnings like this one: libavformat/file.c(62) : warning C4996: 'read': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _read. See online help for details. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configur

<    1   2   3   4   5   6   7   8   9   10   >