Den 2010-08-29 23:30 skrev Roumen Petrov:
> Peter Rosin wrote:
>> Den 2010-08-27 00:27 skrev Roumen Petrov:
>>> Ralf Wildenhues wrote:
Hi Charles,
>>> [SNIP]
> + func_wine_to_win32_path_result="$1"
> + if test -n "$1"; then
> +# Unfortunately, winepath does not exit with
On 8/26/2010 2:26 AM, Peter Rosin wrote:
> This is my current queue of libtool patches. They need more work.
> In particular, I don't know if 0008-Slashify-instead-of-backslashify
> is even remotely acceptable. The subject has been up before and I
> think Chuck had some issue with it, but don't rem
On 8/29/2010 12:21 PM, Peter Rosin wrote:
> Den 2010-08-28 08:57 skrev Charles Wilson:
>> Rename file/path conversion functions
>
> You missed one instance here. Pushed the attached as obvious...
Thanks.
--
Chuck
Peter Rosin wrote:
Den 2010-08-27 00:27 skrev Roumen Petrov:
Ralf Wildenhues wrote:
Hi Charles,
[SNIP]
+ func_wine_to_win32_path_result="$1"
+ if test -n "$1"; then
+# Unfortunately, winepath does not exit with a non-zero
+# error code, so we are forced to check the contents of
+
Den 2010-08-28 08:57 skrev Charles Wilson:
> Rename file/path conversion functions
>
> * TODO: Document QoI issue with file name conversion functions.
> * Makefile.am (TESTS_ENVIRONMENT): Renamed cache variable
> lt_cv_to_host_path_cmd to lt_cv_to_host_file_cmd; Renamed
> envir
On 8/28/2010 2:57 AM, Charles Wilson wrote:
> Ok, I've addressed all of the review comments, including the results of
> the four ***QQQ***estions. Quick-N-Dirty spot testing on native cygwin,
> native mingw, cygwin->mingw, linux->mingw, linux->cygwin all look good,
> so I'm about to rebase on my p
* Charles Wilson wrote on Sat, Aug 28, 2010 at 08:57:04AM CEST:
> This is just an FYI. The take-away here is that I did go ahead and
> rename all the functions to
> func_convert_{file|path}_X_to_Y
> and moved them to just before func_mode_compile. I changed all comments
> and function names to
On 8/27/2010 3:47 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
>> As I said, I don't mind rebasing. I'll probably only test the result on
>> cygwin-native, mingw-native, and linux->mingw, and then push to master.
>
> Oh that's plenty fine.
>
>> Ho
Maybe a bit more explanation:
* Ralf Wildenhues wrote on Sat, Aug 28, 2010 at 07:22:42AM CEST:
> * Charles Wilson wrote on Sat, Aug 28, 2010 at 07:10:25AM CEST:
> > On 8/27/2010 3:47 PM, Ralf Wildenhues wrote:
> > > * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
> > >> However, on
Hi Charles,
* Charles Wilson wrote on Sat, Aug 28, 2010 at 07:10:25AM CEST:
> On 8/27/2010 3:47 PM, Ralf Wildenhues wrote:
> > * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
> >> However, once I have finished the requested changes above and the
> >> rebasing (plus whatever comes o
On 8/27/2010 3:47 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
>> However, once I have finished the requested changes above and the
>> rebasing (plus whatever comes of the four open ***QQQ***uestions), I
>> might ask for a 12 hour halt on updates to m
On 8/27/2010 5:48 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 10:23:31PM CEST:
>> Original:
>> real25m3.886s
>> user6m24.620s
>> sys 11m13.787s
>>
>> With the functions moved ahead of func_mode_compile:
>> real24m34.235s
>> user6m30.590s
>> sys
I'm ok with everything in this.
* Charles Wilson wrote on Fri, Aug 27, 2010 at 10:23:31PM CEST:
> Original:
> real25m3.886s
> user6m24.620s
> sys 11m13.787s
>
> With the functions moved ahead of func_mode_compile:
> real24m34.235s
> user6m30.590s
> sys 11m23.878s
>
> So, when compiling about 325 source
On 8/27/2010 2:01 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 06:35:31PM CEST:
>> Now, this is a little disturbing, since my -dlpreopen was supposed to
>> have fixed this;
>
> Would be good to fix, yes. On *nix, I'd be suggesting git bisect now,
> no idea if you ca
On 8/27/2010 12:54 AM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Thu, Aug 26, 2010 at 11:20:48PM CEST:
>> Also: I've said this before, but we can't use the m4
>> function_replace magic because we need to retain the ability for
>> users to override the choice of $func_to_host_path_cmd. Thi
On 8/26/2010 5:20 PM, Charles Wilson wrote:
> On 8/26/2010 4:18 PM, Ralf Wildenhues wrote:
>> Then, please just move the new functions where Peter needs them,
>> if they really need moving, that is.
>
> I deliberately placed them after func_compile and before func_link, for
> speed-of-parsing reas
* Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
> On 8/26/2010 4:18 PM, Ralf Wildenhues wrote:
> >> + lt_cv_to_host_path_cmd="$(to_host_path_cmd)"
> >
> > I don't understand why this change should be necessary. In your
> > testing, you describe that most setups set a correct to_h
On 8/26/2010 4:18 PM, Ralf Wildenhues wrote:
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -528,7 +528,8 @@ TESTS_ENVIRONMENT = MAKE="$(MAKE)" CC="$(CC)"
>> CFLAGS="$(CFLAGS)" \
>> CXX="$(CXX)" CXXFLAGS="$(CXXFLAGS)" CXXCPP="$(CXXCPP)" \
>> F77="$(F77)" FFLAGS="$(FFLAGS)" \
>> FC=
* Charles Wilson wrote on Fri, Aug 27, 2010 at 08:17:15PM CEST:
> On 8/27/2010 2:10 PM, Ralf Wildenhues wrote:
> > Another questions regarding this patch:
> >
> > Do you know whether all of the conversion functions are idempotent
> > (f(f(x)) = f(x))? IOW, when the user passes names already conve
On 8/27/2010 2:10 PM, Ralf Wildenhues wrote:
> Another questions regarding this patch:
>
> Do you know whether all of the conversion functions are idempotent
> (f(f(x)) = f(x))? IOW, when the user passes names already converted,
> do we do the right things in all cases?
I'm pretty sure they are
Another questions regarding this patch:
Do you know whether all of the conversion functions are idempotent
(f(f(x)) = f(x))? IOW, when the user passes names already converted,
do we do the right things in all cases?
Thanks,
Ralf
* Charles Wilson wrote on Fri, Aug 27, 2010 at 06:35:31PM CEST:
> It appears the problem is that the mdemo{2}_static.exe tests don't work,
> when mdemo{2}-conf.test is used. They DO work when mdemo-static.test is
> used (there is no mdemo2-static.test).
>
> Now, this is a little disturbing, since
Den 2010-08-27 08:25 skrev Peter Rosin:
> Den 2010-08-27 00:27 skrev Roumen Petrov:
>> Lets wine is correctly configured (Z: drive is linked to the file system
>> root):
>> $ cd $WINEPREFIX/dosdevices
>> $ winepath -w `pwd`
>> Z:\%WINEPREFIX_CONVERTED_TO_BACKSLASHES%\dosdevices
>>
>> Now lets remo
Den 2010-08-27 00:27 skrev Roumen Petrov:
> Ralf Wildenhues wrote:
>> Hi Charles,
>>
> [SNIP]
>>> + func_wine_to_win32_path_result="$1"
>>> + if test -n "$1"; then
>>> +# Unfortunately, winepath does not exit with a non-zero
>>> +# error code, so we are forced to check the contents of
>>>
* Charles Wilson wrote on Thu, Aug 26, 2010 at 11:20:48PM CEST:
> Also: I've said this before, but we can't use the m4
> function_replace magic because we need to retain the ability for
> users to override the choice of $func_to_host_path_cmd. This is
> critical for the 'cygwin->mingw (lie)' use c
Ralf Wildenhues wrote:
Hi Charles,
[SNIP]
+ func_wine_to_win32_path_result="$1"
+ if test -n "$1"; then
+# Unfortunately, winepath does not exit with a non-zero
+# error code, so we are forced to check the contents of
+# stdout. On the other hand, if the command is not
+# fou
On 8/26/2010 6:27 PM, Roumen Petrov wrote:
> Starting from wine 1.3.1 wine path always output paths:
> Lets wine is correctly configured (Z: drive is linked to the file system
> root):
> $ cd $WINEPREFIX/dosdevices
> $ winepath -w `pwd`
> Z:\%WINEPREFIX_CONVERTED_TO_BACKSLASHES%\dosdevices
>
> Now
On 8/26/2010 4:18 PM, Ralf Wildenhues wrote:
Then, please just move the new functions where Peter needs them,
if they really need moving, that is.
I deliberately placed them after func_compile and before func_link, for
speed-of-parsing reasons. Obviously libtool is used to compile object
code
Hi Charles,
first off, a few general comments: thanks for doing this work,
thanks for being so persistent.
Then, please just move the new functions where Peter needs them,
if they really need moving, that is.
Then, since the next few days might see a number of commits: in case
your redone patch
Hi,
[Full quoting since I added libtool-patc...@]
Den 2010-08-25 22:28 skrev Charles Wilson:
> [Added Peter]
>
> On 8/25/2010 4:17 PM, Ralf Wildenhues wrote:
>> * Charles Wilson wrote on Wed, Aug 25, 2010 at 10:15:55PM CEST:
>>> On 8/25/2010 3:50 PM, Ralf Wildenhues wrote:
just to let you k
Den 2010-07-19 03:07 skrev Charles Wilson:
*snip*
> Congratulations, you have reached the end of this message, and can
> now review the 750 line patch!
I did wonder when I was going to get some meat :-)
*snip*
> +func_wine_to_win32_pathlist ()
> +{
> + $opt_debug
> + # unfortunately, winepat
On 7/18/2010 9:07 PM, Charles Wilson wrote:
> cygwin->mingw cross (faked)
> cygwin->mingw cross (lie)
to follow in a later message.
> linux->mingw cross
> ==
> linux->mingw (old tests): 2 of 100 FAIL, 6 SKIP
> FAIL: tests/demo-hardcode.test
> FAIL: tests/depdemo-relink.test
>
* libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): New
function sets libtool variable $to_host_path_cmd, and employs
cache. AC_SUBSTs $to_host_path_cmd, as well.
(_LT_SETUP): Require it.
* tests/testsuite.at: Ensure to_host_path_cmd is passed as a
variable setting on the configure line for (n
On 7/18/2010 9:07 PM, Charles Wilson wrote:
> stuff
Sorry about the date. Blame 'git format-patch'.
--
Chuck
35 matches
Mail list logo
