On Tue, 12 Oct 2010 19:19:21 +0530, Balbir Singh
wrote:
> * Nikunj A. Dadhania [2010-10-08 14:43:34]:
>
> > On Fri, 8 Oct 2010 14:10:53 +0530, Balbir Singh
> > wrote:
> > > * Nikunj A. Dadhania [2010-10-08 12:00:44]:
> > >
> > > > On Thu, 7 Oct 2010 12:49:29 +0100, "Daniel P. Berrange"
> >
On Tue, 12 Oct 2010 19:27:05 +0200, Daniel Veillard wrote:
> On Fri, Oct 08, 2010 at 05:47:03PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania
> >
> > v4:
> > * prototype change: add unsigned int flags, regenerate files
> >
> > v3:
> > * Squased all the remote driver changes to o
On Tue, 12 Oct 2010 18:32:19 +0200, Daniel Veillard wrote:
> On Fri, Oct 08, 2010 at 05:46:28PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania
> >
> > Add support in the lxc driver for various memory controllable parameters
> >
> > v4:
> > + prototype change: add unsigned int fla
On Tue, 12 Oct 2010 17:51:54 +0200, Daniel Veillard wrote:
> On Fri, Oct 08, 2010 at 05:45:55PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania
> >
> > V4:
> > * prototype change: add unsigned int flags
> >
> > Driver interface for getting memory parameters, eg. hard_limit, soft_l
On Tue, 12 Oct 2010 16:54:39 +0200, Daniel Veillard wrote:
> On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania
> >
> > Adding parsing code for memory tunables in the domain xml file
> >
> > v4:
> > * Add memtune in tests/qemuxml2xmltest.c
> > * Fix
> acath...@redhat.com :
> Are you looking for a new driver to appear in 'my computer'
Yes, that is what I expected.
> because it wouldn't appear there until you format it. Does it show
> up in device manager?
I'll try to see in the device manager and see if I can ask for
formatting from somewher
* tools/virsh.c (cmdEcho): New command.
(commands): Add it.
(vshCmdOptType): Add VSH_OT_ARGV.
(vshCmddefGetData): Special case new opt flag.
(vshCommandOptArgv): New function.
---
Not complete yet, but this shows what I'm thinking of. Adding the
echo command has two benefits:
1. It will let me a
Eric,
I've been getting this error lately from git (happening during `make`):
make[1]: *** No rule to make target `todo.pl', needed by `todo.html.in'. Stop.
make: *** [distdir] Error 1
I haven't taken any time to look at it, but its caused by the
documentation task, obviously. I've been getting
* tools/virsh.c: Update comments to match patch series.
---
Noticed this one in reviewing the file once again; it's doc only, so
I'll apply it without an ACK once the rest of the series is in place.
tools/virsh.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/t
* tools/virsh.c (vshCommandParse): Float up, to avoid the need for
a forward declaration.
---
> > +static int vshCommandParse(vshControl *ctl, vshCommandParser *parser);
> I'm a fan of avoiding forward static declarations if the file can be
> rearranged topologically.
Like this. Should be a no-
On 10/12/2010 03:56 PM, Mitchell Hashimoto wrote:
I've been working with Justin, and we've been making some progress.
However, I have another question for this list. As a follow-up to
this, I realized that when I download the snapshots and just
"./configure; make; make install" then I get the laz
I've been working with Justin, and we've been making some progress.
However, I have another question for this list. As a follow-up to
this, I realized that when I download the snapshots and just
"./configure; make; make install" then I get the lazy binding issue.
However, if I go through the entire
This makes 'virsh --conn test:///default help help' work right;
previously, the abbreviation confused our hand-rolled option parsing.
* tools/virsh.c (vshParseArgv): Use getopt_long feature, rather
than (incorrectly) reparsing options ourselves.
---
> Oh my - I just looked in the code, and virsh
On Tue, Oct 12, 2010 at 09:33:03PM +0200, Matthias Bolte wrote:
> 2010/10/12 Daniel Veillard :
> > On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote:
> >> From: Nikunj A. Dadhania
> >>
> >> Adding parsing code for memory tunables in the domain xml file
> >>
> >> v4:
> >> * Add mem
On 10/12/2010 01:14 AM, Lai Jiangshan wrote:
"--" means no option at the following arguments.
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index a5b438b..d01091f 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10305,6 +10305,7 @@ vshCommandParse(vshControl *ctl
On 10/12/2010 01:14 AM, Lai Jiangshan wrote:
Some use may type command like this at the virsh shell:
virsh # somecmd 'some arg'
because some users often use single quote in linux shell.
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index b96071d..a5b438b 100644
T
On 10/12/2010 01:14 AM, Lai Jiangshan wrote:
add escaper \ for command string parsing, example:
virsh # cd /path/which/have/a/double\"quote
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index 9fd0602..b96071d 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10235
* tools/virsh.pod: Document top-level options.
---
> And I'm posting a followup patch that documents virsh's options, like -c.
Can't believe we didn't have this in the man page!
tools/virsh.pod | 45 -
1 files changed, 44 insertions(+), 1 deletions(
On 10/12/2010 01:14 AM, Lai Jiangshan wrote:
Old virsh command parsing mashes all the args back into a string and
miss the quotes, this patches fix it. It is also needed for introducing
qemu-monitor-command which is very useful.
This patches uses the new vrshCommandParser abstraction and adds
2010/10/12 Eric Blake :
> On 10/12/2010 01:29 PM, Matthias Bolte wrote:
>>
>> Add proper documentation to the new VIR_DOMAIN_MEMORY_* macros in
>> libvirt.h.in to placate apibuild.py.
>>
>> Mark args as unused in for libvirt_virDomain{Get,Set}MemoryParameters
>> in the Python bindings and add both
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
add vrshCommandParser and make vshCommandParse() accepts different
s/vrsh/vsh/; s/accepts/accept/
parsers.
the current code for parse command string is integrated as
vshCommandStringParse().
Signed-off-by: Lai Jiangshan
---
virsh.c | 91
+++
On 10/12/2010 01:29 PM, Matthias Bolte wrote:
Add proper documentation to the new VIR_DOMAIN_MEMORY_* macros in
libvirt.h.in to placate apibuild.py.
Mark args as unused in for libvirt_virDomain{Get,Set}MemoryParameters
in the Python bindings and add both to the libvirtMethods array.
Update remo
On 10/12/2010 01:01 PM, Laine Stump wrote:
On 10/12/2010 12:26 PM, Eric Blake wrote:
Now that I've done a bit more research; here's the results, to make it
easier for others to do:
git config sendemail.chainreplyto false
git config sendemail.thread false
git config format.thread shallow
Then:
2010/10/12 Daniel Veillard :
> On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote:
>> From: Nikunj A. Dadhania
>>
>> Adding parsing code for memory tunables in the domain xml file
>>
>> v4:
>> * Add memtune in tests/qemuxml2xmltest.c
>> * Fix: insert memtune element only when any o
Add proper documentation to the new VIR_DOMAIN_MEMORY_* macros in
libvirt.h.in to placate apibuild.py.
Mark args as unused in for libvirt_virDomain{Get,Set}MemoryParameters
in the Python bindings and add both to the libvirtMethods array.
Update remote_protocol-structs to placate make syntax-check
On 10/12/2010 12:26 PM, Eric Blake wrote:
Now that I've done a bit more research; here's the results, to make it
easier for others to do:
git config sendemail.chainreplyto false
git config sendemail.thread false
git config format.thread shallow
Then:
git send-email -8 --cover-letter
will
- Original Message -
> From: "Mihamina Rakotomandimby"
> To: virt-tools-l...@redhat.com, "Libvirt Developers Mailing List"
>
> Sent: Tuesday, October 12, 2010 2:17:49 PM
> Subject: [libvirt] KVM Windows guest: add hard drive
> Manao ahoana, Hello, Bonjour,
>
> I installed a Windows
Manao ahoana, Hello, Bonjour,
I installed a Windows (XP and 2003) guest using one partition as hard
drive.
I used:
sudo virt-install --connect qemu:///system \
--name win2003-01 \
--ram 1024 \
--keymap=fr \
--disk path=/dev/lvm0/win2003-01 \
--cdrom=/home/mihamina/Windows_2003_Se
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
in old code the following commands are equivalent:
virsh # dumpxml --update-cpu=vm1
virsh # dumpxml --update-cpu vm1
because the old code split the option argument into 2 parts:
--update-cpu=vm1 is split into update-cpu and vm1,
and update-
On 10/12/2010 10:50 AM, Eric Blake wrote:
Hmm, one thing you _don't_ recognize is:
-"-"option
as an option. In the shell, quotes are stripped before arguments are
recognized as a particular token. I think that's pretty easy to support
- delay VSH_TK_OPTION checking until after we've stripped qu
On 10/12/2010 11:32 AM, Daniel P. Berrange wrote:
@@ -708,6 +735,18 @@ virFileFindMountPoint;
virFileWaitForDevices;
virFileMatchesNameSuffix;
virArgvToString;
+virStrcpy;
+virStrncpy;
+virBuildPathInternal;
+virFileStripSuffix;
+virFileOperation;
+virFork;
+virRandom;
+virRandomInitialize;
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
the following command is allowed at shell, we also make it allowed at virsh
shel.
s/shel/shell/
# somecmd ""
Signed-off-by: Lai Jiangshan
---
ACK. But I'm wondering what sort of subtle surprises we might now get
in any client that is not prep
On Tue, Oct 12, 2010 at 07:27:05PM +0200, Daniel Veillard wrote:
> On Fri, Oct 08, 2010 at 05:47:03PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania
> >
> > v4:
> > * prototype change: add unsigned int flags, regenerate files
> >
> > v3:
> > * Squased all the remote driver changes
From: Miloslav Trmač
A more natural auditing point would perhaps be
SELinuxSetSecurityProcessLabel, but this happens in the child after root
permissions are dropped, so the kernel would refuse the audit record.
---
src/security/security_selinux.c | 22 ++
1 files changed, 1
Integrate with libaudit.so for auditing of important operations.
libvirtd gains a couple of config entries for auditing. By
default it will enable auditing, if its enabled on the host.
It can be configured to force exit if auditing is disabled
on the host. It will can also send audit messages via l
From: Miloslav Trmač
The libvirt_util.la library was mistakenly linked into libvirtd
directly. Since libvirt_util.la is already linked to libvirt.so,
this resulted in libvirtd getting two copies of the code and
more critically 2 copies of static global variables.
Testing in turn exposed a issue
From: Miloslav Trmač
Most operations are audited at the libvirtd level; auditing in
src/libvirt.c would result in two audit entries per operation (one in
the client, one in libvirtd).
The only exception is a domain stopping of its own will (e.g. because
the user clicks on "shutdown" inside the i
This patch series introduces basic support for auditing of guest
operations. The auditing hooks are primarily done in the libvirtd
dispatch layer, because we want to hook all stateful drivers
like QEMU, LXC, UML, etc. We don't want to audit the remote driver,
VMWare, XenAPI etc which are just plai
On Fri, Oct 08, 2010 at 05:47:03PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> v4:
> * prototype change: add unsigned int flags, regenerate files
>
> v3:
> * Squased all the remote driver changes to one single big patch and
> auto-generated is around 40%
> * Implements doma
* tools/virsh.c (malloc, calloc, realloc, strdup): Enforce that
within this file, we use the safe vsh wrappers instead.
(cmdNodeListDevices, cmdSnapshotCreate, main): Fix violations of
this policy.
---
> Hmm, I also noticed that we're inconsistent on strdup/vshStrdup in
> this file; separate clean
Hi,
I am using libvirt Java bindings. How can I rename a domain? Is there an API
to do this?
Thanks,
-Ganesh
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Oct 08, 2010 at 05:46:51PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> The command helps to control the memory/swap parameters for the system, for
> eg. hard_limit (max memory the vm can use), soft_limit (limit during memory
> contention), swap_hard_limit(max swap the
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
In origin code, double quote is only allowed at the begin or end
"complicated argument"
--some_opt="complicated string" (we split this argument into 2 parts,
option and data, the data is "complicated string").
This patch makes it allow double quote
On Fri, Oct 08, 2010 at 05:46:40PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> v4:
> * prototype change: add unsigned int flags
>
> Driver interface for getting memory parameters, eg. hard_limit, soft_limit and
> swap_hard_limit.
>
> Signed-off-by: Nikunj A. Dadhania
> ---
On Fri, Oct 08, 2010 at 05:46:28PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> Add support in the lxc driver for various memory controllable parameters
>
> v4:
> + prototype change: add unsigned int flags
>
> v2:
> + Use #define string constants for "hard_limit", etc
> + fix
On 10/12/2010 09:50 AM, Eric Blake wrote:
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
Old virsh command parsing mashes all the args back into a string and
miss the quotes, this patches fix it. It is also needed for introducing
qemu-monitor-command which is very useful.
This patches add vrshC
On Fri, Oct 08, 2010 at 05:46:15PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> v4:
> * Fix: call cgroup apis only if tunables are non zero
>
> v1:
> libvirt-lxc now configures the hardlimit, softlimit and swaplimit, if
> specified in the domain xml file or picks up the defaul
On Fri, Oct 08, 2010 at 05:46:05PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> v4:
> * Fix: call cgroup apis only if tunables are non zero
>
> QEmu startup would pick up the memory tunables specified in the domain
> configuration file.
>
> Acked-by: "Daniel P. Berrange"
> S
> > Some features provided by the recently added CPU models were mentioned
> > twice for each model. This was a result of automatic generation of the
> > XML from qemu's CPU configuration file without noticing this redundancy.
> > ---
> > src/cpu/cpu_map.xml | 84
> > --
On Fri, Oct 08, 2010 at 05:45:55PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> V4:
> * prototype change: add unsigned int flags
>
> Driver interface for getting memory parameters, eg. hard_limit, soft_limit and
> swap_hard_limit.
>
> Signed-off-by: Nikunj A. Dadhania
> ---
On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
Old virsh command parsing mashes all the args back into a string and
miss the quotes, this patches fix it. It is also needed for introducing
qemu-monitor-command which is very useful.
This patches add vrshCommandParser abstraction to parser the args
On 10/12/2010 04:15 AM, Jiri Denemark wrote:
Some features provided by the recently added CPU models were mentioned
twice for each model. This was a result of automatic generation of the
XML from qemu's CPU configuration file without noticing this redundancy.
---
src/cpu/cpu_map.xml | 84
On Fri, Oct 08, 2010 at 05:45:44PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> Driver interface for setting memory hard_limit, soft_limit and swap
> hard_limit.
[...]
> +static int qemuDomainSetMemoryParameters(virDomainPtr dom,
> + virM
On Fri, Oct 08, 2010 at 05:45:34PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> Provides interfaces for setting/getting memory tunables like hard_limit,
> soft_limit and swap_hard_limit
ACK, just one extra misplaced space,
Daniel
--
Daniel Veillard | libxml Gnome XML
On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> Adding parsing code for memory tunables in the domain xml file
>
> v4:
> * Add memtune in tests/qemuxml2xmltest.c
> * Fix: insert memtune element only when any of them is set
>
> v2:
> + Fix typo
On Fri, Oct 08, 2010 at 05:45:12PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> The patch adds xml entries to the domain.rng file.
>
Except for spurious tabs, looks fine, ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veil
On Tue, Oct 12, 2010 at 08:16:11AM -0600, Eric Blake wrote:
> On 10/12/2010 08:01 AM, Daniel Veillard wrote:
> >
> >Seems that params<= 0 or a NULL params are errors in this function
> >based on the API description, so I prefer to catch those here and added
> >
> > if ((nparams<= 0) || (params
On 09/29/2010 06:02 PM, Eric Blake wrote:
* tools/virsh.c (cmdSetvcpus): Add new flags. Let invalid
commands through to driver, to ease testing of hypervisor argument
validation.
(cmdVcpucount): New command.
(commands): Add new command.
* tools/virsh.pod (setvcpus, vcpucount): Document new behav
On 10/12/2010 08:23 AM, Matthias Bolte wrote:
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -668,6 +668,7 @@ virFileResolveLink;
saferead;
safewrite;
safezero;
+virHexToBin;
virMacAddrCompare;
virEnumFromString;
virEnumToString;
--
1.7.2.3
ACK.
Thanks; pushing
2010/10/12 Eric Blake :
> Commit 1fe2927a3 forgot to export a symbol.
>
> * src/libvirt_private.syms (virHexToBin): Add.
> * src/.gitignore: Ignore temporary file.
> ---
> src/.gitignore | 1 +
> src/libvirt_private.syms | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
>
On 10/12/2010 04:46 AM, Daniel P. Berrange wrote:
This enables support for nested SVM using the regular CPU
model/features block. If the CPU model or features include
'svm', then the '-enable-nesting' flag will be added to the
QEMU command line. Latest out of tree patches for nested
'vmx', no lon
On 10/12/2010 08:01 AM, Daniel Veillard wrote:
Seems that params<= 0 or a NULL params are errors in this function
based on the API description, so I prefer to catch those here and added
if ((nparams<= 0) || (params == NULL)) {
virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCT
On Fri, Oct 08, 2010 at 05:45:00PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> Public api to set/get memory tunables supported by the hypervisors.
> RFC: https://www.redhat.com/archives/libvir-list/2010-August/msg00607.html
>
> v4:
> * Move exporting public API to this patch
* Nikunj A. Dadhania [2010-10-08 14:43:34]:
> On Fri, 8 Oct 2010 14:10:53 +0530, Balbir Singh
> wrote:
> > * Nikunj A. Dadhania [2010-10-08 12:00:44]:
> >
> > > On Thu, 7 Oct 2010 12:49:29 +0100, "Daniel P. Berrange"
> > > wrote:
> > > > On Mon, Oct 04, 2010 at 12:47:22PM +0530, Nikunj A. D
On Fri, Oct 08, 2010 at 05:44:48PM +0530, Nikunj A. Dadhania wrote:
> From: Nikunj A. Dadhania
>
> This patch adds a structure virMemoryParameter, it contains the name of the
> parameter and the type of the parameter along with a union.
>
> v4:
> + Add unsigned int flags to the public api for fu
Commit 1fe2927a3 forgot to export a symbol.
* src/libvirt_private.syms (virHexToBin): Add.
* src/.gitignore: Ignore temporary file.
---
src/.gitignore |1 +
src/libvirt_private.syms |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/.gitignore b/src/.gitign
On Fri, 08 Oct 2010 17:44:32 +0530, "Nikunj A. Dadhania"
wrote:
> Changelog from v3:
> * Add unsigned int flags to the public api and make corresponding changes
> further down till the drivers(qemu, lxc and remote)
> * Move exporting of the api's to patch two
> * Added memtune test in t
This enables support for nested SVM using the regular CPU
model/features block. If the CPU model or features include
'svm', then the '-enable-nesting' flag will be added to the
QEMU command line. Latest out of tree patches for nested
'vmx', no longer require the '-enable-nesting' flag. They
instead
> xen: Make xenDaemon*DeviceFlags errors less confusing
> xen: Fix logic bug in xenDaemon*DeviceFlags
> xen: xenXMDomain*DeviceFlags should obey all flags
> xen: Fix virDomain{At,De}tachDevice
>
> src/xen/xen_driver.c| 24 -
> src/xen/xend_internal.c | 51 +
Dear libvirt team,
I am testing the qemu with libvit networking, and I have a question.
First, I connected the switch and server via Ethernet, the link
encapsulation is 802.1q (eth1 is trunk link)
When I use sub-interface eth1.12 for vlan12,br12 bridged to eth1.12, and
then using tap0 .
Some features provided by the recently added CPU models were mentioned
twice for each model. This was a result of automatic generation of the
XML from qemu's CPU configuration file without noticing this redundancy.
---
src/cpu/cpu_map.xml | 84 ---
Some use may type command like this at the virsh shell:
virsh # somecmd 'some arg'
because some users often use single quote in linux shell.
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index b96071d..a5b438b 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10213
Old virsh command parsing mashes all the args back into a string and
miss the quotes, this patches fix it. It is also needed for introducing
qemu-monitor-command which is very useful.
This patches uses the new vrshCommandParser abstraction and adds
vshCommandArgvParse() for arguments vector, so we
"--" means no option at the following arguments.
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index a5b438b..d01091f 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10305,6 +10305,7 @@ vshCommandParse(vshControl *ctl, vshCommandParser
*parser)
vshCmdOp
add vrshCommandParser and make vshCommandParse() accepts different
parsers.
the current code for parse command string is integrated as
vshCommandStringParse().
Signed-off-by: Lai Jiangshan
---
virsh.c | 91 +++-
1 file changed, 45 i
in old code the following commands are equivalent:
virsh # dumpxml --update-cpu=vm1
virsh # dumpxml --update-cpu vm1
because the old code split the option argument into 2 parts:
--update-cpu=vm1 is split into update-cpu and vm1,
and update-cpu is a boolean option, so the parser takes vm1
add escaper \ for command string parsing, example:
virsh # cd /path/which/have/a/double\"quote
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index 9fd0602..b96071d 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10235,7 +10235,11 @@ copy:
if (!double_quo
the following command is allowed at shell, we also make it allowed at virsh
shel.
# somecmd ""
Signed-off-by: Lai Jiangshan
---
diff --git a/tools/virsh.c b/tools/virsh.c
index 7b6f2b6..1e95023 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10175,7 +10175,6 @@ vshCommandGetToken(vshControl *
Old virsh command parsing mashes all the args back into a string and
miss the quotes, this patches fix it. It is also needed for introducing
qemu-monitor-command which is very useful.
This patches add vrshCommandParser abstraction to parser the args.
For command string, we use vshCommandStringPa
In origin code, double quote is only allowed at the begin or end
"complicated argument"
--some_opt="complicated string" (we split this argument into 2 parts,
option and data, the data is "complicated string").
This patch makes it allow double quote at any position of
an argument:
complicated" ar
On Mon, Oct 11, 2010 at 03:39:39PM -0600, Eric Blake wrote:
> On 10/08/2010 07:55 AM, Guido Günther wrote:
> >Hi,
> >attached patch improves the error message when we can't find a suitable
> >emulator. Otherwise it's simply "Unknown failure". O.k. to apply?
> >Cheers,
> > -- Guido
>
> ACK.
Pushed
81 matches
Mail list logo
