On Tue, Apr 01, 2014 at 08:26:57AM -0600, Eric Blake wrote:
On 04/01/2014 07:22 AM, Martin Kletzander wrote:
On all the places where qemuAgentComand() was called, we did a check
for errors in the reply. Unfortunately, some of the places called
qemuAgentCheckError() without checking for
Hello,
There seems to be a double-free bug in libvirt; I've checked libvirt
0.9.12 and 1.2.3:
With 0.9.12 xenUnifiedOpen() passes a pointer of conn to
xenInotifyOpen(), which passes it to virEventAddHandle(...opaque=conn...).
After successfully defining a new domain inotify picks up the newly
Adding one minor change to copyrights header...
- Move all capabilities functions to separate file
- Add initCPU
---
src/Makefile.am| 2 +
src/bhyve/bhyve_capabilities.c | 105 ++
+++
src/bhyve/bhyve_capabilities.h | 30
From: Li Yang liyang.f...@cn.fujitsu.com
For now 'virsh quit' action like this:
[root@localhost /]# virsh quit
[root@localhost /]#
And 'virsh exit' action:
[root@localhost /]# virsh exit
On 04/02/14 05:04, Eric Blake wrote:
Now that we have a dedicated type for representing a disk source,
we might as well parse and format directly into that type instead
of piecemeal into pointers to members of the type.
* src/conf/domain_conf.h (virDomainDiskSourceDefFormatInternal)
On 04/01/2014 03:31 PM, Jincheng Miao wrote:
On 04/01/2014 02:46 PM, Jincheng Miao wrote:
On 04/01/2014 06:04 AM, Nehal J Wani wrote:
On Sun, Mar 16, 2014 at 1:28 PM, Nehal J Wani
nehaljw.k...@gmail.com wrote:
I followed the following steps to build a clean development version of
libvirt from
On 04/02/14 05:04, Eric Blake wrote:
Some preparatory work before consolidating storage volume
structs with the rest of virstoragefile. Making these
changes allows a volume target to be much closer to (a
subset of) the virStorageSource struct.
Making perms be a pointer allows it to be
On 04/02/14 05:04, Eric Blake wrote:
Another step towards unification of structures. While we might
not expose everything in XML via domain disk as we do for
storage volume pointer, both places want to deal with (at least
part of) the backing chain; therefore, moving towards a single
struct
On 04/02/14 05:05, Eric Blake wrote:
A fairly smooth transition. And now that domain disks and
storage volumes share a common struct, it opens the doors for
a future patch to expose more details in the XML for both
objects.
* src/conf/storage_conf.h (_virStorageVolTarget): Delete.
These APIs allow users to get or set time in a domain, which may come
handy if the domain has been resumed just recently and NTP is not
configured or hasn't kicked in yet and the guest is running
something time critical. In addition, NTP may refuse to re-set the clock
if the skew is too big.
If we'd come up with a struct to interpret the time, it's written
in stone and there's nothing we can do about it. Even if we break
up the struct into function arguments. However, we can use typed
parameters and have the API extensible. For example, I'm
implementing seconds granularity only for
This is also adding new ACL permission to check 'set_time'.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/remote.c | 50
src/access/viraccessperm.c | 2 +-
src/access/viraccessperm.h | 7 ++-
One caveat though, qemu-ga is expecting time and returning time
in nanoseconds. With all the buffering and propagation delay, the
time is already wrong once it gets to the qemu-ga, but there's
nothing we can do about it.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
These APIs are exposed under new virsh command 'domtime' which both gets
and sets (not at the same time of course :)).
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain-monitor.c | 143 +++
tools/virsh.pod | 16 +
On 04/01/2014 06:11 PM, Ján Tomko wrote:
Every caller checked the return value and logged an error
- one if no device with the specified MAC was found,
other if there were multiple devices matching the MAC address
(except for qemuDomainUpdateDeviceConfig which logged the same
message in both
On 04/02/14 01:39, Eric Blake wrote:
The phyp code claims that it wants a non-zero value, but actually
enforces a capacity of zero. It has been this way since commit
ebc46fe in June 2010. Bummer that it has my name as the committer
- I guess I should have been much more stubborn about not
On 04/02/14 05:05, Eric Blake wrote:
One of the features of qcow2 is that a wrapper file can have
more capacity than its backing file from the guest's perspective;
what's more, sparse files make tracking allocation of both
the active and backing file worthwhile. As such, it makes
more sense
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index ba2da20..98d891a 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3162,7 +3162,7 @@ with I--current.
=item Bsnapshot-list Idomain [I--metadata] [I--no-metadata]
On 04/02/2014 12:56 PM, Shanzhi Yu wrote:
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK and pushed.
Jan
signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
On 04/02/14 12:56, Shanzhi Yu wrote:
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index ba2da20..98d891a 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3162,7 +3162,7 @@ with I--current.
=item
On 04/02/2014 12:12 AM, Martin Kletzander wrote:
+static int qemuAgentCheckError(virJSONValuePtr cmd, virJSONValuePtr
reply);
+
Is it worth hoisting this function into topological order, so we don't
need a forward declaration? But that's better as a followup patch
(no-op code motion
On 04/02/14 05:05, Eric Blake wrote:
Now that each virStorageSource can track allocation information,
and given that we already have the information without extra
syscalls, it's easier to just always populate the information
directly into the struct than it is to sometimes pass the address
of
On 04/02/2014 02:55 AM, Jincheng Miao wrote:
Sorry, this is not root cause of this problem: no
libsecurityselinuxhelper.so generated.
The macro HAVE_SELINUX_LXC_CONTEXTS_PATH can handle this no
selinux_lxc_contexts_path problem.
Then I checked the tests/Makefile.am:
936 if
On 04/02/14 05:05, Eric Blake wrote:
A future patch will merge virStorageFileMetadata and virStorageSource,
but I found it easier to do if both structs use the same information
for tracking whether a source file needs encryption keys.
* src/util/virstoragefile.h (_virStorageFileMetadata):
On 04/02/2014 03:34 AM, Michal Privoznik wrote:
If we'd come up with a struct to interpret the time, it's written
in stone and there's nothing we can do about it. Even if we break
up the struct into function arguments. However, we can use typed
parameters and have the API extensible. For
On Wed, Apr 02, 2014 at 05:44:16AM -0600, Eric Blake wrote:
On 04/02/2014 03:34 AM, Michal Privoznik wrote:
If we'd come up with a struct to interpret the time, it's written
in stone and there's nothing we can do about it. Even if we break
up the struct into function arguments. However, we
On 04/01/2014 06:11 PM, Ján Tomko wrote:
When looking up a net device by a MAC and PCI address, it is possible
that we've got a match on the MAC address but failed to match the
PCI address.
In that case, outputting just the MAC address can be confusing.
Partially resolves:
Check the bus, type of the source device (tcp vs. spicevmc)
and the device address visible in the guest.
https://bugzilla.redhat.com/show_bug.cgi?id=1035128
---
src/conf/domain_conf.c | 50 ++
1 file changed, 50 insertions(+)
diff --git
On 04/02/2014 03:49 AM, Peter Krempa wrote:
On 04/02/14 01:39, Eric Blake wrote:
The phyp code claims that it wants a non-zero value, but actually
enforces a capacity of zero. It has been this way since commit
ebc46fe in June 2010. Bummer that it has my name as the committer
- I guess I
On 04/02/2014 03:16 AM, Peter Krempa wrote:
On 04/02/14 05:04, Eric Blake wrote:
Some preparatory work before consolidating storage volume
structs with the rest of virstoragefile. Making these
changes allows a volume target to be much closer to (a
subset of) the virStorageSource struct.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-interface.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index d4ec854..27820a7 100644
--- a/tools/virsh-interface.c
+++ b/tools/virsh-interface.c
@@
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-network.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 4b0df62..3d202ce 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -943,10
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain-monitor.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 18d551a..f872f66 100644
--- a/tools/virsh-domain-monitor.c
+++
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-host.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index cac6086..107aec5 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -111,10
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/vcpupin| 1 -
tools/virsh-domain.c | 75 +---
2 files changed, 24 insertions(+), 52 deletions(-)
diff --git a/tests/vcpupin b/tests/vcpupin
index a616216..638f62b 100755
---
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-volume.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index 55bf6f0..71ff3b1 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@
Currently, the virsh code is plenty of the following pattern:
if (vshCommandOptUInt(..) 0) {
vshError(...);
goto cleanup;
}
It doesn't make much sense to repeat the code everywhere.
Moreover, some functions from the family already report
error some of them don't.
Signed-off-by:
*** BLURB HERE ***
Michal Privoznik (7):
virsh: Make vshCommandOpt* report error
virsh-domain: Adapt to new error reporting
virsh-domain-monitor: Adapt to new error reporting
virsh-host: Adapt to new error reporting
virsh-interface: Adapt to new error reporting
virsh-network: Adapt to
Every security driver has domainGenSecurityLabel defined.
Coverity complains about a possible leak of seclabel if
!sec_managers[i]-drv-domainGenSecurityLabel is true
and the seclabel might be overwritten by the next iteration
of the loop.
---
src/security/security_manager.c | 28
On 04/02/2014 06:44 AM, Ján Tomko wrote:
Every security driver has domainGenSecurityLabel defined.
As currently written. But Dan wrote the manager to be flexible to
future drivers that omit obvious functions.
This patch makes sense for silencing Coverity, but I think it is
incomplete unless
On Wed, Apr 02, 2014 at 07:00:09AM -0600, Eric Blake wrote:
On 04/02/2014 06:44 AM, Ján Tomko wrote:
Every security driver has domainGenSecurityLabel defined.
As currently written. But Dan wrote the manager to be flexible to
future drivers that omit obvious functions.
This patch makes
Coverity complains about a possible leak of seclabel if
!sec_managers[i]-drv-domainGenSecurityLabel is true
and the seclabel might be overwritten by the next iteration
of the loop.
This leak should never happen, because every security driver
has domainGenSecurityLabel defined.
---
v1: 'Remove
On 04/02/2014 03:00 PM, Eric Blake wrote:
On 04/02/2014 06:44 AM, Ján Tomko wrote:
Every security driver has domainGenSecurityLabel defined.
As currently written. But Dan wrote the manager to be flexible to
future drivers that omit obvious functions.
This patch makes sense for silencing
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
configure.ac | 11 +
libvirt.spec.in | 9
src/libvirt_private.syms | 3 +++
src/util/virnodesuspend.c | 32
On Wed, Apr 02, 2014 at 03:35:51PM +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
configure.ac | 11 +
libvirt.spec.in | 9
On Wed, 2014-04-02 at 15:52 +0200, Daniel P. Berrange wrote:
On Wed, Apr 02, 2014 at 03:35:51PM +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
On Wed, Apr 02, 2014 at 03:57:44PM +0200, Cedric Bosdonnat wrote:
On Wed, 2014-04-02 at 15:52 +0200, Daniel P. Berrange wrote:
On Wed, Apr 02, 2014 at 03:35:51PM +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
On 04/02/2014 07:26 AM, Ján Tomko wrote:
Coverity complains about a possible leak of seclabel if
!sec_managers[i]-drv-domainGenSecurityLabel is true
and the seclabel might be overwritten by the next iteration
of the loop.
This leak should never happen, because every security driver
has
On 04/02/2014 07:35 AM, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
+++ b/configure.ac
@@ -563,6 +563,10 @@ AC_ARG_WITH([chrdev-lock-files],
[location for
On 04/02/2014 08:06 AM, Daniel P. Berrange wrote:
Rather than having a hardcoded choice of pm-utils vs systemd
I think we should check if the systemd service is running and
if so use it, otherwise fallback to pm-utils. That way if
someone has systemd installed, but is not running it as
On 04/02/2014 04:26 PM, Eric Blake wrote:
On 04/02/2014 07:26 AM, Ján Tomko wrote:
Coverity complains about a possible leak of seclabel if
!sec_managers[i]-drv-domainGenSecurityLabel is true
and the seclabel might be overwritten by the next iteration
of the loop.
This leak should never
Hi everyone,
When doing a live migration, Linux guests will frequently get stuck and
become unresponsive, while the CPU utilization on the host for that
guest goes to 100%. If you wait long enough, the guest seems to always
recover, with a dmesg entry such as:
Clocksource tsc unstable (delta
Currently VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the error APIs.
Rename the VOL_OPEN_ERROR flag to VOL_OPEN_NOERROR. If NOERROR is
On 04/02/2014 09:54 AM, Cole Robinson wrote:
Currently VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the error APIs.
Rename the
On 04/02/2014 12:36 PM, Eric Blake wrote:
On 04/02/2014 09:54 AM, Cole Robinson wrote:
Currently VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message
On 03/31/2014 03:43 PM, Eric Blake wrote:
On 03/31/2014 10:00 AM, Julio Faracco wrote:
Hi everybody!
I sent an e-mail to Daniel asking about contributing to the libvirt
community for free.
So, I copied the e-mail to the libvirt mailing list as Daniel suggested me.
If anyone can help me I'd
Currently, adding any sort of IPv6 nwfilter rules is rather difficult. There
are no standard rules,
and you end up doing a lot of things by hand. This patch makes the $V6LOCAL
variable available within
rules. This is the generated from the interface's mac address using the
modified EUI-64
On 04/02/2014 01:40 PM, Brian Rak wrote:
Currently, adding any sort of IPv6 nwfilter rules is rather difficult. There
are no standard rules,
Long lines; we tend to keep commit messages wrapped around 72 columns or
so ('git log' adds indentation, and commits start to look stupid in the
On 04/02/2014 01:56 PM, Eric Blake wrote:
On 04/02/2014 01:40 PM, Brian Rak wrote:
Currently, adding any sort of IPv6 nwfilter rules is rather difficult.
There are no standard rules,
Also worth an example of what this will contain (such as
fe80::5254:00ff:fe1a:0a6d).
+
On 4/2/2014 3:56 PM, Eric Blake wrote:
On 04/02/2014 01:40 PM, Brian Rak wrote:
Currently, adding any sort of IPv6 nwfilter rules is rather difficult. There
are no standard rules,
Long lines; we tend to keep commit messages wrapped around 72 columns or
so ('git log' adds indentation, and
On 4/2/2014 4:11 PM, Eric Blake wrote:
On 04/02/2014 01:56 PM, Eric Blake wrote:
On 04/02/2014 01:40 PM, Brian Rak wrote:
Currently, adding any sort of IPv6 nwfilter rules is rather difficult. There
are no standard rules,
Also worth an example of what this will contain (such as
On 3/28/14 12:08 , Tomoki Sekiyama tomoki.sekiy...@hds.com wrote:
On 3/27/14 20:32 , Eric Blake ebl...@redhat.com wrote:
On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote:
This sounds reasonable for me to add disks parameters.
I will try adding them in next version. Then the api will look like:
No need to spawn a child 'rm' process when we can do it ourselves.
* tests/virstoragetest.c (testCleanupImages): Use dedicated
helper.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the trivial rule.
tests/virstoragetest.c | 6 +-
1 file changed, 1 insertion(+), 5
63 matches
Mail list logo
