http://codereview.appspot.com/5440084/diff/11001/scm/modal-transforms.scm
File scm/modal-transforms.scm (right):
http://codereview.appspot.com/5440084/diff/11001/scm/modal-transforms.scm#newcode129
scm/modal-transforms.scm:129: (define (make-scale music)
On 2012/01/20 23:02:21, Carl wrote:
I'm
Am 21.01.2012 00:10, schrieb Pavel Roskin:
On Fri, 20 Jan 2012 17:58:47 +0100
Stefan Weil wrote:
Hi,
tre
my last two patches were sent inline (with git send-email),
but I just learned that they should have been appended instead.
So here are both patches again. Both fix some spelling issues.
B
2012/1/21 James :
> Hello,
>
> On 20 January 2012 16:58, Stefan Weil wrote:
>> Hi,
>>
>> my last two patches were sent inline (with git send-email),
>> but I just learned that they should have been appended instead.
>>
>> So here are both patches again. Both fix some spelling issues.
>>
>> Kind re
Hello,
On 20 January 2012 16:58, Stefan Weil wrote:
> Hi,
>
> my last two patches were sent inline (with git send-email),
> but I just learned that they should have been appended instead.
>
> So here are both patches again. Both fix some spelling issues.
>
> Kind regards,
>
> Stefan Weil
>
I'd o
On Fri, 20 Jan 2012 17:58:47 +0100
Stefan Weil wrote:
> Hi,
>
> my last two patches were sent inline (with git send-email),
> but I just learned that they should have been appended instead.
>
> So here are both patches again. Both fix some spelling issues.
By the way, somebody please run codes
Wow -- what a lot of work. And it really seems to be cleaning things
up!
Thanks!
http://codereview.appspot.com/5440084/diff/11001/scm/modal-transforms.scm
File scm/modal-transforms.scm (right):
http://codereview.appspot.com/5440084/diff/11001/scm/modal-transforms.scm#newcode129
scm/modal-tran
On 2012/01/20 17:59:40, Neil Puttock wrote:
I can't think of anything better than adding another type such as
`command-event' to things like TempoChangeEvent and MarkEvent and
filtering that out too.
Emacs stands for "Editor Macros".
;; Keyboard Macro Editor. Press C-c C-c to finish; press C
Greetings!
After a long hiatus, the
LilyPond Report #23
http://news.lilynet.net/?The-LilyPond-Report-23>
has been released on 2012-01-20. The report contains current news about
the development of LilyPond, the GNU Music Typesetter
http://www.lilypond.org/> and features an art
On 20 January 2012 17:32, David Kastrup wrote:
> n.putt...@gmail.com writes:
>
>> Hi David,
>>
>> Should I wait for a new patch or can I test using the latest one here?
>>
>> I've tried it out briefly on a real music example, and have a problem
>> with identifiers:
>>
>> foo = \mark \default
>>
>>
On 2012/01/20 17:33:44, dak wrote:
mailto:n.putt...@gmail.com writes:
> Hi David,
>
> Should I wait for a new patch or can I test using the latest one
here?
>
> I've tried it out briefly on a real music example, and have a
problem
> with identifiers:
>
> foo = \mark \default
>
> \relative
n.putt...@gmail.com writes:
> Hi David,
>
> Should I wait for a new patch or can I test using the latest one here?
>
> I've tried it out briefly on a real music example, and have a problem
> with identifiers:
>
> foo = \mark \default
>
> \relative c' {
> \foo
> c1
> }
You have the newest. The
Hi,
my last two patches were sent inline (with git send-email),
but I just learned that they should have been appended instead.
So here are both patches again. Both fix some spelling issues.
Kind regards,
Stefan Weil
>From 808f92bccd5efff1348d614209d933da98f37ac2 Mon Sep 17 00:00:00 2001
From
2012/1/20 Stefan Weil :
> Signed-off-by: Stefan Weil
> 1.7.2.5
Applied, thanks. It would be better if you send patches as an
attachment. Also, to keep your name in the author field you should
make the patch with the git format-patch command.
--
Francisco Vila. Badajoz (Spain)
www.paconet.org ,
Hi David,
Should I wait for a new patch or can I test using the latest one here?
I've tried it out briefly on a real music example, and have a problem
with identifiers:
foo = \mark \default
\relative c' {
\foo
c1
}
-> error: syntax error, unexpected EVENT_IDENTIFIER
\foo
If I add a note
Signed-off-by: Stefan Weil
---
python/convertrules.py |2 +-
1 file changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/convertrules.py b/python/convertrules.py
index 32cb5a5..b7d845f 100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -392,7 +392,7 @@ def conv (str)
2012/1/20 Stefan Weil :
> Salut,
>
> my patch also fixes the English text in python/convertrules.py.
>
> As soon as this file is changed, all po files no longer have a
> translation for this text because they are still referring to the
> old wrong text. That's a scenario which is not handled by the
Am 20.01.2012 09:02, schrieb Lilyfan:
Message du 20/01/12 03:42
De : "Stefan Weil"
A : lilypond-devel@gnu.org
Copie à : "Stefan Weil"
Objet : [PATCH 1/2] Fix spelling definiton -> definition
Signed-off-by: Stefan Weil ---
po/cs.po
po/de.po
po/el.po
po/es.po
po/fr.po
po/it.po
po/ja.po
po/lilypond
On 2012/01/20 15:33:07, dak wrote:
Should I be forking the rhythmic-music-iterator stuff into the
separate review
I'd say leave it with this - it's easy to forget that two patches need
to be tested in concert.
http://codereview.appspot.com/5440084/
___
On 2012/01/20 14:55:38, dak wrote:
On 2012/01/20 14:08:18, MikeSol wrote:
> Otherwise, it's better to use the C++ function. In this case:
> ly_is_listened_event_class
> (in translator.cc)
Will do.
Very funny. After putting the (required) prototype into
translator.hh, it takes hours to r
On 2012/01/20 14:08:18, MikeSol wrote:
http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc
File lily/rhythmic-music-iterator.cc (right):
http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc#newcode62
lily/rhythmic-music-iterator.cc:62:
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy#newcode432
lily/parser.yy:432: %type list_music
On 2012/01/20 13:55:56, md5i wrote:
I must *strongly* recommend that the name of either mus
http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc
File lily/rhythmic-music-iterator.cc (right):
http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc#newcode62
lily/rhythmic-music-iterator.cc:62: if (scm_is_true
ly_lily_module_constant sh
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy#newcode432
lily/parser.yy:432: %type list_music
I must *strongly* recommend that the name of either music_list or
list_music be changed. Ev
LGTM
http://codereview.appspot.com/5504092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/5553056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/5557056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM. Good job, Carl!
http://codereview.appspot.com/5539062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Ok, this latest iteration is quite close to what I want to end up
committing. All the work of picking apart articulations and events have
gone into the rhythmic event iterator. What it does is to broadcast all
articulations that have a listener, and keep the rest as articulations.
One side effe
> Message du 20/01/12 09:15
> De : "James"
> A : "Lilyfan"
> Copie à : "StefanWeil" , lilypond-devel@gnu.org
> Objet : Re: [PATCH 1/2] Fix spelling definiton -> definition
>
> Jean-Charles,
>
> On 20 January 2012 08:02, Lilyfan wrote:
> >
> >> Message du 20/01/12 03:42
> >> De : "Stefan Weil"
> >>
Jean-Charles,
On 20 January 2012 08:02, Lilyfan wrote:
>
>> Message du 20/01/12 03:42
>> De : "Stefan Weil"
>> A : lilypond-devel@gnu.org
>> Copie à : "Stefan Weil"
>> Objet : [PATCH 1/2] Fix spelling definiton -> definition
>>
>> Signed-off-by: Stefan Weil ---
>> po/cs.po
...
>
> Please *never*
> Message du 20/01/12 03:42
> De : "Stefan Weil"
> A : lilypond-devel@gnu.org
> Copie à : "Stefan Weil"
> Objet : [PATCH 1/2] Fix spelling definiton -> definition
>
> Signed-off-by: Stefan Weil ---
> po/cs.po
> po/de.po
> po/el.po
> po/es.po
> po/fr.po
> po/it.po
> po/ja.po
> po/lilypond.pot
> po/
31 matches
Mail list logo
