Problem with staging?

2016-02-28 Thread James Lowe
Hello, Seems Hosoda-san's checkin is still in staging after 18 hours. My build machine (where I run patchy merge) is in my office which I don't currently have access to so I'll try to merge and push from home (now) and see what the problem is. Regards -- James --- ___

Re: Issue 4779: Accept isolated durations as music function arguments (issue 288380043 by d...@gnu.org)

2016-02-28 Thread dak
Reviewers: HoangMinh, git, Message: On 2016/02/28 07:26:06, git wrote: Is it OK to use tabs for indentation? It looks like whenever the original code did use them the modified code also uses them, even for subsequently added lines, while any *new* lines that don't refer to existing code are

Re: Problem with staging?

2016-02-28 Thread James Lowe
On 28/02/16 08:43, James Lowe wrote: Hello, Seems Hosoda-san's checkin is still in staging after 18 hours. My build machine (where I run patchy merge) is in my office which I don't currently have access to so I'll try to merge and push from home (now) and see what the problem is. Regards

Re: Problem with staging?

2016-02-28 Thread David Kastrup
James Lowe writes: > On 28/02/16 08:43, James Lowe wrote: >> Hello, >> >> Seems Hosoda-san's checkin is still in staging after 18 hours. >> >> My build machine (where I run patchy merge) is in my office which I >> don't currently have access to so I'll try to merge and push from >> home (now) and

Re: Issue 4779: Accept isolated durations as music function arguments (issue 288380043 by d...@gnu.org)

2016-02-28 Thread dak
On 2016/02/28 08:57:33, dak wrote: On 2016/02/28 07:26:06, git wrote: > Is it OK to use tabs for indentation? > It looks like whenever the original code did use them the modified code also > uses them, even for subsequently added lines, while any *new* lines that don't > refer to existing cod

Re: Problem with staging?

2016-02-28 Thread James Lowe
David, On 28/02/16 09:19, David Kastrup wrote: James Lowe writes: On 28/02/16 08:43, James Lowe wrote: Hello, Seems Hosoda-san's checkin is still in staging after 18 hours. My build machine (where I run patchy merge) is in my office which I don't currently have access to so I'll try to mer

Re: Embed LilyPond source files inside generated PDF (issue 225040043 by v.villen...@gmail.com)

2016-02-28 Thread hohoangminh656
On 2016/02/23 18:15:59, Valentin Villenave wrote: Ngày 2016/02/23 18:07:39, Valentin Villenave đã viết: > File nguồn truy cập chỉ qua LilyPond. Nó sẽ được tốt đẹp nếu chúng ta có thể chỉ định một tác giả / mô tả cho từng nguồn file ... nhưng như xa như tôi có thể thấy, có một loạt các "chưa

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread dak
It seems to me (after glancing over it) like the last Rietveld review was just abandoned and the same state resubmitted. Any reason the suggestions have not been addressed? https://codereview.appspot.com/288290043/diff/40001/Documentation/notation/pitches.itely File Documentation/notation/pitch

Re: Embed LilyPond source files inside generated PDF (issue 225040043 by v.villen...@gmail.com)

2016-02-28 Thread dak
https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc File lily/sources.cc (right): https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode93 lily/sources.cc:93: (SCM parser_smob), Maybe make the parser_smob argument optional? It can be deduced via the %parse

Musicxml: Fix musicxml.py for Reg Test 42a (issue 286480043 by pkx1...@gmail.com)

2016-02-28 Thread pkx166h
Reviewers: , Message: Passes make, make check and a full make doc. Description: Musicxml: Fix musicxml.py for Reg Test 42a MusicXML regression test 42a-MultiVoice-TwoVoicesOnStaff-Lyrics.xml is missing the first note in voice 2. Subsequently the lyrics of voice 2 is moved one note to the right

Re: Embed LilyPond source files inside generated PDF (issue 225040043 by v.villen...@gmail.com)

2016-02-28 Thread v . villenave
OK, new version. The new "fluid" parser variable is noticeably nicer to work with than what we had before. https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc File lily/sources.cc (right): https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode93 lily/sour

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread v . villenave
On 2016/02/28 12:18:29, dak wrote: It seems to me (after glancing over it) like the last Rietveld review was just abandoned and the same state resubmitted. Greetings David, not entirely. I’ve removed the pointless convert-rules, among others. Any reason the suggestions have not been addres

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread dak
Thanks. I really think we are better off without "francais". I think the original motivation of "espanol" was to avoid trouble with loading "español.ly" (which would have been the original interface to languages) system-independently. https://codereview.appspot.com/288290043/diff/40001/scm/def

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread Francisco Vila
2016-02-28 22:01 GMT+01:00 : > Thanks. I really think we are better off without "francais". I think > the original motivation of "espanol" was to avoid trouble with loading > "español.ly" (which would have been the original interface to languages) > system-independently. I vote for keeping 'esp

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread David Kastrup
Francisco Vila writes: > 2016-02-28 22:01 GMT+01:00 : >> Thanks. I really think we are better off without "francais". I think >> the original motivation of "espanol" was to avoid trouble with loading >> "español.ly" (which would have been the original interface to languages) >> system-independ

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread Valentin Villenave
On Sun, Feb 28, 2016 at 11:07 PM, David Kastrup wrote: > I haven't seen a single reason why anyone would be wanting to use > "francais" for specifying a notename language that calls d "ré". I’m fairly certain that it wouldn’t be used, ever. (Voluntarily, that is.) So this is a point I can grant y

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread Francisco Vila
El 28/02/2016 23:12, "David Kastrup" escribió: > > Francisco Vila writes: > > > 2016-02-28 22:01 GMT+01:00 : > >> Thanks. I really think we are better off without "francais". I think > >> the original motivation of "espanol" was to avoid trouble with loading > >> "español.ly

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread David Kastrup
Valentin Villenave writes: > On Sun, Feb 28, 2016 at 11:07 PM, David Kastrup wrote: >> I haven't seen a single reason why anyone would be wanting to use >> "francais" for specifying a notename language that calls d "ré". > > I’m fairly certain that it wouldn’t be used, ever. (Voluntarily, that >

Re: Define French as a separate input language (issue 288290043 by v.villen...@gmail.com)

2016-02-28 Thread Valentin Villenave
On Mon, Feb 29, 2016 at 12:32 AM, David Kastrup wrote: > Seriously? I mean, no German would think about leaving off umlauts from > a letter under any circumstance Well, in German it can alter the meaning (or at least distinguish between plural and singular). In French it’s a bit rarer. (Although

Commit access

2016-02-28 Thread Paul Morris
In issue 4776 James wrote: > @Paul, you may want to apply for commit access yourself if you like as I > think you've done enough work for the 'cause' to So I’d like to request commit access. Among other things this will save James the extra work of committing patches for me. -Paul __