Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> At that day I was having one patchy run after the other and I did go >> through the log files to indicate the failed file and the error message. > > Yep, and I asked for additional info both on the tracker and on > Rietveld; the on

Re: GS version conflict in packaged 2.20 and 2.21

2020-04-19 Thread Simon Albrecht
On 19.04.20 20:27, Werner LEMBERG wrote: Do we have a warning somewhere in the LilyPond documentation that people must not use the binary directly but the wrapper? Simon, have you tried to find something in the docs? If yes, what keywords were you looking for? I have no idea from where I mig

Re: Rewrite Skyline code (issue 547980044 by hanw...@gmail.com)

2020-04-19 Thread dak
On 2020/04/19 21:43:26, hanwenn wrote: > (this still needs some work, but the speedup might be worth an early look) * Buildings store Y coordinate of the left edge, rather than the intercept at x==0.0. This avoid excessive rounding problems when X is large, and lets us compute building.height

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > At that day I was having one patchy run after the other and I did go > through the log files to indicate the failed file and the error message. Yep, and I asked for additional info both on the tracker and on Rietveld; the only reply I did get was from James who

Rewrite Skyline code (issue 547980044 by hanw...@gmail.com)

2020-04-19 Thread hanwenn
Reviewers: , Message: (this still needs some work, but the speedup might be worth an early look) Description: Rewrite Skyline code With this change, Carver MSDM goes from 38 seconds to 32 seconds, a 15% improvement. * Do not use contiguous buildings. Instead, Y=-infinity is represented by sim

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
Jonas Hahnfeld writes: > Am Sonntag, den 19.04.2020, 22:16 +0200 schrieb David Kastrup: >> pkx1...@posteo.net >> writes: >> >> > Hello, >> > >> > On 19/04/2020 17:53, David Kastrup wrote: >> > > v.villen...@gmail.com >> > > writes: >> > > >> > > > On 2020/04/11 09:44:26, Valentin Villenave w

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 22:16 +0200 schrieb David Kastrup: > pkx1...@posteo.net > writes: > > > Hello, > > > > On 19/04/2020 17:53, David Kastrup wrote: > > > v.villen...@gmail.com > > > writes: > > > > > > > On 2020/04/11 09:44:26, Valentin Villenave wrote: > > > > > What could be the cau

Re: Patchy email

2020-04-19 Thread Thomas Morley
Am So., 19. Apr. 2020 um 21:59 Uhr schrieb Jonas Hahnfeld : > > Am Sonntag, den 19.04.2020, 18:20 + schrieb Valentin Villenave: > > On 4/19/20, David Kastrup < > > d...@gnu.org > > > wrote: > > > mkstemp! does not generate a string. It overwrites an existing string > > > in-place, and that's b

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
pkx1...@posteo.net writes: > Hello, > > On 19/04/2020 17:53, David Kastrup wrote: >> v.villen...@gmail.com writes: >> >>> On 2020/04/11 09:44:26, Valentin Villenave wrote: What could be the cause? >>> So, pushed as >>> https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85a

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread pkx166h
Hello, On 19/04/2020 17:53, David Kastrup wrote: v.villen...@gmail.com writes: On 2020/04/11 09:44:26, Valentin Villenave wrote: What could be the cause? So, pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 V. https://codereview.a

Re: Patchy email

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 18:20 + schrieb Valentin Villenave: > On 4/19/20, David Kastrup < > d...@gnu.org > > wrote: > > mkstemp! does not generate a string. It overwrites an existing string > > in-place, and that's bad news for a literal string. > > Yes, it overwrite the string, opens a p

Re: Patchy email

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 20:57 +0200 schrieb David Kastrup: > Jonas Hahnfeld writes: > > So I guess the fix is to delete the (temporary) directory and all > > contained files? And maybe putting it under /tmp? > > > > Oh, and ignore my comment that I had tested this with Guile 2.2. Looks > > li

Re: Patchy email

2020-04-19 Thread David Kastrup
Jonas Hahnfeld writes: > Am Sonntag, den 19.04.2020, 20:03 +0200 schrieb David Kastrup: >> David Kastrup < >> d...@gnu.org >> > writes: >> >> > David Kastrup < >> > d...@gnu.org >> > > writes: >> > >> > > David Kastrup < >> > > d...@gnu.org >> > > > writes: >> > > >> > > > Valentin Villenave <

Re: Patchy email

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> mkstemp! does not generate a string. It overwrites an existing string >> in-place, and that's bad news for a literal string. > > Yes, it overwrite the string, You can/must not override a literal string. It's read-only. > opens

Re: Patchy email

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 20:03 +0200 schrieb David Kastrup: > David Kastrup < > d...@gnu.org > > writes: > > > David Kastrup < > > d...@gnu.org > > > writes: > > > > > David Kastrup < > > > d...@gnu.org > > > > writes: > > > > > > > Valentin Villenave < > > > > valen...@villenave.net > > > >

Re: Patchy email

2020-04-19 Thread Werner LEMBERG
>>> Does anybody have an idea _what_ and _why_ would leave a .uuid >>> file lying around in the temporary file with, well, an uuid kind >>> of number in it? Is that an artifact of my freetype library or >>> something? Definitely not FreeType, but... >> Seems to be something that fontconfig doe

Re: GS version conflict in packaged 2.20 and 2.21

2020-04-19 Thread Werner LEMBERG
> [...] As Jonas Hahnfeld pointed out, the problem was calling (within > the installation directory) the unwrapped binary > ./lilypond/usr/bin/lilypond (which then relied on the system default > GS) instead of the wrapper script ./bin/lilypond (which sets > environment variables such as to use t

Re: Patchy email

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > mkstemp! does not generate a string. It overwrites an existing string > in-place, and that's bad news for a literal string. Yes, it overwrite the string, opens a port, then I read the port-filename which should be an _other_ string object, shouldn’t it? (sigh -

Re: Patchy email

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > So I am afraid that things are rather weird at my side: > -rw-r--r-- 1 dak dak 36 Apr 19 19:51 .uuid > dak@lola:/usr/local/tmp/lilypond2$ cat dummyfont-C5PUYM-dir/.uuid > 35d52a4b-44f7-41b6-afca-165a4187aa4f WTF. Could it be some trace left due to your filesy

Re: Patchy email

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> You need (mkstemp! (string-copy "... >> because mkstemp! overrides the string. > > Why, yes. What I want to copy is precisely the mkstemp-generated > string. What did I miss? mkstemp! does not generate a string. It overwrites an

Re: Patchy email

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > You need (mkstemp! (string-copy "... > because mkstemp! overrides the string. Why, yes. What I want to copy is precisely the mkstemp-generated string. What did I miss? V.

Re: Patchy email

2020-04-19 Thread David Kastrup
David Kastrup writes: > David Kastrup writes: > >> David Kastrup writes: >> >>> Valentin Villenave writes: >>> On 4/19/20, David Kastrup wrote: > Note that the delete-file instructions are executed while the book is > being read in while markup is typeset when the books are being

Re: Patchy email

2020-04-19 Thread David Kastrup
David Kastrup writes: > David Kastrup writes: > >> Valentin Villenave writes: >> >>> On 4/19/20, David Kastrup wrote: Note that the delete-file instructions are executed while the book is being read in while markup is typeset when the books are being processed at the end of the

Re: Rendering chords in "Danish" style

2020-04-19 Thread Valentin Villenave
On 4/19/20, Michael Bisgaard Olesen wrote: > *(Resending because it didn't seem to go through the first time)* Greetings, if you’re subscribed to the -devel list, your messages should go through immediately. Perhaps your first message got stuck because your address was not subscribed yet and as s

Re: Patchy email

2020-04-19 Thread David Kastrup
David Kastrup writes: > Valentin Villenave writes: > >> On 4/19/20, David Kastrup wrote: >>> Note that the delete-file instructions are executed while the book is >>> being read in while markup is typeset when the books are being processed >>> at the end of the input file. >> >> Yes, it looked

Re: Patchy email

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> ERROR: In procedure mkstemp!: >> string is read-only: "kaka-XX" > > Could the following help? > > diff --git a/input/regression/font-name-add-files.ly > b/input/regression/font-name-add-files.ly > index 33f73f0c68..264e2b6532

Re: GS version conflict in packaged 2.20 and 2.21

2020-04-19 Thread Simon Albrecht
On 19.04.20 16:56, Valentin Villenave wrote: Yes, a French user also had some gs issues that I think may be related to yours: https://lists.gnu.org/archive/html/lilypond-user-fr/2020-04/msg00164.html That seems to be the same usage issue—see my parallel reply or the -user thread. Best, Simo

Re: GS version conflict in packaged 2.20 and 2.21

2020-04-19 Thread Simon Albrecht
On 18.04.20 01:46, Simon Albrecht wrote: Hello everyone, it appears from this exchange that the packaged versions of 2.20.0 and 2.21.0 contain a mixture of GS 9.21 and 9.26. Is that correct/expected/a known issue? N

Re: Patchy email

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> Note that the delete-file instructions are executed while the book is >> being read in while markup is typeset when the books are being processed >> at the end of the input file. > > Yes, it looked completely bonkers to me as well,

Re: Patchy email

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > Note that the delete-file instructions are executed while the book is > being read in while markup is typeset when the books are being processed > at the end of the input file. Yes, it looked completely bonkers to me as well, until I realized it worked :-) > No

Re: Patchy email

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > ERROR: In procedure mkstemp!: > string is read-only: "kaka-XX" Could the following help? diff --git a/input/regression/font-name-add-files.ly b/input/regression/font-name-add-files.ly index 33f73f0c68..264e2b6532 100644 --- a/input/regression/font-name-add

Re: ly:page-turn-breaking core dumps

2020-04-19 Thread Pierre-Luc Gauthier
Voilà qui est fait Valentin. :-) C'est juste que -user et -devel sont déjà beaucoup pour ma très humble capacité de suivi. Le dim. 19 avr. 2020 à 10:47, Valentin Villenave a écrit : > > On 4/17/20, Pierre-Luc Gauthier wrote: > > Sorry for necro-following-through so late in the issue. > > If I ma

Re: Patchy email

2020-04-19 Thread David Kastrup
Jonas Hahnfeld writes: > Am Sonntag, den 19.04.2020, 19:07 +0200 schrieb David Kastrup: >> Jonas Hahnfeld < >> hah...@hahnjo.de >> > writes: >> >> > Am Sonntag, den 19.04.2020, 18:59 +0200 schrieb David Kastrup: >> > > pat...@gnu.org >> > > >> > > writes: >> > > >> > > > 16:36:18 (UTC) Begin

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > v.villen...@gmail.com writes: > Breaks my patchy again. Whose patchy was comfortable moving it from > staging to master? Well, at any rate James’ patchy what fine with it. (As it went through the review/countdown process not just once but twice.) The regtest a

Re: Patchy email

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 19:07 +0200 schrieb David Kastrup: > Jonas Hahnfeld < > hah...@hahnjo.de > > writes: > > > Am Sonntag, den 19.04.2020, 18:59 +0200 schrieb David Kastrup: > > > pat...@gnu.org > > > > > > writes: > > > > > > > 16:36:18 (UTC) Begin LilyPond compile, previous commit at

Re: Patchy email

2020-04-19 Thread David Kastrup
Jonas Hahnfeld writes: > Am Sonntag, den 19.04.2020, 18:59 +0200 schrieb David Kastrup: >> pat...@gnu.org >> writes: >> >> > 16:36:18 (UTC) Begin LilyPond compile, previous commit at >> > 12bf65758f33510e6b8e6e4d4a91bb1ebb459248 >> > 16:36:21 From ssh://git.sv.gnu.org/srv/git/lilypond >> >

Re: Patchy email

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 18:59 +0200 schrieb David Kastrup: > pat...@gnu.org > writes: > > > 16:36:18 (UTC) Begin LilyPond compile, previous commit at > > 12bf65758f33510e6b8e6e4d4a91bb1ebb459248 > > 16:36:21 From ssh://git.sv.gnu.org/srv/git/lilypond > >12bf65758f..0cfef7069e master

Re: Patchy email

2020-04-19 Thread David Kastrup
pat...@gnu.org writes: > 16:36:18 (UTC) Begin LilyPond compile, previous commit at > 12bf65758f33510e6b8e6e4d4a91bb1ebb459248 > 16:36:21 From ssh://git.sv.gnu.org/srv/git/lilypond >12bf65758f..0cfef7069e master -> origin/master >12bf65758f..0cfef7069e staging-> origin/stagin

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
v.villen...@gmail.com writes: > On 2020/04/11 09:44:26, Valentin Villenave wrote: >> What could be the cause? > > So, pushed as > https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 > > V. > > https://codereview.appspot.com/557640051/ Breaks my patch

Patchy email

2020-04-19 Thread patchy
16:36:18 (UTC) Begin LilyPond compile, previous commit at 12bf65758f33510e6b8e6e4d4a91bb1ebb459248 16:36:21 From ssh://git.sv.gnu.org/srv/git/lilypond 12bf65758f..0cfef7069e master -> origin/master 12bf65758f..0cfef7069e staging-> origin/staging 16:36:27 Merged staging, now a

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread v . villenave
On 2020/04/11 09:44:26, Valentin Villenave wrote: > What could be the cause? So, pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 V. https://codereview.appspot.com/557640051/

Re: Web: update documentation symlinks, and use https in RewriteRules (issue 551650043 by v.villen...@gmail.com)

2020-04-19 Thread v . villenave
Pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=b9255b50886e5e0de802a26fd486c908b0b55c0f https://codereview.appspot.com/551650043/

Re: Annoying 'langdefs.py' warning

2020-04-19 Thread Werner LEMBERG
>> Is there a way to suppress them? > > Well, submitting fixes? I looked into both issues some time ago, but couldn't find out a good solution. Thanks to your clean-ups I can imagine that it's now easier to handle both problems. > IIRC langdefs.py complains that we set LANG=C in the build > p

Re: Annoying 'langdefs.py' warning

2020-04-19 Thread Werner LEMBERG
>> [...] Is there a way to suppress them? > > I’ve been annoyed by these for quite some time as well. Is it worth > opening a tracker page? For me, it's not *that* annoying :-) Werner

Re: Annoying 'langdefs.py' warning

2020-04-19 Thread Jonas Hahnfeld
Am Donnerstag, den 16.04.2020, 12:14 +0200 schrieb Werner LEMBERG: > Building lilypond you get a bunch of harmless but annoying > > langdefs.py: warning: lilypond-doc gettext domain not found. > > and > > .../podir-targets.make:14: warning: ignoring old recipe for target > 'po-update' > >

Re: Annoying 'langdefs.py' warning

2020-04-19 Thread Jean-Charles Malahieude
Le 19/04/2020 à 16:17, Valentin Villenave a écrit : On 4/16/20, Werner LEMBERG wrote: Building lilypond you get a bunch of harmless but annoying langdefs.py: warning: lilypond-doc gettext domain not found. and .../podir-targets.make:14: warning: ignoring old recipe for target 'po-update'

Documentation: Remove deprecated skeleton-update (issue 545910043 by jonas.hahnf...@gmail.com)

2020-04-19 Thread jonas . hahnfeld
Reviewers: , Message: As I'm not doing translations myself, it would be great if somebody familiar with the process could comment on the faith of scripts/auxiliar/texi-skeleton-update.py: It's not failing, but to me doesn't look like doing anything helpful either. Description: Documentation: Remo

Re: GS version conflict in packaged 2.20 and 2.21

2020-04-19 Thread Valentin Villenave
On 4/17/20, Simon Albrecht wrote: > it appears from this exchange > > that the packaged versions of 2.20.0 and 2.21.0 contain a mixture of GS > 9.21 and 9.26. Yes, a French user also had some gs issues that I think may be re

Re: ly:page-turn-breaking core dumps

2020-04-19 Thread Valentin Villenave
On 4/17/20, Pierre-Luc Gauthier wrote: > Sorry for necro-following-through so late in the issue. If I may chime in, since it may appear from your name that you speak French, do feel free to subscribe to our French-speaking mailing list, where other contributors can help you investigate such quest

Re: Annoying 'langdefs.py' warning

2020-04-19 Thread Valentin Villenave
On 4/16/20, Werner LEMBERG wrote: > Building lilypond you get a bunch of harmless but annoying > langdefs.py: warning: lilypond-doc gettext domain not found. > and > .../podir-targets.make:14: warning: ignoring old recipe for target > 'po-update' > messages. Is there a way to suppress them?

Rendering chords in "Danish" style

2020-04-19 Thread Michael Bisgaard Olesen
*(Resending because it didn't seem to go through the first time)* Hi there. I recently stumbled upon this great project and thought I'd use it to render the score of a little melody with chords and lyrics. The song is in Danish and I'd like the chords to be rendered in the traditional Danish sty

Rendering chords in "Danish" style

2020-04-19 Thread Michael Bisgaard Olesen
Hi there. I recently stumbled upon this great project and thought I'd use it to render the score of a little melody with chords and lyrics. The song is in Danish and I'd like the to be rendered in the traditional Danish style. I don't know if this is Danish only (could be Scandinavian?), but I'l

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread dak
On 2020/04/19 11:03:35, hahnjo wrote: > On 2020/04/19 10:55:52, dak wrote: > I have the vague > > impression that the ability to do template specialisation on typedefs would > also > > be able to solve part of the job here in a more elegant manner but right now > my > > brain objects to more C++ st

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread jonas . hahnfeld
On 2020/04/19 10:55:52, dak wrote: > On 2020/04/19 09:55:03, hahnjo wrote: > > On 2020/04/19 09:39:00, dak wrote: > > > > > > https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh > > > File lily/include/callback.hh (right): > > > > > > > > > https://codereview.appspot.c

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread dak
On 2020/04/19 09:55:03, hahnjo wrote: > On 2020/04/19 09:39:00, dak wrote: > > > https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh > > File lily/include/callback.hh (right): > > > > > https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh#ne

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread jonas . hahnfeld
On 2020/04/19 09:39:00, dak wrote: > https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh > File lily/include/callback.hh (right): > > https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh#newcode166 > lily/include/callback.hh:166: typedef typ

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread dak
https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh File lily/include/callback.hh (right): https://codereview.appspot.com/551780043/diff/573720045/lily/include/callback.hh#newcode166 lily/include/callback.hh:166: typedef typename remove_pointer (nullptr)))>::type typ

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread jonas . hahnfeld
A huge THANK YOU for this cleanup and getting rid of my 'TRANSLATOR_INHERIT' workaround. One request for using C++ style inline. On the topic of 'C++ wizardry': While not completely straight-forward I think mfp_baseclass is small enough to get your head around it if needed. I mean half of it is re

Re: Obviate method_finder methods (issue 551780043 by d...@gnu.org)

2020-04-19 Thread dak
Reviewers: lemzwerg, Message: On 2020/04/19 05:53:34, lemzwerg wrote: > Nice! I don't really understand the C++ wizardry, but having to type less > macros in the normal code is certainly beneficial. The wizardry is comparatively confined and mainly consists of a more polished version of the mfp_

PATCHES - Countdown for April 19th

2020-04-19 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on April 21st A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5911 Use Interval for representing skyline X coordinates -