Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Issue 3830: Document \offset command Please review this at https://codereview.appspot.com/319150043/ Affected files (+142, -0 lines): M Documentation/notation/changing-defaults.itely __

Re: Can someone run makelsr on staging please?

On Sun, Jan 22, 2017 at 8:33 AM, David Nalesnik wrote: > On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup wrote: >> David Nalesnik writes: >> >>> On Sun, Jan 22, 2017 at 7:45 AM, James wrote: >>>> Hello, >>>> >>>> David Nalesnik

Re: Can someone run makelsr on staging please?

On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup wrote: > David Nalesnik writes: > >> On Sun, Jan 22, 2017 at 7:45 AM, James wrote: >>> Hello, >>> >>> David Nalesnik checked in a commit with a new snippet but forgot to push a >>> separ

Re: Can someone run makelsr on staging please?

On Sun, Jan 22, 2017 at 7:59 AM, David Nalesnik wrote: > On Sun, Jan 22, 2017 at 7:45 AM, James wrote: >> Hello, >> >> David Nalesnik checked in a commit with a new snippet but forgot to push a >> separate makelsr checkin to go with it so merge fails. >> >&g

Re: Can someone run makelsr on staging please?

On Sun, Jan 22, 2017 at 7:45 AM, James wrote: > Hello, > > David Nalesnik checked in a commit with a new snippet but forgot to push a > separate makelsr checkin to go with it so merge fails. > > Could someone do that as I currently at work today (lucky me) and won't have

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly File Documentation/snippets/new/moving-the-ends-of-hairpins.ly (right): https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly#newc

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

On 2017/01/08 11:37:18, thomasmorley651 wrote: On 2017/01/07 17:12:57, david.nalesnik wrote: > Please review. Thanks! Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } { \

Fix Texinfo error in new snippet (issue 311530043 by david.nales...@gmail.com)

Reviewers: , Message: Fix needed so that makelsr run will be successful. Adding a snippet as part of Issue 5029 depends on this fix. Description: Fix Texinfo error in new snippet Correct error in snippet introduced in commit 5944d20489bb5b8e4c4907fa3b3bcae9ec275ccb. Please review this at http

Re: Staging Broken with last makelsr - incorrect TexInfo commandformat

On Wed, Jan 11, 2017 at 10:44 AM, David Nalesnik wrote: > On Wed, Jan 11, 2017 at 10:25 AM, Trevor Daniels wrote: >> >> David Nalesnik wrote Wednesday, January 11, 2017 3:22 PM >> >> >>> Ok, so I will probably do >>> >>> git revert HEAD >

Re: Staging Broken with last makelsr - incorrect TexInfo commandformat

On Wed, Jan 11, 2017 at 1:52 PM, David Kastrup wrote: > David Nalesnik writes: > >> On Wed, Jan 11, 2017 at 12:31 PM, David Kastrup wrote: >>> >>> It's nicer to _remove_ the patch from staging instead of adding the >>> revert on top. However, t

Re: Staging Broken with last makelsr - incorrect TexInfo commandformat

On Wed, Jan 11, 2017 at 12:31 PM, David Kastrup wrote: > David Nalesnik writes: > >> On Wed, Jan 11, 2017 at 10:25 AM, Trevor Daniels wrote: >>> >>> David Nalesnik wrote Wednesday, January 11, 2017 3:22 PM >>> >>> >>>> Ok, so I will p

Re: Staging Broken with last makelsr - incorrect TexInfo commandformat

On Wed, Jan 11, 2017 at 10:59 AM, James wrote: > Hello, > > > > On 11/01/17 16:44, David Nalesnik wrote: >> >> On Wed, Jan 11, 2017 at 10:25 AM, Trevor Daniels >> wrote: >>> >>> David Nalesnik wrote Wednesday, January 11, 2017 3:22 PM >>

Re: Staging Broken with last makelsr - incorrect TexInfo commandformat

On Wed, Jan 11, 2017 at 10:25 AM, Trevor Daniels wrote: > > David Nalesnik wrote Wednesday, January 11, 2017 3:22 PM > > >> Ok, so I will probably do >> >> git revert HEAD >> >> in my staging branch >> >> and push it to origin/staging. >>

Re: Staging Broken with last makelsr - incorrect TexInfo command format

On Wed, Jan 11, 2017 at 9:00 AM, James wrote: > David > > > > On 11/01/17 14:31, David Nalesnik wrote: >> >> On Wed, Jan 11, 2017 at 8:26 AM, David Nalesnik >> wrote: >>> >>> On Wed, Jan 11, 2017 at 5:19 AM, James wrote: >>>> &

Re: adding a snippet to a patch

On Wed, Jan 11, 2017 at 3:27 AM, James wrote: > Hello, > > > On 11/01/17 08:08, Mark Knoop wrote: >> >> At 15:51 on 09 Jan 2017, David Nalesnik wrote: >>> >>> On Mon, Jan 9, 2017 at 2:00 PM, David Nalesnik >>> wrote: >>>> >>&

Re: Staging Broken with last makelsr - incorrect TexInfo command format

On Wed, Jan 11, 2017 at 8:26 AM, David Nalesnik wrote: > On Wed, Jan 11, 2017 at 5:19 AM, James wrote: >> Hello, >> >> The snippet 'using-marklines-in-a-frenched-score.ly' in the recent makelsr >> commit >> >> http://git.s

Re: Staging Broken with last makelsr - incorrect TexInfo command format

On Wed, Jan 11, 2017 at 5:19 AM, James wrote: > Hello, > > The snippet 'using-marklines-in-a-frenched-score.ly' in the recent makelsr > commit > > http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=5fd7d7d19803c8b1cfac6324381c86dcc057a433 > > contains a malformed TexInfo command > > @{M

Re: adding a snippet to a patch

Harm, On Mon, Jan 9, 2017 at 5:54 PM, Thomas Morley wrote: > 2017-01-10 0:36 GMT+01:00 David Nalesnik : >> After this: >> >> [lilypond-git (dev/lsr)]$ git pull -r origin staging >> From git://git.sv.gnu.org/lilypond >> * branchstaging-> FET

Re: adding a snippet to a patch

On Mon, Jan 9, 2017 at 4:16 PM, Trevor Daniels wrote: > I suggest running makelsr.py first, before applying your patch, > and push to staging. No need for a prior review. After this: [lilypond-git (dev/lsr)]$ git pull -r origin staging >From git://git.sv.gnu.org/lilypond * branchs

Re: adding a snippet to a patch

On Mon, Jan 9, 2017 at 2:00 PM, David Nalesnik wrote: > Hi, > > I'm adding a snippet to a patch dealing with hairpins, and I'm not > sure what I need to do. > > I've added the snippet to Documentation/snippets/new. > > Do I then need to run scripts/auxi

adding a snippet to a patch

Hi, I'm adding a snippet to a patch dealing with hairpins, and I'm not sure what I need to do. I've added the snippet to Documentation/snippets/new. Do I then need to run scripts/auxiliar/makelsr.py and add the resulting files to my patch for upload to Rietveld? The reason I ask is that there i

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

On 2017/01/08 11:37:18, thomasmorley651 wrote: On 2017/01/07 17:12:57, david.nalesnik wrote: > Please review. Thanks! Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } { \

Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Implement shorten-pair for Hairpin This property allows the user to offset the ends of hairpins independently. Please review this at https://codereview.appspot.com/315350043/ Affected files (+13, -4 lines): M lily/hairpin.cc M scm/

Re: Allow fixed spacing of symbols in church rests (issue 319910043 by david.nales...@gmail.com)

On 2016/12/30 16:59:55, Dan Eble wrote: On 2016/12/29 17:47:46, david.nalesnik wrote: > Please review. Thanks! I haven't reviewed the code, but the description makes me wonder, is the current behavior not a bug? Gould says "In tradition engraving," which appears to be her term for the st

Re: Allow fixed spacing of symbols in church rests (issue 319910043 by david.nales...@gmail.com)

Please see http://www.mail-archive.com/lilypond-user@gnu.org/msg117437.html https://codereview.appspot.com/319910043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow fixed spacing of symbols in church rests (issue 319910043 by david.nales...@gmail.com)

On 2016/12/30 16:59:55, Dan Eble wrote: On 2016/12/29 17:47:46, david.nalesnik wrote: > Please review. Thanks! I haven't reviewed the code, but the description makes me wonder, is the current behavior not a bug? Gould says "In tradition engraving," which appears to be her term for the st

Allow fixed spacing of symbols in church rests (issue 319910043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Allow fixed spacing of symbols in church rests By default, the symbols making up a church rest are spread to fill the available space in a measure. Setting the new property "church-rest-inner-padding" places symbols at the given distan

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode61 lily/self-alignment-interface.cc:61: return scm_from_double (- ext.li

Re: music function to be included somewhere in scm/*

On Fri, Dec 16, 2016 at 8:11 AM, David Nalesnik wrote: > On Fri, Dec 16, 2016 at 8:07 AM, Knut Petersen > wrote: >> Am 16.12.2016 um 14:38 schrieb Urs Liska: >>> >>> >>>> As your knowledge of scheme seems to be well developed, could you give >>&

Re: music function to be included somewhere in scm/*

On Fri, Dec 16, 2016 at 8:07 AM, Knut Petersen wrote: > Am 16.12.2016 um 14:38 schrieb Urs Liska: >> >> >>> As your knowledge of scheme seems to be well developed, could you give >>> a scheme equivalent of >>> >>> forceExtender = { \once \override LyricExtender.force-extender = ##t } >>> >>> that

Re: music function to be included somewhere in scm/*

Hi Knut, On Wed, Dec 14, 2016 at 3:16 AM, Knut Petersen wrote: > Hi everybody! > > There is a discussion on lilypond-user with the target to allow automated > lyric extenders > to lilypond. One part of that is a patch to clean and extend > lyric_extender.cc. > > To allow automated creation of lyr

Re: Musicxml2ly: Fix incorrect conversion of Minor Chords (issue 305700043 by pkx1...@gmail.com)

On Wed, Oct 12, 2016 at 5:52 AM, David Kastrup wrote: > Bonus points for recognizing the fragment... Toccata and Fugue in D minor, BWV 565? DN P.S. Sorry, nothing apropos the main topic! ___ lilypond-devel mailing list lilypond-devel@gnu.org https:/

Re: Help with Scheme engraver please

Hi Trevor, On Tue, Aug 23, 2016 at 3:54 PM, Trevor Daniels wrote: > Prompted by the recent discussion on lute tablature, I tried coding a Scheme > engraver to create the duration grobs but quickly ran into a problem. I need > to collect information from both a Listener and an Acknowledger so t

Re: scriptDefinitions context property

On Tue, May 24, 2016 at 7:12 PM, Carl Sorensen wrote: > According to the Internals Reference, scriptDefinitions is an internal > context property, meaning that the user should not change it. > > Why is this so? As far as I can see, scriptDefinitions is not defined > during engraving, but during i

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2016/01/23 22:11:03, david.nalesnik wrote: The patch was pushed after much of the discussion above. Shall I make another patch removing the functionality> Ugh--I mean pushed *before* much of the discussion. https://codereview.appspot.com/222810043/ __

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

The patch was pushed after much of the discussion above. Shall I make another patch removing the functionality> https://codereview.appspot.com/222810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lil

Re: ly:moment<=? ??

On Sun, Dec 20, 2015 at 7:08 PM, Simon Albrecht wrote: > Hello, > > while getting to terms with the accidentalStyle code I found that it would > be useful (currently only for dodecaphonic-no-repeat-rule, > scm/music-functions.scm:line 1682f.) to have a ly:moment<=? Scheme > predicate function. It

Re: multiple TextSpanners per voice

On Tue, Oct 20, 2015 at 11:50 AM, David Kastrup wrote: > Trevor Bača writes: > > > Hi, > > > > I'd like to add that I'm *incredibly* excited by this work. The ability > to > > have multiple text spanners in a voice -- and to tweak each independently > > -- is something I've wanted in LilyPond fo

Re: multiple TextSpanners per voice

Ok, this should do it. The intention is to provide extra functionality to text spanners. By using this code, you have all the functionality of normal text spanners, but you are able to have multiple spanners per voice. You simply need to swap the regular engraver for this one in a layout block,

Re: multiple TextSpanners per voice

On Sat, Oct 3, 2015 at 12:02 PM, David Nalesnik wrote: > > > So here is a revised version of the TextSpanner code. > > Oh *drat* Attached the wrong file. Apologies... DN \version "2.19" %% Based on the rewrite of Text_spanner_engraver in %% input/regression/scheme-

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 5:59 PM, David Nalesnik wrote: > > > On Fri, Oct 2, 2015 at 5:49 PM, David Nalesnik > wrote: > >> >> Horizontal_bracket_engraver achieves correct ordering of nested brackets >> through the side-position-interface array 'side-positi

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 5:49 PM, David Nalesnik wrote: > > Horizontal_bracket_engraver achieves correct ordering of nested brackets > through the side-position-interface array 'side-position-elements. > Brackets closer to the staff are added to the support of brackets further

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 12:09 PM, David Nalesnik wrote: > David, > > On Fri, Oct 2, 2015 at 11:26 AM, David Kastrup wrote: > >> David Nalesnik writes: >> >> > Hi all, >> > >> > I'm experimenting with a way to support multiple text s

Re: multiple TextSpanners per voice

Michael, On Fri, Oct 2, 2015 at 11:33 AM, Michael Gerdau wrote: > > > The second example shows that tweaks can mess up this reversed ordering > > > even further. > > > > > > Does anyone know what is happening here? I really have no idea :( > > > > Here's an image. > > > > (I'm running 2.19.27 w

Re: multiple TextSpanners per voice

David, On Fri, Oct 2, 2015 at 11:26 AM, David Kastrup wrote: > David Nalesnik writes: > > > Hi all, > > > > I'm experimenting with a way to support multiple text spanners in a > single > > voice, using the 'spanner-id property which already enab

multiple TextSpanners per voice

Hi all, I'm experimenting with a way to support multiple text spanners in a single voice, using the 'spanner-id property which already enables multiple slurs and phrasing slurs. The attached code works--until the spanners cross a line break. Then the order of the spanners is reversed. I've expe

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 10:00 AM, David Nalesnik wrote: > Hi all, > > I'm experimenting with a way to support multiple text spanners in a single > voice, using the 'spanner-id property which already enables multiple slurs > and phrasing slurs. > > The attached code

Re: Doc: Usage - Updated 'Running LilyPond' intros (issue 261240043 by pkx1...@gmail.com)

https://codereview.appspot.com/261240043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/261240043/diff/1/Documentation/usage/running.itely#newcode36 Documentation/usage/running.itely:36: information on where to download or

Re: Fix regtest "dynamics-broken-hairpin.ly" (issue 258470044 by simon.albre...@mail.de)

https://codereview.appspot.com/258470044/diff/1/input/regression/dynamics-broken-hairpin.ly File input/regression/dynamics-broken-hairpin.ly (right): https://codereview.appspot.com/258470044/diff/1/input/regression/dynamics-broken-hairpin.ly#newcode1 input/regression/dynamics-broken-hairpin.ly:1

Re: Rietveld diff annoyance

On Wed, Aug 26, 2015 at 12:18 PM, David Nalesnik wrote: > Hi all, > > I just posted a patch on Rietveld, It adds a new file, which I partially > constructed by cutting and pasting from > lily/pointer-group-interface-scheme.cc into Leafpad (just the initial > comment). Unfor

Rietveld diff annoyance

Hi all, I just posted a patch on Rietveld, It adds a new file, which I partially constructed by cutting and pasting from lily/pointer-group-interface-scheme.cc into Leafpad (just the initial comment). Unfortunately, Rietveld now shows the diff with that file, though the patch doesn't touch it. h

Re: Shared Rests

Dan, > Am 22. August 2015 05:19:43 MESZ, schrieb Dan Eble : > >Can anyone offer general architectural advice for adding the option for > >parts on the same staff to share rests when possible? I mean without > >using \partcombine. I’d like to focus on multi-measure rests first. > >Roughly, I gue

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

LGTM. Thanks again! https://codereview.appspot.com/250590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Yet compare the output of { \offset Y-offset #-5 DynamicLineSpanner \repeat unfold 200 { c'2\f\< c'2\! } } with { \override DynamicLineSpanner.Y-offset = #-15 \repeat unfold 200 { c'2\f\< c'2\! } } Shouldn't the offset to the result of calling the pure function result in be

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Here's two snippets that show \offset working with unpure-pure containers, one with the override form, the second using the tweak form. { c'4\f\< c'4\! \offset Y-offset -2 DynamicLineSpanner c'4\f\< c'4\! c'2 \offset length 2 Stem c'2 } { c'4\f\< c'4\! c'4\f-\offset DynamicLineSpanner

Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Thanks for doing this. The restructuring is a big improvement. https://codereview.appspot.com/250590043/diff/1/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/250590043/diff/1/scm/music-functions.scm#newcode2331 scm/music-functions.scm:2331: (offset

Re: interactive sheet music experiment

Hi Urs, On Wed, Jul 1, 2015 at 2:24 AM, Urs Liska wrote: > > What I see after choosing a song is that seemingly arbitrary letters in > a Courier-like font are placed above the noteheads. If these letters > should be the note names then it seems to be not working properly. If > these should *not

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2015/04/08 16:06:47, david.nalesnik wrote: On 2015/04/08 11:14:54, dak wrote: > commit 8d8e8aec6388fbb08ed2219884b82ecf53a9dbcd > Author: David Kastrup > Date: Wed Jan 1 20:54:15 2014 +0100 > > Provide value->lily-string function > > because I really needed that

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2015/04/08 11:14:54, dak wrote: On 2015/04/08 10:43:09, thomasmorley651 wrote: > On 2015/04/08 10:21:55, dak wrote: > > > value->lily-string is probably the most useful reasonably generic printing > > facility right now. But nobody really knows it. > > At least, I wasn't aware of it, becaus

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

https://codereview.appspot.com/222810043/diff/1/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/222810043/diff/1/ly/init.ly#newcode38 ly/init.ly:38: #(use-modules (ice-9 pretty-print)) On 2015/04/07 16:13:44, dak wrote: Uh, where is the point? Why wouldn't a user include a m

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

On 2015/04/04 20:20:33, dak wrote: On 2015/04/04 16:17:20, david.nalesnik wrote: > Music is used. For example, looking at what sort of object must be produced by > \shape: > > #(display (car (ly:music-function-signature shape))) > > ==> > > (# . # . Music) (types general-music)) > > ) > > T

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) On 2015/04/04 16:17:20, david.nalesnik wrote: >

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) On 2015/04/04 15:25:27, Trevor Daniels wrote: On

Re: PATCHES: Countdown for April 6th 2015

On Sat, Apr 4, 2015 at 3:42 AM, Trevor Daniels wrote: > > James Lowe wrote Saturday, April 04, 2015 9:27 AM > > > > On 04/04/15 08:49, David Kastrup wrote: > >> > >> If we freeze patches only on countdown state and nothing else I hope not > >> to curb the holiday rush of activity too much. > >> >

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) Should Music be given a type? According to patter

Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Remove unused event-type general-music Please review this at https://codereview.appspot.com/222090043/ Affected files (+105, -109 lines): M input/regression/scheme-text-spanner.ly M scm/define-music-types.scm ___

Re: Issue 3615: more consistency with key sig grobs (issue 219460043 by paulwmor...@gmail.com)

On 2015/03/30 16:36:20, david.nalesnik wrote: On 2015/03/29 20:33:33, pwm wrote: > Please review, thanks. Could you provide an example where this would be useful? Thanks, David OK, drat. Ignore that!! See Issue 3615, of course :) https://codereview.appspot.com/219460043/ __

Re: Issue 3615: more consistency with key sig grobs (issue 219460043 by paulwmor...@gmail.com)

On 2015/03/29 20:33:33, pwm wrote: Please review, thanks. Could you provide an example where this would be useful? Thanks, David https://codereview.appspot.com/219460043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/

make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: make pretty-print available in ly files Please review this at https://codereview.appspot.com/222810043/ Affected files (+1, -0 lines): M ly/init.ly Index: ly/init.ly diff --git a/ly/init.ly b/ly/init.ly index 8265d171cf2ab3f9ae63

Re: Language selection code

On Fri, Mar 27, 2015 at 8:38 AM, David Nalesnik wrote: > I haven't gone through this thoroughly, but I did notice that an invalid > statement like this > \language general.deutsch.foo > isn't gracefully dealt with. > > [...] > > If correct-input is #f, lang

Re: Language selection code

Hi Simon, On Thu, Mar 26, 2015 at 6:43 PM, Simon Albrecht wrote: [...] > So the roadmap would include > – discussing design and coding (?) > I haven't gone through this thoroughly, but I did notice that an invalid statement like this \language general.deutsch.foo isn't gracefully dealt with.

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, and there's no need to put this back on review? https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly File input/regression/staff-ledger-positions-dotted-notes.ly (rig

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

On 2015/03/25 05:35:28, ul_openlilylib.org wrote: >Well, it's not much code of course. Would it even be reloaded? >Anyway, >I wonder if "redundant" use-modules invocations should be removed, or >at >least reduced to comments. Scheme modules are loaded only once so thee is no overhead involv

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: I always re

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/25 00:15:45, david.nalesnik wrote: On 2015/03/2

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: I always re

Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Add means to display objects accessible from a grob A convenient means of displaying the grobs and grob-arrays pointed to by various internal properties of a given grob would be very helpful for debugging and development purposes. For

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

Thanks for the review! https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1190 scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column) On 2015/03/11 23:49

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) On 2015/03/09 17:09:23, david.nalesnik wrote: I am recogniz

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) I am recognizing Script grobs in the orthodox way--i.e., thr

toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks. Description: toward-stem-shift-in-column should only consider 'script-interface Previously, toward-stem-shift-in-column did not discriminate between different types of grobs in the 'scripts grob-array. This meant that TextScript, StringNumber, and

Re: [PATCH] Add scheme engraver for StaffTab notation

On Sun, Mar 1, 2015 at 10:32 AM, David Nalesnik wrote: > Hi Ricardo, > > On Sun, Mar 1, 2015 at 8:31 AM, Ricardo Wurmus wrote: > >> I already implemented the following changes: >> >> - added context definitions for \midi in addition to \layout >> - restri

Re: [PATCH] Add scheme engraver for StaffTab notation

Hi Ricardo, On Sun, Mar 1, 2015 at 8:31 AM, Ricardo Wurmus wrote: > I already implemented the following changes: > > - added context definitions for \midi in addition to \layout > - restricted maximum line length to 80 chars > > Attached is a new patch. > This patch fails to apply in ly/string-

Re: [PATCH] support for flagged crotchets in mensural notation

On Sat, Feb 28, 2015 at 10:14 AM, Lukas Pietsch wrote: > Werner LEMBERG gnu.org> writes: > > > >> "hollow=1" would then be the default for modern notation. > > > > > > minHollowDurationLog would be more descriptive. > > > > What an ugly name, but I agree that it is more descriptive than > > `hol

Re: [PATCH] Add scheme engraver for StaffTab notation

On Mon, Feb 23, 2015 at 5:24 PM, David Nalesnik wrote: > > > On Mon, Feb 23, 2015 at 5:15 PM, David Nalesnik > wrote: > >> Hi Ricardo, >> >> On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus >> wrote: >> >>> >>> Here's the pat

Re: [PATCH] Add scheme engraver for StaffTab notation

On Mon, Feb 23, 2015 at 5:15 PM, David Nalesnik wrote: > Hi Ricardo, > > On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus > wrote: > >> >> Here's the patch: >> > > When I apply your patch and try to compile the example file I get: > > warni

Re: [PATCH] Add scheme engraver for StaffTab notation

Hi Ricardo, On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus wrote: > > Here's the patch: > When I apply your patch and try to compile the example file I get: warning: cannot find or create new `StaffTab' warning: cannot find or create new `StaffTab' warning: cannot find or create new `StickVoi

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode29 scm/output-lib.scm:29: (define-public (grob::rhythmic-location grob) On 2015/02/22 07:59:40, dak wrote: The fu

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 20:43:51, david.nalesnik wrote: it seems that a drawback of using Scheme is losing the nice error messages that result from doing LY_ASSERT_SMOB. False alarm. https://codereview.appspot.com/197690044/ ___ lilypond-devel mailing li

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

And in a few moments a version where I didn't strip the docstring... https://codereview.appspot.com/203090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/18 20:46:03, david.nalesnik wrote: On 2015/02/18 19:32:57, david.nalesnik wrote: > Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should > rewrite it in Scheme. Not so sure now. Error reporting options in Scheme aren't as good. I take that back. If I

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/18 19:32:57, david.nalesnik wrote: Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should rewrite it in Scheme. Not so sure now. Error reporting options in Scheme aren't as good. https://codereview.appspot.com/203090043/

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 20:39:19, david.nalesnik wrote: On 2015/02/18 18:12:58, david.nalesnik wrote: > On 2015/02/18 18:08:32, david.nalesnik wrote: > > Putting it into Scheme will need to wait for Issue 4289 to make it to master, > since I'll be able to use ly:item-get-column here. However, we lose

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:12:58, david.nalesnik wrote: On 2015/02/18 18:08:32, david.nalesnik wrote: Putting it into Scheme will need to wait for Issue 4289 to make it to master, since I'll be able to use ly:item-get-column here. However, we lose the nice error reporting which happens when you do (

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should rewrite it in Scheme. https://codereview.appspot.com/203090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-deve

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:08:32, david.nalesnik wrote: Putting it into Scheme will need to wait for Issue 4289 to make it to master, since I'll be able to use ly:item-get-column here. https://codereview.appspot.com/197690044/ ___ lilypond-devel mailing list

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:07:19, dak wrote: On 2015/02/18 18:05:17, david.nalesnik wrote: > On 2015/02/18 18:02:38, dak wrote: > > On 2015/02/18 17:53:44, david.nalesnik wrote: > > > Please review. Thanks! > > > > Can't this be done just as easily in Scheme? > > Sure--that crossed my mind. The reason I

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:02:38, dak wrote: On 2015/02/18 17:53:44, david.nalesnik wrote: > Please review. Thanks! Can't this be done just as easily in Scheme? Sure--that crossed my mind. The reason I went with C++ is so that it would be documented prominently, but I could change it if that's not a

Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Function to display the rhythmic location of a grob A convenient way to return the musical position of a grob within a score will be very helpful in debugging, among other uses. This patch creates a function ly:grob-rhythmic-location w

Re: making measure-counter-stencil public (issue 203130043 by thomasmorle...@gmail.com)

LGTM. Thanks! https://codereview.appspot.com/203130043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

<    1   2   3   4   5   >