On Sat, Sep 29, 2012 at 7:46 PM, Phil Holmes m...@philholmes.net wrote:
Well, in the current version of the NR, the guidance for changing the breath
sign is:
\override BreathingSign #'text = \markup {\musicglyph
#scripts.caesura.straight}
Hmm. I wouldn't do it this way, it feels not
Hello,
On 30 September 2012 13:27, Janek Warchoł janek.lilyp...@gmail.com wrote:
On Sat, Sep 29, 2012 at 7:46 PM, Phil Holmes m...@philholmes.net wrote:
Well, in the current version of the NR, the guidance for changing the breath
sign is:
\override BreathingSign #'text = \markup {\musicglyph
On Sun, Sep 30, 2012 at 4:32 PM, James pkx1...@gmail.com wrote:
On 30 September 2012 13:27, Janek Warchoł janek.lilyp...@gmail.com wrote:
On Sat, Sep 29, 2012 at 7:46 PM, Phil Holmes m...@philholmes.net wrote:
Well, in the current version of the NR, the guidance for changing the breath
sign
Hmm.
My answer to how would we place the glyph at the correct vertical
position, above the barline? is: i suppose that we're going to create
a \tickBreathe command; if so, i guess that defining it in this manner
tickBreathe = {
\override BreathingSign #'outside-staff-priority = something
29, 2012 6:25 PM
Subject: Re: Adds tick mark to scripts (issue 6568055)
Hmm.
My answer to how would we place the glyph at the correct vertical
position, above the barline? is: i suppose that we're going to create
a \tickBreathe command; if so, i guess that defining it in this manner
tickBreathe
27, 2012 1:02 PM
Subject: Re: Adds tick mark to scripts (issue 6568055)
I would also place the vertical center
of the box level with top dip point, ie the point labeled 2r in dvi
preview i see on my machine.
I don't understand this. I know where 2r is, but how can in be in the
centre - it's
Updated glyph. Please review.
http://codereview.appspot.com/6568055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Fri, Sep 28, 2012 at 11:40 AM, Phil Holmes m...@philholmes.net wrote:
This is clear, but I've had a think about this and I don't agree. The
natural reference point of the tick is its bottom, not the middle of the
tick, which is a somewhat arbitrary point based on the aesthetics of the
line
, 2012 3:09 PM
Subject: Re: Adds tick mark to scripts (issue 6568055)
On Fri, Sep 28, 2012 at 11:40 AM, Phil Holmes m...@philholmes.net wrote:
This is clear, but I've had a think about this and I don't agree. The
natural reference point of the tick is its bottom, not the middle of the
tick
@gnu.org;
re...@codereview-hr.appspotmail.com
Sent: Friday, September 28, 2012 3:09 PM
Subject: Re: Adds tick mark to scripts (issue 6568055)
On Fri, Sep 28, 2012 at 11:40 AM, Phil Holmes m...@philholmes.net wrote:
This is clear, but I've had a think about this and I don't agree. The
natural
On Fri, Sep 28, 2012 at 4:12 PM, Phil Holmes em...@philholmes.net wrote:
Does this convince you?
No - sorry. I can't envisage any situation where anyone would want to align
to the inside bend of a tick mark.
I suppose that someone might want to use this glyph as something else
than
Janek Warchoł janek.lilyp...@gmail.com writes:
On Fri, Sep 28, 2012 at 4:12 PM, Phil Holmes em...@philholmes.net wrote:
Does this convince you?
No - sorry. I can't envisage any situation where anyone would want to align
to the inside bend of a tick mark.
I suppose that someone might want
...@gnu.org; lilypond-devel@gnu.org;
re...@codereview-hr.appspotmail.com
Sent: Friday, September 28, 2012 3:09 PM
Subject: Re: Adds tick mark to scripts (issue 6568055)
On Fri, Sep 28, 2012 at 11:40 AM, Phil Holmes m...@philholmes.net
wrote:
This is clear, but I've had a think about this and I
LGTM.
http://codereview.appspot.com/6568055/diff/7001/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/6568055/diff/7001/mf/feta-scripts.mf#newcode1781
mf/feta-scripts.mf:1781: penlabels (1,2,3,4);
z4 is not defined with penpos4, so you should use `labels'
LGTM.
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf#newcode1774
mf/feta-scripts.mf:1774: set_char_box (0, 1.7 staff_space# + epsilon,
I suggest to use a tightest bounding box. At
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf#newcode1774
mf/feta-scripts.mf:1774: set_char_box (0, 1.7 staff_space# + epsilon,
Are you suggesting deleting the epsilon, or moving
Hi,
thanks for including me in reviewers, Phil - i would probably miss it
otherwise.
The shape is ok. Personally i would make the right arm a tad thicker
and a bit less curved, but that's only my opinion.
As for the bounding box, i definitely think that it should be moved,
both horizontally
- Original Message -
From: janek.lilyp...@gmail.com
To: philehol...@googlemail.com; lemzw...@googlemail.com;
gra...@percival-music.ca; d...@gnu.org
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Thursday, September 27, 2012 10:11 AM
Subject: Re: Adds tick mark
Please don't use `epsilon' in set_char_box. I think the problem is that
you `sharpen' a coordinate distance by doing `define_pixels (y_off)',
however, only `black distances' (to use the TrueType vocabulary) like
vertical or horizontal stem widths should be handled like that.
In general, I would
On Thu, Sep 27, 2012 at 11:41 AM, Phil Holmes m...@philholmes.net wrote:
Horizontally, i would align the center of the bounding box to the dip
point. This would allow visual centering of the glyph on something.
Can do. This would imply that there's empty space on the left of the glyph.
Is
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf#newcode1781
mf/feta-scripts.mf:1781: fet_beginchar (snap pizzicato (Bartok
pizzicato), snappizzicat);
It would appear you renamed this
Reviewers: lemzwerg, janek, Graham Percival,
Message:
Please review
Description:
As it says. A tick mark is a very common way of indicating a breath in
vocal music, but we have no good glyph for this. This is an attempt to
create one.
Please review this at
Correct. Apologies - I did that to try an experiment and didn't reset
it. Thanks for picking it up. Next patch set will correct that.
http://codereview.appspot.com/6568055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
23 matches
Mail list logo
