Re: RFC: require librsvg to implement SVG image support

2023-03-02 Thread Jean Abou Samra
Le vendredi 20 janvier 2023 à 18:32 +0100, Jean Abou Samra a écrit : > [In case people are wondering why I’m not replying: I want to actually see > what it takes to cross-compile Poppler, this takes time, and I don’t have a > lot of it ATM, hence the delay.] I tried this, and it consumed a lot o

Re: RFC: require librsvg to implement SVG image support

2023-01-20 Thread Jean Abou Samra
[In case people are wondering why I’m not replying: I want to actually see what it takes to cross-compile Poppler, this takes time, and I don’t have a lot of it ATM, hence the delay.]

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Lukas-Fabian Moser
, the only format for the inclusion of vector graphics is EPS. I just tested this with the Debian logo, and conversion to SVG with Imagemagick produces a black-and-white image. Conversion to PDF on the other hand is as easy as "ps2pdf -dEPSCrop" and hugely battle-tested with Ghostscrip

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Jonas Hahnfeld via Discussions on LilyPond development
in your opinion? I don't understand this from the > following sentences. I think it was asked too generically, without catering for users that already have EPS files. > I think the easiest route is "ps2pdf -dEPSCrop" then > "pdftocairo -svg" (i.e., GS, then Poppler

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Jean Abou Samra
27;s worth, it was not a surprise to me, as it confirms my own experience.) Currently, the only format for the inclusion of vector graphics is EPS. I just tested this with the Debian logo, and conversion to SVG with Imagemagick produces a black-and-white image. Conversion to PDF on the other hand

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Sun, 2023-01-15 at 13:40 +0100, Jean Abou Samra wrote: > - Since Poppler's build system is CMake, we have to write a different >   class inheriting from Package alongside ConfigurePackage and >   MesonPackage, and figure out how CMake needs to be invoked and >   with what environment variable

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Jean Abou Samra
Le 14/01/2023 à 22:09, Jonas Hahnfeld a écrit : On Sat, 2023-01-14 at 18:11 +0100, Jean Abou Samra wrote: I would have to test how difficult it actually is to cross-compile Poppler, but my own assessment is that keeping MinGW cross-compilation of a C++ project working is potentially more burdens

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Kevin Barry
mat), but I'm glad that we polled users and I think it was the right thing to do. It's better to work backwards from the user experience to the technical decisions than the other way around. If you decide that svg is too much burden/debt/work then that is fine and we should communicate it like t

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Aaron Hill
On 2023-01-15 3:24 am, Jonas Hahnfeld wrote: My conclusion is that PDF is the more "logical" successor to the inclusion of EPS.) There is a philosophical issue: EPS (and SVG) are intended to be used as embedded vector graphics. PDF is a document format. EPS/SVG are the di

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Luca Fascione
On Sun, 15 Jan 2023, 12:25 Jonas Hahnfeld via Discussions on LilyPond development, wrote: > PDF is the more "logical" > successor to the inclusion of EPS. > It never occured to me we wouldn't support PDF. I always heard the discussion as "do we actually really nee

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Jonas Hahnfeld via Discussions on LilyPond development
;s post on the list was merely an ask for what > vector format(s) could be useful. (I think SVG "won", if it matters.) (which is surprising and my interpretation is that the question was phrased wrongly: Currently, the only format for the inclusion of vector graphics is EPS. I

Re: RFC: require librsvg to implement SVG image support

2023-01-15 Thread Aaron Hill
well-motivated) to consider technical matters. But the important thing is that users *are* able to express what they need from LilyPond. Jean's post on the list was merely an ask for what vector format(s) could be useful. (I think SVG "won", if it matters.) It then falls to

Re: RFC: require librsvg to implement SVG image support

2023-01-14 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Sat, 2023-01-14 at 18:11 +0100, Jean Abou Samra wrote: > I would have to test how difficult it actually is to cross-compile > Poppler, but my own assessment is that keeping MinGW cross-compilation > of a C++ project working is potentially more burdensome on the long-term > than with a Rust one,

Re: RFC: require librsvg to implement SVG image support

2023-01-14 Thread Jean Abou Samra
Le 14/01/2023 à 16:45, Jonas Hahnfeld a écrit : On Wed, 2023-01-11 at 23:13 +0100, Han-Wen Nienhuys wrote: Regarding rsvg and rust: maybe we could try with an older version of librsvg first? Rust was only introduced in 2.41, so if we go with 2.40, we can postpone the worry about compiling Rust.

Re: RFC: require librsvg to implement SVG image support

2023-01-14 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Wed, 2023-01-11 at 23:13 +0100, Han-Wen Nienhuys wrote: > Regarding rsvg and rust: maybe we could try with an older version of > librsvg first? Rust was only introduced in 2.41, so if we go with > 2.40, we can postpone the worry about compiling Rust. librsvg 2.41 was released in 2017, the last

Re: RFC: require librsvg to implement SVG image support

2023-01-11 Thread Jean Abou Samra
s at https://lists.gnu.org/archive/html/lilypond-user/2023-01/msg00189.html See my previous posts, I posted this link and also the one to the equivalent thread on lilypond-user-fr (which also leans towards SVG). It's currently 3-0 skewed towards SVG. Regarding rsvg and rust: maybe we co

Re: RFC: require librsvg to implement SVG image support

2023-01-11 Thread Han-Wen Nienhuys
for vector graphics, even if not > >>> with EPS, we can add support for embedding SVG images. > >> Are we sure that this is actually what the users need? If everybody > >> just cares about including PDF (for logos), I'm not sure if we need to > >> implement

Re: RFC: require librsvg to implement SVG image support

2023-01-11 Thread Jean Abou Samra
Le 08/01/2023 à 23:18, Jean Abou Samra a écrit : * If so, how do we manage the transition? Do we make them   optional at first, and if so, for how long? Only Werner commented on this aspect so far. Are there other opinions? OpenPGP_signature Description: OpenPGP digital signature

Re: RFC: require librsvg to implement SVG image support

2023-01-11 Thread Jean Abou Samra
Le 10/01/2023 à 23:32, Jean Abou Samra a écrit : A thought in passing: whether we take Librsvg or Poppler, we will need libjpeg. This should also enable us to support JPEG in addition to PNG with not too much effort. On further thinking, I think I'm going to submit this separately as a first

Re: RFC: require librsvg to implement SVG image support

2023-01-10 Thread Aaron Hill
On 2023-01-10 2:51 pm, Jean Abou Samra wrote: Hi Aaron, Thanks for your reply. Le 10/01/2023 à 03:25, Aaron Hill a écrit : I have had some success with converting EPS to SVG (albeit with some manual correction for color spaces) I'm curious about this, can you say more about

Re: RFC: require librsvg to implement SVG image support

2023-01-10 Thread Jean Abou Samra
Le 10/01/2023 à 23:32, Jean Abou Samra a écrit : (It hasn't appeared on the archives yet, I'll post a link when it does.) https://lists.gnu.org/archive/html/lilypond-user/2023-01/msg00189.html Also on -user-fr: https://lists.gnu.org/archive/html/lilypond-user-fr/2023-01/msg00048.html (Googl

Re: RFC: require librsvg to implement SVG image support

2023-01-10 Thread Jean Abou Samra
Hi Aaron, Thanks for your reply. Le 10/01/2023 à 03:25, Aaron Hill a écrit : I have had some success with converting EPS to SVG (albeit with some manual correction for color spaces) I'm curious about this, can you say more about these corrections? (If we do this, it's important t

Re: RFC: require librsvg to implement SVG image support

2023-01-10 Thread Jean Abou Samra
Le 10/01/2023 à 23:25, Han-Wen Nienhuys a écrit : On Mon, Jan 9, 2023 at 7:45 PM Jonas Hahnfeld wrote: On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: In order to keep support for vector graphics, even if not with EPS, we can add support for embedding SVG images. Are we sure that

Re: RFC: require librsvg to implement SVG image support

2023-01-10 Thread Han-Wen Nienhuys
On Mon, Jan 9, 2023 at 7:45 PM Jonas Hahnfeld wrote: > > On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: > > In order to keep support for vector graphics, even if not > > with EPS, we can add support for embedding SVG images. > > Are we sure that this is actually

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Mon, 2023-01-09 at 23:19 +0100, Jean Abou Samra wrote: > Le 09/01/2023 à 20:50, Jonas Hahnfeld a écrit : > > I tried very hard to install as much as possible from the official > > repositories (MetaPost on CentOS7 and Meson being the exceptions), > > which makes the environment very easy to repr

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Aaron Hill
On 2023-01-09 11:12 am, Jean Abou Samra wrote: I'm not really sure how to get factual data about this (a straw poll on the user list?). In my experience, for things like logos, SVG is more common (there *are* logos in PDF, they're just less common as far as I know, but again this i

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:50, Jonas Hahnfeld a écrit : I tried very hard to install as much as possible from the official repositories (MetaPost on CentOS7 and Meson being the exceptions), which makes the environment very easy to reproduce. I'm not too fond of the rustup approach in general... Maybe

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Mon, 2023-01-09 at 20:12 +0100, Jean Abou Samra wrote: > Le 09/01/2023 à 19:44, Jonas Hahnfeld a écrit : > > On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: > > > In order to keep support for vector graphics, even if not > > > with EPS, we can add suppo

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:12, Jean Abou Samra a écrit : while rustup arranges so that the version of Rust used in each project is the one specified in Cargo.toml. Sorry, I misremembered: s/Cargo.toml/rust-toolchain.toml. A pinned Rust version is specified there, Cargo.toml supports a minimum supporte

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 19:44, Jonas Hahnfeld a écrit : On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: In order to keep support for vector graphics, even if not with EPS, we can add support for embedding SVG images. Are we sure that this is actually what the users need? If everybody just

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: > In order to keep support for vector graphics, even if not > with EPS, we can add support for embedding SVG images. Are we sure that this is actually what the users need? If everybody just cares about including PDF (for logos), I

Re: RFC: require librsvg to implement SVG image support,RFC: require librsvg to implement SVG image support

2023-01-09 Thread Werner LEMBERG
> Therefore, the proposal here is to add librsvg as a dependency to > LilyPond. The transitive dependencies it pulls in are libxml2, > GdkPixbuf, and libjpeg (the latter for GdkPixbuf). Your proposal sounds good to me. > * If so, how do we manage the transition? Do we make them optional > a

Re: Duplicate SVG attribute

2022-12-29 Thread Paolo Prete
On Thu, Dec 29, 2022 at 12:18 AM Jean Abou Samra wrote: > Le 25/12/2022 à 21:01, Paolo Prete a écrit : > > Thanks as always for your help, and also for the snippet you provided. > > > > You're right it's not usual to do that override twice for the same > > grob, and I'll update you with a concret

Re: Duplicate SVG attribute

2022-12-28 Thread Jean Abou Samra
Le 25/12/2022 à 21:01, Paolo Prete a écrit : Thanks as always for your help, and also for the snippet you provided. You're right it's not usual to do that override twice for the same grob, and I'll update you with a concrete test-case in which the mentioned issue happens, so to see if we have

Re: Duplicate SVG attribute

2022-12-25 Thread Paolo Prete
On Sun, Dec 25, 2022 at 7:02 PM Jean Abou Samra wrote: > Le 24/12/2022 à 15:38, Paolo Prete a écrit : > > Hello, > > > > I'm noting that the generated SVG of this...: > > > > { > > \once \override DynamicText.output-attributes.val = &qu

Re: Duplicate SVG attribute

2022-12-25 Thread Jean Abou Samra
Le 24/12/2022 à 15:38, Paolo Prete a écrit : Hello, I'm noting that the generated SVG of this...: { \once \override DynamicText.output-attributes.val = "x" \once \override DynamicText.output-attributes.val = "y" c'\mf } ... creates the following

Duplicate SVG attribute

2022-12-24 Thread Paolo Prete
Hello, I'm noting that the generated SVG of this...: { \once \override DynamicText.output-attributes.val = "x" \once \override DynamicText.output-attributes.val = "y" c'\mf } ... creates the following SVG tag, with a duplicate "val" attrib

Re: Automated test on PDF or SVG output

2022-11-15 Thread Paolo Prete
Thank you Dan and Jean. I'll do some experiments in the next few days and I'll update you. On Tue, Nov 15, 2022 at 2:39 AM Dan Eble wrote: > On Nov 14, 2022, at 04:43, Paolo Prete wrote: > > > > I need to execute the following automated test: > > given a .ly file, I would like to check if the p

Re: Automated test on PDF or SVG output

2022-11-14 Thread Dan Eble
On Nov 14, 2022, at 04:43, Paolo Prete wrote: > > I need to execute the following automated test: > given a .ly file, I would like to check if the produced output is what I > expect it to be. For checking the impact of LilyPond changes on my own scores, I use a Docker container and a bash script

Re: Automated test on PDF or SVG output

2022-11-14 Thread Jean Abou Samra
esn't matter if > PDF or SVG) with an expected image of the same file type, and check if the > two images are the same. > There are several ways to do that: for example a Python script with a > graphic library such as Pillow, which compares two images. > However, I wonder if this te

Automated test on PDF or SVG output

2022-11-14 Thread Paolo Prete
Hello, I need to execute the following automated test: given a .ly file, I would like to check if the produced output is what I expect it to be. Then I was thinking about a way to compare the output (doesn't matter if PDF or SVG) with an expected image of the same file type, and check if th

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Kevin Barry
I will close this rietveld issue now that you are taking care of it. Whatever discussion needs to take place can happen at the one you have opened. On Sat, May 02, 2020 at 11:54:14AM +0200, Han-Wen Nienhuys wrote: > See http://codereview.appspot.com/545970043 > > note: > 1) Depending on the rend

Compute SVG skyline based on original data (issue 545970043 by hanw...@gmail.com)

2020-05-02 Thread hanwenn
Reviewers: , Message: goes on top of https://codereview.appspot.com/555760043/ Description: Compute SVG skyline based on original data Since stencil data is used as input to formatting decisions, this will make SVG output more similar to PS/PDF output. Please review this at https

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Han-Wen Nienhuys
See http://codereview.appspot.com/545970043 note: 1) Depending on the renderer, the skylines diverge from the text. Inkscape reproduces exactly, but EOG messes up the text formatting. 2) The lack of regression testing is worrying. We could have a section of regtests that is powered by inkscape

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Han-Wen Nienhuys
Let me see what I can come up with today On Sat, May 2, 2020 at 10:53 AM Kevin Barry wrote: > > On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote: > > Not necessarily, but the refactoring means I'll likely have to > > overwrite the fix wholesale. Because there is no regtest, it wil

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Kevin Barry
On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote: > Not necessarily, but the refactoring means I'll likely have to > overwrite the fix wholesale. Because there is no regtest, it willl > depend on my diligence anyway to fix this again. OK, so what should we do? I am happy to take re

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Kevin Barry
On Sat, May 02, 2020 at 01:16:30AM -0700, beauleetien...@gmail.com wrote: > On 2020/05/02 07:38:58, hanwenn wrote: > > I don't completely understand, though: if we put the "utf-8-string" > directly > > into the SVG output, the SVG browser might make other font

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread beauleetienne0
On 2020/05/02 07:38:58, hanwenn wrote: > I don't completely understand, though: if we put the "utf-8-string" directly > into the SVG output, the SVG browser might make other font choices, making the > outline potentially incorrect. Is this a problem in practice? There

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Han-Wen Nienhuys
Not necessarily, but the refactoring means I'll likely have to overwrite the fix wholesale. Because there is no regtest, it willl depend on my diligence anyway to fix this again. On Sat, May 2, 2020 at 9:46 AM wrote: > > On 2020/05/02 07:25:16, hanwenn wrote: > > please don't submit; I'm rearrang

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread jonas . hahnfeld
On 2020/05/02 07:25:16, hanwenn wrote: > please don't submit; I'm rearranging this file completely. Do you really need to hold this up after it went through the full cycle? If it fixes a problem now and doesn't regress somewhere else, I think we should take it now. https://codereview.appspot.com/

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread hanwenn
your regression test + instructions on how to reproduce the > > > problem? > > > > I did add a regression test in the first patch set, but it breaks > > testing. It seems we have no way to include the SVG backend in > > regression tests (I can see one other example t

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread hanwenn
e > > problem? > > I did add a regression test in the first patch set, but it breaks > testing. It seems we have no way to include the SVG backend in > regression tests (I can see one other example that tries to, using > inkscape, but it was disabled in 2008). I had to remove the regr

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread Kevin Barry
it breaks testing. It seems we have no way to include the SVG backend in regression tests (I can see one other example that tries to, using inkscape, but it was disabled in 2008). I had to remove the regression test in the second patchset in order to not break make test/check/etc. Do you have any s

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread hanwenn
please don't submit; I'm rearranging this file completely. Can you add your regression test + instructions on how to reproduce the problem? https://codereview.appspot.com/582010043/

Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-04-28 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/582010043/

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi Jonas, > Done (hopefully). Thank you very much; it looks like it worked! Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Jonas Hahnfeld
Am Dienstag, den 28.04.2020, 18:31 +0100 schrieb Kevin Barry: > Hi James, > > > We do have a process, see: > > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers > > > > I have followed this as best I can, but it seems I need to have write > acce

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi James, > We do have a process, see: > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers I have followed this as best I can, but it seems I need to have write access to the issue tracker before I can send patches. If that is the case then can s

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread James
Hello Kevin, On 27/04/2020 18:07, Kevin Barry wrote: Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? It's not work in progress no - unless someone

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread Kevin Barry
Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: > Is this patch read for full testing or is it work-in-progress you just want > someone to comment on it? It's not work in progress no - unless someone has objections or observations, but I don't mean to c

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread James
Kevin, Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? James On 25/04/2020 08:42, Kevin Barry wrote: Patch is attached to this mail as a file if that is more convenient. Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-25 Thread Kevin Barry
Patch is attached to this mail as a file if that is more convenient. Kevin >From 1c5715ad52139aab936ee7dffb2cdef3d123b369 Mon Sep 17 00:00:00 2001 From: Kevin Barry Date: Fri, 24 Apr 2020 19:26:26 +0100 Subject: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

[PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
Empty skylines forces a fallback to the grob's bounding box, which restores the behaviour from before the patch to improve skyline approximations (issue 2148). This does not fix the issue that there is no routine for determining skylines for utf-8-strings when the backend is svg, but it does at le

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
On Fri, Apr 24, 2020 at 09:25:19PM +0200, Han-Wen Nienhuys wrote: > Just add a test file under input/regression/ , following the style of > other files there. Thanks for the pointer. The only other svg backend file there looks like it has been deliberately disabled, so apologies if I hav

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
On Fri, Apr 24, 2020 at 09:18:10PM +0200, Han-Wen Nienhuys wrote: > Can you add a regression test that shows the problem? Yes. I'll go read the docs to see how to do that and do one up (but feel free to point me in the right direction...) Kevin

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Han-Wen Nienhuys
On Fri, Apr 24, 2020 at 9:21 PM Kevin Barry wrote: > > On Fri, Apr 24, 2020 at 09:18:10PM +0200, Han-Wen Nienhuys wrote: > > Can you add a regression test that shows the problem? > > Yes. I'll go read the docs to see how to do that and do one up (but feel > free to point me in the right direction

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Han-Wen Nienhuys
line approximations (issue 2148). This > does not fix the issue that there is no routine for determining skylines > for utf-8-strings when the backend is svg, but it does at least remove > the collisions without changing the behaviour in non-broken situations. > --- > lily/stencil

[PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
Empty skylines forces a fallback to the grob's bounding box, which restores the behaviour from before the patch to improve skyline approximations (issue 2148). This does not fix the issue that there is no routine for determining skylines for utf-8-strings when the backend is svg, but it does at le

Re: GSoC Proposal - SVG Export

2020-03-30 Thread Étienne Beaulé
To re-open this thread: Sorry if I wasn’t clear enough about LY’s export formats. I thought I was clear with the distinction I drew between my terminology of « application » and « program » from my first message. Sadly Ghostscript has deprecated its SVG capabilities. I was sadly unavailable

SVG: Permit 'e' to appear in SVG font glyph paths (issue 561460044 by jonas.hahnf...@gmail.com)

2020-02-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/561460044/

Re: Collisions on OttavaBracket in the SVG output (BUG)

2020-02-06 Thread Dan Eble
let 5/4 { \ottava #1 c'''8^>^\mf[(^\markup{ legato }\startTextSpan e'' > f''' g''' e'''']} c''''4\stopTextSpan \ottava #0 c'') > } > %%% > > On 2.19.83 the SVG output produces a collision on the OttavaBracket, which > is not placed at the right outside-staff-priority order. The PDF output is > ok. Is there a workaround/fix for this? > > thanks

Collisions on OttavaBracket in the SVG output (BUG)

2020-02-06 Thread Paolo Prete
Bracket.bracket-visibility = ##t \override TupletBracket.direction = #UP \tuplet 5/4 { \ottava #1 c'''8^>^\mf[(^\markup{ legato }\startTextSpan e'' f''' g''' e'''']} c''''4\stopTextSpan \ottava #0 c&#x

Re: GSoC Proposal - SVG Export

2018-12-04 Thread Paul Morris
On 12/3/18 10:07 AM, Richard Shann wrote: what seems strange is that there seems to be no concept of "backgound color" in SVG (logical in a way as SVG is about things you can draw) allowing for the possibility of drawing white on white. Easily setting a background color would

Re: GSoC Proposal - SVG Export

2018-12-04 Thread David Kastrup
Andrew Bernard writes: >> On Sat, 1 Dec 2018 at 14:39, Étienne Beaulé wrote: >> >>> >>> Scalable Vector Graphics (SVG) is a vector graphics format designed >>> for use on the internet. LilyPond (LY) is a program which translates >>> musical not

Re: GSoC Proposal - SVG Export

2018-12-04 Thread Urs Liska
Am 04.12.18 um 11:56 schrieb Andrew Bernard: Hi Étienne , The default is PDF, not PNG. I applaud your desire to improve the SVG output, but do get the premise right. Thanks! Étienne has already clarified this. I assume it's that with "this application" he was not refering

Re: GSoC Proposal - SVG Export

2018-12-04 Thread Andrew Bernard
Hi Étienne , The default is PDF, not PNG. I applaud your desire to improve the SVG output, but do get the premise right. Thanks! Andrew On Sat, 1 Dec 2018 at 14:39, Étienne Beaulé wrote: > > Scalable Vector Graphics (SVG) is a vector graphics format designed for > use on the

Re: GSoC Proposal - SVG Export

2018-12-03 Thread Richard Shann
; > was an improvement, IMO.  That is why I feel strongly about moving > > away from currentColor. > > currentColor sounds like the right default. what seems strange is that there seems to be no concept of "backgound color" in SVG (logical in a way as SVG is about things y

Re: GSoC Proposal - SVG Export

2018-12-03 Thread Paul Morris
users the option should address the concerns, and would make sense in this kind of GSOC proposal. Étienne, I really like your proposal.  I'd love to see improvements to SVG, moving towards giving it first-class support in LilyPond.  And kudos for planning ahead.

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Carl Sorensen
On 12/2/18, 1:30 PM, "Étienne Beaulé" wrote: That is more of a problem with Pixbuf (similar problem was fixed in librsvg). However, a case could be made to specify black for glyphs instead of currentColor, and I would be open to it (leaning against it though) However, changing i

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Étienne Beaulé
gt;> In the use of « currentColor, » it does seem to follow >> specifications. > > Hmm, these specs would seem to allow the SVG to be rendered onto a > background of the same color as currentColor - in my case I use the GDK > Pixbuf library to render the SVG and it seems to choo

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Étienne Beaulé
ontréal studying computer science and mathematics, and Google Summer of Code > caught my eye. I’d be interested in doing a project if a mentor is available. > ># Improving SVG score output > > I think this is a great idea! > >## Summary > >Scalable Vector Grap

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Richard Shann
On Sat, 2018-12-01 at 23:21 -0500, Étienne Beaulé wrote: > Having glyph styling through CSS is one of the goals of this project. > In the use of « currentColor, » it does seem to follow > specifications. Hmm, these specs would seem to allow the SVG to be rendered onto a background of

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Carl Sorensen
a bachelor student at the Université de Montréal studying computer science and mathematics, and Google Summer of Code caught my eye. I’d be interested in doing a project if a mentor is available. # Improving SVG score output I think this is a great idea! ## Summary Scala

Re: GSoC Proposal - SVG Export

2018-12-02 Thread Carl Sorensen
the viewer. However, the current SVG backend should be able to use CSS more effectively with classes and ids. In terms of colour, it currently wraps objects of a colour in a https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC Proposal - SVG Export

2018-12-01 Thread Étienne Beaulé
Having glyph styling through CSS is one of the goals of this project. In the use of « currentColor, » it does seem to follow specifications. If an object does not have a colour associated with it, it should leave the colour to the viewer. However, the current SVG backend should be able to use

Re: GSoC Proposal - SVG Export

2018-12-01 Thread Carl Sorensen
On 12/1/18, 1:22 AM, "lilypond-devel on behalf of Richard Shann" wrote: It is probably a very small thing, but it would be good if you could improve the SVG output with regard to the use of "current color" which Lily outputs as the default foreground col

Re: GSoC Proposal - SVG Export

2018-12-01 Thread Urs Liska
lable. # Improving SVG score output ## Summary Scalable Vector Graphics (SVG) is a vector graphics format designed for use on the internet. LilyPond (LY) is a program which translates musical notation syntax into a graphics format, such as SVG. This format is important for web publishing, and as a v

Re: GSoC Proposal - SVG Export

2018-12-01 Thread Richard Shann
tudent at > the Université de Montréal studying computer science and mathematics, > and Google Summer of Code caught my eye. I’d be interested in doing a > project if a mentor is available. > > # Improving SVG score output > > ## Summary > > Scalable Vector Graphics (SVG) is a

Re: GSoC Proposal - SVG Export

2018-11-30 Thread Werner LEMBERG
> I’m Étienne Beaulé and I’ve been making some changes to LilyPond. I > am also the maintainer of the MediaWiki Score extension which allows > embedded LilyPond on Wikipedia. I’m currently a bachelor student at > the Université de Montréal studying computer science and > mathematics, and Google

GSoC Proposal - SVG Export

2018-11-30 Thread Étienne Beaulé
Google Summer of Code caught my eye. I’d be interested in doing a project if a mentor is available. # Improving SVG score output ## Summary Scalable Vector Graphics (SVG) is a vector graphics format designed for use on the internet. LilyPond (LY) is a program which translates musical notation

Request PATCH to ensure LilyPond SVG compatibility with Scribus

2018-10-11 Thread d_l
I have joined this list today just for the purpose of facilitating a link between Scribus and LilyPond forums and posting one PATCH suggestion before next imminent release of lilypond. Over at the Scribus forum a small issue prevents svg output from lilypond commandline being rendered in Scribus

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-04 Thread James Lowe
Paul On Wed, 4 Jul 2018 15:59:18 -0400, Paul Morris wrote: > James, > > On 07/04/2018 09:41 AM, James Lowe wrote: > > > On Sun, 1 Jul 2018 17:52:02 -0400, Paul Morris wrote: > > > >> Thanks.  It turned out I had a new SSH key that I hadn't added to > >> Savannah yet.  So I got it to work b

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-04 Thread David Kastrup
Paul Morris writes: > Below is what I got, which doesn't match what you have above.  Looks > like I have ECDSA instead of RSA, or something? > > $ git pull --verbose > > The authenticity of host 'git.sv.gnu.org (208.118.235.201)' can't be > established. > > ECDSA key fingerprint is SHA256:qRLLJ4

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-04 Thread Paul Morris
James, On 07/04/2018 09:41 AM, James Lowe wrote: On Sun, 1 Jul 2018 17:52:02 -0400, Paul Morris wrote: Thanks.  It turned out I had a new SSH key that I hadn't added to Savannah yet.  So I got it to work by following CG 3.4.9 http://lilypond.org/doc/v2.19/Documentation/contributor/commit-a

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-04 Thread James Lowe
Paul, On Sun, 1 Jul 2018 17:52:02 -0400, Paul Morris wrote: > On 07/01/2018 02:43 AM, David Kastrup wrote: > > > Edit your .git/config file and change the repository address according > > to the Git repository clone command given for developers on LilyPond's > > Savannah page. > > Th

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-01 Thread Paul Morris
On 07/01/2018 02:43 AM, David Kastrup wrote: Edit your .git/config file and change the repository address according to the Git repository clone command given for developers on LilyPond's Savannah page. Thanks.  It turned out I had a new SSH key that I hadn't added to Savannah yet.  So I got i

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-01 Thread David Kastrup
"James Lowe" writes: > Hello > > On Sun, 1 Jul 2018 09:59:11 +0200, Urs Liska wrote: > >> >> >> Am 01.07.2018 um 09:55 schrieb James Lowe: >> > I don't know what the difference is between pull and fetch in >> > terms of 'rights' but I'd have thought it would be the same right? >> > >> >> Yes,

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-01 Thread James Lowe
Hello On Sun, 1 Jul 2018 09:59:11 +0200, Urs Liska wrote: > > > Am 01.07.2018 um 09:55 schrieb James Lowe: > > I don't know what the difference is between pull and fetch in terms of > > 'rights' but I'd have thought it would be the same right? > > > > Yes, the difference comes only on your o

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-01 Thread Urs Liska
Am 01.07.2018 um 09:55 schrieb James Lowe: I don't know what the difference is between pull and fetch in terms of 'rights' but I'd have thought it would be the same right? Yes, the difference comes only on your own computer. ___ lilypond-devel m

Re: #5355 Doc: document grob metadata in SVG output in Notation Reference

2018-07-01 Thread James Lowe
Hello, On Sun, 1 Jul 2018 07:43:29 +0100, "David Kastrup" wrote: > Paul Morris writes: > > > On 06/28/2018 03:35 AM, pkx166h wrote: > > > >> * *Patch*: countdown --> push > >> * *Comment*: > >> > >> Patch counted down - please push > >> > > > > I tried pushing my patch to staging and got t

  1   2   3   4   >