Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Andi Kleen
> > > - Post the entire patch series to lkml for review (I'd like a cc please) > > > > Already happened, multiple people reviewed and tested. > > um, I would not consider "Looks ok to me from a quick look." and "I > couldn't tell from the github view, but I assume you follow standard > coding sty

Re: tree root

2012-10-03 Thread Mitch Harder
On Wed, Oct 3, 2012 at 5:11 PM, Øystein Sættem Middelthun wrote: > On 10/03/2012 07:29 PM, Mitch Harder wrote: >> >> If you do not have a suitable backup for these files, please make an >> effort to do what you can with restore. Some of the repair methods >> out there have a possibility to make t

Re: tree root

2012-10-03 Thread Øystein Sættem Middelthun
On 10/03/2012 07:29 PM, Mitch Harder wrote: If you do not have a suitable backup for these files, please make an effort to do what you can with restore. Some of the repair methods out there have a possibility to make the situation worse. We are talking about something like 50TB, so there is ju

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Andrew Morton
On Wed, 3 Oct 2012 23:19:04 +0200 Andi Kleen wrote: > > No, lib/lzo has no identifiable maintainer. I suggest you proceed as > > follows: > > > > - Post the entire patch series to lkml for review (I'd like a cc please) > > Already happened, multiple people reviewed and tested. um, I would not

btrfs lockdep splat for fs_info->chunk_mutex

2012-10-03 Thread Jim Schutt
Hi, I've been testing what I believe to be the btrfs patches being queued up for 3.7, and have been having trouble with stalled writes. (See, e.g., http://www.spinics.net/lists/linux-btrfs/msg19171.html) With CONFIG_PROVE_LOCKING=y I was able to collect the following lockdep splat, which I hope

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Andi Kleen
> No, lib/lzo has no identifiable maintainer. I suggest you proceed as > follows: > > - Post the entire patch series to lkml for review (I'd like a cc please) Already happened, multiple people reviewed and tested. This was just the patch ping. -Andi -- a...@linux.intel.com -- Speaking for mys

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Andrew Morton
On Wed, 3 Oct 2012 12:48:46 +0200 richard -rw- weinberger wrote: > CC'in akpm. Thanks. > >>> Hi all, > >>> > >>> I finally have prepared a small package that updates the LZO version > >>> in the Linux kernel. Please get it from: > >>> > >>> http://www.oberhumer.com/opensource/lzo/download/Testi

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 10:38 PM, Hugo Mills wrote: + if( !(flags& (DF_SHOW_SUMMARY|DF_SHOW_DETAIL)) ){ > > + fprintf(stderr, "btrfs filesystem df: it is not possible to specify -s AND -d\n"); > > This doesn't look right at all. You are adding two switches and > specifying both of t

Re: Out of memory condition

2012-10-03 Thread Josef Bacik
On Wed, Oct 03, 2012 at 08:25:11AM -0600, Jérôme Poulin wrote: > I don't know how to diagnose the problem, but now it is the second > time. After starting a VM in VirtualBox and filling the memory, Chrome > stopped loading any pages. After logging out and on, it still wasn't > working, reboot fixed

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 09:38:52PM +0100, Hugo Mills wrote: > On Wed, Oct 03, 2012 at 11:34:00PM +0300, Ilya Dryomov wrote: > > On Wed, Oct 03, 2012 at 07:22:31PM +0200, Goffredo Baroncelli wrote: > [snip] > > > +static const char * const cmd_disk_free_usage[] = { > > > + "btrfs filesystem df [-d|-

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Hugo Mills
On Wed, Oct 03, 2012 at 11:34:00PM +0300, Ilya Dryomov wrote: > On Wed, Oct 03, 2012 at 07:22:31PM +0200, Goffredo Baroncelli wrote: [snip] > > +static const char * const cmd_disk_free_usage[] = { > > + "btrfs filesystem df [-d|-s][-k] [..]", > > + "Show space usage information for a mount poi

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 07:22:31PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > The command btrfs filesystem df is used to query the > status of the chunks, how many space on the disk(s) are used by > the chunks, how many space are available in the chunks, and an > est

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 10:01:00PM +0200, Goffredo Baroncelli wrote: > On 10/03/2012 07:46 PM, Ilya Dryomov wrote: > >On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: > >>On 10/03/2012 05:01 PM, Ilya Dryomov wrote: > >>>"Type" for the first column is probably enough. > >>> > >>>

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 07:46 PM, Ilya Dryomov wrote: On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 05:01 PM, Ilya Dryomov wrote: "Type" for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct, it's just a b

Re: [PATCH][BTRFS-PROGS][V2] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 09:32 PM, David Sterba wrote: On Wed, Oct 03, 2012 at 07:22:30PM +0200, Goffredo Baroncelli wrote: $ ./btrfs filesystem df / Path: / Summary: Disk_size: 72.57GB Disk_allocated:25.10GB Disk_unallocated: 47.48GB Logical_size:

Re: [PATCH][BTRFS-PROGS][V2] btrfs filesystem df

2012-10-03 Thread David Sterba
On Wed, Oct 03, 2012 at 07:22:30PM +0200, Goffredo Baroncelli wrote: > $ ./btrfs filesystem df / > Path: / > Summary: > Disk_size: 72.57GB > Disk_allocated:25.10GB > Disk_unallocated: 47.48GB > Logical_size: 23.06GB > Used:

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Theodore Ts'o
On Wed, Oct 03, 2012 at 11:29:58AM -0700, Wade Cline wrote: > In this case, dir_iterate_proc() is being passed into > ext2_dir_iterate2() and is called from ext2fs_process_dir_block(), > not readdir(2). It looks like the main issue would be detecting if the > EXT2_FEATURE_INCOMPAT_FILETYPE flag is

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Wade Cline
On 10/03/2012 10:58 AM, Theodore Ts'o wrote: To clarify, the EXT2_FEATURE_INCOMPAT_FILETYPE flag indicates that there _may_ be file type information in the directory entry (and so only the low 8 bits of name_len should be considered part of the name length), but it does not guarantee that it wil

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Theodore Ts'o
On Wed, Oct 03, 2012 at 10:39:55AM -0700, Wade Cline wrote: > >I would think that using (name_len& 0xFF) is a much simpler solution, > >and my suggestion is to not depend on the file type in the directory > >entry (since there might be some very old ext2 file systems that don't > >set the file typ

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: > On 10/03/2012 05:01 PM, Ilya Dryomov wrote: > >"Type" for the first column is probably enough. > > > >Why is the third column called Chunk-size? If my understanding is > >correct, it's just a break down of Disk_allocated from t

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Wade Cline
On 10/02/2012 02:08 PM, Theodore Ts'o wrote: On Tue, Oct 02, 2012 at 12:02:22PM -0700, Wade Cline wrote: Hello Theodore Ts'o, Is there a function similar to ext2fs_dir_iterate2() that will call a hook function on an ext2_dir_entry_2 structure and not an ext2_dir_entry structure? The reason I

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
Hi, On 10/03/2012 07:20 PM, Ilya Dryomov wrote: filesystem_cmd_group_usage, NULL, { > >>- { "df", cmd_df, cmd_df_usage, NULL, 0 }, > >>+ { "df", cmd_disk_free, cmd_disk_free_usage, NULL, 0 }, > > > >If this command is going to replace df, you should change the functio

Re: tree root

2012-10-03 Thread Mitch Harder
On Wed, Oct 3, 2012 at 11:35 AM, Øystein Sættem Middelthun wrote: > Hi! > > I have a broken btrfs unable to mount because it is unable to find the tree > root. Using find-root I find the following: > > Well block 14102764707840 seems great, but generation doesn't match, > have=109268, want=109269

[PATCH 2/2] Update help page

2012-10-03 Thread Goffredo Baroncelli
From: Goffredo Baroncelli --- man/btrfs.8.in | 94 1 file changed, 94 insertions(+) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 4b0a9f9..0db588f 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -27,6 +27,8 @@ btrfs \- control

[PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
From: Goffredo Baroncelli The command btrfs filesystem df is used to query the status of the chunks, how many space on the disk(s) are used by the chunks, how many space are available in the chunks, and an estimation of the free space of the filesystem. --- cmds-filesystem.c | 284 ++

[PATCH][BTRFS-PROGS][V2] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
>From the man page (see 2nd patch): [...] The command btrfs filesystem df is used to query the status of the chunks, how many space on the disk(s) are used by the chunks, how many space are available in the chunks, and an estimation of the free space of the filesystem. [...] $ ./btrfs file

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 06:34:38PM +0200, Goffredo Baroncelli wrote: > On 10/03/2012 05:02 PM, Ilya Dryomov wrote: > >On Wed, Oct 03, 2012 at 01:43:15PM +0200, Goffredo Baroncelli wrote: > >>The command btrfs filesystem df is used to query the > >>status of the chunks, how many space on the dis

tree root

2012-10-03 Thread Øystein Sættem Middelthun
Hi! I have a broken btrfs unable to mount because it is unable to find the tree root. Using find-root I find the following: Well block 14102764707840 seems great, but generation doesn't match, have=109268, want=109269 Because the filesystem was last in use with a pre 3.2-kernel I am unable

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 05:02 PM, Ilya Dryomov wrote: +static int cmd_disk_free(int argc, char **argv) > +{ > + > + int flags=DF_SHOW_SUMMARY|DF_SHOW_DETAIL|DF_HUMAN_UNIT; > + int i, more_than_one=0; > + > + if (check_argc_min(argc, 2)) > + usage(cmd_disk_free_usage); > + > + for(i

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 05:01 PM, Ilya Dryomov wrote: "Type" for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct, it's just a break down of Disk_allocated from the summary section. If so, why not call it Disk_allocated to avoid confusion?

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 05:02 PM, Ilya Dryomov wrote: On Wed, Oct 03, 2012 at 01:43:15PM +0200, Goffredo Baroncelli wrote: The command btrfs filesystem df is used to query the status of the chunks, how many space on the disk(s) are used by the chunks, how many space are available in the chunks, and

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Hugo Mills
On Wed, Oct 03, 2012 at 06:17:53PM +0200, Goffredo Baroncelli wrote: > On 10/03/2012 01:56 PM, Hugo Mills wrote: > >Looks good. Only a few comments, inline. > > > >On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: [snip] > >Also, use kB, MB, GB, TB for powers-of-ten based

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 01:56 PM, Hugo Mills wrote: Looks good. Only a few comments, inline. On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: $ ./btrfs filesystem df --help usage: btrfs filesystem disk-usage [-d][-s][-k] [..] Show space usage information for a mount point(s

Re: [Btrfs-next] bulid failure at fs/btrfs/ctree.h

2012-10-03 Thread Gordon Ng
Hello David, I compared the source code and found that I did have a merge conflict. This is now resolved and now builds fine. Thanks, Gordon On 3 October 2012 00:14, David Sterba wrote: > On Tue, Oct 02, 2012 at 10:50:26PM +1000, Gordon Ng wrote: >> Hello Josef, >> >> FYI build failure occured i

Re: [PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 01:43:15PM +0200, Goffredo Baroncelli wrote: > The command btrfs filesystem df is used to query the > status of the chunks, how many space on the disk(s) are used by > the chunks, how many space are available in the chunks, and an > estimation of the free space of the

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: > This serie of patches updated the command "btrfs filesystem > df". I update this command because it is not so easy to get > the information about the disk usage from the command "fi df" and "fi show". > > >>From the man page (s

Re: [PATCH 2/2 v3] Btrfs: snapshot-aware defrag

2012-10-03 Thread Chris Mason
On Tue, Sep 25, 2012 at 07:07:53PM -0600, Liu Bo wrote: > On 09/26/2012 01:39 AM, Mitch Harder wrote: > > On Mon, Sep 17, 2012 at 4:58 AM, Liu Bo wrote: > >> This comes from one of btrfs's project ideas, > >> As we defragment files, we break any sharing from other snapshots. > >> The balancing cod

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-03 Thread Josef Bacik
On Wed, Oct 03, 2012 at 06:57:26AM -0600, Alex Lyakas wrote: > Hi Josef, > in send code, in full_send_tree() there is code like this: > key.objectid = found_key.objectid; > key.type = found_key.type; > key.offset = found_key.offset + 1; > >

Re: [PATCH] Btrfs-progs: replace find_mount_root from send code

2012-10-03 Thread Alex Lyakas
Hi Jan, > + mnttab = fopen("/etc/mtab", "r"); Isn't it better to use "/proc/mounts" here? Otherwise, if the FS was mounted using "mount" syscall, then this code will fail to find the correct mount root. > + while ((ent = getmntent(mnttab))) { > + len = strlen(ent->mnt_d

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-03 Thread Alex Lyakas
Hi Josef, in send code, in full_send_tree() there is code like this: key.objectid = found_key.objectid; key.type = found_key.type; key.offset = found_key.offset + 1; ret = btrfs_next_item(send_root, path); if (ret < 0)

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Hugo Mills
Looks good. Only a few comments, inline. On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: > $ ./btrfs filesystem df --help > usage: btrfs filesystem disk-usage [-d][-s][-k] [..] > > Show space usage information for a mount point(s). > > -k Set KB (1024 bytes) as

[PATCH 1/2] Update btrfs filesystem df command

2012-10-03 Thread Goffredo Baroncelli
The command btrfs filesystem df is used to query the status of the chunks, how many space on the disk(s) are used by the chunks, how many space are available in the chunks, and an estimation of the free space of the filesystem. --- cmds-filesystem.c | 264 ++

[PATCH 2/2] Update help page

2012-10-03 Thread Goffredo Baroncelli
--- man/btrfs.8.in | 94 1 file changed, 94 insertions(+) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 4b0a9f9..ed20448 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -27,6 +27,8 @@ btrfs \- control a btrfs filesystem .PP \fB

[PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
This serie of patches updated the command "btrfs filesystem df". I update this command because it is not so easy to get the information about the disk usage from the command "fi df" and "fi show". >From the man page (see 2nd patch): [...] The command btrfs filesystem df is used to query the s

Re: [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage

2012-10-03 Thread Chris Mason
On Wed, Oct 03, 2012 at 12:22:06AM -0600, Goffredo Baroncelli wrote: > On Wed, Oct 3, 2012 at 1:46 AM, Chris Mason wrote: > [...] > > I like it, thanks. Could you please update btrfs fi df to show this > > instead of adding a new command though? > > Hi Chris, > no problem to update the patches,

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Markus F.X.J. Oberhumer
Hi all, is there some official maintainer who feels responsible for pushing the LZO update to Linus? Otherwise I also could issue a pull-request on github, but somehow I don't think that this is the preferred workflow. Cheers, Markus On 2012-08-21 17:21, Markus F.X.J. Oberhumer wrote: > Hi all,

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread richard -rw- weinberger
CC'in akpm. On Wed, Oct 3, 2012 at 12:34 PM, Markus F.X.J. Oberhumer wrote: > Hi all, > > is there some official maintainer who feels responsible for > pushing the LZO update to Linus? > > Otherwise I also could issue a pull-request on github, but somehow I > don't think that this is the preferre

Re: [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage

2012-10-03 Thread Martin Steigerwald
Am Mittwoch, 3. Oktober 2012 schrieb Roman Mamedov: > On Wed, 3 Oct 2012 08:22:06 +0200 > > Goffredo Baroncelli wrote: > > On Wed, Oct 3, 2012 at 1:46 AM, Chris Mason > > wrote: [...] > > > > > I like it, thanks. Could you please update btrfs fi df to show > > > this instead of adding a new co