On Mon, Aug 26, 2013 at 04:56:06PM -0400, Josef Bacik wrote:
+#ifdef BTRFS_ASSERT
+
+static inline void assfail(char *expr, char *file, int lin)
typo: lin instead of line
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
On Fri, Aug 16, 2013 at 02:11:23PM -0600, Chris Murphy wrote:
On Aug 16, 2013, at 12:02 PM, Chris Murphy li...@colorremedies.com wrote:
When a Btrfs multiple device volume is shrunk resized, it directly affects
the partition size…
Oops, this obviously happens with single or multiple
On Thu, Aug 29, 2013 at 10:34:00AM +0800, lilofile wrote:
I made a btrfs on five disks using RAID5 (-d raid5 for mount option).
When a power failure occurs, I can not remount btrfs after my system
reboots. Dmesg for remount is presented as following:
Please note that current implementation
On Thu, Aug 29, 2013 at 01:47:38PM +0800, Miao Xie wrote:
By the current code, if the requested size is very large, and all the extents
in the free space cache are small, we will waste lots of the cpu time to cut
the requested size in half and search the cache again and again until it gets
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote:
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs /dev/null 21
+_scratch_mount
+
+# This will be set to subvolid 256.
On Thu, Aug 29, 2013 at 08:21:51PM +0100, Filipe David Borba Manana wrote:
Count: 5013
Range: 25.000 - 497.000; Mean: 82.767; Median: 64.000; Stddev: 49.972
Percentiles: 90th: 141.000; 95th: 182.000; 99th: 287.000
25.000 - 33.930: 211 ##
33.930 - 45.927: 277
On Fri, Aug 30, 2013 at 03:47:21PM +0100, Filipe David Manana wrote:
Sure.
They're actually better now :)
Thanks. The numbers changed in both samples, but the relative difference
is still 2x improvement in this particular test.
david
--
To unsubscribe from this list: send the line unsubscribe
On Wed, Aug 14, 2013 at 12:29:10PM +0800, Wang Shilong wrote:
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
v2-v3: availiable parts is not true anymore,remove it.
v1-v2: remove wrong copyrights.
Thanks for the updates, I've put
On Wed, Aug 14, 2013 at 04:16:37PM -0700, Zach Brown wrote:
I *think* the second one is just a typo. The chunk's num_stripes was
already initialized from the record, but it's le16. So we'll set the
item's size based on the record's native num_stripes.
@@ -1117,7 +1117,7 @@ static int
On Wed, Aug 14, 2013 at 04:16:45PM -0700, Zach Brown wrote:
+ { NULL, 0, NULL, 0}
+ NULL_CMD_STRUCT,
It's always the last item, so I think the comma should go away,
currently it's mixed. I'll fix it during commit, too trivial to bother
you.
david
--
To unsubscribe from this
I went through the actual fixes and they're selfcontained and now in
integration. Actually, the compilation fail in 1/1 might be caused by a
old sparse utility on my box, I'll check again later.
thanks,
david
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a
On Fri, Aug 30, 2013 at 02:03:28PM -0700, Zach Brown wrote:
Heh, I goofed when building the echo and actual rules, might as well
update that to $ to have it output .c?
@$(check_echo) [SP] $@
$(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $
Yeah, looks better with .c
sparse
On Thu, Aug 29, 2013 at 02:09:57PM -0400, Josef Bacik wrote:
+#define ASSERT(expr) \
+ (likely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
+#else
+#define ASSERT(expr) ((void)0)
+#endif
+
+#define btrfs_assert()
This is unused and without any ifdef-ed alternatives, should go
it.
There is a performance penalty incured by the change, but deleting a
subvolume is not a frequent operation and the tradeoff seems justified
by getting the guarantee stated above.
CC: Alex Lyakas alex.bt...@zadarastorage.com
CC: Josef Bacik jba...@fusionio.com
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs
On Mon, Aug 19, 2013 at 11:48:32AM -0400, Josef Bacik wrote:
@@ -344,10 +442,12 @@ int main(int ac, char **av)
ac = ac - optind;
if (ac == 0)
print_usage();
- if (logical == 0 !extent_tree)
+ if (logical == 0 (!extent_tree !inode))
There's a conflict
On Thu, Aug 29, 2013 at 11:11:50AM -0500, Eric Sandeen wrote:
Also, I'm curious - I know the code existed before your patch 2/2,
but I don't understand why it reserves 1MB for the first superblock
when the first superblock is actually at 64k. Any idea?
I'm not sure... According to the
On Fri, Aug 30, 2013 at 04:50:37PM +0800, Anand Jain wrote:
This fix the regression introduced by 830427d
ie. that's
btrfs-progs: avoid write to the disk before sure to create fs
please note that the commit id is not stable and may change during
integration branch updates.
I was not sure if
On Fri, Aug 30, 2013 at 07:09:01PM +0800, Anand Jain wrote:
as of now, when 'btrfs device add' adds a device it doesn't
check if the given device contains an existing FS. This
patch will change that to check the same. which when true
add will fail, and ask user to use -f option to overwrite.
On Sun, Sep 01, 2013 at 11:39:28AM +0100, Filipe David Borba Manana wrote:
+#ifdef CONFIG_BTRFS_ASSERT
+static int key_search_validate(struct extent_buffer *b,
+struct btrfs_key *key,
+int level)
+{
...
+}
+#endif
+
+static int
On Tue, Jun 11, 2013 at 06:15:17PM -0500, Eric Sandeen wrote:
Preparatory patch to move cmd test files into their
own subdirs.
I'm adding this to integration as it's just an infrastructure change,
but there are some bits missing before we can move more .c files into
their own subdirs. More
On Tue, Jun 11, 2013 at 07:38:03PM -0500, Eric Sandeen wrote:
Move btrfs cmd files to cmd/ subdir
Are you ok with naming the subdirectory 'cmds'?
david
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo
On Mon, Sep 02, 2013 at 03:40:39PM +0100, Filipe David Manana wrote:
Between patch versions v5 to v7, I don't have any strong preference.
All have correct, small and simple code.
I'm ok with v7.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
I wanted to only comment on the ioctl and interface to userspace bits,
but found more things to comment in the kernel code.
On Thu, Aug 08, 2013 at 04:35:45PM +0800, Liu Bo wrote:
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -94,6 +95,9 @@ struct btrfs_ordered_sum;
/* for storing balance
On Mon, Aug 12, 2013 at 10:45:55AM +0800, Liu Bo wrote:
On Fri, Aug 09, 2013 at 02:51:35PM +0200, David Sterba wrote:
I'm not sure that calling it register/unregister is the right thing, IMO
it's more enable/disable as you write in the documentation under each
respective command.
Both
On Tue, Aug 13, 2013 at 12:35:15PM -0700, Mark Fasheh wrote:
Can you (or Mark) please turn it into a subcommand of dedup? The idea is
to merge both in-bound and out-bound dedup into one command, eg.
btrfs dedup files dir/*
I can handle this - it's pretty easy but we have to talk about
On Tue, Aug 20, 2013 at 02:34:05PM -0400, Josef Bacik wrote:
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -505,8 +505,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code
err_code)
case BTRFS_ERROR_DEV_ONLY_WRITABLE:
return
Set the EXTENT_DATA_COMPRESSED flag together with EXTENT_ENCODED as
defined by fiemap spec.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/extent_io.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index fe443fe
On Mon, Sep 02, 2013 at 05:53:42PM +0100, Simon Farnsworth wrote:
On Monday 2 September 2013 18:43:58 David Sterba wrote:
Yes that's what I meant and that's what dupremove in your git tree does,
right?
Using the EXTENT_SAME ioctl without any checks is dangerous, and that's
what btrfs
On Mon, Sep 02, 2013 at 06:43:58PM +0200, David Sterba wrote:
So I would suggest maybe something like the syhntax of btrfs-extent-same.c:
btrfs dedupe files len file1 loff1 file2 loff2 ...
I'm not sure I see what 'len' means here, length of the dedup block?
Now I'm reading more
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/disk-io.c |1 +
include/trace/events/btrfs.h |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 4cbb00a..72cf08b 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs
On Tue, Sep 03, 2013 at 03:25:27PM +0200, Stefan Behrens wrote:
We want to know if there are debugging features compiled in, this may
affect performance. The message is printed before the sanity checks.
Agreed.
Reviewed-by: David Sterba dste...@suse.cz
--
To unsubscribe from this list: send
On Tue, Sep 03, 2013 at 12:19:58PM +0100, Filipe David Borba Manana wrote:
This patch is based on top of branch integration-20130902.
It used to be present in older integration branches, but it suddenly
disappeared in more recent integration branches.
My bad sorry, I hope I haven't lost more
On Sat, Aug 31, 2013 at 01:29:53PM +0800, Anand Jain wrote:
Thanks for taking care of this David. Let me know if anywhere
needs more explanation.
I have been introducing series of device related changes in
btrfs-progs/mkfs which were/is essential bug fix. Fixes looks
complex since
On Tue, Sep 03, 2013 at 06:19:01PM -0400, Jeff Mahoney wrote:
The DEVHTL lookup in btrfs/003 is broken. It can only handle full LUNs and
not partitions on a disk.
Rather than returning 2:0:0:0 for /dev/sdc7, it returns 'block' and we see:
./common/rc: line 2081:
Frist, thank you very much for the patches! I'm going to merge all
except 18/20, expecting V2.
On Thu, Sep 05, 2013 at 10:14:06AM +0800, Anand Jain wrote:
On 09/04/2013 11:22 PM, Wang Shilong wrote:
This patchset tries to fix all the magic return value in btrfs-progs.
Most commands will have
On Thu, Sep 05, 2013 at 10:38:55AM +0800, Gui Hecheng wrote:
The local probe variable in is_ssd() freed upon unsuccessful return;
FYI, I've applied a patch from Wang Shilong Btrfs-progs: fix compile
warning in is_ssd() instead of the hunk below and will remove the
respective changelog line. The
On Mon, Sep 09, 2013 at 04:18:55PM +0200, David Sterba wrote:
On Thu, Sep 05, 2013 at 10:38:55AM +0800, Gui Hecheng wrote:
The local probe variable in is_ssd() freed upon unsuccessful return;
FYI, I've applied a patch from Wang Shilong Btrfs-progs: fix compile
warning in is_ssd() instead
On Thu, Sep 05, 2013 at 09:10:51AM +0200, Stefan Behrens wrote:
Just noticed that you had already sent a V2 with the things fixed that I
have commented, but you sent the 5/5 as a 1/5 and added the changelog
v1-v2 none which made it difficult to recognize :). But maybe David
Sterba is smart
On Fri, Sep 06, 2013 at 09:26:19AM -0400, Josef Bacik wrote:
@@ -93,6 +95,9 @@ static void print_usage(void)
fprintf(stderr, \t-b Number of bytes to be corrupted\n);
fprintf(stderr, \t-e Extent to be corrupted\n);
fprintf(stderr, \t-E The whole extent free to be corrupted\n);
On Tue, Aug 27, 2013 at 03:17:54PM -0400, Jeff Mahoney wrote:
+static int btrfs_ioctl_add_features(struct file *file, void __user *arg)
+{
...
spin_lock(fs_info-super_lock);
+ flags = btrfs_super_compat_flags(super_block);
+ flags |=
On Fri, Sep 06, 2013 at 02:50:56PM -0400, Josef Bacik wrote:
We need to start adding some sanity tests to btrfs-progs to make sure we
aren't
breaking things with our patches. The most important of these tools is
btrfsck.
This patch gets things started by adding a basic btrfsck test that
On Mon, Sep 09, 2013 at 02:13:50PM -0700, Andy Grover wrote:
However, as it stands, the kernel's include/uapi/linux/btrfs.h and
btrfs-progs are GPLv2, which means that a libbtrfs that is based on either
of these might also be construed to need to be GPLv2, and any program
*using* libbtrfs
On Mon, Sep 09, 2013 at 03:57:17PM -0400, Josef Bacik wrote:
On Mon, Sep 09, 2013 at 02:07:43PM -0500, Eric Sandeen wrote:
On 9/9/13 12:13 PM, Josef Bacik wrote:
David might have meant 001-bad-file-extent-bytenr.img though.
Oh yeah that may be good then.
Yes that's what I meant. I thought
I'm not sure this change is necessary. The code is inherited from
kernel, I doubt that this would be wrong unnoticed. PTR_ERR should
be always used after IS_ERR, this does all the typecasts and checks,
the final value is in the range of -MAX_ERRNO..0. MAX_ERRNO is 4095,
even if long is wider than
On Wed, Sep 11, 2013 at 02:34:05PM +0530, chandan wrote:
--- a/man/btrfs.8.in
+++ b/man/btrfs.8.in
@@ -244,7 +244,8 @@ is similar to \fBsubvolume list\fR command.
\fBsubvolume set-default\fR\fI id path\fR
Set the subvolume of the filesystem \fIpath\fR which is mounted as
\fIdefault\fR.
On Fri, Sep 06, 2013 at 05:37:53PM +0800, Anand Jain wrote:
Further, to scan for the disks this patch will use
lblkid, so that we don't have to manually scan the
/dev or /dev/mapper which means we don't need the
all-devices options.
Thanks for implementing it! I found a few things to fix,
On Fri, Sep 06, 2013 at 05:37:52PM +0800, Anand Jain wrote:
+static char *group_type_str(u64 flag)
{
- struct btrfs_ioctl_space_args *sargs, *sargs_orig;
- u64 count = 0, i;
- int ret;
- int fd;
- int e;
- char *path;
- DIR *dirstream = NULL;
-
- if
On Thu, Sep 12, 2013 at 04:08:15PM +0800, Qu Wenruo wrote:
Use kernel workqueue and kernel workqueue based new btrfs_workqueue_struct to
replace
the old btrfs_workers.
The main goal is to reduce the redundant codes(800 lines vs 200 lines) and
try to get benefits from the latest workqueue
On Fri, Sep 13, 2013 at 11:02:10AM +0530, chandan wrote:
On Thursday, September 12, 2013 03:29:52 PM David Sterba wrote:
The number 5 is an implementation detail, we should recommend to use 0.
In the current btrfs kernel code if 0 is passed as the subvolume id
On Fri, Sep 13, 2013 at 07:34:10PM +0530, chandan wrote:
This patch makes it possible to set BTRFS_FS_TREE_OBJECTID as the default
subvolume by passing a subvolume id of 0.
Signed-off-by: chandan chan...@linux.vnet.ibm.com
Reviewed-by: David Sterba dste...@suse.cz
--
To unsubscribe from
It's still possible to flip the filesystem into RW mode after it's
remounted RO due to an abort. There are lots of places that check for
the superblock error bit and will not write data, but we should not let
the filesystem appear read-write.
Signed-off-by: David Sterba dste...@suse.cz
---
fs
On Fri, Sep 13, 2013 at 06:49:10PM +0800, Anand Jain wrote:
I wonder if we should keep --all-devices as a last resort fallback eg.
Any idea whats the real use of --all-devices option anyway
I am unsure. Anyway will restore --all-devices so now.
That's when udev breaks or is not present on
On Fri, Sep 13, 2013 at 11:46:50AM -0400, Frank Holton wrote:
The kernel log entries for device label %s and device fsid %pU
are missing the btrfs: prefix. Add those here.
Signed-off-by: Frank Holton fhol...@gmail.com
Reviewed-by: David Sterba dste...@suse.cz
- printk(KERN_INFO
On Fri, Sep 13, 2013 at 05:56:46PM +0200, David Sterba wrote:
Reproduced with today's linus tree (btrfs pull is there), progs contain the
patches in question:
Reproduces with the updated patches you sent today.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body
On Fri, Sep 13, 2013 at 07:32:23PM +0800, Anand Jain wrote:
Further, this patch adds new parameters mounted and
group profile info in the filesystem show output
Sorry to bother you, but the 'further' part of the patch should be
separated out. The core change of the patch is to use libblkid and
On Fri, Sep 13, 2013 at 07:32:22PM +0800, Anand Jain wrote:
+static int get_df(int fd, struct btrfs_ioctl_space_args **sargs_ret)
+{
This function returns full error codes, that's ok,
@@ -77,89 +98,79 @@ static int cmd_df(int argc, char **argv)
ret = ioctl(fd, BTRFS_IOC_SPACE_INFO,
On Mon, Sep 16, 2013 at 04:18:24PM +0800, Liu Bo wrote:
@@ -4122,7 +4136,7 @@ int extent_fiemap(struct inode *inode, struct
fiemap_extent_info *fieinfo,
last = found_key.offset;
last_for_get_extent = last + 1;
}
- btrfs_free_path(path);
+
.
[1]:
http://thr3ads.net/ocfs2-devel/2010/09/489052-PATCH-3-3-shared-du-using-fiemap-to-figure-up-the-shared-extents-per-file-and-the-footprint-in
Signed-off-by: Liu Bo bo.li@oracle.com
Reviewed-by: David Sterba dste...@suse.cz
--
To unsubscribe from this list: send the line unsubscribe linux
On Sun, Sep 15, 2013 at 12:30:35PM +0800, Anand Jain wrote:
IMO group profile is useful info to have it at both the places.
end user using this new btrfs fi show would surely notice that it
will reduce other commands normally used following the current
btrfs fi show command. (like mount
On Mon, Sep 16, 2013 at 03:58:09PM +0100, Ross Kirk wrote:
Remove unused eb parameter from btrfs_item_nr
Hmm it's been unused since day one
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee
Mon Oct 15 16:14:19 2007
Signed-off-by: Ross Kirk ross.k...@gmail.com
Reviewed-by: David Sterba dste...@suse.cz
On Tue, Sep 10, 2013 at 12:24:09AM -0400, Jeff Mahoney wrote:
+static int btrfs_ioctl_set_features(struct file *file, void __user *arg)
+{
+ struct btrfs_root *root = BTRFS_I(file_inode(file))-root;
+ struct btrfs_super_block *super_block = root-fs_info-super_copy;
+ struct
On Mon, Sep 16, 2013 at 10:21:24PM -0400, Frank Holton wrote:
I'm working on a patch to add the recursive option to the
btrfs filesystem defrag command.
Great!
I'd like some feedback on how the patch looks as written. I've added
two helper functions, which might need to be renamed, one to
On Mon, Sep 09, 2013 at 02:21:58PM +0800, Miao Xie wrote:
On fri, 06 Sep 2013 15:47:08 +0200, Stefan Behrens wrote:
This patch makes the xfstest generic/256 lock up. It's quite
reliably reproducible on one of my test boxes, and not at all
visible on a second test box.
And yes, I'm
Signed-off-by: David Sterba dste...@suse.cz
---
mkfs.c | 8
utils.c | 4 ++--
utils.h | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/mkfs.c b/mkfs.c
index 3ac00ba..40da546 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1324,7 +1324,7 @@ int main(int ac, char **av
David Sterba (2):
btrfs-progs: use better name for nodiscard variable and flip the logic
btrfs-progs: add nodiscard option to device add
cmds-device.c | 34 +-
man/btrfs.8.in | 11 +--
mkfs.c | 8
utils.c| 6 --
utils.h
David Sterba (3):
btrfs-progs: introduce rescue command group
btrfs-progs: move chunk-recover to rescue group
btrfs-progs: separate command ant implementation of chunk-recover code
Makefile|3 +-
btrfs.c |2 +-
chunk-recover.c | 1745
Add an empty 1st level command namespace that will collect specialized
recovery tools like chunk-recover, zero-log, select-super and similar.
Signed-off-by: David Sterba dste...@suse.cz
---
Makefile | 2 +-
btrfs.c| 1 +
cmds-rescue.c | 37
Signed-off-by: David Sterba dste...@suse.cz
---
btrfs.c| 1 -
cmds-chunk.c | 2 +-
cmds-rescue.c | 1 +
man/btrfs.8.in | 10 ++
4 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/btrfs.c b/btrfs.c
index 14a27cb..dfae35f 100644
--- a/btrfs.c
+++ b/btrfs.c
The devices in 'btrfs filesystem show' are now sorted by the device id,
currently the order was undefined.
Signed-off-by: David Sterba dste...@suse.cz
---
Makefile | 2 +-
cmds-filesystem.c | 19 ++-
list_sort.c | 144
...@cn.fujitsu.com
Signed-off-by: David Sterba dste...@suse.cz
---
Makefile|3 +-
chunk-recover.c | 1745 +++
cmds-rescue.c | 62 ++
3 files changed, 1809 insertions(+), 1 deletion(-)
create mode 100644 chunk-recover.c
diff --git
On Mon, Sep 16, 2013 at 02:19:11PM -0400, Jeff Mahoney wrote:
+static int btrfs_ioctl_set_features(struct file *file, void __user *arg)
+{
...
+ trans = btrfs_start_transaction(root, 1);
trans = btrfs_start_transaction(root, 0);
+ if (IS_ERR(trans))
+ return
On Mon, Sep 16, 2013 at 02:19:11PM -0400, Jeff Mahoney wrote:
There are some feature bits that require no offline setup and can
be enabled online. I've only reviewed extended irefs, but there will
probably be more.
Each feature bit being set online has to be treated separately regarding
safety
On Wed, Sep 18, 2013 at 01:28:32PM +0100, Ross Kirk wrote:
Signed-off-by: Ross Kirk ross.k...@gmail.com
Reviewed-by: David Sterba dste...@suse.cz
Do I need to update anything following the Reviewed-by sign off? First
time submitting a patch so still working things out :)
No you don't
On Wed, Sep 18, 2013 at 09:11:01AM +0800, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
The dependencies of all: version.h or other similar ones can not
fix the parallel build failure, only reduce the times; In fact,
many *.o files require version.h file.
On Wed, Sep 18, 2013 at 04:27:36PM +0800, Wang Shilong wrote:
--- a/disk-io.c
+++ b/disk-io.c
@@ -982,7 +982,8 @@ int btrfs_setup_chunk_tree_and_device_map(struct
btrfs_fs_info *fs_info)
static struct btrfs_fs_info *__open_ctree_fd(int fp, const char *path,
On Wed, Sep 18, 2013 at 04:27:32PM +0800, Wang Shilong wrote:
Until now if one of device's first superblock is corrupt,btrfs will
fail to mount. Luckily, btrfs have at least two superblocks for
every disk.
This little program will scan devices and find good superblocks
(max generation,
Signed-off-by: David Sterba dste...@suse.cz
---
.hgignore | 1 -
.hgtags| 15 ---
version.sh | 20
3 files changed, 36 deletions(-)
delete mode 100644 .hgignore
delete mode 100644 .hgtags
diff --git a/.hgignore b/.hgignore
deleted file mode 100644
index
Find the tree id of the containing subvolume for a given file or
directory. For subvolume return it's own id.
$ btrfs inspect-internal rootid path
Signed-off-by: David Sterba dste...@suse.cz
---
cmds-inspect.c | 38 ++
man/btrfs.8.in |9
On Wed, Sep 18, 2013 at 11:31:16PM +0800, Wang Shilong wrote:
static struct btrfs_fs_info *__open_ctree_fd(int fp, const char *path,
u64 sb_bytenr,
u64 root_tree_bytenr, int writes,
-
that in the command. With this patch we now pass again with the fix for the 0
subvolid. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Tested-by: David Sterba dste...@suse.cz
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord
On Wed, Sep 18, 2013 at 12:04:30PM +0800, Miao Xie wrote:
On Tue, 17 Sep 2013 15:13:12 +0200, David Sterba wrote:
On Mon, Sep 09, 2013 at 02:21:58PM +0800, Miao Xie wrote:
On fri, 06 Sep 2013 15:47:08 +0200, Stefan Behrens wrote:
The massive slowdown is present in current 3.12-rc code
Hi stable team,
please add the following commits to 3.11 tree, they fix user visible problems,
were tested and are now present in 3.12-rc1.
3d05ca371200b3366530621abf73769024581b79
b13a004528c3e5eb060a26eee795f5a0da7bfe9f
7ef67ffda91cc0c56f33937bfdf1d057b9ee96ca
The message about trim was printed unconditionally, we should check if
trim is supported at all.
Signed-off-by: David Sterba dste...@suse.cz
---
utils.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/utils.c b/utils.c
index 5fa193b..6c74654 100644
--- a/utils.c
When creating a fs on a loop device, mkfs checks whether the same file
is not already mounted, but a backing file of another loop dev does not
exist, mkfs fails. This fixes a bug during openSUSE installation.
Signed-off-by: David Sterba dste...@suse.cz
---
utils.c | 36
On Fri, Sep 20, 2013 at 11:32:41AM -0400, Josef Bacik wrote:
I've been wanting to get back to the allocator and make some changes to try
and
fix our fragmenation woes with lots of metadata. But in order to make these
changes I need to have something to tell me if my changes are making a real
On Sat, Sep 21, 2013 at 09:16:25AM +0800, Wang Shilong wrote:
- open_ctree_fs_info_restore(target, 0, 0, 0, 1);
+ open_ctree_fs_info_restore(target, 0, 0, OPEN_CTREE_PARTIAL);
Good idea, i think this should be another patch.
yes
--
To unsubscribe from this list: send the line unsubscribe
On Sun, Sep 22, 2013 at 09:06:39AM +0800, Rongqing Li wrote:
I want to know how many cores your cpu has? I can not reproduce it on
my 2 cores cpu, but it always happens when run on a server which is
a 16 cores cpu and make -j20
Depends on what you call a core, I've tested this on a box with 8
On Mon, Sep 23, 2013 at 10:08:08AM -0500, Eric Sandeen wrote:
On 9/20/13 11:42 AM, David Sterba wrote:
The message about trim was printed unconditionally, we should check if
trim is supported at all.
Good idea, but I wonder if there's any risk that discard(0,0) will ever
be optimized away
On Fri, Sep 20, 2013 at 09:53:02AM -0700, Greg KH wrote:
On Fri, Sep 20, 2013 at 06:34:39PM +0200, David Sterba wrote:
3d05ca371200b3366530621abf73769024581b79
b13a004528c3e5eb060a26eee795f5a0da7bfe9f
7ef67ffda91cc0c56f33937bfdf1d057b9ee96ca
ca6d07c1d74bf7ba3083bc31a9aeeaa1d0ad86aa
On Mon, Sep 23, 2013 at 07:43:44AM +0700, Tomasz Chmielewski wrote:
Not sure if it's anything interesting - I had the following entry in
dmesg a few days ago, on a server with 32 GB RAM. The system is still working
fine.
Yes this is interesting of course.
[1878432.675210] btrfs-qgroup-re:
On Tue, Sep 17, 2013 at 11:30:52AM -0400, Frank Holton wrote:
Thanks for that hint to use ftw. I've updated the code to use it and
tried to make sure
that I caught all of the styling errors.
Dunno what caused that, but the whitespace is completely messed up and
squasthed into a single space
On Mon, Sep 23, 2013 at 01:43:48PM -0400, Josef Bacik wrote:
I've done that with a patch in bugzilla, hopefully that will fix it. I've not
had time to try and reproduce myself, but I assume if you do something like
create a random file, then create 10 snapshots and then defrag it will
On Wed, Sep 25, 2013 at 08:56:47AM +0200, Guenther Starnberger wrote:
On one of my btrfs filesystems I'm encountering a reproducable kernel bug
during rebalancing. This issue originally appeared on Linux 3.11.1, but I am
also able to reproduce it in a VM using btrfs-next (c024ca6) and Linux
On Mon, Sep 23, 2013 at 02:17:19PM +0800, Wang Shilong wrote:
Firstly, we restructure show_qgroups, make it easy to add new features.
And then we add '-p' '-c', '-l',and '-e' options to print the parent
qgroup id, child qgroup id, max referenced size and max exclusive size
of qgroup
On Sat, Sep 28, 2013 at 12:21:51AM +0800, Wang Shilong wrote:
Following this patch the idea is to use lblkid to scan
for the btrfs disks by default which means we don't
use BTRFS_SCAN_PROC any more.
Firstly, i would like to know if we will get any different results between
scanning
On Mon, Sep 23, 2013 at 03:18:17PM -0400, Frank Holton wrote:
Add an option to defrag all files in a directory recursively.
I had this patch merged but still saw some problems. If there's eg. a
symlink to file on another filesystem, defrag fails with
ERROR: defrag range ioctl not supported in
On Sun, Sep 29, 2013 at 11:02:29PM +0800, Anand Jain wrote:
this is to avoid duplicate codes, which indeed spans across
most of the search functions that's in there in btrfs-progs.
what you suggest is good, but its better to do that collectively.
Good cleanup idea, added to wiki todo list.
On Sun, Sep 29, 2013 at 11:25:36PM +0800, Anand Jain wrote:
It needs a lot more information about the snapshots if
snapshot's life cycle has to be all auto managed by
scripts _some day_. this patch is a step towards that.
This patch provides the size which would be freed
if the
On Tue, Oct 01, 2013 at 08:25:38PM +0800, Wang Shilong wrote:
* -l sounds less intuitive, I suggest to use -r as for
'referenced', given that there is -e for 'exclusive'.
Yeah, here -l means limited size. Anyway, this is a little obscure.
Maybe -r is better, but it may let user think it
On Sat, Sep 28, 2013 at 10:51:54AM -0700, Saul Wold wrote:
On 09/28/2013 05:29 AM, Chris Mason wrote:
Ah great news! I want to verify is your git repo for btrfs-progs the main
upstream? I see loads of other patches flying around, but not applied
there.
The patches land in the integration
101 - 200 of 6778 matches
Mail list logo
