Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Christoph Anton Mitterer
On Thu, 2015-12-17 at 01:09 +, Duncan wrote: > Well, "don't load the journal on mounting" is exactly what the option > would do.  The journal (aka log) of course has a slightly different > meaning, it's only the fsync log, but loading it is exactly what the > option would prevent, here.

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Duncan
Christoph Anton Mitterer posted on Wed, 16 Dec 2015 12:45:00 +0100 as excerpted: > On Wed, 2015-12-16 at 11:10 +, Duncan wrote: >> And noload doesn't have the namespace collision problem norecovery does >> on btrfs, so I'd strongly suggest using it, at least as an alias for >> whatever other

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Duncan
Qu Wenruo posted on Wed, 16 Dec 2015 09:36:23 +0800 as excerpted: > David Sterba wrote on 2015/12/14 18:32 +0100: >> On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: >>> Introduce a new mount option "nologreplay" to co-operate with "ro" >>> mount option to get real readonly mount, like

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Christoph Anton Mitterer
On Wed, 2015-12-16 at 11:10 +, Duncan wrote: > And noload doesn't have the namespace collision problem norecovery > does > on btrfs, so I'd strongly suggest using it, at least as an alias for > whatever other btrfs-specific name we might choose. but noload is, AFAIU, not what's desired

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Austin S. Hemmelgarn
On 2015-12-16 06:10, Duncan wrote: Qu Wenruo posted on Wed, 16 Dec 2015 09:36:23 +0800 as excerpted: David Sterba wrote on 2015/12/14 18:32 +0100: On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread David Sterba
On Mon, Dec 14, 2015 at 12:50:37PM -0500, Austin S. Hemmelgarn wrote: > On 2015-12-14 12:32, David Sterba wrote: > > On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: > >> Introduce a new mount option "nologreplay" to co-operate with "ro" mount > >> option to get real readonly mount, like

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Austin S. Hemmelgarn
On 2015-12-16 07:34, Christoph Anton Mitterer wrote: On Wed, 2015-12-16 at 07:12 -0500, Austin S. Hemmelgarn wrote: I kind of agree with Christoph here. I don't think that noload should be the what we actually use, although I do think having it as an alias for whatever name we end up using

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread David Sterba
On Wed, Dec 16, 2015 at 09:36:23AM +0800, Qu Wenruo wrote: > > > > mount -o ro,nowr /dev/sdx /mnt > > > > would work when switching kernels. > > > That would be nice. > > I'd like to forward the idea/discussion to filesystem ml, not only btrfs > maillist. Good idea. > Such behavior should

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Christoph Anton Mitterer
On Wed, 2015-12-16 at 07:12 -0500, Austin S. Hemmelgarn wrote: > I kind of agree with Christoph here.  I don't think that noload > should > be the what we actually use, although I do think having it as an > alias > for whatever name we end up using would be a good thing. No, because people would

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-16 Thread Christoph Anton Mitterer
On Wed, 2015-12-16 at 07:57 -0500, Austin S. Hemmelgarn wrote: > No, because we should ease the transition from other filesystems to > the > greatest extent reasonably possible.  It should be clearly documented > as > an alias for compatibility with ext{3,4}, and that it might go away > in >

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-15 Thread Austin S. Hemmelgarn
On 2015-12-14 18:34, Christoph Anton Mitterer wrote: On Mon, 2015-12-14 at 15:20 -0500, Austin S. Hemmelgarn wrote: On 2015-12-14 14:44, Christoph Anton Mitterer wrote: On Mon, 2015-12-14 at 14:33 -0500, Austin S. Hemmelgarn wrote: The traditional reasoning was that read-only meant that users

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-15 Thread Qu Wenruo
David Sterba wrote on 2015/12/14 18:32 +0100: On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-15 Thread Christoph Anton Mitterer
On Wed, 2015-12-16 at 09:36 +0800, Qu Wenruo wrote: > One sad example is, we can't use 'norecovery' mount option to disable > log replay in btrfs, as there is 'recovery' mount option already. I think "norecovery" would anyway not really fit... the name should rather indicated, that from the

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Christoph Anton Mitterer
On Mon, 2015-12-14 at 15:20 -0500, Austin S. Hemmelgarn wrote: > On 2015-12-14 14:44, Christoph Anton Mitterer wrote: > > On Mon, 2015-12-14 at 14:33 -0500, Austin S. Hemmelgarn wrote: > > > The traditional reasoning was that read-only meant that users > > > couldn't > > > change anything > >

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread David Sterba
On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: > Introduce a new mount option "nologreplay" to co-operate with "ro" mount > option to get real readonly mount, like "norecovery" in ext* and xfs. > > Since the new parse_options() need to check new flags at remount time, > so add a new

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Austin S. Hemmelgarn
On 2015-12-14 14:44, Christoph Anton Mitterer wrote: On Mon, 2015-12-14 at 14:33 -0500, Austin S. Hemmelgarn wrote: The traditional reasoning was that read-only meant that users couldn't change anything Where I'd however count the atime changes to. The atimes wouldn't change magically, but

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Christoph Anton Mitterer
On Mon, 2015-12-14 at 18:32 +0100, David Sterba wrote: > I've read the discussions around the change and from the user's POV > I'd > suggest to add another mount option that would be just an alias for > any > mount options that would implement the 'hard-ro' semantics. Nice to hear...  > Say it's

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Christoph Anton Mitterer
On Mon, 2015-12-14 at 12:50 -0500, Austin S. Hemmelgarn wrote: > It should also imply noatime.  I'm not sure how BTRFS handles atime > when > mounted RO, but I know a lot of old UNIX systems updated atime even > on > filesystems mounted RO, and I know that at least at one point Linux > did too.

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Austin S. Hemmelgarn
On 2015-12-14 14:16, Christoph Anton Mitterer wrote: On Mon, 2015-12-14 at 12:50 -0500, Austin S. Hemmelgarn wrote: It should also imply noatime. I'm not sure how BTRFS handles atime when mounted RO, but I know a lot of old UNIX systems updated atime even on filesystems mounted RO, and I know

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Christoph Anton Mitterer
On Mon, 2015-12-14 at 14:33 -0500, Austin S. Hemmelgarn wrote: > The traditional reasoning was that read-only meant that users > couldn't > change anything Where I'd however count the atime changes to. The atimes wouldn't change magically, but only because the user stared some program, configured

Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-14 Thread Austin S. Hemmelgarn
On 2015-12-14 12:32, David Sterba wrote: On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new

[PATCH v3] btrfs: Introduce new mount option to disable tree log replay

2015-12-09 Thread Qu Wenruo
Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new flags at remount time, so add a new parameter for parse_options(). Signed-off-by: Qu Wenruo