ins the bhs while committing journal so
> > try_to_release_page fails when jbd
> > is committing the transaction.
>
> Yeah. It sure would be fantastic if some ext3 expert could stop this
> from happening somehow. But that hasn't happened in.. uh.. Badari, for
> how many y
On Tue, 2007-11-06 at 17:43 -0800, Zach Brown wrote:
> At the FS meeting at LCE there was some talk of doing O_DIRECT writes from the
> kernel with pages instead of with iovecs. T
Why ? Whats the use case ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubs
still movable even if there is no file system method
> > for migration available. In that case the page needs to be cleaned before
> > it can be moved.
> >
>
> Badari, do you know if the pages failed to migrate because they were
> dirty or because the filesystem si
On Thu, 2007-11-01 at 10:10 -0800, Badari Pulavarty wrote:
> On Thu, 2007-11-01 at 11:51 -0400, Chris Mason wrote:
> > On Thu, 01 Nov 2007 08:38:57 -0800
> > Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > > On Wed, 2007-10-31 at 13:40 -0400, Chris Mason w
On Thu, 2007-11-01 at 11:51 -0400, Chris Mason wrote:
> On Thu, 01 Nov 2007 08:38:57 -0800
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
>
> > On Wed, 2007-10-31 at 13:40 -0400, Chris Mason wrote:
> > > On Wed, 31 Oct 2007 08:14:21 -0800
> > > Bad
On Wed, 2007-10-31 at 13:40 -0400, Chris Mason wrote:
> On Wed, 31 Oct 2007 08:14:21 -0800
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > I tried data=writeback mode and it didn't help :(
>
> Ouch, so much for the easy way out.
>
> >
On Tue, 2007-10-30 at 18:58 -0400, Chris Mason wrote:
> On Tue, 30 Oct 2007 13:54:05 -0800
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
>
> > On Tue, 2007-10-30 at 13:54 -0400, Chris Mason wrote:
> > > On Tue, 30 Oct 2007 10:27:04 -0800
> > > Bad
Chris Mason wrote:
On Tue, 30 Oct 2007 13:54:05 -0800
Badari Pulavarty <[EMAIL PROTECTED]> wrote:
On Tue, 2007-10-30 at 13:54 -0400, Chris Mason wrote:
On Tue, 30 Oct 2007 10:27:04 -0800
Badari Pulavarty <[EMAIL PROTECTED]> wrote:
Hi,
While testing hotplug memo
On Tue, 2007-10-30 at 13:54 -0400, Chris Mason wrote:
> On Tue, 30 Oct 2007 10:27:04 -0800
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
>
> > Hi,
> >
> > While testing hotplug memory remove, I ran into this issue. Given a
> > range of pages hotplug mem
why the b_count == 1 and not getting dropped to zero ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ee_pages() waste
> 1/3-1/2 page space.
>
> What was the originally intention to set up slabs for committed_data(and
> frozen_buffer) in JBD? Why not using kmalloc?
>
> Mingming
Looks good. Small suggestion is to get rid of all kmalloc() usages and
consistently use jbd_kmallo
the BUG_ON condition is a
> good one.
I will ask them to try that.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
). But unfortunately, our perf. team is able reproduce the
problem. Debug indicated that, the ret2 == 1 :(
Not sure how that can happen. Ideas ?
Thanks,
Badari
>
> ---
>
> dio: remove bogus refcounting BUG_ON
>
> Badari Pulavarty reported a case of this BUG_ON is trig
Zach Brown wrote:
On Jun 27, 2007, at 8:01 PM, Badari Pulavarty wrote:
Hi Zach,
One of our perf. team ran into this while doing some runs.
I didn't see anything obvious - it looks like we converted
async IO to synchronous one. I didn't spend much time digging
around.
It lo
Hi Zach,
One of our perf. team ran into this while doing some runs.
I didn't see anything obvious - it looks like we converted
async IO to synchronous one. I didn't spend much time digging
around.
Is this a known issue ? Any ideas ?
Thanks,
Badari
[ cut here ]-
spin_unlock(&dentry->d_lock);
> + union_lock(dentry);
> + }
> +}
> +
> +static inline struct union_info *union_lock_and_get(struct dentry *dentry)
> +{
> + union_lock(dentry);
> + return union_get(dentry->d_union);
> +}
> +
> +/* Shouldn't be called with last reference to union_info */
> +static inline void union_put_and_unlock(struct union_info *uinfo)
> +{
> + union_put(uinfo);
> + __union_unlock(&uinfo->u_mutex);
^^^
It should be
__union_unlock(uinfo);
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
reak;
> + loop3:
> + union_unlock(fs->altroot);
> + loop2:
> + union_unlock(fs->root);
> + loop1:
> + read_unlock(&fs->lock);
> + UM_DEBUG_LOCK("Failed to get all semaphores in fs_struct!\n");
> + cpu_re
new_inode (handle, dir, S_IFWHT | S_IRUGO);
> + err = PTR_ERR(inode);
> + if (IS_ERR(inode))
> + goto out_stop;
Don't you need to call init_special_inode() here ?
Or this is handled somewhere else ?
> +
> + err = ext3_add_nondir(handle, dentry, inode);
> +
> +out_stop:
> + ext3_journal_stop(handle);
> + if (err == -ENOSPC && ext3_should_retry_alloc(dir->i_sb, &retries))
> + goto retry;
> + return err;
> +}
> +
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
methods.
Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 156
1 file changed, 102 insertions(+), 54 deletions(-)
Index: linux-2.6.21-rc6.aop/fs/ext4/inode.c
==
On Fri, 2007-04-13 at 01:25 +0200, Nick Piggin wrote:
> On Thu, Apr 12, 2007 at 09:37:36AM -0700, Badari Pulavarty wrote:
> > On Thu, 2007-04-12 at 06:48 +0200, Nick Piggin wrote:
> > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
> > >
On Thu, 2007-04-12 at 06:48 +0200, Nick Piggin wrote:
> http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
>
> 2.6.21-rc6-new-aops*
>
> New aops patchset against 2.6.21-rc6.
Building modules, stage 2.
MODPOST 558 modules
WARNING: ".cont_prepare_write" [fs/hfsplus/hfsplu
(since "ret" will be mostly positive).
Instead can we do this ?
+ copied = block_write_end(file, mapping, pos, len, copied, page,
fsdata);
+ if (copied < 0)
+ ret = copied;
Thanks,
Badari
-
To unsubscribe from this list: send th
On Thu, 2007-04-05 at 04:08 +0200, Nick Piggin wrote:
> On Wed, Apr 04, 2007 at 04:32:24PM -0700, Badari Pulavarty wrote:
> > On Wed, 2007-04-04 at 16:17 -0700, Mark Fasheh wrote:
> > > On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote:
> > > > Hmm
On Wed, 2007-04-04 at 16:17 -0700, Mark Fasheh wrote:
> On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote:
> > Hmm.. Okay, only filesystems that could return AOP_TRUNCATED_PAGE
> > are ocf2 and gfs2. Now that both of them are switched to have
> > write_begin()/w
if (ret == AOP_TRUNCATED_PAGE)
> + goto again;
> + }
> + return ret;
> + }
Hmm.. Okay, only filesystems that could return AOP_TRUNCATED_PAGE
are ocf2 and gfs2. Now that both of them are switched to have
write_begin()/write_end(),
On Wed, 2007-04-04 at 15:51 -0700, Mark Fasheh wrote:
> On Wed, Apr 04, 2007 at 03:39:48PM -0700, Badari Pulavarty wrote:
> > Could you elaborate on issues ext3 caused ? Its pretty stable for
> > me (after bunch of simple fixes, I posted earlier). Anything I need
> > to be awa
ust temporarily dropped
> it for my immediate work.
Could you elaborate on issues ext3 caused ? Its pretty stable for
me (after bunch of simple fixes, I posted earlier). Anything I need
to be aware ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdeve
(vs hacking the existing methods).
Thanks,
Badari
---
fs/ext4/inode.c | 171 +---
1 file changed, 113 insertions(+), 58 deletions(-)
Index: linux-2.6.21-rc5/fs/ext4/inode.c
===
--- l
name).
>
I haven't seen an fsx failure recently. I ran 4 copies of fsx
on 2.6.21-rc5 and 2.6.21-rc5+aops, without any problems for
12+ hours. What am I missing ?
Mingming, do you know of any fsx failures recently ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubsc
On Tue, 2007-04-03 at 01:58 +0200, Nick Piggin wrote:
> On Mon, Apr 02, 2007 at 01:44:59PM -0700, Badari Pulavarty wrote:
> > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> > > Updated aops patchset against 2.6.21-rc5.
> > >
> > > http://www.kernel
On Tue, 2007-04-03 at 01:49 +0200, Nick Piggin wrote:
> On Mon, Apr 02, 2007 at 04:14:59PM -0700, Badari Pulavarty wrote:
> > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> > > Updated aops patchset against 2.6.21-rc5.
> > >
> > > http://www.kernel
e a shot at ext4 tomorrow.
(If you want me to roll all my fixes and send them to you,u,
5.)
1 c link
5.origĀ
h2
(
and send them to you,
let me know).
Thanks,
Badari
---
mm/filemap.c |2 --
1 file changed, 2 deletions(-)
Index: linu
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> Updated aops patchset against 2.6.21-rc5.
>
> http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
>
> Files/dirs are 2.6.21-rc5-new-aops*
ext3_write_begin() is computing "start" incorrectly.
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> Updated aops patchset against 2.6.21-rc5.
>
> http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
>
Sorry to send you so many silly fixes, but I though it would
be easy to review individual ones.
Th
to support nobh versions of block_write_begin/end ?
BTW, I don't see how block_write_end() can ever return < 0.
If so, here is the cleanup fix for ext3 (no unnecessay checks).
Thanks,
Badari
---
fs/ext3/inode.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
Index: l
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> Updated aops patchset against 2.6.21-rc5.
>
> http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
>
> Files/dirs are 2.6.21-rc5-new-aops*
>
Simple cleanup for block_write_begin().
Thanks,
Badari
include/linux/version.h
CHK include/linux/utsrelease.h
Building modules, stage 2.
MODPOST 1281 modules
WARNING: "cont_write_begin" [fs/fat/fat.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Here is the fix.
Thanks,
Badari
---
fs/buffer.c |
x27;d say the core code is
> getting reasonably stable at this point.
ext3_write_failure() conversion is NOT quite correct.
Old code was returing failure of do_journal_get_write_access(),
where as your changes will return journal_stop().
Thanks,
Badari
---
fs/ext3/inode.c |7 +--
1 fil
In case of error, write_begin() is *supposed* to unlock and release the
page it locked. Right ?
If so, ext3 error handling is not quite right :(
Here is the fix.
Thanks,
Badari
---
fs/ext3/inode.c | 10 --
1 file changed, 8 insertions(+)
On Fri, 2007-03-02 at 09:16 -0600, Eric Sandeen wrote:
> Badari Pulavarty wrote:
> >
> > Amit K. Arora wrote:
> >
> >> This is to give a heads up on few patches that we will be soon coming up
> >> with. These patches implement a new system call sys_fal
es ?
Just curious .. What does posix_fallocate() return ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2005-07-26 at 15:52 -0700, Andrew Morton wrote:
> Mingming Cao <[EMAIL PROTECTED]> wrote:
> >
> > Here is the updated patch from Badari for delayed allocation for ext3.
> > Delayed allocation defers block allocation from prepare-write time to
> > p
Nir Tzachar wrote:
On Wed, 2005-07-20 at 20:14 -0700, Badari Pulavarty wrote:
Nir Tzachar wrote:
hello list.
can someone please explain the exact semantics the get_block_t function
(which is passed to mpage_readpage(s)) should implement??
i could not find any documentation, and existing
disk block# of the block. (and size of the block). If "create"
is one, it needs to allocate the block (if it doesn't already exist).
Makes sense ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAI
NING "EXT3-fs: Ignoring delall option
> > - "
> > + "its supported only with writeback mode\n");
>
> Should be "ignoring delalloc option".
Yep.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
write would not call
> unmap_underlying_metadata).
>
> I think we'll go for the first method, but the second would make life
> easier for filesystems which can have pages consisting of both mapped
> and reserved blocks.
I guess for now, you can do all this in your filesystem
could use
mappedtodisk, but this means in ->commit_write() we'd need to check that one
more time (first time in ->prepare_write())
Yep. We need one more to indicate the we reserved a block for this page.
Other option I was thinking on how to avoid is, by "reserving" a block
when
On Tue, 2005-04-19 at 08:04, Alex Tomas wrote:
> >>>>> Badari Pulavarty (BP) writes:
>
> >> you can introduce one more bit to page->flags
>
> BP> Agreed. I was hoping to avoid it as much as I can.
>
> well, you're gonna modify mpage api an
On Tue, 2005-04-19 at 03:10, Alex Tomas wrote:
> >>>>> Badari Pulavarty (BP) writes:
>
> BP> In order to do the correct accounting, we need to mark a page
> BP> to indicate if we reserved a block or not. One way to do this,
> BP> to use page->private t
On Tue, 2005-04-19 at 04:22, Nikita Danilov wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> writes:
>
> [...]
>
> >
> > Yes. Its possible to do what you want to. I am currently working on
> > adding "delayed allocation" support to ext3. As part of
quirements ? I am looking for a common
way to combine all the requirements and come out with a
saner "generic" routines to handle these.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
I think adding support to JBD to deal with "bio"s would be
a valuable generic extention. Anyway its dealing with "bh"s
now.
Thanks,
Badari
Suparna Bhattacharya wrote:
What would be really nice is if we could do this in a way that
enables reuse of generic paths even for order
e effort.
Isn't it ?
So, may be we should look at adding multiblock allocation +
delayed allocation to current ext3 layout. Then we can evaluate
the benifits of having "extents" etc and then break the layout ?
One more thing, we need to keep in mind is - we need to make sure
that &quo
quot;confused" case. Depending on
how folks view this, I would add support to handle infinite
recursion (for "confused" case).
Andrew, what do you think ?
Thanks,
Badari
diff -Narup -X dontdiff linux-2.6.10/fs/buffer.c linux-2.6.10.nobh/fs/buffer.c
--- linux-2.6.10/fs/buffer.c 2
On Wed, 2005-02-16 at 11:43, Dave Kleikamp wrote:
> On Wed, 2005-02-16 at 11:28 -0800, Badari Pulavarty wrote:
> > On Wed, 2005-02-16 at 11:09, Dave Kleikamp wrote:
> > > On Wed, 2005-02-16 at 10:37 -0800, Badari Pulavarty wrote:
> > >
> > > > Yes. page
On Wed, 2005-02-16 at 11:09, Dave Kleikamp wrote:
> On Wed, 2005-02-16 at 10:37 -0800, Badari Pulavarty wrote:
>
> > Yes. page->private is assumed for the bufferhead usage. Do you really
> > need for handling page->private for non-bufferhead usage ?
>
> For what i
On Wed, 2005-02-16 at 03:41, Nikita Danilov wrote:
> Badari Pulavarty writes:
> > On Tue, 2005-02-15 at 09:54, Andrew Morton wrote:
> > > Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> > > >
> > > > Yep. nobh_prepare_write() do
On Tue, 2005-02-15 at 09:54, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Yep. nobh_prepare_write() doesn't add any bufferheads. But
> > we call block_write_full_page() even for "nobh" case, which
> > does creat
On Tue, 2005-02-15 at 11:07, Nikita Danilov wrote:
> Andrew Morton <[EMAIL PROTECTED]> writes:
>
> > Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >>
> >> Yep. nobh_prepare_write() doesn't add any bufferheads. But
> >> we call block_w
On Tue, 2005-02-15 at 09:54, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Yep. nobh_prepare_write() doesn't add any bufferheads. But
> > we call block_write_full_page() even for "nobh" case, which
> > does creat
On Mon, 2005-02-14 at 19:05, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Is there anything wrong, if we tear down bufferheads after the
> > writepage/writepages is complete ? may be "-nobh" option for ext3 ?
>
> The I/O
On Mon, 2005-02-14 at 18:57, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Most of DB2 customers use filesystem for their database. Under the load,
> > they complain that entire memory in the system is used by filesystem
> > page
On Mon, 2005-02-14 at 13:40, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > I see that as part of bufferheads to page association, we get a
> > ref. on the page.
> >
> >create_empty_buffers() -> attach_page_buffers() -&g
b 7 05:35:29 nmcopsu41 kernel: Out of Memory: Killed process 18873
(db2sysc).
total used free shared buffers cached
Mem: 16304560 16284152 20408 0 228428 15093736
-/+ buffers/cache: 961988 15342572
Swap: 35655616 24448 35631168
Total: 51960176 16308600 35651576
Thanks,
Badari
-
To unsu
erheads even after fsync() is normal.
Correct ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
e,
IO scheduler does less work.
Thanks,
Badari
On Mon, 2005-02-14 at 08:50, Thiago Rondon wrote:
> Can you explain more what do you wrote ?
>
> Thanks in advanced!
> -Thiago Rondon
>
>
> On Thu, 10 Feb 2005 17:48:55 -0800 (PST), Badari Pulavarty
> <[EMAIL PROTECTED]&
On Sat, 2005-02-12 at 15:29, Alex Tomas wrote:
> >>>>> Badari Pulavarty (BP) writes:
>
> >> UP, after:
> >> [EMAIL PROTECTED] root]# time /work/tests/fwrite /test/fff 64 1
> >> real0m21.452s user0m0.026s sys 0m6.105s
> >&g
Alex Tomas wrote:
Badari Pulavarty (BP) writes:
BP> Test: writes 10,000 blocks of 64k and does fdatasync().
The patch doesn't apply ;) after a minor correction
I've tested the patch too:
...
UP, after:
[EMAIL PROTECTED] root]# time /work/tests/fwrite /test/fff 64 1
real0
Alex Tomas wrote:
Badari Pulavarty (BP) writes:
BP> Test: writes 10,000 blocks of 64k and does fdatasync().
The patch doesn't apply ;) after a minor correction
I've tested the patch too:
SMP, before:
[EMAIL PROTECTED] root]# time /work/tests/fwrite /test/fff 64 1
real0
On Fri, 2005-02-11 at 17:00, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > BEFORE: (without writepages support)
> >
> >
> >
On Fri, 2005-02-11 at 15:58, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Due to lack of interesting suggestions to solve
> > mpage_writepages() -> ext3_writeback_writepage() problem,
> > I fixed it in the dumbest possible way.
&
Hi Andrew,
Due to lack of interesting suggestions to solve
mpage_writepages() -> ext3_writeback_writepage() problem,
I fixed it in the dumbest possible way.
Please don't kill me :)
Let me know, what you think.
Thanks,
Badari
diff -Naurp linux-2.6.10/include/linux/fs.h linux-2.
On Fri, 2005-02-11 at 15:58, Andrew Morton wrote:
> Badari Pulavarty <[EMAIL PROTECTED]> wrote:
> >
> > Due to lack of interesting suggestions to solve
> > mpage_writepages() -> ext3_writeback_writepage() problem,
> > I fixed it in the dumbest possible way.
&
Andrew Morton wrote:
Badari Pulavarty <[EMAIL PROTECTED]> wrote:
Here is my first cut at adding writepages() support for
ext3 writeback mode.
Looks sane from a brief scan.
Well, not really..
mpage_writepages() could end up calling ext3_writeback_writepage()
in "confused" case thro
Hi,
Here is my first cut at adding writepages() support for
ext3 writeback mode.
I have not done any performance analysis on the patch,
so try it at your own risk.
Please let me know, if I am completely off or its a
stupid idea.
Thanks,
Badari
--- linux-2.6.10.org/fs/ext3/inode.c2004-12
amp;& (index <= end) &&
(nr_pages = pagevec_lookup_tag(&pvec, mapping,
&index,
PAGECACHE_TAG_DIRTY,
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1)))
...
Thanks,
Badari
-
To unsubscribe from this list: send the line "
)
what am i missing ?
Thanks,
Badari
On Thu, 2005-02-10 at 09:39, Badari Pulavarty wrote:
> On Wed, 2005-02-09 at 08:37, Stephen C. Tweedie wrote:
> > Hi,
> >
> > On Wed, 2005-02-09 at 16:18, Badari Pulavarty wrote:
> >
> > > I am trying to understan
cks we get and the processing we need to
do.
I don't think we have enough numbers here to get to bottom of this.
CPU utilization remains same in both cases, doesn't mean that - the
test took exactly same amount of time. I don't even think that we
are doing a fixed number of IOs. Its p
On Wed, 2005-02-09 at 08:37, Stephen C. Tweedie wrote:
> Hi,
>
> On Wed, 2005-02-09 at 16:18, Badari Pulavarty wrote:
>
> > I am trying to understand journaling code in ext3.
> > Can some one enlighten me, why we need journal start
> > and stop in ext3_wri
making the elevator merge all the peices together. Thats
one reason why 2.6 DIO/RAW code is completely written from
scratch to submit the biggest possible IO chunks.
Well, I agree that we should have theory behind the results.
We are just playing with prototypes for now.
Thanks,
Badari
-
To
at a time.
First fix writepages() without bufferhead changes ? Then handle
bufferheads ? I still can't figure out a way to workaround the
bufferheads especially for ordered writes.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2005-02-09 at 08:37, Stephen C. Tweedie wrote:
> Hi,
>
> On Wed, 2005-02-09 at 16:18, Badari Pulavarty wrote:
>
> > I am trying to understand journaling code in ext3.
> > Can some one enlighten me, why we need journal start
> > and stop in ext3_wri
flushing metadata anyway ?
Whats getting written to journal ?
Thanks,
Badari
static int ext3_writeback_writepage(struct page *page,
struct writeback_control *wbc)
{
...
handle = ext3_journal_start(inode,
ext3_writepage_trans_blocks
heads
attached.
And also, are you sure you don't need to journal start/stop
in writepages() ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ge() seems to be creating
buffer heads, where as mpage_writepages() can do directly
bios. Shouldn't they be using mpage_writepage() instead of
block_full_write_page() ?
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message
On Wed, 2005-02-02 at 12:19, Sonny Rao wrote:
> On Wed, Feb 02, 2005 at 07:32:04AM -0800, Badari Pulavarty wrote:
> > Hi,
> >
> > I forgot the reason why we don't have ext3_writepages() ?
> > I can dig through to find out, but it would be easy to ask
> &g
Hi,
I forgot the reason why we don't have ext3_writepages() ?
I can dig through to find out, but it would be easy to ask
people.
Please let me know.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL
87 matches
Mail list logo
