Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-12-01 Thread Lars Ellenberg
On Mon, Nov 28, 2011 at 03:57:19PM +0100, Ulrich Windl wrote: > >>> Florian Haas schrieb am 28.11.2011 um 15:05 in > >>> Nachricht > : > > On Mon, Nov 28, 2011 at 2:58 PM, Dejan Muhamedagic > > wrote: > > >> Why? It seems "typeset" is the POSIX thing, while "local" is a BASH-ism. > > >> So >

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Ulrich Windl
>>> Florian Haas schrieb am 28.11.2011 um 15:05 in >>> Nachricht : > On Mon, Nov 28, 2011 at 2:58 PM, Dejan Muhamedagic > wrote: > >> Why? It seems "typeset" is the POSIX thing, while "local" is a BASH-ism. > >> So > what's wrong with local variables? > > > > local is almost certainly not a b

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Ulrich Windl
>>> Dejan Muhamedagic schrieb am 28.11.2011 um 14:53 in Nachricht <2028135344.GB3542@squib>: > Hi, > > On Mon, Nov 28, 2011 at 02:41:42PM +0100, Florian Haas wrote: > > On Mon, Nov 28, 2011 at 8:51 AM, Ulrich Windl > > wrote: > > Florian Haas schrieb am 25.11.2011 um 14:35 > > in

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Ulrich Windl
>>> Florian Haas schrieb am 28.11.2011 um 14:41 in >>> Nachricht : > On Mon, Nov 28, 2011 at 8:51 AM, Ulrich Windl > wrote: > Florian Haas schrieb am 25.11.2011 um 14:35 in > > Nachricht <4ecf99ae.8050...@hastexo.com>: > > > > [...] > >> ... and I just morphed that patch into a git branch.

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Florian Haas
On Mon, Nov 28, 2011 at 2:58 PM, Dejan Muhamedagic wrote: >> Why? It seems "typeset" is the POSIX thing, while "local" is a BASH-ism. So >> what's wrong with local variables? > > local is almost certainly not a bashism. At least I can recall > once changing typeset to local in some RA. IIRC, the

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Dejan Muhamedagic
Hi, On Mon, Nov 28, 2011 at 08:38:11AM +0100, Ulrich Windl wrote: > >>> Lars Ellenberg schrieb am 25.11.2011 um 13:18 > >>> in > Nachricht <2025121816.GB7722@barkeeper1-xen.linbit>: > > On Tue, Nov 22, 2011 at 12:09:51PM +0100, Ulrich Windl wrote: > > > >>> Dejan Muhamedagic schrieb am 21.1

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Dejan Muhamedagic
Hi, On Mon, Nov 28, 2011 at 02:41:42PM +0100, Florian Haas wrote: > On Mon, Nov 28, 2011 at 8:51 AM, Ulrich Windl > wrote: > Florian Haas schrieb am 25.11.2011 um 14:35 in > > Nachricht <4ecf99ae.8050...@hastexo.com>: > > > > [...] > >> ... and I just morphed that patch into a git branch. U

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-28 Thread Florian Haas
On Mon, Nov 28, 2011 at 8:51 AM, Ulrich Windl wrote: Florian Haas schrieb am 25.11.2011 um 14:35 in > Nachricht <4ecf99ae.8050...@hastexo.com>: > > [...] >> ... and I just morphed that patch into a git branch. Ulrich, as much as >> we're all grateful for contributions to resource agents, _pl

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-27 Thread Ulrich Windl
>>> Florian Haas schrieb am 25.11.2011 um 14:35 in Nachricht <4ecf99ae.8050...@hastexo.com>: [...] > ... and I just morphed that patch into a git branch. Ulrich, as much as > we're all grateful for contributions to resource agents, _please_ don't > mix functional modification with "cleanup" such

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-27 Thread Ulrich Windl
>>> Lars Ellenberg schrieb am 25.11.2011 um 13:18 in Nachricht <2025121816.GB7722@barkeeper1-xen.linbit>: > On Tue, Nov 22, 2011 at 12:09:51PM +0100, Ulrich Windl wrote: > > >>> Dejan Muhamedagic schrieb am 21.11.2011 um 16:11 > > >>> in > > Nachricht <2021151134.GB3600@squib>: > > > >

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-25 Thread Florian Haas
On 11/25/11 13:18, Lars Ellenberg wrote: > On Tue, Nov 22, 2011 at 12:09:51PM +0100, Ulrich Windl wrote: > Dejan Muhamedagic schrieb am 21.11.2011 um 16:11 in >> Nachricht <2021151134.GB3600@squib>: >> >> [...] >>> This RA could certainly be improved. Patches welcome! >> >> OK, I tried a l

Re: [Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-25 Thread Lars Ellenberg
On Tue, Nov 22, 2011 at 12:09:51PM +0100, Ulrich Windl wrote: > >>> Dejan Muhamedagic schrieb am 21.11.2011 um 16:11 in > Nachricht <2021151134.GB3600@squib>: > > [...] > > This RA could certainly be improved. Patches welcome! > > OK, I tried a little, removing a lot. IMHO the new version is

[Linux-HA] Antw: Re: ocf_heartbeat:Xinetd: bad status report

2011-11-22 Thread Ulrich Windl
>>> Dejan Muhamedagic schrieb am 21.11.2011 um 16:11 in Nachricht <2021151134.GB3600@squib>: [...] > This RA could certainly be improved. Patches welcome! OK, I tried a little, removing a lot. IMHO the new version is better than the previous one, but scores may vary. Anyway, you'll hate me