Re: [PATCH] libata: cosmetic clean up in ata_eh_reset()

2007-10-25 Thread Jeff Garzik
Tejun Heo wrote: Local variable @action usage in ata_eh_reset() is a bit confusing. It's used only to cache ehc-i.action to test reset masks after clearing it; however, due to the generic name action, it's easy to misinterpret the local variable as containing the selected reset method later.

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-25 Thread Jeff Garzik
Alan Cox wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox [EMAIL PROTECTED] applied to

Re: [git patches] IDE updates (part 2)

2007-10-25 Thread Jeff Garzik
Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@

Re: [PATCH] ahci: ahci: implement workaround for ASUS P5W-DH Deluxe ahci_broken_hardreset(), take #2

2007-10-25 Thread Jeff Garzik
Tejun Heo wrote: P5W-DH Deluxe has ICH9 which doesn't have PMP support but SIMG 4726 hardwired to the second port of AHCI controller at PCI device 1f.2. The 4726 doesn't work as PMP but as a storage processor which can do hardware RAID on downstream ports. When no device is attached to the

Re: [PATCH] libata-core: Be a bit more relaxed about early DMA zero devices

2007-10-25 Thread Jeff Garzik
Alan Cox wrote: I guess Windows didn't care about the command so neither did they Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 3/4] scsi: expose AN support to user space

2007-10-25 Thread Jeff Garzik
. Create a routine which allows scsi devices to send a uevent when media change events occur. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 4/4] libata: expose AN to user space

2007-10-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Kristen Carlson Accardi [EMAIL PROTECTED] If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL

[git patches] libata updates

2007-10-25 Thread Jeff Garzik
pata_icside build for recent libata API changes Alan Cox (1): libata-core: Be a bit more relaxed about early DMA zero devices Jeff Garzik (1): [libata] Create [and use -ed.] internal helper ata_dev_set_feature() Kuan Luo (1): [libata] sata_nv: SWNCQ should not apply to MCP61

Re: [PATCH 0/5]: Resolve MSI vs. INTX_DISABLE quirks, V2.

2007-10-25 Thread Jeff Garzik
which are no longer necessary. Signed-off-by: David S. Miller [EMAIL PROTECTED] [corrected subject line s/4/5/. the actual patches are OK] Acked-by: Jeff Garzik [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED

Re: [PATCH] libata: Deal with ATA8-ACS proposed Trusted/Treacherous Computing features

2007-10-25 Thread Jeff Garzik
Alan Cox wrote: - Make dword_io check the ATA version speaking of dword_io, it would be nice to add 32-bit functions for I/O rather than hand-rolling like pdc_data_xfer_vlb() does. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH #upstream] libata: relocate and fix post-command processing

2007-10-25 Thread Jeff Garzik
Tejun Heo wrote: Some commands need post-processing after successful completion. This was done in ata_scsi_qc_complete() till now but this has the following problems. * Post-command processing gets executed when qc is completed from EH. Some qc's are retried from EH with zero err_mask and

Re: [PATCH #upstream] libata: track SLEEP state and issue SRST to wake it up

2007-10-25 Thread Jeff Garzik
Tejun Heo wrote: ATA devices in SLEEP mode don't respond to any commands. SRST is necessary to wake it up. Till now, when a command is issued to a device in SLEEP mode, the command times out, which makes EH reset the device and retry the command after that, causing a long delay. This patch

What's left in libata-dev.git?

2007-10-25 Thread Jeff Garzik
This is a summary of items and issues that remain outstanding for libata. Whenever a git branch is mentioned, it is referring to a branch at git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git Current push just sent to Linus:

Re: What's left in libata-dev.git?

2007-10-25 Thread Jeff Garzik
Jeff Garzik wrote: Active libata branches: ALLSuperset branch for -mm testing alpmLink power management (2.6.24-rc hopefully) anAsync notify (2.6.24-rc hopefully) for-testingInteresting-but-not-ready stuff masterVanilla linux-2.6.git

Re: [patch 2/4] libata: implement ata_wait_after_reset()

2007-10-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Tejun Heo [EMAIL PROTECTED] On certain device/controller combination, 0xff status is asserted after reset and doesn't get cleared during 150ms post-reset wait. As 0xff status is interpreted as no device (for good reasons), this can lead to misdetection on such

Re: PMP device port link speed issues

2007-10-25 Thread Jeff Garzik
Kalra Ashish-B00888 wrote: While testing the sata_fsl driver with a Sil3726 based PMP, we had a specific configuration where the host port to PMP link speed was 1.5Gbps, while the PMP has configured it's device port(s) link speed to 3Gbps. This configuration causes NCQ hangs on certain Seagate

Re: 2.6.24-rc1, sata_nv: MCP51 is boned with SWNCQ too

2007-10-25 Thread Jeff Garzik
Andrew wrote: Hi, I've noticed a thread reporting that SWNCQ can't be disabled on the sata_nv. Gerhard Dirschl * BUG: sata_nv swncq cannot be disabled and another with a patch switching MCP61 to GENERIC instead of SWNCQ Kuan Luo * [PATCH] ata: sata_nv MCP61 using GENERIC instead

Re: [PATCH 2/3] drivers/ide/pci/sc1200.c: remove pointless hwif lookup loop

2007-10-25 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Thursday 25 October 2007, Jeff Garzik wrote: Store our hwif indices at probe time, in order to eliminate a needless and ugly loop across all hwifs, searching for our pci device. It seems that we can simplify it even further and remove knowledge about hwifs

Re: Questions about SATA hotplug in linux 2.6

2007-10-25 Thread Jeff Garzik
Shane Huang wrote: 1. If users unplug one SATA HDD(no-root partition) or SATA ODD when the system is running, then plug it back to the same SATA port, Should the system and SATA HDD/ODD still work well? Yes. 2. How about users plug the SATA HDD/ODD in a different SATA port? Should it still

Re: [PATCH-RFC] Promise TX4 implement hw-bug workaround

2007-10-28 Thread Jeff Garzik
Alexander Sabourenkov wrote: Alan Cox wrote: I can't think of a way to avoid second pass over scatterlist without duplicating code (ata_qc_prep() and ata_fill_sg() from libata-core.c). This appears to be incomplete: [...] What guarantees you have enough PRD entries to do this without

Re: [PATCH-RFC] Promise SATA300 TX4

2007-10-28 Thread Jeff Garzik
Alexander Sabourenkov wrote: Hmm. sata_promise.c says: * Maintained by: Jeff Garzik [EMAIL PROTECTED] That should be changed :) I wrote the code but Mikael is now the primary maintainer. Meanwhile I'll check the Promise driver(s) to see if there's something about SG table formatting

Re: [PATCH-RFC] Promise TX4 implement hw-bug workaround

2007-10-28 Thread Jeff Garzik
BTW, looking at the Promise code I see cam_con.h: /* for ASIC bug, limit the last element of SG byteCount must 32 Dword */ #define SG_COUNT_ASIC_BUG 32 //#define SG_COUNT_ASIC_BUG 128 and in the code itself /* check PRD table, last element = (32 Dword), fix ASIC bug */

Re: [PATCH-RFC] Promise TX4 implement hw-bug workaround

2007-10-28 Thread Jeff Garzik
Alexander Sabourenkov wrote: Jeff Garzik wrote: BTW, looking at the Promise code I see cam_con.h: /* for ASIC bug, limit the last element of SG byteCount must 32 Dword */ #define SG_COUNT_ASIC_BUG 32 //#define SG_COUNT_ASIC_BUG 128 and in the code itself /* check PRD table

Re: [PATCH #upstream 1/2] libata: relocate forcing PIO0 on reset

2007-10-29 Thread Jeff Garzik
Tejun Heo wrote: Forcing PIO0 on reset was done inside ata_bus_softreset(), which is a bit out of place as it should be applied to all resets - hard, soft and implementation which don't use ata_bus_softreset(). Relocate it such that... * For new EH, it's done in ata_eh_reset() before calling

Re: [RFC/PATCH] libata and bogus LBA48 drives

2007-10-29 Thread Jeff Garzik
Geert Uytterhoeven wrote: Hi Jeff, A colleague noticed recent versions of Ubuntu no longer detect his 80 GB ST380020ACE drive. This drive is special in that it advertises LBA48 support, but has the lba_capacity_2 field set to zero (cfr. http://lkml.org/lkml/2004/3/30/163). Upon closer

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-10-30 Thread Jeff Garzik
jameshsu wrote: Should be in TEXT/PLAIN mode. --- resend Hello, This driver has nothing changed since last time submit. However recently we download 2.6.23.1 kernel and found Acard ATP8620 SATA driver is still not there. Resend this message to submit the same driver

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Some it821x RAID firmwares return 0 for the err return off both devices. A similar issue occurs with the slave returning 0 not 1 if you plug a gigabyte sata ramdisk into a controller that fakes two SATA ports as master/slave on an SFF channel. The patch does the following -

Re: [PATCH 1/3] libata: flush is an IO command

2007-10-30 Thread Jeff Garzik
Tejun Heo wrote: ATA_QCFLAG_IO is used to mark commands which are used to perform regluar IO transfers via block layer. These commands are assumed to be valid and taken more seriously during error handling. Cache flush is used by regular IO path and necessary for data integrity. Mark it with

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: The other IT821x change is a bit ugly, we slightly abuse the cable type hook to fiddle with the identify data for the devices. We could add a new hook for this but as we have only one offender and no more seeming likely it seems better to keep libata-core clean. Please let this

Re: [PATCH] libata: Deal with ATA8-ACS proposed Trusted/Treacherous Computing features

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Historically word 48 in the identify data was used to mean 32bit I/O was supported for VLB IDE etc. ATA8 reassigns this word to the Trusted Computing Group, where it is used for TCG features. This means that an ATA8 TCG drive is going to trigger 32bit I/O on some systems which

Re: [PATCH 2.6.24-rc1 1/2] sata_promise: ASIC PRD table bug workaround, take 2

2007-10-30 Thread Jeff Garzik
Mikael Pettersson wrote: Second-generation Promise SATA controllers have an ASIC bug which can trigger if the last PRD entry is larger than 164 bytes, resulting in intermittent errors and possible data corruption. Work around this by replacing calls to ata_qc_prep() with a private version that

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Some it821x RAID firmwares return 0 for the err return off both devices. A similar issue occurs with the slave returning 0 not 1 if you plug a gigabyte sata ramdisk into a controller that fakes two SATA ports as master/slave on an SFF channel. The patch does the following -

Re: [PATCH] libata: Deal with ATA8-ACS proposed Trusted/Treacherous Computing features

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Historically word 48 in the identify data was used to mean 32bit I/O was supported for VLB IDE etc. ATA8 reassigns this word to the Trusted Computing Group, where it is used for TCG features. This means that an ATA8 TCG drive is going to trigger 32bit I/O on some systems which

Re: [RFC 0/3] [SCSI/libata] libata EH conversion for ipr SAS

2007-10-30 Thread Jeff Garzik
Brian King wrote: The following three patches convert ipr to use the new libata EH APIs. In the process of doing this, I first looked into implementing this in a similar manner to how libata SAS is done today, which is hooking into target_alloc/target_destroy to allocate/delete sata ports. While

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-30 Thread Jeff Garzik
Daniel Drake wrote: Hi Alan, In 2.6.23 and previous, CD writing works fine on my system. I'm using ata_piix on: 00:1f.2 IDE interface: Intel Corporation 82801GBM/GHM (ICH7 Family) SATA IDE Controller (rev 01) When I'm running CD writing utilities, I sometimes see this message in the

[git patches] libata fixes

2007-10-30 Thread Jeff Garzik
/sata_promise.c @@ -2,6 +2,7 @@ * sata_promise.c - Promise SATA * * Maintained by: Jeff Garzik [EMAIL PROTECTED] + * Mikael Pettersson [EMAIL PROTECTED] * Please ALWAYS copy linux-ide@vger.kernel.org * on emails. * @@ -45,11 +46,12 @@ #include

Re: [git patches] libata fixes

2007-10-30 Thread Jeff Garzik
Linus Torvalds wrote: On Tue, 30 Oct 2007, Jeff Garzik wrote: Mikael Pettersson (2): sata_promise: ASIC PRD table bug workaround, take 2 sata_promise: cleanups You and Mikael need to sort out the way you send/accept patches. Both of these commits had stuff like

[PATCH] killing sg_last(), and discussion

2007-10-31 Thread Jeff Garzik
I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe kill one use with caching, but in the other sg_last() callsites there isn't another s/g loop we can stick a last_sg = sg; into. libata is stuck because we undertake the

Re: [git patches] libata fixes

2007-10-31 Thread Jeff Garzik
Mikael Pettersson wrote: That's my fault for misremembering the rule about the number of dashes before the other comments part :-( I'll remember better in the future. Well, I should have caught it and hand-edited it on my side too... Jeff - To unsubscribe from this list: send the

Re: [PATCH] killing sg_last(), and discussion

2007-10-31 Thread Jeff Garzik
Boaz Harrosh wrote: On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe kill one use with caching, but in the other sg_last() callsites

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-31 Thread Jeff Garzik
Jens Axboe wrote: On Wed, Oct 31 2007, Alan Cox wrote: On Tue, 30 Oct 2007 19:21:29 + Daniel Drake [EMAIL PROTECTED] wrote: Alan Cox wrote: I would guess Brasero is issuing a command with the length of data wrongly set. In the old code that might well just produce errors of the Umm wtf

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-31 Thread Jeff Garzik
Jens Axboe wrote: Right, that's of course problematic... There has to be a way to recover that situation though, or you can't export any user command issue facility. You cannot hope to handle all possible effects arising from an app providing an invalid sg header / cdb. Once you start

Re: Other Problems with Marvell Driver - 7042 (2.6.23)...

2007-10-31 Thread Jeff Garzik
Morrison, Tom wrote: I am running the 'latest' kernel retrieved from Kumar Gala's Powerpc git tree (mainly because I am running on a MPC8548 board) and it appears to be in the full 2.6.23 version while the sata_mv driver version seems to be 1.01. I have searched the archives, and there has

[PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
/libata-core.c | 53 + drivers/ata/libata-eh.c | 11 + drivers/ata/libata-scsi.c | 48 +--- drivers/ata/libata.h |7 ++ 4 files changed, 72 insertions(+), 47 deletions(-) Jeff Garzik (1

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-01 Thread Jeff Garzik
Ok, gave this a hard look. This is basically a behavior change with regards to how we program the bcount(low) and bcount(high) registers. Issues about FIFO draining and devices returning too-much data are ultimately tangential. Furthermore, this is an ATAPI PIO issue, as demonstrated by

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
Alan Cox wrote: On Thu, 1 Nov 2007 05:07:33 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: This is purely for comment and testing, not for merging (yet?). A common recipe in several vendor drivers (either GPL'd, or I have NDA'd access to use them as a documentation-like reference) for ATAPI

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-01 Thread Jeff Garzik
Alan Cox wrote: demonstrated by (a) Alan's patch did not change DMA lbam/lbah programming and (b) Daniel's report of the message ata2.00: 66 bytes (a) did. Well the original did, dunno about your version. We are both half-right. I reverted my version of that completely, applied your

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -190,8 +190,7

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644

Re: sata_nv: ata2 errors

2007-11-01 Thread Jeff Garzik
Andrew Morton wrote: On Thu, 25 Oct 2007 13:18:50 +0530 Amit Shah [EMAIL PROTECTED] wrote: On 2.6.24-rc1 (AMD Opteron 1216), my sata_nv driver produces this output on bootup: ata2: EH in SWNCQ mode,QC:qc_active 0x1 sactive 0x1 ata2: SWNCQ:qc_active 0x1 defer_bits 0x0 last_issue_tag 0x0 ata2:

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Jeff Garzik
Torsten Kaiser wrote: On 11/1/07, Jeff Garzik [EMAIL PROTECTED] wrote: + lo = tf-lbam; + hi = tf-lbam; + ibyte = (hi 8) | lo; + + lo = result_tf-lbam; + hi = result_tf-lbam; That doesn't look right. I suspect this was intended: lo = tf-lbam; hi = tf-lbah

Re: [PATCH 1/3] libata: implement dev-acpi_init_gtm

2007-11-02 Thread Jeff Garzik
Tejun Heo wrote: Add dev-acpi_init_gtm and store initial GTM values on host initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag is set. This is to remember BIOS/firmware programmed initial timing for later use before reset and mode configuration modify it. Signed-off-by:

Re: pata_serverworks hangs

2007-11-02 Thread Jeff Garzik
Krzysztof Oledzki wrote: Hello, I just tried to switch from old IDE to libata but unfortunately kernel (2.6.22.10) hangs during boot: does 2.6.23.1 or 2.6.24-rc1 work? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-02 Thread Jeff Garzik
Daniel Drake wrote: Again, ignore me if I'm not contributing anything useful, but I'm increasingly thinking that the SG_IO command block in question is perfectly valid, and doing a short read of the mode page in question (and probably others too) is in fact required before you can know its

Re: [PATCH 1/3] libata: implement dev-acpi_init_gtm

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Add dev-acpi_init_gtm and store initial GTM values on host initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag is set. This is to remember BIOS/firmware programmed initial timing for later use before

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: Does this patch fix the problem? [snip] I hope it does... that patch removes a call to sg_last() and in general cleans up the function a bit, which is nice. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH 01/12] ata/sata_fsl: Update for ata_link introduction

2007-11-03 Thread Jeff Garzik
Li Yang wrote: Update the driver to use the newly added ata_link structure. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/ata/sata_fsl.c | 31 ++- 1 files changed, 18 insertions(+), 13 deletions(-) applied patches 1-12 to #upstream-fixes (2.6.24), thanks

Re: [PATCH] libata: suppress two warnings

2007-11-03 Thread Jeff Garzik
Stephen Rothwell wrote: drivers/ata/libata-core.c:768: warning: 'ata_lpm_enable' defined but not used drivers/ata/libata-core.c:784: warning: 'ata_lpm_disable' defined but not used Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/ata/libata-core.c |4 1 files changed, 4

Re: [2.6 patch] make ata_scsi_lpm_get() static

2007-11-03 Thread Jeff Garzik
Adrian Bunk wrote: ata_scsi_lpm_get() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 380046f657271be470566bb5c762c1599569bac6 diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 93bd36c..c4f0c6c 100644 --- a/drivers/ata/libata-scsi.c +++

Re: [PATCH 2.6.24-rc1] sata_promise: fix endianess bug in ASIC PRD bug workaround

2007-11-03 Thread Jeff Garzik
Mikael Pettersson wrote: The original workaround for the Promise ASIC PRD bug contained an endianess bug which I failed to detect: the adjustment of the last PRD entry's length field applied host arithmetic to little-endian data, which is incorrect on big-endian machines. We have the length

Re: [PATCH] libata: increase 128 KB / cmd limit for ATAPI tape drives

2007-11-03 Thread Jeff Garzik
Tony Battersby wrote: Commands sent to ATAPI tape drives via the SCSI generic (sg) driver are limited in the amount of data that they can transfer by the max_sectors value. The max_sectors value is currently calculated according to the command set for disk drives, which doesn't apply to tape

Re: [PATCH 1/6] libata: fix timing computation in ata_eh_reset()

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: As jiffies changes asynchronously, it needs to be cached if unchanging timestamp is needed. The code in ata_eh_reset() intended to do that with @now but never actually did it. Fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c |2 +- 1 files

Re: Bart's efforts?

2007-11-03 Thread Jeff Garzik
Greg Freemyer wrote: Jeff / Alan, I mostly lurk here, but I know there is a long term effort/ToDo to move libata away from the SCSI infrastructure. I've also seen that Bart has been making a large number of improvements to drivers/ide over the last little while. From my limited perspective,

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-03 Thread Jeff Garzik
Shaohua Li wrote: Not sure, this is just to call a BIOS routine, but a check should be safer. Thanks! ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't

[git patches] libata fixes

2007-11-03 Thread Jeff Garzik
ata_scsi_lpm_get() static Jeff Garzik (4): ata/sata_fsl: Remove unnecessary SCR cases ata/sata_fsl: cleanup needless casts to/from void __iomem * ata/sata_fsl: remove unneeded on-stack copy of FIS ata/sata_fsl: remove unneeded sata_fsl_hardreset() Li Yang (5): ata/sata_fsl

[git patches] Add and use media change notification

2007-11-04 Thread Jeff Garzik
drivers/scsi/scsi_scan.c |3 + drivers/scsi/scsi_sysfs.c | 47 +++ include/scsi/scsi_device.h | 25 5 files changed, 216 insertions(+), 3 deletions(-) commit f26792d5c63344e14540ced4b19deb29e360bb8d Author: Jeff Garzik [EMAIL PROTECTED] Date: Mon Oct 29 17

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where

Re: [git patches] Add and use media change notification

2007-11-05 Thread Jeff Garzik
Linus Torvalds wrote: On Sun, 4 Nov 2007, Jeff Garzik wrote: The end to CD-ROM polling... newer SATA ATAPI hardware will emit 'asynchronous notification' events when media is changed. This adds support. I *really* didn't want to pull this. Not only is it after the -rc1 period, but I also

[git patches] libata fixes

2007-11-05 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |1 + drivers/ata/libata-core.c | 39 ---

Re: [PATCH 05/12] libata: xfer_mask is unsigned int not unsigned long

2007-11-06 Thread Jeff Garzik
Tejun Heo wrote: Alan Cox wrote: On Tue, 6 Nov 2007 14:39:03 +0900 Tejun Heo [EMAIL PROTECTED] wrote: xfer_mask is unsigned int not unsigned long. Change -mode_filter to take and return unsigned int. While at it, rename @adev of ata_pci_default_filter() to @dev for consistency.

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: Hi Jeff, Please help Acard to add this chip spec on the web site in your earlier conveniance. http://gkernel.sourceforge.net/specs/ http://linux-ata.org/driver-status.html#open_chipsets Updated, thanks much! By the way, once you

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 05:13:55PM -0500, Jeff Garzik wrote: On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: Please help Acard to add this chip spec on the web site in your earlier conveniance. http://gkernel.sourceforge.net/specs/ BTW, I put the doc in http

[PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: By the way, once you complete the SATA sample driver , please inform us , so we could modify, test and submit in the near future. If any chip info still missing or need us to involve, please let me know. Any chance the patch below

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 02:12:55PM -0500, Mark Lord wrote: That cannot be correct (??). Is this with hdparm-7.7 (latest sourceforge) ?? Can you show us the hdparm --Istdout output as well, please. If this is applicable... FWIW hdparm was only recently (in past 72 hours) updated from 6.9 to

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 10:54:15AM -0500, Mark Lord wrote: sata_qstor conversion to new error handling (EH). Convert sata_qstor to use the newer libata EH mechanisms. Based on earlier work by Jeff Garzik. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] Did you test

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 06:36:13PM -0500, Mark Lord wrote: Mark Lord wrote: .. and SG_IO WRITEs don't work. That's really no different from the existing 2.6.24 version. Regular I/O looks fine. ... I should qualify that: SG_IO *PIO* WRITEs don't work. SG_IO PIO READs do work, and SG_IO

Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 07:28:38PM +0800, jameshsu wrote: Not really understand your patch listed below. We do not provide ahci.c file to you, so we don't know where the patch came from(diff from where)?? Who create this and how can we get ahci.c file?? Can you tell us?? The file is found

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 07:34:22PM +0800, jameshsu wrote: From: LaurenceWu We didn't study about ata/ahci.c, but it should be based on AHCI1.0 or 1.1 spec. That is, NO P.M. FIS base switching, but supports both non-NCQ and NCQ protocols. For NCQ or nonNCQ, 8620 is very AHCI-like, although

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 06:44:31PM +0200, Denys Fedoryshchenko wrote: Doesn't help WRAP ~ #cat /proc/cmdline console=ttyS0,38400n8 libata.dma_mask=3 It's libata.dma if its built into the kernel, or 'dma' module option if built as a kernel module. Jeff - To unsubscribe from this

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Andrew Morton wrote, On 11/07/2007 09:13 PM: On Wed, 07 Nov 2007 15:15:07 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Hello. I

Re: [PATCH] ata_piix: add SATELLITE PRO U200 to broken suspend list

2007-11-08 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 12:02:27PM +0900, Tejun Heo wrote: From: Yann Chachkoff [EMAIL PROTECTED] Please warmly welcome the PRO variant of Satellite U200 to the broken suspend list. Original patch is from Yann Chachkoff. Patch reformatted and forwarded by Tejun Heo. Signed-off-by:

Re: [PATCH 2/4] libata sata_qstor nuke idle state

2007-11-08 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 10:52:55AM -0500, Mark Lord wrote: sata_qstor nuke idle state. We're really only ever in one of two hardware states: packet, or mmio. Get rid of unnecessary qs_state_idle state. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] applied patches

Re: [PATCH 1/2 take #2] libata: Support PIO polling-only hosts.

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:14:56AM +0900, Paul Mundt wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation (either in

Re: [PATCH #upstream-fixes] libata: skip 0xff polling for PATA controllers

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:20:18AM +0900, Tejun Heo wrote: In a presentation of true workmanship, pata_ali asserts IRQ permanantly if the TF status register is read more than once when there's no device attached to the port. Avoid waiting polling for !0xff if it's PATA. It's needed only for

Re: [PATCH #upstream-fixes] libata: port and host should be stopped before hardware resources are released

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 01:09:00PM +0900, Tejun Heo wrote: Port / host stop calls used to be made from ata_host_release() which is called after all hardware resources acquired after host allocation are released. This is wrong as port and host stop routines often access the hardware. Add

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote: Jeff Garzik wrote: .. 2) This chip includes target mode support. Very nice, well done! I hope that standard AHCI eventually supports this nice feature

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote: Jeff Garzik wrote: .. 2) This chip includes target mode support. Very nice, well done! I hope that standard AHCI eventually supports this nice feature! .. Speaking of which. Do we have a strategy as to how to implement/support

Re: SATA Target mode libata

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 03:49:17PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote: .. MMmm.. I wonder what the most common use case is for target mode? Everybody I've dealt with thus far uses it as a high-speed local comms interface

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Fri, Nov 09, 2007 at 09:02:35AM +0700, Riki Oktarianto wrote: Some BIOSen map AHCI ABAR but lock the SATA controller to IDE mode. This patch add quirk to set AHCI mode on ICH board with such case. Tested on Macbook2,1 (ICH7M) Intel will complain but it's awful tempting... Jeff

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case is the main reason why AHCI was not unconditionally enabled, even in IDE mode, when

Re: FIS structure and Command List structure for AHCI SATA controller

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:38:25PM -0500, mike zheng wrote: I am working on an AHCI SATA controller. For each port, there is one FIS descriptor and one Command List, which points to a Received FIS structure and Command List structure. So what is Received FIS structure? The Command List

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:44:22PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Jeff Garzik
Alan Cox wrote: On Thu, 8 Nov 2007 22:46:22 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Jeff Garzik
Matthias Schniedermeyer wrote: And on the topic of broken BIOSes. I have a little empathy for the MB manufactures as non-RAID AHCI royaly screws Windos, so not supporting it reduces their support costs enough to overlook screwing the non-windos faction. non-RAID AHCI works just fine on

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-11-09 Thread Jeff Garzik
Jeff Garzik wrote: The proposed sata_nv patch does the opposite -- guarantees we must support the continually problematic legacy IDE interface ad infinitum. Such patches are OK for the test lab, but in this specific case users /suffer/ when not running AHCI mode. Just to reinforce

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Jeff Garzik
Allen Martin wrote: At least for NVIDIA controllers, loading the AHCI driver when the BIOS is set to IDE mode is not recommended by NVIDIA. Any AHCI workarounds in the BIOS are likely to be disabled when set to IDE mode. In practice What workarounds, if any, are needed? We need those in the

linux-ata.org contributions

2007-11-10 Thread Jeff Garzik
(cc'd to main potential content contributors) What do you guys think about a git tree for linux-ata.org web pages, rather than a wiki? A git tree would be my preference. Whenever you want to update or add a page, just send a 'git pull' request to me... As I noted to Tejun in IRC, the main

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Jeff Garzik
Alan Cox wrote: ata9.00: qc timeout (cmd 0xa0) ata9.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata9.00: cmd a0/00:00:00:02:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 2 in res 51/54:03:00:02:00/00:00:00:00:00/a0 Emask 0x5 (timeout) ata9.00: status: { DRDY ERR } Could be

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Jeff Garzik
Will Trives wrote: Hello, Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1) Chipset: Intel P35 + ICH9R PATA port runs off JMicron controller CD/DVD Device: BENQ DW1640 16X I cannot access my dvd burner under 2.6.24-rc2, I have no problems under 2.6.23. Basically the drive is detected OK,

<    8   9   10   11   12   13   14   15   16   >