Tejun Heo wrote:
Local variable @action usage in ata_eh_reset() is a bit confusing.
It's used only to cache ehc-i.action to test reset masks after
clearing it; however, due to the generic name action, it's easy to
misinterpret the local variable as containing the selected reset
method later.
Alan Cox wrote:
Some hardware seems to get this wrong in a non-harmful way, and there are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied to
Al Viro wrote:
Proposed addition to icside part, provided that ARM folks ACK it - gets
icside to build and AFAICS it's correct:
diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c
index be30923..842fe08 100644
--- a/drivers/ata/pata_icside.c
+++ b/drivers/ata/pata_icside.c
@@
Tejun Heo wrote:
P5W-DH Deluxe has ICH9 which doesn't have PMP support but SIMG 4726
hardwired to the second port of AHCI controller at PCI device 1f.2.
The 4726 doesn't work as PMP but as a storage processor which can do
hardware RAID on downstream ports.
When no device is attached to the
Alan Cox wrote:
I guess Windows didn't care about the command so neither did they
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
. Create a routine which allows scsi devices to send a uevent when
media change events occur.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Cc: James Bottomley [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL
[EMAIL PROTECTED] wrote:
From: Kristen Carlson Accardi [EMAIL PROTECTED]
If Asynchronous Notification of media change events is supported, pass that
information up to the SCSI layer.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL
pata_icside build for recent libata API changes
Alan Cox (1):
libata-core: Be a bit more relaxed about early DMA zero devices
Jeff Garzik (1):
[libata] Create [and use -ed.] internal helper ata_dev_set_feature()
Kuan Luo (1):
[libata] sata_nv: SWNCQ should not apply to MCP61
which are no longer necessary.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
[corrected subject line s/4/5/. the actual patches are OK]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED
Alan Cox wrote:
- Make dword_io check the ATA version
speaking of dword_io, it would be nice to add 32-bit functions for I/O
rather than hand-rolling like pdc_data_xfer_vlb() does.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
Tejun Heo wrote:
Some commands need post-processing after successful completion. This
was done in ata_scsi_qc_complete() till now but this has the following
problems.
* Post-command processing gets executed when qc is completed from EH.
Some qc's are retried from EH with zero err_mask and
Tejun Heo wrote:
ATA devices in SLEEP mode don't respond to any commands. SRST is
necessary to wake it up. Till now, when a command is issued to a
device in SLEEP mode, the command times out, which makes EH reset the
device and retry the command after that, causing a long delay.
This patch
This is a summary of items and issues that remain outstanding for
libata. Whenever a git branch is mentioned, it is referring to a branch
at git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Current push just sent to Linus:
Jeff Garzik wrote:
Active libata branches:
ALLSuperset branch for -mm testing
alpmLink power management (2.6.24-rc hopefully)
anAsync notify (2.6.24-rc hopefully)
for-testingInteresting-but-not-ready stuff
masterVanilla linux-2.6.git
[EMAIL PROTECTED] wrote:
From: Tejun Heo [EMAIL PROTECTED]
On certain device/controller combination, 0xff status is asserted
after reset and doesn't get cleared during 150ms post-reset wait. As
0xff status is interpreted as no device (for good reasons), this can
lead to misdetection on such
Kalra Ashish-B00888 wrote:
While testing the sata_fsl driver with a Sil3726 based PMP, we had a
specific configuration where the host port to PMP link speed was
1.5Gbps, while the PMP has configured it's device port(s) link speed to
3Gbps. This configuration causes NCQ hangs on certain Seagate
Andrew wrote:
Hi,
I've noticed a thread reporting that SWNCQ can't be disabled
on the sata_nv.
Gerhard Dirschl
* BUG: sata_nv swncq cannot be disabled
and another with a patch switching MCP61 to GENERIC instead
of SWNCQ
Kuan Luo
* [PATCH] ata: sata_nv MCP61 using GENERIC instead
Bartlomiej Zolnierkiewicz wrote:
On Thursday 25 October 2007, Jeff Garzik wrote:
Store our hwif indices at probe time, in order to eliminate a needless
and ugly loop across all hwifs, searching for our pci device.
It seems that we can simplify it even further and remove knowledge about
hwifs
Shane Huang wrote:
1. If users unplug one SATA HDD(no-root partition) or SATA ODD when
the system is running, then plug it back to the same SATA port,
Should the system and SATA HDD/ODD still work well?
Yes.
2. How about users plug the SATA HDD/ODD in a different SATA port?
Should it still
Alexander Sabourenkov wrote:
Alan Cox wrote:
I can't think of a way to avoid second pass over scatterlist without
duplicating code (ata_qc_prep() and ata_fill_sg() from libata-core.c).
This appears to be incomplete:
[...]
What guarantees you have enough PRD entries to do this without
Alexander Sabourenkov wrote:
Hmm. sata_promise.c says:
* Maintained by: Jeff Garzik [EMAIL PROTECTED]
That should be changed :) I wrote the code but Mikael is now the
primary maintainer.
Meanwhile I'll check the Promise driver(s) to see if there's
something about SG table formatting
BTW, looking at the Promise code I see
cam_con.h:
/* for ASIC bug, limit the last element of SG byteCount must 32 Dword */
#define SG_COUNT_ASIC_BUG 32
//#define SG_COUNT_ASIC_BUG 128
and in the code itself
/* check PRD table, last element = (32 Dword), fix ASIC bug */
Alexander Sabourenkov wrote:
Jeff Garzik wrote:
BTW, looking at the Promise code I see
cam_con.h:
/* for ASIC bug, limit the last element of SG byteCount must 32
Dword */
#define SG_COUNT_ASIC_BUG 32
//#define SG_COUNT_ASIC_BUG 128
and in the code itself
/* check PRD table
Tejun Heo wrote:
Forcing PIO0 on reset was done inside ata_bus_softreset(), which is a
bit out of place as it should be applied to all resets - hard, soft
and implementation which don't use ata_bus_softreset(). Relocate it
such that...
* For new EH, it's done in ata_eh_reset() before calling
Geert Uytterhoeven wrote:
Hi Jeff,
A colleague noticed recent versions of Ubuntu no longer detect his 80 GB
ST380020ACE drive. This drive is special in that it advertises LBA48 support,
but has the lba_capacity_2 field set to zero (cfr.
http://lkml.org/lkml/2004/3/30/163).
Upon closer
jameshsu wrote:
Should be in TEXT/PLAIN mode. --- resend
Hello,
This driver has nothing changed since last time submit.
However recently we download 2.6.23.1 kernel and found Acard ATP8620 SATA
driver is still not there.
Resend this message to submit the same driver
Alan Cox wrote:
Some it821x RAID firmwares return 0 for the err return off both devices.
A similar issue occurs with the slave returning 0 not 1 if you plug a
gigabyte sata ramdisk into a controller that fakes two SATA ports as
master/slave on an SFF channel.
The patch does the following
-
Tejun Heo wrote:
ATA_QCFLAG_IO is used to mark commands which are used to perform
regluar IO transfers via block layer. These commands are assumed to
be valid and taken more seriously during error handling. Cache flush
is used by regular IO path and necessary for data integrity. Mark it
with
Alan Cox wrote:
The other IT821x change is a bit ugly, we slightly abuse the cable type
hook to fiddle with the identify data for the devices. We could add a new
hook for this but as we have only one offender and no more seeming likely
it seems better to keep libata-core clean.
Please let this
Alan Cox wrote:
Historically word 48 in the identify data was used to mean 32bit I/O was
supported for VLB IDE etc. ATA8 reassigns this word to the Trusted
Computing Group, where it is used for TCG features. This means that an
ATA8 TCG drive is going to trigger 32bit I/O on some systems which
Mikael Pettersson wrote:
Second-generation Promise SATA controllers have an ASIC bug
which can trigger if the last PRD entry is larger than 164 bytes,
resulting in intermittent errors and possible data corruption.
Work around this by replacing calls to ata_qc_prep() with a
private version that
Alan Cox wrote:
Some it821x RAID firmwares return 0 for the err return off both devices.
A similar issue occurs with the slave returning 0 not 1 if you plug a
gigabyte sata ramdisk into a controller that fakes two SATA ports as
master/slave on an SFF channel.
The patch does the following
-
Alan Cox wrote:
Historically word 48 in the identify data was used to mean 32bit I/O was
supported for VLB IDE etc. ATA8 reassigns this word to the Trusted
Computing Group, where it is used for TCG features. This means that an
ATA8 TCG drive is going to trigger 32bit I/O on some systems which
Brian King wrote:
The following three patches convert ipr to use the new libata EH APIs.
In the process of doing this, I first looked into implementing this
in a similar manner to how libata SAS is done today, which is hooking
into target_alloc/target_destroy to allocate/delete sata ports. While
Daniel Drake wrote:
Hi Alan,
In 2.6.23 and previous, CD writing works fine on my system. I'm using
ata_piix on:
00:1f.2 IDE interface: Intel Corporation 82801GBM/GHM (ICH7 Family) SATA
IDE Controller (rev 01)
When I'm running CD writing utilities, I sometimes see this message in
the
/sata_promise.c
@@ -2,6 +2,7 @@
* sata_promise.c - Promise SATA
*
* Maintained by: Jeff Garzik [EMAIL PROTECTED]
+ * Mikael Pettersson [EMAIL PROTECTED]
* Please ALWAYS copy linux-ide@vger.kernel.org
* on emails.
*
@@ -45,11 +46,12 @@
#include
Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Mikael Pettersson (2):
sata_promise: ASIC PRD table bug workaround, take 2
sata_promise: cleanups
You and Mikael need to sort out the way you send/accept patches.
Both of these commits had stuff like
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe kill one use with caching, but in the other sg_last()
callsites there isn't another s/g loop we can stick a last_sg = sg;
into.
libata is stuck because we undertake the
Mikael Pettersson wrote:
That's my fault for misremembering the rule about the
number of dashes before the other comments part :-(
I'll remember better in the future.
Well, I should have caught it and hand-edited it on my side too...
Jeff
-
To unsubscribe from this list: send the
Boaz Harrosh wrote:
On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe kill one use with caching, but in the other sg_last()
callsites
Jens Axboe wrote:
On Wed, Oct 31 2007, Alan Cox wrote:
On Tue, 30 Oct 2007 19:21:29 +
Daniel Drake [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I would guess Brasero is issuing a command with the length of data
wrongly set. In the old code that might well just produce errors of the
Umm wtf
Jens Axboe wrote:
Right, that's of course problematic... There has to be a way to recover
that situation though, or you can't export any user command issue
facility.
You cannot hope to handle all possible effects arising from an app
providing an invalid sg header / cdb.
Once you start
Morrison, Tom wrote:
I am running the 'latest' kernel retrieved from Kumar Gala's
Powerpc git tree (mainly because I am running on a MPC8548 board)
and it appears to be in the full 2.6.23 version while the sata_mv
driver version seems to be 1.01.
I have searched the archives, and there has
/libata-core.c | 53 +
drivers/ata/libata-eh.c | 11 +
drivers/ata/libata-scsi.c | 48 +---
drivers/ata/libata.h |7 ++
4 files changed, 72 insertions(+), 47 deletions(-)
Jeff Garzik (1
Ok, gave this a hard look.
This is basically a behavior change with regards to how we program the
bcount(low) and bcount(high) registers.
Issues about FIFO draining and devices returning too-much data are
ultimately tangential. Furthermore, this is an ATAPI PIO issue, as
demonstrated by
Alan Cox wrote:
On Thu, 1 Nov 2007 05:07:33 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
This is purely for comment and testing, not for merging (yet?).
A common recipe in several vendor drivers (either GPL'd, or I have NDA'd
access to use them as a documentation-like reference) for ATAPI
Alan Cox wrote:
demonstrated by (a) Alan's patch did not change DMA lbam/lbah
programming and (b) Daniel's report of the message ata2.00: 66 bytes
(a) did. Well the original did, dunno about your version.
We are both half-right. I reverted my version of that completely,
applied your
Jens Axboe wrote:
Reverting just the default AHCI flags makes it work again. IOW, with the
below patch I can suspend properly with current -git.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ed9b407..77f7631 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -190,8 +190,7
Jens Axboe wrote:
On Thu, Nov 01 2007, Jeff Garzik wrote:
Jens Axboe wrote:
Reverting just the default AHCI flags makes it work again. IOW, with the
below patch I can suspend properly with current -git.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ed9b407..77f7631 100644
Andrew Morton wrote:
On Thu, 25 Oct 2007 13:18:50 +0530
Amit Shah [EMAIL PROTECTED] wrote:
On 2.6.24-rc1 (AMD Opteron 1216), my sata_nv driver produces this
output on bootup:
ata2: EH in SWNCQ mode,QC:qc_active 0x1 sactive 0x1
ata2: SWNCQ:qc_active 0x1 defer_bits 0x0 last_issue_tag 0x0
ata2:
Torsten Kaiser wrote:
On 11/1/07, Jeff Garzik [EMAIL PROTECTED] wrote:
+ lo = tf-lbam;
+ hi = tf-lbam;
+ ibyte = (hi 8) | lo;
+
+ lo = result_tf-lbam;
+ hi = result_tf-lbam;
That doesn't look right.
I suspect this was intended:
lo = tf-lbam;
hi = tf-lbah
Tejun Heo wrote:
Add dev-acpi_init_gtm and store initial GTM values on host
initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag
is set. This is to remember BIOS/firmware programmed initial timing
for later use before reset and mode configuration modify it.
Signed-off-by:
Krzysztof Oledzki wrote:
Hello,
I just tried to switch from old IDE to libata but unfortunately kernel
(2.6.22.10) hangs during boot:
does 2.6.23.1 or 2.6.24-rc1 work?
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
Daniel Drake wrote:
Again, ignore me if I'm not contributing anything useful, but I'm
increasingly thinking that the SG_IO command block in question is
perfectly valid, and doing a short read of the mode page in question
(and probably others too) is in fact required before you can know its
Tejun Heo wrote:
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Add dev-acpi_init_gtm and store initial GTM values on host
initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag
is set. This is to remember BIOS/firmware programmed initial timing
for later use before
Tejun Heo wrote:
Does this patch fix the problem?
[snip]
I hope it does... that patch removes a call to sg_last() and in general
cleans up the function a bit, which is nice.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Li Yang wrote:
Update the driver to use the newly added ata_link structure.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c | 31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)
applied patches 1-12 to #upstream-fixes (2.6.24), thanks
Stephen Rothwell wrote:
drivers/ata/libata-core.c:768: warning: 'ata_lpm_enable' defined but not used
drivers/ata/libata-core.c:784: warning: 'ata_lpm_disable' defined but not used
Signed-off-by: Stephen Rothwell [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |4
1 files changed, 4
Adrian Bunk wrote:
ata_scsi_lpm_get() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
380046f657271be470566bb5c762c1599569bac6
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 93bd36c..c4f0c6c 100644
--- a/drivers/ata/libata-scsi.c
+++
Mikael Pettersson wrote:
The original workaround for the Promise ASIC PRD bug
contained an endianess bug which I failed to detect:
the adjustment of the last PRD entry's length field
applied host arithmetic to little-endian data, which
is incorrect on big-endian machines.
We have the length
Tony Battersby wrote:
Commands sent to ATAPI tape drives via the SCSI generic (sg) driver are
limited in the amount of data that they can transfer by the max_sectors
value. The max_sectors value is currently calculated according to the
command set for disk drives, which doesn't apply to tape
Tejun Heo wrote:
As jiffies changes asynchronously, it needs to be cached if unchanging
timestamp is needed. The code in ata_eh_reset() intended to do that
with @now but never actually did it. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c |2 +-
1 files
Greg Freemyer wrote:
Jeff / Alan,
I mostly lurk here, but I know there is a long term effort/ToDo to
move libata away from the SCSI infrastructure.
I've also seen that Bart has been making a large number of
improvements to drivers/ide over the last little while. From my
limited perspective,
Shaohua Li wrote:
Not sure, this is just to call a BIOS routine, but a check should be
safer. Thanks!
ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
methods. As recently most PATA drivers use libata, this patch adds _PSx
method support in libata. ACPI spec doesn't
ata_scsi_lpm_get() static
Jeff Garzik (4):
ata/sata_fsl: Remove unnecessary SCR cases
ata/sata_fsl: cleanup needless casts to/from void __iomem *
ata/sata_fsl: remove unneeded on-stack copy of FIS
ata/sata_fsl: remove unneeded sata_fsl_hardreset()
Li Yang (5):
ata/sata_fsl
drivers/scsi/scsi_scan.c |3 +
drivers/scsi/scsi_sysfs.c | 47 +++
include/scsi/scsi_device.h | 25
5 files changed, 216 insertions(+), 3 deletions(-)
commit f26792d5c63344e14540ced4b19deb29e360bb8d
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Mon Oct 29 17
Jens Axboe wrote:
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote:
On Thu, 1 Nov 2007 09:41:46 +0100
Jens Axboe [EMAIL PROTECTED] wrote:
On Wed, Oct 31 2007, Jens Axboe wrote:
Hi,
My x60 stopped suspending about two days ago. It just freezes after
printing
Suspending console(s)
where
Linus Torvalds wrote:
On Sun, 4 Nov 2007, Jeff Garzik wrote:
The end to CD-ROM polling... newer SATA ATAPI hardware will emit
'asynchronous notification' events when media is changed. This adds
support.
I *really* didn't want to pull this.
Not only is it after the -rc1 period, but I also
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ata_piix.c |1 +
drivers/ata/libata-core.c | 39 ---
Tejun Heo wrote:
Alan Cox wrote:
On Tue, 6 Nov 2007 14:39:03 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
xfer_mask is unsigned int not unsigned long. Change -mode_filter to
take and return unsigned int.
While at it, rename @adev of ata_pci_default_filter() to @dev for
consistency.
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote:
Hi Jeff,
Please help Acard to add this chip spec on the web site in your earlier
conveniance.
http://gkernel.sourceforge.net/specs/
http://linux-ata.org/driver-status.html#open_chipsets
Updated, thanks much!
By the way, once you
On Wed, Nov 07, 2007 at 05:13:55PM -0500, Jeff Garzik wrote:
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote:
Please help Acard to add this chip spec on the web site in your earlier
conveniance.
http://gkernel.sourceforge.net/specs/
BTW, I put the doc in
http
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote:
By the way, once you complete the SATA sample driver , please inform us , so
we could modify, test and submit in the near future.
If any chip info still missing or need us to involve, please let me know.
Any chance the patch below
On Wed, Nov 07, 2007 at 02:12:55PM -0500, Mark Lord wrote:
That cannot be correct (??). Is this with hdparm-7.7 (latest sourceforge)
??
Can you show us the hdparm --Istdout output as well, please.
If this is applicable... FWIW hdparm was only recently (in past 72
hours) updated from 6.9 to
On Wed, Nov 07, 2007 at 10:54:15AM -0500, Mark Lord wrote:
sata_qstor conversion to new error handling (EH).
Convert sata_qstor to use the newer libata EH mechanisms.
Based on earlier work by Jeff Garzik.
This belongs in 2.6.24.
Signed-off-by: Mark Lord [EMAIL PROTECTED]
Did you test
On Wed, Nov 07, 2007 at 06:36:13PM -0500, Mark Lord wrote:
Mark Lord wrote:
..
and SG_IO WRITEs don't work. That's really no different from
the existing 2.6.24 version. Regular I/O looks fine.
...
I should qualify that: SG_IO *PIO* WRITEs don't work.
SG_IO PIO READs do work, and SG_IO
On Thu, Nov 08, 2007 at 07:28:38PM +0800, jameshsu wrote:
Not really understand your patch listed below.
We do not provide ahci.c file to you, so we don't know where the patch came
from(diff from where)??
Who create this and how can we get ahci.c file?? Can you tell us??
The file is found
On Thu, Nov 08, 2007 at 07:34:22PM +0800, jameshsu wrote:
From: LaurenceWu
We didn't study about ata/ahci.c, but it should be based on AHCI1.0 or 1.1
spec. That is, NO P.M. FIS base switching, but supports both non-NCQ and NCQ
protocols.
For NCQ or nonNCQ, 8620 is very AHCI-like, although
On Thu, Nov 08, 2007 at 06:44:31PM +0200, Denys Fedoryshchenko wrote:
Doesn't help
WRAP ~ #cat /proc/cmdline
console=ttyS0,38400n8 libata.dma_mask=3
It's libata.dma if its built into the kernel, or 'dma' module option
if built as a kernel module.
Jeff
-
To unsubscribe from this
On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote:
On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED]
wrote:
Andrew Morton wrote, On 11/07/2007 09:13 PM:
On Wed, 07 Nov 2007 15:15:07 +0100 Roberto Oppedisano [EMAIL
PROTECTED] wrote:
Hello.
I
On Wed, Nov 07, 2007 at 12:02:27PM +0900, Tejun Heo wrote:
From: Yann Chachkoff [EMAIL PROTECTED]
Please warmly welcome the PRO variant of Satellite U200 to the broken
suspend list.
Original patch is from Yann Chachkoff. Patch reformatted and
forwarded by Tejun Heo.
Signed-off-by:
On Wed, Nov 07, 2007 at 10:52:55AM -0500, Mark Lord wrote:
sata_qstor nuke idle state.
We're really only ever in one of two hardware states: packet, or mmio.
Get rid of unnecessary qs_state_idle state.
This belongs in 2.6.24.
Signed-off-by: Mark Lord [EMAIL PROTECTED]
applied patches
On Thu, Nov 08, 2007 at 11:14:56AM +0900, Paul Mundt wrote:
By default ata_host_activate() expects a valid IRQ in order to
successfully register the host. This patch enables a special case
for registering polling-only hosts that either don't have IRQs
or have buggy IRQ generation (either in
On Thu, Nov 08, 2007 at 11:20:18AM +0900, Tejun Heo wrote:
In a presentation of true workmanship, pata_ali asserts IRQ
permanantly if the TF status register is read more than once when
there's no device attached to the port.
Avoid waiting polling for !0xff if it's PATA. It's needed only for
On Thu, Nov 08, 2007 at 01:09:00PM +0900, Tejun Heo wrote:
Port / host stop calls used to be made from ata_host_release() which
is called after all hardware resources acquired after host allocation
are released. This is wrong as port and host stop routines often
access the hardware.
Add
On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote:
On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote:
On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote:
On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL
PROTECTED] wrote
On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote:
Jeff Garzik wrote:
On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote:
Jeff Garzik wrote:
..
2) This chip includes target mode support. Very nice, well done!
I hope that standard AHCI eventually supports this nice feature
On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote:
Jeff Garzik wrote:
..
2) This chip includes target mode support. Very nice, well done!
I hope that standard AHCI eventually supports this nice feature!
..
Speaking of which. Do we have a strategy as to how to implement/support
On Thu, Nov 08, 2007 at 03:49:17PM -0500, Mark Lord wrote:
Jeff Garzik wrote:
On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote:
..
MMmm.. I wonder what the most common use case is for target mode?
Everybody I've dealt with thus far uses it as a high-speed local comms
interface
On Fri, Nov 09, 2007 at 09:02:35AM +0700, Riki Oktarianto wrote:
Some BIOSen map AHCI ABAR but lock the SATA controller to IDE mode.
This patch add quirk to set AHCI mode on ICH board with such case.
Tested on Macbook2,1 (ICH7M)
Intel will complain but it's awful tempting...
Jeff
On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote:
And I might even privately patch my own kernels to map the ACHI BAR
in the cases where the BIOS didn't...
The inability to do this in the general case is the main reason why
AHCI was not unconditionally enabled, even in IDE mode, when
On Thu, Nov 08, 2007 at 10:38:25PM -0500, mike zheng wrote:
I am working on an AHCI SATA controller. For each port, there is one
FIS descriptor and one Command List, which points to a Received FIS
structure and Command List structure. So what is Received FIS
structure? The Command List
On Thu, Nov 08, 2007 at 11:44:22PM -0500, Mark Lord wrote:
Jeff Garzik wrote:
On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote:
And I might even privately patch my own kernels to map the ACHI BAR
in the cases where the BIOS didn't...
The inability to do this in the general case
Alan Cox wrote:
On Thu, 8 Nov 2007 22:46:22 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote:
And I might even privately patch my own kernels to map the ACHI BAR
in the cases where the BIOS didn't...
The inability to do this in the general
Matthias Schniedermeyer wrote:
And on the topic of broken BIOSes. I have a little empathy for the MB
manufactures as non-RAID AHCI royaly screws Windos, so not supporting it
reduces their support costs enough to overlook screwing the non-windos
faction.
non-RAID AHCI works just fine on
Jeff Garzik wrote:
The proposed sata_nv patch does the opposite -- guarantees we must
support the continually problematic legacy IDE interface ad infinitum.
Such patches are OK for the test lab, but in this specific case users
/suffer/ when not running AHCI mode.
Just to reinforce
Allen Martin wrote:
At least for NVIDIA controllers, loading the AHCI driver when the BIOS
is set to IDE mode is not recommended by NVIDIA. Any AHCI workarounds
in the BIOS are likely to be disabled when set to IDE mode. In practice
What workarounds, if any, are needed?
We need those in the
(cc'd to main potential content contributors)
What do you guys think about a git tree for linux-ata.org web pages,
rather than a wiki? A git tree would be my preference.
Whenever you want to update or add a page, just send a 'git pull'
request to me...
As I noted to Tejun in IRC, the main
Alan Cox wrote:
ata9.00: qc timeout (cmd 0xa0)
ata9.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata9.00: cmd a0/00:00:00:02:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 2
in
res 51/54:03:00:02:00/00:00:00:00:00/a0 Emask 0x5 (timeout)
ata9.00: status: { DRDY ERR }
Could be
Will Trives wrote:
Hello,
Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1)
Chipset: Intel P35 + ICH9R
PATA port runs off JMicron controller
CD/DVD Device: BENQ DW1640 16X
I cannot access my dvd burner under 2.6.24-rc2, I have no problems under
2.6.23. Basically the drive is detected OK,
1201 - 1300 of 1579 matches
Mail list logo