Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-04-06 Thread Kristoffer Ericson
On Mon, 10 Mar 2008 10:41:06 -0400 Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On Thu, Mar 06, 2008 at 10:51:47PM +0100, Jiri Kosina wrote: > > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > > > The general replies I've gotten when asking to change filenames is that > > > they don't want t

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-10 Thread Kristoffer Ericson
diff --git a/drivers/input/touchscreen/hp680_ts_input.c b/drivers/input/touchscreen/hp680_ts_input.c index c38d4e0..da395a3 100644 --- a/drivers/input/touchscreen/hp680_ts_input.c +++ b/drivers/input/touchscreen/hp680_ts_input.c @@ -1,7 +1,16 @@ +/* + * Platform driver for the HP Jornada 620/660/6

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-10 Thread Dmitry Torokhov
On Thu, Mar 06, 2008 at 10:51:47PM +0100, Jiri Kosina wrote: > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > The general replies I've gotten when asking to change filenames is that > > they don't want to break back-portability or whatever. To tell you the > > truth im not fully in the clea

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-08 Thread Kristoffer Ericson
On Sat, 8 Mar 2008 01:35:31 +0100 (CET) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Fri, 7 Mar 2008, Kristoffer Ericson wrote: > > > diff --git a/drivers/input/touchscreen/hp680_ts_input.c > > b/drivers/input/touchscreen/hp680_ts_input.c > > index c38d4e0..6b24f0b 100644 > > --- a/drivers/input/

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-07 Thread Jiri Kosina
On Fri, 7 Mar 2008, Kristoffer Ericson wrote: > diff --git a/drivers/input/touchscreen/hp680_ts_input.c > b/drivers/input/touchscreen/hp680_ts_input.c > index c38d4e0..6b24f0b 100644 > --- a/drivers/input/touchscreen/hp680_ts_input.c > +++ b/drivers/input/touchscreen/hp680_ts_input.c > @@ -1,7 +1

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-07 Thread Kristoffer Ericson
On Thu, 6 Mar 2008 22:51:47 +0100 (CET) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > The general replies I've gotten when asking to change filenames is that > > they don't want to break back-portability or whatever. To tell you the > > truth im no

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Jiri Kosina
On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > The general replies I've gotten when asking to change filenames is that > they don't want to break back-portability or whatever. To tell you the > truth im not fully in the clear what they ment. Perhaps that it would be > harder to track changes i

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Kristoffer Ericson
On Thu, 6 Mar 2008 11:40:35 +0100 (CET) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > Usually filename changes are avoided. For many reasons I guess, avoid > > breaking platforms, Makefiles..and so on. > > I of course assumed that you will also cha

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Kristoffer Ericson
On Thu, 6 Mar 2008 11:40:35 +0100 (CET) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > Usually filename changes are avoided. For many reasons I guess, avoid > > breaking platforms, Makefiles..and so on. > > I of course assumed that you will also cha

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Jiri Kosina
On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > Usually filename changes are avoided. For many reasons I guess, avoid > breaking platforms, Makefiles..and so on. I of course assumed that you will also change the Makefile :) I don't think that anything else (neither kernelspace nor userspace) re

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Kristoffer Ericson
2008/3/6, Jiri Kosina <[EMAIL PROTECTED]>: > > On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > > > Valid points, will fix them. > > Thanks. > > > > Also, while you are at it, maybe it would be worth to rename the > > > driver? (hp6xx instead of hp680). > > I would LOVE to rename the filename and ma

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Jiri Kosina
On Thu, 6 Mar 2008, Kristoffer Ericson wrote: > Valid points, will fix them. Thanks. > > Also, while you are at it, maybe it would be worth to rename the > > driver? (hp6xx instead of hp680). > I would LOVE to rename the filename and make it abit more similiar to > jornada7xx (like we have for

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-06 Thread Kristoffer Ericson
Valid points, will fix them. 2008/3/6, Jiri Kosina <[EMAIL PROTECTED]>: > > On Wed, 5 Mar 2008, Kristoffer Ericson wrote: > > > -static void do_softint(struct work_struct *work) > > +static void do_softint(struct delayed_work *work) > > { > > - int absx = 0, absy = 0; > > u8 scpdr; > >

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-05 Thread Jiri Kosina
On Wed, 5 Mar 2008, Kristoffer Ericson wrote: > -static void do_softint(struct work_struct *work) > +static void do_softint(struct delayed_work *work) > { > - int absx = 0, absy = 0; > u8 scpdr; > int touched = 0; > + int x,y; Minor nitpick: could you put some space here plea

[HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-05 Thread Kristoffer Ericson
This patch makes the HP Jornada 6xx touchscreen driver work with tslib (userland touchscreen library) again. The reason for it to stop working was the deletion of tsdev, which it depended on. Changes include : * device driver -> platform_driver. * more error checking at registration time. * mor