Re: [RFC v5 3/4] pstore/blk: support pmsg for pstore block

2019-01-23 Thread liaoweixiong
Resend this mail. On 2019-01-18 08:17, Kees Cook wrote: > On Mon, Jan 7, 2019 at 4:01 AM liaoweixiong > wrote: >> >> To enable pmsg, just set pmsg_size when block device register blkzone. > > At first pass, this looks like a reasonable extension of blkzone. Is > it possible to add console, ftrac

Re: [RFC v5 3/4] pstore/blk: support pmsg for pstore block

2019-01-23 Thread 廖威雄
On 2019-01-18 08:17, Kees Cook wrote: > On Mon, Jan 7, 2019 at 4:01 AM liaoweixiong > wrote: >> >> To enable pmsg, just set pmsg_size when block device register blkzone. > > At first pass, this looks like a reasonable extension of blkzone. Is > it possible to add console, ftrace, etc, too? > I

[PATCH v16 5/7] x86/boot: Early parse RSDP and fill in boot_params

2019-01-23 Thread Chao Fan
RSDP is needed by both KASLR, so parse it early and fill it in boot_params before KASLR code. RSDP is needed by lots of other code, it would be easier to have it always built-in instead of a long "depends on" line in Kconfig. Signed-off-by: Chao Fan --- arch/x86/boot/compressed/Makefile | 2 ++

[PATCH v16 4/7] x86/boot: Introduce bios_get_rsdp_addr() to search RSDP in memory

2019-01-23 Thread Chao Fan
Memory information in SRAT table is necessary to fix the conflict between KASLR and memory-hotremove. So RSDP and SRAT should be parsed. When booting form KEXEC/EFI/BIOS, the methods to compute RSDP are different. When booting from BIOS, there is no variable who can point to RSDP directly, so scan

[PATCH v16 0/7] Parse ACPI table and limit KASLR to choosing immovable memory

2019-01-23 Thread Chao Fan
***Background: People reported that KASLR may randomly choose some positions which are located in movable memory regions. This will make the movable memory chosen by KASLR can't be removed. ***Solutions: Get the information of memory hot-remove, then KASLR knows the right regions. Information abou

[PATCH v16 7/7] x86/boot/KASLR: Limit KASLR to extracting kernel in immovable memory

2019-01-23 Thread Chao Fan
KASLR may randomly choose some positions which are located in movable memory regions. It will break memory hotplug feature and make the movable memory chosen by KASLR can't be removed. The solution is to limit KASLR to choose memory regions in immovable node according to SRAT tables. When CONFIG_E

[PATCH v16 3/7] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table

2019-01-23 Thread Chao Fan
Memory information in SRAT is necessary to fix the conflict between KASLR and memory-hotremove. So RSDP and SRAT should be parsed. When booting form KEXEC/EFI/BIOS, the methods to compute RSDP are different. When booting from EFI, EFI table points to RSDP. So parse the EFI table and find the RSDP.

[PATCH v16 1/7] x86/boot: Copy kstrtoull() to boot/string.c instead of simple_strtoull()

2019-01-23 Thread Chao Fan
Copy kstrtoull() and necessary functions from lib/kstrtox.c to boot/string.c so that code in boot/ can use kstrtoull() and the old simple_strtoull() can be replaced. In boot/string.c, using div_u64() from math64.h directly will cause the dividend handled as 64-bit value and bring ld error. The sol

[PATCH v16 6/7] x86/boot: Parse SRAT address from RSDP and store immovable memory

2019-01-23 Thread Chao Fan
SRAT should be parsed by RSDP to fix the conflict between KASLR and memory-hotremove, then filter the immovable memory regions and accoring to the memory information, KASLR can avoid to extract kernel to movable memory regions. Signed-off-by: Chao Fan --- arch/x86/boot/compressed/acpi.c | 122 +

[PATCH v16 2/7] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2019-01-23 Thread Chao Fan
KASLR may randomly choose some positions which are located in movable memory regions. This will make the movable memory chosen by KASLR can't be removed. Memory information in SRAT is necessary to fix the conflict between KASLR and memory-hotremove. ACPI SRAT (System/Static Resource Affinity Tabl

Re: [PATCH 2/2] debugfs: return error values, not NULL

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 11:28:14, Greg KH wrote: > When an error happens, debugfs should return an error pointer value, not > NULL. This will prevent the totally theoretical error where a debugfs > call fails due to lack of memory, returning NULL, and that dentry value > is then passed to another debugfs

[PATCH 2/3] gcc-plugins: Introduce stackinit plugin

2019-01-23 Thread Kees Cook
This attempts to duplicate the proposed gcc option -finit-local-vars[1] in an effort to implement the "always initialize local variables" kernel development goal[2]. Enabling CONFIG_GCC_PLUGIN_STACKINIT should stop all "uninitialized stack variable" flaws as long as they don't depend on being zero

Re: [PATCH] checkpatch: Verify SPDX comment style

2019-01-23 Thread Joe Perches
On Thu, 2019-01-10 at 16:05 -0800, Joe Perches wrote: > Using SPDX commenting style // or /* is specified for > various file types in Documentation/process/license-rules.rst > so add an appropriate test for .[chsS] files because many > proposed file additions and patches do not use the correct styl

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Kirill Tkhai
On 23.01.2019 14:02, Michal Hocko wrote: > On Wed 23-01-19 13:28:03, Kirill Tkhai wrote: >> On 22.01.2019 23:09, Yang Shi wrote: >>> In current implementation, both kswapd and direct reclaim has to iterate >>> all mem cgroups. It is not a problem before offline mem cgroups could >>> be iterated.

[PATCH 0/3] gcc-plugins: Introduce stackinit plugin

2019-01-23 Thread Kees Cook
This adds a new plugin "stackinit" that attempts to perform unconditional initialization of all stack variables[1]. It has wider effects than GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=y since BYREF_ALL does not consider non-structures. A notable weakness is that padding bytes in many cases remain uninitializ

Re: [PATCH] checkpatch: Add some new alloc functions to various tests

2019-01-23 Thread Joe Perches
On Sat, 2019-01-12 at 12:45 -0800, Joe Perches wrote: > Many new generic allocation functions like the > kvmalloc family have been added recently to the kernel. ping?

[PATCH 3/3] lib: Introduce test_stackinit module

2019-01-23 Thread Kees Cook
Adds test for stack initialization coverage. We have several build options that control the level of stack variable initialization. This test lets us visualize which options cover which cases, and provide tests for options that are currently not available (padding initialization). All options pass

[PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Kees Cook
Variables declared in a switch statement before any case statements cannot be initialized, so move all instances out of the switches. After this, future always-initialized stack variables will work and not throw warnings like this: fs/fcntl.c: In function ‘send_sigio_to_task’: fs/fcntl.c:738:13: w

RE: [PATCH v5 2/4] perf: add arm64 smmuv3 pmu driver

2019-01-23 Thread Shameerali Kolothum Thodi
Hi Andrew, Thanks for taking a look at this. > -Original Message- > From: Andrew Murray [mailto:andrew.mur...@arm.com] > Sent: 22 January 2019 16:24 > To: Shameerali Kolothum Thodi > Cc: lorenzo.pieral...@arm.com; robin.mur...@arm.com; > mark.rutl...@arm.com; vkil...@codeaurora.org; neil

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 13:28:03, Kirill Tkhai wrote: > On 22.01.2019 23:09, Yang Shi wrote: > > In current implementation, both kswapd and direct reclaim has to iterate > > all mem cgroups. It is not a problem before offline mem cgroups could > > be iterated. But, currently with iterating offline mem cg

[RFC v6 4/4] Documentation: pstore/blk: create document for pstore_blk

2019-01-23 Thread liaoweixiong
The document, at Documentation/admin-guide/pstore-block.rst, tells user how to use pstore_blk and the attentions about panic read/write Signed-off-by: liaoweixiong --- Documentation/admin-guide/pstore-block.rst | 227 + MAINTAINERS| 1

[RFC v6 2/4] pstore/blk: add blkoops for pstore_blk

2019-01-23 Thread liaoweixiong
blkoops is a sample for pstore/blk. It can only record oops, excluding panics as no read/write apis for panic registered. It support settings on Kconfg/device tree/module parameters. It can record oops log even power failure if "PSTORE_BLKOOPS_PART_PATH" on Kconfig or "partition-path" on dts or "pa

[RFC v6 0/4] pstore/block: new support logger for block devices

2019-01-23 Thread liaoweixiong
Why should we need pstore_block? 1. Most embedded intelligent equipment have no persistent ram, which increases costs. We perfer to cheaper solutions, like block devices. In fast, there is already a sample for block device logger in driver MTD (drivers/mtd/mtdoops.c). 2. Do not any equipment have b

[RFC v6 1/4] pstore/blk: new support logger for block devices

2019-01-23 Thread liaoweixiong
pstore_blk is similar to pstore_ram, but dump log to block devices rather than persistent ram. Why should we need pstore_blk? 1. Most embedded intelligent equipment have no persistent ram, which increases costs. We perfer to cheaper solutions, like block devices. In fact, there is already a sample

[RFC v6 3/4] pstore/blk: support pmsg for pstore block

2019-01-23 Thread liaoweixiong
To enable pmsg, just set pmsg_size when block device register blkzone. Signed-off-by: liaoweixiong --- fs/pstore/blkoops.c| 11 ++ fs/pstore/blkzone.c| 254 + include/linux/pstore_blk.h | 1 + 3 files changed, 244 insertions(+), 22 d

Re: [PATCH v3] selftests: add binderfs selftests

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote: > On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote: > > This adds the promised selftest for binderfs. It will verify the following > > things: > > - binderfs mounting works > > - binder device allocation works > > -

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-23 Thread Mark Brown
On Wed, Jan 23, 2019 at 12:45:30PM +0530, al...@codeaurora.org wrote: > On 2019-01-23 01:59, Mark Brown wrote: > > Still not seeing anything except this patch here in my inbox - like I > > said what's the story with dependencies? > I've added linux-spi mailing list to all the patches sent as part

RE: Awaiting your urgent response

2019-01-23 Thread Miss Julian Mene
Good day!!! I am Miss Julian Mene, 24 year old, an orphan from Democratic Republic of Congo (DRC), but presently in Benin Republic. I have something very urgent and important to discuss with you. I assure you that you will not regret anything. Please send your reply to my personal email: me...@r

Re: [PATCH v3] selftests: add binderfs selftests

2019-01-23 Thread Christian Brauner
On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote: > This adds the promised selftest for binderfs. It will verify the following > things: > - binderfs mounting works > - binder device allocation works > - performing a binder ioctl() request through a binderfs device works > - binder

Re: [PATCH v2 1/9] thermal: cpu_cooling: Require thermal core to be compiled in

2019-01-23 Thread Rafael J. Wysocki
On Wed, Jan 23, 2019 at 11:53 AM Amit Kucheria wrote: > > On Wed, Jan 23, 2019 at 4:04 PM Viresh Kumar wrote: > > > > On 21-01-19, 21:10, Amit Kucheria wrote: > > > The CPU cooling driver (cpu_cooling.c) allows the platform's cpufreq > > > driver to register as a cooling device and cool down the

Re: [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

2019-01-23 Thread Rafael J. Wysocki
On Wed, Jan 23, 2019 at 11:44 AM Viresh Kumar wrote: > > On 23-01-19, 16:13, Viresh Kumar wrote: > > On 23-01-19, 11:39, Rafael J. Wysocki wrote: > > > On Wed, Jan 23, 2019 at 11:36 AM Viresh Kumar > > > wrote: > > > > > > > > On 21-01-19, 21:10, Amit Kucheria wrote: > > > > > @@ -151,6 +152,11

Re: [PATCH v2 1/9] thermal: cpu_cooling: Require thermal core to be compiled in

2019-01-23 Thread Amit Kucheria
On Wed, Jan 23, 2019 at 4:04 PM Viresh Kumar wrote: > > On 21-01-19, 21:10, Amit Kucheria wrote: > > The CPU cooling driver (cpu_cooling.c) allows the platform's cpufreq > > driver to register as a cooling device and cool down the platform by > > throttling the CPU frequency. In order to be able t

Re: [PATCH v4 2/3] dt-bindings: reset: imx7: Document usage on i.MX8MQ SoCs

2019-01-23 Thread Philipp Zabel
On Thu, 2019-01-17 at 14:38 -0800, Andrey Smirnov wrote: [...] > > To be honest, I don't like these two, I'm not convinced anymore that > > they actually qualify as reset signals. To me it looks like this is > > something that the PCIe glue code should handle via syscon like i.MX6. > > Leonard, Luc

Re: linux-next: Fixes tags need some work in the dma-mapping-fixes tree

2019-01-23 Thread Thierry Reding
On Wed, Jan 23, 2019 at 07:47:47AM +1100, Stephen Rothwell wrote: > Hi Christoph, > > In commit > > 702e8ed37bed ("arm64/xen: fix xen-swiotlb cache flushing") Hi Christoph, I'm not subscribed to any of the mailing list that the above patch was reviewed on, so I'm replying here because it is t

Re: [PATCH v5 3/3] reset: imx7: Add support for i.MX8MQ IP block variant

2019-01-23 Thread Philipp Zabel
Hi Andrey, On Mon, 2019-01-21 at 18:10 -0800, Andrey Smirnov wrote: > Add bits and pieces needed to support IP block variant found on > i.MX8MQ SoCs. > > Cc: p.za...@pengutronix.de > Cc: Fabio Estevam > Cc: cphe...@gmail.com > Cc: l.st...@pengutronix.de > Cc: Leonard Crestez > Cc: "A.s. Dong"

Re: [PATCH v6 09/16] sched/cpufreq: uclamp: Add utilization clamping for RT tasks

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 15, 2019 at 10:15:06AM +, Patrick Bellasi wrote: > @@ -858,16 +859,23 @@ static inline void > uclamp_effective_get(struct task_struct *p, unsigned int clamp_id, >unsigned int *clamp_value, unsigned int *bucket_id) > { > + struct uclamp_se *default_clamp; >

Re: [PATCH v9 12/26] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2019-01-23 Thread Julien Thierry
On 22/01/2019 15:21, Catalin Marinas wrote: > On Mon, Jan 21, 2019 at 03:33:31PM +, Julien Thierry wrote: >> diff --git a/arch/arm64/include/asm/irqflags.h >> b/arch/arm64/include/asm/irqflags.h >> index 24692ed..7e82a92 100644 >> --- a/arch/arm64/include/asm/irqflags.h >> +++ b/arch/arm64/

Re: [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

2019-01-23 Thread Viresh Kumar
On 23-01-19, 16:13, Viresh Kumar wrote: > On 23-01-19, 11:39, Rafael J. Wysocki wrote: > > On Wed, Jan 23, 2019 at 11:36 AM Viresh Kumar > > wrote: > > > > > > On 21-01-19, 21:10, Amit Kucheria wrote: > > > > @@ -151,6 +152,11 @@ struct cpufreq_policy { > > > > > > > > /* For cpufreq driver

Re: [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

2019-01-23 Thread Viresh Kumar
On 23-01-19, 11:39, Rafael J. Wysocki wrote: > On Wed, Jan 23, 2019 at 11:36 AM Viresh Kumar wrote: > > > > On 21-01-19, 21:10, Amit Kucheria wrote: > > > @@ -151,6 +152,11 @@ struct cpufreq_policy { > > > > > > /* For cpufreq driver's internal use */ > > > void*dri

Re: [PATCH] quantenna: no need to check return value of debugfs_create functions

2019-01-23 Thread Sergey Matyukevich
> When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Igor Mitsyanko > Cc: Avinash Patil > Cc: Sergey Matyukevich > Cc: Kalle Valo > Cc: linux-wirel...@

Re: [PATCH 02/17] clocksource: davinci-timer: new driver

2019-01-23 Thread Kevin Hilman
Bartosz Golaszewski writes: > pon., 14 sty 2019 o 13:20 Sekhar Nori napisał(a): >> >> Hi Bartosz, >> >> On 11/01/19 10:51 PM, Bartosz Golaszewski wrote: >> > From: Bartosz Golaszewski >> > >> > Currently the clocksource and clockevent support for davinci platforms >> > lives in mach-davinci. It

[regression] mei: me: allow runtime pm for platform with D0i3

2019-01-23 Thread Jeremy Cline
Hi folks, Fedora has received a number of reports of e1000e-driven ethernet ports negotiating 10Mbps links if the cable is disconnected and reconnected after boot on a number of laptops, including the Lenovo T480s[0]. Kamil git-bisected the issue to commit cc365dcf0e56 ("mei: me: allow runtime pm

Re: [PATCH] media: docs-rst: Document m2m stateless video decoder interface

2019-01-23 Thread Paul Kocialkowski
Hi Alex, On Wed, 2019-01-23 at 18:43 +0900, Alexandre Courbot wrote: > On Tue, Jan 22, 2019 at 7:10 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Tue, 2019-01-22 at 17:19 +0900, Tomasz Figa wrote: > > > Hi Paul, > > > > > > On Fri, Dec 7, 2018 at 5:30 PM Paul Kocialkowski > > > wrote: > > >

RE: linux-next: Fixes tag needs some work in the renesas tree

2019-01-23 Thread Fabrizio Castro
Thank you Simon. Fab > From: Simon Horman > Sent: 23 January 2019 10:39 > Subject: Re: linux-next: Fixes tag needs some work in the renesas tree > > [CC linux-renesas-soc] > > On Wed, Jan 23, 2019 at 08:55:21AM +, Fabrizio Castro wrote: > > > From: Stephen Rothwell > > > Sent: 22 January 20

[PATCH v2 2/4] venus: core: correct maximum hardware load for sdm845

2019-01-23 Thread Stanimir Varbanov
This correct maximum hardware load constant in per SoC resources for sdm845 aka Venus v4. Reviewed-by: Alexandre Courbot Tested-by: Alexandre Courbot Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 0/4] Venus various fixes

2019-01-23 Thread Stanimir Varbanov
Hello, Changes in v2: * in 1/4 make 'mapped' const - Alex * fixed typos in 2/4 and 4/4 - Alex * added Reviewed-by and Tested-by tags regards, Stan Stanimir Varbanov (4): venus: firmware: check fw size against DT memory region size venus: core: correct maximum hardware load for sdm845 ve

[PATCH v2 1/4] venus: firmware: check fw size against DT memory region size

2019-01-23 Thread Stanimir Varbanov
By historical reasons we defined firmware memory size to be 6MB even that the firmware size for all supported Venus versions is 5MBs. Correct that by compare the required firmware size returned from mdt loader and the one provided by DT reserved memory region. We proceed further if the required fir

[PATCH v2 4/4] venus: helpers: drop setting of timestamp invalid flag

2019-01-23 Thread Stanimir Varbanov
The zero timestamp is really valid so fix that mistake by dropping the code which checks for zero timestamp. Reviewed-by: Alexandre Courbot Tested-by: Alexandre Courbot Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 --- 1 file changed, 3 deletions(-) dif

[PATCH v2 3/4] venus: core: correct frequency table for sdm845

2019-01-23 Thread Stanimir Varbanov
This corrects clock frequency table rates to be in sync with video clock controller frequency table. Reviewed-by: Alexandre Courbot Tested-by: Alexandre Courbot Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 10 ++ 1 file changed, 6 insertions(+), 4 del

Re: [PATCH v2] arm: sun8i-h3-nanopi-m1-plus: enable HDMI

2019-01-23 Thread Maxime Ripard
On Tue, Jan 22, 2019 at 07:46:46AM +, Corentin Labbe wrote: > This patch enable HDMI output on sun8i-h3-nanopi-m1-plus. > > Signed-off-by: Corentin Labbe The prefix must be "ARM: dts:" I've fixed it and applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineerin

Re: [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

2019-01-23 Thread Rafael J. Wysocki
On Wed, Jan 23, 2019 at 11:36 AM Viresh Kumar wrote: > > On 21-01-19, 21:10, Amit Kucheria wrote: > > @@ -151,6 +152,11 @@ struct cpufreq_policy { > > > > /* For cpufreq driver's internal use */ > > void*driver_data; > > + > > +#ifdef CONFIG_CPU_THERMAL > > + /*

Re: linux-next: Fixes tag needs some work in the renesas tree

2019-01-23 Thread Simon Horman
[CC linux-renesas-soc] On Wed, Jan 23, 2019 at 08:55:21AM +, Fabrizio Castro wrote: > > From: Stephen Rothwell > > Sent: 22 January 2019 20:56 > > To: Simon Horman > > Subject: linux-next: Fixes tag needs some work in the renesas tree > > > > Hi all, > > > > In commit > > > > 8d6e2bbaeceb

Re: [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

2019-01-23 Thread Viresh Kumar
On 21-01-19, 21:10, Amit Kucheria wrote: > @@ -151,6 +152,11 @@ struct cpufreq_policy { > > /* For cpufreq driver's internal use */ > void*driver_data; > + > +#ifdef CONFIG_CPU_THERMAL > + /* Pointer to the cooling device if used for thermal mitigation */ > +

[PATCH] livepatch: fix size mismatch

2019-01-23 Thread Nicholas Mc Guire
samples/livepatch//livepatch-shadow-fix1.c:97:30-36: ERROR: application of sizeof to pointer Patch was compile tested with: x86_64_defconfig + FTRACE=y, FUNCTION_TRACER=y, SAMPLES=y, LIVEPATCH=y SAMPLE_LIVEPATCH=m Patch is against 5.0-rc3 (localversion-next is next-20190123) samples/livepatch

Re: [PATCH v2 1/9] thermal: cpu_cooling: Require thermal core to be compiled in

2019-01-23 Thread Viresh Kumar
On 21-01-19, 21:10, Amit Kucheria wrote: > The CPU cooling driver (cpu_cooling.c) allows the platform's cpufreq > driver to register as a cooling device and cool down the platform by > throttling the CPU frequency. In order to be able to auto-register a > cpufreq driver as a cooling device from the

Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages

2019-01-23 Thread David Hildenbrand
On 22.01.19 16:44, Oscar Salvador wrote: > This is the same sort of error we saw in [1]. > > Gigantic hugepages crosses several memblocks, so it can be > that the page we get in scan_movable_pages() is a page-tail > belonging to a 1G-hugepage. > If that happens, page_hstate()->size_to_hstate() wil

Re: [PATCH] power: domain: no need to check return value of debugfs_create functions

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 09:20:05AM +0100, Ulf Hansson wrote: > On Wed, 23 Jan 2019 at 08:59, Greg Kroah-Hartman > wrote: > > > > On Wed, Jan 23, 2019 at 08:44:36AM +0100, Ulf Hansson wrote: > > > On Tue, 22 Jan 2019 at 16:23, Greg Kroah-Hartman > > > wrote: > > > > > > > > When calling debugfs fu

Re: [PATCH -next] gpio: davinci: drop pointless static qualifier

2019-01-23 Thread Keerthy
On 23/01/19 2:19 PM, YueHaibing wrote: > There is no need to have the 'gpio_unbanked' variable static since > new value always be assigned before use it. Acked-by: Keerthy > > Signed-off-by: YueHaibing > --- > drivers/gpio/gpio-davinci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH 2/2] debugfs: return error values, not NULL

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 11:29:30AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 23, 2019 at 11:28:14AM +0100, Greg Kroah-Hartman wrote: > > When an error happens, debugfs should return an error pointer value, not > > NULL. This will prevent the totally theoretical error where a debugfs > > call

Dear Friend Please Respond.

2019-01-23 Thread james kabore
From:MR.JAMES KABORE. Bill and Exchange Manager Micro Finance Bank Plc Burkina Faso Dear Friend, I know that this mail will come to you as a surprise. I am MR.JAMES KABORE. and I am the bill and Exchange manager in a Bank here in my country .I Hope that you will not expose or betray this trust a

Re: [PATCH 2/2] debugfs: return error values, not NULL

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 11:28:14AM +0100, Greg Kroah-Hartman wrote: > When an error happens, debugfs should return an error pointer value, not > NULL. This will prevent the totally theoretical error where a debugfs > call fails due to lack of memory, returning NULL, and that dentry value > is then

[PATCH 2/2] debugfs: return error values, not NULL

2019-01-23 Thread Greg Kroah-Hartman
When an error happens, debugfs should return an error pointer value, not NULL. This will prevent the totally theoretical error where a debugfs call fails due to lack of memory, returning NULL, and that dentry value is then passed to another debugfs call, which would end up succeeding, creating a f

Re: [PATCH v6 09/16] sched/cpufreq: uclamp: Add utilization clamping for RT tasks

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 15, 2019 at 10:15:06AM +, Patrick Bellasi wrote: > - util = (type == ENERGY_UTIL) > - ? util_cfs > - : uclamp_util(rq, util_cfs); > - util += cpu_util_rt(rq); > + util = cpu_util_rt(rq); > + if (type == FREQUENCY_UTIL) { > + util +

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Kirill Tkhai
On 22.01.2019 23:09, Yang Shi wrote: > In current implementation, both kswapd and direct reclaim has to iterate > all mem cgroups. It is not a problem before offline mem cgroups could > be iterated. But, currently with iterating offline mem cgroups, it > could be very time consuming. In our work

[PATCH 1/2] debugfs: fix debugfs_rename parameter checking

2019-01-23 Thread Greg Kroah-Hartman
debugfs_rename() needs to check that the dentries passed into it really are valid, as sometimes they are not (i.e. if the return value of another debugfs call is passed into this one.) So fix this up by properly checking if the two parent directories are errors (they are allowed to be NULL), and i

Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 11:18:42, Oscar Salvador wrote: > On Wed, Jan 23, 2019 at 10:47:17AM +0100, Michal Hocko wrote: > > So this should be probably folded into the above patch as it is > > incomplete unless I am missing something. > > Well, they are triggered from different paths. > The former error wa

[PATCH] drm/rockchip: rgb: update SPDX license identifier

2019-01-23 Thread Sandy Huang
update SPDX License Identifier from GPL-2.0+ to GPL-2.0 and drop some GPL text. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 11 +-- drivers/gpu/drm/rockchip/rockchip_rgb.h | 11 +-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/drive

Re: [Qestion] Softlockup when send IPI to other CPUs

2019-01-23 Thread Will Deacon
On Tue, Jan 22, 2019 at 02:55:22PM +, Mark Rutland wrote: > On Tue, Jan 22, 2019 at 05:44:02AM +, Will Deacon wrote: > > On Mon, Jan 21, 2019 at 02:21:28PM +, Catalin Marinas wrote: > > > On Sat, Jan 19, 2019 at 11:58:27PM +, Will Deacon wrote: > > > > On Thu, Jan 17, 2019 at 07:42:

Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages

2019-01-23 Thread Oscar Salvador
On Wed, Jan 23, 2019 at 10:47:17AM +0100, Michal Hocko wrote: > So this should be probably folded into the above patch as it is > incomplete unless I am missing something. Well, they are triggered from different paths. The former error was triggered in: removable_show is_mem_section_removable

Re: [PATCH v5 2/8] ASoC: wcd9335: add support to wcd9335 codec

2019-01-23 Thread Srinivas Kandagatla
Thanks for the review, On 22/01/2019 18:41, Mark Brown wrote: On Thu, Jan 10, 2019 at 03:06:10PM +, Srinivas Kandagatla wrote: This all looks good apart from a couple of small things that should be easy to fix: diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 62bdb7e

Re: [PATCH v5 4/8] ASoC: wcd9335: add basic controls

2019-01-23 Thread Srinivas Kandagatla
Thanks for the review, On 22/01/2019 18:52, Mark Brown wrote: On Thu, Jan 10, 2019 at 03:06:12PM +, Srinivas Kandagatla wrote: +static const char * const wcd9335_ear_pa_gain_text[] = { + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", + "G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB

Re: [PATCH 2/2] Input: st1232 - add support for st1633

2019-01-23 Thread Martin Kepplinger
On 23.01.19 08:26, Martin Kepplinger wrote: From: Martin Kepplinger Add support for the Sitronix ST1633 touchscreen controller to the st1232 driver. FYI, here's a protocol spec: www.ampdisplay.com/documents/pdf/AM-320480B6TZQW-TC0H.pdf Let me know if you want that link in the commit message

Re: [PATCH 1/4] venus: firmware: check fw size against DT memory region size

2019-01-23 Thread Stanimir Varbanov
Hi Alex, Thanks for the review! On 1/23/19 8:10 AM, Alexandre Courbot wrote: > Sorry for the delayed review! >_< > > On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov > wrote: >> >> By historical reasons we defined firmware memory size to be 6MB even >> that the firmware size for all supported V

Re: [PATCH] x86/boot: save several bytes in decompressor

2019-01-23 Thread Kirill A. Shutemov
On Wed, Jan 23, 2019 at 06:00:14PM +0800, Cao jin wrote: > gdt64 represents the content of GDTR under x86-64, which actually needs > 10 bytes only, ".long" & ".word" is superfluous. > > Signed-off-by: Cao jin Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov

Re: [PATCH 09/24] dt-bindings: PCI: Document "atu" reg-names

2019-01-23 Thread Kishon Vijay Abraham I
Hi Rob, On 22/01/19 6:18 AM, Rob Herring wrote: > On Mon, Jan 14, 2019 at 06:54:09PM +0530, Kishon Vijay Abraham I wrote: >> Document "atu" reg-names required to get the register space for ATU in >> Synopsys designware core version >= 4.80. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> D

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-01-23 Thread Christophe Leroy
Le 12/01/2019 à 10:55, Christophe Leroy a écrit : The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which moves the thread_info into task_struct. Moving thread_info into task_struct has the following advantages: - It protects thread_info from corruption in the case of stack

Re: question about head_64.S

2019-01-23 Thread Kirill A. Shutemov
On Wed, Jan 23, 2019 at 12:01:23PM +0800, Cao jin wrote: > Thanks for your info! BTW, could I know how you construct the test > environment? Nothing fancy. I just built different versions of binutils from git. -- Kirill A. Shutemov

[PATCH] x86/boot: save several bytes in decompressor

2019-01-23 Thread Cao jin
gdt64 represents the content of GDTR under x86-64, which actually needs 10 bytes only, ".long" & ".word" is superfluous. Signed-off-by: Cao jin --- arch/x86/boot/compressed/head_64.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compress

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-23 Thread Tomasz Figa
On Sun, Nov 18, 2018 at 10:34 AM Nicolas Dufresne wrote: > > Le samedi 17 novembre 2018 à 12:37 +0100, Hans Verkuil a écrit : > > > > Does V4L2_CID_MIN_BUFFERS_FOR_CAPTURE make any sense for encoders? > > > > > > We do account for it in GStreamer (the capture/output handling is > > > generic), but

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-23 Thread Tomasz Figa
On Sat, Nov 17, 2018 at 8:37 PM Hans Verkuil wrote: > > On 11/17/2018 05:18 AM, Nicolas Dufresne wrote: > > Le lundi 12 novembre 2018 à 14:23 +0100, Hans Verkuil a écrit : > >> On 10/22/2018 04:49 PM, Tomasz Figa wrote: [snip] > >>> + rely on it. The ``V4L2_BUF_FLAG_LAST`` buffer flag should

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 04:09:42, Yang Shi wrote: > In current implementation, both kswapd and direct reclaim has to iterate > all mem cgroups. It is not a problem before offline mem cgroups could > be iterated. But, currently with iterating offline mem cgroups, it > could be very time consuming. In our

[PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap()

2019-01-23 Thread Jason Wang
This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even hardware feature toggling. Test shows about 24% improvement on TX PPS. It should benefit other cases as well. Changes f

[PATCH net-next V4 3/5] vhost: rename vq_iotlb_prefetch() to vq_meta_prefetch()

2019-01-23 Thread Jason Wang
Rename the function to be more accurate since it actually tries to prefetch vq metadata address in IOTLB. And this will be used by following patch to prefetch metadata virtual addresses. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 4 ++-- drivers/vhost/vhost.c | 4 ++-- drivers/vhost/v

[PATCH net-next V4 1/5] vhost: generalize adding used elem

2019-01-23 Thread Jason Wang
Use one generic vhost_copy_to_user() instead of two dedicated accessor. This will simplify the conversion to fine grain accessors. About 2% improvement of PPS were seen during vitio-user txonly test. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 11 +-- 1 file changed, 1 insertio

[PATCH net-next V4 4/5] vhost: introduce helpers to get the size of metadata area

2019-01-23 Thread Jason Wang
Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 46 ++- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 24c74c60c093..37e2cac8e8b0 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vho

[PATCH net-next V4 2/5] vhost: fine grain userspace memory accessors

2019-01-23 Thread Jason Wang
This is used to hide the metadata address from virtqueue helpers. This will allow to implement a vmap based fast accessing to metadata. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 94 +++ 1 file changed, 77 insertions(+), 17 deletions(-) diff --

[PATCH net-next V4 5/5] vhost: access vq metadata through kernel virtual address

2019-01-23 Thread Jason Wang
It was noticed that the copy_user() friends that was used to access virtqueue metdata tends to be very expensive for dataplane implementation like vhost since it involves lots of software checks, speculation barrier, hardware feature toggling (e.g SMAP). The extra cost will be more obvious when tra

Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device

2019-01-23 Thread Boris Brezillon
On Wed, 23 Jan 2019 17:43:58 +0800 YueHaibing wrote: > On 2019/1/23 17:12, Boris Brezillon wrote: > > On Wed, 23 Jan 2019 14:58:27 +0800 > > YueHaibing wrote: > > > >> Fix a static code checker warning: > >> drivers/mtd/devices/docg3.c:1875 > >> doc_probe_device() warn: passing zero to 'ERR_

[PATCH v2] virtio: support VIRTIO_F_ORDER_PLATFORM

2019-01-23 Thread Tiwei Bie
This patch introduces the support for VIRTIO_F_ORDER_PLATFORM. If this feature is negotiated, the driver must use the barriers suitable for hardware devices. Otherwise, the device and driver are assumed to be implemented in software, that is they can be assumed to run on identical CPUs in an SMP co

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-23 Thread Tomasz Figa
On Mon, Nov 12, 2018 at 10:23 PM Hans Verkuil wrote: > > On 10/22/2018 04:49 PM, Tomasz Figa wrote: > > Due to complexity of the video encoding process, the V4L2 drivers of > > stateful encoder hardware require specific sequences of V4L2 API calls > > to be followed. These include capability enume

Re: [PATCH v6 08/16] sched/cpufreq: uclamp: Add utilization clamping for FAIR tasks

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 22, 2019 at 06:18:31PM +, Patrick Bellasi wrote: > On 22-Jan 18:13, Peter Zijlstra wrote: > > On Tue, Jan 15, 2019 at 10:15:05AM +, Patrick Bellasi wrote: > > > @@ -342,11 +350,24 @@ static void sugov_iowait_boost(struct sugov_cpu > > > *sg_cpu, u64 time, > > > return

Re: [PATCH v8 2/3] sched/fair: update scale invariance of PELT

2019-01-23 Thread Vincent Guittot
On Wed, 23 Jan 2019 at 09:26, Dietmar Eggemann wrote: > > On 1/16/19 10:43 AM, Vincent Guittot wrote: > > [...] > > > +static inline u64 rq_clock_pelt(struct rq *rq) > > +{ > > Doesn't this function need > >lockdep_assert_held(&rq->lock); >assert_clock_updated(rq); originally, it was repl

[PATCH] xtensa: rename BUILTIN_DTB to BUILTIN_DTB_SOURCE

2019-01-23 Thread Corentin Labbe
When building some xtensa config, I hit the following warning: drivers/staging/mt7621-dts/Kconfig:4:warning: 'BUILTIN_DTB' has wrong type. 'select' only accept arguments of bool and tristate type It is due to some arch use BUILTIN_DTB as a flag for the need to builtin dtb but xtensa use it as a s

Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages

2019-01-23 Thread Michal Hocko
On Tue 22-01-19 16:44:07, Oscar Salvador wrote: > This is the same sort of error we saw in [1]. > > Gigantic hugepages crosses several memblocks, so it can be > that the page we get in scan_movable_pages() is a page-tail > belonging to a 1G-hugepage. > If that happens, page_hstate()->size_to_hstat

[PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-23 Thread ufo19890607
From: yuzhoujian We can monitor the sum wait time of a task group since 'commit 3d6c50c27bd6 ("sched/debug: Show the sum wait time of a task group")'. However this wait_sum just represents the confilct between different task groups, since it is simply sum the wait time of task_group's cfs_rq. And

Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device

2019-01-23 Thread YueHaibing
On 2019/1/23 17:12, Boris Brezillon wrote: > On Wed, 23 Jan 2019 14:58:27 +0800 > YueHaibing wrote: > >> Fix a static code checker warning: >> drivers/mtd/devices/docg3.c:1875 >> doc_probe_device() warn: passing zero to 'ERR_PTR' >> >> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor suppo

Re: [PATCH] media: docs-rst: Document m2m stateless video decoder interface

2019-01-23 Thread Alexandre Courbot
On Tue, Jan 22, 2019 at 7:10 PM Paul Kocialkowski wrote: > > Hi, > > On Tue, 2019-01-22 at 17:19 +0900, Tomasz Figa wrote: > > Hi Paul, > > > > On Fri, Dec 7, 2018 at 5:30 PM Paul Kocialkowski > > wrote: > > > Hi, > > > > > > Thanks for this new version! I only have one comment left, see below. >

Re: [PATCH] edac: no need to check return value of debugfs_create functions

2019-01-23 Thread Borislav Petkov
On Tue, Jan 22, 2019 at 04:21:16PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Borislav Petkov > Cc: Mauro Carva

Re: [PATCH 2/4] arm: dump: no need to check return value of debugfs_create functions

2019-01-23 Thread Laura Abbott
On 1/22/19 6:41 AM, Greg Kroah-Hartman wrote: When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Russell King Cc: Jinbum Park Cc: Kees Cook Cc: Laura Abbott

Re: [PATCH reset-next 0/2] reset: brcmstb: Misc fixes

2019-01-23 Thread Philipp Zabel
On Tue, 2019-01-22 at 16:33 -0800, Florian Fainelli wrote: > Hi Philipp, > > These two patches fix some recent issues brought up by Paul and Randy, > feel free to squash into c196cdc7659d ("reset: Add Broadcom STB SW_INIT > reset controller driver") since this is only in reset/next and > linux-nex

<    4   5   6   7   8   9   10   >