[PATCH V3 07/10] mmc: tegra: add Tegra186 WAR for CQE

2019-03-13 Thread Sowjanya Komatineni
Tegra186 CQHCI host has a known bug where CQHCI controller selects DATA_PRESENT_SELECT bit to 1 for DCMDs with R1B response type and since DCMD does not trigger any data transfer, DCMD task complete happens leaving the DATA FSM of host controller in wait state for the data. This effects the data

[PATCH V3 06/10] mmc: cqhci: allow hosts to update dcmd cmd desc

2019-03-13 Thread Sowjanya Komatineni
This patch adds update_dcmd_desc interface to cqhci_host_ops to allow hosts to update any of the DCMD task descriptor attributes and parameters. Tested-by: Jon Hunter Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/cqhci.c | 2 ++ drivers/mmc/host/cqhci.h | 2 ++ 2 files changed, 4

[PATCH V3 02/10] mmc: sdhci: allow host to specify maximum tuning loops

2019-03-13 Thread Sowjanya Komatineni
As per the Host Controller Standard Specification Version 4.20, limitation of tuning iteration count is removed as PLL locking time can be longer than UHS-1 tuning due to larger PVT fluctuation and it will result in increase of tuning iteration to complete the tuning. This patch creates

[PATCH V3 04/10] dt-bindings: mmc: tegra: document Tegra194 compatible string

2019-03-13 Thread Sowjanya Komatineni
SDHCI controller of Tegra194 is similar to SDHCI controller in Tegra186. This patch documents Tegra194 sdhci compatible string. Signed-off-by: Sowjanya Komatineni --- Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH V3 05/10] arm64: tegra: fix default tap and trim values

2019-03-13 Thread Sowjanya Komatineni
Default tap and trim values are incorrect for Tegra186 SDMMC4. This patch fixes it. Tested-by: Jon Hunter Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V3 08/10] mmc: cqhci: add CQHCI_SSC1 register CBC field mask

2019-03-13 Thread Sowjanya Komatineni
This patch adds define for CBC field mask of the register CQHCI_SSC1. Tested-by: Jon Hunter Acked-by: Adrian Hunter Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/cqhci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/cqhci.h b/drivers/mmc/host/cqhci.h index

[PATCH V3 10/10] arm64: tegra: enable command queue for tegra186 sdmmc4

2019-03-13 Thread Sowjanya Komatineni
This patch enables command queue support for Tegra186 SDMMC4. Tested-by: Jon Hunter Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi

[PATCH V3 09/10] mmc: tegra: fix CQE enable and resume sequence

2019-03-13 Thread Sowjanya Komatineni
Tegra CQHCI/SDHCI design prevents write access to SDHCI block size register when CQE is enabled and unhalted. CQHCI driver enables CQE prior to invoking sdhci_cqe_enable which violates this Tegra specific host requirement. This patch fixes this by configuring sdhci block registers prior to CQE

[PATCH V3 01/10] mmc: tegra: fix ddr signaling for non-ddr modes

2019-03-13 Thread Sowjanya Komatineni
ddr_signaling is set to true for DDR50 and DDR52 modes but is not set back to false for other modes. This programs incorrect host clock when mode change happens from DDR52/DDR50 to other SDR or HS modes like incase of mmc_retune where it switches from HS400 to HS DDR and then from HS DDR to HS

[PATCH V3 03/10] mmc: tegra: update hw tuning process

2019-03-13 Thread Sowjanya Komatineni
This patch includes below HW tuning related fixes. configures tuning parameters as per Tegra TRM WAR fix for manual tap change HW auto-tuning post process As per Tegra TRM, SDR50 mode tuning execution takes upto maximum of 256 tuning iterations and SDR104/HS200/HS400 modes tuning

Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting

2019-03-13 Thread Suren Baghdasaryan
On Fri, Feb 8, 2019 at 2:06 AM Patrick Bellasi wrote: > > Utilization clamping allows to clamp the CPU's utilization within a > [util_min, util_max] range, depending on the set of RUNNABLE tasks on > that CPU. Each task references two "clamp buckets" defining its minimum > and maximum

Re: [PATCH] arch: arm: Kconfig: pedantic formatting

2019-03-13 Thread Alexander Sverdlin
Hi! On 11/03/2019 14:56, Enrico Weigelt, metux IT consult wrote: > Formatting of Kconfig files doesn't look so pretty, so let the > Great White Handkerchief come around and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/arm/Kconfig | 24

[PATCH] pci: aardvark: Wait for endpoint to be ready before training link

2019-03-13 Thread Remi Pommarel
When configuring pcie reset pin from gpio (e.g. initially set by u-boot) to pcie function this pin goes low for a brief moment asserting the PERST# signal. Thus connected device enters fundamental reset process and link configuration can only begin after a minimal 100ms delay (see [1]). This

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-13 Thread Tejun Heo
Hello, On Wed, Mar 13, 2019 at 02:22:55PM -0700, Paul E. McKenney wrote: > Should I define DEFINE_SRCU() and DEFINE_STATIC_SRCU() only if > !defined(MODULE)? Yeah, that sounds like a great idea with comments explaining why it's like that. Thanks. -- tejun

lib/test_overflow.c causes WARNING and tainted kernel

2019-03-13 Thread Randy Dunlap
This is v5.0-11053-gebc551f2b8f9, MAR-12 around 4:00pm PT. In the first test_kmalloc() in test_overflow_allocation(): [54375.073895] test_overflow: ok: (s64)(0 << 63) == 0 [54375.074228] WARNING: CPU: 2 PID: 5462 at ../mm/page_alloc.c:4584 __alloc_pages_nodemask+0x33f/0x540 [54375.074279]

[PATCH] mm: fix a wrong flag in set_migratetype_isolate()

2019-03-13 Thread Qian Cai
Due to has_unmovable_pages() takes an incorrect irqsave flag instead of the isolation flag in set_migratetype_isolate(), it causes issues with HWPOSION and error reporting where dump_page() is not called when there is an unmoveable page. Fixes: d381c54760dc ("mm: only report isolation failures

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-13 Thread Rasmus Villemoes
On 21/02/2019 07.30, George Spelvin wrote: > Rather than u32_swap and u64_swap working on 4- and 8-byte objects > directly, let them handle any multiple of 4 or 8 bytes. This speeds > up most users of sort() by avoiding fallback to the byte copy loop. > > Despite what commit ca96ab859ab4

Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting

2019-03-13 Thread Suren Baghdasaryan
On Wed, Mar 13, 2019 at 6:52 AM Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 10:05:40AM +, Patrick Bellasi wrote: > > +/* > > + * When a task is enqueued on a rq, the clamp bucket currently defined by > > the > > + * task's uclamp::bucket_id is reference counted on that rq. This also >

Re: [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation

2019-03-13 Thread Linus Walleij
On Wed, Mar 13, 2019 at 10:19 PM Arnd Bergmann wrote: > Marking a local variable as __xipram causes a warning because of the > noinline attribute: > > drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only > applies to functions [-Werror,-Wignored-attributes] >

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-13 Thread Paul E. McKenney
On Wed, Mar 13, 2019 at 01:26:40PM -0700, Tejun Heo wrote: > Hello, > > On Wed, Mar 13, 2019 at 03:40:04PM -0400, Barret Rhoden wrote: > > Are there any other alternatives? Not using static SRCU in any code > > that could be built as a module seems a little harsh. > > Yes, allocate the srcu

[PATCH v4 01/10] gpio: Add support for hierarchical IRQ domains

2019-03-13 Thread Lina Iyer
From: Thierry Reding Hierarchical IRQ domains can be used to stack different IRQ controllers on top of each other. One specific use-case where this can be useful is if a power management controller has top-level controls for wakeup interrupts. In such cases, the power management controller can

[PATCH v4 00/10] support wakeup capable GPIOs

2019-03-13 Thread Lina Iyer
Hi all, This series adds support for wakeup capable GPIOs. It is based on Thierry's hiearchical GPIO domains. This approach is based on Stephen's idea [1]. The SoC that is used for this development is a QCOM SDM845. The current patchset is rebased on top of 5.0 and adds documentation for the

[PATCH] ARM: milbeaut: fix build with !CONFIG_HOTPLUG_CPU

2019-03-13 Thread Arnd Bergmann
When HOTPLUG_CPU is disabled, some fields in the smp operations are not available or needed: arch/arm/mach-milbeaut/platsmp.c:90:3: error: field designator 'cpu_die' does not refer to any field in type 'struct smp_operations' .cpu_die= m10v_cpu_die, ^

[PATCH v4 02/10] irqdomain: add bus token DOMAIN_BUS_WAKEUP

2019-03-13 Thread Lina Iyer
A single controller can handle normal interrupts and wake-up interrupts independently, with a different numbering space. It is thus crucial to allow the driver for such a controller discriminate between the two. A simple way to do so is to tag the wake-up irqdomain with a "bus token" that

[PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation

2019-03-13 Thread Arnd Bergmann
Marking a local variable as __xipram causes a warning because of the noinline attribute: drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only applies to functions [-Werror,-Wignored-attributes] map_word __xipram ret; ^

[PATCH v4 05/10] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs

2019-03-13 Thread Lina Iyer
Introduce a new domain for wakeup capable GPIOs. The domain can be requested using the bus token DOMAIN_BUS_WAKEUP. In the following patches, we will specify PDC as the wakeup-parent for the TLMM GPIO irqchip. Requesting a wakeup GPIO will setup the GPIO and the corresponding PDC interrupt as its

[PATCH v4 08/10] arm64: dts: qcom: add PDC interrupt controller for SDM845

2019-03-13 Thread Lina Iyer
Add PDC interrupt controller device bindings for SDM845. Signed-off-by: Lina Iyer --- Changes in v1: - Use updated address specification in reg - Rename to pdc_intc - Sort per address in DT --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 + 1 file changed, 9

[PATCH v4 06/10] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO

2019-03-13 Thread Lina Iyer
SDM845 SoC has an always-on interrupt controller (PDC) with select GPIO routed to the PDC as interrupts that can be used to wake the system up from deep low power modes and suspend. Cc: devicet...@vger.kernel.org Signed-off-by: Lina Iyer ---

[PATCH v4 10/10] arm64: defconfig: enable PDC interrupt controller for Qualcomm SDM845

2019-03-13 Thread Lina Iyer
Enable PDC interrupt controller for SDM845 devices. The interrupt controller can detect wakeup capable interrupts when the SoC is in a low power state. Signed-off-by: Lina Iyer --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig

[PATCH v4 09/10] arm64: dts: qcom: setup PDC as wakeup parent for GPIOs for SDM845

2019-03-13 Thread Lina Iyer
Setup PDC wakeup parent for TLMM for SDM845 SoC. Signed-off-by: Lina Iyer --- Changes in v3: - Provide irqdomain-map for GPIOs that map to PDC --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 78 1 file changed, 78 insertions(+) diff --git

[PATCH v4 03/10] of/irq: document properties for wakeup interrupt parent

2019-03-13 Thread Lina Iyer
Some interrupt controllers in a SoC, are always powered on and have a select interrupts routed to them, so that they can wakeup the SoC from suspend. Add wakeup-parent DT property to refer to these interrupt controllers. If the interrupts routed to the wakeup parent are not sequential, than a map

[PATCH v4 07/10] drivers: pinctrl: msm: setup GPIO irqchip hierarchy

2019-03-13 Thread Lina Iyer
To allow GPIOs to wakeup the system from suspend or deep idle, the wakeup capable GPIOs are setup in hierarchy with interrupts from the wakeup-parent irqchip. In older SoC's, the TLMM will handover detection to the parent irqchip and in newer SoC's, the parent irqchip may also be active as well

[PATCH v4 04/10] of: irq: add helper to remap interrupts to another irqdomain

2019-03-13 Thread Lina Iyer
From: Stephen Boyd Sometimes interrupts are routed from an interrupt controller to another in no specific order. Having these in the drivers makes it difficult to maintain when the same drivers supports multiple variants with different mapping. Also, specifying them in DT makes little sense with

Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 05:36:10PM +0100, Wolfram Sang wrote: > Hi Greg, > > > > I was wondering if you think the below ABI addition looks sane to you? > > I am not the i2c maintainer :) > > Peter is the i2c-mux maintainer, so I trust him very much on the I2C > side of things. We just wondered

[PATCH v4] lib/string.c: implement a basic bcmp

2019-03-13 Thread Nick Desaulniers
A recent optimization in Clang (r355672) lowers comparisons of the return value of memcmp against zero to comparisons of the return value of bcmp against zero. This helps some platforms that implement bcmp more efficiently than memcmp. glibc simply aliases bcmp to memcmp, but an optimized

Re: [PATCH v3] lib/string.c: implement a basic bcmp

2019-03-13 Thread Steven Rostedt
On March 13, 2019 4:37:37 PM EDT, Nick Desaulniers wrote: >A recent optimization in Clang (r355672) lowers comparisons of the >return value of memcmp against zero to comparisons of the return value >of bcmp against zero. This helps some platforms that implement bcmp >more efficiently than

[PATCH v3] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up. This commit remove the following warnings: lib/siphash.c:71:12: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/siphash.c:72:12: warning:

Re: [RFC] sched/fair: hard lockup in sched_cfs_period_timer

2019-03-13 Thread Phil Auld
On Wed, Mar 13, 2019 at 01:26:51PM -0700 bseg...@google.com wrote: > Phil Auld writes: > > > On Wed, Mar 13, 2019 at 10:44:09AM -0700 bseg...@google.com wrote: > >> Phil Auld writes: > >> > >> > On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wrote: > >> >> On Mon, Mar 11, 2019 at

[PATCH] mm/hotplug: fix notification in offline error path

2019-03-13 Thread Qian Cai
When start_isolate_page_range() returned -EBUSY in __offline_pages(), it calls memory_notify(MEM_CANCEL_OFFLINE, ) with an uninitialized "arg". As the result, it triggers warnings below. Also, it is only necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE. page:ea000120 count:1

Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting

2019-03-13 Thread Suren Baghdasaryan
On Wed, Mar 13, 2019 at 12:46 PM Peter Zijlstra wrote: > > On Wed, Mar 13, 2019 at 03:23:59PM +, Patrick Bellasi wrote: > > On 13-Mar 15:09, Peter Zijlstra wrote: > > > On Fri, Feb 08, 2019 at 10:05:40AM +, Patrick Bellasi wrote: > > > > > +static inline void uclamp_rq_update(struct rq

Re: [PATCH 3/3] RISC-V: Allow booting kernel from any 4KB aligned address

2019-03-13 Thread Anup Patel
On Thu, Mar 14, 2019 at 12:01 AM Mike Rapoport wrote: > > On Tue, Mar 12, 2019 at 10:08:22PM +, Anup Patel wrote: > > Currently, we have to boot RISCV64 kernel from a 2MB aligned physical > > address and RISCV32 kernel from a 4MB aligned physical address. This > > constraint is because

Re: [LSF/MM TOPIC] Using XArray to manage the VMA

2019-03-13 Thread Davidlohr Bueso
On Wed, 13 Mar 2019, Laurent Dufour wrote: If this is not too late and if there is still place available, I would like to attend the MM track and propose a topic about using the XArray to replace the VMA's RB tree and list. Using the XArray in place of the VMA's tree and list seems to be a

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 13:25 -0700, Eric Biggers wrote: > On Wed, Mar 13, 2019 at 01:06:06PM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 12:57 -0700, Eric Biggers wrote: [...] > > > fscrypt would allow the data to be stored encrypted on the local > > > disk, so it's protected against

[PATCH v1 1/3] mmc: sdio: Add helper macro for sdio_driver boilerplate

2019-03-13 Thread sean.wang
From: Sean Wang This patch introduces the module_sdio_driver macro which is a convenience macro for SDIO driver modules similar to module_usb_driver. It is intended to be used by drivers which init/exit section does nothing but register/ unregister the SDIO driver. By using this macro it is

Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting

2019-03-13 Thread Suren Baghdasaryan
On Wed, Mar 13, 2019 at 8:15 AM Patrick Bellasi wrote: > > On 12-Mar 13:52, Dietmar Eggemann wrote: > > On 2/8/19 11:05 AM, Patrick Bellasi wrote: > > > > [...] > > > > > +config UCLAMP_BUCKETS_COUNT > > > + int "Number of supported utilization clamp buckets" > > > + range 5 20 > > > +

[PATCH v1 3/3] Bluetooth: btsdio: Use module_sdio_driver helper

2019-03-13 Thread sean.wang
From: Sean Wang Macro module_sdio_driver is used for drivers whose init and exit paths only register and unregister to SDIO API. So remove boilerplate code to make code simpler by using module_sdio_driver. Cc: Marcel Holtmann Cc: Ulf Hansson Signed-off-by: Sean Wang ---

[PATCH v1 0/3] add module_sdio_driver and enable a few users

2019-03-13 Thread sean.wang
From: Sean Wang Add module_sdio_driver exactly like the function module_usb_drivear offers to and enable a few users to eliminate a few lines of boilerplate code per SDIO driver. Sean Wang (3): mmc: sdio: Add helper macro for sdio_driver boilerplate Bluetooth: mediatek: Use

[PATCH v1 2/3] Bluetooth: mediatek: Use module_sdio_driver helper

2019-03-13 Thread sean.wang
From: Sean Wang Macro module_sdio_driver is used for drivers whose init and exit paths only register and unregister to SDIO API. So remove boilerplate code to make code simpler by using module_sdio_driver. Cc: Ulf Hansson Suggested-by: Marcel Holtmann Signed-off-by: Sean Wang ---

Re: Applied "spi: work around clang bug in SPI_BPW_RANGE_MASK()" to the spi tree

2019-03-13 Thread Arnd Bergmann
On Wed, Mar 13, 2019 at 8:15 PM Geert Uytterhoeven wrote: > > -#define SPI_BIT_MASK(bits) (((bits) == 32) ? ~0U : (BIT(bits) - 1)) > > -#define SPI_BPW_RANGE_MASK(min, max) (SPI_BIT_MASK(max) - SPI_BIT_MASK(min > > - 1)) > > +#define SPI_BPW_RANGE_MASK(min, max) GENMASK((min) - 1, (max) - 1) >

[PATCH] spi: fix SPI_BPW_RANGE_MASK() regression

2019-03-13 Thread Arnd Bergmann
Geert points out that I confused the min/max arguments that are reversed between SPI_BPW_RANGE_MASK() and GENMASK(). This time I have verified the result of the macro after fixing the arguments. Cc: Geert Uytterhoeven Fixes: eefffb42f665 ("spi: work around clang bug in SPI_BPW_RANGE_MASK()")

Re: [PATCH 5.0 00/25] 5.0.2-stable review

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 01:36:25PM -0700, Guenter Roeck wrote: > On Tue, Mar 12, 2019 at 10:08:38AM -0700, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.0.2 release. > > There are 25 patches in this series, all will be posted as a response > > to this one.

Re: Re:[PATCH 4.9 81/96] MIPS: Loongson: Introduce and use loongson_llsc_mb()

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 09:17:15PM +0800, 陈华才 wrote: > Hi, GREG, > > 4.9 need to modify spinlock.h, please wait my patch. > > > > ---原始邮件--- > 发件人:"Greg Kroah-Hartman" > 发送时间:2019年3月13日(星期三) 凌晨1:10 > 收件人:"linux-kernel"; > 主题:[PATCH 4.9 81/96] MIPS: Loongson: Introduce and use

Re: [PATCH 4.20 000/171] 4.20.16-stable review

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 05:24:09PM +0530, Naresh Kamboju wrote: > On Tue, 12 Mar 2019 at 22:42, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.20.16 release. > > There are 171 patches in this series, all will be posted as a response > > to this one. If

Re: [PATCH 4.20 000/171] 4.20.16-stable review

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 05:36:36PM +, Jon Hunter wrote: > > On 12/03/2019 17:06, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.16 release. > > There are 171 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld wrote: > > Conceptually this seems pretty reasonable. Though, style-wise, perhaps > you might want to put those breaks on the next line too, i.e. s/; > break;/;\n\t\tbreak;/? Good point. This needs some more love since checkpatch complains now

Re: [PATCH v7 06/15] sched/core: uclamp: Reset uclamp values on RESET_ON_FORK

2019-03-13 Thread Peter Zijlstra
On Fri, Feb 08, 2019 at 10:05:45AM +, Patrick Bellasi wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 070caa1f72eb..8b282616e9c9 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1071,7 +1071,7 @@ static void __setscheduler_uclamp(struct task_struct

Re: [PATCH 1/2] firewire: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
On Wed, Mar 13, 2019 at 9:39 PM Gustavo A. R. Silva wrote: > > Mathieu, > > On 3/13/19 3:28 PM, Mathieu Malaterre wrote: > > ping ? > > > > I have sent the following patch to address all these warnings in > firewire: > > https://lore.kernel.org/patchwork/patch/1040737/ > > and, as this is being

Re: [PATCH 4.9 00/96] 4.9.163-stable review

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 01:34:41PM -0700, Guenter Roeck wrote: > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.163 release. > > There are 96 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Gustavo A. R. Silva
On 3/13/19 3:34 PM, Jason A. Donenfeld wrote: > Conceptually this seems pretty reasonable. Though, style-wise, perhaps > you might want to put those breaks on the next line too, i.e. s/; > break;/;\n\t\tbreak;/? > I agree. With that, you can add my: Acked-by: Gustavo A. R. Silva Thanks --

[PATCH] Bluetooth: mediatek: fix uninitialized symbol errors in btmtksdio_rx_packet

2019-03-13 Thread sean.wang
From: Sean Wang Fixed all the below warnings. They would probably cause the following error handling path would use the uninitialized value and then produce unexpected behavior. drivers/bluetooth/btmtksdio.c:470:2: warning: ‘old_len’ may be used uninitialized in this function

Re: [PATCH v7 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-13 Thread Patrick Venture
On Wed, Mar 13, 2019 at 12:54 PM Rob Herring wrote: > > On Tue, Mar 12, 2019 at 11:30 AM Patrick Venture wrote: > > > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > --- > > Changes for v7: > > - Moved node under the syscon

Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Jason A. Donenfeld
Conceptually this seems pretty reasonable. Though, style-wise, perhaps you might want to put those breaks on the next line too, i.e. s/; break;/;\n\t\tbreak;/?

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Marc Gonzalez
On 13/03/2019 19:29, Srinivas Kandagatla wrote: > On 13/03/2019 11:45, Marc Gonzalez wrote: > >> We don't need to fudge the device class in qcom_pcie_rd_own_conf() >> because dw_pcie_setup_rc() already does the right thing: >> >> /* Program correct class for RC */ >>

Re: [PATCH 1/2] firewire: annotate implicit fall through

2019-03-13 Thread Gustavo A. R. Silva
Mathieu, On 3/13/19 3:28 PM, Mathieu Malaterre wrote: > ping ? > I have sent the following patch to address all these warnings in firewire: https://lore.kernel.org/patchwork/patch/1040737/ and, as this is being ignored, I'll add it to my tree for 5.2. Thanks -- Gustavo > On Mon, Jan 14,

[PATCH v3] lib/string.c: implement a basic bcmp

2019-03-13 Thread Nick Desaulniers
A recent optimization in Clang (r355672) lowers comparisons of the return value of memcmp against zero to comparisons of the return value of bcmp against zero. This helps some platforms that implement bcmp more efficiently than memcmp. glibc simply aliases bcmp to memcmp, but an optimized

Re: [PATCH 5.0 00/25] 5.0.2-stable review

2019-03-13 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 10:08:38AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.0.2 release. > There are 25 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 4.20 000/171] 4.20.16-stable review

2019-03-13 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 10:06:20AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.20.16 release. > There are 171 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 000/149] 4.19.29-stable review

2019-03-13 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 10:06:58AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.29 release. > There are 149 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 000/135] 4.14.106-stable review

2019-03-13 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 10:07:27AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.106 release. > There are 135 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/96] 4.9.163-stable review

2019-03-13 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.163 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: overlayfs vs. fscrypt

2019-03-13 Thread Richard Weinberger
Am Mittwoch, 13. März 2019, 15:26:54 CET schrieb Amir Goldstein: > IMO, the best thing for UBIFS to do would be to modify fscrypt to support > opting out of the revalidate behavior, IWO, sanitize your hack to an API. Given the WTF/s rate this thread has, this might me a good option. Actually

Re: [PATCH 1/2] firewire: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:42 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > In this particular case rewrote the comment to start with the string "fall > through", so as to match the

Re: [PATCH] signal: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > kernel/signal.c:795:13: warning: this statement may fall

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-13 Thread Tejun Heo
Hello, On Wed, Mar 13, 2019 at 03:40:04PM -0400, Barret Rhoden wrote: > Are there any other alternatives? Not using static SRCU in any code > that could be built as a module seems a little harsh. Yes, allocate the srcu dynamically on module init and destroy on module exit. That's how the other

[PATCH 0/4] leds: netdev trigger: allow setting initial values in device tree

2019-03-13 Thread Rasmus Villemoes
I asked whether it would be reasonable to be able to initialize a netdev trigger from DT data and was told "patch welcome", so here's an attempt at implementing that, adding some pieces of documentation along the way that would have saved me some time figuring out how to transition away from the

[PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store

2019-03-13 Thread Rasmus Villemoes
If userspace doesn't end the input with a newline (which can easily happen if the write happens from a C program that does write(fd, iface, strlen(iface))), we may end up including garbage from a previous, longer value in the device_name. For example # cat device_name # printf 'eth12' >

Re: [RFC] sched/fair: hard lockup in sched_cfs_period_timer

2019-03-13 Thread bsegall
Phil Auld writes: > On Wed, Mar 13, 2019 at 10:44:09AM -0700 bseg...@google.com wrote: >> Phil Auld writes: >> >> > On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wrote: >> >> On Mon, Mar 11, 2019 at 10:44:25AM -0700 bseg...@google.com wrote: >> >> > Letting it spin for 100ms and then only

[PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store

2019-03-13 Thread Rasmus Villemoes
Take the part of device_name_store that puts the old device (if any), copies the new device name, looks the name up etc. into a separate helper function. This is preparation for using that helper from a function that will initialize the led_netdev_data from a device tree node. No functional

[PATCH 3/4] leds: netdev trigger: add documentation to leds/common.txt

2019-03-13 Thread Rasmus Villemoes
The various sysfs files used to configure a netdev-triggered LED are already documented, but let's also add "netdev" to the list of things one can reasonably set linux,default-trigger to. Signed-off-by: Rasmus Villemoes --- Documentation/devicetree/bindings/leds/common.txt | 3 +++ 1 file

Re: [PATCH] blkcg: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:31 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > kernel/trace/blktrace.c:725:9: warning: this statement

Re: overlayfs vs. fscrypt

2019-03-13 Thread Eric Biggers
On Wed, Mar 13, 2019 at 01:06:06PM -0700, James Bottomley wrote: > On Wed, 2019-03-13 at 12:57 -0700, Eric Biggers wrote: > > On Wed, Mar 13, 2019 at 12:17:52PM -0700, James Bottomley wrote: > > > On Wed, 2019-03-13 at 14:58 -0400, Theodore Ts'o wrote: > > > > On Wed, Mar 13, 2019 at 10:45:04AM

[PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up. This commit remove the following warnings: lib/siphash.c:71:12: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/siphash.c:72:12: warning:

Re: [RFC 2/2] PCI: imx6: Add support for i.MX8QM/QXP PCIe

2019-03-13 Thread Andrey Smirnov
On Wed, Mar 13, 2019 at 2:15 AM Richard Zhu wrote: > > Add codes needed to support i.MX8QM/QXP PCIe. > - HSIO(High Speed IO) subsystem is new defined on i.MX8QM/QXP. > The PCIe and SATA modules are contained in the HSIO subsystem. There > are two PCIe, one SATA controllers and three mixed

Re: [PATCH 00/12] introduce percpu block scan_hint

2019-03-13 Thread Dennis Zhou
On Wed, Feb 27, 2019 at 09:18:27PM -0500, Dennis Zhou wrote: > Hi everyone, > > It was reported a while [1] that an increase in allocation alignment > requirement [2] caused the percpu memory allocator to do significantly > more work. > > After spending quite a bit of time diving into it, it

Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps

2019-03-13 Thread Peter Zijlstra
On Fri, Feb 08, 2019 at 10:05:42AM +, Patrick Bellasi wrote: > +static void uclamp_fork(struct task_struct *p) > +{ > + unsigned int clamp_id; > + > + if (unlikely(!p->sched_class->uclamp_enabled)) > + return; > + > + for (clamp_id = 0; clamp_id < UCLAMP_CNT;

Re: [PATCH] MAINTAINERS: Add KVM selftests to existing KVM entry

2019-03-13 Thread Sean Christopherson
On Wed, Mar 13, 2019 at 12:55:55PM -0700, Sean Christopherson wrote: > It's safe to assume Paolo and Radim are maintaining the KVM selftests > given that the vast majority of commits have their SOBs. Play nice > with get_maintainers and make it official. > > Signed-off-by: Sean Christopherson >

Re: [RFC PATCH 0/7] tracing: Use common error_log with probe events

2019-03-13 Thread Tom Zanussi
Hi Masami, On Wed, 2019-03-13 at 21:27 +0900, Masami Hiramatsu wrote: > Hi Tom, > > Here is a series of patches which applies common error_log framework > to > probe events. While applying it, I found I missed to check some > errors > in parser. Also, I made a testcase for this feature (only for

Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps

2019-03-13 Thread Peter Zijlstra
On Fri, Feb 08, 2019 at 10:05:42AM +, Patrick Bellasi wrote: > +int sysctl_sched_uclamp_handler(struct ctl_table *table, int write, > + void __user *buffer, size_t *lenp, > + loff_t *ppos) > +{ > + int old_min, old_max; > + int

Re: [PATCH v2] lib/string.c: implement a basic bcmp

2019-03-13 Thread Steven Rostedt
On Wed, 13 Mar 2019 20:34:11 +0100 Rasmus Villemoes wrote: > Yes, but let's completely avoid mentioning memcmp in the summary. > > bcmp - return 0 if and only if the buffers have identical contents > @a: pointer to first buffer > @b: pointer to second buffer > @len: size of buffers > > The

Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps

2019-03-13 Thread Peter Zijlstra
On Wed, Mar 13, 2019 at 05:09:40PM +, Patrick Bellasi wrote: > Yes, that should be possible... will look into splitting this out in > v8 to have something like: > > ---8<--- > struct uclamp_req { > /* Clamp value "requested" by a scheduling entity */ > unsigned int value

Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga driver

2019-03-13 Thread Rob Herring
On Tue, Mar 5, 2019 at 3:42 AM Nava kishore Manne wrote: > > Hi Rob, > > Thanks for the quick response. > Please find my response inline. > > > -Original Message- > > From: Rob Herring [mailto:r...@kernel.org] > > Sent: Monday, March 4, 2019 10:57 PM > > To: Nava kishore Manne > > Cc:

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 12:57 -0700, Eric Biggers wrote: > On Wed, Mar 13, 2019 at 12:17:52PM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 14:58 -0400, Theodore Ts'o wrote: > > > On Wed, Mar 13, 2019 at 10:45:04AM -0700, James Bottomley wrote: > > > > > If they can't break root, then

Re: [PATCH 0/3] userfaultfd: allow to forbid unprivileged users

2019-03-13 Thread Mike Kravetz
On 3/13/19 11:52 AM, Andrea Arcangeli wrote: > > hugetlbfs is more complicated to detect, because even if you inherit > it from fork(), the services that mounts the fs may be in a different > container than the one that Oracle that uses userfaultfd later on down > the road from a different

Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps

2019-03-13 Thread Peter Zijlstra
On Wed, Mar 13, 2019 at 05:09:40PM +, Patrick Bellasi wrote: > On 13-Mar 15:32, Peter Zijlstra wrote: > > I still think that this effective thing is backwards. > With respect to the previous v6, I've now moved this concept to the > patch where we actually use it for the first time. > The

Re: [PATCH AUTOSEL 4.20 37/60] tmpfs: fix link accounting when a tmpfile is linked in

2019-03-13 Thread Hugh Dickins
AUTOSEL is wrong to select this commit without also selecting 29b00e609960 ("tmpfs: fix uninitialized return value in shmem_link") which contains the tag Fixes: 1062af920c07 ("tmpfs: fix link accounting when a tmpfile is linked in") Please add 29b00e609960 for those 6 trees, or else omit

Re: overlayfs vs. fscrypt

2019-03-13 Thread Eric Biggers
On Wed, Mar 13, 2019 at 12:17:52PM -0700, James Bottomley wrote: > On Wed, 2019-03-13 at 14:58 -0400, Theodore Ts'o wrote: > > On Wed, Mar 13, 2019 at 10:45:04AM -0700, James Bottomley wrote: > > > > If they can't break root, then the OS's user-id based access > > > > control checks (or SELinux

[PATCH] MAINTAINERS: Add KVM selftests to existing KVM entry

2019-03-13 Thread Sean Christopherson
It's safe to assume Paolo and Radim are maintaining the KVM selftests given that the vast majority of commits have their SOBs. Play nice with get_maintainers and make it official. Signed-off-by: Sean Christopherson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

Re: [PATCH RESEND V2 1/4] dt-bindings: fsl: scu: add watchdog binding

2019-03-13 Thread Rob Herring
On Wed, Mar 13, 2019 at 3:11 AM Anson Huang wrote: > > Hi, Rob > Do you have any feedback about adding imx scu watchdog node in dts? > Thanks. Yes, in my reply 2 days ago. Rob

Re: [PATCH v7 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-13 Thread Rob Herring
On Tue, Mar 12, 2019 at 11:30 AM Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > Signed-off-by: Patrick Venture > --- > Changes for v7: > - Moved node under the syscon node it requires > Changes for v6: > - None > Changes for v5: > - None >

[PATCH] kbuild: deb-pkg: set executable bit for debian/rules

2019-03-13 Thread Mathieu Malaterre
This will remove the warning: dpkg-buildpackage: warning: debian/rules is not executable; fixing that Signed-off-by: Mathieu Malaterre --- scripts/package/mkdebian | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian index

<    1   2   3   4   5   6   7   8   9   >