Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-05 Thread Peter Zijlstra
On Sun, Aug 04, 2019 at 09:19:01PM -0700, Paul E. McKenney wrote: > On Sun, Aug 04, 2019 at 01:24:46PM -0700, Paul E. McKenney wrote: > > For whatever it is worth, the things on my list include using 25 rounds > > of resched_cpu() on each CPU with ten-jiffy wait between each (instead of > >

Re: [PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-08-05 Thread Eric Dumazet
On 7/29/19 7:23 PM, Cong Wang wrote: > On Mon, Jul 29, 2019 at 1:24 AM Jia-Ju Bai wrote: >> >> In dequeue_func(), there is an if statement on line 74 to check whether >> skb is NULL: >> if (skb) >> >> When skb is NULL, it is used on line 77: >> prefetch(>end); >> >> Thus, a possible

Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-05 Thread Peter Zijlstra
On Sun, Aug 04, 2019 at 11:41:59AM -0700, Paul E. McKenney wrote: > On Sun, Aug 04, 2019 at 04:48:35PM +0200, Peter Zijlstra wrote: > > On Sun, Aug 04, 2019 at 04:43:17PM +0200, Peter Zijlstra wrote: > > > On Fri, Aug 02, 2019 at 08:15:01AM -0700, Paul E. McKenney wrote: > > > > The

Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS

2019-08-05 Thread Vignesh Raghavendra
Hi, On 02/08/19 4:51 PM, Anil Varughese wrote: > Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of > .setup_clock() because if UFSHCD resets the controller ip because > of phy or device related errors then CDNS_UFS_REG_HCLKDIV is > reset to default value and .setup_clock() is not

Re: [PATCH 6/7] mtd: spi-nor: Rework the SPI NOR lock/unlock logic

2019-08-05 Thread Tudor.Ambarus
On 08/04/2019 05:36 PM, Vignesh Raghavendra wrote: > External E-Mail > > > Hi Tudor, > > On 31-Jul-19 2:33 PM, tudor.amba...@microchip.com wrote: >> From: Boris Brezillon >> >> Move the locking hooks in a separate struct so that we have just >> one field to update when we change the locking

[PATCH] power: reset: make reboot-mode user selectable

2019-08-05 Thread Arnd Bergmann
Nandor Han points out that there might be drivers that can use the reboot-mode interfaces but might also be usable on configurations without device tree. Move the 'depends on OF' dependency into CONFIG_REBOOT_MODE since that is the only thing that truely has a compile-time dependency on

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Daniel Lezcano
On 05/08/2019 09:42, Martin Kepplinger wrote: > On 05.08.19 09:39, Daniel Lezcano wrote: >> On 05/08/2019 08:53, Martin Kepplinger wrote: >> >> [ ... ] >> > +static s64 cpuidle_cooling_runtime(struct cpuidle_cooling_device > *idle_cdev) > +{ > + s64 next_wakeup; > + unsigned

[PATCH] Staging : rtl8188eu : rtw_security.c - Fixed warning: coding style issues - Fixed warning: if statement containing return with an else - Fixed check: coding style issues

2019-08-05 Thread merwintf
Signed-off-by: merwintf --- drivers/staging/rtl8188eu/core/rtw_security.c | 525 +++--- 1 file changed, 334 insertions(+), 191 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c index 2f90f60f1681..b9f5ebdae034

Re: [RFC PATCH 02/40] soundwire: cadence_master: add debugfs register dump

2019-08-05 Thread Sanyog Kale
On Thu, Jul 25, 2019 at 06:39:54PM -0500, Pierre-Louis Bossart wrote: > Add debugfs file to dump the Cadence master registers > > Credits: this patch is based on an earlier internal contribution by > Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change > is the use of scnprintf to

Re: [PATCH] power: reset: nvmem-reboot-mode: add CONFIG_OF dependency

2019-08-05 Thread Arnd Bergmann
On Mon, Aug 5, 2019 at 9:10 AM Nandor Han wrote: > > On 7/8/19 3:52 PM, Arnd Bergmann wrote: > > Without CONFIG_OF, we get a build failure in the reboot-mode > > implementation: > > > > drivers/power/reset/reboot-mode.c: In function 'reboot_mode_register': > >

[tip:ras/core] x86/mce: Don't check for the overflow bit on action optional machine checks

2019-08-05 Thread tip-bot for Tony Luck
Commit-ID: aaefca8e30d9df7a4ca13c9c8e135dd227b8ff19 Gitweb: https://git.kernel.org/tip/aaefca8e30d9df7a4ca13c9c8e135dd227b8ff19 Author: Tony Luck AuthorDate: Thu, 18 Jul 2019 11:29:20 -0700 Committer: Borislav Petkov CommitDate: Mon, 5 Aug 2019 09:34:02 +0200 x86/mce: Don't check for

Re: [PATCH v2 0/3] ACPI: New eject flow to remove devices cautiously

2019-08-05 Thread Chester Lin
On Wed, Jul 03, 2019 at 10:14:39AM +, Chester Lin wrote: > Currently there are two ways to handle ACPI device ejection. When an eject > event happens on a container, the kernel just sends KOBJ_CHANGE to > userland and userland should handle offline operation. For other device > types,

Re: [PATCH 3/7] mtd: spi_nor: Rework quad_enable()

2019-08-05 Thread Tudor.Ambarus
On 08/01/2019 09:29 AM, Boris Brezillon wrote: > External E-Mail > > > On Wed, 31 Jul 2019 09:03:31 + > wrote: > >> From: Tudor Ambarus >> >> The goal is to move the quad_enable manufacturer specific init in the >> nor->manufacturer->fixups->default_init() >> >> The legacy/core

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Martin Kepplinger
On 05.08.19 09:39, Daniel Lezcano wrote: > On 05/08/2019 08:53, Martin Kepplinger wrote: > > [ ... ] > +static s64 cpuidle_cooling_runtime(struct cpuidle_cooling_device *idle_cdev) +{ + s64 next_wakeup; + unsigned long state = idle_cdev->state; + + /*

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Martin Kepplinger
On 05.08.19 09:37, Daniel Lezcano wrote: > On 05/08/2019 07:11, Martin Kepplinger wrote: >> --- > > [ ... ] > >>> +static s64 cpuidle_cooling_runtime(struct cpuidle_cooling_device >>> *idle_cdev) >>> +{ >>> + s64 next_wakeup; >>> + unsigned long state = idle_cdev->state; >>> + >>> + /*

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Daniel Lezcano
On 05/08/2019 08:53, Martin Kepplinger wrote: [ ... ] >>> +static s64 cpuidle_cooling_runtime(struct cpuidle_cooling_device >>> *idle_cdev) >>> +{ >>> + s64 next_wakeup; >>> + unsigned long state = idle_cdev->state; >>> + >>> + /* >>> +* The function should not be called when there is

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Daniel Lezcano
On 05/08/2019 07:11, Martin Kepplinger wrote: > --- [ ... ] >> +static s64 cpuidle_cooling_runtime(struct cpuidle_cooling_device *idle_cdev) >> +{ >> +s64 next_wakeup; >> +unsigned long state = idle_cdev->state; >> + >> +/* >> + * The function should not be called when there is

Re: linux-next: Fixes tag needs some work in the arm64-fixes tree

2019-08-05 Thread Masami Hiramatsu
On Sat, 3 Aug 2019 11:15:34 +0100 Catalin Marinas wrote: > On Sat, Aug 03, 2019 at 09:42:12AM +0900, Masami Hiramatsu wrote: > > On Fri, 2 Aug 2019 07:48:13 +1000 > > Stephen Rothwell wrote: > > > In commit > > > > > > 72de4a283cb1 ("arm64: kprobes: Recover pstate.D in single-step > > >

Re: [Linux-stm32] [PATCH V3 1/3] mmc: mmci: fix read status for busy detect

2019-08-05 Thread Ludovic BARRE
hi Ulf On 7/26/19 11:41 AM, Ludovic BARRE wrote: hi Ulf Thanks to your "Clarify comments ..." commit, like is closes I resumed upstream of this series. On 7/15/19 6:31 PM, Ulf Hansson wrote: On Mon, 3 Jun 2019 at 17:55, Ludovic Barre wrote: From: Ludovic Barre "busy_detect_flag" is used

Re: [PATCH 6/6] mtd: spi-nor: Add the SPI_NOR_XSR_RDY flag

2019-08-05 Thread Tudor.Ambarus
On 08/05/2019 08:14 AM, Vignesh Raghavendra wrote: > External E-Mail > > > > On 31/07/19 2:42 PM, tudor.amba...@microchip.com wrote: >> From: Boris Brezillon >> >> S3AN flashes use a specific opcode to read the status register. >> We currently use the SPI_S3AN flag to decide whether this

[PATCH 1/2] ia64: hp-sim: Replace strncmp with str_has_prefix

2019-08-05 Thread Chuhong Yuan
strncmp(str, const, len) is error-prone since the len is easy to be wrong because of counting error or sizeof(const) without - 1. Use the newly introduced str_has_prefix() to substitute it to make code better. Signed-off-by: Chuhong Yuan --- arch/ia64/hp/sim/boot/bootloader.c | 2 +-

Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies

2019-08-05 Thread Vignesh Raghavendra
On 19/07/19 1:59 PM, Vignesh Raghavendra wrote: > On x86_64, when CONFIG_OF is not disabled: > > WARNING: unmet direct dependencies detected for MUX_MMIO > Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n]) > Selected by [y]: > - HBMC_AM654 [=y] && MTD [=y] &&

Re: [PATCH] s390/net: Mark expected switch fall-throughs

2019-08-05 Thread Julian Wiedmann
On 30.07.19 02:17, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: s390): > > drivers/s390/net/ctcm_fsms.c: In function ‘ctcmpc_chx_attnbusy’: > drivers/s390/net/ctcm_fsms.c:1703:6: warning: this

Re: [PATCH v4 09/10] rtc: mt6397: fix alarm register overwrite

2019-08-05 Thread Alexandre Belloni
On 05/08/2019 13:21:57+0800, Hsin-Hsiung Wang wrote: > From: Ran Bi > > Alarm registers high byte was reserved for other functions. > This add mask in alarm registers operation functions. > This also fix error condition in interrupt handler. > > Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397

Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC

2019-08-05 Thread Alexandre Belloni
Hi, The subject should be: "rtc: mt6397: Add support for the MediaTek MT6358 RTC" On 05/08/2019 13:21:58+0800, Hsin-Hsiung Wang wrote: > From: Ran Bi > > This add support for the MediaTek MT6358 RTC. Driver using > compatible data to store different RTC_WRTGR address offset. > > Review-by:

[PATCH v1] gpio: mpc8xxx: Add new platforms GPIO DT node description

2019-08-05 Thread Hui Song
From: Song Hui Update the NXP GPIO node dt-binding file for QorIQ and Layerscape platforms, and add one more example with ls1028a GPIO node. Signed-off-by: Song Hui --- Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-05 Thread Philippe Schenker
On Fri, 2019-08-02 at 10:51 +0200, Stefan Agner wrote: > On 2019-07-31 16:52, Philippe Schenker wrote: > > On Wed, 2019-07-31 at 09:56 -0300, Fabio Estevam wrote: > > > On Wed, Jul 31, 2019 at 9:38 AM Philippe Schenker > > > wrote: > > > > From: Stefan Agner > > > > > > > > Add pinmuxing and do

Re: [PATCH] pinctrl: rzn1: Add of_node_put() before return

2019-08-05 Thread Geert Uytterhoeven
CC Phil On Sun, Aug 4, 2019 at 5:40 PM Nishka Dasgupta wrote: > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return in > three places.

Re: [RFC PATCH v2 10/19] RISC-V: KVM: Handle WFI exits for VCPU

2019-08-05 Thread Anup Patel
On Mon, Aug 5, 2019 at 12:44 PM Paolo Bonzini wrote: > > On 05/08/19 09:12, Anup Patel wrote: > > On Fri, Aug 2, 2019 at 2:33 PM Paolo Bonzini wrote: > >> > >> On 02/08/19 09:47, Anup Patel wrote: > >>> + if (!kvm_riscv_vcpu_has_interrupt(vcpu)) { > >> > >> This can be

Re: [PATCH] power: reset: nvmem-reboot-mode: add CONFIG_OF dependency

2019-08-05 Thread Nandor Han
On 7/8/19 3:52 PM, Arnd Bergmann wrote: Without CONFIG_OF, we get a build failure in the reboot-mode implementation: drivers/power/reset/reboot-mode.c: In function 'reboot_mode_register': drivers/power/reset/reboot-mode.c:72:2: error: implicit declaration of function

Re: [PATCH] habanalabs: Update DRAM consumption on context tear down

2019-08-05 Thread Oded Gabbay
On Sun, Aug 4, 2019 at 10:03 AM Tomer Tayar wrote: > > The patch adds a missing update of the DRAM memory consumption, when a > context is being torn down without an organized release of the allocated > memory. > > Signed-off-by: Tomer Tayar > --- > drivers/misc/habanalabs/memory.c | 2 ++ > 1

[PATCH v4 6/7] perf tools: Add aux-source config term

2019-08-05 Thread Alexander Shishkin
From: Adrian Hunter Expose the aux_source attribute flag to the user to configure, by adding a config term 'aux-source'. For events that support it, selection of 'aux-source' causes the generation of AUX records instead of event records. This requires that an AUX area event is also provided.

[PATCH v4 7/7] perf intel-pt: Add brief documentation for PEBS via Intel PT

2019-08-05 Thread Alexander Shishkin
From: Adrian Hunter Document how to select PEBS via Intel PT and how to display synthesized PEBS samples. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/Documentation/intel-pt.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v4 5/7] perf intel-pt: Process options for PEBS event synthesis

2019-08-05 Thread Alexander Shishkin
From: Adrian Hunter Process synth_opts.other_events and attr.aux_source to set up for synthesizing PEBs via Intel PT events. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/arch/x86/util/intel-pt.c | 23 +++ tools/perf/util/intel-pt.c

[PATCH v4 4/7] perf tools: Add itrace option 'o' to synthesize aux-source events

2019-08-05 Thread Alexander Shishkin
From: Adrian Hunter Add itrace option 'o' to synthesize events recorded in the AUX area due to the use of perf record's aux-source config term. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/Documentation/itrace.txt | 2 ++ tools/perf/util/auxtrace.c |

[PATCH v4 2/7] perf/x86/intel: Support PEBS output to PT

2019-08-05 Thread Alexander Shishkin
If PEBS declares ability to output its data to Intel PT stream, use the aux_source attribute bit to enable PEBS data output to PT. This requires a PT event to be present and scheduled in the same context. Unlike the DS area, the kernel does not extract PEBS records from the PT stream to generate

[PATCH v4 0/7] perf, intel: Add support for PEBS output to Intel PT

2019-08-05 Thread Alexander Shishkin
Hi Peter, Fifth attempt at the PEBS-via-PT feature. The previous ones were [1], [2], [3], [4]. This one addresses review comments in patches 1/7 and 2/7, the tooling patches are intact, but I'm including them anyway. The PEBS feature: output to Intel PT stream instead of the DS area. It's

[PATCH v4 3/7] perf tools: Add aux_source attribute flag

2019-08-05 Thread Alexander Shishkin
From: Adrian Hunter Add aux_source attribute flag to match the kernel's perf_event.h file. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/include/uapi/linux/perf_event.h | 3 ++- tools/perf/util/evsel.c | 1 + 2 files changed, 3 insertions(+), 1

[PATCH v4 1/7] perf: Allow normal events to be sources of AUX data

2019-08-05 Thread Alexander Shishkin
In some cases, ordinary (non-AUX) events can generate data for AUX events. For example, PEBS events can come out as records in the Intel PT stream instead of their usual DS records, if configured to do so. One requirement for such events is to consistently schedule together, to ensure that the

Re: [PATCH] m68k: Prevent some compiler warnings in coldfire builds

2019-08-05 Thread Geert Uytterhoeven
Hi Greg, On Sat, Aug 3, 2019 at 1:36 AM Greg Ungerer wrote: > On 2/8/19 10:10 am, Finn Thain wrote: > > Since commit d3b41b6bb49e ("m68k: Dispatch nvram_ops calls to Atari or > > Mac functions"), Coldfire builds generate compiler warnings due to the > > unconditional inclusion of asm/atarihw.h

Re: [RFC PATCH v2 10/19] RISC-V: KVM: Handle WFI exits for VCPU

2019-08-05 Thread Paolo Bonzini
On 05/08/19 09:12, Anup Patel wrote: > On Fri, Aug 2, 2019 at 2:33 PM Paolo Bonzini wrote: >> >> On 02/08/19 09:47, Anup Patel wrote: >>> + if (!kvm_riscv_vcpu_has_interrupt(vcpu)) { >> >> This can be kvm_arch_vcpu_runnable instead, since kvm_vcpu_block will >> check it anyway before

Re: [PATCH 2/2] habanalabs: Add descriptive name to PSOC app status register

2019-08-05 Thread Oded Gabbay
On Thu, Aug 1, 2019 at 5:28 PM Tomer Tayar wrote: > > Add a meaningful name to the general PSOC application status register > which better describes its usage in keeping the HW state. > > Signed-off-by: Tomer Tayar > --- > drivers/misc/habanalabs/goya/goya.c | 4 ++-- >

Re: [RFC PATCH v2 10/19] RISC-V: KVM: Handle WFI exits for VCPU

2019-08-05 Thread Anup Patel
On Fri, Aug 2, 2019 at 2:33 PM Paolo Bonzini wrote: > > On 02/08/19 09:47, Anup Patel wrote: > > + if (!kvm_riscv_vcpu_has_interrupt(vcpu)) { > > This can be kvm_arch_vcpu_runnable instead, since kvm_vcpu_block will > check it anyway before sleeping. I think we can skip this check

Re: [RFC PATCH v2 07/19] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls

2019-08-05 Thread Paolo Bonzini
On 05/08/19 08:55, Anup Patel wrote: > On Fri, Aug 2, 2019 at 2:33 PM Paolo Bonzini wrote: >> >> On 02/08/19 09:47, Anup Patel wrote: >>> + if (reg_num == KVM_REG_RISCV_CSR_REG(sip)) >>> + kvm_riscv_vcpu_flush_interrupts(vcpu, false); >> >> Not updating the vsip CSR here can cause

[PATCH] arm64: dts: ls1028a: fix gpio nodes

2019-08-05 Thread Hui Song
From: Song Hui Update the nodes to include little-endian property to be consistent with the hardware. Signed-off-by: Song Hui --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

RE: [PATCH V3 4/5] thermal: qoriq: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

2019-08-05 Thread Aisheng Dong
> From: anson.hu...@nxp.com > Sent: Tuesday, July 30, 2019 10:21 AM > > Use __maybe_unused for power management related functions instead of #if > CONFIG_PM_SLEEP to simply the code. > > Signed-off-by: Anson Huang Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V3 5/5] dt-bindings: thermal: qoriq: Add optional clocks property

2019-08-05 Thread Aisheng Dong
> From: anson.hu...@nxp.com > Sent: Tuesday, July 30, 2019 10:21 AM > > Some platforms like i.MX8M series SoCs have clock control for TMU, add > optional clocks property to the binding doc. > > Signed-off-by: Anson Huang > Reviewed-by: Rob Herring Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V3 2/5] thermal: qoriq: Fix error path of calling qoriq_tmu_register_tmu_zone fail

2019-08-05 Thread Aisheng Dong
> From: anson.hu...@nxp.com > Sent: Tuesday, July 30, 2019 10:21 AM > > When registering tmu zone failed, the error path should be err_tmu instead of > err_iomap, as iounmap() needs to be called. > > Signed-off-by: Anson Huang Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V3 3/5] thermal: qoriq: Use devm_platform_ioremap_resource() instead of of_iomap()

2019-08-05 Thread Aisheng Dong
> From: anson.hu...@nxp.com > Sent: Tuesday, July 30, 2019 10:21 AM > > Use devm_platform_ioremap_resource() instead of of_iomap() to save the > iounmap() call in error handle path; > > Signed-off-by: Anson Huang Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-05 Thread Aisheng Dong
> From: Anson Huang > > Some platforms like i.MX8MQ has clock control for this module, need to add > clock operations to make sure the driver is working properly. > > Signed-off-by: Anson Huang > Reviewed-by: Guido Günther Reviewed-by: Dong Aisheng Regards Aisheng

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

2019-08-05 Thread Chuhong Yuan
On Mon, Aug 5, 2019 at 2:13 PM Leon Romanovsky wrote: > > On Sun, Aug 04, 2019 at 10:44:47PM +0800, Chuhong Yuan wrote: > > On Sun, Aug 4, 2019 at 8:59 PM Leon Romanovsky wrote: > > > > > > On Sat, Aug 03, 2019 at 12:48:28AM +0800, Chuhong Yuan wrote: > > > > refcount_t is better for reference

Re: [RFC PATCH v2 07/19] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls

2019-08-05 Thread Anup Patel
On Fri, Aug 2, 2019 at 2:33 PM Paolo Bonzini wrote: > > On 02/08/19 09:47, Anup Patel wrote: > > + if (reg_num == KVM_REG_RISCV_CSR_REG(sip)) > > + kvm_riscv_vcpu_flush_interrupts(vcpu, false); > > Not updating the vsip CSR here can cause an interrupt to be lost, if the > next

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2019-08-05 Thread Martin Kepplinger
On 05.08.19 07:11, Martin Kepplinger wrote: > --- > > On 05-04-18, 18:16, Daniel Lezcano wrote: >> The cpu idle cooling driver performs synchronized idle injection across all >> cpus belonging to the same cluster and offers a new method to cool down a >> SoC. >> >> Each cluster has its own idle

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Benjamin Herrenschmidt
On Tue, 2019-07-30 at 13:28 -0700, Benjamin Herrenschmidt wrote: > > One problem is that we've an nvme parameter, io_queue_depth, that a user > > could set to something less than 32, and then you won't be able to do > > any IO. I'd recommend enforce the admin queue to QD1 for this device so > >

[PATCH v4 02/10] powerpc: move memstart_addr and kernstart_addr to init-common.c

2019-08-05 Thread Jason Yan
These two variables are both defined in init_32.c and init_64.c. Move them to init-common.c. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Christophe Leroy

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-08-05 Thread Tudor.Ambarus
On 08/01/2019 09:42 AM, Boris Brezillon wrote: > Almost all of this (except the s3an specific bits) should be done in > the previous patch. So I'll put a condition on the R-b I placed on patch > 4: some of this code should be moved there. You're right, will do. Cheers, ta

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 12:41:45PM +0800, Jason Wang wrote: > > On 2019/8/5 下午12:36, Jason Wang wrote: > > > > On 2019/8/2 下午10:27, Michael S. Tsirkin wrote: > > > On Fri, Aug 02, 2019 at 09:46:13AM -0300, Jason Gunthorpe wrote: > > > > On Fri, Aug 02, 2019 at 05:40:07PM +0800, Jason Wang wrote:

Re: [PATCH] mtd: spi-nor: Fix the disabling of write protection at init

2019-08-05 Thread Vignesh Raghavendra
On 31/07/19 2:16 PM, tudor.amba...@microchip.com wrote: > From: Tudor Ambarus > > spi_nor_spansion_clear_sr_bp() depends on spansion_quad_enable(). > While spansion_quad_enable() is selected as default when > initializing the flash parameters, the nor->quad_enable() method > can be

Re: [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-05 Thread Tao Ren
Hi Andrew, On 8/4/19 7:51 AM, Andrew Lunn wrote: >>> The patchset looks better now. But is it ok, I wonder, to keep >>> PHY_BCM_FLAGS_MODE_1000BX in phydev->dev_flags, considering that >>> phy_attach_direct is overwriting it? >> > >> I checked ftgmac100 driver (used on my machine) and it calls

[PATCH v2 3/3] bfq: Add per-device weight

2019-08-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/bfq-cgroup.c | 95 ++--- block/bfq-iosched.h | 3 ++ 2 files changed, 87 insertions(+), 11 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index 28e5a9241237..de4fd8b725aa 100644 ---

[PATCH v2 0/3] Implement BFQ per-device weight interface

2019-08-05 Thread Fam Zheng
(Revision starting from v2 since v1 was used off-list) Hi Paolo and others, This adds to BFQ the missing per-device weight interfaces: blkio.bfq.weight_device on legacy and io.bfq.weight on unified. The implementation pretty closely resembles what we had in CFQ and the parsing code is basically

Re: [PATCH 4/6] mtd: spi_nor: Add nor->setup() method

2019-08-05 Thread Tudor.Ambarus
On 08/01/2019 09:36 AM, Boris Brezillon wrote: > On Wed, 31 Jul 2019 09:12:14 + > wrote: > > >> static inline bool spi_nor_protocol_is_dtr(enum spi_nor_protocol proto) >> { >> return !!(proto & SNOR_PROTO_IS_DTR); >> @@ -384,6 +522,7 @@ struct flash_info; >> *

Re: [PATCH 1/1] arm64: dts: sdm845: Add device node for Last level cache controller

2019-08-05 Thread Vivek Gautam
Hi Bjorn, On Wed, Jul 10, 2019 at 5:09 PM Vivek Gautam wrote: > > From: Sai Prakash Ranjan > > Last level cache (aka. system cache) controller provides control > over the last level cache present on SDM845. This cache lies after > the memory noc, right before the DDR. > > Signed-off-by: Sai

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 12:36:40PM +0800, Jason Wang wrote: > > On 2019/8/2 下午10:27, Michael S. Tsirkin wrote: > > On Fri, Aug 02, 2019 at 09:46:13AM -0300, Jason Gunthorpe wrote: > > > On Fri, Aug 02, 2019 at 05:40:07PM +0800, Jason Wang wrote: > > > > > This must be a proper barrier, like a

Re: [PATCH 2/5] mtd: spi-nor: group the code about the write protection at power-up

2019-08-05 Thread Tudor.Ambarus
On 08/05/2019 08:44 AM, Vignesh Raghavendra wrote: >> From: Tudor Ambarus >> >> The write protection at power-up logic was split across functions >> because of a dependency to spansion_quad_enable(). Group the code >> in spi_nor_init() as the pointer to spansion_quad_enable() can be >>

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 12:33:45PM +0800, Jason Wang wrote: > > On 2019/8/2 下午10:03, Michael S. Tsirkin wrote: > > On Fri, Aug 02, 2019 at 05:40:07PM +0800, Jason Wang wrote: > > > Btw, I come up another idea, that is to disable preemption when vhost > > > thread > > > need to access the memory.

[PATCH v4 09/10] powerpc/fsl_booke/kaslr: support nokaslr cmdline parameter

2019-08-05 Thread Jason Yan
One may want to disable kaslr when boot, so provide a cmdline parameter 'nokaslr' to support this. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Diana

[PATCH v4 06/10] powerpc/fsl_booke/32: implement KASLR infrastructure

2019-08-05 Thread Jason Yan
This patch add support to boot kernel from places other than KERNELBASE. Since CONFIG_RELOCATABLE has already supported, what we need to do is map or copy kernel to a proper place and relocate. Freescale Book-E parts expect lowmem to be mapped by fixed TLB entries(TLB1). The TLB1 entries are not

[PATCH v4 08/10] powerpc/fsl_booke/kaslr: clear the original kernel if randomized

2019-08-05 Thread Jason Yan
The original kernel still exists in the memory, clear it now. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Christophe Leroy Reviewed-by: Diana Craciun

[PATCH v4 04/10] powerpc/fsl_booke/32: introduce create_tlb_entry() helper

2019-08-05 Thread Jason Yan
Add a new helper create_tlb_entry() to create a tlb entry by the virtual and physical address. This is a preparation to support boot kernel at a randomized address. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul

[PATCH v4 01/10] powerpc: unify definition of M_IF_NEEDED

2019-08-05 Thread Jason Yan
M_IF_NEEDED is defined too many times. Move it to a common place. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Christophe Leroy Reviewed-by: Diana Craciun

[PATCH v4 05/10] powerpc/fsl_booke/32: introduce reloc_kernel_entry() helper

2019-08-05 Thread Jason Yan
Add a new helper reloc_kernel_entry() to jump back to the start of the new kernel. After we put the new kernel in a randomized place we can use this new helper to enter the kernel and begin to relocate again. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy

[PATCH v4 03/10] powerpc: introduce kimage_vaddr to store the kernel base

2019-08-05 Thread Jason Yan
Now the kernel base is a fixed value - KERNELBASE. To support KASLR, we need a variable to store the kernel base. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook

[PATCH v4 10/10] powerpc/fsl_booke/kaslr: dump out kernel offset information on panic

2019-08-05 Thread Jason Yan
When kaslr is enabled, the kernel offset is different for every boot. This brings some difficult to debug the kernel. Dump out the kernel offset when panic so that we can easily debug the kernel. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin

[PATCH v4 00/10] implement KASLR for powerpc/fsl_booke/32

2019-08-05 Thread Jason Yan
This series implements KASLR for powerpc/fsl_booke/32, as a security feature that deters exploit attempts relying on knowledge of the location of kernel internals. Since CONFIG_RELOCATABLE has already supported, what we need to do is map or copy kernel to a proper place and relocate. Freescale

[PATCH v4 07/10] powerpc/fsl_booke/32: randomize the kernel image offset

2019-08-05 Thread Jason Yan
After we have the basic support of relocate the kernel in some appropriate place, we can start to randomize the offset now. Entropy is derived from the banner and timer, which will change every build and boot. This not so much safe so additionally the bootloader may pass entropy via the

[PATCH v7 7/7] powerpc: add machine check safe copy_to_user

2019-08-05 Thread Santosh Sivaraj
Use memcpy_mcsafe() implementation to define copy_to_user_mcsafe() Signed-off-by: Santosh Sivaraj --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/uaccess.h | 14 ++ 2 files changed, 15 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig

[PATCH v7 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe

2019-08-05 Thread Santosh Sivaraj
If we take a UE on one of the instructions with a fixup entry, set nip to continue execution at the fixup entry. Stop processing the event further or print it. Based-on-patch-by: Reza Arbab Cc: Reza Arbab Cc: Mahesh Salgaonkar Signed-off-by: Santosh Sivaraj --- arch/powerpc/include/asm/mce.h

[PATCH v7 3/7] powerpc/mce: Fix MCE handling for huge pages

2019-08-05 Thread Santosh Sivaraj
From: Balbir Singh The current code would fail on huge pages addresses, since the shift would be incorrect. Use the correct page shift value returned by __find_linux_pte() to get the correct physical address. The code is more generic and can handle both regular and compound pages. Fixes:

[PATCH v7 4/7] extable: Add function to search only kernel exception table

2019-08-05 Thread Santosh Sivaraj
Certain architecture specific operating modes (e.g., in powerpc machine check handler that is unable to access vmalloc memory), the search_exception_tables cannot be called because it also searches the module exception tables if entry is not found in the kernel exception table. Cc: Thomas

Re: [PATCH] scsi: 3w-sas: Fix unterminated strncpy

2019-08-05 Thread Chuhong Yuan
On Tue, Jul 30, 2019 at 10:56 PM James Bottomley wrote: > > On Tue, 2019-07-30 at 16:40 +0800, Chuhong Yuan wrote: > > strncpy(dest, src, strlen(src)) leads to unterminated > > dest, which is dangerous. > > I don't buy that. The structure is only used for the > TW_IOCTL_GET_COMPATIBILITY_INFO

[PATCH v7 0/7] powerpc: implement machine check safe memcpy

2019-08-05 Thread Santosh Sivaraj
During a memcpy from a pmem device, if a machine check exception is generated we end up in a panic. In case of fsdax read, this should only result in a -EIO. Avoid MCE by implementing memcpy_mcsafe. Before this patch series: ``` bash-4.4# mount -o dax /dev/pmem0 /mnt/pmem/ [ 7621.714094]

[PATCH v7 1/7] powerpc/mce: Schedule work from irq_work

2019-08-05 Thread Santosh Sivaraj
schedule_work() cannot be called from MCE exception context as MCE can interrupt even in interrupt disabled context. fixes: 733e4a4c ("powerpc/mce: hookup memory_failure for UE errors") Signed-off-by: Santosh Sivaraj --- arch/powerpc/kernel/mce.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v7 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem

2019-08-05 Thread Santosh Sivaraj
From: Balbir Singh The pmem infrastructure uses memcpy_mcsafe in the pmem layer so as to convert machine check exceptions into a return value on failure in case a machine check exception is encountered during the memcpy. The return value is the number of bytes remaining to be copied. This patch

[PATCH v7 2/7] powerpc/mce: Make machine_check_ue_event() static

2019-08-05 Thread Santosh Sivaraj
From: Reza Arbab The function doesn't get used outside this file, so make it static. Signed-off-by: Reza Arbab Signed-off-by: Santosh Sivaraj Reviewed-by: Nicholas Piggin --- arch/powerpc/kernel/mce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/5] mtd: spi-nor: add Global Block Unlock support

2019-08-05 Thread Vignesh Raghavendra
On 17/07/19 2:18 PM, tudor.amba...@microchip.com wrote: > From: Tudor Ambarus > > To avoid inadvertent writes during power-up, some flashes are > write-protected by default after a power-on reset cycle. > A Global Block-Protection Unlock command offers a single > command cycle that unlocks

Re: [RFC PATCH 1/2] dt-bindings: net: macb: Add new property for PS SGMII only

2019-08-05 Thread Harini Katakam
Hi Andrew, On Sun, Aug 4, 2019 at 8:26 PM Andrew Lunn wrote: > > On Wed, Jul 31, 2019 at 03:10:32PM +0530, Harini Katakam wrote: > > Add a new property to indicate when PS SGMII is used with NO > > external PHY on board. > > Hi Harini > > What exactly is you use case? Are you connecting to a

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

2019-08-05 Thread Leon Romanovsky
On Sun, Aug 04, 2019 at 10:44:47PM +0800, Chuhong Yuan wrote: > On Sun, Aug 4, 2019 at 8:59 PM Leon Romanovsky wrote: > > > > On Sat, Aug 03, 2019 at 12:48:28AM +0800, Chuhong Yuan wrote: > > > refcount_t is better for reference counters since its > > > implementation can prevent overflows. > > >

linux-next: Tree for Aug 5

2019-08-05 Thread Stephen Rothwell
Hi all, Changes since 20190802: The crypto tree gained a build failure for which I applied a patch. Non-merge commits (relative to Linus' tree): 3992 4485 files changed, 238294 insertions(+), 107183 deletions(-) I

Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return

2019-08-05 Thread Vivek Gautam
On Sun, Aug 4, 2019 at 9:54 PM Nishka Dasgupta wrote: > > Each iteration of for_each_available_child_of_node puts the previous > node, but in the case of a return from the middle of the loop, there is > no put, thus causing a memory leak. Hence add an of_node_put before the > return in two

Re: [PATCH v6 0/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 09:29:28AM +0530, Ajay Kaher wrote: > coredump: fix race condition between mmget_not_zero()/get_task_mm() > and core dumping > > [PATCH v5 1/3]: > Backporting of commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream. > > [PATCH v5 2/3]: > Extension of commit

<    8   9   10   11   12   13