[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Flipkart

2025-06-23 Thread Cristian Cozzolino via B4 Relay
From: Cristian Cozzolino Add Flipkart to the vendor prefixes. Signed-off-by: Cristian Cozzolino --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bi

[PATCH v2 2/3] dt-bindings: arm: qcom: Add Billion Capture+

2025-06-23 Thread Cristian Cozzolino via B4 Relay
From: Cristian Cozzolino Billion Capture+ (flipkart,rimob) is a smartphone based on Qualcomm Snapdragon 625 (MSM8953). Signed-off-by: Cristian Cozzolino --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm

[PATCH v2 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-23 Thread Cristian Cozzolino via B4 Relay
From: Cristian Cozzolino Billion Capture+ (flipkart,rimob) is a smartphone released in 2017, based on Snapdragon 625 (MSM8953) SoC. Add a device tree with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - Regulators - Simple framebuffer Signed-off-by:

[PATCH v2 0/3] Add initial device tree for Billion Capture+

2025-06-23 Thread Cristian Cozzolino via B4 Relay
Billion Capture+ is a handset using the MSM8953 SoC released in 2017 and sold by Flipkart. Add a device tree with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - Regulators - Simple framebuffer Signed-off-by: Cristian Cozzolino --- Changes in v2: - (

Re: [PATCH v3] rust: kunit: use crate-level mapping for `c_void`

2025-06-23 Thread Miguel Ojeda
On Wed, May 28, 2025 at 7:51 PM Jesung Yang wrote: > > Remove `use core::ffi::c_void`, which shadows `kernel::ffi::c_void` > brought in via `use crate::prelude::*`, to maintain consistency and > centralize the abstraction. > > Since `kernel::ffi::c_void` is a straightforward re-export of > `core::

[PATCH] selftests: ptrace: add set_syscall_info to .gitignore

2025-06-23 Thread Moon Hee Lee
Add the set_syscall_info test binary to .gitignore to avoid tracking build artifacts in the ptrace selftests directory. Signed-off-by: Moon Hee Lee --- tools/testing/selftests/ptrace/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/ptrace/.gitignore b/tools

Re: [PATCH 3/4] selftests/nolibc: rename Makefile

2025-06-23 Thread Thomas Weißschuh
On 2025-06-21 10:47:39+0200, Willy Tarreau wrote: > On Sat, Jun 21, 2025 at 10:34:38AM +0200, Thomas Weißschuh wrote: > > On 2025-06-21 06:14:21+0200, Willy Tarreau wrote: > > > Hi Thomas, > > > > > > On Fri, Jun 20, 2025 at 11:39:32PM +0200, Thomas Weißschuh wrote: > > > > The nolibc tests are no

[PATCH v2 3/3] tools/nolibc: add support for SuperH

2025-06-23 Thread Thomas Weißschuh
Add support for SuperH/"sh" to nolibc. Only sh4 is tested for now. The startup code is special: __nolibc_entrypoint_epilogue() calls __builtin_unreachable() which emits a call to abort(). To make this work a function prologue is generated to set up a GOT pointer which corrupts "sp". __builtin_unr

Re: [PATCH] selftests/nolibc: avoid GCC 15 -Wunterminated-string-initialization

2025-06-23 Thread Willy Tarreau
On Mon, Jun 23, 2025 at 11:34:32PM +0200, Thomas Weißschuh wrote: > On GCC 15 the following warnings is emitted: > > nolibc-test.c: In function 'run_stdlib': > nolibc-test.c:1416:32: warning: initializer-string for array of 'char' > truncates NUL terminator but destination lacks 'nonstring' attri

[PATCH v3 3/4] tools/nolibc: MIPS: drop noreorder option

2025-06-23 Thread Thomas Weißschuh
There are no more statements in the assembly code which would require the usage of ".set noreorder". Remove the option. This also allows removal of the manual "nop" instruction in the delay slot. Suggested-by: Maciej W. Rozycki Link: https://lore.kernel.org/lkml/alpine.deb.2.21.2502172208570.6

[PATCH] selftests/nolibc: avoid GCC 15 -Wunterminated-string-initialization

2025-06-23 Thread Thomas Weißschuh
buf[4] = '\0'; --- base-commit: eb135311083100b6590a7545618cd9760d896a86 change-id: 20250623-nolibc-nonstring-7fe6974552b5 Best regards, -- Thomas Weißschuh

[PATCH v2 1/3] selftests/nolibc: fix EXTRACONFIG variables ordering

2025-06-23 Thread Thomas Weißschuh
The variable block got disordered at some point. Use the correct ordering. Signed-off-by: Thomas Weißschuh Acked-by: Willy Tarreau --- tools/testing/selftests/nolibc/Makefile.nolibc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/nolibc/Makefile.

[PATCH v3 2/4] tools/nolibc: MIPS: drop manual stack pointer alignment

2025-06-23 Thread Thomas Weißschuh
The stack pointer is already aligned by the kernel to a multiple of 16. All modifications of the register have been removed from the entrypoint, so the manual realignment is unnecessary. Drop the manual alignment. Suggested-by: Maciej W. Rozycki Link: https://lore.kernel.org/lkml/alpine.deb.2.2

[PATCH v3 1/4] tools/nolibc: MIPS: drop $gp setup

2025-06-23 Thread Thomas Weißschuh
The setup of the global pointer "$gp" register was necessary when the C entrypoint was called through "jal ". However since commit 0daf8c86a451 ("tools/nolibc: mips: load current function to $t9") "jalr" is used instead which does not require "$gp". Remove the unnecessary $gp setup, simplifying t

[PATCH v3 4/4] tools/nolibc: MIPS: add support for N64 and N32 ABIs

2025-06-23 Thread Thomas Weißschuh
Add support for the MIPS 64bit N64 and ILP32 N32 ABIs. In addition to different byte orders and ABIs there are also different releases of the MIPS architecture. To avoid blowing up the test matrix, only add a subset of all possible test combinations. Signed-off-by: Thomas Weißschuh Tested-by: Se

[PATCH v3 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs

2025-06-23 Thread Thomas Weißschuh
Introduce support for the N32 and N64 ABIs. As preparation, the entrypoint is first simplified significantly. Thanks to Maciej for all the valuable information. Signed-off-by: Thomas Weißschuh --- Changes in v3: - Rebase onto latest nolibc-next - Link to v2: https://lore.kernel.org/r/20250225-no

[PATCH v2 2/3] selftests/nolibc: use file driver for QEMU serial

2025-06-23 Thread Thomas Weißschuh
For the test implementation of the SuperH architecture a second serial serial port needs to be used. Unfortunately the currently used 'stdio' driver does not support multiple serial ports at the same time. Switch to the 'file' driver which does support multiple ports and is sufficient for the noli

[PATCH v2 0/3] tools/nolibc: add support for SuperH

2025-06-23 Thread Thomas Weißschuh
Add support for SuperH/"sh" to nolibc. Only sh4 is tested for now. This is only tested on QEMU so far. Additional testing would be very welcome. Test instructions: $ cd tools/testings/selftests/nolibc/ $ make -f Makefile.nolibc ARCH=sh CROSS_COMPILE=sh4-linux- nolibc-test $ file nolibc-test nolibc

Re: [PATCH 3/4] selftests/nolibc: rename Makefile

2025-06-23 Thread Willy Tarreau
Hi Thomas, On Mon, Jun 23, 2025 at 10:18:19PM +0200, Thomas Weißschuh wrote: (...) > > I hadn't thought about this, but that could indeed make sense. Let's see > > later how it goes and let's not add burden about this for now. Please just > > keep your patch as-is. > > Sounds good. Could you give

Re: [PATCH RFC 03/14] mm: compare pfns only if the entry is present when inserting pfns/pages

2025-06-23 Thread David Hildenbrand
On 20.06.25 15:27, Oscar Salvador wrote: On Tue, Jun 17, 2025 at 05:43:34PM +0200, David Hildenbrand wrote: Doing a pte_pfn() etc. of something that is not a present page table entry is wrong. Let's check in all relevant cases where we want to upgrade write permissions when inserting pfns/pages

Re: [PATCH RFC 03/14] mm: compare pfns only if the entry is present when inserting pfns/pages

2025-06-23 Thread David Hildenbrand
On 20.06.25 20:24, Pedro Falcato wrote: On Tue, Jun 17, 2025 at 05:43:34PM +0200, David Hildenbrand wrote: Doing a pte_pfn() etc. of something that is not a present page table entry is wrong. Let's check in all relevant cases where we want to upgrade write permissions when inserting pfns/pages w

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-23 Thread Breno Leitao
On Mon, Jun 23, 2025 at 10:29:03AM -0700, Jakub Kicinski wrote: > On Mon, 23 Jun 2025 02:16:12 -0700 Breno Leitao wrote: > > So, the selftest for netpoll is already in the mailing list[1], so, we > > have two options, now: > > > > 1) Steal your patch and make [1] depend on it. > > 2) Merge the

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-23 Thread Jakub Kicinski
On Mon, 23 Jun 2025 02:16:12 -0700 Breno Leitao wrote: > So, the selftest for netpoll is already in the mailing list[1], so, we > have two options, now: > > 1) Steal your patch and make [1] depend on it. > 2) Merge the selftest [1] and, then, steal your patch by adding the > bpftrace supp

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-23 Thread Donet Tom
On Mon, Jun 23, 2025 at 10:23:02AM +0530, Dev Jain wrote: > > On 21/06/25 11:25 pm, Donet Tom wrote: > > On Fri, Jun 20, 2025 at 08:15:25PM +0530, Dev Jain wrote: > > > On 19/06/25 1:53 pm, Donet Tom wrote: > > > > On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: > > > > > On 18/06/25 8:0

Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains

2025-06-23 Thread Luca Weiss
On 23-06-2025 2:39 p.m., Konrad Dybcio wrote: On 6/21/25 3:19 PM, Luca Weiss wrote: Due to historical reasons all msm8974 boards have used the CX power rail as regulator instead of going through the power domain framework. Since rpmpd has gained msm8974 support quite a bit ago, let's start usin

Re: [PATCH bpf-next] selftests/bpf: Support ppc64el in vmtest

2025-06-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Thu, 19 Jun 2025 16:08:53 +0200 you wrote: > With a rootfs built using libbpf's BPF CI [1], we can run specific tests > as follows: > > $ ../libbpf-ci/rootfs/mkrootfs_debian.sh --arch ppc64el --distro noble > $

Re: [PATCH] ASoC: qcom: sm8250: Fix possibly undefined reference

2025-06-23 Thread Mark Brown
On Tue, 17 Jun 2025 14:20:12 +0200, Luca Weiss wrote: > With CONFIG_SND_SOC_SM8250=y and CONFIG_SND_SOC_QCOM_OFFLOAD_UTILS=m > selected in kconfig, the build will fail due to trying to link against a > symbol only found in the module. > > aarch64-linux-gnu-ld: sound/soc/qcom/sm8250.o: in functio

Re: [PATCH v3] remoteproc: xlnx: allow single core use in split mode

2025-06-23 Thread Mathieu Poirier
On Wed, Jun 18, 2025 at 11:19:33AM -0700, Tanmay Shah wrote: > When operating in split mode, it is a valid usecase to have > only one core enabled in the cluster. Remove exact core count > expecatation from the driver. > > Signed-off-by: Tanmay Shah > --- > > Changes in v3: > - Fix commit mess

Re: [PATCH v5 0/3] remoteproc: imx_rproc: allow attaching to running core kicked by the bootloader

2025-06-23 Thread Mathieu Poirier
On Tue, Jun 17, 2025 at 04:34:47PM -0300, Hiago De Franco wrote: > From: Hiago De Franco > > This patch series depends on Ulf's patches that are currently under > review, "pmdomain: Add generic ->sync_state() support to genpd" [1]. > Without them, this series is not going to work. Please resend

Re: [PATCH v5 3/3] remoteproc: imx_rproc: detect and attach to pre-booted remote cores

2025-06-23 Thread Mathieu Poirier
On Tue, Jun 17, 2025 at 04:34:50PM -0300, Hiago De Franco wrote: > From: Hiago De Franco > > When the remote core is started before Linux boots (e.g., by the > bootloader), the driver currently is not able to attach because it only > checks for cores running in different partitions. If the core w

Re: [PATCH v5 2/3] remoteproc: imx_rproc: skip clock enable when M-core is managed by the SCU

2025-06-23 Thread Mathieu Poirier
Hi Hiago, On Tue, Jun 17, 2025 at 04:34:49PM -0300, Hiago De Franco wrote: > From: Hiago De Franco > > For the i.MX8X and i.MX8 family SoCs, when the M-core is powered up > by the bootloader, M-core and Linux are in same SCFW (System Controller > Firmware) partition, so linux has permission to c

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Benno Lossin
On Mon Jun 23, 2025 at 4:31 PM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: > >> On Mon Jun 23, 2025 at 11:44 AM CEST, Andreas Hindborg wrote: >>> "Benno Lossin" writes: >>> On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: >> On Thu Jun

Re: [PATCH 1/2] remoteproc: imx_dsp_rproc: Add support of recovery process

2025-06-23 Thread Mathieu Poirier
Good day, On Wed, Jun 18, 2025 at 02:26:43PM +0800, Shengjiu Wang wrote: > when recovery is triggered, rproc_stop() is called first then > rproc_start(), but there is no rproc_unprepare_device() and > rproc_prepare_device() in the flow. > > So power enablement needs to be moved from prepare callb

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-23 Thread Konrad Dybcio
On 6/23/25 4:49 PM, cristian_ci wrote: > On Monday, June 23rd, 2025 at 12:11, Konrad Dybcio > wrote: > >> On 6/21/25 9:31 PM, cristian_ci wrote: >> >>> On Saturday, June 21st, 2025 at 12:17, Konrad Dybcio >>> konrad.dyb...@oss.qualcomm.com wrote: >>> > + > +&sdhc_1 { > + vmmc-supply

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-23 Thread cristian_ci
On Monday, June 23rd, 2025 at 12:11, Konrad Dybcio wrote: > On 6/21/25 9:31 PM, cristian_ci wrote: > > > On Saturday, June 21st, 2025 at 12:17, Konrad Dybcio > > konrad.dyb...@oss.qualcomm.com wrote: > > > > > > + > > > > +&sdhc_1 { > > > > + vmmc-supply = <&pm8953_l8>; > > > > + vqmmc-supply

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-23 Thread Krzysztof Kozlowski
On 06/06/2025 03:55, Peng Fan (OSS) wrote: >fsl,entry-address: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > @@ -78,6 +85,12 @@ properties: > description: >Phandle to IOMUXC GPR block which provide access to CM7 CPUWAIT bit. > > + fsl,lmm-id: > +

Re: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread Lorenzo Stoakes
On Mon, Jun 23, 2025 at 10:36:48PM +0800, wang lian wrote: > I deeply appreciate for your criticism. This is my first patch and I will > improve it based on what we have discussed so far. Sorry if it seemed harsh, I appreciate the first patch can be difficult (I still remember mine!) but hopefull

Re: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread wang lian
I deeply appreciate for your criticism. This is my first patch and I will improve it based on what we have discussed so far.

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Andreas Hindborg
"Benno Lossin" writes: > On Mon Jun 23, 2025 at 11:44 AM CEST, Andreas Hindborg wrote: >> "Benno Lossin" writes: >> >>> On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: "Benno Lossin" writes: > On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >> +/// A wrapp

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-06-23 Thread Marc Zyngier
On Mon, 23 Jun 2025 11:31:32 +0100, Ganapatrao Kulkarni wrote: > > On 6/19/2025 5:15 PM, Marc Zyngier wrote: > >> > > >>> Also, running EL2 is the least of our worries, because that's pretty > >>> easy to deal with. It is running at EL1/0 when EL2 is present that is > >>> interesting, and I see

Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page()

2025-06-23 Thread David Hildenbrand
On 20.06.25 14:50, Oscar Salvador wrote: On Tue, Jun 17, 2025 at 05:43:32PM +0200, David Hildenbrand wrote: In 2009, we converted a VM_BUG_ON(!pfn_valid(pfn)) to the current highest_memmap_pfn sanity check in commit 22b31eec63e5 ("badpage: vm_normal_page use print_bad_pte"), because highest_memm

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Benno Lossin
On Mon Jun 23, 2025 at 2:37 PM CEST, Miguel Ojeda wrote: > On Mon, Jun 23, 2025 at 1:48 PM Benno Lossin wrote: >> >> Another way would be to use a `Once`-like type (does that exist on the C >> side?) so a type that can be initialized once and then never changes. > > There are `DO_ONCE{,_SLEEPABLE,

Re: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread Lorenzo Stoakes
On Mon, Jun 23, 2025 at 03:49:05PM +0200, David Hildenbrand wrote: > On 23.06.25 14:35, Lorenzo Stoakes wrote: > > +cc Liam, David, Vlastimil, Jann > > > > (it might not be obvious from get_maintainers.pl but please cc > > maintainers/reviewers of the thing you are adding a test for, thanks!) > > >

Re: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread David Hildenbrand
On 23.06.25 14:35, Lorenzo Stoakes wrote: +cc Liam, David, Vlastimil, Jann (it might not be obvious from get_maintainers.pl but please cc maintainers/reviewers of the thing you are adding a test for, thanks!) Overall I'm not in favour of us taking this patch. There are a number of issues with

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-23 Thread Dmitry Vyukov
Nice! A bag of assorted comments: 1. I share the same concern of duplicating info. If there are lots of duplication it may lead to failure of the whole effort since folks won't update these and/or they will get out of sync. If a syscall arg is e.g. umode_t, we already know that it's an integer of

Re: [PATCH 1/2] filemap: Add a mempolicy argument to filemap_alloc_folio()

2025-06-23 Thread Vlastimil Babka
On 6/20/25 16:34, Matthew Wilcox (Oracle) wrote: > guest_memfd needs to support memory policies so add an argument > to filemap_alloc_folio(). All existing users pass NULL, the first > user will show up later in this series. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babk

Re: Subject: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread Lorenzo Stoakes
On Sat, Jun 21, 2025 at 05:08:18PM +0530, Dev Jain wrote: > > On 21/06/25 4:40 pm, wang lian wrote: > > From cb505647eb5f418d1ff5e807361f4c3a337c251f Mon Sep 17 00:00:00 2001 > > From: Lian Wang > > Date: Sat, 21 Jun 2025 18:51:49 +0800 > > Subject: [PATCH] selftests/mm: add test for (BATCH_PROCES

Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains

2025-06-23 Thread Konrad Dybcio
On 6/21/25 3:19 PM, Luca Weiss wrote: > Due to historical reasons all msm8974 boards have used the CX power rail > as regulator instead of going through the power domain framework. > > Since rpmpd has gained msm8974 support quite a bit ago, let's start > using it and replace all usages of pm8841_s

Re: [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED

2025-06-23 Thread Lorenzo Stoakes
+cc Liam, David, Vlastimil, Jann (it might not be obvious from get_maintainers.pl but please cc maintainers/reviewers of the thing you are adding a test for, thanks!) Overall I'm not in favour of us taking this patch. There are a number of issues with it (explained inline below), but those aside

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Miguel Ojeda
On Mon, Jun 23, 2025 at 1:48 PM Benno Lossin wrote: > > Another way would be to use a `Once`-like type (does that exist on the C > side?) so a type that can be initialized once and then never changes. There are `DO_ONCE{,_SLEEPABLE,_LITE}`. Cheers, Miguel

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Shivank Garg
On 6/23/2025 12:13 AM, Andrew Morton wrote: > On Fri, 20 Jun 2025 17:53:15 +0100 Matthew Wilcox wrote: > >> On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote: >>> +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, >>> + pgoff_t index, fgf_t f

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
On Mon, Jun 23, 2025 at 12:22 PM Muhammad Usama Anjum wrote: > > On 6/20/25 7:55 PM, Chen Linxuan wrote: > > On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum > > wrote: > >> > >> On 6/20/25 8:50 AM, Chen Linxuan wrote: > >>> When running `make kselftest`, the following compilation warning wa

Re: [RESEND PATCH v2] kallsyms: fix build without execinfo

2025-06-23 Thread Achill Gilgenast
On Sun Jun 22, 2025 at 8:36 PM CEST, Andrew Morton wrote: > On Sun, 22 Jun 2025 03:45:49 +0200 Achill Gilgenast wrote: > >> Some libc's like musl libc don't provide execinfo.h since it's not part >> of POSIX. In order to fix compilation on musl, only include execinfo.h >> if available (HAVE_BACKTR

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Andrew Morton
On Mon, 23 Jun 2025 00:32:05 +0530 Shivank Garg wrote: > > -EXPORT_SYMBOL(__filemap_get_folio); > > +EXPORT_SYMBOL(__filemap_get_folio_mpol); > > > > static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t > > max, > > xa_mark_t mark) > > _ > > > > Hi Andrew, >

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Vlastimil Babka
On 6/20/25 16:34, Matthew Wilcox (Oracle) wrote: > This allows guest_memfd to pass in a memory policy. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Benno Lossin
On Mon Jun 23, 2025 at 11:44 AM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: > >> On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: >>> "Benno Lossin" writes: On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: > +/// A wrapper for kernel parameters. > +

Re: [RFC 0/6] Add multiple address spaces support to VDUSE

2025-06-23 Thread Christoph Hellwig
On Fri, Jun 20, 2025 at 08:25:50AM +0200, Eugenio Perez Martin wrote: > This code does not touch the DMA API at all. Actually, we could even > remove all the DMA code and these changes would work the same. Can't > we just continue with this series and remove the abuse of the DMA API > in parallel?

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-23 Thread Breno Leitao
On Sat, Jun 21, 2025 at 06:51:21AM -0700, Jakub Kicinski wrote: > On Fri, 20 Jun 2025 01:39:43 -0700 Breno Leitao wrote: > > > FWIW you can steal bpftrace integration from this series: > > > https://lore.kernel.org/all/20250421222827.283737-22-k...@kernel.org/ > > > > Yes, that would be great. I

Re: [RFC PATCH 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:26 +0530 Neeraj Kumar wrote: > In order to accommodate cxl lsa 2.1 format region label, renamed > nd_namespace_label to nd_lsa_label. I would add some more information on why. I've no idea from this description whether the issue is a naming clash or a need for a broade

[PATCH v3] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir(

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-23 Thread Dev Jain
On 21/06/25 11:25 pm, Donet Tom wrote: On Fri, Jun 20, 2025 at 08:15:25PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wro

Re: [PATCH] selftests/mm: Fix validate_addr helper

2025-06-23 Thread David Hildenbrand
On 20.06.25 13:11, Dev Jain wrote: validate_addr() function checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always return

Re: [PATCH] selftests/coredump: Fix "socket_detect_userspace_client" test failure

2025-06-23 Thread Christian Brauner
On Fri, 20 Jun 2025 13:02:52 +0200, Nam Cao wrote: > The coredump.socket_detect_userspace_client test occasionally fails: > # RUN coredump.socket_detect_userspace_client ... > # stackdump_test.c:500:socket_detect_userspace_client:Expected 0 (0) != > WIFEXITED(status) (0) > #

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-06-23 Thread Ganapatrao Kulkarni
On 6/19/2025 5:15 PM, Marc Zyngier wrote: > Also, running EL2 is the least of our worries, because that's pretty easy to deal with. It is running at EL1/0 when EL2 is present that is interesting, and I see no coverage on that front. Sorry, I did not get this comment fully. When we run selfte

Re: [PATCH] mm/selftests: improve UFFD-WP feature detection in KSM test

2025-06-23 Thread David Hildenbrand
On 22.06.25 10:10, Li Wang wrote: The current implementation of test_unmerge_uffd_wp() explicitly sets `uffdio_api.features = UFFD_FEATURE_PAGEFAULT_FLAG_WP` before calling UFFDIO_API. This can cause the ioctl() call to fail with EINVAL on kernels that do not support UFFD-WP, leading the test to

Re: [RFC PATCH 07/20] nvdimm/namespace_label: Update namespace init_labels and its region_uuid

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:31 +0530 Neeraj Kumar wrote: > nd_mapping->labels maintains the list of labels present into LSA. > init_labels function prepares this list while adding new label init_labels() prepares > into LSA and updates nd_mapping->labels accordingly. During cxl > region creation

Re: [RFC PATCH 06/20] nvdimm/region_label: Add region label deletion routine

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:30 +0530 Neeraj Kumar wrote: > Added cxl v2.1 format region label deletion routine. This function is > used to delete region label from LSA > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/label.c | 75 ++--- > drivers/nvdimm

Re: [RFC PATCH 20/20] cxl/pmem_region: Add cxl region label updation and deletion device attributes

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:44 +0530 Neeraj Kumar wrote: > Using these attributes region label is added/deleted into LSA. These > attributes are called from userspace (ndctl) after region creation. These need documentation. Documentation/ABI/testing/sysfs-bus-cxl is probably the right place. >

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-23 Thread Konrad Dybcio
On 6/21/25 9:31 PM, cristian_ci wrote: > On Saturday, June 21st, 2025 at 12:17, Konrad Dybcio > wrote: >>> + >>> +&sdhc_1 { >>> + vmmc-supply = <&pm8953_l8>; >>> + vqmmc-supply = <&pm8953_l5>; >> >> >> you should add regulator-allow-set-load to these vregs > > So, do you mean I should add 'regul

Re: [RFC PATCH 13/20] cxl/mem: Refactor cxl pmem region auto-assembling

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:37 +0530 Neeraj Kumar wrote: > In 84ec985944ef3, For cxl pmem region auto-assembly after endpoint port > probing, cxl_nvd presence was required. And for cxl region persistency, > region creation happens during nvdimm_probe which need the completion > of endpoint probe. >

Re: [RFC PATCH 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:07:23 +0100 Jonathan Cameron wrote: > On Tue, 17 Jun 2025 18:09:24 +0530 > Neeraj Kumar wrote: > > Hi Neeraj, > > First a process thing. Looks like threading is broken in your patch set. > https://lore.kernel.org/linux-cxl/1931444790.41750165203442.JavaMail.epsvc@epcpadp

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Shivank Garg
On 6/23/2025 3:46 AM, Andrew Morton wrote: > On Mon, 23 Jun 2025 00:32:05 +0530 Shivank Garg wrote: > >>> -EXPORT_SYMBOL(__filemap_get_folio); >>> +EXPORT_SYMBOL(__filemap_get_folio_mpol); >>> >>> static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t >>> max, >>>

[PATCH net] vsock/uapi: fix linux/vm_sockets.h userspace compilation errors

2025-06-23 Thread Stefano Garzarella
From: Stefano Garzarella If a userspace application just include will fail to build with the following errors: /usr/include/linux/vm_sockets.h:182:39: error: invalid application of ‘sizeof’ to incomplete type ‘struct sockaddr’ 182 | unsigned char svm_zero[sizeof(struct sockad

Re: [PATCH] ksm_tests: Skip hugepage test when Transparent Hugepages are disabled

2025-06-23 Thread Lorenzo Stoakes
Hi Li, This is breaking the mm-new mm selftest test build, did you have some local changes you didn't submit by mistake? You seem to be returning KSFT_SKIP from a void function. I enclose a simple fix-patch that fixes the issue, but obviously you should check to see if this is still doing what y

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Shivank Garg
On 6/23/2025 12:46 PM, Vlastimil Babka wrote: > On 6/22/25 21:02, Shivank Garg wrote: >> >> Hi Andrew, >> >> Thank you for addressing this. >> >> If you don’t mind me asking, >> I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here. >> I had previously received feedback recom

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Andreas Hindborg
"Benno Lossin" writes: > On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: +/// A wrapper for kernel parameters. +/// +/// This type is instantiated by the [`module!`] macro when

Re: [RFC PATCH 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in cxl pmem

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:42 +0530 Neeraj Kumar wrote: > Add support of cxl lsa 2.1 using NDD_CXL_LABEL flag. It also creates cxl > region based on region information parsed from LSA. > > Signed-off-by: Neeraj Kumar > --- > drivers/cxl/pmem.c | 59 ++

Re: [RFC PATCH 19/20] cxl/pmem_region: Prep patch to accommodate pmem_region attributes

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:43 +0530 Neeraj Kumar wrote: > Created a separate file core/pmem_region.c along with CONFIG_PMEM_REGION > Moved pmem_region related code from core/region.c to core/pmem_region.c > For region label update, need to create device attribute, which calls > nvdimm exported fun

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-23 Thread Andreas Hindborg
"Benno Lossin" writes: > On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: +/// A wrapper for kernel parameters. +/// +/// This type is instantiated by the [`module!`] macro when

Re: [RFC PATCH 15/20] cxl: Add a routine to find cxl root decoder on cxl bus

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:39 +0530 Neeraj Kumar wrote: > Add cxl_find_root_decoder to find root decoder on cxl bus. It is used to > find root decoder during region creation > > Signed-off-by: Neeraj Kumar > --- > drivers/cxl/core/port.c | 26 ++ > drivers/cxl/cxl.h

Re: [RFC PATCH 14/20] cxl/region: Add cxl pmem region creation routine for region persistency

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:38 +0530 Neeraj Kumar wrote: > Added exported cxl_create_pmem_region routine to create cxl pmem region For function names always add () after and drop 'function/routine' etc. Ends up shorter and easier to read. > from LSA parsed cxl region information. > Inspirition fo

Re: [RFC PATCH 12/20] nvdimm/namespace_label: Skip region label during namespace creation

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:36 +0530 Neeraj Kumar wrote: > During namespace creation skip presence of region label if present. > Also preserve region label into labels list if present. > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/namespace_devs.c | 48 +

Re: [RFC PATCH 08/20] nvdimm/label: Include region label in slot validation

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:32 +0530 Neeraj Kumar wrote: > slot validation routine validates label slot by calculating label > checksum. It was only validating namespace label. This changeset also > validates region label if present. > > Also validate and calculate lsa v2.1 namespace label checksu

Re: [RFC PATCH 05/20] nvdimm/region_label: Add region label updation routine

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:29 +0530 Neeraj Kumar wrote: Add region label update routine > Added __pmem_region_label_update region label update routine to update > region label > > Signed-off-by: Neeraj Kumar A few trivial comments inline. Jonathan > --- > drivers/nvdimm/label.c |

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-23 Thread Vlastimil Babka
On 6/22/25 21:02, Shivank Garg wrote: > > Hi Andrew, > > Thank you for addressing this. > > If you don’t mind me asking, > I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here. > I had previously received feedback recommending the use of EXPORT_SYMBOL_GPL > to better align w

[PATCH] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir(