Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write

2019-05-07 Thread Adrian Hunter
On 7/05/19 7:27 PM, Faiz Abbas wrote: > Hi Adrian, > > On 26/04/19 11:30 AM, Adrian Hunter wrote: >> On 25/04/19 6:57 PM, Faiz Abbas wrote: >>> In the call to regmap_update_bits() for SLOTTYPE, the mask and value >>> fields are exchanged. Fix this. >> >&g

Re: [PATCH 2/2] mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-07 Thread Adrian Hunter
On 8/05/19 1:46 AM, Scott Branden wrote: > Hi Adrian, > > On 2019-05-06 11:31 p.m., Adrian Hunter wrote: >> On 6/05/19 8:01 PM, Scott Branden wrote: >>> From: Trac Hoang >>> >>> The iproc host eMMC/SD controller hold time does not meet the >>> s

Re: [PATCH 1/2] mmc: sdhci-iproc: cygnus: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-06 Thread Adrian Hunter
the falling clock edges rather than the > rising clock edges. > > This change applies only to the Cygnus platform. > > Fixes: c833e92bbb60 ("mmc: sdhci-iproc: support standard byte register > accesses") > Signed-off-by: Trac Hoang > Signed-off-by: Scott Bran

Re: [PATCH 2/2] mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-06 Thread Adrian Hunter
On 6/05/19 8:01 PM, Scott Branden wrote: > From: Trac Hoang > > The iproc host eMMC/SD controller hold time does not meet the > specification in the HS50 mode. This problem can be mitigated > by disabling the HISPD bit; thus forcing the controller output > data to be driven on the falling clock

Re: [PATCH] mmc: block: Fix memory leak in blk-mq when cleaning up

2019-05-06 Thread Adrian Hunter
On 4/05/19 2:35 AM, Douglas Anderson wrote: > If I run the following on rk3288-veyron-minnie (a 2GB machine) > > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 3000); do > echo "" $i > echo ff0f.dwmmc > unbind > sleep .5 > echo ff0f00

[PATCH 2/6] perf scripts python: exported-sql-viewer.py: Move view creation

2019-05-03 Thread Adrian Hunter
As preparation for adding support for copying to clipboard, create view in TreeWindowBase instead of derived classes. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/scripts

[PATCH 5/6] perf scripts python: exported-sql-viewer.py: Add context menu

2019-05-03 Thread Adrian Hunter
Add a context menu (right-click) that provides options for copying to clipboard, including, for trees, the ability to copy only the cell under the mouse pointer. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 41 +++ 1 file changed, 41

[PATCH 4/6] perf scripts python: exported-sql-viewer.py: Add copy to clipboard

2019-05-03 Thread Adrian Hunter
Add support for copying to clipboard. Two menu options are added to copy the selected rows / columns with normal spacing, or as comma-separated-values. In the case of trees, only entire rows can be copied. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 217

[PATCH 3/6] perf scripts python: exported-sql-viewer.py: Add tree level

2019-05-03 Thread Adrian Hunter
As preparation for adding support for copying to clipboard, keep track of what level each item is in tree items. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/scripts/python/exported-sql

[PATCH 0/6] perf scripts python: exported-sql-viewer.py: Minor improvements

2019-05-03 Thread Adrian Hunter
Hi Here are a some minor improvememnts to exported-sql-viewer.py The patches go on top of the pyside2 support patches, here: https://lore.kernel.org/lkml/20190412113830.4126-1-adrian.hun...@intel.com Adrian Hunter (6): perf scripts python: exported-sql-viewer.py: Fix error when

[PATCH 6/6] perf scripts python: exported-sql-viewer.py: Add 'About' dialog box

2019-05-03 Thread Adrian Hunter
With support for Python 2 or 3 and PySide 1 or 2 (Qt 4 or 5), it is useful to see what versions are in use. Add an 'About' dialog box that displays Python, PySide, Qt and database server (SQLite or PostgreSQL) version numbers. Signed-off-by: Adrian Hunter --- .../scripts/python/ex

[PATCH 1/6] perf scripts python: exported-sql-viewer.py: Fix error when shrinking / enlarging font

2019-05-03 Thread Adrian Hunter
s no attribute 'view' Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py in

Re: [PATCH] mmc: Fix tag set memory leak

2019-05-02 Thread Adrian Hunter
s: 81196976ed94 ("mmc: block: Add blk-mq support") Acked-by: Adrian Hunter > --- > I found this using kmemleak and plugging and unplugging an SD card in a > few times. > > Here is an example of the output of kmemleak: > unreferenced object 0x888125be4ce8 (size

Re: [RFC PATCH 2/2] mmc: sdhci: Quirk for AMD SDHC Device 0x7906

2019-05-01 Thread Adrian Hunter
Cc: some AMD people On 1/05/19 8:54 PM, Raul E Rangel wrote: > AMD SDHC 0x7906 requires a hard reset to clear all internal state. > Otherwise it can get into a bad state where the DATA lines are always > read as zeros. > > This change requires firmware that can transition the device into > D3Cold

Re: [PATCH 0/8] perf scripts python: Support pyside2 and misc Intel PT

2019-04-29 Thread Adrian Hunter
On 12/04/19 2:38 PM, Adrian Hunter wrote: > Hi > > Here are patches to add support for pyside2 to the db-export scripts, > and a couple of Intel PT patches. > > > Adrian Hunter (8): > perf scripts python: exported-sql-viewer.py: Change python2 to python >

Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write

2019-04-25 Thread Adrian Hunter
On 25/04/19 6:57 PM, Faiz Abbas wrote: > In the call to regmap_update_bits() for SLOTTYPE, the mask and value > fields are exchanged. Fix this. Could you also comment on whether this has any known effect on the driver. > > Signed-off-by: Faiz Abbas > --- > drivers/mmc/host/sdhci_am654.c | 4 ++

Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations

2019-04-25 Thread Adrian Hunter
On 25/04/19 6:57 PM, Faiz Abbas wrote: > Fix the following minor things: > > 1. Line wrapping with the regmap_*() functions is way more conservative > than required by the 80 character rule. Expand the function calls out to > use less number of lines. > > 2. Add an error message if the DLL fails

Re: [PATCH 06/12] perf tools: Do not erase uncovered maps by kcore

2019-04-23 Thread Adrian Hunter
On 16/04/19 7:01 PM, Jiri Olsa wrote: > Maps in kcore do not cover bpf maps, so we can't just > remove everything. Keeping all kernel maps, which are > not covered by kcore maps. Memory for jited-bpf is allocated from the same area that is used for modules. In the case of /proc/kcore, that entire

Re: [PATCH v1 0/4] Add tracing for SDHCI register access

2019-04-17 Thread Adrian Hunter
On 12/04/19 5:50 PM, Raul Rangel wrote: > On Fri, Apr 12, 2019 at 09:26:44AM +0300, Adrian Hunter wrote: >> On 12/04/19 1:08 AM, Raul E Rangel wrote: >>> I was debugging a SDHC hardware bug and got tired of having to >>> translate the register values by hand. Thi

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-16 Thread Adrian Hunter
On 17/04/19 9:51 AM, Jiri Olsa wrote: > On Wed, Apr 17, 2019 at 09:35:32AM +0300, Adrian Hunter wrote: >> On 16/04/19 7:01 PM, Jiri Olsa wrote: >>> The eBPF program can be loaded multiple times >>> with the same name (tag). We can share dso >>> objects for

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-16 Thread Adrian Hunter
On 16/04/19 7:01 PM, Jiri Olsa wrote: > The eBPF program can be loaded multiple times > with the same name (tag). We can share dso > objects for those programs. Doesn't a eBPF program get recompiled differently every time it is loaded? > > Link: http://lkml.kernel.org/n/tip-3damf8vq1dryhtpbk5b06

[tip:perf/urgent] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

2019-04-16 Thread tip-bot for Adrian Hunter
Commit-ID: 6e4b1cac30d297718218dc268199ed20df074b98 Gitweb: https://git.kernel.org/tip/6e4b1cac30d297718218dc268199ed20df074b98 Author: Adrian Hunter AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 16 Apr 2019 11:27:05 -0300 perf scripts

Re: [RFC] mmc: cqhci: clear pending interrupt and halt

2019-04-16 Thread Adrian Hunter
On 16/04/19 10:27 AM, Peng Fan wrote: > Hi Adrian, > >> >> On 16/04/19 9:48 AM, Peng Fan wrote: >>> On i.MX8MM, we are running Dual Linux OS, with 1st Linux using SD Card >>> as rootfs storage, 2nd Linux using eMMC as rootfs storage. We let the >>> the 1st linux configure power/clock for the 2nd L

Re: [RFC] mmc: cqhci: clear pending interrupt and halt

2019-04-16 Thread Adrian Hunter
On 16/04/19 9:48 AM, Peng Fan wrote: > On i.MX8MM, we are running Dual Linux OS, with 1st Linux using SD Card > as rootfs storage, 2nd Linux using eMMC as rootfs storage. We let the > the 1st linux configure power/clock for the 2nd Linux. > > When the 2nd Linux is booting into rootfs stage, we let

[tip:perf/urgent] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

2019-04-12 Thread tip-bot for Adrian Hunter
Commit-ID: 961df45e5de662e65fc6bc415fecc8caa8a3045c Gitweb: https://git.kernel.org/tip/961df45e5de662e65fc6bc415fecc8caa8a3045c Author: Adrian Hunter AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 9 Apr 2019 10:15:00 -0300 perf scripts

[PATCH 7/8] perf intel-pt: Improve sync_switch

2019-04-12 Thread Adrian Hunter
sync_switch is a facility to synchronize decoding more closely with the point in the kernel when the context actually switched. Improve it by processing "context switch in" events. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt.c | 40

[PATCH 0/8] perf scripts python: Support pyside2 and misc Intel PT

2019-04-12 Thread Adrian Hunter
Hi Here are patches to add support for pyside2 to the db-export scripts, and a couple of Intel PT patches. Adrian Hunter (8): perf scripts python: exported-sql-viewer.py: Change python2 to python perf scripts python: exported-sql-viewer.py: Use argparse module for argument parsing

[PATCH 2/8] perf scripts python: exported-sql-viewer.py: Use argparse module for argument parsing

2019-04-12 Thread Adrian Hunter
argparse makes it easier to add new arguments. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 21 +-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python

[PATCH 8/8] perf intel-pt: Rationalize intel_pt_sync_switch()'s use of next_tid

2019-04-12 Thread Adrian Hunter
Returning 1 from intel_pt_sync_switch() causes the current tid to be set. That negates the need to keep next_tid anymore. Rationalize the code to that effect. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 6/8] perf tools: perf-with-kcore.sh: Always allow fix_buildid_cache_permissions

2019-04-12 Thread Adrian Hunter
The user's buildid cache may contain entries added by root even if root has its own home directory (e.g. by using perfconfig to specify the same buildid dir), so remove that validation. Signed-off-by: Adrian Hunter --- tools/perf/perf-with-kcore.sh | 5 - 1 file changed, 5 dele

[PATCH 3/8] perf scripts python: exported-sql-viewer.py: Add support for pyside2

2019-04-12 Thread Adrian Hunter
pyside2 is the future for pyside support. Note pyside use Qt4 whereas pyside2 uses Qt5. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 28 ++- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql

[PATCH 5/8] perf scripts python: export-to-postgresql.py: Add support for pyside2

2019-04-12 Thread Adrian Hunter
pyside2 is the future for pyside support. Note pyside use Qt4 whereas pyside2 uses Qt5. Signed-off-by: Adrian Hunter --- .../scripts/python/export-to-postgresql.py| 43 +++ 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/tools/perf/scripts/python/export-to

[PATCH 1/8] perf scripts python: exported-sql-viewer.py: Change python2 to python

2019-04-12 Thread Adrian Hunter
Now that there is also support for python3, there is no need to specify python2 explicitly. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b

[PATCH 4/8] perf scripts python: export-to-sqlite.py: Add support for pyside2

2019-04-12 Thread Adrian Hunter
pyside2 is the future for pyside support. Note pyside use Qt4 whereas pyside2 uses Qt5. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/export-to-sqlite.py | 44 --- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/tools/perf/scripts/python/export-to

Re: [PATCH v1 0/4] Add tracing for SDHCI register access

2019-04-11 Thread Adrian Hunter
On 12/04/19 1:08 AM, Raul E Rangel wrote: > I was debugging a SDHC hardware bug and got tired of having to > translate the register values by hand. This patch set makes it so all > SDHC register read and write operations can be traced and easily read by > a human. While this might be useful for pe

[PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

2019-04-08 Thread Adrian Hunter
Fix following error using calls_view: Query failed: ambiguous column name: parent_id Unable to execute statement Signed-off-by: Adrian Hunter Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id") --- tools/perf/scripts/python/export-to-sqlite.py

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-04-02 Thread Adrian Hunter
On 2/04/19 10:59 AM, Faiz Abbas wrote: > Hi Adrian, > > On 26/03/19 1:03 PM, Adrian Hunter wrote: >> On 18/03/19 11:33 AM, Ulf Hansson wrote: >>> + Arnd, Grygorii >>> >>> On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: >>>> >>>

Re: [PATCH v2] mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes

2019-04-02 Thread Adrian Hunter
speed, SD high speed, MMC high speed, SDR12 and SDR25 > speed modes. > > Use the sdhci writeb callback to implement this condition. > > [1] http://www.ti.com/lit/gpn/am6546 Section 5.10.5.16.1 > > Signed-off-by: Faiz Abbas Acked-by: Adrian Hunter > --- > > v

Re: [PATCH 1/2] mmc: sdhci: Add Quirk for enabling HISPD under special conditions

2019-04-01 Thread Adrian Hunter
On 1/04/19 12:01 PM, Faiz Abbas wrote: > Hi Adrian, > > On 01/04/19 2:21 PM, Adrian Hunter wrote: >> On 29/03/19 4:22 PM, Faiz Abbas wrote: >>> Some controllers on TI devices requires the HISPD bit to be cleared >>> even in some high speed modes. Add a quirk that

Re: [PATCH 1/2] mmc: sdhci: Add Quirk for enabling HISPD under special conditions

2019-04-01 Thread Adrian Hunter
On 29/03/19 4:22 PM, Faiz Abbas wrote: > Some controllers on TI devices requires the HISPD bit to be cleared > even in some high speed modes. Add a quirk that facilitates this > requirement. Could you use sdhci I/O accessors for this? > > Signed-off-by: Faiz Abbas > --- > drivers/mmc/host/sdhc

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Fix python3 support

2019-03-29 Thread tip-bot for Adrian Hunter
Commit-ID: 606bd60ab6fbcb7f73deeef4fa37cfd5e447a200 Gitweb: https://git.kernel.org/tip/606bd60ab6fbcb7f73deeef4fa37cfd5e447a200 Author: Adrian Hunter AuthorDate: Wed, 27 Mar 2019 09:28:26 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 28 Mar 2019 15:53:16 -0300 perf

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Fix never-ending loop

2019-03-29 Thread tip-bot for Adrian Hunter
Commit-ID: 8453c936db20489dbf0957187dca9a2656a2a7b6 Gitweb: https://git.kernel.org/tip/8453c936db20489dbf0957187dca9a2656a2a7b6 Author: Adrian Hunter AuthorDate: Wed, 27 Mar 2019 09:28:25 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 28 Mar 2019 14:41:21 -0300 perf

[tip:perf/urgent] perf intel-pt: Fix TSC slip

2019-03-29 Thread tip-bot for Adrian Hunter
Commit-ID: f3b4e06b3bda759afd042d3d5fa86bea8f1fe278 Gitweb: https://git.kernel.org/tip/f3b4e06b3bda759afd042d3d5fa86bea8f1fe278 Author: Adrian Hunter AuthorDate: Mon, 25 Mar 2019 15:51:35 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 28 Mar 2019 14:31:55 -0300 perf intel

Re: [PATCH v5] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-29 Thread Adrian Hunter
t instead of calling > finish_mrq(). > > Fixes: 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset > callback") > Signed-off-by: Faiz Abbas Acked-by: Adrian Hunter > --- > Tested with 100 times boot tests on dra71x-evm, dra72x-evm and > dra7xx-evm. &g

Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-28 Thread Adrian Hunter
On 27/03/19 1:47 PM, Faiz Abbas wrote: > Hi Adrian, > > On 27/03/19 4:45 PM, Adrian Hunter wrote: >> On 26/03/19 1:00 PM, Faiz Abbas wrote: >>> commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset >>> callback") skips data resets during tu

Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-27 Thread Adrian Hunter
On 26/03/19 1:00 PM, Faiz Abbas wrote: > commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset > callback") skips data resets during tuning operation. Because of this, > a data error or data finish interrupt might still arrive after a command > error has been handled and the mrq ended.

[PATCH 1/2] perf scripts python: exported-sql-viewer.py: Fix never-ending loop

2019-03-27 Thread Adrian Hunter
: Adrian Hunter Fixes: beda0e725e5f ("perf script python: Add Python3 support to exported-sql-viewer.py") --- .../scripts/python/exported-sql-viewer.py | 60 +++ 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-vi

[PATCH 2/2] perf scripts python: exported-sql-viewer.py: Fix python3 support

2019-03-27 Thread Adrian Hunter
Unlike python2, python3 strings are not compatible with byte strings. That results in disassembly not working for the branches reports. Fixup those places overlooked in the port to python3. Signed-off-by: Adrian Hunter Fixes: beda0e725e5f ("perf script python: Add Python3 support to exp

[PATCH 0/2] perf scripts python: exported-sql-viewer.py: Fix python3 support

2019-03-27 Thread Adrian Hunter
Hi Here are a couple for fixes. Adrian Hunter (2): perf scripts python: exported-sql-viewer.py: Fix never-ending loop perf scripts python: exported-sql-viewer.py: Fix python3 support tools/perf/scripts/python/exported-sql-viewer.py | 77 +++- 1 file changed, 63

tools bugs: make clean deletes files in the git tree

2019-03-26 Thread Adrian Hunter
Hi Doing: make -C tools clean Results in: git diff --stat tools/pci/pcitest.sh | 72 tools/testing/selftests/livepatch/test-callbacks.sh | 587

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-26 Thread Adrian Hunter
On 18/03/19 11:33 AM, Ulf Hansson wrote: > + Arnd, Grygorii > > On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: >> >> sdhci.c has two bottom halves implemented. A threaded_irq for handling >> card insert/remove operations and a tasklet for finishing mmc requests. >> With the addition of external

[RESEND PATCH] perf intel-pt: Fix TSC slip

2019-03-25 Thread Adrian Hunter
A TSC packet can slip past MTC packets so that the timestamp appears to go backwards. One estimate is that can be up to about 40 CPU cycles, which is certainly less than 0x1000 TSC ticks, but accept slippage an order of magnitude more to be on the safe side. Signed-off-by: Adrian Hunter Fixes

Re: [PATCH V4 03/10] mmc: tegra: update hw tuning process

2019-03-25 Thread Adrian Hunter
correction to pick the best tap. > > This patch has implementation of this post HW tuning process for > the tegra hosts that support HW tuning through the callback function > tegra_sdhci_execute_hw_tuning and uses the tuned tap delay. >

Re: [PATCH V4 07/10] mmc: tegra: add Tegra186 WAR for CQE

2019-03-25 Thread Adrian Hunter
rjani > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index f1aa0

Re: [PATCH V4 06/10] mmc: cqhci: allow hosts to update dcmd cmd desc

2019-03-25 Thread Adrian Hunter
: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > [V4]: Minor fix of missing declaration of mmc_request > > drivers/mmc/host/cqhci.c | 2 ++ > drivers/mmc/host/cqhci.h | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/cqhci.c b/

Re: [PATCH V4 02/10] mmc: sdhci: allow host to specify maximum tuning loops

2019-03-25 Thread Adrian Hunter
et to same as existing loop count of > MAX_TUNING_LOOP which is 40 iterations. > > Tested-by: Jon Hunter > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci.c | 5 +++-- > drivers/mmc/host/sdhci.h | 1 + > 2 files changed, 4 in

Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static

2019-03-25 Thread Adrian Hunter
On 22/03/19 4:11 PM, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/mmc/host/sdhci-omap.c:788:6: warning: > symbol 'sdhci_omap_reset' was not declared. Should it be static? > > Signed-off-by: YueHaibing Acked-by: Adrian Hunter

Re: [bug report][stable] perf probe: failed to add events

2019-03-25 Thread Adrian Hunter
On 21/03/19 12:10 PM, Greg KH wrote: > On Thu, Feb 28, 2019 at 09:19:08AM +0200, Adrian Hunter wrote: >> On 28/02/19 4:07 AM, Joseph Qi wrote: >>> Hi Adrian, >>> >>> On 19/2/27 20:39, Adrian Hunter wrote: >>>> Seems to be fixed by this: >>>&

[tip:perf/urgent] perf probe: Fix getting the kernel map

2019-03-22 Thread tip-bot for Adrian Hunter
Commit-ID: eaeffeb9838a7c0dec981d258666bfcc0fa6a947 Gitweb: https://git.kernel.org/tip/eaeffeb9838a7c0dec981d258666bfcc0fa6a947 Author: Adrian Hunter AuthorDate: Mon, 4 Mar 2019 15:13:21 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 11 Mar 2019 11:56:03 -0300 perf probe

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Factor out CallGraphModelBase

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: 254c0d820b86d7712e03750c58ab104e06e3655d Gitweb: https://git.kernel.org/tip/254c0d820b86d7712e03750c58ab104e06e3655d Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:30 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:56:17 -0300 perf scripts

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Add call tree

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: ae8b887c00d3fe4ca8c2cba16ae452b5df4c19e2 Gitweb: https://git.kernel.org/tip/ae8b887c00d3fe4ca8c2cba16ae452b5df4c19e2 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:31 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 15:04:16 -0300 perf scripts

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Improve TreeModel abstraction

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: a448ba232a5f0176c226df1bab8877ec06a7c771 Gitweb: https://git.kernel.org/tip/a448ba232a5f0176c226df1bab8877ec06a7c771 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:29 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:55:32 -0300 perf scripts

[tip:perf/urgent] perf scripts python: exported-sql-viewer.py: Factor out TreeWindowBase

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: a731cc4c990a90d9d42a2081ca93fb4310680ae2 Gitweb: https://git.kernel.org/tip/a731cc4c990a90d9d42a2081ca93fb4310680ae2 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:28 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:54:39 -0300 perf scripts

[tip:perf/urgent] perf scripts python: export-to-postgresql.py: Fix invalid input syntax for integer error

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: 07c5ebead85f507271fb8e2a8b5814e486702518 Gitweb: https://git.kernel.org/tip/07c5ebead85f507271fb8e2a8b5814e486702518 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:26 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:53:12 -0300 perf scripts

[tip:perf/urgent] perf scripts python: export-to-postgresql.py: Export calls parent_id

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: febce6dc1f5167e683d6e3c3d0f6ab7f98201ea8 Gitweb: https://git.kernel.org/tip/febce6dc1f5167e683d6e3c3d0f6ab7f98201ea8 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:27 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:53:33 -0300 perf scripts

[tip:perf/urgent] perf scripts python: export-to-sqlite.py: Export calls parent_id

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: 8ce9a7251d110c7bbb43e30dd42f81d8e6286516 Gitweb: https://git.kernel.org/tip/8ce9a7251d110c7bbb43e30dd42f81d8e6286516 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:25 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:52:29 -0300 perf scripts

[tip:perf/urgent] perf db-export: Add calls parent_id to enable creation of call trees

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: f435887ec0c941b97301bd6ed1f3e4b5200df409 Gitweb: https://git.kernel.org/tip/f435887ec0c941b97301bd6ed1f3e4b5200df409 Author: Adrian Hunter AuthorDate: Thu, 28 Feb 2019 15:00:24 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:50:47 -0300 perf db

[tip:perf/urgent] perf intel-pt: Fix divide by zero when TSC is not available

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: 076333870c2f5bdd9b6d31e7ca1909cf0c84cbfa Gitweb: https://git.kernel.org/tip/076333870c2f5bdd9b6d31e7ca1909cf0c84cbfa Author: Adrian Hunter AuthorDate: Fri, 1 Mar 2019 12:35:36 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:48:30 -0300 perf intel-pt

[tip:perf/urgent] perf auxtrace: Improve address filter error message when there is no DSO

2019-03-09 Thread tip-bot for Adrian Hunter
Commit-ID: c1c49204b0114daf210c79d66a5980c8e6f8f8fb Gitweb: https://git.kernel.org/tip/c1c49204b0114daf210c79d66a5980c8e6f8f8fb Author: Adrian Hunter AuthorDate: Fri, 1 Mar 2019 14:29:02 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Mar 2019 14:47:06 -0300 perf auxtrace

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-08 Thread Adrian Hunter
On 6/03/19 12:00 PM, Faiz Abbas wrote: > Adrian, > > On 25/02/19 1:47 PM, Adrian Hunter wrote: >> On 15/02/19 9:20 PM, Faiz Abbas wrote: >>> sdhci.c has two bottom halves implemented. A threaded_irq for handling >>> card insert/remove operations and a tasklet for

Re: [PATCH v2 7/7] perf script python: add printdate function to SQL exporters

2019-03-08 Thread Adrian Hunter
since Adrian provided the Acked-by to the other > patch, can this be done this time again? Acked-by: Adrian Hunter

Re: [PATCH V1 10/11] mmc: tegra: fix CQE resume sequence

2019-03-08 Thread Adrian Hunter
> > This patch fixes this by configuring sdhci block registers prior > to CQE unhalt. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 71 > -- > 1 file changed, 62 inser

Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.

2019-03-08 Thread Adrian Hunter
On 7/03/19 10:43 AM, Christoph Muellner wrote: > This patch documents the new property disable-cqe-dcmd > for the Arasan eMMC 5.1 driver. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 > 1 file chan

Re: [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs.

2019-03-08 Thread Adrian Hunter
ion sets this bit unconditionally. > > This patch allows to suppress the feature activation, > by specifying the property disable-cqe-dcmd. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-o

Re: [PATCH V1 07/11] mmc: cqhci: add quirk for setting DCMD CMD_TIMING

2019-03-08 Thread Adrian Hunter
On 7/03/19 8:16 PM, Sowjanya Komatineni wrote: > >> On 3/6/2019 6:30 PM, Adrian Hunter wrote: >>> On 2/03/19 7:20 AM, Sowjanya Komatineni wrote: >>>> This patch adds a quirk for setting CMD_TIMING to 1 in descriptor for >>>> DCMD with R1B response type

Re: [PATCH V1 09/11] mmc: cqhci: add CQHCI_SSC1 register CBC field mask

2019-03-08 Thread Adrian Hunter
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote: > This patch adds define for CBC field mask of the register > CQHCI_SSC1. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/cqhci.h | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH V1 03/11] mmc: sdhci: add support for post tuning process

2019-03-08 Thread Adrian Hunter
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote: > This patch adds support for post tuning process needed for some hosts > to perform after successful completion of HW tuning. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/mmc/host/sdhci.c | 6 +- > drivers/mmc/host/sdhci.h | 1 + > 2

Re: [PATCH V1 02/11] mmc: sdhci: allow host to specify maximum tuning loops

2019-03-08 Thread Adrian Hunter
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote: > As per the Host Controller Standard Specification Version 4.20, > limitation of tuning iteration count is removed as PLL locking > time can be longer than UHS-1 tuning due to larger PVT fluctuation > and it will result in increase of tuning iteration

Re: [PATCH V1 01/11] mmc: tegra: fix ddr signaling for non-ddr modes

2019-03-08 Thread Adrian Hunter
une where it switches > from HS400 to HS DDR and then from HS DDR to HS mode and then > to HS200. > > This patch fixes the ddr_signaling to set properly for non DDR > modes. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/s

Re: [PATCH v2 6/7] perf script python: add Python3 support to sql scripts

2019-03-08 Thread Adrian Hunter
On 7/03/19 8:51 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 06, 2019 at 08:32:42AM -0800, Tony Jones escreveu: >> On 3/6/19 1:26 AM, Adrian Hunter wrote: >>> On 2/03/19 3:19 AM, Tony Jones wrote: >>>> Support both Python2 and Python3 in the exported

Re: [PATCH v4 03/15] perf tools script: Filter COMM/FORK/.. events by CPU

2019-03-06 Thread Adrian Hunter
On 5/03/19 4:47 PM, Andi Kleen wrote: > From: Andi Kleen > > The --cpu option only filtered samples. Filter other perf events, > such as COMM, FORK, SWITCH by the CPU too. Because tasks can migrate from cpu to cpu, we probably need to process most of the events anyway, even if they are not print

Re: [PATCH V1 07/11] mmc: cqhci: add quirk for setting DCMD CMD_TIMING

2019-03-06 Thread Adrian Hunter
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote: > This patch adds a quirk for setting CMD_TIMING to 1 in descriptor > for DCMD with R1B response type to allow the command to be sent to > device during data activity or busy time. > > Tegra186 CQHCI host has bug where it selects DATA_PRESENT_SELECT >

Re: [PATCH v2 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-06 Thread Adrian Hunter
On 1/03/19 10:38 AM, Faiz Abbas wrote: > commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset > callback") skips data resets during tuning operation. Because of this, > a data error or data finish interrupt might still arrive after a command > error has been handled and the mrq ended.

Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-06 Thread Adrian Hunter
ionary ordering etc. However the format within lines > should be unchanged. > > The use of 'from __future__' implies the minimum supported Python2 version > is now v2.6 > > Signed-off-by: Tony Jones > Signed-off-by: Seeteena Thoufeek > Cc: Adr

Re: [PATCH v2 6/7] perf script python: add Python3 support to sql scripts

2019-03-06 Thread Adrian Hunter
ever the format within lines > should be unchanged. > > The use of 'from __future__' implies the minimum supported Python2 version > is now v2.6 > > Signed-off-by: Tony Jones > Signed-off-by: Seeteena Thoufeek > Cc: Adrian Hunter Apart from one issue (see below

Re: [PATCH v2 1/7] perf script python: remove mixed indentation

2019-03-05 Thread Adrian Hunter
error if it encounters > mixed indentation. > > Signed-off-by: Tony Jones For intel-pt-events.py Acked-by: Adrian Hunter

Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-05 Thread Adrian Hunter
> The use of 'from __future__' implies the minimum supported Python2 version > is now v2.6 > > Signed-off-by: Tony Jones > Signed-off-by: Seeteena Thoufeek > Cc: Adrian Hunter One change missed, see below, otherwise: Acked-by: Adrian Hunter > --- >

Re: [PATCH v2 0/7] perf script python: add Python3 support

2019-03-05 Thread Adrian Hunter
On 2/03/19 3:18 AM, Tony Jones wrote: > This is v2 of my version of the patchset. Incorporating the > previous feedback. Some changes from v1 were already merged. > > Patch 1/7 deals with the existing inconsistent indentation. > Indentation is now consistent per file but varying styles (tabs, >

[PATCH] perf probe: Fix getting the kernel map

2019-03-04 Thread Adrian Hunter
Since commit 4d99e4136580 ("perf machine: Workaround missing maps for x86 PTI entry trampolines"), perf tools has been creating more than one kernel map, however 'perf probe' assumed there could be only one. Fix by using machine__kernel_map() to get the main kernel map. S

[tip:perf/core] perf thread-stack: Hide x86 retpolines

2019-02-27 Thread tip-bot for Adrian Hunter
Commit-ID: 3c0cd952cf051903929cd57b89034cc5f71f451d Gitweb: https://git.kernel.org/tip/3c0cd952cf051903929cd57b89034cc5f71f451d Author: Adrian Hunter AuthorDate: Wed, 9 Jan 2019 11:18:35 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 22 Feb 2019 16:49:49 -0300 perf thread

[tip:perf/core] perf thread-stack: Improve thread_stack__no_call_return()

2019-02-27 Thread tip-bot for Adrian Hunter
Commit-ID: 1f35cd65386e02430546727bd3cc2508d052e3ec Gitweb: https://git.kernel.org/tip/1f35cd65386e02430546727bd3cc2508d052e3ec Author: Adrian Hunter AuthorDate: Wed, 9 Jan 2019 11:18:34 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 22 Feb 2019 11:42:34 -0300 perf thread

Re: [bug report][stable] perf probe: failed to add events

2019-02-27 Thread Adrian Hunter
On 28/02/19 4:07 AM, Joseph Qi wrote: > Hi Adrian, > > On 19/2/27 20:39, Adrian Hunter wrote: >> Seems to be fixed by this: >> >> From: Adrian Hunter >> Date: Wed, 27 Feb 2019 05:35:25 +0200 >> Subject: [PATCH] perf probe: Fix getting the kernel map >>

Re: [PATCH v2 2/2] mmc: cqhci: Fix a tiny potential memory leak on error condition

2019-02-27 Thread Adrian Hunter
ry. > Also, cqhci_disable() seems to be designed to disable and free > all resources, not suitable to handle this corner case. > > Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host") > Signed-off-by: Alamy Liu Acked-by: Adrian Hunter > ---

Re: [PATCH v2 1/2] mmc: cqhci: fix space allocated for transfer descriptor

2019-02-27 Thread Adrian Hunter
o allocate > space for data transfer. For instance: > CQE_DCMD is enabled: 31 slots space (one slot used by DCMD) > CQE_DCMD is disabled: 32 slots space > > Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host") > Signed-off-by: Alamy Liu Acked

Re: [bug report][stable] perf probe: failed to add events

2019-02-27 Thread Adrian Hunter
ever worked on the 4.19 stable tree? If so, any chance >>>> you can run 'git bisect' to find the offending commit? >>>> >>> >From my test, v4.19.0 also has this issue. >>> Bisect locates that it is introduced by commit bf904d2762ee >>> &q

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-02-25 Thread Adrian Hunter
On 15/02/19 9:20 PM, Faiz Abbas wrote: > sdhci.c has two bottom halves implemented. A threaded_irq for handling > card insert/remove operations and a tasklet for finishing mmc requests. > With the addition of external dma support, dmaengine APIs need to > terminate in non-atomic context before unma

Re: [PATCH 06/15] perf script python: add Python3 support to intel-pt-events.py

2019-02-24 Thread Adrian Hunter
> > The use of 'from __future__' implies the minimum supported Python2 version > is now v2.6 > > Signed-off-by: Tony Jones > Signed-off-by: Seeteena Thoufeek > Cc: Adrian Hunter > --- > tools/perf/scripts/python/intel-pt-events.py | 138 ++- >

Re: [PATCH 5/6] perf thread-stack: Improve thread_stack__no_call_return()

2019-02-22 Thread Adrian Hunter
On 9/01/19 11:18 AM, Adrian Hunter wrote: > Improve thread_stack__no_call_return() to better handle 'returns' that do > not match the stack i.e. 'no call'. See code comments for details. This patch and patch 6 of the series do not seem to have been applied. Can they be applied?

Re: [PATCH v3 1/3] mmc: sdhci: use WP GPIO in sdhci_check_ro()

2019-02-12 Thread Adrian Hunter
gt; The below patch simply changes sdhci_check_ro() to use the value of > the WP GPIO if available. > > Signed-off-by: Thomas Petazzoni Acked-by: Adrian Hunter > --- > Changes since v2: > > - As suggested by Adrian Hunter, keep the argument of >sdhci_check_ro()

Re: [PATCH v2 3/3] mmc: sdhci-tegra: drop ->get_ro() implementation

2019-02-12 Thread Adrian Hunter
ed-by: Thierry Reding > Acked-by: Thierry Reding Acked-by: Adrian Hunter > --- > Changes since v1: > - Added Tested-by/Acked-by from Thierry Reding > > Note: this patch has only been compiled tested, as I don't have the > hardware to test it. > --- > drivers/mmc/

<    4   5   6   7   8   9   10   11   12   13   >