Re: Disk activity trigger: keeps blinking under full load

2019-05-25 Thread Jacek Anaszewski
hecks whether timer is pending and doesn't reset the timer in this case: if (test_bit(LED_BLINK_ONESHOT, _cdev->work_flags) && timer_pending(_cdev->blink_timer)) return; In effect you get gaps between timer expiration and setting of a new

Re: Droid 4 backlight support

2019-05-24 Thread Jacek Anaszewski
y functions it would be indeed very useful to have devicename. For backlight LED it would be "associated frame buffer device node name, e.g. fb0". Attached is what I came up with, and I was going to send to the list officially with the v5 of LED naming patch set. -- Best rega

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-24 Thread Jacek Anaszewski
ted branch ib-leds-mfd-regulator on linux-leds.git, but in the same time dropped the merge from the for-next. We will proceed further once we clarify the issue of cross-merging recently raised again by Linus. -- Best regards, Jacek Anaszewski

Re: linux-next: Tree for May 24 (leds-lm3697)

2019-05-24 Thread Jacek Anaszewski
help Say Y to enable the LM3697 LED driver for TI LMU devices. This supports the LED device LM3697. But for now I'm dropping the patch set anyway until we agree on how it should be merged across subsystems. -- Best regards, Jacek Anaszewski

Re: [GIT PULL] Immutable branch between LEDs, MFD and REGULATOR

2019-05-23 Thread Jacek Anaszewski
On 5/23/19 10:31 AM, Lee Jones wrote: On Wed, 22 May 2019, Jacek Anaszewski wrote: On 5/22/19 7:42 AM, Lee Jones wrote: On Tue, 21 May 2019, Jacek Anaszewski wrote: The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700

Re: [PATCH][V2] leds: TI LMU: fix u8 variable comparisons with less than zero

2019-05-22 Thread Jacek Anaszewski
bank->ramp_up_usec == 0 && lmu_bank->ramp_down_usec == 0) { ramp_up = 0; Applied. -- Best regards, Jacek Anaszewski

Re: [PATCH v4 0/6] LM36274 Introduction

2019-05-22 Thread Jacek Anaszewski
Documentation/devicetree/bindings/leds/leds-lm36274.txt create mode 100644 drivers/leds/leds-lm36274.c -- Best regards, Jacek Anaszewski

Re: [GIT PULL] Immutable branch between LEDs, MFD and REGULATOR

2019-05-22 Thread Jacek Anaszewski
On 5/22/19 7:42 AM, Lee Jones wrote: On Tue, 21 May 2019, Jacek Anaszewski wrote: The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel

Re: [GIT PULL] Immutable branch between LEDs, MFD and REGULATOR

2019-05-22 Thread Jacek Anaszewski
On 5/21/19 11:15 PM, Mark Brown wrote: On Tue, May 21, 2019 at 10:30:38PM +0200, Jacek Anaszewski wrote: regulator: lm363x: Make the gpio register enable flexible regulator: lm363x: Add support for LM36274 Why have these been applied, I haven't reviewed them? As far as I can

Re: [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-21 Thread Jacek Anaszewski
On 5/21/19 9:41 PM, Dan Murphy wrote: Jacek On 5/21/19 1:46 PM, Jacek Anaszewski wrote: Dan, On 5/21/19 8:25 PM, Dan Murphy wrote: Jacek On 5/21/19 12:40 PM, Jacek Anaszewski wrote: On 5/20/19 11:19 PM, Dan Murphy wrote: Jacek On 5/20/19 2:54 PM, Jacek Anaszewski wrote: Hi Dan, On 5/7

[GIT PULL] Immutable branch between LEDs, MFD and REGULATOR

2019-05-21 Thread Jacek Anaszewski
The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git tags/ti-lmu-led-drivers for you to fetch changes up to

Re: [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-21 Thread Jacek Anaszewski
Dan, On 5/21/19 8:25 PM, Dan Murphy wrote: Jacek On 5/21/19 12:40 PM, Jacek Anaszewski wrote: On 5/20/19 11:19 PM, Dan Murphy wrote: Jacek On 5/20/19 2:54 PM, Jacek Anaszewski wrote: Hi Dan, On 5/7/19 10:11 PM, Dan Murphy wrote: Introduce the LM36274 LED driver.  This driver uses the ti

Re: [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-21 Thread Jacek Anaszewski
On 5/20/19 11:19 PM, Dan Murphy wrote: Jacek On 5/20/19 2:54 PM, Jacek Anaszewski wrote: Hi Dan, On 5/7/19 10:11 PM, Dan Murphy wrote: Introduce the LM36274 LED driver.  This driver uses the ti-lmu MFD driver to probe this LED driver.  The driver configures only the LED registers and enables

Re: [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-20 Thread Jacek Anaszewski
r for TI LMU devices. + This supports the LED device LM36274. -- Best regards, Jacek Anaszewski

Re: [PATCH 0/2] Fix LED GPIO trigger behavior

2019-05-17 Thread Jacek Anaszewski
. Kun Yi (2): ledtrig-gpio: Request user input pin as GPIO ledtrig-gpio: 0 is a valid GPIO number drivers/leds/trigger/ledtrig-gpio.c | 35 - 1 file changed, 24 insertions(+), 11 deletions(-) -- Best regards, Jacek Anaszewski

Re: [PATCH v4 0/6] LM36274 Introduction

2019-05-14 Thread Jacek Anaszewski
/devicetree/bindings/leds/leds-lm36274.txt create mode 100644 drivers/leds/leds-lm36274.c -- Best regards, Jacek Anaszewski

[GIT PULL] LED updates for 5.2-rc1

2019-05-07 Thread Jacek Anaszewski
-02 22:54:51 +0200) Thanks, Jacek Anaszewski LED updates for 5.2-rc1. Andy Shevchenko (4): leds: pca963x: Revert "Add ACPI support" leds: pca955x

Re: [PATCH v3 0/7] LMU Common code intro

2019-05-01 Thread Jacek Anaszewski
Ekhm, I forgot to add the main recipient. Adding Lee. On 5/1/19 12:05 AM, Jacek Anaszewski wrote: Hi Lee, This patch set has dependency on the previous one for lm3532, which also touches ti-lmu.txt bindings, and for which I already created immutable branch. Now if I created another immutable

Re: [PATCH v3 0/7] LMU Common code intro

2019-04-30 Thread Jacek Anaszewski
it should be harmless for MFD. Best regards, Jacek Anaszewski On 4/30/19 9:17 PM, Dan Murphy wrote: Hello I have added the Reviewed-by for dt bindings as well as made the Kconfig change pointed out for the common code flag Dan Dan Murphy (7): dt-bindings: mfd: LMU: Fix lm3632 dt binding

Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices

2019-04-30 Thread Jacek Anaszewski
wish I had this comment 2 weeks ago. But I can fix it I will amend this while merging, no need to resend. -- Best regards, Jacek Anaszewski

[GIT PULL] LED update for 5.1-rc7

2019-04-24 Thread Jacek Anaszewski
at: git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git tags/leds-for-5.1-rc7 for you to fetch changes up to 52fb56f7b5a9cc23a07b2c237bad91180263a492: MAINTAINERS: LEDs: Add designated reviewer for LED subsystem (2019-04-24 21:07:18 +0200) Thanks, Jacek Anaszewski

Re: [PATCH v4 24/26] leds: gpio: Use generic support for composing LED names

2019-04-24 Thread Jacek Anaszewski
Pavel, Thanks for the review. On 4/24/19 4:04 PM, Pavel Machek wrote: On Wed 2019-04-17 22:54:37, Jacek Anaszewski wrote: Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Linus Walleij --- drivers/leds/leds-gpio.c | 23

Re: [PATCH v4 02/26] leds: class: Improve LED and LED flash class registration API

2019-04-24 Thread Jacek Anaszewski
quot; says .. well, inline this into caller, so there will be one function call, not two. Yes, I realized that right after sending the message. -- Best regards, Jacek Anaszewski

Re: [PATCH v4 22/26] leds: as3645a: Use generic support for composing LED names

2019-04-24 Thread Jacek Anaszewski
Pavel, On 4/24/19 4:01 PM, Pavel Machek wrote: Hi! Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Sakari Ailus +static int as3645a_led_class_setup(struct as3645a *flash) { struct led_classdev *fled_cdev

Re: [PATCH v4 20/26] leds: aat1290: Use generic support for composing LED names

2019-04-24 Thread Jacek Anaszewski
On 4/24/19 3:57 PM, Pavel Machek wrote: Hi! Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski @@ -257,9 +257,6 @@ static int aat1290_led_parse_dt(struct aat1290_led *led, return -EINVAL; } - led_cdev->n

Re: [PATCH v4 04/26] dt-bindings: leds: Add LED_COLOR_ID definitions

2019-04-24 Thread Jacek Anaszewski
Pavel, On 4/24/19 3:49 PM, Pavel Machek wrote: On Wed 2019-04-17 22:54:17, Jacek Anaszewski wrote: Add common LED color identifiers. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus

Re: [PATCH v4 02/26] leds: class: Improve LED and LED flash class registration API

2019-04-24 Thread Jacek Anaszewski
Hi Pavel, Thanks for the review. On 4/24/19 3:46 PM, Pavel Machek wrote: Hi! Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Acked-by: Pavel Machek +/** + * led_classdev_register_ext - register a new object of LED class with + *init data + * @parent: LED

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Jacek Anaszewski
On 4/18/19 7:12 PM, Jacek Anaszewski wrote: On 4/18/19 2:24 PM, Takashi Iwai wrote: On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: On Wed, 17 Apr 2019 22:54:14 +0200, Jacek Anaszewski wrote: led_colors clashes with the array

Re: [PATCH v4 11/26] dt-bindings: lp8860: Add function and color properties

2019-04-18 Thread Jacek Anaszewski
On 4/18/19 2:28 PM, Dan Murphy wrote: Jacek On 4/17/19 3:54 PM, Jacek Anaszewski wrote: Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy I gave reviewed-by for DT docs and teste

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Jacek Anaszewski
On 4/18/19 2:24 PM, Takashi Iwai wrote: On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: On Wed, 17 Apr 2019 22:54:14 +0200, Jacek Anaszewski wrote: led_colors clashes with the array of the same name being added to the LED class. Do

[PATCH v4 05/26] dt-bindings: leds: Add properties for LED name construction

2019-04-17 Thread Jacek Anaszewski
Introduce dedicated properties for conveying information about LED function and color. Mark old "label" property as deprecated. Additionally function-enumerator property is being provided for the cases when neither function nor color can be used for LED differentiation. Signed-off

[PATCH v4 03/26] dt-bindings: leds: Add LED_FUNCTION definitions

2019-04-17 Thread Jacek Anaszewski
Add initial set of common LED function definitions. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields --- include/dt-bindings/leds/common.h | 37

[PATCH v4 11/26] dt-bindings: lp8860: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --

[PATCH v4 15/26] dt-bindings: lm36010: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- Documentation/devicetree/bindings/leds/leds-lm3601x.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --

[PATCH v4 10/26] leds: lt3593: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Daniel Mack --- drivers/leds/leds-lt3593.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds

[PATCH v4 07/26] dt-bindings: sc27xx-blt: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang --- Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v4 09/26] dt-bindings: lt3593: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Daniel Mack --- Documentation/devicetree/bindings/leds/leds-lt3593.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --

[PATCH v4 16/26] leds: lm3601x: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- drivers/leds/leds-lm3601x.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/leds/leds-lm3601x.c b

[PATCH v4 14/26] leds: lm3692x: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
new devm_led_classdev_register_ext() API. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- drivers/leds/leds-lm3692x.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c index 4f413a7c5f05..f25ac6a98125 100644 --- a/driv

[PATCH v4 18/26] leds: cr0014114: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
new devm_led_classdev_register_ext() API. Signed-off-by: Jacek Anaszewski Cc: Oleh Kravchenko --- drivers/leds/leds-cr0014114.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/leds/leds-cr0014114.c b/drivers/leds/leds-cr0014114.c index 1c82152764d2..1b05456ee

[PATCH v4 24/26] leds: gpio: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Linus Walleij --- drivers/leds/leds-gpio.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds

[PATCH v4 19/26] dt-bindings: aat1290: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH v4 21/26] dt-bindings: as3645a: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Also, fix malformed syntax of address-cells and size-cells in the example. Signed-off-by: Jacek Anaszewski Cc: Sakari Ailus --- .../devicetree/bindings/leds/ams,as3645a.txt | 22

[PATCH v4 25/26] dt-bindings: an30259a: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Simon Shields --- .../devicetree/bindings/leds/leds-an30259a.txt | 22 +- 1 file changed, 17 insertions(+), 5 deletions(

[PATCH v4 23/26] dt-bindings: leds-gpio: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Linus Walleij --- .../devicetree/bindings/leds/leds-gpio.txt | 23 +++--- 1 file changed, 16 insertions(+), 7 deletions(

[PATCH v4 22/26] leds: as3645a: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Sakari Ailus --- drivers/leds/leds-as3645a.c | 69 - 1 file changed, 25 insertions(+), 44 deletions(-) diff --git a/drivers/leds/leds

[PATCH v4 20/26] leds: aat1290: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-aat1290.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c index

[PATCH v4 26/26] leds: an30259a: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Simon Shields --- drivers/leds/leds-an30259a.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-an30259a.c b/drivers

[PATCH v4 13/26] dt-bindings: lm3692x: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --

[PATCH v4 17/26] dt-bindings: cr0014114: Add function and color properties

2019-04-17 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Oleh Kravchenko --- .../devicetree/bindings/leds/leds-cr0014114.txt| 26 -- 1 file changed, 19 insertions(+), 7 deletions(

[PATCH v4 04/26] dt-bindings: leds: Add LED_COLOR_ID definitions

2019-04-17 Thread Jacek Anaszewski
Add common LED color identifiers. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields --- include/dt-bindings/leds/common.h | 11 +++ 1 file changed, 11

[PATCH v4 02/26] leds: class: Improve LED and LED flash class registration API

2019-04-17 Thread Jacek Anaszewski
on registration from the beginning. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields --- drivers/leds/led-class-flash.c | 9 + drivers/leds/led

[PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-17 Thread Jacek Anaszewski
plement LED controls via LED class") Signed-off-by: Jacek Anaszewski Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Arnd Bergmann --- sound/usb/line6/toneport.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c in

[PATCH v4 00/26] Add generic support for composing LED class device name

2019-04-17 Thread Jacek Anaszewski
tes for optimalization and the first users of the new led_compose_name() API. The modifications were tested with Qemu, by stubbing the driver internals where hardware interaction was needed for proper probing. Thanks, Jacek Anaszewski Jacek Anaszewski (26): ALSA: line6: Avoid polluting led_* na

[PATCH v4 06/26] leds: core: Add support for composing LED class device names

2019-04-17 Thread Jacek Anaszewski
ass device's parent device, which proves that using vendor or product name for filling devicename section deosn't convey any added value since that information is already available in sysfs. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Wall

[PATCH v4 12/26] leds: lp8860: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. While at it, avoid iterating through available child of nodes in favor of obtaining single expected child node using single call to of_get_next_available_child(). Signed-off-by: Jacek Anaszewski Cc: Dan Murphy

[PATCH v4 08/26] leds: sc27xx-blt: Use generic support for composing LED names

2019-04-17 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang --- drivers/leds/leds-sc27xx-bltc.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers

Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention

2019-04-13 Thread Jacek Anaszewski
Dan, On 4/13/19 12:02 AM, Dan Murphy wrote: All On 4/12/19 2:10 PM, Jacek Anaszewski wrote: Dan, On 4/12/19 1:50 PM, Dan Murphy wrote: Marek On 4/11/19 5:07 PM, Marek Behun wrote: Hi Dan, this probaly was discussed, but I did not follow brightness model discussions: what will happen if I

Re: [PATCH v2 4/6] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-12 Thread Jacek Anaszewski
And one more: [5] - LED naming patch set v3 On 4/11/19 9:48 PM, Jacek Anaszewski wrote: Hi Rob, I've collected references to the DT patches we're waiting to be reviewed. This is just to make sure that none of them will be missed - recent traffic on the linux-leds list is a bit heavier. [0

Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention

2019-04-12 Thread Jacek Anaszewski
Dan, On 4/12/19 8:46 PM, Dan Murphy wrote: Jacek On 4/12/19 1:14 PM, Jacek Anaszewski wrote: Hi Marek, On 4/12/19 12:07 AM, Marek Behun wrote: Hi Dan, this probaly was discussed, but I did not follow brightness model discussions: what will happen if I set yellow by writing into yellow mode

Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention

2019-04-12 Thread Jacek Anaszewski
. But this violates the requirements asked for. Dan Marek -- Best regards, Jacek Anaszewski

Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention

2019-04-12 Thread Jacek Anaszewski
it could be useful to define brightness model that allows to go from blue color (for cold) up to red (hot) for representing a temperature for instance. These ideas will need however more documentation. Generally we aim to propose only a convention. -- Best regards, Jacek Anaszewski

Re: [PATCH v2 4/6] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-11 Thread Jacek Anaszewski
}; - }; - - fault-monitor { - compatible = "ti,lm3697-fault-monitor"; - }; -}; [0] https://marc.info/?l=linux-kernel=155414072611538=2 [1] https://marc.info/?l=devicetree=155447454524411=2 [2] https://lore.kernel.org/patchwork/patch/1058762/ [3] https://marc.info/?l=devicetree=155447624324995=2 [4] https://lore.kernel.org/patchwork/patch/1058779/ -- Best regards, Jacek Anaszewski

Re: [PATCH 1/6] regulator: lm363x: Make the gpio register enable flexible

2019-04-09 Thread Jacek Anaszewski
, +lm363x_regulator_desc[id].enable_reg, LM3632_EXT_EN_MASK, LM3632_EXT_EN_MASK); if (ret) { -- Best regards, Jacek Anaszewski

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-08 Thread Jacek Anaszewski
Hi Dmitry, Thanks for the review. On 4/8/19 12:01 AM, Dmitry Torokhov wrote: Hi Jacek, On Fri, Apr 5, 2019 at 1:00 PM Jacek Anaszewski wrote: Hi all, On 4/5/19 10:42 AM, Enric Balletbo i Serra wrote: Hi, On 5/4/19 0:42, Guenter Roeck wrote: On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek

Re: [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-04-07 Thread Jacek Anaszewski
configuration. Reviewed-by: Rob Herring Signed-off-by: Dan Murphy --- Thank you for your work on this set. Applied. -- Best regards, Jacek Anaszewski

[GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-07 Thread Jacek Anaszewski
5:49 +0200) Thanks, Jacek Anaszewski LM3532 backlight driver improvements and relocation Dan Murphy (4): dt: lm3532: Add lm3532 dt doc and update ti_lmu doc ARM:

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-04-07 Thread Jacek Anaszewski
On 4/5/19 12:00 AM, Tony Lindgren wrote: * Jacek Anaszewski [190404 20:12]: Tony, On 3/21/19 3:28 PM, Dan Murphy wrote: Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately. Signed-off

[GIT PULL] LM3532 backlight support improvements and relocation

2019-04-07 Thread Jacek Anaszewski
up to b3e9d18dc4a5e4d329dea32b59bdde5e012ae64a: leds: lm3532: Introduce the lm3532 LED driver (2019-04-06 21:06:07 +0200) Thanks, Jacek Anaszewski LM3532 backlight driver improvements and relocation

[GIT PULL] LM3532 backlight support improvements and relocation

2019-04-07 Thread Jacek Anaszewski
up to b3e9d18dc4a5e4d329dea32b59bdde5e012ae64a: leds: lm3532: Introduce the lm3532 LED driver (2019-04-06 21:06:07 +0200) Thanks, Jacek Anaszewski LM3532 backlight driver improvements and relocation

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-06 Thread Jacek Anaszewski
klight on USB keyboards. For LEDs exposed through the input-LED bridge my get_led_device_info.sh script nicely reports: associated input node: input1 It just does: readlink input1\:\:numlock/device which prints: "../../input1 " And I believe that for backlight LEDs exposed by input subsystem it should be similarly since the input device related to USB keyboard is a child of USB device: /sys/class/leds# readlink input1::numlock ../../devices/pci:00/:00:14.0/usb2/2-4/2-4:1.0/0003:1C4F:0002.0002/input/input1/input1::numlock -- Best regards, Jacek Anaszewski

Re: [PATCH v3 05/25] leds: core: Add support for composing LED class device names

2019-04-05 Thread Jacek Anaszewski
Hi Dan, Thank you for the review. On 4/5/19 1:45 PM, Dan Murphy wrote: Jacek On 3/31/19 12:54 PM, Jacek Anaszewski wrote: Add generic support for composing LED class device name basing on fwnode_handle data. The function composes device name according to either a new pattern or the legacy

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-05 Thread Jacek Anaszewski
ommon.h, so that they would be more naturally accessible for non DT based drivers. [0] https://lkml.org/lkml/2019/3/31/222 [1] https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/log/?h=led_naming_v3 -- Best regards, Jacek Anaszewski

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-04-04 Thread Jacek Anaszewski
= <0>; + label = "platform::kbd_backlight"; s/platform::kbd_backlight/:kbd_backlight/ and then send you a pull request. Would you be OK with that? }; }; }; -- Best regards, Jacek Anaszewski

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Jacek Anaszewski
-resolution sounds good to me. Rob has the last word, though. -- Best regards, Jacek Anaszewski

Re: [PATCH v3 00/25] Add generic support for composing LED class device name

2019-04-04 Thread Jacek Anaszewski
rty it will be concatenated with the led_hw_name provided by the driver. The problem would be only with the drivers whose bindings erroneously require devicename section in the label. They will need to be left intact. -- Best regards, Jacek Anaszewski

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-04 Thread Jacek Anaszewski
mode panel support". So feel free to add: Tested-by: Tony Lindgren -- Best regards, Jacek Anaszewski

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Jacek Anaszewski
Dan, On 4/3/19 10:23 PM, Dan Murphy wrote: Jacek On 4/3/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the patch. You need Lee Jones on CC for this series. Yes I saw I missed Lee. One more comment below. On 3/25/19 3:24 PM, Dan Murphy wrote: The LM3697 is a single function

Re: [PATCH] leds: Small fixes for Flash class description

2019-04-03 Thread Jacek Anaszewski
ternal API to it. You'll need this to provide support for the flash related features of a LED device. It can be built as a module. Applied. -- Best regards, Jacek Anaszewski

Re: [PATCH 0/5] TI LMU rework

2019-04-03 Thread Jacek Anaszewski
. The patch set looks good to me with a single reservation I've just posted. You can base your work off it. -- Best regards, Jacek Anaszewski

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-03 Thread Jacek Anaszewski
047 (11bit). We should use led-max-microamp for that, if possible. -- Best regards, Jacek Anaszewski

Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references

2019-04-03 Thread Jacek Anaszewski
On 4/3/19 9:57 AM, Lee Jones wrote: On Mon, 25 Mar 2019, Jacek Anaszewski wrote: On 3/25/19 8:53 AM, Lee Jones wrote: On Sat, 23 Mar 2019, Jacek Anaszewski wrote: Hi Lee, Can we have your ack for this going via LED tree, please? Patch looks okay. You can take it through the LED

Re: [PATCH v3 2/2] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-03 Thread Jacek Anaszewski
It bypasses internal LED core workqueue. While its use here is not incorrect per se, it is of no avail to use public LED subsystem API just for calling brightness_set_blocking op initialized also in this driver. Just call keyboard_led_set_brightness() directly. With that: Acked-by: Jacek Anas

Re: [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention

2019-04-02 Thread Jacek Anaszewski
And now is this moment - we'd like to hear the feedback from DT guys. -- Best regards, Jacek Anaszewski

Re: [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention

2019-04-02 Thread Jacek Anaszewski
a backward compatible way, which is especially important in relation to existing triggers. This is our attempt of addressing that problem in a color space agnostic way. It was inspired by out-of-tree approach presented by Vesa few months ago. [0] https://www.spinics.net/lists/linux-leds/msg11388.html -- Best regards, Jacek Anaszewski

Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr

2019-04-02 Thread Jacek Anaszewski
int blinkm_probe(struct i2c_client *client, goto exit; } - data->i2c_addr = 0x09; data->i2c_addr = 0x08; /* i2c addr - use fake addr of 0x08 initially (real is 0x09) */ data->fw_ver = 0xfe; Applied. -- Best regards, Jacek Anaszewski

Re: [PATCH] leds: fix a potential NULL pointer dereference

2019-04-02 Thread Jacek Anaszewski
Hi Geert, On 4/1/19 9:08 AM, Geert Uytterhoeven wrote: Hi Jacek, On Sun, Mar 31, 2019 at 1:01 PM Jacek Anaszewski wrote: On 3/31/19 11:06 AM, Geert Uytterhoeven wrote: On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski wrote: On 3/9/19 7:04 AM, Kangjie Lu wrote: In case of_match_device

[PATCH v3 06/25] dt-bindings: sc27xx-blt: Add function and color properties

2019-03-31 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang --- Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v3 03/25] dt-bindings: leds: Add LED_COLOR_ID definitions

2019-03-31 Thread Jacek Anaszewski
Add common LED color identifiers for use in Device Tree. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields --- include/dt-bindings/leds/common.h | 11 +++ 1

[PATCH v3 09/25] leds: lt3593: Use generic support for composing LED names

2019-03-31 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Daniel Mack --- drivers/leds/leds-lt3593.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds

[PATCH v3 11/25] leds: lp8860: Use generic support for composing LED names

2019-03-31 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. While at it, avoid iterating through available child of nodes in favor of obtaining single expected child node using single call to of_get_next_available_child(). Signed-off-by: Jacek Anaszewski Cc: Dan Murphy

[PATCH v3 14/25] dt-bindings: lm36010: Add function and color properties

2019-03-31 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- Documentation/devicetree/bindings/leds/leds-lm3601x.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --

[PATCH v3 17/25] leds: cr0014114: Use generic support for composing LED names

2019-03-31 Thread Jacek Anaszewski
new devm_led_classdev_register_ext() API. Signed-off-by: Jacek Anaszewski Cc: Oleh Kravchenko --- drivers/leds/leds-cr0014114.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/leds/leds-cr0014114.c b/drivers/leds/leds-cr0014114.c index 1c82152764d2..08c894651

[PATCH v3 15/25] leds: lm3601x: Use generic support for composing LED names

2019-03-31 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Dan Murphy --- drivers/leds/leds-lm3601x.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/leds/leds-lm3601x.c b

[PATCH v3 02/25] dt-bindings: leds: Add LED_FUNCTION definitions

2019-03-31 Thread Jacek Anaszewski
Add initial set of common LED function definitions for use in Device Tree. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields --- include/dt-bindings/leds/common.h | 36

[PATCH v3 20/25] dt-bindings: as3645a: Add function and color properties

2019-03-31 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Also, fix malformed syntax of address-cells and size-cells in the example. Signed-off-by: Jacek Anaszewski Cc: Sakari Ailus --- .../devicetree/bindings/leds/ams,as3645a.txt | 22

[PATCH v3 22/25] dt-bindings: leds-gpio: Add function and color properties

2019-03-31 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski Cc: Linus Walleij --- .../devicetree/bindings/leds/leds-gpio.txt | 23 +++--- 1 file changed, 16 insertions(+), 7 deletions(

[PATCH v3 05/25] leds: core: Add support for composing LED class device names

2019-03-31 Thread Jacek Anaszewski
ls of a LED class device's parent device, which proves that getting rid of a devicename section from LED name pattern is justified since this information is already available in sysfs. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Pavel Machek Cc: Dan Murphy Cc: Daniel Mack Cc: Linus

[PATCH v3 23/25] leds: gpio: Use generic support for composing LED names

2019-03-31 Thread Jacek Anaszewski
Switch to using generic LED support for composing LED class device name. Signed-off-by: Jacek Anaszewski Cc: Linus Walleij --- drivers/leds/leds-gpio.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds

[PATCH v3 18/25] dt-bindings: aat1290: Add function and color properties

2019-03-31 Thread Jacek Anaszewski
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation

<    1   2   3   4   5   6   7   8   9   10   >