Re: [PATCH] clk: meson: make shipped controller configurable

On Thu 10 Sep 2020 at 09:52, Stephen Boyd wrote: > Quoting Jerome Brunet (2020-08-28 08:47:35) >> Add the necessary so bits so unnecessary amlogic clock controllers can be > > s/so// Fixed and applied > >> compiled out. This allows to save a few kB when nece

Re: [PATCH 07/10] clk: meson: Simplify with dev_err_probe()

On Wed 02 Sep 2020 at 17:03, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jerome Brunet > --- > drivers/clk

Re: [PATCH v2] clk: meson: g12a: mark fclk_div2 as critical

On Fri 28 Aug 2020 at 17:52, Stefan Agner wrote: > On Amlogic Meson G12b platform, similar to fclk_div3, the fclk_div2 > seems to be necessary for the system to operate correctly as well. > > Typically, the clock also gets chosen by the eMMC peripheral. This > probably masked the problem so

[PATCH] clk: meson: make shipped controller configurable

Add the necessary so bits so unnecessary amlogic clock controllers can be compiled out. This allows to save a few kB when necessary. Signed-off-by: Jerome Brunet --- drivers/clk/meson/Kconfig | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH] arm64: dts: meson: vim3l: remove sound card definition

The sound card definition should have been removed when the common definition was added to the vim3 dtsi but this slips through. Remove it now. Fixes: 7c9c06246cea ("arm64: dts: meson: vim3: make sound card common to all variants") Signed-off-by: Jerome Brunet --- .../dts/amlogic

[PATCH] ASoC: meson: axg-toddr: fix channel order on g12 platforms

is not easily predictable. According to the documentation, this bit is not present on the axg series. Set the bit on g12 and fix the problem. Fixes: a3c23a8ad4dc ("ASoC: meson: axg-toddr: add g12a support") Reported-by: Nicolas Belin Signed-off-by: Jerome Brunet --- sound/soc/meson/a

Re: [PATCH] clk: meson: g12a: mark fclk_div2 as critical

On Thu 27 Aug 2020 at 23:43, Stefan Agner wrote: > On Amlogic Meson G12b platform, similar to fclk_div3, the fclk_div2 > seems to be necessary for the system to operate correctly as well. > > Typically, the clock also gets chosen by the eMMC peripheral. This > probably masked the problem so

Re: [PATCH] clk: meson: g12a: mark fclk_div2 as CLK_IGNORE_UNUSED

On Fri 28 Aug 2020 at 15:07, Marek Szyprowski wrote: > Add CLK_IGNORE_UNUSED flag to the "fclk_div2" clock to fix boot hang on > the Hardkernel's Odroid N2 board (with bootloader booted from SD card and > kernel loaded via FTFP). > > It looks that this clock is disabled by the generic unused

Re: [PATCH] ASoC: meson: cards: deal dpcm flag change

On Thu 27 Aug 2020 at 14:43, Marek Szyprowski wrote: > Hi Jerome, > > On 31.07.2020 14:06, Jerome Brunet wrote: >> Commit b73287f0b074 ("ASoC: soc-pcm: dpcm: fix playback/capture checks") >> changed the meaning of dpcm_playback/dpcm_capture and now requir

[PATCH] arm64: dts: meson: vim3: make sound card common to all variants

The vim3 sound card definition should be same all the vim3 variants Move the definition to the appropriate device tree file. Signed-off-by: Jerome Brunet --- .../dts/amlogic/meson-g12b-khadas-vim3.dtsi | 88 -- .../boot/dts/amlogic/meson-khadas-vim3.dtsi | 90

[PATCH] arm64: dts: meson: vim3: correct led polarity

The LEDs on the vim3 are active when the gpio is high, not low. Fixes: c6d29c66e582 ("arm64: dts: meson-g12b-khadas-vim3: add initial device-tree") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] ASoC: core: restore dpcm flags semantics

On Thu 30 Jul 2020 at 20:52, Mark Brown wrote: > On Thu, Jul 30, 2020 at 11:06:23AM -0500, Pierre-Louis Bossart wrote: >> On 7/30/20 4:04 AM, Jerome Brunet wrote: >> > On Wed 29 Jul 2020 at 17:56, Pierre-Louis Bossart >> > wrote: >> > > O

[PATCH] ASoC: meson: cards: deal dpcm flag change

/capture checks") Signed-off-by: Jerome Brunet --- Hi, For the cards be actually fixed, change 'ASoC: core: use less strict tests for dailink capabilities' will need to merged as well. snd_soc_dai_link_set_capabilities() as implemented in 25612477d20b5 ('ASoC: soc-dai: set dai_link dpcm_

Re: [PATCH] ASoC: core: restore dpcm flags semantics

On Thu 30 Jul 2020 at 18:06, Pierre-Louis Bossart wrote: > On 7/30/20 4:04 AM, Jerome Brunet wrote: >> >> On Wed 29 Jul 2020 at 17:56, Pierre-Louis Bossart >> wrote: >> >>> On 7/29/20 10:46 AM, Jerome Brunet wrote: >>>> commit b73287f0b0745 ('

Re: [PATCH] ASoC: core: restore dpcm flags semantics

On Wed 29 Jul 2020 at 17:56, Pierre-Louis Bossart wrote: > On 7/29/20 10:46 AM, Jerome Brunet wrote: >> commit b73287f0b0745 ('ASoC: soc-pcm: dpcm: fix playback/capture checks') >> changed dpcm_playback and dpcm_capture semantic by throwing an error if >> these flags are

[PATCH] ASoC: core: restore dpcm flags semantics

t with DAI caps, breaking a few cards along the way. This change drops the added error conditions and restore the initial flag semantics. Cc: Pierre-Louis Bossart Signed-off-by: Jerome Brunet --- Hi Mark, Because b73287f0b0745 ('ASoC: soc-pcm: dpcm: fix playback/capture checks') introduced

[PATCH 0/4] ASoC: meson: tdm fixes

This patcheset is collection of fixes for the TDM input and output the axg audio architecture. Its fixes: - slave mode format setting - g12 and sm1 skew offset - tdm clock inversion - standard daifmt props names which don't require a specific prefix Jerome Brunet (4): ASoC: meson: axg-tdm

[PATCH 3/4] ASoC: meson: axg-tdm-formatters: fix sclk inversion

and fix the sclk phase. Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-formatter.c | 11 ++- sound/soc/meson/axg-tdm-formatter.h | 1 - sound/soc/meson/axg-tdmin.c | 2 -- sound/soc/meson/ax

[PATCH 4/4] ASoC: meson: cards: remove DT_PREFIX for standard daifmt properties

Standard dai format property don't need the "amlogic," prefix. There nothing amlogic specific about them. Just remove it. Fixes: 435857e015dc ("ASoC: meson: align axg card driver with DT bindings documentation") Signed-off-by: Jerome Brunet --- sound/soc/meson/meson-card-ut

[PATCH 1/4] ASoC: meson: axg-tdm-interface: fix link fmt setup

The .set_fmt() callback of the axg tdm interface incorrectly test the content of SND_SOC_DAIFMT_MASTER_MASK as if it was a bitfield, which it is not. Implement the test correctly. Fixes: d60e4f1e4be5 ("ASoC: meson: add tdm interface driver") Signed-off-by: Jerome Brunet --- sound/soc

[PATCH 2/4] ASoC: meson: axg-tdmin: fix g12a skew

After carefully checking the result provided by the TDMIN on the g12a and sm1 SoC families, the TDMIN skew offset appears to be 3 instead of 2 on the axg. Fixes: f01bc67f58fd ("ASoC: meson: axg-tdm-formatter: rework quirks settings") Signed-off-by: Jerome Brunet --- sound/soc/meson/a

[PATCH 0/3] clk: meson: axg-audio: fix tdmout sclk inverter

be the inverse of the inverter bit at all time. Quite a lot of lines for a single bit ... Jerome Brunet (3): clk: meson: add sclk-ws driver clk: meson: axg-audio: separate axg and g12a regmap tables clk: meson: axg-audio: fix g12a tdmout sclk inverter drivers/clk/meson/axg-audio.c | 214

[PATCH 3/3] clk: meson: axg-audio: fix g12a tdmout sclk inverter

Fix the tdmout inverter of the g12a and following SoC families. This inverter is special and needs two bits to be the inverse of each other for the inverter to operate properly. Fixes: 075001385c66 ("clk: meson: axg-audio: add g12a support") Signed-off-by: Jerome Brunet --- drivers

[PATCH 2/3] clk: meson: axg-audio: separate axg and g12a regmap tables

There are more differences than what we initially thought. Let's keeps things clear and separate the axg and g12a regmap tables of the audio clock controller. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 135 -- 1 file changed, 127 insertions

[PATCH 1/3] clk: meson: add sclk-ws driver

and the manual setting was added on g12a. Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-phase.c | 56 +++ drivers/clk/meson/clk-phase.h | 6 2 files changed, 62 insertions(+) diff --git a/drivers/clk/meson/clk-phase.c b/drivers/clk/meson/clk-phase.c index

[PATCH] ASoC: soc-component: don't report of_xlate_dai_name failures

Morimoto Signed-off-by: Jerome Brunet --- If we wish to report an error when no name is found for dai phandle, I think it would be more approriate to it with with "struct device *" of the card, which is the one actually failing to get what it needs. These user of snd_soc_get_da

Re: [PATCH 3/3] arm64: dts: meson: add support for the ODROID-N2+

On Sun 19 Jul 2020 at 16:10, Christian Hewitt wrote: > HardKernel ODROID-N2+ uses an Amlogic S922X rev. C chip capable of higher > clock speeds than the original ODROID-N2. Hardkernel supports the big cpu > cluster at 2.4GHz and the little cpu cluster at 2.0GHz. Opp points and > regulator

Re: [PATCH v2 3/3] arm64: dts: meson: add audio playback to u200

On Sun 19 Jul 2020 at 04:45, Christian Hewitt wrote: > Add initial support limited to HDMI i2s and S/PDIF (LPCM). Nack. #1. Same comment as before on spdifout B and SPDIF HDMI input. #2. the u200 is a special reference device with 2 onboards codecs, external connector for audio daugther

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add support for the WeTek Core 2

On Sat 18 Jul 2020 at 07:00, Christian Hewitt wrote: > The WeTek Core 2 is a commercial Android device based on the Amlogic Q200 > reference design using the S912-H chipset. Specs: This series is missing a cover-letter. Please add a cover letter when sending more that one patch > > 3GB DDR3

Re: [PATCH 0/2] arm64: dts: meson: add more SM1 soundcards

eson-sm1-khadas-vim3l.dts| 88 +++ > .../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 88 +++ > 2 files changed, 176 insertions(+) Acked-by: Jerome Brunet

Re: [PATCH 00/12] arm64: dts: meson: add more GX soundcards

On Sat 18 Jul 2020 at 08:57, Christian Hewitt wrote: > From: chewitt > > This series adds basic support for LPCM audio over HDMI and S/PDIF > interfaces to GXBB/GXL/GXM devices without support. I'm sure audio > support can be extended in places (some devices have internal DACs > and

Re: [PATCH 09/12] arm64: dts: meson: add audio playback to rbox-pro

On Sat 18 Jul 2020 at 08:57, Christian Hewitt wrote: > Add initial support limited to HDMI i2s and SPDIF (LPCM). > > Signed-off-by: Christian Hewitt > --- > .../boot/dts/amlogic/meson-gxm-rbox-pro.dts | 80 +++ > 1 file changed, 80 insertions(+) > > diff --git

Re: [PATCH 04/12] arm64: dts: meson: add audio playback to nexbox-a1

On Sat 18 Jul 2020 at 08:57, Christian Hewitt wrote: > Add initial support is limited to HDMI i2s and SPDIF (LPCM). > > Signed-off-by: Christian Hewitt > --- > .../boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 80 +++ > 1 file changed, 80 insertions(+) > > diff --git

Re: [PATCH 2/2] arm64: dts: meson: add initial Beelink GS-King-X device-tree

On Sat 18 Jul 2020 at 07:22, Christian Hewitt wrote: > The Shenzen AZW (Beelink) GS-King-X is based on the Amlogic W400 reference > board with an S922X-H chip. > > - 4GB LPDDR4 RAM > - 64GB eMMC storage > - 10/100/1000 Base-T Ethernet > - AP6356S Wireless (802.11 a/b/g/n/ac, BT 4.1) > - HDMI

Re: [PATCH v2] ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback

use modern dai_link style") > Signed-off-by: Jing Xiangfeng Reviewed-by: Jerome Brunet > --- > sound/soc/meson/axg-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c > index 89f7f64747c

Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback

On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng wrote: > axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add > the missed function call to fix it. > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > Signed-off-by: Jing Xiangfeng Thanks for fixing

Re: [PATCH 0/2] clk: meson8b: add two missing gate clocks

On Mon 29 Jun 2020 at 22:39, Martin Blumenstingl wrote: > While trying to figure out how to set up the video clocks on the 32-bit > SoCs I found that the current clock tree is missing two gates. This adds > the missing gates based on evidence found in the public S805 datasheet, > the GXBB

[PATCH 1/2] arm64: dts: meson: odroid-n2: enable audio loopback

Add capture pcm interfaces and loopback routes to the odroid-n2 Signed-off-by: Jerome Brunet --- .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 65 +-- 1 file changed, 61 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch

[PATCH 0/2] arm64: dts: meson: odroid-n2: update sound card

This patchset adds the support for the TDM loopback and audio on the jack output using the internal codec. Jerome Brunet (2): arm64: dts: meson: odroid-n2: enable audio loopback arm64: dts: meson: odroid-n2: add jack audio output support .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 136

[PATCH 2/2] arm64: dts: meson: odroid-n2: add jack audio output support

Add support for audio on jack socket of the odroid-n2 Signed-off-by: Jerome Brunet --- .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 79 +-- 1 file changed, 74 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot

Re: [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2

On Sat 20 Jun 2020 at 18:14, Martin Blumenstingl wrote: > Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't > know the relation between this clock and RGMII Ethernet. It turns out > that fclk_div2 is used as "timing adjustment clock" to generate the RX > delay on the MAC

Re: [PATCH 0/2] clk: meson: g12a: Add the NNA source clocks

On Wed 10 Jun 2020 at 10:30, Neil Armstrong wrote: > This patchset adds the Neural Network Accelerator source clocks present > on the Amlogic SM1 SoCs family. > > Dmitry Shmidt (2): > dt-bindings: clk: g12a-clkc: Add NNA CLK Source clock IDs > clk: meson: g12a: Add support for NNA CLK

[PATCH] ASoC: meson: imply acodec glue on axg sound card

When axg card driver support is enabled, lets enable the related internal DAC glue by default. Signed-off-by: Jerome Brunet --- sound/soc/meson/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/meson/Kconfig b/sound/soc/meson/Kconfig index 8b6295283989..363dc3b1bbe4 100644

Re: [PATCH] pinctrl: meson: fix drive strength register and bit calculation

On Thu 11 Jun 2020 at 07:40, Hyeonki Hong wrote: > On Wed, Jun 10, 2020 at 03:09:42PM +0200, Jerome Brunet wrote: >> >> On Wed 10 Jun 2020 at 06:13, hhk7...@gmail.com wrote: >> >> > From: Hyeonki Hong >> > >> > If a GPIO bank has gr

[PATCH] arm64: dts: meson: add missing gxl rng clock

The peripheral clock of the RNG is missing for gxl while it is present for gxbb. Fixes: 1b3f6d148692 ("ARM64: dts: meson-gx: add clock CLKID_RNG0 to hwrng node") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 5 + 1 file changed, 5 insertions(+)

Re: sound/soc/meson/t9015.c:315:34: warning: unused variable 't9015_ids'

On Sun 31 May 2020 at 05:00, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: ffeb595d84811dde16a28b33d8a7cf26d51d51b3 > commit: 33901f5b9b16d212ee58865e9e8e80fc813f12da ASoC: meson: add t9015 > internal DAC driver >

Re: [PATCH] pinctrl: meson: fix drive strength register and bit calculation

On Wed 10 Jun 2020 at 06:13, hhk7...@gmail.com wrote: > From: Hyeonki Hong > > If a GPIO bank has greater than 16 pins, PAD_DS_REG is split into two > registers. However, when register and bit were calculated, the first > register defined in the bank was used, and the bit was calculated based

Re: [PATCH] soc/meson: add missing free_irq() in error path

On Sat 06 Jun 2020 at 17:31, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. > > Signed-off-by: Pavel Machek (CIP) Reviewed-by: Jerome Brunet > > diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c > index 2e9b56b29d31..b

Re: [PATCH] ASoC: meson: fix memory leak of links if allocation of ldata fails

t; Addresses-Coverity: ("Resource leak") > Fixes: 7864a79f37b5 ("ASoC: meson: add axg sound card support") > Signed-off-by: Colin Ian King Looks good, Thx Acked-by: Jerome Brunet > --- > sound/soc/meson/meson-card-utils.c | 17 - > 1 file

Re: [PATCH] clk: add api to get clk consummer from clk_hw

On Wed 27 May 2020 at 22:07, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, May 19, 2020 at 7:09 PM Jerome Brunet wrote: > [...] >> + * Calls to this function must be balanced with calls clk_put() >> + */ >> +struct clk *clk_hw_get_clk(struct clk_hw *hw) &

Re: [PATCH] clk: add api to get clk consummer from clk_hw

On Wed 27 May 2020 at 11:17, Stephen Boyd wrote: > Quoting Jerome Brunet (2020-05-19 10:04:40) >> clk_register() is deprecated. Using 'clk' member of struct clk_hw is >> discouraged. With this constrainst, it is difficult for driver to > > s/constrainst/constraint/ >

[PATCH] clk: add api to get clk consummer from clk_hw

clk_hw. Like other clk_get() variant, each call to this helper must be balanced with a call to clk_put(). Cc: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/clk/clk.c| 17 + include/linux/clk-provider.h | 1 + 2 files changed, 18 insertions(+) diff

Re: [PATCH v7 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

results in command >> timeouts and thus decreases read performance. >> >> Tested-by: Wei Wang >> Tested-by: Xin Yin >> Reviewed-by: Xin Yin >> Tested-by: Anand Moon >> Signed-off-by: Martin Blumenstingl > > This looks good to me, however I

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

On Sun 10 May 2020 at 22:52, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, May 5, 2020 at 6:05 PM Jerome Brunet wrote: > [...] >> > 2. Keep the existing approach, with devm_clk_get(). I am fine with >> > this as well, we can always switch to 1) la

[PATCH 1/7] arm64: dts: meson: gxl: add acodec support

Add the internal audio DAC to the gxl SoC DT Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi index 44c0371f63ca

[PATCH 3/7] arm64: dts: meson: libretech-cc: add internal DAC support

Add the internal DAC support on the libretech CC. The output of this DAC is provided on the 3.5mm jack connector. Signed-off-by: Jerome Brunet --- .../amlogic/meson-gxl-s905x-libretech-cc.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH 7/7] arm64: dts: meson: g12: add internal DAC glue

add the internal DAC glue support on the g12 and sm1 family This glue connects the different TDM interfaces of the SoC to the internal audio DAC codec. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch

[PATCH 6/7] arm64: dts: meson: g12: add internal DAC

add internal audio DAC support on the g12 and sm1 SoC family Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson

[PATCH 0/7] arm64: dts: meson: add internal audio DAC support

://lore.kernel.org/r/20200122092526.2436421-1-jbru...@baylibre.com [1]: git://git.pengutronix.de/pza/linux.git reset/meson-gxl-dac Jerome Brunet (7): arm64: dts: meson: gxl: add acodec support arm64: dts: meson: p230-q200: add internal DAC support arm64: dts: meson: libretech-cc: add internal

[PATCH 2/7] arm64: dts: meson: p230-q200: add internal DAC support

Add the necessary bits to support the internal audio DAC the p230/q200 reference design derivated boards. The output of this DAC is provided on the 3.5mm jack connector Signed-off-by: Jerome Brunet --- .../boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 32 +++ 1 file changed, 32

[PATCH 4/7] arm64: dts: meson: libretech-ac: add internal DAC support

Add the internal DAC support on the libretech CC. The output of this DAC is provided on the 9J5 connector. Signed-off-by: Jerome Brunet --- .../amlogic/meson-gxl-s805x-libretech-ac.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson

[PATCH 5/7] arm64: dts: meson: libretech-pc: add internal DAC support

Add the internal DAC support on the libretech CC. The output of this DAC is provided on the 9J4 connector. Signed-off-by: Jerome Brunet --- .../dts/amlogic/meson-gx-libretech-pc.dtsi| 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gx

Re: [PATCH] dt-bindings: reset: meson: add gxl internal dac reset

On Wed 06 May 2020 at 16:54, Philipp Zabel wrote: > Hi Jerome, > > On Wed, 2020-05-06 at 15:50 +0200, Jerome Brunet wrote: >> On Tue 14 Apr 2020 at 10:28, Jerome Brunet wrote: >> >> > On Thu 23 Jan 2020 at 11:13, Philipp Zabel wrote: >> > >>

Re: [RFC] DPCM for Tegra

On Wed 06 May 2020 at 16:12, Sameer Pujar wrote: >>> >>> | Front End PCMs | SoC DSP | Back End DAIs| >>> >>> * >>> ADMAIF<0> <> * * -> I2S >>> * * >>> ADMAIF<1>

Re: [PATCH] dt-bindings: reset: meson: add gxl internal dac reset

On Tue 14 Apr 2020 at 10:28, Jerome Brunet wrote: > On Thu 23 Jan 2020 at 11:13, Philipp Zabel wrote: > >> On Wed, 2020-01-22 at 10:25 +0100, Jerome Brunet wrote: >>> Add the reset line of the internal DAC found on the amlogic gxl SoC family >>> &g

Re: [RFC] DPCM for Tegra

On Thu 30 Apr 2020 at 14:41, Sameer Pujar wrote: > At a high level Tegra Audio HW is depicted as below. > > | Front End PCMs | SoC DSP | Back End DAIs| > > * > ADMAIF<0> <> * * -> I2S >

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

On Tue 05 May 2020 at 10:17, Ulf Hansson wrote: > [...] > >> >> > + >> >> > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, >> >> > +onecell_data); >> >> >> >> I think registering a provider for a module that does not provide clocks

Re: stable-rc/linux-5.4.y bisection: baseline.dmesg.alert on meson-g12a-x96-max

On Sat 02 May 2020 at 16:09, Greg Kroah-Hartman wrote: > On Sat, May 02, 2020 at 09:47:21AM -0400, Sasha Levin wrote: >> On Fri, May 01, 2020 at 01:25:36PM +0100, Mark Brown wrote: >> > On Fri, May 01, 2020 at 12:57:27PM +0100, Guillaume Tucker wrote: >> > >> > > The call stack is not the

Re: [PATCH] clk: meson: meson8b: Don't rely on u-boot to init all GP_PLL registers

On Fri 01 May 2020 at 23:57, Martin Blumenstingl wrote: > Not all u-boot versions initialize the HHI_GP_PLL_CNTL[2-5] registers. > In that case all HHI_GPLL_PLL_CNTL[1-5] registers are 0x0 and when > booting Linux the PLL fails to lock. > The initialization sequence from u-boot is: > - put

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

On Thu 30 Apr 2020 at 13:10, Ulf Hansson wrote: > + Stephen > > On Thu, 30 Apr 2020 at 11:47, Jerome Brunet wrote: >> >> >> On Tue 28 Apr 2020 at 23:02, Martin Blumenstingl >> wrote: >> >> > The SDHC MMC host controller on Amlogic SoCs provide

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

On Tue 28 Apr 2020 at 23:02, Martin Blumenstingl wrote: > The SDHC MMC host controller on Amlogic SoCs provides an eMMC and MMC > card interface with 1/4/8-bit bus width. > It supports eMMC spec 4.4x/4.5x including HS200 (up to 100MHz clock). > > The public S805 datasheet [0] contains a short

Re: [PATCH] arm64: dts: meson: sm1-khadas-vim3l: add audio playback to vim3l

On Wed 15 Apr 2020 at 12:23, chewitt wrote: > From: Christian Hewitt > > Add the sound and related audio nodes to the VIM3L board. > > Signed-off-by: Christian Hewitt > --- > .../dts/amlogic/meson-sm1-khadas-vim3l.dts| 88 +++ > 1 file changed, 88 insertions(+) > > diff

Re: [PATCH] clk/meson: fixes memleak issue in init err branch

On Wed 29 Apr 2020 at 05:14, Bernard Zhao wrote: > In common init function, when run into err branch, we didn`t > use kfree to release kzmalloc area, this may bring in memleak Thx for reporting this Bernard. I'm not a fan of adding kfree everywhere. I'd much prefer a label and clear error

Re: [PATCH v2 0/4] clk: meson8b: updates for video clocks / resets

On Fri 17 Apr 2020 at 20:41, Martin Blumenstingl wrote: > This is the first batch of fixes and updates for the Meson8/8b/8m2 > clock controller driver. > > The first patch fixes the video clock hierarchy. Special thanks to > Neil for providing a lot of details about the video clock tree! > >

Re: [alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue

On Wed 23 Oct 2019 at 18:23, Takashi Iwai wrote: > On Wed, 23 Oct 2019 18:12:01 +0200, > Jerome Brunet wrote: >> >> This patchset fixes the locking issue reported by Russell. >> >> As explained a mutex was used as flag and held while returning to >> u

[PATCH 0/2] ASoC: hdmi-codec: fix locking issue

should be fine. Jerome Brunet (2): Revert "ASoC: hdmi-codec: re-introduce mutex locking" ASoC: hdmi-codec: re-introduce mutex locking again sound/soc/codecs/hdmi-codec.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) -- 2.21.0

[PATCH 2/2] ASoC: hdmi-codec: re-introduce mutex locking again

The dai codec needs to ensure that on one dai is used at any time. This is currently protected by bit atomic operation. With this change, it done with a mutex instead. Suggested-by: Mark Brown Signed-off-by: Jerome Brunet --- sound/soc/codecs/hdmi-codec.c | 23 --- 1 file

[PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking"

fa0: 000c8748 0189 0001 1fc0: 00f0 00056200 1fe0: 00f0 beac03a8 b6d6c835 b6d6f456 Fixes: eb1ecadb7f67 ("ASoC: hdmi-codec: re-introduce mutex locking") Reported-by: Russell King Signed-o

Re: [PATCH v3 2/4] pinctrl: meson: add a new dt parse callback for Meson-A series SoCs

On Wed 23 Oct 2019 at 14:33, Qianggui Song wrote: > On 2019/10/23 17:01, Jerome Brunet wrote: >> >> On Mon 14 Oct 2019 at 12:54, Qianggui Song wrote: >> >>> >>> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c >>> b/drivers/pinc

Re: [PATCH v3 2/4] pinctrl: meson: add a new dt parse callback for Meson-A series SoCs

On Mon 14 Oct 2019 at 12:54, Qianggui Song wrote: > Meson A1 Soc share the same register layout of pinmux with previous > Meson-G12A, however there is difference for gpio and pin config register > in A1. The main difference is that registers before A1 are grouped by > function while those of

Re: [PATCH] mmc: fix mmc dma operation

On Mon 21 Oct 2019 at 16:48, Ulf Hansson wrote: > On Mon, 21 Oct 2019 at 11:17, Jerome Brunet wrote: >> >> >> On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: >> >> > Hi, >> > >> > Thanks for the fix. >> > >> > First,

Re: [PATCH v2 3/3] clk: meson: a1: add support for Amlogic A1 clock driver

On Fri 18 Oct 2019 at 09:14, Jian Hu wrote: > The Amlogic A1 clock includes three drivers: > peripheral clocks, pll clocks, CPU clocks. > sys pll and CPU clocks will be sent in next patch. > > Unlike the previous series, there is no EE/AO domain > in A1 CLK controllers. > > Signed-off-by: Jian

Re: [PATCH v2 2/3] clk: meson: add support for A1 PLL clock ops

On Fri 18 Oct 2019 at 09:14, Jian Hu wrote: > The A1 PLL design is different with previous SoCs. The PLL > internal analog modules Power-on sequence is different > with previous, and thus requires a strict register sequence to > enable the PLL. Unlike the previous series, the maximum frequency

Re: [PATCH v2 1/3] dt-bindings: clock: meson: add A1 clock controller bindings

) 2019 Amlogic, Inc. All rights reserved. > + */ > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml#; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#; > + > +title: Amlogic Meson A/C serials Clock Control

Re: [PATCH] mmc: fix mmc dma operation

On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: > Hi, > > Thanks for the fix. > > First, you should add "mmc: meson-gx:" in the subject. > > On 21/10/2019 07:59, Jianxin Pan wrote: >> From: Nan Li >> >> In MMC dma transfer, the region requested by dma_map_sg() may be released >> by

Re: [PATCH] arm64: dts: meson-g12b-khadas-vim3: add missing frddr_a status property

c/meson-g12b-khadas-vim3.dtsi > @@ -152,6 +152,10 @@ > clock-latency = <5>; > }; > > +_a { > + status = "okay"; > +}; > + > _b { > status = "okay"; > }; Acked-by: Jerome Brunet

Re: [PATCH] arm64: dts: meson: khadas-vim3l: enable audio

On Fri 18 Oct 2019 at 12:05, Christian Hewitt wrote: > Add and enable the audio nodes on the VIM3L. This is based on the recent > submission for the SEI610 device [1] and the existing VIM3 dts. > > [1] https://patchwork.kernel.org/patch/11180785/ > > Signed-off-by: Christian Hewitt > --- >

Re: [PATCH 0/2] arm64: dts: meson: sm1: add audio support

On Wed 16 Oct 2019 at 18:43, Kevin Hilman wrote: > Kevin Hilman writes: > >> Jerome Brunet writes: >> >>> This patchset adds audio support on the sm1 SoC family and the >>> sei610 platform >> >> Queued for v5.5. >> >>> Kevin, Th

Re: [PATCH -next] clk: meson: axg-audio: use devm_platform_ioremap_resource() to simplify code

On Mon 14 Oct 2019 at 16:43, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing > --- > drivers/clk/meson/axg-audio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver

u are reporting should already be covered by CCF. >> >>> >>> And which sulution is better above two? >> >> Neither, I'm afraid >> >>> >>> Or maybe other good ideas for it? >> >> My bet would be that an important clocks (maybe more tha

Re: [PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver

r good ideas for it? My bet would be that an important clocks (maybe more than 1) is being gated during the init process. Maybe you should try the command line parameter "clk_ignore_unused" until you get things running with your 2 controllers. > > On 2019/9/29 17:38, Jian Hu

Re: [RFCv1 5/5] arm64/ARM: configs: Change CONFIG_PWM_MESON from m to y

On Wed 09 Oct 2019 at 10:48, Anand Moon wrote: > > Kernel command line: console=ttyAML0,115200n8 > root=PARTUUID=45d7d61e-01 rw rootwait > earlyprintk=serial,ttyAML0,115200 initcall_debug printk.time=y > > [0] https://pastebin.com/eBgJrSKe > >> you can also try the command line parameter

[PATCH 2/2] arm64: dts: meson: sei610: enable audio

Add and enable the audio devices on the sei610. The new FRDDR/TODDR D of the SM1 have been left out on purpose. The plaftorm has 2 possible playback interfaces and 3 possible capture interfaces. 3 pcm interfaces for each direction is enough. Signed-off-by: Jerome Brunet --- .../boot/dts

[PATCH 0/2] arm64: dts: meson: sm1: add audio support

driver changes, if you want to test this. [0]: https://lkml.kernel.org/r/20190905135040.6635-1-jbru...@baylibre.com [1]: git://github.com/BayLibre/clk-meson.git clk-meson-dt-v5.5-1 [2]: git://github.com/BayLibre/clk-meson.git v5.5/drivers Jerome Brunet (2): arm64: dts: meson: sm1: add audio

[PATCH 1/2] arm64: dts: meson: sm1: add audio devices

Add the audio devices found on the SM1 SoC family. Only the spdif output and input are missing. These are not supported yet since no platform is available to them. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 327 + 1 file changed, 327

Re: [PATCH v3 0/7] clk: meson: axg-audio: add sm1 support

On Wed 02 Oct 2019 at 11:15, Jerome Brunet wrote: > The purpose of this patchset is to add the sm1 support to the amlogic audio > clock controller. The line count is lot higher than what I hoped for. Even > if extremely similar, there is a shift in the register address on the sm1 >

[PATCH v3 2/7] dt-bindings: clock: meson: add sm1 resets to the axg-audio controller

Add the reset id of the sm1 audio clock controller Reviewed-by: Neil Armstrong Signed-off-by: Jerome Brunet --- .../reset/amlogic,meson-g12a-audio-reset.h| 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-audio-reset.h b

[PATCH v3 3/7] clk: meson: axg-audio: remove useless defines

Defining the number of each input type is no longer necessary since we are not using the clk-input hack anymore Fixes: 282420eed23f ("clk: meson: axg-audio: migrate to the new parent description method") Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/a

[PATCH v3 5/7] clk: meson: axg-audio: prepare sm1 addition

-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 1467 ++--- 1 file changed, 782 insertions(+), 685 deletions(-) diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c index 4b34601342bb..ce8836776d1c 100644

[PATCH v3 7/7] clk: meson: axg_audio: add sm1 support

Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 582 -- drivers/clk/meson/axg-audio.h | 22 +- 2 files changed, 574 insertions(+), 30 deletions(-) diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c index 1a4c50a29ad7

<    1   2   3   4   5   6   7   8   9   10   >