[PATCH 08/13] remoteproc: Rename function rproc_actuate()

2020-08-26 Thread Mathieu Poirier
Align what was done for rproc_detach() by renaming function rproc_actuate(). That way it is easier to figure out the opposite of each functions. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 04/13] remoteproc: Properly represent the attached state

2020-08-26 Thread Mathieu Poirier
-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers

[PATCH 07/13] remoteproc: Introduce function rproc_detach()

2020-08-26 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_core.c | 65 +++- include/linux/remoteproc.h

[PATCH 12/13] remoteproc: Refactor rproc delete and cdev release path

2020-08-26 Thread Mathieu Poirier
be enhanced easily if there is a need to. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 7 ++- drivers/remoteproc/remoteproc_core.c | 5 - 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc

[PATCH 11/13] remoteproc: Properly deal with detach request

2020-08-26 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to or booted by the remoteproc core. For that to happen a rproc::ops::detach() operation need to be available. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 6 ++ drivers

[PATCH 05/13] remoteproc: Add new detach() remoteproc operation

2020-08-26 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier --- include/linux

[PATCH 03/13] remoteproc: Add new RPROC_ATTACHED state

2020-08-26 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_sysfs.c | 1 + include/linux/remoteproc.h| 7 +-- 2

[PATCH 02/13] remoteproc: Remove useless check in rproc_del()

2020-08-26 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 00/13] remoteproc: Add support for detaching from rproc

2020-08-26 Thread Mathieu Poirier
/14/1600 Mathieu Poirier (13): remoteproc: Re-check state in rproc_shutdown() remoteproc: Remove useless check in rproc_del() remoteproc: Add new RPROC_ATTACHED state remoteproc: Properly represent the attached state remoteproc: Add new detach() remoteproc operation remoteproc: Introduce

Re: [PATCH 8/9] rpmsg: virtio: use rpmsg_ns driver to manage ns announcement

2020-08-25 Thread Mathieu Poirier
Hi Arnaud, On Fri, Jul 31, 2020 at 01:47:31PM +0200, Arnaud Pouliquen wrote: > Use the new rpmsg_ns API to send the name service announcements if > the VIRTIO_RPMSG_F_NS is set, else just not implement the ops. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 94

Re: [PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement

2020-08-25 Thread Mathieu Poirier
On Tue, 25 Aug 2020 at 05:57, Arnaud POULIQUEN wrote: > > Hi Mathieu > > Thanks for the review! please find few comments below. > > On 8/25/20 12:47 AM, Mathieu Poirier wrote: > > On Fri, Jul 31, 2020 at 01:47:28PM +0200, Arnaud Pouliquen wrote: > >> The

Re: [PATCH 9/9] rpmsg: ns: name service announcement endianness

2020-08-24 Thread Mathieu Poirier
On Fri, Jul 31, 2020 at 01:47:32PM +0200, Arnaud Pouliquen wrote: > The endianness has to be fixed to ensure that both sides can > decode the message. The Little endian format is used according > to the generic virtio implementation. > > Signed-off-by: Arnaud Pouliquen > --- >

Re: [PATCH 6/9] rpmsg: virtio: use rpmsg ns device for the ns announcement

2020-08-24 Thread Mathieu Poirier
On Fri, Jul 31, 2020 at 01:47:29PM +0200, Arnaud Pouliquen wrote: > As generic NS driver is available, rely on it for NS management instead of > managing it in RPMsg virtio bus. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/rpmsg/Kconfig| 1 + >

Re: [PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement

2020-08-24 Thread Mathieu Poirier
On Fri, Jul 31, 2020 at 01:47:28PM +0200, Arnaud Pouliquen wrote: > The name service announcement should not be linked to the RPMsg virtio bus > but to the RPMsg protocol itself. > > This patch proposes to break the dependency with the RPmsg virtio bus by > the introduction of the reserved RPMsg

Re: [PATCH 2/9] rpmsg: core: add channel creation internal API

2020-08-24 Thread Mathieu Poirier
Hi Arnaud, On Fri, Jul 31, 2020 at 01:47:25PM +0200, Arnaud Pouliquen wrote: > Add the channel creation API as a first step to be able to define the > name service announcement as a rpmsg driver independent from the RPMsg > virtio bus. > > Signed-off-by: Arnaud Pouliquen > --- >

Re: [PATCH 0/9] introduce name service announcement rpmsg driver

2020-08-20 Thread Mathieu Poirier
On Fri, Jul 31, 2020 at 01:47:23PM +0200, Arnaud Pouliquen wrote: > The NS announcement is implemented by several backends, but could be > considered as part the RPMsg protocol. > In this case it should be managed as a reserved rpmsg service and so > implemented on top of the rpmsg protocol. > >

Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional

2020-08-20 Thread Mathieu Poirier
On Thu, Aug 20, 2020 at 02:04:10AM +, Peng Fan wrote: > > Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional > > > > On Wed, Aug 19, 2020 at 12:51:27AM +, Peng Fan wrote: > > > > Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon > > > > optional > > > > > >

[PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

2020-08-20 Thread Mathieu Poirier
Add entries for perf tools elements related to the support of Arm CoreSight and Arm SPE. Also lump in Arm and Arm64 architecture files to provide coverage. Signed-off-by: Mathieu Poirier --- V2: - Completed fileset for SPE. - Added Arm and Arm64 architecture files. MAINTAINERS | 8 +++- 1

Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional

2020-08-19 Thread Mathieu Poirier
On Wed, Aug 19, 2020 at 12:51:27AM +, Peng Fan wrote: > > Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional > > > > Hi Peng, > > > > On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > > > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control > >

Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

2020-08-19 Thread Mathieu Poirier
On Wed, 19 Aug 2020 at 11:30, Will Deacon wrote: > > On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote: > > On Tue, 18 Aug 2020 at 11:56, John Garry wrote: > > > On 17/08/2020 20:31, Mathieu Poirier wrote: > > > > diff --git a/MAINTAINERS b/MAINT

Re: [PATCH] coresight: etm4x: Handle unreachable sink in perf mode

2020-08-19 Thread Mathieu Poirier
handler+0xf8/0x124 > [10919.732003] el0_sync+0x140/0x180 > > Fixes: f9d81a657bb8 ("coresight: perf: Allow tracing on hotplugged CPUs") > Reported-by: Jeremy Linton > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracin

Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

2020-08-19 Thread Mathieu Poirier
On Tue, 18 Aug 2020 at 11:56, John Garry wrote: > > On 17/08/2020 20:31, Mathieu Poirier wrote: > > Add entries for perf tools elements related to the support of > > Arm CoreSight and Arm SPE. > > Thanks for doing this... > > > > > Signed-off-by: Mathieu

Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional

2020-08-18 Thread Mathieu Poirier
Hi Peng, On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control M4. > But currently i.MX8QM/QXP/7ULP not added, so still check regmap > when start/stop to avoid unhappy things. On the i.MX8QM/QXP/7ULP processors, the

Re: [PATCH 2/2] remoteproc: Move recovery debugfs entry to sysfs

2020-08-18 Thread Mathieu Poirier
On Tue, Jul 28, 2020 at 04:08:17PM -0700, Rishabh Bhatnagar wrote: > Expose recovery mechanism through sysfs rather than exposing through > debugfs. Some operating systems may limit access to debugfs through > access policies. This restricts user access to recovery mechanism, > hence move it to

Re: [PATCH 1/2] remoteproc: Move coredump entry from debugfs to sysfs.

2020-08-18 Thread Mathieu Poirier
On Tue, Jul 28, 2020 at 04:08:16PM -0700, Rishabh Bhatnagar wrote: > Expose coredump configuration from sysfs instead of debugfs. > In some operating systems access to debugfs might be limited. > This restricts user from selecting the coredump configuration > at all, hence move this interface to

[PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

2020-08-17 Thread Mathieu Poirier
Add entries for perf tools elements related to the support of Arm CoreSight and Arm SPE. Signed-off-by: Mathieu Poirier --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4e2698cc7e23..f9bb76baeec9 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v2] coresight: etm4x: Add Support for HiSilicon ETM device

2020-08-13 Thread Mathieu Poirier
On Thu, Aug 13, 2020 at 08:59:22PM +0800, Qi Liu wrote: > Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08 > contains ETMv4.2 device and Hip09 contains ETMv4.5 device. > > Signed-off-by: Qi Liu I have applied your patch to my local branch - it will be published on Monday

Re: [PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Mathieu Poirier
On Thu, Aug 13, 2020 at 12:04:55PM +0200, Mian Yousaf Kaukab wrote: > Since port-numbers start from 0, add 1 to port-number to get the port > count. > > Fix following crash when Coresight is enabled on ACPI based systems: > > [ 61.061736] Unable to handle kernel NULL pointer dereference at

Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

2020-08-13 Thread Mathieu Poirier
On Wed, 12 Aug 2020 at 12:53, Arnaldo Carvalho de Melo wrote: > > Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu: > > Hi Arnaldo, > > > > On Fri, 7 Aug 2020 at 01:16, Leo Yan wrote: > > > > > > This patch set is to enable Arm arch ti

Re: [PATCH v3 0/6] tracing: export event trace and trace_marker

2020-08-12 Thread Mathieu Poirier
On Tue, Aug 11, 2020 at 11:57:20AM +0800, Tingwei Zhang wrote: > Ftrace has ability to export trace packets to other destination. > Currently, only function trace can be exported. This series extends the > support to event trace and trace_maker. STM is one possible destination to > export ftrace.

Re: [PATCH v4] perf test: Introduce script for Arm CoreSight testing

2020-08-12 Thread Mathieu Poirier
Leo and Arnaldo, On Thu, 6 Aug 2020 at 01:02, Leo Yan wrote: > > We need a simple method to test Perf with Arm CoreSight drivers, this > could be used for smoke testing when new patch is coming for perf or > CoreSight drivers, and we also can use the test to confirm if the > CoreSight has been

Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

2020-08-12 Thread Mathieu Poirier
Hi Arnaldo, On Fri, 7 Aug 2020 at 01:16, Leo Yan wrote: > > This patch set is to enable Arm arch timer counter and Arm SPE is the > first customer to use arch timer counter for its timestamp. > > Patches 01 ~ 03 enables Arm arch timer counter in Perf tool; patch 01 is > to retrieve arch timer's

Re: [PATCH 2/2] remoteproc: imx_rproc: add elf memory hooks

2020-08-11 Thread Mathieu Poirier
On Tue, Jul 28, 2020 at 05:31:13PM +0800, peng@nxp.com wrote: > From: Peng Fan > > Please not apply 2/2 for now, this 2/2 has not gone through > test on all i.MX8 platforms. Why sending patches to the mailing list if they are not ready to be applied? > > Signed-off-by: Peng Fan > --- >

Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional

2020-08-11 Thread Mathieu Poirier
On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control M4. > But currently i.MX8QM/QXP/7ULP not added, so still check regmap > when start/stop to avoid unhappy things. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan

Re: [PATCH 10/10] remoteproc: imx_rproc: support coproc booting before Linux

2020-08-11 Thread Mathieu Poirier
On Fri, Jul 24, 2020 at 04:08:13PM +0800, Peng Fan wrote: > Detect Coproc booted or not and Parse resource table > Set remoteproc state to RPROC_DETACHED when M4 is booted early > Add attach hook > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 75 >

Re: [PATCH 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2020-08-11 Thread Mathieu Poirier
On Fri, Jul 24, 2020 at 04:08:10PM +0800, Peng Fan wrote: > The hook is used to parse memory-regions and load resource table > from the address the remote processor published. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 99 > +- >

Re: [PATCH 06/10] remoteproc: imx_rproc: add load hook

2020-08-11 Thread Mathieu Poirier
On Fri, Jul 24, 2020 at 04:08:09PM +0800, Peng Fan wrote: > To i.MX8, we not able to see the correct data written into TCM when > using ioremap_wc, so use ioremap. > > However common elf loader using memset. > > To arm64, "dc zva, dst" is used in memset. > Per ARM DDI 0487A.j, chapter

Re: [PATCH 02/10] remoteproc: imx_rproc: correct err message

2020-08-11 Thread Mathieu Poirier
ion area that is private to the driver. That way we don't expose system information involuntarily. With that: Reviewed-by: Mathieu Poirier > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > -- > 2.16.4 >

Re: [PATCH 1/3] remoteproc: core: Add coredump to remoteproc ops

2020-08-10 Thread Mathieu Poirier
On Fri, Aug 07, 2020 at 04:31:59PM -0700, Gurbir Arora wrote: > Each remoteproc might have different requirements for coredumps and might > want to choose the type of dumps it wants to collect. This change allows > remoteproc drivers to specify their own custom dump function to be executed > in

Re: [PATCH] rpmsg: virtio: fix compilation warning for virtio_rpmsg_channel description

2020-08-10 Thread Mathieu Poirier
channel belongs to > > Signed-off-by: Arnaud Pouliquen > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Mathieu Poirier > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c > b/drivers/rpmsg/virtio_rpmsg_b

Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units

2020-08-10 Thread Mathieu Poirier
On Thu, Jul 30, 2020 at 05:38:37PM +0100, Suzuki K Poulose wrote: > On 07/29/2020 06:20 PM, Mathieu Poirier wrote: > > On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: > > > Document the bindings for ETMv4.4 and later with only system register > > > a

Re: [PATCHv3] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-08-10 Thread Mathieu Poirier
On Wed, Jul 29, 2020 at 10:43:10AM +0530, Sai Prakash Ranjan wrote: > etm4_count keeps track of number of ETMv4 registered and on some systems, > a race is observed on etm4_count variable which can lead to multiple calls > to cpuhp_setup_state_nocalls_cpuslocked(). This function internally calls >

Re: [PATCH] remoteproc: virtio: support sharing vdev buffer

2020-07-30 Thread Mathieu Poirier
On Thu, 30 Jul 2020 at 00:22, Peng Fan wrote: > > Hi Mathieu, > > > Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer > > > > Hi Peng, > > > > On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote: > > > Support sharing vdev buffer between multiple vdevs by using name > > >

Re: [RFC PATCH 09/14] coresight: etm4x: Add sysreg access helpers

2020-07-30 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:35PM +0100, Suzuki K Poulose wrote: > ETMv4.4 architecture defines the system instructions for accessing > ETM via register accesses. Add basic support for accessing a given > register via system instructions. > > Cc: Mathieu Poirier > Cc: Mike L

Re: [RFC PATCH 08/14] coresight: etm4x: Convert all register accesses

2020-07-30 Thread Mathieu Poirier
\)\?(drvdata->base + \(.*\))/etm4x_\1_read32(csdev, \2) > s/writel\(_relaxed\)\?(\(.*\), drvdata->base + > \(.*\))/etm4x_\1_write32(csdev, \2, \3) > > We don't want to replace them with the csdev_access_* to > avoid a function call for every register access for system > regis

Re: [RFC PATCH 07/14] coresight: etm4x: Always read the registers on the host CPU

2020-07-30 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:33PM +0100, Suzuki K Poulose wrote: > As we are about to add support for sysreg access to ETM4.4+ components, > make sure that we read the registers only on the host CPU. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulos

Re: [RFC PATCH 06/14] coresight: Convert claim and lock operations to use access wrappers

2020-07-30 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:32PM +0100, Suzuki K Poulose wrote: > Convert the CoreSight CLAIM set/clear, LOCK/UNLOCK operations to > use the coresight device access abstraction. > > Mostly a mechanical change. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-

Re: [RFC PATCH 05/14] coresight: Convert coresight_timeout to use access abstraction

2020-07-30 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:31PM +0100, Suzuki K Poulose wrote: > Convert the generic routines to use the new access abstraction layer > gradually, starting with coresigth_timeout. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > dri

Re: [RFC PATCH 04/14] coresight: etm4x: Free up argument of etm4_init_arch_data

2020-07-30 Thread Mathieu Poirier
csdev_access for the given device. > Towards this free up the argument, which is already available > via etmdrvdata[smp_processor_id()]. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 15 +

Re: [PATCH v5 2/2] remoteproc: core: Register the character device interface

2020-07-30 Thread Mathieu Poirier
ed-off-by: Rishabh Bhatnagar > Signed-off-by: Siddharth Gupta Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/remoteproc_core.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/remoteproc/remoteproc_core.c > b/drivers/remoteproc/remoteproc

Re: [PATCH v5 1/2] remoteproc: Add remoteproc character device interface

2020-07-30 Thread Mathieu Poirier
unctionality. An ioctl call is implemented to enable > the shutdown on release feature which will allow remote processors to > be shutdown when the controlling userpsace application crashes or hangs. > > Signed-off-by: Rishabh Bhatnagar > Signed-off-by: Siddharth Gupta > ---

Re: [RFC PATCH 03/14] coresight: tpiu: Use coresight device access abstraction

2020-07-29 Thread Mathieu Poirier
ch is that we are moving to the access abstraction and the changelog should reflect that. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tpiu.c | 30 +--- > 1 file changed, 13 insertions(

Re: [RFC PATCH 02/14] coresight: Introduce device access abstraction

2020-07-29 Thread Mathieu Poirier
rrent patch. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-catu.c | 1 + > drivers/hwtracing/coresight/coresight-cti.c | 1 + > drivers/hwtracing/coresight/coresight-etb10.c | 1 + > dri

Re: [RFC PATCH 01/14] coresight: etm4x: Skip save/restore before device registration

2020-07-29 Thread Mathieu Poirier
Hi Suzuki, I have starte to review this - comments will be scattered over a few days. On Wed, Jul 22, 2020 at 06:20:27PM +0100, Suzuki K Poulose wrote: > Skip cpu save/restore before the coresight device is registered. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: S

Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units

2020-07-29 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: > Document the bindings for ETMv4.4 and later with only system register > access. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-

Re: [PATCH] remoteproc: virtio: support sharing vdev buffer

2020-07-29 Thread Mathieu Poirier
Hi Peng, On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote: > Support sharing vdev buffer between multiple vdevs by using name > "vdevbuffer". > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/remoteproc_virtio.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-07-28 Thread Mathieu Poirier
On Sun, 26 Jul 2020 at 19:51, Xu Wang wrote: > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang > --- >

Re: [PATCH v6 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-07-28 Thread Mathieu Poirier
On Wed, Jul 15, 2020 at 08:33:17AM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different > configurations. > > Acked-by: Stefano Stabellini > Acked-by: Ben Levinsky > Reviewed-by: Radhey Shyam

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Mathieu Poirier
On Tue, 28 Jul 2020 at 06:02, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > > - Firstly, the function auxtrace_record__init() will be invoked only >

Re: [PATCH v6 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-07-27 Thread Mathieu Poirier
On Wed, Jul 15, 2020 at 08:33:17AM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different > configurations. > > Acked-by: Stefano Stabellini > Acked-by: Ben Levinsky > Reviewed-by: Radhey Shyam

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-27 Thread Mathieu Poirier
h itself. The only thing that is happening here is the removal of a useless check and a fix for a memory leak. Once again whether Arnaldo wants to make the changes by hand or not you may have to resubmit. Reviewed-by: Mathieu Poirier > > So remove the useless check code to make it clear. > &

Re: [PATCH v2 1/2] perf tools: Fix record failure when mixed with ARM SPE event

2020-07-27 Thread Mathieu Poirier
than 13. Depending on what Arnaldo wants to do you may have to resend. > Signed-off-by: Wei Li Reviewed-by: Mathieu Poirier > --- > tools/perf/arch/arm/util/auxtrace.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/arch/arm/util/

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-22 Thread Mathieu Poirier
On Tue, Jul 21, 2020 at 01:56:35PM -0700, Bjorn Andersson wrote: > On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > > On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote: > > > > On Tue, Ju

Re: [PATCH 5/6] remoteproc: mtk_apu: Don't try to use the APU local RAM

2020-07-21 Thread Mathieu Poirier
On Mon, Jul 13, 2020 at 03:29:26PM +0200, Alexandre Bailon wrote: > Currently, this local RAM is not accessible from the CPU. > If the CPU tries to access it, then the CPU will hang. > > Remoteproc may try to use it when it load a firmware > that has some sections in the local RAM. > This

Re: [PATCH 4/6] remoteproc: mtk_vpu_rproc: Don't try to load empty PT_LOAD segment

2020-07-21 Thread Mathieu Poirier
On the flip side I suspect that you don't control all the process and that systems are out there with faulty fw images. As such: Reviewed-by: Mathieu Poirier > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/mtk_apu_rproc.c | 35 +++--- > 1

Re: [PATCH 3/6] remoteproc: mtk_vpu_rproc: Add support of JTAG

2020-07-21 Thread Mathieu Poirier
On Mon, Jul 13, 2020 at 03:29:24PM +0200, Alexandre Bailon wrote: > The DSP could be debugged using JTAG. > The support of JTAG could enabled at build time and it could be enabled > using debugfs. > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/Kconfig | 9 ++ >

Re: [PATCH] arm64: dts: qcom: sdm845: Support ETMv4 power management

2020-07-21 Thread Mathieu Poirier
njan > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Mathieu Poirier > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index e506793407d8..0b5f063dcaea 100644 > -

Re: [PATCH 2/6] remoteproc: Add a remoteproc driver for the MT8183's APU

2020-07-20 Thread Mathieu Poirier
On Mon, Jul 13, 2020 at 03:29:23PM +0200, Alexandre Bailon wrote: > This adds a driver to control the APU present in the MT8183. > This loads the firmware and start the DSP. > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/Kconfig | 10 + > drivers/remoteproc/Makefile

Re: [PATCH 2/6] remoteproc: Add a remoteproc driver for the MT8183's APU

2020-07-20 Thread Mathieu Poirier
On Mon, Jul 13, 2020 at 03:29:23PM +0200, Alexandre Bailon wrote: > This adds a driver to control the APU present in the MT8183. > This loads the firmware and start the DSP. > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/Kconfig | 10 + > drivers/remoteproc/Makefile

Re: [PATCH v8 4/5] remoteproc: Add inline coredump functionality

2020-07-20 Thread Mathieu Poirier
h Bhatnagar > Tested-by: Sibi Sankar Thanks for doing the modifications. Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/remoteproc_coredump.c | 156 > +++ > include/linux/remoteproc.h | 16 > 2 files changed, 15

Re: [PATCH v8 3/5] remoteproc: Pass size and offset as arguments to segment dump function

2020-07-20 Thread Mathieu Poirier
+-- > 3 files changed, 11 insertions(+), 9 deletions(-) Reviewed-by: Mathieu Poirier > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c > b/drivers/remoteproc/qcom_q6v5_mss.c > index 037cd45..6baa3ae 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/q

Re: [PATCH v1 2/4] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size

2020-07-20 Thread Mathieu Poirier
cking with size. > > Signed-off-by: Sibi Sankar > Signed-off-by: Rishabh Bhatnagar Acked-by: Mathieu Poirier > --- > drivers/remoteproc/qcom_q6v5_mss.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/remoteproc/

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-20 Thread Mathieu Poirier
On Thu, 16 Jul 2020 at 23:48, Bjorn Andersson wrote: > > On Wed 15 Jul 13:18 PDT 2020, Mathieu Poirier wrote: > > > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: > > > Add the character device interface into remoteproc framework. > > > Th

Re: [PATCH v2 1/4] dt-bindings: remoteproc: Add bindings for R5F subsystem on TI K3 SoCs

2020-07-16 Thread Mathieu Poirier
Hi Rob, On Tue, Jul 14, 2020 at 11:15:53AM -0600, Rob Herring wrote: > On Mon, Jun 29, 2020 at 09:49:19PM -0500, Suman Anna wrote: > > The Texas Instruments K3 family of SoCs have one or more dual-core > > Arm Cortex R5F processor subsystems/clusters (R5FSS). The clusters > > can be split between

Re: [PATCH v5 06/11] remoteproc: stm32: Properly set co-processor state when attaching

2020-07-15 Thread Mathieu Poirier
e wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Mathieu-Poirier/remoteproc-stm32-Add-support-for-attaching-to-M4/20200708-0535

Re: [PATCH v7 3/4] remoteproc: Add inline coredump functionality

2020-07-15 Thread Mathieu Poirier
On Wed, 15 Jul 2020 at 13:22, wrote: > > On 2020-07-14 10:53, Mathieu Poirier wrote: > > On Thu, Jul 09, 2020 at 01:31:55PM -0700, Rishabh Bhatnagar wrote: > >> The current coredump implementation uses vmalloc area to copy > >> all the segments. But this might pu

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-15 Thread Mathieu Poirier
On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote: > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: > > Add the character device interface into remoteproc framework. > > This interface can be used in order to boot/shutdown remote > > subsystems

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-15 Thread Mathieu Poirier
; > > +#ifdef CONFIG_REMOTEPROC_CDEV > +void rproc_init_cdev(void); > +void rproc_exit_cdev(void); > +int rproc_char_device_add(struct rproc *rproc); > +void rproc_char_device_remove(struct rproc *rproc); > +#else > +static inline void rproc_init_cdev(void) > +{ > +} > +

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-07-15 Thread Mathieu Poirier
Hey Kishon, On Wed, Jul 08, 2020 at 06:43:45PM +0530, Kishon Vijay Abraham I wrote: > Hi Jason, > > On 7/8/2020 4:52 PM, Jason Wang wrote: > > > > On 2020/7/7 下午10:45, Kishon Vijay Abraham I wrote: > >> Hi Jason, > >> > >> On 7/7/2020 3:17 PM, Jason Wang wrote: > >>> On 2020/7/6 下午5:32, Kishon

Re: [PATCH v6 00/11] remoteproc: stm32: Add support for attaching to M4

2020-07-15 Thread Mathieu Poirier
On Wed, 15 Jul 2020 at 00:51, Arnaud POULIQUEN wrote: > > Hi Mathieu > > > -Original Message- > > From: Mathieu Poirier > > Sent: mardi 14 juillet 2020 22:05 > > To: o...@wizery.com; bjorn.anders...@linaro.org; Loic PALLARDY > > ; Arnaud PO

[PATCH v6 05/11] remoteproc: stm32: Parse syscon that will manage M4 synchronisation

2020-07-14 Thread Mathieu Poirier
Get from the DT the syncon to probe the state of the remote processor and the location of the resource table. Mainly based on the work published by Arnaud Pouliquen [1]. [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877 Signed-off-by: Mathieu Poirier Reviewed

[PATCH v6 02/11] remoteproc: stm32: Request IRQ with platform device

2020-07-14 Thread Mathieu Poirier
Request IRQ with platform device rather than remote proc in order to call stm32_rproc_parse_dt() before rproc_alloc(). That way we can know whether we need to synchronise with the MCU or not. Signed-off-by: Mathieu Poirier Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson --- drivers

[PATCH v6 08/11] remoteproc: stm32: Parse memory regions when attaching to M4

2020-07-14 Thread Mathieu Poirier
on the work published by Arnaud Pouliquen [1]. [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877 Signed-off-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v6 10/11] remoteproc: stm32: Introduce new attach() operation

2020-07-14 Thread Mathieu Poirier
Introduce new attach function to be used when attaching to a remote processor. Mainly based on the work published by Arnaud Pouliquen [1]. [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877 Signed-off-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 8

[PATCH v6 00/11] remoteproc: stm32: Add support for attaching to M4

2020-07-14 Thread Mathieu Poirier
by the patch. Tested on ST's mp157c development board. Thanks, Mathieu [1].https://patchwork.kernel.org/project/linux-remoteproc/list/?series=318275 Mathieu Poirier (11): remoteproc: stm32: Decouple rproc from memory translation remoteproc: stm32: Request IRQ with platform device remoteproc

[PATCH v6 07/11] remoteproc: Make function rproc_resource_cleanup() public

2020-07-14 Thread Mathieu Poirier
Make function rproc_resource_cleanup() public so that it can be used by platform drivers when allocating resources to be used by a detached remote processor. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_core.c | 3 ++- include/linux/remoteproc.h | 1 + 2 files

[PATCH v6 11/11] remoteproc: stm32: Update M4 state in stm32_rproc_stop()

2020-07-14 Thread Mathieu Poirier
-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 7145cd49616e..f4da42fc0eeb 100644 --- a/drivers/remoteproc

[PATCH v6 06/11] remoteproc: stm32: Properly set co-processor state when attaching

2020-07-14 Thread Mathieu Poirier
=239877 Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson --- drivers/remoteproc/stm32_rproc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 961a53f67ec5..f393f2503106 100644

[PATCH v6 09/11] remoteproc: stm32: Properly handle the resource table when attaching

2020-07-14 Thread Mathieu Poirier
-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 76 1 file changed, 76 insertions(+) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 2a1cccd8d311..882229f3b1c9 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b

[PATCH v6 01/11] remoteproc: stm32: Decouple rproc from memory translation

2020-07-14 Thread Mathieu Poirier
Remove the remote processor from the process of parsing the memory ranges since there is no correlation between them. Signed-off-by: Mathieu Poirier Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson --- drivers/remoteproc/stm32_rproc.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v6 03/11] remoteproc: stm32: Decouple rproc from DT parsing

2020-07-14 Thread Mathieu Poirier
Remove the remote processor from the process of parsing the device tree since (1) there is no correlation between them and (2) to use the information that was gathered to make a decision on whether to synchronise with the M4 or not. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson

[PATCH v6 04/11] remoteproc: stm32: Remove memory translation from DT parsing

2020-07-14 Thread Mathieu Poirier
-off-by: Mathieu Poirier Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson --- drivers/remoteproc/stm32_rproc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index cbba995a80a2..986f34a336a7 100644

[PATCH v6 5/9] remoteproc: Introducing function rproc_validate()

2020-07-14 Thread Mathieu Poirier
Add a new function to assert the general health of the remote processor before handing it to the remoteproc core. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen Tested-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 41 1 file changed

[PATCH v6 4/9] remoteproc: Introducing function rproc_actuate()

2020-07-14 Thread Mathieu Poirier
by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen Tested-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 59 +++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers

[PATCH v6 8/9] remoteproc: Refactor function rproc_free_vring()

2020-07-14 Thread Mathieu Poirier
the virtio device section in it. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Tested-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b

[PATCH v6 1/9] remoteproc: Add new RPROC_DETACHED state

2020-07-14 Thread Mathieu Poirier
Add a new RPROC_DETACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Tested-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v6 2/9] remoteproc: Add new attach() remoteproc operation

2020-07-14 Thread Mathieu Poirier
Add an new attach() operation in order to properly deal with scenarios where the remoteproc core needs to attach to a remote processor that has been booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Tested-by: Arnaud Pouliquen --- drivers/remoteproc

[PATCH v6 0/9] remoteproc: Add support for attaching with rproc

2020-07-14 Thread Mathieu Poirier
This set provides functionality allowing the remoteproc core to attach to a remote processor that was started by another entity. New in V6: 1) Added Arnaud's reviewed-by and tested-by tags. Applies cleanly on rproc-next (0cf17702d872) Thanks, Mathieu Mathieu Poirier (9): remoteproc: Add new

[PATCH v6 3/9] remoteproc: Introducing function rproc_attach()

2020-07-14 Thread Mathieu Poirier
. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Tested-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 42 1 file changed, 42 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index

[PATCH v6 7/9] remoteproc: Refactor function rproc_trigger_auto_boot()

2020-07-14 Thread Mathieu Poirier
Refactor function rproc_trigger_auto_boot() to properly deal with scenarios where the remoteproc core needs to attach with a remote processor that has already been booted by an external entity. Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Tested-by: Arnaud Pouliquen --- drivers

<    5   6   7   8   9   10   11   12   13   14   >