Re: [PATCH 3/3] fpga: region: Adds runtime PM support

2021-04-09 Thread Moritz Fischer
On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: > Adds support to handle FPGA/PL power domain. With this patch, > the PL power domain will be turned on before loading the bitstream > and turned off while removing/unloading the bitstream using overlays. > This can be achieved by

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Moritz Fischer
On Thu, Apr 08, 2021 at 09:20:19AM +, Wu, Hao wrote: > > On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > > > Hi Matthew, > > > > > > &g

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-06 Thread Moritz Fischer
Hi Matthew, On Tue, Apr 06, 2021 at 09:05:35AM -0700, matthew.gerl...@linux.intel.com wrote: > > Hi Moritz, > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > Hi Matthew, > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, matthew.gerl...@linux.intel.com >

Re: [PATCH 1/3] fpga: dfl: pci: add DID for D5005 PAC cards

2021-04-05 Thread Moritz Fischer
On Mon, Apr 05, 2021 at 04:52:59PM -0700, matthew.gerl...@linux.intel.com wrote: > From: Russ Weight > > This patch adds the approved PCI Express Device IDs for the > PF and VF for the card for D5005 PAC cards. > > Signed-off-by: Russ Weight > Signed-off-by: Matthew Gerlach > --- >

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-05 Thread Moritz Fischer
Hi Matthew, On Mon, Apr 05, 2021 at 04:53:00PM -0700, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach > > This patch adds DFL bus driver for the Altera SPI Master > controller. The SPI master is connected to an Intel SPI Slave to > Avalon Master Bridge, inside an Intel MAX10 BMC

Re: [PATCH 2/3] fpga: region: Add fpga-region property 'power-domains'

2021-04-02 Thread Moritz Fischer
On Fri, Apr 02, 2021 at 02:50:48PM +0530, Nava kishore Manne wrote: > Add fpga-region property 'power-domains' to allow to handle > the FPGA/PL power domins. > > dt-bindings: fpga: Enable PM generic domain support > > Signed-off-by: Nava kishore Manne > --- >

Re: [PATCH] dt-bindings: fpga: fpga-region: Convert to sugar syntax

2021-04-02 Thread Moritz Fischer
Hi Geert, On Fri, Apr 02, 2021 at 01:57:49PM +0200, Geert Uytterhoeven wrote: > Using overlay sugar syntax makes the DTS files easier to read (and > write). > > While at it, fix two build issues: > - "/dts-v1/" and "/plugin/" must be separate statements. > - Add a missing closing curly

Re: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-31 Thread Moritz Fischer
Hi Russ, On Wed, Mar 31, 2021 at 11:47:26AM -0700, Russ Weight wrote: > Moritz, > > On 3/28/21 10:20 AM, Moritz Fischer wrote: > > Tom, > > > > On Sun, Mar 28, 2021 at 08:40:24AM -0700, Tom Rix wrote: > >> On 3/27/21 11:09 AM, Moritz Fischer wrote: > >&g

Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-03-30 Thread Moritz Fischer
Hi Richard, On Tue, Mar 30, 2021 at 09:33:05AM -0500, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Extend Intel service layer driver to get the firmware version running at > FPGA device. Therefore FPGA manager driver, one of Intel service layer > driver's client, can decide

Re: [PATCHv5 3/7] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-03-28 Thread Moritz Fischer
On Tue, Feb 09, 2021 at 04:20:29PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Extend Intel service layer driver to get the firmware version running at > FPGA device. Therefore FPGA manager driver, one of Intel service layer > driver's client, can decide whether to handle

Re: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-28 Thread Moritz Fischer
Tom, On Sun, Mar 28, 2021 at 08:40:24AM -0700, Tom Rix wrote: > > On 3/27/21 11:09 AM, Moritz Fischer wrote: > > Hi Richard, Russ, > > > > On Thu, Feb 25, 2021 at 01:07:14PM +, Gong, Richard wrote: > >> Hi Moritz, > >> > >> Sorry for a

Re: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-27 Thread Moritz Fischer
Hi Richard, Russ, On Thu, Feb 25, 2021 at 01:07:14PM +, Gong, Richard wrote: > Hi Moritz, > > Sorry for asking. > > When you have chance, can you help review the version 5 patchset submitted on > 02/09/21? > > Regards, > Richard > > -Original Message- > From:

[PATCH RESEND v2] PCI/IOV: Clarify error message for unbound devices

2021-03-27 Thread Moritz Fischer
Be more verbose to disambiguate the error case when trying to configure SRIOV with no driver bound vs. a driver that does not implement the SRIOV callback. Reported-by: Brian Foley Reviewed-by: Krzysztof Wilczyński Signed-off-by: Moritz Fischer --- Changes from v1: - Added Krzysztof's Reviewed

Re: [PATCH v12 0/2] UIO support for dfl devices

2021-03-24 Thread Moritz Fischer
Hi Xu, On Wed, Mar 24, 2021 at 04:22:17PM +0800, Xu Yilun wrote: > Hi Moritz: > > Sorry I need to get back to you again, seems no more comments from Greg. > > The patchset is stuck here for more than 1 month. Do you have some > more suggestion that could make it move forward? Do you have some

Re: [PATCH v9 1/1] fpga: dfl: afu: harden port enable logic

2021-03-24 Thread Moritz Fischer
On Tue, Mar 23, 2021 at 03:46:50PM -0700, Russ Weight wrote: > Port enable is not complete until ACK = 0. Change > __afu_port_enable() to guarantee that the enable process > is complete by polling for ACK == 0. > > Signed-off-by: Russ Weight > Reviewed-by: Tom Rix > Reviewed-by: Matthew Gerlach

Re: [PATCHv5 1/7] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0

2021-03-18 Thread Moritz Fischer
On Mon, Feb 15, 2021 at 06:32:16AM -0800, Tom Rix wrote: > > On 2/15/21 6:41 AM, Richard Gong wrote: > > Hi Tom, > > > > On 2/13/21 9:44 AM, Tom Rix wrote: > >> > >> On 2/9/21 2:20 PM, richard.g...@linux.intel.com wrote: > >>> From: Richard Gong > >>> > >>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL

Re: [PATCH v3 12/15] fpga: altera: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs

2021-03-11 Thread Moritz Fischer
Hi Krzysztof, On Thu, Mar 11, 2021 at 04:27:35PM +0100, Krzysztof Kozlowski wrote: > ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the > 32-bit ARM drivers to rely on new symbol. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Moritz Fischer > --- > driver

Re: [PATCH v10 0/7] FPGA Security Manager Class Driver

2021-03-09 Thread Moritz Fischer
Hi Tom, On Tue, Mar 09, 2021 at 08:03:09AM -0800, Tom Rix wrote: > Moritz, > > This and the next patchset apply to today's char-misc-next. > > However they conflicts with other in flight linux-fpga patchsets. > > Since I believe these patchsets came first, I think they should have >

Re: [PATCH V3 XRT Alveo 01/18] Documentation: fpga: Add a document describing XRT Alveo drivers

2021-03-06 Thread Moritz Fischer
On Mon, Mar 01, 2021 at 06:48:46AM +, Sonal Santan wrote: > Hello Tom, > > > -Original Message- > > From: Tom Rix > > Sent: Friday, February 19, 2021 2:26 PM > > To: Lizhi Hou ; linux-kernel@vger.kernel.org > > Cc: Lizhi Hou ; linux-f...@vger.kernel.org; Max Zhen > > ; Sonal Santan ;

Re: [PATCH] fpga: xilinx-pr-decoupler: Simplify code by using dev_err_probe()

2021-03-06 Thread Moritz Fischer
On Thu, Feb 04, 2021 at 02:36:11PM +0100, Michal Simek wrote: > Use already prepared dev_err_probe() introduced by commit a787e5400a1c > ("driver core: add device probe log helper"). > It simplifies EPROBE_DEFER handling. > > Signed-off-by: Michal Simek > --- > >

Re: [PATCH] fpga: fpga-mgr: xilinx-spi: fix error messages on -EPROBE_DEFER

2021-03-06 Thread Moritz Fischer
On Thu, Feb 04, 2021 at 01:13:13PM +0100, Luca Ceresoli wrote: > The current code produces an error message on devm_gpiod_get() errors even > when the error is -EPROBE_DEFER, which should be silent. > > This has been observed producing a significant amount of messages like: > >

Re: [PATCH V3 XRT Alveo 00/18] XRT Alveo driver overview

2021-03-03 Thread Moritz Fischer
On Tue, Mar 02, 2021 at 10:49:43PM -0800, Joe Perches wrote: > On Sun, 2021-02-21 at 12:43 -0800, Moritz Fischer wrote: > > On Wed, Feb 17, 2021 at 10:40:01PM -0800, Lizhi Hou wrote: > > > This is V3 of patch series which adds management physical function driver > > >

Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support

2021-03-03 Thread Moritz Fischer
Hi Nava, On Thu, Jan 21, 2021 at 09:17:10PM -0800, Moritz Fischer wrote: > On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne wrote: > > This commit adds secure flags to the framework to support > > secure BitStream Loading. > > > > Signed

Re: [PATCH V3 XRT Alveo 03/18] fpga: xrt: xclbin file helper functions

2021-03-02 Thread Moritz Fischer
On Mon, Mar 01, 2021 at 04:25:37PM -0800, Lizhi Hou wrote: > Hi Tom, > > > On 02/28/2021 08:54 AM, Tom Rix wrote: > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this

Re: [RESEND PATCH v11 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-02-28 Thread Moritz Fischer
Hi Greg, On Sat, Feb 27, 2021 at 04:42:55PM +0100, Greg KH wrote: > On Sat, Feb 27, 2021 at 11:27:03PM +0800, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver now only binds

Re: [PATCH V3 XRT Alveo 07/18] fpga: xrt: management physical function driver (root)

2021-02-26 Thread Moritz Fischer
On Fri, Feb 26, 2021 at 07:01:05AM -0800, Tom Rix wrote: > A question i do not know the answer to. > > Seems like 'golden' is linked to a manufacturing (diagnostics?) image. >From my brief history with Xilinx Ultrascale+ PCI cards I recall the golden image being a sort of known good recovery

Re: [PATCH V3 XRT Alveo 04/18] fpga: xrt: xrt-lib platform driver manager

2021-02-22 Thread Moritz Fischer
On Mon, Feb 22, 2021 at 07:05:29AM -0800, Tom Rix wrote: > > On 2/17/21 10:40 PM, Lizhi Hou wrote: > > xrt-lib kernel module infrastructure code to register and manage all > > leaf driver modules. > > > > Signed-off-by: Sonal Santan > > Signed-off-by: Max Zhen > > Signed-off-by: Lizhi Hou > >

Re: [PATCH V3 XRT Alveo 00/18] XRT Alveo driver overview

2021-02-21 Thread Moritz Fischer
Lizhi, On Wed, Feb 17, 2021 at 10:40:01PM -0800, Lizhi Hou wrote: > Hello, > > This is V3 of patch series which adds management physical function driver for > Xilinx > Alveo PCIe accelerator cards, > https://www.xilinx.com/products/boards-and-kits/alveo.html > This driver is part of Xilinx

Re: [PATCH V3 XRT Alveo 04/18] fpga: xrt: xrt-lib platform driver manager

2021-02-21 Thread Moritz Fischer
Lizhi, On Wed, Feb 17, 2021 at 10:40:05PM -0800, Lizhi Hou wrote: > xrt-lib kernel module infrastructure code to register and manage all > leaf driver modules. > > Signed-off-by: Sonal Santan > Signed-off-by: Max Zhen > Signed-off-by: Lizhi Hou > --- > drivers/fpga/xrt/lib/main.c | 274

Re: [PATCH V3 XRT Alveo 17/18] fpga: xrt: partition isolation platform driver

2021-02-21 Thread Moritz Fischer
On Wed, Feb 17, 2021 at 10:40:18PM -0800, Lizhi Hou wrote: > Add partition isolation platform driver. partition isolation is > a hardware function discovered by walking firmware metadata. > A platform device node will be created for it. Partition isolation > function isolate the different fpga

Re: [PATCH V3 XRT Alveo 12/18] fpga: xrt: ICAP platform driver

2021-02-21 Thread Moritz Fischer
On Wed, Feb 17, 2021 at 10:40:13PM -0800, Lizhi Hou wrote: > Add ICAP driver. ICAP is a hardware function discovered by walking > firmware metadata. A platform device node will be created for it. > FPGA bitstream is written to hardware through ICAP. > > Signed-off-by: Sonal Santan >

Re: [PATCH V3 XRT Alveo 16/18] fpga: xrt: DDR calibration platform driver

2021-02-21 Thread Moritz Fischer
Lizhi, On Wed, Feb 17, 2021 at 10:40:17PM -0800, Lizhi Hou wrote: > Add DDR calibration driver. DDR calibration is a hardware function > discovered by walking firmware metadata. A platform device node will > be created for it. Hardware provides DDR calibration status through > this function. > >

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-21 Thread Moritz Fischer
On Sun, Feb 21, 2021 at 06:57:31AM -0800, Tom Rix wrote: > As I am looking through the files, I have this comment. > > fpga/ is currently a single directory, while files could be organized in > subdirectories like > > dfl/pci.c > > instead have the possible subdir name as a prefix to the

Re: [PATCH V3 XRT Alveo 03/18] fpga: xrt: xclbin file helper functions

2021-02-21 Thread Moritz Fischer
On Sun, Feb 21, 2021 at 09:12:37AM -0800, Tom Rix wrote: > > On 2/17/21 10:40 PM, Lizhi Hou wrote: > > Alveo FPGA firmware and partial reconfigure file are in xclbin format. > This code enumerates and extracts > > Add > > code to enumerate and extract sections from xclbin files. xclbin.h is

Re: [PATCH v9 0/7] FPGA Security Manager Class Driver

2021-02-16 Thread Moritz Fischer
Hi Russ, On Tue, Feb 16, 2021 at 09:46:53AM -0800, Russ Weight wrote: > I believe all of the dependencies have been accepted now. > > - Russ Sorry for dropping the ball on this, I'll get to this ASAP after -rc1 is tagged. > > On 2/15/21 6:56 AM, Tom Rix wrote: > > Russ, Moritz > > > > This

Re: [PATCH 2/2] clk: axi-clkgen: Add support for FPGA info

2021-02-10 Thread Moritz Fischer
On Wed, Feb 10, 2021 at 12:15:35PM +0200, Alexandru Ardelean wrote: > From: Mircea Caprioru > > This patch adds support for vco maximum and minimum ranges in accordance VCO > with fpga speed grade, voltage, device package, technology and family. This FPGA > new information is extracted from two

Re: [PATCH 1/2] include: fpga: adi-axi-common.h: add definitions for supported FPGAs

2021-02-10 Thread Moritz Fischer
ses them. > > The register definitions are described at this link: > https://wiki.analog.com/resources/fpga/docs/hdl/regmap > (the 'Base (common to all cores)' section). > > Acked-by: Moritz Fischer This patchset is very different from the reviewed one earlier. Please don't just copy

Re: [PATCH v5 1/1] fpga: dfl: afu: harden port enable logic

2021-02-06 Thread Moritz Fischer
Russ, On Fri, Feb 05, 2021 at 10:25:21AM -0800, Russ Weight wrote: > Port enable is not complete until ACK = 0. Change > __afu_port_enable() to guarantee that the enable process > is complete by polling for ACK == 0. > > Reviewed-by: Tom Rix > Reviewed-by: Matthew Gerlach > Signed-off-by: Russ

Re: [PATCH] fpga: fpga-mgr: xilinx-spi: fix error messages on -EPROBE_DEFER

2021-02-06 Thread Moritz Fischer
On Thu, Feb 04, 2021 at 01:13:13PM +0100, Luca Ceresoli wrote: > The current code produces an error message on devm_gpiod_get() errors even > when the error is -EPROBE_DEFER, which should be silent. > > This has been observed producing a significant amount of messages like: > >

Re: [PATCH] fpga: xilinx-pr-decoupler: Simplify code by using dev_err_probe()

2021-02-06 Thread Moritz Fischer
On Thu, Feb 04, 2021 at 02:36:11PM +0100, Michal Simek wrote: > Use already prepared dev_err_probe() introduced by commit a787e5400a1c > ("driver core: add device probe log helper"). > It simplifies EPROBE_DEFER handling. > > Signed-off-by: Michal Simek > --- > >

Re: [PATCHv4 5/6] dt-bindings: fpga: add authenticate-fpga-config property

2021-02-01 Thread Moritz Fischer
On Mon, Feb 01, 2021 at 09:21:58AM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add authenticate-fpga-config property for FPGA bitstream authentication, > which makes sure a signed bitstream has valid signatures. > > Signed-off-by: Richard Gong > --- > v4: explain

Re: [PATCH v3 2/4] clk: clk-axiclkgen: add ZynqMP PFD and VCO limits

2021-02-01 Thread Moritz Fischer
ts and apply them. > > Signed-off-by: Dragos Bogdan > Signed-off-by: Mathias Tausen > Signed-off-by: Alexandru Ardelean Acked-by: Moritz Fischer > --- > drivers/clk/clk-axi-clkgen.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk

Re: [PATCH v3 1/4] clk: axi-clkgen: replace ARCH dependencies with driver deps

2021-02-01 Thread Moritz Fischer
> And adds dependencies on the mechanisms required by the driver to work (OF > and HAS_IOMEM). > > Signed-off-by: Dragos Bogdan > Signed-off-by: Alexandru Ardelean Reviewed-by: Moritz Fischer > --- > drivers/clk/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 del

Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-28 Thread Moritz Fischer
Hi Catalin, On Wed, Jan 27, 2021 at 01:09:36PM +, Catalin Marinas wrote: > On Thu, 21 Jan 2021 17:24:19 -0800, Moritz Fischer wrote: > > Address issue observed on real world system with suboptimal IORT table > > where DMA masks of PCI devices would get set

Re: [PATCH 3/3] fpga: versal-fpga: Add versal fpga manager driver

2021-01-27 Thread Moritz Fischer
On Wed, Jan 27, 2021 at 10:16:32AM +0100, Michal Simek wrote: > Hi > > On 1/27/21 9:57 AM, Nava kishore Manne wrote: > > Hi Moritz, > > > > Please find my response inline. > > > >> -----Original Message- > >> From: Moritz F

Re: [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

2021-01-27 Thread Moritz Fischer
On Wed, Jan 27, 2021 at 07:05:41AM -0600, Richard Gong wrote: > > Hi Greg, > > Thanks for review! > > On 1/27/21 6:04 AM, Greg KH wrote: > > On Mon, Jan 25, 2021 at 02:56:23PM -0600, richard.g...@linux.intel.com > > wrote: > > > From: Richard Gong > > > > > > Add

Re: [PATCHv3 2/6] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-01-27 Thread Moritz Fischer
Hi Richard, On Mon, Jan 25, 2021 at 02:56:24PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Extend Intel service layer driver to get the firmware version running at > FPGA device. Therefore FPGA manager driver, one of Intel service layer > driver's client, can decide

Re: [PATCHv3 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag

2021-01-27 Thread Moritz Fischer
On Mon, Jan 25, 2021 at 02:56:25PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add FPGA_MGR_BITSTREM_AUTHENTICATION flag for FPGA bitstream > authentication, which makes sure a signed bitstream has valid signatures. > > Except for the actual configuration of the device,

Re: [PATCH v2 1/3] clk: axi-clkgen: remove ARCH dependency in Kconfig

2021-01-26 Thread Moritz Fischer
Alexandru, On Tue, Jan 26, 2021 at 01:08:24PM +0200, Alexandru Ardelean wrote: > The intent is to be able to run this driver to access the IP core in setups > where FPGA board is also connected via a PCIe bus. In such cases the number > of combinations explodes, where the host system can be an

Re: [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property

2021-01-26 Thread Moritz Fischer
On Mon, Jan 25, 2021 at 02:56:26PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add authenticate-fpga-config property to support FPGA bitstream > authentication, which makes sure a signed bitstream has valid signatures. > > Signed-off-by: Richard Gong > --- > v3: no

Re: [PATCHv3 6/6] fpga: stratix10-soc: extend driver for bitstream authentication

2021-01-26 Thread Moritz Fischer
On Mon, Jan 25, 2021 at 02:56:28PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Extend FPGA manager driver to support FPGA bitstream authentication on > Intel SocFPGA platforms. > > Signed-off-by: Richard Gong > --- > v3: add handle to retriev the firmware version to

Re: [PATCHv3 5/6] dt-bindings: fpga: add authenticate-fpga-config property

2021-01-26 Thread Moritz Fischer
On Mon, Jan 25, 2021 at 02:56:27PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add authenticate-fpga-config property for FPGA bitstream authentication, > which makes sure a signed bitstream has valid signatures. > > Signed-off-by: Richard Gong > --- > v3: no change >

Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-26 Thread Moritz Fischer
On Tue, Jan 26, 2021 at 10:40:05AM +0800, Xu Yilun wrote: > On Mon, Jan 25, 2021 at 06:22:55PM -0800, Moritz Fischer wrote: > > On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote: > > > > > > On 1/25/21 12:49 AM, Xu Yilun wrote: > > > > This pa

Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-26 Thread Moritz Fischer
On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote: > > On 1/25/21 12:49 AM, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver now only binds the ether group feature, which

Re: [PATCH v3] selftests: drivers: fpga: A test for interrupt support

2021-01-23 Thread Moritz Fischer
TH_LOG("ioctl() failed to get the number irqs"); > + } > + ASSERT_LT(irq_num, 256) { > + TH_LOG("unexpeced number of irqs"); > + } > + close(devfd); > +} > + > +TEST_HARNESS_MAIN > -- > 2.27.0 > Looks good to me, from FPGA perspective, needs Acked-by from Shua, though. Also, this does not apply to linux-next, or for-5.12 or char-misc-next, so I'm confused :) Once that's sorted, feel free to add Acked-by: Moritz Fischer - Moritz

Re: [PATCH 1/3] drivers: firmware: Add Pdi load API support

2021-01-23 Thread Moritz Fischer
On Mon, Jan 18, 2021 at 08:13:16AM +0530, Nava kishore Manne wrote: > This patch adds load pdi api support to enable pdi/partial loading from > linux. Programmable Device Image (PDI) is combination of headers, images > and bitstream files to be loaded. Partial PDI is partial set of image/ > images

Re: [PATCH 3/3] fpga: versal-fpga: Add versal fpga manager driver

2021-01-23 Thread Moritz Fischer
Hi Nava, On Fri, Jan 22, 2021 at 10:34:15AM +, Nava kishore Manne wrote: > Hi Moritz, > > Thanks for the review. > Please find my response inline. > > > -Original Message----- > > From: Moritz Fischer > > Sent: Tuesday, January 19, 2021 6:03 AM &

Re: [PATCH v2] MAINTAINERS: Add FPGA SUBDEVICES

2021-01-22 Thread Moritz Fischer
On Fri, Jan 22, 2021 at 11:29:28AM -0800, t...@redhat.com wrote: > From: Tom Rix > > Every FPGA has several subdevices in other subsystems. > The new FPGA subdevices section is necessary to ensure changes to > the subdevices files get reviewed within the context of the FPGA > subsystem. > >

Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-22 Thread Moritz Fischer
On Fri, Jan 22, 2021 at 07:17:59PM +, Robin Murphy wrote: > On 2021-01-22 17:50, Moritz Fischer wrote: > > Hi Robin, > > > > On Fri, Jan 22, 2021 at 02:42:05PM +, Robin Murphy wrote: > > > On 2021-01-22 01:24, Moritz Fischer wrote: > > > > A

Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-22 Thread Moritz Fischer
Hi Robin, On Fri, Jan 22, 2021 at 02:42:05PM +, Robin Murphy wrote: > On 2021-01-22 01:24, Moritz Fischer wrote: > > Address issue observed on real world system with suboptimal IORT table > > where DMA masks of PCI devices would get set to 0 as result. > > > > i

Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support

2021-01-21 Thread Moritz Fischer
On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne wrote: > This commit adds secure flags to the framework to support > secure BitStream Loading. > > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/of-fpga-region.c | 10 ++ > include/linux/fpga/fpga-mgr.h | 12

Re: [PATCH 2/2] fpga: Add support for Xilinx DFX AXI Shutdown manager

2021-01-21 Thread Moritz Fischer
On Tue, Jan 19, 2021 at 06:34:54AM +, Nava kishore Manne wrote: > Hi Moritz, > > Thanks for the review. > Please find my response inline. > > > -Original Message----- > > From: Moritz Fischer > > Sent: Saturday, January 16, 2021 8:28 AM >

[PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-21 Thread Moritz Fischer
. Ideally we want to use the minimum mask of what the IORT contains for the root complex and what the device was configured with. Fixes: 5ac65e8c8941 ("ACPI/IORT: Support address size limit for root complexes") Signed-off-by: Moritz Fischer --- Changes from v1: - Changed warning to FW_

Re: [PATCH] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-21 Thread Moritz Fischer
Robin, On Thu, Jan 21, 2021 at 11:15:05PM +, Robin Murphy wrote: > On 2021-01-21 21:17, Moritz Fischer wrote: > > Robin, > > > > On Thu, Jan 21, 2021 at 08:08:42PM +, Robin Murphy wrote: > > > On 2021-01-21 19:16, Moritz Fischer wrote: > > > > A

Re: [PATCH] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-21 Thread Moritz Fischer
Robin, On Thu, Jan 21, 2021 at 08:08:42PM +, Robin Murphy wrote: > On 2021-01-21 19:16, Moritz Fischer wrote: > > Address issue observed on real world system with suboptimal IORT table > > where DMA masks of PCI devices would get set to 0 as result. > > > > i

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-21 Thread Moritz Fischer
Hi Tom, On Thu, Jan 21, 2021 at 06:30:20AM -0800, Tom Rix wrote: > > On 1/17/21 8:22 AM, Moritz Fischer wrote: > > Greg, > > > > On Sun, Jan 17, 2021 at 04:45:04PM +0100, Greg KH wrote: > >> On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > >

[PATCH] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-21 Thread Moritz Fischer
to use the minimum mask of what the IORT contains for the root complex and what the device was configured with, but never 0. Fixes: 5ac65e8c8941 ("ACPI/IORT: Support address size limit for root complexes") Signed-off-by: Moritz Fischer --- Hi all, not sure I'm doing this right, b

Re: [PATCH 3/3] fpga: versal-fpga: Add versal fpga manager driver

2021-01-18 Thread Moritz Fischer
Hi Nava, On Mon, Jan 18, 2021 at 08:13:18AM +0530, Nava kishore Manne wrote: > This patch adds driver for versal fpga manager. Nit: Add support for Xilinx Versal FPGA manager > > PDI source type can be DDR, OCM, QSPI flash etc.. No idea what PDI is :) > But driver allocates memory always from

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-17 Thread Moritz Fischer
Greg, On Sun, Jan 17, 2021 at 04:45:04PM +0100, Greg KH wrote: > On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver leverages the

Re: [PATCH v6 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-16 Thread Moritz Fischer
Hi Xu, On Wed, Jan 13, 2021 at 09:54:08AM +0800, Xu Yilun wrote: > This patch adds description for UIO support for dfl devices on DFL > bus. > > Signed-off-by: Xu Yilun > --- > v2: no doc in v1, add it for v2. > v3: some documentation fixes. > v4: documentation change since the driver matching

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-16 Thread Moritz Fischer
Hi Xu, On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the uio_pdrv_genirq > platform device with the

Re: [PATCH v2] selftests: drivers: fpga: A test for interrupt support

2021-01-16 Thread Moritz Fischer
Hi Tom, On Sat, Jan 16, 2021 at 11:33:21AM -0800, t...@redhat.com wrote: > From: Tom Rix > > Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns > an expected result. > > Tested on vf device 0xbcc1 > > Sample run with > # make -C tools/testing/selftests TARGETS=drivers/fpga run_tests

Re: [PATCH 2/2] fpga: Add support for Xilinx DFX AXI Shutdown manager

2021-01-15 Thread Moritz Fischer
Hi, On Fri, Jan 15, 2021 at 07:04:31AM +0530, Nava kishore Manne wrote: > This patch adds support for Xilinx Dynamic Function eXchange(DFX) AXI > shutdown manager IP. It can be used to safely handling the AXI traffic > on a Reconfigurable Partition when it is undergoing dynamic reconfiguration >

Re: [PATCH 0/8] FPGA DFL Changes for 5.12

2021-01-14 Thread Moritz Fischer
On Mon, Jan 11, 2021 at 02:39:36PM -0800, Tom Rix wrote: > > On 1/11/21 12:28 PM, Moritz Fischer wrote: > > Tom, > > > > On Mon, Jan 11, 2021 at 11:46:03AM -0800, Tom Rix wrote: > > > > [..] > >> I have been doing the first review in a couple o

Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting

2021-01-14 Thread Moritz Fischer
Hi Greg, On Mon, Jan 11, 2021 at 07:14:22PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 11, 2021 at 05:34:57PM +0100, Lukas Bulwahn wrote: > > On Mon, Jan 11, 2021 at 4:52 PM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jan 11, 2021 at 12:21:13PM +0100, Lukas Bulwahn wrote: > > > >

Re: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-12 Thread Moritz Fischer
Hi Xu, On Tue, Jan 12, 2021 at 08:16:15AM +0800, Xu Yilun wrote: > On Mon, Jan 11, 2021 at 06:59:10AM -0800, Tom Rix wrote: > > > > On 1/10/21 10:16 PM, Xu Yilun wrote: > > > On Sun, Jan 10, 2021 at 12:11:17PM -0800, Moritz Fischer wrote: > > >> On Sat, Jan 02

Re: [PATCH 0/8] FPGA DFL Changes for 5.12

2021-01-11 Thread Moritz Fischer
Tom, On Mon, Jan 11, 2021 at 11:46:03AM -0800, Tom Rix wrote: [..] > I have been doing the first review in a couple of days after every patch > landing. I appreciate your help with doing reviews. > I see some pretty good response from the developers to fix the issues raised.  ... yet

Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting

2021-01-11 Thread Moritz Fischer
ends without a blank line; unexpected unindent. > > Rectify ReST formatting in ./Documentation/fpga/dfl.rst. > > Signed-off-by: Lukas Bulwahn Acked-by: Moritz Fischer > --- > applies cleanly on next-20210111 > > Moritz, Matthew, please ack. > > Greg, please pick

Re: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-10 Thread Moritz Fischer
On Sat, Jan 02, 2021 at 11:13:01AM +0800, Xu Yilun wrote: > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the uio_pdrv_genirq > platform device with the DFL

Re: [PATCH v5 0/2] UIO support for dfl devices

2021-01-10 Thread Moritz Fischer
Hi Xu, On Sat, Jan 02, 2021 at 11:13:00AM +0800, Xu Yilun wrote: > This patchset supports some dfl device drivers written in userspace. > > In the patchset v1, the "driver_override" interface should be used to bind > the DFL UIO driver to DFL devices. But there is concern that the >

Re: [PATCH -next] fpga: Use DEFINE_SPINLOCK() for spinlock

2021-01-10 Thread Moritz Fischer
On Sat, Jan 09, 2021 at 02:08:53PM -0800, Tom Rix wrote: > > On 12/28/20 5:51 AM, Zheng Yongjun wrote: > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > > rather than explicitly calling spin_lock_init(). > > > > Signed-off-by: Zheng Yongjun > > This looks fine. > >

Re: [PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-10 Thread Moritz Fischer
On Sat, Jan 09, 2021 at 05:40:38PM -0800, Tom Rix wrote: > > On 1/9/21 2:52 PM, Rikard Falkeborn wrote: > > On Sat, Jan 09, 2021 at 01:55:13PM -0800, Tom Rix wrote: > >> On 1/8/21 3:54 PM, Rikard Falkeborn wrote: > >>> The only usage of these is to put their addresses in arrays of pointers > >>>

Re: [PATCH 0/8] FPGA DFL Changes for 5.12

2021-01-10 Thread Moritz Fischer
Tom, On Sun, Jan 10, 2021 at 07:46:29AM -0800, Tom Rix wrote: > > On 1/7/21 8:09 AM, Tom Rix wrote: > > On 1/6/21 8:37 PM, Moritz Fischer wrote: > >> This is a resend of the previous (unfortunately late) patchset of > >> changes for FPGA DFL. > > Is there so

[PATCH] PCI/IOV: Clarify error message for unbound devices

2021-01-08 Thread Moritz Fischer
Be more verbose to disambiguate the error case when trying to configure SRIOV with no driver bound vs. a driver that does not implement the SRIOV callback. Reported-by: Brian Foley Signed-off-by: Moritz Fischer --- drivers/pci/iov.c | 9 - 1 file changed, 8 insertions(+), 1 deletion

[PATCH 7/8] fpga: dfl: add support for N3000 Nios private feature

2021-01-06 Thread Moritz Fischer
From: Xu Yilun This patch adds support for the Nios handshake private feature on Intel PAC (Programmable Acceleration Card) N3000. The Nios is the embedded processor on the FPGA card. This private feature provides a handshake interface to FPGA Nios firmware, which receives retimer configuration

[PATCH 6/8] fpga: dfl: move dfl bus related APIs to include/linux/dfl.h

2021-01-06 Thread Moritz Fischer
header guards to match filename] Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked-by: Wu Hao Signed-off-by: Moritz Fischer --- MAINTAINERS | 1 + drivers/fpga/dfl.c | 1 + drivers/fpga/dfl.h | 72 - include/linux/dfl.h | 86

[PATCH 8/8] memory: dfl-emif: add the DFL EMIF private feature driver

2021-01-06 Thread Moritz Fischer
From: Xu Yilun This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control. The purpose of memory clearing block is to zero out all private memory when FPGA is

[PATCH 5/8] fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()

2021-01-06 Thread Moritz Fischer
in file2alias.c. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Signed-off-by: Matthew Gerlach Signed-off-by: Russ Weight Acked-by: Wu Hao Signed-off-by: Moritz Fischer --- scripts/mod/devicetable-offsets.c | 4 scripts/mod/file2alias.c | 13 + 2 files changed, 17

[PATCH 1/8] fpga: dfl: refactor cci_enumerate_feature_devs()

2021-01-06 Thread Moritz Fischer
From: Matthew Gerlach In preparation of looking for dfls based on a vendor specific pci capability, move the code for the default method of finding the first dfl at offset 0 of Bar 0 to its own function. Signed-off-by: Matthew Gerlach Acked-by: Wu Hao Signed-off-by: Moritz Fischer

[PATCH 4/8] fpga: dfl: move dfl_device_id to mod_devicetable.h

2021-01-06 Thread Moritz Fischer
Signed-off-by: Matthew Gerlach Signed-off-by: Russ Weight Reviewed-by: Tom Rix Acked-by: Wu Hao Signed-off-by: Moritz Fischer --- drivers/fpga/dfl.h | 13 + include/linux/mod_devicetable.h | 24 2 files changed, 25 insertions(+), 12 deletions

[PATCH 2/8] fpga: dfl-pci: locate DFLs by PCIe vendor specific capability

2021-01-06 Thread Moritz Fischer
From: Matthew Gerlach A PCIe vendor specific extended capability is introduced by Intel to specify the start of a number of DFLs. Signed-off-by: Matthew Gerlach Signed-off-by: Moritz Fischer --- Documentation/fpga/dfl.rst | 27 drivers/fpga/dfl-pci.c | 87

[PATCH 0/8] FPGA DFL Changes for 5.12

2021-01-06 Thread Moritz Fischer
This is a resend of the previous (unfortunately late) patchset of changes for FPGA DFL. This contains Matthew's changes to allow for more flexible discovery of DFLs. Xu's changeset adds support for DFL device drivers. Two of the first users are part of the patchset: dfl-emif a memory controller,

[PATCH 3/8] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2021-01-06 Thread Moritz Fischer
-off-by: Xu Yilun Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/dfl.c | 3 +-- drivers/fpga/dfl.h | 14 +++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index b450870b75ed..5a6ba3b2fa05 100644

Re: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-03 Thread Moritz Fischer
On Fri, Dec 04, 2020 at 01:17:37AM +, Max Zhen wrote: > Hi Moritz, > > I manually fixed some line breaks. Not sure why outlook is not doing it > properly. > Let me know if it still looks bad to you. That might just be outlook :) > > Please see my reply below. > > > > > > > Max, > > > >

Re: [PATCH 1/2] clk: axi-clkgen: wrap limits in a struct and keep copy on the state object

2020-12-02 Thread Moritz Fischer
Hi Alex, On Wed, Dec 02, 2020 at 06:10:42PM +0200, Alexandru Ardelean wrote: > On Mon, Oct 19, 2020 at 2:14 PM Alexandru Ardelean > wrote: > > > > Up until now the these limits were global/hard-coded, since they are > > typically limits of the fabric. > > > > However, since this is an FPGA

Re: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-02 Thread Moritz Fischer
Max, On Thu, Dec 03, 2020 at 03:38:26AM +, Max Zhen wrote: > [...cut...] > > > > > > +xclbin over the User partition as part of DFX. When a user > > > > > +requests loading of a specific xclbin the xmgmt management > > > > > +driver reads the parent interface UUID specified in the xclbin

Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files

2020-12-02 Thread Moritz Fischer
Hi Sonal, On Wed, Dec 02, 2020 at 06:57:11PM +, Sonal Santan wrote: > Hi Moritz, > > > -Original Message- > > From: Moritz Fischer > > Sent: Monday, November 30, 2020 8:27 PM > > To: Sonal Santan > > Cc: linux-kernel@vger.kernel.org; linux-f...@v

Re: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-02 Thread Moritz Fischer
Hi Max, On Wed, Dec 02, 2020 at 09:24:29PM +, Max Zhen wrote: > Hi Moritz, > > Thanks for your feedback. Please see my reply inline. > > Thanks, > -Max > > > -Original Message----- > > From: Moritz Fischer > > Sent: Monday, November 30, 2020 20

Re: [PATCH Xilinx Alveo 7/8] fpga: xrt: Alveo management physical function driver

2020-12-01 Thread Moritz Fischer
Hi Sonal, On Sat, Nov 28, 2020 at 04:00:39PM -0800, Sonal Santan wrote: > From: Sonal Santan > > Add management physical function driver core. The driver attaches > to management physical function of Alveo devices. It instantiates > the root driver and one or more partition drivers which in

Re: [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

2020-12-01 Thread Moritz Fischer
Hi Richard, On Tue, Dec 01, 2020 at 01:30:16PM -0600, Richard Gong wrote: > > Can U-Boot determine whether it's the new or old flow? Can you set a > > different compatible value in your device-tree, to disambiguate > > behaviors? > > > > The boot flow is determined by defconfig during

  1   2   3   4   5   6   7   8   9   10   >