Re: [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h

2020-09-14 Thread Moritz Fischer
On Tue, Sep 15, 2020 at 10:55:17AM +0800, Xu Yilun wrote: > On Mon, Sep 14, 2020 at 02:32:32PM -0700, Moritz Fischer wrote: > > Hao, > > > > On Fri, Sep 11, 2020 at 06:50:18AM +, Wu, Hao wrote: > > > > On 9/10/20 1:41 AM, Xu Yilun wrote: > > > > &g

Re: [PATCH v2 0/6] clk: axi-clk-gen: misc updates to the driver

2020-09-14 Thread Moritz Fischer
On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > wrote: > > > > These patches synchronize the driver with the current state in the > > Analog Devices Linux tree: > > https://github.com/analogdevicesinc/linux/ > > > > They

Re: [PATCH v2 5/6] include: fpga: adi-axi-common.h: add definitions for supported FPGAs

2020-09-14 Thread Moritz Fischer
On Mon, Aug 10, 2020 at 07:07:14AM -0700, Tom Rix wrote: > > On 8/10/20 6:42 AM, Alexandru Ardelean wrote: > > From: Mircea Caprioru > > > > All (newer) FPGA IP cores supported by Analog Devices, store information in > > the synthesized designs. This information describes various parameters, > >

Re: [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h

2020-09-14 Thread Moritz Fischer
Hao, On Fri, Sep 11, 2020 at 06:50:18AM +, Wu, Hao wrote: > > On 9/10/20 1:41 AM, Xu Yilun wrote: > > > On Wed, Sep 09, 2020 at 05:55:33AM -0700, Tom Rix wrote: > > >> On 9/7/20 10:48 PM, Xu Yilun wrote: > > >>> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this > > >>>

Re: [PATCH net-next 2/3] net: dec: tulip: de2104x: Replace pci_enable_device with devres version

2020-09-13 Thread Moritz Fischer
On Sun, Sep 13, 2020 at 05:10:01PM -0700, Moritz Fischer wrote: > Replace pci_enable_device() with its devres counterpart > pcim_enable_device(). > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++- > 1 file changed, 2 inser

[PATCH net-next 1/3] net: dec: tulip: de2104x: Replace alloc_etherdev by devm_alloc_etherdev

2020-09-13 Thread Moritz Fischer
Replace devm_alloc_etherdev() with its devres version. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c index

[PATCH net-next 2/3] net: dec: tulip: de2104x: Replace pci_enable_device with devres version

2020-09-13 Thread Moritz Fischer
Replace pci_enable_device() with its devres counterpart pcim_enable_device(). Signed-off-by: Moritz Fischer --- drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet

[PATCH net-next 3/3] net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup()

2020-09-13 Thread Moritz Fischer
Replace an instance of kmemdup() with the devres counted version instead. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec

[PATCH net-next 0/3] First bunch of cleanups

2020-09-13 Thread Moritz Fischer
This series is the first bunch of minor cleanups for the de2104x driver to make it look and behave more like a modern driver. These changes replace some of the non-devres versions with devres versions of functions to simplify the error paths. Next up after this will be the ioremap part. Moritz

Re: [PATCH] tulip: de2104x: switch from 'pci_' to 'dma_' API

2020-09-13 Thread Moritz Fischer
ssion e1, e2, e3, e4; > @@ > -pci_dma_sync_sg_for_device(e1, e2, e3, e4) > +dma_sync_sg_for_device(>dev, e2, e3, e4) > > @@ > expression e1, e2; > @@ > -pci_dma_mapping_error(e1, e2) > +dma_mapping_error(>dev, e2) > > @@ > expression e1, e2; > @@ >

Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip

2020-09-10 Thread Moritz Fischer
0 eth0: rx work limit reached > [ 102.251387] de2104x :17:00.0 eth0: rx work limit reached > [ 102.267444] de2104x :17:00.0 eth0: rx work limit reached > > Signed-off-by: Lucy Yan Reviewed-by: Moritz Fischer > --- > drivers/net/ethernet/dec/tulip/de2104x.c | 2 +- >

Re: [PATCH v8 1/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-09-09 Thread Moritz Fischer
Hi Xu, On Mon, Sep 07, 2020 at 10:23:13PM +0800, Xu Yilun wrote: > A new bus type "dfl" is introduced for private features which are not > initialized by DFL feature drivers (dfl-fme & dfl-afu drivers). So these > private features could be handled by separate driver modules. > > DFL feature

Re: [PATCH v8 1/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-09-08 Thread Moritz Fischer
On Mon, Sep 07, 2020 at 10:23:13PM +0800, Xu Yilun wrote: > A new bus type "dfl" is introduced for private features which are not > initialized by DFL feature drivers (dfl-fme & dfl-afu drivers). So these > private features could be handled by separate driver modules. > > DFL feature drivers

Re: [PATCH v7 3/3] fpga: dfl: add support for N3000 Nios private feature

2020-09-04 Thread Moritz Fischer
Hi Xu, On Wed, Aug 19, 2020 at 03:45:21PM +0800, Xu Yilun wrote: > This patch adds support for the Nios handshake private feature on Intel > PAC (Programmable Acceleration Card) N3000. > > The Nios is the embedded processor on the FPGA card. This private feature > provides a handshake interface

Re: [PATCH v7 2/3] fpga: dfl: create a dfl bus type to support DFL devices

2020-09-04 Thread Moritz Fischer
Hi Xu, On Wed, Aug 19, 2020 at 03:45:20PM +0800, Xu Yilun wrote: > A new bus type "dfl" is introduced for private features which are not > initialized by DFL feature drivers (dfl-fme & dfl-afu drivers). So these > private features could be handled by separate driver modules. > > DFL feature

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-04 Thread Moritz Fischer
Hi Russ, On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry

Re: [PATCH v7 1/3] fpga: dfl: map feature mmio resources in their own feature drivers

2020-08-30 Thread Moritz Fischer
On Wed, Aug 19, 2020 at 03:45:19PM +0800, Xu Yilun wrote: > This patch makes preparation for modularization of DFL sub feature > drivers. > > DFL based FPGA devices may contain some IP blocks which are already > supported by kernel, most of them are supported by platform device > drivers. We

Re: [PATCH v4 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure

2020-08-30 Thread Moritz Fischer
On Sun, Aug 30, 2020 at 06:38:50PM +0200, Luca Ceresoli wrote: > When the DONE pin does not go high after programming to confirm programming > success, the INIT_B pin provides some info on the reason. Use it if > available to provide a more explanatory error message. > > Reviewed-by: Tom Rix >

Re: [PATCH v4 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

2020-08-30 Thread Moritz Fischer
On Sun, Aug 30, 2020 at 06:38:49PM +0200, Luca Ceresoli wrote: > Current code calls gpiod_get_value() without error checking. Should the > GPIO controller fail, execution would continue without any error message. > > Fix by checking for negative error values. > > Reported-by: Tom Rix >

Re: [PATCH v4 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling

2020-08-30 Thread Moritz Fischer
On Sun, Aug 30, 2020 at 06:38:48PM +0200, Luca Ceresoli wrote: > If this routine sleeps because it was scheduled out, it might miss DONE > going asserted and consider it a timeout. This would potentially make the > code return an error even when programming succeeded. Rewrite the loop to > always

Re: [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment

2020-08-30 Thread Moritz Fischer
On Sun, Aug 30, 2020 at 06:38:46PM +0200, Luca Ceresoli wrote: > Remove comment committed by mistake. > > Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during > write_init") > Reviewed-by: Tom Rix > Signed-off-by: Luca Ceresoli > > --- > > Changes in v4: > - add

Re: [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings

2020-08-30 Thread Moritz Fischer
On Sun, Aug 30, 2020 at 06:38:47PM +0200, Luca Ceresoli wrote: > Most dev_err messages in this file have no final dot. Remove the only two > exceptions to make them consistent. > > Reviewed-by: Tom Rix > Signed-off-by: Luca Ceresoli > > --- > > Changes in v4: > - add Reviewed-by Tom Rix > >

Re: [PATCH v7 0/3] Modularization of DFL private feature drivers

2020-08-19 Thread Moritz Fischer
Hi Xu, On Wed, Aug 19, 2020 at 03:45:18PM +0800, Xu Yilun wrote: > This patchset makes it possible to develop independent driver modules > for DFL private features. It also helps to leverage existing kernel > drivers to enable some IP blocks in DFL. > > Patch #1: Release the dfl mmio regions

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-19 Thread Moritz Fischer
On Thu, Aug 13, 2020 at 05:04:09PM +0800, Xu Yilun wrote: > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > From: Xu Yilun > > > Sent: 13 August 2020 08:59 > > > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > > > From: M

Re: [PATCH 1/3] fpga manager: xilinx-spi: remove stray comment

2020-08-19 Thread Moritz Fischer
On Mon, Aug 17, 2020 at 06:59:09PM +0200, Luca Ceresoli wrote: > Remove comment committed by mistake. > > Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during > write_init") > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 1 - > 1 file changed, 1

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-11 Thread Moritz Fischer
On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu Yilun wrote: > The feature id is stored in a 12 bit field in DFH. So a u16 variable is > enough for feature id. > > This patch changes all feature id related places to fit u16. > > Signed-off-by: Xu Yilun > Reviewed-by: Tom Rix > Acked-by: Wu Hao >

Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga reviewer

2020-08-05 Thread Moritz Fischer
; > > M: Wu Hao > > > +R: Tom Rix > > > L: linux-f...@vger.kernel.org > > > S: Maintained > > > F: Documentation/fpga/dfl.rst > > > @@ -6813,6 +6814,7 @@ F: include/uapi/linux/fpga-dfl.h > > > > > &

Re: [RESEND PATCHv1] fpga: stratix10-soc: make FPGA task un-interruptible

2020-08-04 Thread Moritz Fischer
On Fri, Jul 24, 2020 at 11:10:09AM -0500, richard.g...@linux.intel.com wrote: > From: Richard Gong > > When CTRL+C occurs during the process of FPGA reconfiguration, the FPGA > reconfiguration process stops and the user can't perform a new FPGA > reconfiguration properly. > > Set FPGA task to

Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga reviewer

2020-08-04 Thread Moritz Fischer
ix > L: linux-f...@vger.kernel.org > S: Maintained > F: Documentation/fpga/dfl.rst > @@ -6813,6 +6814,7 @@ F: include/uapi/linux/fpga-dfl.h > > FPGA MANAGER FRAMEWORK > M: Moritz Fischer > +R: Tom Rix > L: linux-f...@vger.kernel.org > S: Ma

[GIT PULL] FPGA Manager changes for 5.9-rc1

2020-07-17 Thread Moritz Fischer
. All patches have been reviewed on the mailing list, and have been in the last few linux-next releases (as part of my for-next branch) without issues. Signed-off-by: Moritz Fischer Gustavo A. R. Silva (1): fpga: dfl: Use

[GIT PULL] FPGA Manager (late) fixes for 5.8

2020-07-17 Thread Moritz Fischer
in the reset of a port. Xu'x fix addresses a linter warning. All patches have been reviewed on the mailing list, and have been in the last few linux-next releases (as part of my fixes branch) without issues. Signed-off-by: Moritz Fischer

Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

2020-07-12 Thread Moritz Fischer
On Mon, Jul 13, 2020 at 09:47:46AM +0800, Xu Yilun wrote: > Add PCIe Device ID for Intel FPGA PAC N3000. > > Signed-off-by: Wu Hao > Signed-off-by: Xu Yilun > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ Weight > Reviewed-by: Wu Hao > Reviewed-by: Tom Rix > --- >

Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

2020-07-10 Thread Moritz Fischer
On Fri, Jul 10, 2020 at 06:14:19AM +, Wu, Hao wrote: > > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote: > > > > > > On 7/9/20 3:14 AM, Wu, Hao wrote: > > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote: > > > Subject: [PATCH] fpga: dfl: pci: add device id for Intel

Re: [PATCH v7 7/7] Documentation: fpga: dfl: add descriptions for interrupt related interfaces.

2020-07-06 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:48PM +0800, Xu Yilun wrote: > This patch adds introductions of interrupt related interfaces for FME > error reporting, port error reporting and AFU user interrupts features. > > Signed-off-by: Luwei Kang > Signed-off-by: Wu Hao > Signed-off-by: Xu Yilun >

Re: [PATCH v7 5/7] fpga: dfl: fme: add interrupt support for global error reporting

2020-07-06 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:46PM +0800, Xu Yilun wrote: > Error reporting interrupt is very useful to notify users that some > errors are detected by the hardware. Once users are notified, they > could query hardware logged error states, no need to continuously > poll on these states. > > This

Re: [PATCH v7 6/7] fpga: dfl: afu: add AFU interrupt support

2020-07-06 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:47PM +0800, Xu Yilun wrote: > AFU (Accelerated Function Unit) is dynamic region of the DFL based FPGA, > and always defined by users. Some DFL based FPGA cards allow users to > implement their own interrupts in AFU. In order to support this, > hardware implements a

Re: [PATCH v7 4/7] fpga: dfl: afu: add interrupt support for port error reporting

2020-07-06 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:45PM +0800, Xu Yilun wrote: > Error reporting interrupt is very useful to notify users that some > errors are detected by the hardware. Once users are notified, they > could query hardware logged error states, no need to continuously > poll on these states. > > This

Re: [PATCH v7 3/7] fpga: dfl: introduce interrupt trigger setting API

2020-06-28 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:44PM +0800, Xu Yilun wrote: > FPGA user applications may be interested in interrupts generated by > DFL features. For example, users can implement their own FPGA > logics with interrupts enabled in AFU (Accelerated Function Unit, > dynamic region of DFL based FPGA).

Re: [PATCH v7 1/7] fpga: dfl: parse interrupt info for feature devices on enumeration

2020-06-28 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:42PM +0800, Xu Yilun wrote: > DFL based FPGA devices could support interrupts for different purposes, > but current DFL framework only supports feature device enumeration with > given MMIO resources information via common DFL headers. This patch > introduces one new

Re: [PATCH v7 2/7] fpga: dfl: pci: add irq info for feature devices enumeration

2020-06-28 Thread Moritz Fischer
On Tue, Jun 16, 2020 at 12:08:43PM +0800, Xu Yilun wrote: > Some DFL FPGA PCIe cards (e.g. Intel FPGA Programmable Acceleration > Card) support MSI-X based interrupts. This patch allows PCIe driver > to prepare and pass interrupt resources to DFL via enumeration API. > These interrupt resources

Re: [PATCH v2 2/2] fpga manager: xilinx-spi: check INIT_B pin during write_init

2020-06-26 Thread Moritz Fischer
On Mon, Jun 22, 2020 at 03:37:23PM +0200, Luca Ceresoli wrote: > The INIT_B pin reports the status during startup and after the end of the > programming process. However the current driver completely ignores it. > > Check the pin status during startup to make sure programming is never > started

Re: [PATCH v2 1/2] dt-bindings: fpga: xilinx-slave-serial: add optional INIT_B GPIO

2020-06-26 Thread Moritz Fischer
On Mon, Jun 22, 2020 at 03:37:22PM +0200, Luca Ceresoli wrote: > The INIT_B is used by the 6 and 7 series to report the programming status, > providing more control and information about programming errors. > > Signed-off-by: Luca Ceresoli > > --- > > Changes in v2: > - rename init_b-gpios to

Re: [PATCH v7 0/7] Add interrupt support to FPGA DFL drivers

2020-06-23 Thread Moritz Fischer
Will look at it this week. - Moritz On Mon, Jun 22, 2020 at 10:30 PM Xu Yilun wrote: > > On Mon, Jun 22, 2020 at 05:27:20AM -0700, Tom Rix wrote: > > In addition to reviewing, I have run these changes on the pac a10 card and > > while i do not have an afu using interrupts, I have exercised

Re: [PATCH][next] fpga: dfl: Use struct_size() in kzalloc()

2020-06-18 Thread Moritz Fischer
On Wed, Jun 17, 2020 at 05:10:39PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function dfl_feature_platform_data_size(). > > This code was detected with the

Re: [PATCH v2 2/2] fpga: Fix dead store in fpga-bridge.c

2020-06-18 Thread Moritz Fischer
On Mon, Jun 08, 2020 at 05:54:46AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Using clang's scan-build/view this issue was flagged > a dead store issue in fpga-bridge.c > > warning: Value stored to 'ret' is never read [deadcode.DeadStores] > ret = id; > >

Re: [PATCH v2 1/2] fpga: Fix dead store fpga-mgr.c

2020-06-18 Thread Moritz Fischer
On Mon, Jun 08, 2020 at 05:54:45AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Using clang's scan-build/view this issue was flagged in fpga-mgr.c > > drivers/fpga/fpga-mgr.c:585:3: warning: Value stored to 'ret' is never read > [deadcode.DeadStores] > ret = id; > >

Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables

2020-06-18 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > >

Re: [PATCH 2/5] fpga manager: xilinx-spi: valid for the 7 Series too

2020-06-18 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:41PM +0200, Luca Ceresoli wrote: > The Xilinx 7-series uses the same protocol, mention that. > > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-spi.c

Re: [PATCH 1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too

2020-06-18 Thread Moritz Fischer
On Wed, Jun 17, 2020 at 04:38:41PM -0600, Rob Herring wrote: > On Thu, 11 Jun 2020 23:11:40 +0200, Luca Ceresoli wrote: > > The Xilinx 7-series uses the same protocol, mention that. > > > > Signed-off-by: Luca Ceresoli > > --- > > .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 9

Re: [PATCH 5/5] fpga manager: xilinx-spi: check INIT_B pin during write_init

2020-06-15 Thread Moritz Fischer
Hi Luca, On Thu, Jun 11, 2020 at 11:11:44PM +0200, Luca Ceresoli wrote: > The INIT_B reports the status during startup and after the end of the > programming process. However the current driver completely ignores it. > > Check the pin status during startup to make sure programming is never >

Re: [PATCH 1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too

2020-06-15 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:40PM +0200, Luca Ceresoli wrote: > The Xilinx 7-series uses the same protocol, mention that. > > Signed-off-by: Luca Ceresoli Acked-by: Moritz Fischer > --- > .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 9 ++--- > 1 file cha

Re: [PATCH v3] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-31 Thread Moritz Fischer
On Wed, May 27, 2020 at 12:10:21AM +, Wu, Hao wrote: > > -Original Message- > > From: John Hubbard > > Sent: Tuesday, May 26, 2020 6:18 AM > > To: LKML > > Cc: John Hubbard ; Xu, Yilun ; > > Wu, Hao ; Moritz Fischer ; linux- > > f...@vger.ke

Re: [PATCHv2] fpga: stratix10-soc: remove the pre-set reconfiguration condition

2020-05-31 Thread Moritz Fischer
On Fri, May 29, 2020 at 08:15:15AM -0500, Richard Gong wrote: > Hi Moritz, > > Sorry for asking. > > When you get chance, can you review my version 2 patch submitted on > 05/15/20? > > Regards, > Richard > > On 5/15/20 9:35 AM, richard.g...@linux.intel.com wrote: > > From: Richard Gong > > >

Re: [PATCH v2] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-23 Thread Moritz Fischer
tems' use of those pages. > > > > [1] Documentation/core-api/pin_user_pages.rst > > > > [2] "Explicit pinning of user-space pages": > > https://lwn.net/Articles/807108/ > > > > Cc: Xu Yilun > > Cc: Wu Hao > > Cc: Moritz Fische

Re: [PATCHv1] fpga: stratix10-soc: remove the pre-set reconfiguration condition

2020-05-12 Thread Moritz Fischer
Hi Richard, On Tue, May 12, 2020 at 08:27:31AM -0500, richard.g...@linux.intel.com wrote: > From: Richard Gong > > The reconfiguration mode is pre-set by driver as the full reconfiguration. > As a result, user have to change code and recompile the drivers if he or > she wants to perform a

Re: [PATCH v5 3/7] fpga: dfl: introduce interrupt trigger setting API

2020-05-11 Thread Moritz Fischer
On Mon, Apr 20, 2020 at 04:11:39PM +0800, Xu Yilun wrote: > FPGA user applications may be interested in interrupts generated by > DFL features. For example, users can implement their own FPGA > logics with interrupts enabled in AFU (Accelerated Function Unit, > dynamic region of DFL based FPGA).

Re: [PATCH v5 2/7] fpga: dfl: pci: add irq info for feature devices enumeration

2020-05-11 Thread Moritz Fischer
On Mon, Apr 20, 2020 at 04:11:38PM +0800, Xu Yilun wrote: > Some DFL FPGA PCIe cards (e.g. Intel FPGA Programmable Acceleration > Card) support MSI-X based interrupts. This patch allows PCIe driver > to prepare and pass interrupt resources to DFL via enumeration API. > These interrupt resources

Re: [PATCH v5 1/7] fpga: dfl: parse interrupt info for feature devices on enumeration

2020-05-11 Thread Moritz Fischer
On Mon, Apr 20, 2020 at 04:11:37PM +0800, Xu Yilun wrote: > DFL based FPGA devices could support interrupts for different purposes, > but current DFL framework only supports feature device enumeration with > given MMIO resources information via common DFL headers. This patch > introduces one new

Re: [PATCH 2/2] fpga: zynq: Add AFI config driver

2020-05-09 Thread Moritz Fischer
Hi Nava, On Mon, May 04, 2020 at 11:55:23AM +, Nava kishore Manne wrote: > Hi Mortiz, > > Thanks for proving the comments. > Please find my response inline. > > > -Original Message----- > > From: Moritz Fischer [mailto:m...@kernel.org] > > Sent:

Re: [PATCH] fpga: zynqmp: fix modular build

2020-05-09 Thread Moritz Fischer
On Tue, May 05, 2020 at 04:00:11PM +0200, Arnd Bergmann wrote: > Two symbols need to be exported to allow the zynqmp-fpga module > to get loaded dynamically: > > ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined! > ERROR: modpost: "zynqmp_pm_fpga_get_status"

Re: [PATCH v5 0/7] Add interrupt support to FPGA DFL drivers

2020-05-06 Thread Moritz Fischer
Hi Xu, On Tue, May 5, 2020 at 10:13 PM Xu Yilun wrote: > > Hi Moritz: > > Hao and I did several rounds of review and fix in the mailing list. Now > the patches are all acked by Hao. > > Could you please help review it when you have time? I'll get to it this weekend. Sorry for the delay, Moritz

Re: How to upload fpga firmware

2020-04-29 Thread Moritz Fischer
On Mon, Apr 27, 2020 at 08:44:33AM +0200, Sascha Hauer wrote: > On Fri, Apr 24, 2020 at 08:59:49PM -0700, Moritz Fischer wrote: > > Hi Sascha, > > > > On Thu, Apr 23, 2020 at 08:23:31AM +0200, Sascha Hauer wrote: > > > Hi Moritz, > > > > > >

Re: How to update a piece of flash for FPGA firmware?

2020-04-29 Thread Moritz Fischer
Hi Matthew, Yilun On Tue, Apr 28, 2020 at 03:06:07PM -0700, matthew.gerl...@linux.intel.com wrote: > Hi Yilun, > > You raise some very interesting questions. Please see > my comments below. > > Matthew > > On Tue, 28 Apr 2020, Xu Yilun wrote: > > > Hi, > > > > I wonder if an updating of FPGA

Re: [PATCH v4 1/2] fpga: fpga-mgr: Add readback support

2019-10-07 Thread Moritz Fischer
Hi Thor, On Mon, Oct 07, 2019 at 01:06:51PM -0500, Thor Thayer wrote: > Hi Moritz, > > On 9/27/19 1:23 PM, Moritz Fischer wrote: > > Thor, > > > > On Fri, Sep 27, 2019 at 09:32:11AM -0500, Thor Thayer wrote: > > > Hi Kedar & Moritz, > > > > &

Re: [PATCH v4 1/2] fpga: fpga-mgr: Add readback support

2019-09-27 Thread Moritz Fischer
Thor, On Fri, Sep 27, 2019 at 09:32:11AM -0500, Thor Thayer wrote: > Hi Kedar & Moritz, > > On 9/27/19 12:13 AM, Appana Durga Kedareswara Rao wrote: > > Hi Alan, > > > > Did you get a chance to send your framework changes to upstream? No they weren't upstreamed

[PATCH v2] net: fixed_phy: Add forward declaration for struct gpio_desc;

2019-09-03 Thread Moritz Fischer
From: Moritz Fischer Add forward declaration for struct gpio_desc in order to address the following: ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror] ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration

[PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

2019-09-03 Thread Moritz Fischer
not what you want [-Werror] Fixes commit 71bd106d2567 ("net: fixed-phy: Add fixed_phy_register_with_gpiod() API") Signed-off-by: Moritz Fischer --- include/linux/phy_fixed.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h index 1e

Re: [PATCH v6 14/57] fpga: Remove dev_err() usage after platform_get_irq()

2019-08-31 Thread Moritz Fischer
); > -... } > | > ... > -dev_err(...); > ) > ... > } > // > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Moritz Fischer > Cc: linux-f...@vger.kernel.org > Cc: Greg Kroah-Hartman > Signed-

[GIT PULL] Please pull FPGA Manager changes for 5.4

2019-08-31 Thread Moritz Fischer
. This patchset adds support for the v2 revision of Intel (Altera)'s CVP parts including the Stratix 10. All of this patches have been reviewed and been in the last few linux-next releases without issues. Signed-off-by: Moritz Fischer

Re: [RESEND PATCHv4 0/3] fpga: altera-cvp: Add Stratix10 Support

2019-08-24 Thread Moritz Fischer
Hi Thor, On Mon, Aug 19, 2019 at 03:48:05PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Newer versions (V2) of Altera/Intel FPGAs CvP have different PCI > Vendor Specific Capability offsets than the older (V1) Altera/FPGAs. > > Most of the CvP registers and their

[GIT PULL] FPGA Manager (late) change for 5.3-rc6

2019-08-18 Thread Moritz Fischer
receives -EPROBE_DEFER when trying to obtain a GPIO desc. Signed-off-by: Moritz Fischer Phil Reid (1): fpga: altera-ps-spi: Fix getting of optional confd gpio drivers/fpga/altera-ps-spi.c | 11 +++ 1 file changed, 7

[GIT PULL] Please pull FPGA Manager changes for 5.4

2019-07-31 Thread Moritz Fischer
the FPGA bridge bindings by consolidating them instead of repeating the same paragraph over and over again. All of these patches have been in the last few linux-next releases without issues. Signed-off-by: Moritz Fischer Carlos

Re: [PATCHv3 3/3] fpga: altera-cvp: Add Stratix10 (V2) Support

2019-07-26 Thread Moritz Fischer
On Thu, Jul 25, 2019 at 10:16:48AM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Add Stratix10 specific functions that use a credit mechanism > to throttle data to the CvP FIFOs. Add a private structure > with function pointers for V1 vs V2 functions. > > Signed-off-by: Thor

[PATCH] MAINTAINERS: Move linux-fpga tree to new location

2019-07-25 Thread Moritz Fischer
Move the linux-fpga tree to new location at: git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git Signed-off-by: Moritz Fischer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 783569e3c4b4..c3b5e3dbc74e 100644

Re: [PATCHv3 0/3] fpga: altera-cvp: Add Stratix10 Support

2019-07-25 Thread Moritz Fischer
Hi Thor, On Thu, Jul 25, 2019 at 10:16:45AM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Newer versions (V2) of Altera/Intel FPGAs CvP have different PCI > Vendor Specific Capability offsets than the older (V1) Altera/FPGAs. > > Most of the CvP registers and their

Re: [PATCHv2 2/3] fpga: altera-cvp: Preparation for V2 parts.

2019-07-24 Thread Moritz Fischer
Hi Thor, On Wed, Jul 24, 2019 at 11:59:12AM -0500, Thor Thayer wrote: > Hi Moritz, > > On 7/24/19 9:57 AM, Moritz Fischer wrote: > > On Tue, Jul 23, 2019 at 09:40:51AM -0500, Thor Thayer wrote: > > > Hi Moritz, > > > > > > On 7/21/19 7

Re: [PATCHv2 2/3] fpga: altera-cvp: Preparation for V2 parts.

2019-07-24 Thread Moritz Fischer
On Tue, Jul 23, 2019 at 09:40:51AM -0500, Thor Thayer wrote: > Hi Moritz, > > On 7/21/19 7:59 PM, Moritz Fischer wrote: > > Thor, > > > > On Tue, Jul 16, 2019 at 05:48:06PM -0500, thor.tha...@linux.intel.com wrote: > > > From: Thor Thayer > > > &

Re: [GIT PULL] FPGA Manager fix for 5.3

2019-07-24 Thread Moritz Fischer
On Wed, Jul 24, 2019 at 09:20:56AM +0200, Greg KH wrote: > On Tue, Jul 23, 2019 at 10:20:12PM -0700, Moritz Fischer wrote: > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > &

[GIT PULL] FPGA Manager fix for 5.3

2019-07-23 Thread Moritz Fischer
as builtin while a dependency is built as a module. This has been on the list for a while and I've reviewed it. Signed-off-by: Moritz Fischer YueHaibing (1): fpga-manager: altera-ps-spi: Fix build error drivers/fpga/Kconfig

Re: [PATCHv2 2/3] fpga: altera-cvp: Preparation for V2 parts.

2019-07-21 Thread Moritz Fischer
Thor, On Tue, Jul 16, 2019 at 05:48:06PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > In preparation for adding newer V2 parts that use a FIFO, > reorganize altera_cvp_chk_error() and change the write > function to block based. > V2 parts have a block size matching the FIFO

Re: [PATCHv2 3/3] fpga: altera-cvp: Add Stratix10 (V2) Support

2019-07-21 Thread Moritz Fischer
Hi Thor, looks mostly good. On Tue, Jul 16, 2019 at 05:48:07PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Add Stratix10 specific functions that use a credit mechanism > to throttle data to the CvP FIFOs. Add a private structure > with function pointers for V1 vs V2

Re: [PATCH 3/3] fpga: altera-cvp: Add Stratix10 (V2) Support

2019-07-14 Thread Moritz Fischer
Hi Thor, On Thu, Jul 11, 2019 at 03:32:50PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Add Stratix10 specific functions that use a credit mechanism > to throttle data to the CvP FIFOs. Add a private structure > with function pointers for V1 vs V2 functions. > >

Re: [PATCH 2/3] fpga: altera-cvp: Preparation for V2 parts.

2019-07-14 Thread Moritz Fischer
Hi Thor, On Thu, Jul 11, 2019 at 03:32:49PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > In preparation for adding newer V2 parts that use a FIFO, > reorganize altera_cvp_chk_error() and change the write > function to block based. > V2 parts have a block size matching the

Re: [PATCH 1/3] fpga: altera-cvp: Discover Vendor Specific offset

2019-07-14 Thread Moritz Fischer
On Thu, Jul 11, 2019 at 03:32:48PM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Newer Intel FPGAs have different Vendor Specific offsets than > legacy parts. Use PCI discovery to find the CvP registers. > Since the register positions remain the same, change the hard > coded

Re: [PATCH] fpga-manager: altera-ps-spi: Fix build error

2019-07-08 Thread Moritz Fischer
pends on SPI > + select BITREVERSE > help > FPGA manager driver support for Altera Arria/Cyclone/Stratix > using the passive serial interface over SPI. > -- > 2.7.4 > > Acked-by: Moritz Fischer

Re: [PATCH v4 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-06-27 Thread Moritz Fischer
Hi Wu, On Thu, Jun 27, 2019 at 12:44:45PM +0800, Wu Hao wrote: > This patch adds virtualization support description for DFL based > FPGA devices (based on PCIe SRIOV), and introductions to new > interfaces added by new dfl private feature drivers. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu

[PATCH] fpga: altera-pr-ip: Make alt_pr_unregister function void

2019-06-26 Thread Moritz Fischer
Make alt_pr_unregister function void, since it always returns 0, and nothing would act on the value anyways. Signed-off-by: Moritz Fischer --- drivers/fpga/altera-pr-ip-core-plat.c | 4 +++- drivers/fpga/altera-pr-ip-core.c | 4 +--- include/linux/fpga/altera-pr-ip-core.h | 2 +- 3 files

[PATCH 0/1] One cleanup patch for FPGA

2019-06-18 Thread Moritz Fischer
Hi Greg, please take this cleanup patch. It's been on the list but somehow fell through the cracks. Thanks, Moritz Enrico Weigelt (1): drivers: fpga: Kconfig: pedantic cleanups drivers/fpga/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.22.0

[PATCH 1/1] drivers: fpga: Kconfig: pedantic cleanups

2019-06-18 Thread Moritz Fischer
From: Enrico Weigelt Formatting of Kconfig files doesn't look so pretty, so just take damp cloth and clean it up. Signed-off-by: Enrico Weigelt Signed-off-by: Moritz Fischer --- drivers/fpga/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga

Re: [PATCH] MAINTAINERS: fpga: hand off maintainership to Moritz

2019-06-16 Thread Moritz Fischer
K: fmc_d.*register > > FPGA MANAGER FRAMEWORK > -M: Alan Tull > M: Moritz Fischer > L: linux-f...@vger.kernel.org > S: Maintained > -- > 2.21.0 > Cheers, Moritz

Re: [PATCH] fpga: dfl: afu: Pass the correct device to dma_mapping_error()

2019-05-08 Thread Moritz Fischer
Hi Scott, On Wed, May 08, 2019 at 04:39:51PM -0500, Scott Wood wrote: > On Mon, 2019-04-15 at 14:22 -0500, Alan Tull wrote: > > On Thu, Apr 11, 2019 at 11:36 AM Moritz Fischer > > wrote: > > > > Hi Scott, > > > > Thanks! > > > > > Hi Scott

[PATCH v2] fpga: zynqmp-fpga: Correctly handle error pointer

2019-05-07 Thread Moritz Fischer
the EPROBE_DEFER value in a special manner. Fixes commit c09f7471127e ("fpga manager: Adding FPGA Manager support for Xilinx zynqmp") Reported-by: Dan Carpenter Signed-off-by: Moritz Fischer --- Changes from v1: - Address Alan's feedback regarding handling both occurences. --- drivers/f

Re: [PATCH] fpga: zynqmp-fpga: Correctly handle error pointer

2019-05-07 Thread Moritz Fischer
Alan, On Tue, May 07, 2019 at 02:11:06PM -0500, Alan Tull wrote: > On Tue, May 7, 2019 at 12:03 PM Moritz Fischer wrote: > > Hi Moritz, > > > > > Fixes the following static checker error: > > > > drivers/fpga/zynqmp-fpga.c:50 zynqmp_fpga_ops_write() > >

Re: [PATCH v2 15/18] fpga: dfl: fme: add thermal management support

2019-05-07 Thread Moritz Fischer
Please for next round: +CC linux-hwmon, Guenter etc ... On Mon, Apr 29, 2019 at 04:55:48PM +0800, Wu Hao wrote: > This patch adds support to thermal management private feature for DFL > FPGA Management Engine (FME). This private feature driver registers > a hwmon for thermal/temperature

Re: [PATCH v2 07/18] fpga: dfl: pci: enable SRIOV support.

2019-05-07 Thread Moritz Fischer
Z > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/dfl-pci.c | 40 > drivers/fpga/dfl.c | 41 + > drivers/fpga/dfl

Re: [PATCH v2 06/18] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-05-07 Thread Moritz Fischer
form device of given port back to PF, it configures >PF/VF access mode to PF, then adds port platform device back to >re-enable related userspace interfaces on PF. > > Signed-off-by: Zhang Yi Z > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Acked-by: Alan Tull

Re: [PATCH v2 03/18] fpga: dfl: fme: align PR buffer size per PR datawidth

2019-05-07 Thread Moritz Fischer
m files to driver. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/dfl-fme-pr.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-pr.c b/

Re: [PATCH v2 02/18] fpga: dfl: fme: remove copy_to_user() in ioctl for PR

2019-05-07 Thread Moritz Fischer
On Mon, Apr 29, 2019 at 04:55:35PM +0800, Wu Hao wrote: > This patch removes copy_to_user() code in partial reconfiguration > ioctl, as it's useless as user never needs to read the data > structure after ioctl. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao Acked-

[PATCH] fpga: zynqmp-fpga: Correctly handle error pointer

2019-05-07 Thread Moritz Fischer
pport for Xilinx zynqmp") Reported-by: Dan Carpenter Signed-off-by: Moritz Fischer --- drivers/fpga/zynqmp-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c index f7cbaadf49ab..abcb0b2e75bf 100644 --- a/drivers/f

Re: [PATCH] fpga: stratix10-soc: fix use-after-free on s10_init()

2019-04-23 Thread Moritz Fischer
. > > Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver") > Signed-off-by: Wen Yang > Cc: Alan Tull > Cc: Moritz Fischer > Cc: Nicolas Saenz Julienne > Cc: linux-f...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Moritz

<    1   2   3   4   5   6   7   8   9   10   >