On Thu, May 16, 2013 at 1:19 PM, Andrew Morton
wrote:
> On Thu, 16 May 2013 13:08:17 -0400 Robert Love wrote:
>> This problem seems a rare proper use of mutex_trylock.
>
> Not really. The need for a trylock is often an indication that a
> subsystem has a locking misdesign.
On Thu, May 16, 2013 at 12:45 PM, Andrew Morton
wrote:
> A better approach would be to add a new __GFP_NOSHRINKERS, but it's all
> variations on a theme.
I don't like this proposal, either. Many of the existing GFP flags
already exist to prevent recurse into that flag's respective shrinker.
This
On Thu, May 16, 2013 at 4:15 AM, Raul Xiong wrote:
> The issue happens in such sequence:
> ashmem_mmap acquired ashmem_mutex --> ashmem_mutex:shmem_file_setup
> called kmem_cache_alloc --> shrink due to low memory --> ashmem_shrink
> tries to acquire the same ashmem_mutex -- it blocks here.
>
> I
Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the
shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is
fine, as ashmem cache pruning is advisory anyhow.
Signed-off-by: Robert Love
---
drivers/staging/android/ashmem.c | 6
On Tue, Apr 30, 2013 at 9:29 AM, Shankar Brahadeeswaran
wrote:
> Question:
> On occasions when we return because of the lock unavailability, what
> could be the worst case number of ashmem pages that are left
> unfreed (lru_count). Will it be very huge and have side effects?
On that VM shrink pa
On Thu, Apr 25, 2013 at 9:54 AM, Shankar Brahadeeswaran
wrote:
> Also, there are other places in the code where ashmem_mutex is held and memory
> allocation functions are called, ex:- range_alloc, calls kmem_cache_zalloc
>
> Since ashmem_shrink holds the ashmem_mutex, any where from ashmem driver
On Tue, Apr 23, 2013 at 12:20 PM, Shankar Brahadeeswaran
wrote:
> I'm unable to think of a straight forward way to fix this. If you have
> any suggestions please provide the same.
> If we are unable to solve this too with minor mods, as suggested by
> Dan we have to re-look at the locking in this
On Mon, Apr 22, 2013 at 10:22 AM, Dan Carpenter
wrote:
> Read Al's email again: https://lkml.org/lkml/2013/3/20/458
>
> I don't know much about VFS locking, but the ashmem locking seems
> pretty bogus to me. Why can't multiple threads read() at the same
> time?
ashmem originally did not support
On Thu, Mar 21, 2013 at 10:06 AM, Bjorn Bringert wrote:
> I did implement ashmem_read, but I had no idea what I was doing. Calling the
> VFS read function seemed like an obvious way to do it, but it might be
> wrong. If that needs fixing, then the similar VFS call in ashmem_llseek
> probably needs
Andrew,
Attached patch updates the hdaps driver in 2.6.13-mm2. It is a drop-in
replacement for the current patch.
Changes: bug fixes and an absolute input device.
Thanks,
Robert Love
driver for hdaps
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon
,
Robert Love
Driver for the IBM Hard Drive Active Protection System (HDAPS), an
accelerometer found in most modern ThinkPads.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
diff -urN linux-2.6.13/drivers/hwmon/hdaps.c linux/drivers/hwmon/hdaps.c
--- linux-2.6.13/drivers/hwmon/hdaps.c 1
t; and when /dev/hda1 is unmounted, you will get
an IN_UNMOUNT on the watch.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-circuiting.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/i386/kernel/dmi_scan.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urN linux-2.6.13/arch/i386/kernel/dmi_scan.c
linux/arch/i386/kernel/dmi_scan.c
--- linux-2.6.13/arch/i386/kernel/dmi_
to programmers reading the code.
> input_[un]register_device and del_timer_sync are "long" operations. I
> think a semaphore would be better here.
I was considering moving all locking to a single semaphore, actually.
Robert Love
-
To unsubscribe from this list: send
Andrew,
Attached patch provides a driver for the IBM Hard Drive Active
Protection System (hdaps) on top of 2.6.13-rc6-mm2.
Over the previous post, it contains several fixes and improvements,
including a dev->probe() routine and a DMI whitelist.
Robert Love
Driver for the IBM HD
On Fri, 2005-08-26 at 15:39 -0400, Robert Love wrote:
> > This is racy - 2 threads can try to do this simultaneously.
>
> Fixed. Thanks.
Actually, doesn't sysfs and/or the vfs layer serialize the two
simultaneous writes?
Robert Love
-
To unsubscribe from this li
On Fri, 2005-08-26 at 15:33 -0400, Jeff Garzik wrote:
> Since such a check is possible, that's definitely a merge-stopper IMO
First, I am not asking that Linus merge this. Everyone needs to relax.
Second, we don't know a DMI-based solution will work. I'll check it out.
device_create_file(&hdaps_plat_dev.dev, &dev_attr_mousedev);
> > + device_create_file(&hdaps_plat_dev.dev,
> > &dev_attr_mousedev_threshold);
> > + device_create_file(&hdaps_plat_dev.dev, &dev_attr_mousedev_poll_ms);
> > +
>
> What about
the
requisite hardware.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ns of people with a ThinkPad can feel free to
try a DMI-based probe() out, if they want a probe() routine, was my
point.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at htt
T=n, CONFIG_INPUT_MOUSEDEV=n, etc?
Probably a question you should of asked before merging the patch. ;-)
We just need CONFIG_INPUT.
Thanks,
Robert Love
Depend on CONFIG_INPUT.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
diff -u linux/drivers/hwmon/Kconfig linux/drivers/hwmo
On Fri, 2005-08-26 at 20:01 +0200, Arjan van de Ven wrote:
> > Not that we've been able to tell. It is a legacy platform device.
> >
> > So, unfortunately, no probe() routine.
>
> dmi surely
Patches accepted.
Robert Love
-
To unsubscribe
function name doesn't fit, but it never did.
>
> Signed-off-by: John McCutchan <[EMAIL PROTECTED]>
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
Keeping the current behavior is probably the best way to
On Fri, 2005-08-26 at 13:33 -0400, Brian Gerst wrote:
> Is there any way to detect that this device is present (PCI, ACPI, etc.)
> without poking at ports?
Not that we've been able to tell. It is a legacy platform device.
So, unfortunately, no probe() routine.
Robert
On Fri, 2005-08-26 at 13:05 -0400, Bill Nottingham wrote:
> How does this relate to the hdaps driver hosted at sourceforge since
> June?
This driver is what is hosted there.
I thought it was time to push on.
Robert Love
-
To unsubscribe from this list: send the line "
-contained and fairly simple.
Please, apply.
Robert Love
Driver for the IBM HDAPS, an accelerometer
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon/Makefile |1
drivers/hwmon/hdaps.c
t code and with 2.6.12-rc6-mm(1|2) kernel.
> >
> > Robert, John, what do you think? Is this possibly related to the oops
> > seen
> > in the log that I reported earlier? (Which is still showing up 2-3 times
> > per
> > day, btw)
>
> There is defini
w_above(),
which is I believe the behavior of the other interface, and see if the
1024-multiple problem goes away. We definitely did not have that
before.
If it does, and we don't have another solution, let's run with that for
2.6.13. I don't want this bug released.
Robe
was in our court and not the idr layer.
idr_get_new_above() seems to work fine.
One-line patch is attached. Please merge before 2.6.13.
Robert Love
We are saving the wrong thing in ->last_wd. We want the wd, not the return
value.
Signed-off-by: Robert Love <[EMAIL PROTECTED]&g
valds/linux-2.6.git;a=commit;h=7a91bf7f5c22c8407a9991cbd9ce5bb87caa6b4a
Should solve this problem?
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/
Add inotify and ioprio syscall stubs to SH64.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/sh64/kernel/syscalls.S |5 +
include/asm-sh64/unistd.h |7 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arc
Add inotify and ioprio syscall stubs to SH.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/sh/kernel/entry.S |5 +
include/asm-sh/unistd.h |8 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arch/sh/
Russell,
Hey. Attached patch adds the syscall stubs for the inotify and ioprio
system calls to ARM.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/arm/kernel/calls.S |6 ++
include/asm-arm/unistd.h |5 +
2 files changed, 11 insertions(+)
dif
lls.
We should.
Robert Love
Add fsnotify_xattr() hook to removexattr().
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/xattr.c |2 ++
1 files changed, 2 insertions(+)
diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c 2005-08-05 15:
The inotify help text still refers to the character device. Update it.
Fixes kernel bug #4993.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/Kconfig | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
--- linux-2.6.13-rc3-git8/fs/Kconfig2005-07-27 10:59:32.000
ad of a full stack frame just to sign extend arguments.
Yah, but it looked like they did the sign extend thing for every int but
file descriptors, and fd's are the only int's we have.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
r PPC64.
[ I don't think we need sys32 compatibility versions--and if we do, I
failed in life. ]
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ppc64/kernel/misc.S |6 ++
include/asm-ppc64/unistd.h |5 -
2 files changed, 10 insertions(+), 1 delet
Hi, Tony.
Attached patch adds the inotify syscalls to ia64.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ia64/kernel/entry.S |6 +++---
include/asm-ia64/unistd.h |3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff -urN linux-2.6.13-rc3-git8/arch/ia64/kernel/e
Hey, Paulus,
Add inotify system call stubs to PPC32.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ppc/kernel/misc.S |3 +++
include/asm-ppc/unistd.h |5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S
linu
On Fri, 2005-07-15 at 22:01 +0200, Andi Kleen wrote:
> It won't work anyways because you forgot to patch the compat
> sys32_open.
Well, "won't work" is a bit harsh, its just one hook. But that was
next.
I usually leave per-arch stuff to the arch folks.
Rober
Andi,
Attached patch adds the inotify syscall numbers to x86-64. Also adds
the new ioprio_get() and ioprio_set() calls to the IA32 layer.
Robert Love
Add the inotify syscalls to x86-64
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/x86_64/ia32/ia32entry.S
Linus,
Trivial documentation update for inotify. Please, apply.
Robert Love
Clean up and expand some of the inotify documentation.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
Documentation/filesystems/inotify.txt | 77 +++---
1 files chang
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN
It is a system call, now. ;-)
> OK - you exported a common underlying function
> inotify_inode_queue_event
> under the inline functions which the network/cluster fs would call to notify
> of remote changes.
> That makes sense. I had missed that.
Nod.
Robert Love
-
T
notify the
> local system about changes.
Eh?
They are in .
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN
Linus,
Attached patch rearranges the event ordering for "open" to be consistent
with the ordering of the other events.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
include/linux/fsnotify.h |2 +-
1
Linus,
Attached patch moves the inotify sysctl knobs to "/proc/sys/fs/inotify"
from "/proc/sys/fs". Also some related cleanup.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/
nse.
I would like to share some more code at a lower level, though, as you
pointed out.
I planned to look at redoing dnotify entirely on top of inotify, once
inotify is in the kernel proper, for example.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-
On Thu, 2005-07-07 at 04:00 -0700, Andrew Morton wrote:
> - Anything which you think needs to go into 2.6.13, please let me know.
Inotify?
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
M
his. Or at least
the I_WILL_FREE check.
Anyhow... I'll send out an updated inotify patch after some testing.
Thanks again.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
On Fri, 2005-04-22 at 22:13 +0100, Al Viro wrote:
> Or it would, if remove_watch() had been called only once. In the scenario
> above that will not be true.
Thanks.
Robert Love
Double check that we don't race.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs
On Thu, 2005-04-21 at 01:13 -0400, Robert Love wrote:
> Live from linux.conf.au, below is inotify against 2.6.12-rc3.
Here is an updated rediff for 2.6.12-rc3, with the changes from the last
day or so added:
- Add oneshot support for Tridge and Jeremy.
- Send IN_ATTRIB event
On Thu, 2005-04-21 at 01:13 -0400, Robert Love wrote:
> Live from linux.conf.au, below is inotify against 2.6.12-rc3.
Mark the open inotify device as nonseekable, so lseek() and such do not
work.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c |2 ++
1 files c
On Fri, 2005-04-22 at 05:51 +0200, Adrian Bunk wrote:
> This is a good example why development against Linus' tree is ofter
> pointless:
Seriously.
> A similar patch is already in -mm.
But...woohoo!
Robert Love
-
To unsubscribe from this list: send the line &quo
> Rusty and I's LCA kernel tutorial again brought up kstrdup(). Let's
> close this never ending saga and provide a standard kernel
> implementation.
Convert a few existing implementations, with a nice net loss of 50
lines. Still way more to go.
Best,
Robert Love
ded
strdup() uses. Some of which are surely buggy or less optimal than our
version, and all of which bloat the kernel.
Andrew, patch is against 2.6.12-rc3.
Best,
Robert Love
The world continually reimplements kstrdup(). Implement an optimal version
and export it to the world.
By: Rober
est,
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c|2 ++
include/linux/inotify.h |7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff -urN linux-2.6.12-rc3-inotify/fs/inotify.c linux/fs/inotify.c
--- linux-2.6.12-rc3-inoti
On Thu, 2005-04-21 at 01:13 -0400, Robert Love wrote:
> Live from linux.conf.au, below is inotify against 2.6.12-rc3.
G'day mates! By popular request!
Cheers,
Robert Love
Send an event on xattr change. Just use the existing metadata change event,
IN_ATTRIB, instead of addi
Live from linux.conf.au, below is inotify against 2.6.12-rc3.
Cheers,
Robert Love
inotify!
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each
t (except
maybe /proc).
The problem of changes on remote filesystems is solved by FAM.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
URL
as soon as the mirrors sync.
Thanks again!
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
e can add support at anytime, even
after inotify is merged. I'd be for it.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
le/rml/inotify/glib/
It integrates inotify watches into the glib mainloop via GIOChannel.
Everything is abstracted behind simple interfaces, so this might prove a
nice start for curious inotify developers.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-ker
appen when the user asks to remove a watch on a
wd that does not exist (I just forgot to check that error case in a bug
fix I added).
Keep pounding. It ought to be fixed, but please let me know if not!
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-k
On Tue, 2005-04-05 at 12:56 -0400, Robert Love wrote:
Mr Morton,
> Below is an updated inotify 0.22 patch, with various small clean ups and
> a fix for the oops reported by Prakash Punnoor. The oops was unrelated
> to the semaphore change, which seems to of been the right thing.
Be
Below is an updated inotify 0.22 patch, with various small clean ups and
a fix for the oops reported by Prakash Punnoor. The oops was unrelated
to the semaphore change, which seems to of been the right thing.
Patch is against 2.6.12-rc2.
Robert Love
inotify!
inotify is intended to
w minutes of
> uptime (compiling some stuff):
Ah, thanks. That was not even related to the semaphore rewrite, but a
small bug fix I slipped in. But of course.
Gamin is an interesting test case for us because it does so many
ignores.
Anyhow, this should fix it. Confirm?
Thanks,
Robert
. It can even be done
in an atomic fashion. See
http://mail.gnome.org/archives/dashboard-hackers/2004-October/msg00022.html
wherein I publish such an algorithm.
Hope this helps,
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel&q
On Mon, 2005-04-04 at 16:02 -0400, Robert Love wrote:
Greetings, Mr Morton.
> Below, find inotify 0.22, against 2.6.12-rc1.
>
> This release introduces a conversion in our primary locking from
> spinlocks to semaphores. Semaphores are a more natural fit for our
> code, which sy
match before coalescing.
Comments are welcome.
Robert Love
inotify!
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each directory
that you
y finished it
up today.
Below is an updated inotify, against 2.6.12-rc1, that no longer calls
iput() while atomic.
Robert Love
inotify!
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requ
ies do this. For example, GNOME handles segfaults, presenting the
user with various options (send bug report, restart application, etc).
The best bet, from an application developer's standpoint, is to just not
crash. Second best, save early and save often.
Robert Love
-
To unsub
On Wed, 2005-03-16 at 16:38 -0500, Robert Love wrote:
> Andrew, here is an updated inotify for 2.6.11-mm4 (replacing the current
> two patches), implementing your API suggestion. It is no different from
> the patch I sent you in private, , except it is the full patch and not
> an in
On Wed, 2005-03-16 at 16:34 -0500, Robert Love wrote:
> Below is an updated inotify patch for 2.6.11. The only change over the
> previous release is incorporating an API suggestion of Mr. Andrew
> Morton's: We now add watches via the file's file descriptor, not its
> pathn
is
located in Documentation/filesystems/inotify.txt.
Enjoy.
Robert Love
inotify!
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each directory
the PID's in /proc//task/, yes.
Or you can just set the PID of the main thread before it starts other
threads, or use chrt to launch the program, or use chrt to set the PID
of a shell script that starts the application: Scheduler properties are
inherited.
Best,
Robert Love
-
To unsubs
an I do with my threads. cpusets, perhaps...
Affinity is inherited.
Start the threads in a shell script that runs taskset on itself. Or
just modify this program to have the main thread do sched_setaffinity()
on itself.
Robert Love
-
To unsubscribe from this list: send the line "unsubscr
processor
> immediately as when I start the program directly with runon/taskset.
You have to bind all of the threads individually.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
ack.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
y user-space. It is stored in esp,
obviously, while inside of the kernel. And, yes, alloc_thread_info()
allocates the stack.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
e define a kernel stack?
I don't know what you mean. alloc_thread_info() creates the thread_info
structure and stack.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
On Tue, 2005-03-08 at 22:34 +0530, Imanpreet Arora wrote:
> I am wondering if someone could provide information as to how
> thread_struct is kept in memory. Robert Love mentions that it is kept
> at the "lowest" kernel address in case of x86 based platform. Could
&g
On Mon, 2005-03-07 at 23:50 -0500, Robert Love wrote:
> Yah, I just missed it. It is fixed in my tree.
Following patch, against 2.6.11-mm1, fixes the hooks in fs/compat.c.
Otherwise unchanged from the previous patch.
Robert Love
inotify!
inotify is intended to correct
27;t have a chance to compile-test
> the 32bit compat layer?
Yah, I just missed it. It is fixed in my tree.
Thanks,
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:
d and/or
> > metadata
> > + * was changed.
> > + */
> > +static inline void fsnotify_change(struct dentry *dentry, unsigned int
> > ia_valid)
>
> this one is far too large to be inlined.
I'd agree, but it is only called from one place. And this way everythi
On Fri, 2005-03-04 at 13:37 -0500, Robert Love wrote:
> I greatly reworked much of the data structures and their interactions,
> to lay the groundwork for sanitizing the locking. I then, I hope,
> sanitized the locking. It looks right, I am happy. Comments welcome.
> I surely cou
6-mm once.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
> bugs pop up almost weekly.
I don't follow this sentence.
Best,
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ple
TELY look at merging and
consolidating. But I think that we need to wait until one or the other
gets more traction and into the mainline kernel.
> Also, FYI:
> I just purchased the 2nd edition of your book, looking forward to reading it.
Great. Hope you enjoy it! ;-)
Best,
Robert
On Fri, 2005-03-04 at 13:37 -0500, Robert Love wrote:
Hey, Andrew.
> I greatly reworked much of the data structures and their interactions,
> to lay the groundwork for sanitizing the locking. I then, I hope,
> sanitized the locking. It looks right, I am happy. Comments welcome.
&
something big.
But, regardless, this release is a huge jump from the previous, fixing
all known issues and greatly improving the locking.
Best,
Robert Love
inotify!
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user
on x86).
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, 2005-02-23 at 12:03 +0100, Mathieu Segaud wrote:
> it is the latest Robert Love posted against -mm kernels, but in
> inotify_ignore():
I posted an updated patch last Friday, which fixed this.
Anyhow, this is the correct fix.
Signed-off-by: Robert Love <[EMAIL PROTECTED]
On Fri, 2005-02-18 at 17:24 +, Al Viro wrote:
> Fix the damn locking, already.
Fast as I can.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vg
On Thu, 2005-02-10 at 13:47 -0500, Robert Love wrote:
> Attached, find a patch against 2.6.11-rc3-mm2 of the latest inotify.
Updated patch, fixes a bug.
Robert Love
inotify, bitches
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/sparc64/Kconfig | 13
dri
version has numerous optimizations, bug fixes, and clean ups. It
introduces a generic notification layer to cleanly wrap both dnotify and
inotify hooks in fs/.
Pending is a data structure reorganization, to untangle some of the
locking.
Andrew, please apply!
Robert Love
inotify!
inotify is
ster to use mmap(1) over read(2). Then you can use
madvise().
Best,
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
How the fd is
obtained is up for discussion.
Ingo, what do you prefer?
Best,
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
so after
the call to getname, and we don't touch getname() or strncpy_from_user()
at all.
I wonder if there is another bug and inotify is just affecting the
timing?
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
1 - 100 of 121 matches
Mail list logo
