On 2021-03-29 09:15, Geert Uytterhoeven wrote:
Hoi Robin,
On Mon, Mar 29, 2021 at 9:09 AM Robin van der Gracht
wrote:
On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> The Holtek HT16K33 LED controller is not only used for driving
> dot-matrix displays, but also for driving segment di
+ break;
+ }
+ if (err)
+ return err;
+
+ err = linedisp_register(&seg->linedisp, dev, 4, seg->curr,
+ ht16k33_linedisp_update);
+ if (err)
+ goto err_remove_map_file;
+
+ return 0;
Groetjes/Kind regards,
Robin van der Gracht
light class can and more.
Maybe we can stop registering a backlight device in the fbdev case and
register a led device for both. This makes the code cleaner and drops
a dependency but will break backwards compatibility.
I'd prefer a single solution that covers both use cases, but I'm not
sure about the 'breaking backwards compatibility' consequence...
Groetjes / Kind regards,
Robin van der Gracht
The value for AVID stop is relative to the width of the active video area,
not the maximum register value. Zero means equal and a negative value means
we're cropping on the right side.
Signed-off-by: Robin van der Gracht
---
drivers/media/i2c/tvp5150.c | 4 ++--
1 file changed, 2 inser
power key with the older SoCs, we need
to send a keypress AND release when we get the power down request irq.
Signed-off-by: Robin van der Gracht
---
Changes v2 -> v3:
- Drop alt compatible string for identifying first revision snvs hardware,
read minor revision from register instead.
- D
power key with the older SoCs, we need
to send a keypress AND release when we get the power down request irq.
Signed-off-by: Robin van der Gracht
---
.../devicetree/bindings/crypto/fsl-sec4.txt | 16 --
drivers/input/keyboard/Kconfig| 2 +-
drivers/input/keyboard/snvs_pwrkey.c
The older imx6 SoCs do not send a power key press interrupt, instead it
sends a power down request interrupt when the key is released between
750ms and 5 seconds. The driver uses a different compatible string to ID
the older SoCs.
Signed-off-by: Robin van der Gracht
---
arch/arm/boot/dts
release when we get the powerdown request interrupt.
Signed-off-by: Robin van der Gracht
---
arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
arch/arm/boot/dts/imx6sll.dtsi | 2 +-
arch/arm/boot/dts/imx6sx.dtsi| 2 +-
arch/arm/boot/dts/imx6ul.dtsi| 2 +-
arch/arm/boot/dts
On 2019-08-19 09:51, Nishka Dasgupta wrote:
The static structures ht16k33_fb_fix and ht16k33_fb_var, of types
fb_fix_screeninfo and fb_var_screeninfo respectively, are not used
except to be copied into other variables. Hence make both of them
constant to prevent unintended modification.
Issue fou
gt; - return vm_insert_page(vma, vma->vm_start,
> - virt_to_page(priv->fbdev.buffer));
> + return vm_map_pages_zero(vma, &pages, 1);
> }
>
> static struct fb_ops ht16k33_fb_ops = {
Acked-by: Robin van der Gracht
t16k33_fbdev *fbdev = &priv->fbdev;
>
> - cancel_delayed_work(&fbdev->work);
> + cancel_delayed_work_sync(&fbdev->work);
> unregister_framebuffer(fbdev->info);
> framebuffer_release(fbdev->info);
> free_page((unsigned long) fbdev->buffer);
Looks good
Acked-by: Robin van der Gracht
On Thu, 31 Jan 2019 13:17:23 +0100
Ulf Hansson wrote:
> On Thu, 31 Jan 2019 at 09:20, Robin van der Gracht wrote:
> >
> > On Mon, 28 Jan 2019 22:15:23 +0100
> > Ulf Hansson wrote:
> >
> > > On Mon, 28 Jan 2019 at 15:41, Martin Kepplinger
> &g
ulator: %d\n", ret);
> > + goto out_mmc_free;
> > }
> >
> > ssp->clk = devm_clk_get(&pdev->dev, NULL);
> > --
> > 2.20.1
> >
>
> BTW, you didn't really answer my earlier question about the TI WiFi
> chip. Doesn't you need a special clock for WiFi chip as well? How do
> you intend to manage that?
I used an external 32K oscillator (SLOW_CLK) for my wl1271. Other
clocks ware generated on the module.
I had to supply a 'vmmc-supply' in your wl1271 devicetree node,
which will be used to power on/off the wlan module. The supply should
be a (delayed) GPIO controlled 'fixed-regulator' attached to the
wlan_en pin on the module.
1: Documentation/devicetree/bindings/net/wireless/ti,wlcore.txt
Kind regards,
--
Robin van der Gracht
Protonic Holland
tel.: +31 (0) 229 212928
fax.: +31 (0) 229 210930
Factorij 36 / 1689 AL Zwaag
nks Robin for your input!
>
> revision history
>
> v1: was just a question why this hasn't gone in earlier.
Not sure why it never made it. I created it for use with a wl1271 which
wan't properly reset in case of a fault. Also combined with imx28.
Regards,
Robin van der Gracht
;
> - }
> - }
> + if (!IS_ERR(reg_vmmc))
> + host->vmmc = reg_vmmc;
what about mmc_regulator_get_supply(mmc)?
If we use that the vmmc will be made available under mmv->supply->vmmc
if probe was successfull instead of storing it in the drivers private
struct.
>
> ssp->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(ssp->clk)) {
Robin van der Gracht
On Mon, 19 Feb 2018 08:44:17 +0100
Robin van der Gracht wrote:
> On Sat, 17 Feb 2018 20:39:55 +0100
> Miguel Ojeda wrote:
>
> > Cc: Willy Tarreau
> > Cc: Geert Uytterhoeven
> > Cc: Linus Walleij
> > Cc: Robin van der Gracht
> > Cc: Paul
On Sat, 17 Feb 2018 20:39:55 +0100
Miguel Ojeda wrote:
> Cc: Willy Tarreau
> Cc: Geert Uytterhoeven
> Cc: Linus Walleij
> Cc: Robin van der Gracht
> Cc: Paul Burton
> Signed-off-by: Miguel Ojeda
> ---
> Please let me know if you agree for your files and I wi
matrix_keypad_parse_of_params() was replaced early this year.
Signed-off-by: Robin van der Gracht
---
Early this year Dmitry Torokhov introduced a switch to using generic
device properties instead of being OF-specific.
Somehow this driver wasn't included in the update.
For reference:
Static naming causes problems when multiple devices are registered.
Reported-by: Michael Kaplan
Signed-off-by: Robin van der Gracht
---
Michael Kaplan reported the issue with his multiple
ht16k33 controller setup.
[ 472.124385] sysfs: cannot create duplicate filename
'/class/back
keyscan should be optional to support simple LED matrix displays (output only).
Reported-by: Michael Kaplan
Signed-off-by: Robin van der Gracht
---
Documentation/devicetree/bindings/display/ht16k33.txt | 15 +--
drivers/auxdisplay/ht16k33.c | 14
On Wed, 29 Mar 2017 00:42:08 -0700
Dmitry Torokhov wrote:
> The data read from the device is 3 little-endian words, so let's annotate
> them as such and use le16_to_cpu() to convert them to host endianness - it
> might turn out to be a bit more performant, and it expresses the conversion
> more c
he access is harmless because we never read the data, but we are better
> off not doing this, so this changes the code to only copy the data
> that was actually initialized. To make sure we don't overflow the
> stack with an incorrect DT, we also need to add a sanity checkin the
> prob
On Fri, 3 Mar 2017 15:14:05 +0100
Robin van der Gracht wrote:
> The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
>
> Reviewed-by: Fabio Estevam
> Signed-off-by: Robin van der Gracht
Sasha or Shawn would you mind pushing this patch upstream?
I don't h
Reviewed-by: Fabio Estevam
Signed-off-by: Robin van der Gracht
---
v2: Rebased on latest mainline
drivers/clk/imx/clk-imx6ul.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index dbd6e59..b4e0dff 100644
--- a
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
Reviewed-by: Fabio Estevam
Signed-off-by: Robin van der Gracht
---
Fixed another title typo in v3
drivers/clk/imx/clk-imx6ul.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
Reviewed-by: Fabio Estevam
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 75c35fb..dbd6e59
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 0f1f17a..4dcd107 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
try Torokhov
> ---
>
> v2: addressed Robin's feedback - changed interrupt trigger from
> IRQF_TRIGGER_RISING to IRQF_TRIGGER_HIGH
>
Works like a charm!
Tested-by: Robin van der Gracht
client *client,
> framebuffer_release(fbdev->info);
> err_fbdev_buffer:
> free_page((unsigned long) fbdev->buffer);
> -err_destroy_wq:
> - destroy_workqueue(priv->workqueue);
>
> return err;
> }
> @@ -521,7 +512,6 @@ static int ht16k33_remove(struct i2c_client *client)
> framebuffer_release(fbdev->info);
> free_page((unsigned long) fbdev->buffer);
>
> - destroy_workqueue(priv->workqueue);
> return 0;
> }
>
Acked-by: Robin van der Gracht
On Tue, 31 Jan 2017 12:54:37 -0800
Dmitry Torokhov wrote:
...
> +
> +static irqreturn_t ht16k33_keypad_irq_thread(int irq, void *dev)
> +{
> + struct ht16k33_keypad *keypad = dev;
> +
> + do {
> + wait_event_timeout(keypad->wait, keypad->stopped,
> +
t->dev, HT16K33_FB_SIZE, GFP_KERNEL);
> @@ -510,8 +510,6 @@ static int ht16k33_probe(struct i2c_client *client,
> framebuffer_release(fbdev->info);
> err_fbdev_buffer:
> free_page((unsigned long) fbdev->buffer);
> -err_free_fbdev:
> - kfree(fbdev);
> err_destroy_wq:
> destroy_workqueue(priv->workqueue);
>
Acked-by: Robin van der Gracht
Hello Dmitry,
Thank you for submitting your changes. I was out of office last week
and I'll try to test and review your changes on my hardware this week.
Best regards,
Robin van der Gracht
undefined reference to `sys_copyarea'
> drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
>
> Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
>
> Signed-off-by: Randy Dunlap
> Cc: Robin van der Gracht
> Cc: Miguel Oje
Reported-by: Arnd Bergmann
Signed-off-by: Robin van der Gracht
---
Greg: Bugfix for your char-misc-* tree
drivers/auxdisplay/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index a230ea7..4ef4c5c 100644
--- a/drivers/
On Tue, 29 Nov 2016 21:04:30 +0100
Greg Kroah-Hartman wrote:
> On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote:
> > On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> > > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wro
This selects the respective helpers required in addition to the one
Arnd Bergmann pointer out earlier.
Signed-off-by: Robin van der Gracht
---
This is a responce to https://lkml.org/lkml/2016/11/25/66
This patch complements the changes Arnd submitted earlier.
drivers/auxdisplay/Kconfig | 3
Hi Arnd,
On Wed, 23 Nov 2016 14:06:49 +0100
Arnd Bergmann wrote:
> The new driver caused a rare randconfig failure:
>
> drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference
> to `fb_sys_read'
> drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined referenc
This patch introduces a vendor prefix for Holtek Semiconductor Inc.
Signed-off-by: Robin van der Gracht
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b
Signed-off-by: Robin van der Gracht
CC: Miguel Ojeda Sandonis
Acked-by: Linus Walleij
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 411e3b8..15d9712 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3030,6 +3030,12 @@ F: drivers
Rebased and resend for Greg.
This patchset adds a new driver to the auxdisplay subsystem. It also adds
devicetree binding documentation and a new vendor prefix.
I added myself as maintainer to the MAINTAINERS file.
Robin van der Gracht (3):
of: add vendor prefix for Holtek Semiconductor
Added a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
CC: Miguel Ojeda Sandonis
Acked-by: Rob Herring
Reviewed-by: Linus Walleij
---
.../devicetree/bindings/display/ht16k33.txt| 42 ++
drivers/auxdisplay/Kconfig
Hi Randy,
On Tue, 1 Nov 2016 09:34:04 -0700
Randy Dunlap wrote:
> On 11/01/16 09:02, Robin van der Gracht wrote:
> > Hi Tobias,
> >
> > On Tue, 1 Nov 2016 16:33:03 +0100
> > Tobias Jakobi wrote:
> >
> >> Hello Robin,
> >>
> >> I&#
uld contact Daniel Vetter about this..?
> I don't have any nouveau platform here.
Me neither, the warning is shown when invoking Kconfig. So when I use
the config file supplied on my previous email, and start a build or a
menuconfig on my (x86_64) system its showing.
Regards,
--
Robin van der Gracht
Protonic Holland
one else selects FB, the warning mentioned above is raised.
Would you like to verify this?
Regards,
--
Robin van der Gracht
Protonic Holland
config.gz
Description: application/gzip
Signed-off-by: Robin van der Gracht
---
Changes in v2:
- Removed the trailing dot in the patch subject
.../devicetree/bindings/display/ht16k33.txt| 15 ++-
drivers/auxdisplay/ht16k33.c | 126 +++--
2 files changed, 73 insertions(+), 68
Signed-off-by: Robin van der Gracht
---
.../devicetree/bindings/display/ht16k33.txt| 15 ++-
drivers/auxdisplay/ht16k33.c | 126 +++--
2 files changed, 73 insertions(+), 68 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/ht16k33
Static naming causes problems when multiple devices are registered.
Signed-off-by: Robin van der Gracht
---
drivers/auxdisplay/ht16k33.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index eeb323f..9c09bbc
Added a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
CC: Miguel Ojeda Sandonis
Acked-by: Rob Herring
---
Changes in v7:
- Fixed unit for debounce-delay-ms in doc (microseconds -> milliseconds)
.../devicetree/bindings/display/ht16k33.
Signed-off-by: Robin van der Gracht
CC: Miguel Ojeda Sandonis
Acked-by: Linus Walleij
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 841ffa3..7e7368e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2998,6 +2998,12 @@ F: drivers
This patch introduces a vendor prefix for Holtek Semiconductor Inc.
Signed-off-by: Robin van der Gracht
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b
This patchset adds a new driver to the auxdisplay subsystem. It also adds
devicetree binding documentation and a new vendor prefix.
I added myself as maintainer to the MAINTAINERS file.
@Greg: Would you like to review and push this upstream?
Robin van der Gracht (3):
of: add vendor prefix for
On Wed, 18 May 2016 08:09:24 -0700
Greg Kroah-Hartman wrote:
> On Wed, May 18, 2016 at 02:23:16PM +0200, Robin van der Gracht wrote:
> > This patchset adds a new driver to the auxdisplay subsystem. It
> > also adds devicetree bindings documentation and a new vendor prefix.
&
This patchset adds a new driver to the auxdisplay subsystem. It also adds
devicetree bindings documentation and a new vendor prefix.
I added myself as maintainer to the MAINTAINERS file.
Robin van der Gracht (3):
of: add vendor prefix for Holtek Semiconductor
auxdisplay: ht16k33: Driver for
Signed-off-by: Robin van der Gracht
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9c567a4..54aed16 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2816,6 +2816,12 @@ F: drivers/usb/host/whci/
F: drivers/usb/wusbcore/
F
Signed-off-by: Robin van der Gracht
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 86740d4..84fb85d 100644
--- a
Added a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
Changes in v6:
- Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10'
.../devicetree/bindings/display/ht16k33.txt| 42 ++
dri
On Mon, 9 May 2016 16:27:00 +0200
Linus Walleij wrote:
> On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht
> wrote:
> > On Mon, 9 May 2016 15:19:26 +0200
> > Linus Walleij wrote:
> >
> >> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> >>
On Tue, 10 May 2016 09:10:04 +0200
Greg KH wrote:
> On Mon, May 09, 2016 at 04:27:00PM +0200, Linus Walleij wrote:
> > On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht
> > wrote:
> > > On Mon, 9 May 2016 15:19:26 +0200
> > > Linus Walleij wrote:
> >
On Mon, 9 May 2016 15:19:26 +0200
Linus Walleij wrote:
> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> wrote:
>
> > If you guys feel like auxdisplay is not the right subsystem for the
> > driver, and would like me to move it, please share.
>
> The best w
t; But, not relevant for this patch, of course.
If you guys feel like auxdisplay is not the right subsystem for the
driver, and would like me to move it, please share.
Regards,
Robin van der Gracht
Added a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
Changes in v5:
- Updated compatible string
- the HT16K33_FB_SIZE define now uses BYTES_PER_ROW as multiplier instead of 2
- Dropped a trailing '\' in ht16k33.txt
- Shorte
Signed-off-by: Robin van der Gracht
---
Changes in v5:
- Changed vendor prefix from 'ht' into 'holtek'
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Docu
This patch series adds a driver for the ht16k33 LED controller and a
new vendor prefix for Holtek Semiconductor Inc.
Robin van der Gracht (2):
of: add vendor prefix for Holtek Semiconductor
auxdisplay: ht16k33: Driver for LED controller
.../devicetree/bindings/display/ht16k33.txt
On Fri, 18 Mar 2016 16:42:17 -0500
Rob Herring wrote:
> On Wed, Mar 16, 2016 at 04:52:09PM +0100, Robin van der Gracht wrote:
> > This is a driver for the Holtek HT16K33 RAM mapping LED controller
> > with keyscan.
>
> Wrap your lines to less than 80 chars.
I must
On Fri, 18 Mar 2016 16:32:59 -0500
Rob Herring wrote:
> I think holtek being a bit longer would be better here.
Thank you for your feedback. I'll adjust this.
Kind regards,
--
Robin van der Gracht
Protonic Holland
This patch series adds a driver for the ht16k33 LED controller and a
new vendor prefix for Holtek Semiconductor Inc.
Robin van der Gracht (2):
of: add vendor prefix for Holtek Semiconductor
auxdisplay: ht16k33: Driver for LED controller
.../devicetree/bindings/display/ht16k33.txt
This patch introduces a vendor prefix for Holtek Semiconductor Inc.
Signed-off-by: Robin van der Gracht
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree
This is a driver for the Holtek HT16K33 RAM mapping LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
Changes in v4:
- Removed trailing dot from patch title
- Removed unused defines
- Fixed brightness range (0 was presumed to be off but its 1/16 duty cycle)
- No longer
This is a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
Changes in v3:
- Renamed device-tree property 'refresh-rate' to 'refresh-rate-hz'
- Renamed device-tree property 'default-brightness' to
'default-
On Fri, 12 Feb 2016 09:12:43 -0600
Rob Herring wrote:
> On Tue, Feb 09, 2016 at 12:31:08PM +0100, Robin van der Gracht wrote:
> > This is a driver for the Holtek HT16K33 LED controller with keyscan.
> >
> > Signed-off-by: Robin van der Gracht
> > ---
> > C
This is a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
Changes in v2:
- Fixed build error reported by kbuild test robot by including mm.h
.../devicetree/bindings/display/ht16k33.txt| 42 ++
drivers/auxdisplay/Kconfig
This is a driver for the Holtek HT16K33 LED controller with keyscan.
Signed-off-by: Robin van der Gracht
---
.../devicetree/bindings/display/ht16k33.txt| 42 ++
drivers/auxdisplay/Kconfig | 9 +
drivers/auxdisplay/Makefile| 1
van der Gracht
---
drivers/pwm/pwm-mxs.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index a53d309..7e1fa0a 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -10,6 +10,7 @@
*/
#include
+#include
#include
:
pwm: pwm-mxs: Wait for configuration to apply before disabling PWM
is more accurate?
Agreed
On Wed, Jun 19, 2013 at 01:51:26PM +0200, Robin van der Gracht wrote:
When disabling the pwm, the output state locks at its current state.
Please use the proper spelling "PWM" in
output period.
Signed-off-by: Robin van der Gracht
---
drivers/pwm/pwm-mxs.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index 3febddd..4ddc063 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -21,6 +21,7
host->base + LCDC_VDCTRL4);
clk_disable(host->clk);
--
1.5.6.5
Ping. Any comments on this?
Lothar Waßmann
I've encountered this problem to, and i can confirm your patch fixed it.
The VDCTRL4 register has no CLR feature.
Regards,
--
Robin van der Gracht
Protonic Holland.
tel.: +31 (0)
77 matches
Mail list logo
