[PATCH v3 0/3] PCI: iproc: Add fixes to pcie iproc

2020-10-01 Thread Srinath Mannam
comments - pcie_print_link_status is used to print Link information. - Added IARR1/IMAP1 window map definition. Bharat Gooty (1): PCI: iproc: Fix out-of-bound array accesses Roman Bacik (1): PCI: iproc: Invalidate correct PAXB inbound windows Srinath Mannam (1): PCI: iproc: Display

[PATCH v3 3/3] PCI: iproc: Display PCIe Link information

2020-10-01 Thread Srinath Mannam
After successful linkup more comprehensive information about PCIe link speed and link width will be displayed to the console. Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/controller/pcie-iproc.c b

[PATCH v3 1/3] PCI: iproc: Fix out-of-bound array accesses

2020-10-01 Thread Srinath Mannam
From: Bharat Gooty Declare the full size array for all revisions of PAX register sets to avoid potentially out of bound access of the register array when they are being initialized in iproc_pcie_rev_init(). Fixes: 06324ede76cdf ("PCI: iproc: Improve core register population") Signed-off-by:

[PATCH v3 2/3] PCI: iproc: Invalidate correct PAXB inbound windows

2020-10-01 Thread Srinath Mannam
/IMAP1 because it was missed in previous patch. Fixes: 9415743e4c8a ("PCI: iproc: Invalidate PAXB address mapping") Signed-off-by: Roman Bacik Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [PATCH v2 3/3] PCI: iproc: Display PCIe Link information

2020-09-16 Thread Srinath Mannam
On Thu, Sep 17, 2020 at 7:22 AM Rob Herring wrote: > Hi Rob, Thanks for review. > On Tue, Sep 15, 2020 at 07:15:41PM +0530, Srinath Mannam wrote: > > After successful linkup more comprehensive information about PCIe link > > speed and link width will be displayed to the conso

Re: [PATCH v2 0/3] PCI: iproc: Add fixes to pcie iproc

2020-09-16 Thread Srinath Mannam
On Thu, Sep 17, 2020 at 3:38 AM Bjorn Helgaas wrote: > Hi Bjorn, Thanks for review. > On Tue, Sep 15, 2020 at 07:15:38PM +0530, Srinath Mannam wrote: > > This patch series contains fixes and improvements to pcie iproc driver. > > > > This patch set is based on Linux-5.

[PATCH v2 0/3] PCI: iproc: Add fixes to pcie iproc

2020-09-15 Thread Srinath Mannam
Gooty (1): PCI: iproc: fix out of bound array access Roman Bacik (1): PCI: iproc: fix invalidating PAXB address mapping Srinath Mannam (1): PCI: iproc: Display PCIe Link information drivers/pci/controller/pcie-iproc.c | 29 ++--- 1 file changed, 22 insertions(+), 7

[PATCH v2 3/3] PCI: iproc: Display PCIe Link information

2020-09-15 Thread Srinath Mannam
After successful linkup more comprehensive information about PCIe link speed and link width will be displayed to the console. Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/controller/pcie-iproc.c b

[PATCH v2 1/3] PCI: iproc: fix out of bound array access

2020-09-15 Thread Srinath Mannam
From: Bharat Gooty Declare the full size array for all revisions of PAX register sets to avoid potentially out of bound access of the register array when they are being initialized in the 'iproc_pcie_rev_init' function. Fixes: 06324ede76cdf ("PCI: iproc: Improve core register population")

[PATCH v2 2/3] PCI: iproc: fix invalidating PAXB address mapping

2020-09-15 Thread Srinath Mannam
/IMAP1 because it was missed in previous patch. Fixes: 9415743e4c8a ("PCI: iproc: Invalidate PAXB address mapping") Signed-off-by: Roman Bacik Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[PATCH v3] iommu/dma: Fix IOVA reserve dma ranges

2020-09-14 Thread Srinath Mannam
Fix IOVA reserve failure in the case when address of first memory region listed in dma-ranges is equal to 0x0. Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address") Signed-off-by: Srinath Mannam --- Changes from v2: Modify error message with useful i

Re: [PATCH v2] iommu/dma: Fix IOVA reserve dma ranges

2020-09-14 Thread Srinath Mannam
On Fri, Sep 11, 2020 at 8:47 PM Bjorn Helgaas wrote: > Hi Bjorn, Thanks for review. > On Fri, Sep 11, 2020 at 03:55:34PM +0530, Srinath Mannam wrote: > > Fix IOVA reserve failure in the case when address of first memory region > > listed in dma-ranges is equal to 0x0. > >

[PATCH v2] iommu/dma: Fix IOVA reserve dma ranges

2020-09-11 Thread Srinath Mannam
Fix IOVA reserve failure in the case when address of first memory region listed in dma-ranges is equal to 0x0. Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address") Signed-off-by: Srinath Mannam --- Changes from v1: Removed unnecessary changes based

Re: [PATCH] iommu/dma: Fix IOVA reserve dma ranges

2020-09-10 Thread Srinath Mannam
On Wed, Sep 9, 2020 at 5:35 PM Robin Murphy wrote: > Hi Robin, Thanks for review > On 2020-09-09 06:32, Srinath Mannam wrote: > > Fix IOVA reserve failure for memory regions listed in dma-ranges in the > > following cases. > > > > - start address of memory region

[PATCH] iommu/dma: Fix IOVA reserve dma ranges

2020-09-08 Thread Srinath Mannam
dress") Signed-off-by: Srinath Mannam --- drivers/iommu/dma-iommu.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 5141d49a046b..0a3f67a4f9ae 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers

Re: [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address

2020-05-27 Thread Srinath Mannam
On Wed, May 27, 2020 at 11:00 PM Robin Murphy wrote: > Thanks Robin for your quick response. > On 2020-05-27 17:03, Srinath Mannam wrote: > > This patch gives the provision to change default value of MSI IOVA base > > to platform's suitable IOVA using module parameter. The pre

[RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address

2020-05-27 Thread Srinath Mannam
dress"), inaccessible IOVA address ranges parsed from dma-ranges property are reserved. If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa000" command line argument. Signed-off-by: Srinath Mannam --- drivers/

Re: [PATCH 2/2] gpio: iproc-gpio: Handle interrupts for multiple instances

2019-09-20 Thread Srinath Mannam
Hi Linus, We have tested patch with your changes, it works fine. Thanks a lot for all the help. Regards, Srinath. On Wed, Sep 11, 2019 at 3:13 PM Linus Walleij wrote: > > On Thu, Aug 29, 2019 at 5:52 AM Srinath Mannam > wrote: > > > From: Rayagonda Kokatanur > > &g

Re: [PATCH] PCI: Add PCIE ACS quirk for IPROC PAXB

2019-09-06 Thread Srinath Mannam
9:45AM +0530, Srinath Mannam wrote: > > From: Abhinav Ratna > > > > IPROC PAXB RC doesn't support ACS capabilities and control registers. > > Add quirk to have separate IOMMU groups for all EPs and functions connected > > to root port, by masking RR/CR/SV/UF

Re: [PATCH v2 0/4] Reset xHCI port PHY on disconnect

2019-09-03 Thread Srinath Mannam
Hi Mathias, Could you please help to review this patch series? Regards, Srinath. On Wed, Jul 31, 2019 at 3:50 PM Srinath Mannam wrote: > > This patch set adds a quirk in xHCI driver to reset PHY of xHCI port on > its disconnect event. > > This patch set is based on Linux-5.2-r

[PATCH 2/2] gpio: iproc-gpio: Handle interrupts for multiple instances

2019-08-28 Thread Srinath Mannam
From: Rayagonda Kokatanur When multiple instance of iproc-gpio chips are present, a fix up message[1] is printed during the probe of second and later instances. This issue is because driver sharing same irq_chip data structure among multiple instances of driver. Fix this by allocating irq_chip

[PATCH 1/2] gpio: iproc-gpio: Fix incorrect pinconf configurations

2019-08-28 Thread Srinath Mannam
From: Li Jin Fix drive strength for AON/CRMU controller; fix pull-up/down setting for CCM/CDRU controller. Fixes: 616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc") Signed-off-by: Li Jin --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 96 +--- 1 file

[PATCH 0/2] Add fixes to iProc GPIO driver

2019-08-28 Thread Srinath Mannam
This patch series adds the following fixes to the iProc GPIO driver - Fix Warning message given for shared irqchip data structure - Fix pinconfig of pull-up/down and drive strength for AON/CRMU GPIOs This patch set is based on Linux-5.2-rc4. Changes from v1: - Add Fixes tags in both patches

[PATCH v2 6/6] arm64: dts: Change PCIe INTx mapping for NS2

2019-08-28 Thread Srinath Mannam
From: Ray Jui Change the PCIe INTx mapping to model the 4 INTx interrupts in the IRQ domain of the iProc PCIe controller itself Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 28 1 file changed, 24

[PATCH v2 5/6] arm: dts: Change PCIe INTx mapping for HR2

2019-08-28 Thread Srinath Mannam
From: Ray Jui Change the PCIe INTx mapping to model the 4 INTx interrupts in the IRQ domain of the iProc PCIe controller itself Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- arch/arm/boot/dts/bcm-hr2.dtsi | 30 ++ 1 file changed, 26 insertions(+), 4

[PATCH v2 2/6] PCI: iproc: Add INTx support with better modeling

2019-08-28 Thread Srinath Mannam
register Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 100 +++- drivers/pci/controller/pcie-iproc.h | 6 +++ 2 files changed, 104 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-iproc.c b

[PATCH v2 4/6] arm: dts: Change PCIe INTx mapping for NSP

2019-08-28 Thread Srinath Mannam
From: Ray Jui Change the PCIe INTx mapping to model the 4 INTx interrupts in the IRQ domain of the iProc PCIe controller itself Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- arch/arm/boot/dts/bcm-nsp.dtsi | 45 -- 1 file changed, 39

[PATCH v2 0/6] PAXB INTx support with proper model

2019-08-28 Thread Srinath Mannam
This patch series adds PCIe legacy interrupt (INTx) support to the iProc PCIe driver by modeling it with its own IRQ domain. All 4 interrupts INTA, INTB, INTC, INTD share the same interrupt line connected to the GIC in the system. This is now modeled by using its own IRQ domain. Also update all

[PATCH v2 1/6] dt-bindings: pci: Update iProc PCI binding for INTx support

2019-08-28 Thread Srinath Mannam
From: Ray Jui Update the iProc PCIe binding document for better modeling of the legacy interrupt (INTx) support Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- .../devicetree/bindings/pci/brcm,iproc-pcie.txt| 48 ++ 1 file changed, 41 insertions(+), 7

[PATCH v2 3/6] arm: dts: Change PCIe INTx mapping for Cygnus

2019-08-28 Thread Srinath Mannam
From: Ray Jui Change the PCIe INTx mapping to model the 4 INTx interrupts in the IRQ domain of the iProc PCIe controller itself Signed-off-by: Ray Jui Signed-off-by: Srinath Mannam --- arch/arm/boot/dts/bcm-cygnus.dtsi | 30 ++ 1 file changed, 26 insertions(+), 4

Re: [PATCH v2 2/5] dt-bindings: phy: Modify Stingray USB PHY #phy-cells

2019-08-27 Thread Srinath Mannam
03:49:52PM +0530, Srinath Mannam wrote: > > Increase #phy-cells from 1 to 2 to have bitmask of PHY enabled ports. > > And from 0 to 1... > > Are you going to update all the dts files so when we convert this to > schema we don't get a bunch of warnings? (Feel free to c

[PATCH] PCI: Add PCIE ACS quirk for IPROC PAXB

2019-08-19 Thread Srinath Mannam
From: Abhinav Ratna IPROC PAXB RC doesn't support ACS capabilities and control registers. Add quirk to have separate IOMMU groups for all EPs and functions connected to root port, by masking RR/CR/SV/UF bits. Signed-off-by: Abhinav Ratna Signed-off-by: Srinath Mannam --- drivers/pci/quirks.c

Re: [PATCH v4 0/3] PCIe Host request to reserve IOVA

2019-05-01 Thread Srinath Mannam
renzo Pieralisi wrote: > > > > On Fri, Apr 12, 2019 at 08:43:32AM +0530, Srinath Mannam wrote: > > > > > Few SOCs have limitation that their PCIe host can't allow few inbound > > > > > address ranges. Allowed inbound address ranges are listed in >

[PATCH] thermal: broadcom: Remove ACPI support

2019-04-29 Thread Srinath Mannam
Unlike DT framework, thermal-zones and its parameters can't be parsed using ACPI framework. So that ACPI support is removed in this driver. Signed-off-by: Srinath Mannam Reported-by: David Woodhouse --- drivers/thermal/broadcom/sr-thermal.c | 8 1 file changed, 8 deletions(-) diff

Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2019-04-29 Thread Srinath Mannam
Hi David, Thank you for notifying.. Hi Sudeep, I will send a patch to remove ACPI support. Regards, Srinath. On Mon, Apr 29, 2019 at 8:54 PM Sudeep Holla wrote: > > On Mon, Apr 29, 2019 at 06:07:12PM +0300, David Woodhouse wrote: > > On Mon, 2018-05-28 at 11:11 +0530, Srinath

[PATCH] PCI: iproc: Enable iProc config read for PAXBv2

2019-04-26 Thread Srinath Mannam
iProc config read flag has to enable for PAXBv2 instead of PAXB. Fixes: f78e60a29d4ff ("PCI: iproc: Reject unconfigured physical functions from PAXC") Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v4 2/3] iommu/dma: Reserve IOVA for PCIe inaccessible DMA address

2019-04-11 Thread Srinath Mannam
in the list. This method is similar to PCI IO resources address ranges reserving in IOMMU for each EP connected to host bridge. Signed-off-by: Srinath Mannam Based-on-patch-by: Oza Pawandeep Reviewed-by: Oza Pawandeep --- drivers/iommu/dma-iommu.c | 19 +++ 1 file changed, 19 insertions

[PATCH v4 0/3] PCIe Host request to reserve IOVA

2019-04-11 Thread Srinath Mannam
from v3: - Addressed Robin Murphy review comments. - pcie-iproc: parse dma-ranges and make sorted resource list. - dma-iommu: process list and reserve gaps between entries Changes from v2: - Patch set rebased to Linux-5.0-rc2 Changes from v1: - Addressed Oza review comments. Srinath

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-03 Thread Srinath Mannam
and have detailed description of feature and implementation. Thank again for you patience. Regards, Srinath. On Wed, Apr 3, 2019 at 5:01 PM Lorenzo Pieralisi wrote: > > On Wed, Apr 03, 2019 at 08:41:44AM +0530, Srinath Mannam wrote: > > Hi Lorenzo, > > > > Please see my rep

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Tue, Apr 2, 2019 at 7:08 PM Lorenzo Pieralisi wrote: > > On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath Mannam wrote: > > [...] > > > > Ok - I start to understand. What does it mean in HW terms that your > > > 32bi

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Tue, Apr 2, 2019 at 3:56 PM Lorenzo Pieralisi wrote: > > On Tue, Apr 02, 2019 at 03:20:21PM +0530, Srinath Mannam wrote: > > Hi Ray, > > > > Thanks for detailed explanation. > > Please see some more details below. > >

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
de section. I hope that will help to > make it more clear. > > On 4/1/2019 9:44 AM, Lorenzo Pieralisi wrote: > > On Mon, Apr 01, 2019 at 11:04:48AM +0530, Srinath Mannam wrote: > >> Hi Lorenzo, > >> > >> Please see my reply below, > >> > >> On Fri, Mar

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-03-31 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Fri, Mar 29, 2019 at 11:06 PM Lorenzo Pieralisi wrote: > > On Fri, Mar 01, 2019 at 10:22:16AM +0530, Srinath Mannam wrote: > > In the present driver outbound window configuration is done to map above > > 32-bit address I/O regions with

Re: linux-next: build warning after merge of the phy-next tree

2019-03-27 Thread Srinath Mannam
Hi Stephen, Thanks for the notice. I sent patch to fix this warning. https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1964942.html Regards, Srinath. On Thu, Mar 28, 2019 at 5:59 AM Stephen Rothwell wrote: > > Hi Kishon, > > After merging the phy-next tree, today's linux-next build

Re: [PATCH v4 0/2] Add IPROC PCIe new features

2019-03-27 Thread Srinath Mannam
Hi Lorenzo, Thanks for feedback, I will talk to our HW engineer. Regards, Srinath. On Wed, Mar 27, 2019 at 6:01 PM Lorenzo Pieralisi wrote: > > On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > > Hi Lorenzo/Bjorn, > > > > Could you please help to revie

[PATCH] phy: sr-usb: fix build warning

2019-03-27 Thread Srinath Mannam
PHY driver) Reported-by: kbuild test robot Signed-off-by: Srinath Mannam --- drivers/phy/broadcom/phy-bcm-sr-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/broadcom/phy-bcm-sr-usb.c b/drivers/phy/broadcom/phy-bcm-sr-usb.c index bfe8237..fe6c589 100644

Re: [PATCH v4 0/2] Add IPROC PCIe new features

2019-03-27 Thread Srinath Mannam
Hi Lorenzo/Bjorn, Could you please help to review this patch series when you have time? I believe I have addressed all your review comments. Thanks, Srinath. On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam wrote: > > This patch set extends support of new IPROC PCIe host controller fe

Re: [PATCH v6 0/3] Stingray USB PHY driver support

2019-03-26 Thread Srinath Mannam
tch series, > >> > >> Acked-by: Scott Branden > >> > > > > Kishon, can you let me know when you apply patches 1 and 2 so I can > > queue up patch 3 for inclusion the 5.2 ARM SoC pull request? Thanks! > > merged the dt-binding and sr-usb driver, thanks. Thanks a

[PATCH v6 2/3] phy: sr-usb: Add Stingray USB PHY driver

2019-03-19 Thread Srinath Mannam
USB PHY driver supports two types of stingray USB PHYs - Type 1 is a combo PHY contains two PHYs, one SS and one HS. - Type 2 is a single HS PHY. These two PHY versons support both Generic xHCI host controller driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam

[PATCH v6 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-03-19 Thread Srinath Mannam
use SS-PHY in SS mode and HS-PHY in HS mode. xHCI0 port1 is SS-PHY0, port2 is HS-PHY0. xHCI1 port1 is SS-PHY1, port2 is HS-PHY2 and port3 is HS-PHY1. Signed-off-by: Srinath Mannam --- .../boot/dts/broadcom/stingray/stingray-usb.dtsi | 72 ++ .../arm64/boot/dts/broadcom

[PATCH v6 0/3] Stingray USB PHY driver support

2019-03-19 Thread Srinath Mannam
- Updated patchset to Linux-5.0-rc2 Changes from v1: - Addressed Kishon review comments - phy init call return value handle Srinath Mannam (3): dt-bindings: phy: Add Stingray USB PHY binding document phy: sr-usb: Add Stingray USB PHY driver arm64: dts: Add USB DT nodes for Stingray SoC

[PATCH v6 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-03-19 Thread Srinath Mannam
Add DT binding document for Stingray USB PHY. Signed-off-by: Srinath Mannam Reviewed-by: Rob Herring --- .../bindings/phy/brcm,stingray-usb-phy.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/brcm,stingray-usb

[PATCH v5 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-03-12 Thread Srinath Mannam
use SS-PHY in SS mode and HS-PHY in HS mode. xHCI0 port1 is SS-PHY0, port2 is HS-PHY0. xHCI1 port1 is SS-PHY1, port2 is HS-PHY2 and port3 is HS-PHY1. Signed-off-by: Srinath Mannam --- .../boot/dts/broadcom/stingray/stingray-usb.dtsi | 78 ++ .../arm64/boot/dts/broadcom

[PATCH v5 2/3] phy: sr-usb: Add Stingray USB PHY driver

2019-03-12 Thread Srinath Mannam
USB PHY driver supports two types of stingray USB PHYs - Type 1 is a combo PHY contains two PHYs, one SS and one HS. - Type 2 is a single HS PHY. These two PHY versons support both Generic xHCI host controller driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam

[PATCH v5 0/3] Stingray USB PHY driver support

2019-03-12 Thread Srinath Mannam
comments - phy init call return value handle Srinath Mannam (3): dt-bindings: phy: Add Stingray USB PHY binding document phy: sr-usb: Add Stingray USB PHY driver arm64: dts: Add USB DT nodes for Stingray SoC .../bindings/phy/brcm,stingray-usb-phy.txt | 40 +++ .../boot/dts

[PATCH v5 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-03-12 Thread Srinath Mannam
Add DT binding document for Stingray USB PHY. Signed-off-by: Srinath Mannam --- .../bindings/phy/brcm,stingray-usb-phy.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt diff --git

Re: [PATCH v4 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-03-11 Thread Srinath Mannam
Hi Rob, Thank you, I will send next patch set with the changes as you suggested. Regards, Srinath. On Tue, Mar 12, 2019 at 3:00 AM Rob Herring wrote: > > On Sun, Mar 10, 2019 at 10:32 PM Srinath Mannam > wrote: > > > > Hi Rob, > > > > Please find my comments be

Re: [PATCH v4 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-03-10 Thread Srinath Mannam
Hi Rob, Please find my comments below, On Sat, Feb 23, 2019 at 1:05 AM Rob Herring wrote: > > On Fri, Feb 22, 2019 at 11:29 AM Srinath Mannam > wrote: > > > > Hi Rob, > > > > Thanks for the review, Please find my comments below in line. > > > >

[PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-02-28 Thread Srinath Mannam
ranges = <0x8300 0x0 0x4200 0x0 0x4200 0 0x200>; I/O region address is 0x4200 Signed-off-by: Srinath Mannam Signed-off-by: Abhishek Shah Signed-off-by: Ray Jui --- drivers/pci/controller/pcie-iproc.c | 21 +++-- 1 file changed, 19 insertions(+),

[PATCH v4 0/2] Add IPROC PCIe new features

2019-02-28 Thread Srinath Mannam
. Changes from v2: - Based on Lorenzo Pieralisi comments, commit logs are expanded. Changes from v1: - Addressed Bjorn Helgaas comments. - Removed set order mode patch from patchset. Srinath Mannam (2): PCI: iproc: Add CRS check in config read PCI: iproc: Add outbound configuration

[PATCH v4 1/2] PCI: iproc: Add CRS check in config read

2019-02-28 Thread Srinath Mannam
using status flags before reissue config read. Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c index

Re: [PATCH v3 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-02-28 Thread Srinath Mannam
Hi Lorenzo, Thanks for the review.. Please see my comments below in line.. Regards, Srinath. On Thu, Feb 28, 2019 at 9:43 PM Lorenzo Pieralisi wrote: > > On Wed, Feb 20, 2019 at 10:03:55PM +0530, Srinath Mannam wrote: > > In the present driver outbound window configuration is done

Re: [PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-27 Thread Srinath Mannam
Hi Rob, Thanks for the information. Please find my comments below. Regards, Srinath. On Tue, Feb 26, 2019 at 11:33 PM Rob Herring wrote: > > On Mon, Feb 25, 2019 at 10:57 PM Srinath Mannam > wrote: > > > > Hi Rob, > > Thanks for the review, Please see my comments bel

Re: [PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-25 Thread Srinath Mannam
Hi Rob, Thanks for the review, Please see my comments below in line. Regards, Srinath. On Tue, Feb 26, 2019 at 3:08 AM Rob Herring wrote: > > On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote: > > Add usb-phy-port-reset optional property to set quirk in xhci platfor

Re: [PATCH v4 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-22 Thread Srinath Mannam
Hi Rob, Thanks for the review, Please find my comments below in line. On Fri, Feb 22, 2019 at 10:50 PM Rob Herring wrote: > > On Wed, Feb 20, 2019 at 04:04:00PM +0530, Srinath Mannam wrote: > > Add DT binding document for Stingray USB PHY. > > > > Signed-off-by: Srin

Re: [PATCH v3 0/3] PCIe Host request to reserve IOVA

2019-02-21 Thread Srinath Mannam
Hi Bjorn, Please help to review this patch series. Thank you. Regards, Srinath. On Fri, Jan 25, 2019 at 3:44 PM Srinath Mannam wrote: > > Few SOCs have limitation that their PCIe host can't allow few inbound > address ranges. Allowed inbound address ranges are listed in dma-ranges >

[PATCH v3 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-02-20 Thread Srinath Mannam
ranges = <0x8300 0x0 0x4200 0x0 0x4200 0 0x200>; I/O region address is 0x4200 Signed-off-by: Srinath Mannam Signed-off-by: Abhishek Shah Signed-off-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram Prakash --- drivers/pci/controller/pcie-

[PATCH v3 1/2] PCI: iproc: Add CRS check in config read

2019-02-20 Thread Srinath Mannam
using status flags before reissue config read. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui --- drivers/pci/controller/pcie-iproc.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller

[PATCH v3 0/2] Add IPROC PCIe new features

2019-02-20 Thread Srinath Mannam
, commit logs are expanded. Changes from v1: - Addressed Bjorn Helgaas comments. - Removed set order mode patch from patchset. Srinath Mannam (2): PCI: iproc: Add CRS check in config read PCI: iproc: Add outbound configuration for 32-bit I/O region drivers/pci/controller/pcie-iproc.c | 44

[PATCH v4 0/3] Stingray USB PHY driver support

2019-02-20 Thread Srinath Mannam
from v2: - Addressed Kishon review comments - Updated patchset to Linux-5.0-rc2 Changes from v1: - Addressed Kishon review comments - phy init call return value handle Srinath Mannam (3): dt-bindings: phy: Add Stingray USB PHY binding document phy: sr-usb: Add Stingray USB PHY driver

[PATCH v4 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-02-20 Thread Srinath Mannam
use SS-PHY in SS mode and HS-PHY in HS mode. xHCI0 port1 is SS-PHY0, port2 is HS-PHY0. xHCI1 port1 is SS-PHY1, port2 is HS-PHY2 and port3 is HS-PHY1. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../boot/dts/broadcom/stingray/stingray-usb.dtsi | 95

[PATCH v4 2/3] phy: sr-usb: Add Stingray USB PHY driver

2019-02-20 Thread Srinath Mannam
USB PHY driver supports two versions of stingray USB PHYs - Version 1 is a combo PHY contains one SS and one HS PHYs. - Version 2 is a single HS PHY. These two PHY versons support both Generic xHCI host controller driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam

[PATCH v4 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-20 Thread Srinath Mannam
Add DT binding document for Stingray USB PHY. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../bindings/phy/brcm,stingray-usb-phy.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

Re: [PATCH v3 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-18 Thread Srinath Mannam
Hi Rob, Thanks for review, please see my comments below inline. On Mon, Feb 18, 2019 at 10:52 PM Rob Herring wrote: > > On Wed, Feb 06, 2019 at 11:02:25PM +0530, Srinath Mannam wrote: > > Add DT binding document for Stingray USB PHY. > > > > Signed-off-by: Srin

Re: [PATCH v3 0/3] Stingray USB PHY driver support

2019-02-14 Thread Srinath Mannam
Hi Kishon, Could you please help to review and provide your comments to this patch series when you have time? Regards, Srinath. On Wed, Feb 6, 2019 at 11:03 PM Srinath Mannam wrote: > > These patches add Stingray USB PHY driver and its corresponding > DT nodes with docu

Re: [PATCH v6 0/3] Stingray thermal driver support

2019-02-14 Thread Srinath Mannam
> The following tag should be added to the binding document patch: > > > > Reviewed-by: Rob Herring > > > > Thanks, > > > > Ray > > > > On 1/3/2019 12:55 AM, Srinath Mannam wrote: > > > These patches adds the stingray thermal driver a

Re: [PATCH v2 2/2] PCI: iproc: Add PCIe 32bit outbound memory configuration

2019-02-12 Thread Srinath Mannam
Hi Lorenzo, Thanks for review, please see my comments below inline. On Wed, Feb 13, 2019 at 12:07 AM Lorenzo Pieralisi wrote: > > On Tue, Feb 05, 2019 at 10:27:01AM +0530, Srinath Mannam wrote: > > Add configuration to support IPROC PCIe host controller outbound memory > &

Re: [PATCH v2 1/2] PCI: iproc: Add CRS check in config read

2019-02-12 Thread Srinath Mannam
Hi Lorenzo, Thanks for review, please see my comments below inline. On Tue, Feb 12, 2019 at 11:42 PM Lorenzo Pieralisi wrote: > > On Tue, Feb 05, 2019 at 10:27:00AM +0530, Srinath Mannam wrote: > > In the current implementation, config read output data 0x0001 is > &

Re: [PATCH 2/2] drivers: xhci: Add quirk to reset xHCI port PHY

2019-02-08 Thread Srinath Mannam
Hi Mathias, Thanks for comments, Please find my comments below inline. On Fri, Feb 8, 2019 at 6:00 PM Mathias Nyman wrote: > > On 07.02.2019 17:17, Srinath Mannam wrote: > > Hi Mathias, > > > > Thanks for review, please see my comments below inline. > > >

Re: [PATCH 2/2] drivers: xhci: Add quirk to reset xHCI port PHY

2019-02-07 Thread Srinath Mannam
Hi Mathias, Thanks for review, please see my comments below inline. On Thu, Feb 7, 2019 at 8:32 PM Mathias Nyman wrote: > > On 05.02.2019 08:18, Srinath Mannam wrote: > > Add a quirk to reset xHCI port PHY on port disconnect event. > > Stingray USB HS PHY has an issue, t

[PATCH v3 2/3] phy: sr-usb: Add Stingray USB PHY driver

2019-02-06 Thread Srinath Mannam
USB PHY driver supports all versions of stingray SS and HS USB PHYs. - Version 1 is a combo PHY contains both SS and HS PHYs. - Version 2 is a single HS PHY. These PHYs support both Generic xHCI host controller driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam

[PATCH v3 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-06 Thread Srinath Mannam
Add DT binding document for Stingray USB PHY. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../bindings/phy/brcm,stingray-usb-phy.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

[PATCH v3 0/3] Stingray USB PHY driver support

2019-02-06 Thread Srinath Mannam
call return value handle Srinath Mannam (3): dt-bindings: phy: Add Stingray USB PHY binding document phy: sr-usb: Add Stingray USB PHY driver arm64: dts: Add USB DT nodes for Stingray SoC .../bindings/phy/brcm,stingray-usb-phy.txt | 62 .../boot/dts/broadcom/stingray/stingray

[PATCH v3 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-02-06 Thread Srinath Mannam
] | | | | --- --- | | | | | [SS-PHY0] [HS-PHY0][SS-PHY1] [HS-PHY2] [HS-PHY1] [SS-PHY0/HS-PHY0] and [SS-PHY1/HS-PHY1] are combo PHYs of version1 category has both SS and HS PHYs.. [HS-PHY2] is HS PHY of version2 category. Signed-off-by: Srinath Mannam Reviewed-by: Florian

[PATCH v3 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-02-06 Thread Srinath Mannam
] | | | | --- --- | | | | | [SS-PHY0] [HS-PHY0][SS-PHY1] [HS-PHY2] [HS-PHY1] [SS-PHY0/HS-PHY0] and [SS-PHY1/HS-PHY1] are combo PHYs of version1 category has both SS and HS PHYs.. [HS-PHY2] is HS PHY of version2 category. Signed-off-by: Srinath Mannam Reviewed-by: Florian

[PATCH v3 0/3] Stingray USB PHY driver support

2019-02-06 Thread Srinath Mannam
call return value handle Srinath Mannam (3): dt-bindings: phy: Add Stingray USB PHY binding document phy: sr-usb: Add Stingray USB PHY driver arm64: dts: Add USB DT nodes for Stingray SoC .../bindings/phy/brcm,stingray-usb-phy.txt | 62 .../boot/dts/broadcom/stingray/stingray

[PATCH v3 2/3] phy: sr-usb: Add Stingray USB PHY driver

2019-02-06 Thread Srinath Mannam
USB PHY driver supports all versions of stingray SS and HS USB PHYs. - Version 1 is a combo PHY contains both SS and HS PHYs. - Version 2 is a single HS PHY. These PHYs support both Generic xHCI host controller driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam

[PATCH v3 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-06 Thread Srinath Mannam
Add DT binding document for Stingray USB PHY. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../bindings/phy/brcm,stingray-usb-phy.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

[PATCH 2/2] drivers: xhci: Add quirk to reset xHCI port PHY

2019-02-04 Thread Srinath Mannam
Add a quirk to reset xHCI port PHY on port disconnect event. Stingray USB HS PHY has an issue, that USB High Speed device detected at Full Speed after the same port has connected to Full speed device. This problem can be resolved with that port PHY reset on disconnect. Signed-off-by: Srinath

[PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-04 Thread Srinath Mannam
Add usb-phy-port-reset optional property to set quirk in xhci platform driver which forces USB port PHY reset on port disconnect event. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 0/2] Reset xHCI port PHY on disconnect

2019-02-04 Thread Srinath Mannam
This patch set adds a quirk in xHCI driver to reset PHY of xHCI port on its disconnect event. This patch set is based on Linux-5.0-rc2. Srinath Mannam (2): dt-bindings: usb-xhci: Add usb-phy-port-reset property drivers: xhci: Add quirk to reset xHCI port PHY Documentation/devicetree

[PATCH v2 2/2] PCI: iproc: Add PCIe 32bit outbound memory configuration

2019-02-04 Thread Srinath Mannam
Add configuration to support IPROC PCIe host controller outbound memory window mapping with SOC address range inside 4GB boundary, which is 32 bit AXI address. Signed-off-by: Srinath Mannam Signed-off-by: Abhishek Shah Signed-off-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram

[PATCH v2 0/2] Add IPROC PCIe new features

2019-02-04 Thread Srinath Mannam
order mode patch from patchset. Srinath Mannam (2): PCI: iproc: Add CRS check in config read PCI: iproc: Add PCIe 32bit outbound memory configuration drivers/pci/controller/pcie-iproc.c | 44 + 1 file changed, 40 insertions(+), 4 deletions(-) -- 2.7.4

[PATCH v2 1/2] PCI: iproc: Add CRS check in config read

2019-02-04 Thread Srinath Mannam
using status flags before reissue config read. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui --- drivers/pci/controller/pcie-iproc.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller

[PATCH v2 0/2] Add IPROC PCIe new features

2019-02-04 Thread Srinath Mannam
set order mode patch from patchset. Srinath Mannam (2): PCI: iproc: Add CRS state check in config read PCI: iproc: Add PCIe 32bit outbound memory configuration drivers/pci/controller/pcie-iproc.c | 44 + 1 file changed, 40 insertions(+), 4 deletions

[PATCH v3 2/3] iommu/dma: Reserve IOVA for PCI host reserve address list

2019-01-25 Thread Srinath Mannam
. Signed-off-by: Srinath Mannam Based-on-patch-by: Oza Pawandeep Reviewed-by: Oza Pawandeep --- drivers/iommu/dma-iommu.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index d19f3d6..81b591b 100644 --- a/drivers/iommu/dma-iommu.c

[PATCH v3 0/3] PCIe Host request to reserve IOVA

2019-01-25 Thread Srinath Mannam
Changes from v1: - Addressed Oza review comments. Srinath Mannam (3): PCI: Add dma-resv window list iommu/dma: Reserve IOVA for PCI host reserve address list PCI: iproc: Add dma reserve resources to host drivers/iommu/dma-iommu.c | 8 ++ drivers/pci/controller/pcie-iproc.c

[PATCH v3 1/3] PCI: Add dma-resv window list

2019-01-25 Thread Srinath Mannam
ranges will be add to this list to avoid IOMMU mapping. While initializing IOMMU domain of PCI EPs connected to that host bridge IOVAs for this given list of address ranges will be reserved. Signed-off-by: Srinath Mannam Based-on-patch-by: Oza Pawandeep Reviewed-by: Oza Pawandeep --- drivers

[PATCH v3 3/3] PCI: iproc: Add dma reserve resources to host

2019-01-25 Thread Srinath Mannam
00, 0x1 - 0x8, 0x10 - 0x80 and 0x100 - 0x. are not allowed to use as inbound addresses. So that we need to add these address ranges to dma_resv list to reserve corresponding IOVA address ranges. Signed-off-by: Srinath Mannam Based-on

Re: [PATCH 1/3] PCI: iproc: Add feature to set order mode

2019-01-25 Thread Srinath Mannam
Hi Bjorn, Thank you, Please see my comments below inline. On Fri, Jan 25, 2019 at 1:01 AM Bjorn Helgaas wrote: > > On Thu, Jan 24, 2019 at 02:10:18PM +0530, Srinath Mannam wrote: > > On Fri, Jan 18, 2019 at 8:37 PM Bjorn Helgaas wrote: > > > On Fri, Jan 18, 2019 at 09:5

  1   2   3   4   >