Re: [GIT PULL] clk: imx: Updates for v5.13

2021-04-09 Thread Stephen Boyd
Quoting Abel Vesa (2021-04-08 01:12:21) > On 21-04-08 00:06:29, Stephen Boyd wrote: > > Quoting Abel Vesa (2021-04-04 13:40:24) > > > The following changes since commit > > > a38fd8748464831584a19438cbb3082b5a2dab15: > > > > > >

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-08 Thread Stephen Boyd
Quoting Stephan Gerhold (2021-04-08 00:19:44) > Personally, I think it would be best to introduce a new, SMC64 only > compatible (e.g. "qcom,scm-64" like I mentioned). Then you can skip the > detection check for the boards that opt-in by adding the compatible. > You can then use it on all newer

Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-04-08 Thread Stephen Boyd
Quoting Stephen Boyd (2021-04-08 12:52:27) > > Can you try this patch for x86? I'll dig up some hardware in the meantime. > It works for me backported to this 5.10 kernel running on this x86 device I found. I'll wait for you to confirm and then send the next round. CPU: 0 PID: 2719 C

Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

2021-04-08 Thread Stephen Boyd
Quoting Chen Hui (2021-04-08 06:55:09) > Add missing MODULE_DEVICE_TABLE entries to support module autoloading, > as these drivers can be compiled as external modules. > > Signed-off-by: Chen Hui Any fixes tag?

Re: [PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify

2021-04-08 Thread Stephen Boyd
Quoting Baoquan He (2021-04-08 03:17:43) > On 04/07/21 at 07:03pm, Petr Mladek wrote: > > On Tue 2021-03-30 20:05:20, Stephen Boyd wrote: > > > We can use the vmlinux_build_id array here now instead of open coding > > > it. This mostly consolidates code. > >

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-04-08 07:05:54) > On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote: > > +++ Stephen Boyd [30/03/21 20:05 -0700]: > > ... > > > > +static void init_build_id(struct module *mod, const struct load_info > > > *info) >

Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-04-08 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-08 03:13:20) > It helped with the vmlinux buildid. I see the following: > > [ 551.435942][ T1803] test_printf: loaded. > [ 551.436667][ T1803] [ cut here ] > [ 551.437561][ T1803] kernel BUG at lib/test_printf.c:689! > [ 551.438352][ T1803]

Re: [PATCH v3 02/12] buildid: Stash away kernels build ID on init

2021-04-08 Thread Stephen Boyd
Quoting Jessica Yu (2021-04-08 05:05:33) > +++ Stephen Boyd [30/03/21 20:05 -0700]: > >+/** > >+ * init_vmlinux_build_id - Get the running kernel's build ID > >+ * > >+ * Return: Running kernel's build ID > >+ */ > > Hm, init_vmlinux_build_id() d

Re: [PATCH] clk: imx: reference preceded by free

2021-04-08 Thread Stephen Boyd
Quoting Jian Dong (2021-04-07 18:53:12) > On Tue, 30 Mar 2021 19:16:48 -0700 > Stephen Boyd wrote: > > > Quoting Jian Dong (2021-03-22 20:10:34) > > > From: Jian Dong > > > > > > when register failed, clk will be freed, it will generate danglin

Re: [PATCH v1 4/6] clk: qcom: Add graphics clock controller driver for SC7280

2021-04-08 Thread Stephen Boyd
Quoting Taniya Das (2021-03-16 18:22:20) > +static struct clk_regmap_div gpu_cc_hub_ahb_div_clk_src = { > + .reg = 0x11c0, > + .shift = 0, > + .width = 4, > + .clkr.hw.init = &(struct clk_init_data) { > + .name = "gpu_cc_hub_ahb_div_clk_src", > +

Re: [GIT PULL] clk: imx: Updates for v5.13

2021-04-08 Thread Stephen Boyd
Quoting Abel Vesa (2021-04-04 13:40:24) > The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: > > Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/abelvesa/linux.git clk/imx > >

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 08:03:47) > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for

Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-04-08 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 07:03:19) > # readelf -Wn vmlinux-5.12.0-rc6-default+ > > Displaying notes found in: .notes > Owner Data size Description > Xen 0x0006 Unknown note type: (0x0006) > description data: 6c 69 6e 75 78 00 >

Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-04-07 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 06:42:38) > > I think that you need to use something like: > > #ifdef CONFIG_STACKTRACE_BUILD_ID > #define BUILD_ID_FTM " %20phN" > #define BUILD_ID_VAL vmlinux_build_id > #else > #define BUILD_ID_FTM "%s" > #define BUILD_ID_VAL "" > #endif > >

Re: [PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify

2021-04-07 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 10:03:28) > On Tue 2021-03-30 20:05:20, Stephen Boyd wrote: > > We can use the vmlinux_build_id array here now instead of open coding > > it. This mostly consolidates code. > > > > Cc: Jiri Olsa > > Cc: Alexei Starovoitov >

Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-04-07 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 07:03:19) > On Tue 2021-03-30 20:05:11, Stephen Boyd wrote: > > Add the running kernel's build ID[1] to the stacktrace information > > header. This makes it simpler for developers to locate the vmlinux with > > full debuginfo for a particu

Re: [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-04-07 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-04-06 08:40:15) > From: Quanyang Wang > > The round_rate callback should only perform rate calculation and not > involve calling zynqmp_pll_set_mode to change the pll mode. So let's > move zynqmp_pll_set_mode out of round_rate and to set_rate callback. >

Re: [V3][PATCH] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-04-07 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-04-06 08:31:31) > From: Quanyang Wang > > If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, > we shouldn't skip invoking PM_CLOCK_ENABLE fn even though this > pll has been enabled. In ATF implementation, it will only assign > the mode to

Re: [PATCH mvebu v3 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz

2021-04-07 Thread Stephen Boyd
Quoting Pali Rohár (2021-03-28 04:31:02) > On Friday 12 March 2021 10:12:06 Gregory CLEMENT wrote: > > Hello Pali, > > > > > Hello Gregory! > > > > > > Patches are the for almost two months and more people have tested them. > > > They are marked with Fixed/CC-stable tags, they should go also into

Re: [PATCH] clk: fix for_each_child.cocci warnings

2021-04-07 Thread Stephen Boyd
Quoting Julia Lawall (2021-04-07 12:02:32) > From: kernel test robot > > For_each_child_of_node should have of_node_put() before goto. > > Generated by: scripts/coccinelle/iterators/for_each_child.cocci > > CC: Liam Beguin > Reported-by: kernel test robot > Signed-off-by: kernel test robot

Re: [PATCH v1 0/2] Add sync_state() support to clock framework

2021-04-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-04-06 20:44:53) > Stephen, > > We can decide later if both these patches land through clk tree or the > driver-core tree. The meat of the series is in Patch 2/2 and that commit > text gives all the details. The majority of the diff is in drivers/clk so presumably it

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-07 Thread Stephen Boyd
Quoting Stephan Gerhold (2021-04-05 05:50:26) > On Fri, Apr 02, 2021 at 10:21:58AM -0700, Stephen Boyd wrote: > > > > Ah right, the whole secure world running in 32-bit mode thing. Is > > msm8916 the only SoC that's using that? Or are there more? If only > > msm8916 is

Re: [PATCH][next] clk: socfpga: remove redundant initialization of variable div

2021-04-07 Thread Stephen Boyd
Quoting Colin King (2021-04-06 11:27:46) > From: Colin Ian King > > The variable div is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH] clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return

2021-04-07 Thread Stephen Boyd
Quoting Colin King (2021-04-06 10:01:15) > From: Colin Ian King > > There is an error return path that is not kfree'ing socfpga_clk leading > to a memory leak. Fix this by adding in the missing kfree call. > > Addresses-Coverity: ("Resource leak") > Signed-off-by: Colin Ian King > --- Applied

Re: [PATCH v3] media: venus : hfi: add venus image info into smem

2021-04-07 Thread Stephen Boyd
Quoting Dikshita Agarwal (2021-04-06 22:47:17) > Fill fw version info into smem to be printed as part of > soc info. > > Signed-off-by: Dikshita Agarwal > > changes since v2: > - adressed all review comments. > --- Please address the krobot errors. Looks like we need a 'depends on QCOM_SMEM'

Re: [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread Stephen Boyd
Quoting Bernard Zhao (2021-04-07 06:06:21) > This patch fix coccicheck warning: > drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return > "0" on line 880 > Also remove unneeded function return value check. > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephen Boyd
Quoting Stephan Gerhold (2021-04-02 03:18:04) > On Thu, Apr 01, 2021 at 11:58:48PM -0700, Stephen Boyd wrote: > > Quoting Elliot Berman (2021-04-01 18:12:14) > > > > > > It might be a good idea to wrap these lines from qcom_scm_call with #if > > > IS_ENABLE

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephen Boyd
Quoting Elliot Berman (2021-04-01 18:12:14) > > It might be a good idea to wrap these lines from qcom_scm_call with #if > IS_ENABLED(CONFIG_ARM), and the corresponding ones in qcom_scm_call_atomic: > >case SMC_CONVENTION_LEGACY: >return scm_legacy_call(dev, desc, res); > > If

Re: [PATCH V2 3/5] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver

2021-04-01 Thread Stephen Boyd
Quoting schow...@codeaurora.org (2021-04-01 08:42:50) > On 2021-03-30 01:39, Stephen Boyd wrote: > > Quoting Souradeep Chowdhury (2021-03-25 01:02:34) > >> The DCC is a DMA engine designed to store register values either in > >> case of a system crash or in case of soft

Re: [PATCH V2 2/5] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)

2021-04-01 Thread Stephen Boyd
Quoting schow...@codeaurora.org (2021-04-01 07:04:07) > On 2021-03-30 01:35, Stephen Boyd wrote: > > Quoting Souradeep Chowdhury (2021-03-25 01:02:33) > >> diff --git a/drivers/soc/qcom/dcc.c b/drivers/soc/qcom/dcc.c > >> new file mode 100644 > >> index

Re: [PATCH 8/9] clk: qcom: gcc-msm8994: Add proper msm8992 support

2021-04-01 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-03-12 18:19:17) > diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c > index fae784b4242f..a5b9db7678d1 100644 > --- a/drivers/clk/qcom/gcc-msm8994.c > +++ b/drivers/clk/qcom/gcc-msm8994.c > @@ -2718,13 +2742,57 @@ static const struct

Re: [PATCH 1/9] dt-bindings: clk: qcom: Add bindings for MSM8994 GCC driver

2021-04-01 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-03-12 18:19:10) > Add documentation for the MSM8994 GCC driver. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/clock/qcom,gcc-msm8994.yaml | 72 +++ > 1 file changed, 72 insertions(+) > create mode 100644 >

Re: [PATCH 9/9] clk: qcom: gcc-msm8994: Add a quirk for a different SDCC configuration

2021-04-01 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-03-24 10:12:34) > > On 24.03.2021 18:11, Rob Herring wrote: > > On Sat, Mar 13, 2021 at 03:19:18AM +0100, Konrad Dybcio wrote: > >> Some devices come with a different SDCC clock configuration, > >> account for that. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >>

Re: [PATCH 2/2] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

2021-03-31 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-02-25 12:18:43) > diff --git a/drivers/clk/qcom/gcc-msm8976.c b/drivers/clk/qcom/gcc-msm8976.c > new file mode 100644 > index ..5478612cd1b3 > --- /dev/null > +++ b/drivers/clk/qcom/gcc-msm8976.c > @@ -0,0 +1,4181 @@ > +// SPDX-License-Identifier: GPL-2.0 >

Re: [PATCH 5/6] clk: qcom: gcc-sdm660: Account for needed adjustments in probe function

2021-03-31 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-02-25 11:09:14) > Hi and sorry for the late reply, > I'm sorry too. This fell off my review queue for some time. > > >> + > >> + /* Keep bimc gfx clock port on all the time */ > >> + clk_prepare_enable(gcc_bimc_gfx_clk.clkr.hw.clk); > >> + > > Preferably

Re: [V2] [PATCH] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-03-31 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-03-30 05:17:01) > From: Quanyang Wang > > If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, > we shouldn't skip invoking PM_CLOCK_ENABLE fn even though this > pll has been enabled. In ATF implementation, it will only assign > the mode to

Re: [PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-03-31 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-03-31 02:00:18) > From: Quanyang Wang > > The round_rate callback should only perform rate calculation and not > involve calling zynqmp_pll_set_mode to change the pll mode. So let's > move zynqmp_pll_set_mode out of round_rate and to set_rate callback. >

Re: [PATCH v3 0/4] clk: ti: add am33xx spread spectrum clock support

2021-03-31 Thread Stephen Boyd
Quoting Tony Lindgren (2021-03-30 22:51:04) > * Stephen Boyd [210330 02:25]: > > Quoting Dario Binacchi (2021-03-29 09:42:17) > > > > > > As reported by the TI spruh73x RM, MPU and LCD modules support spread > > > spectrum clocking (SSC) on their

Re: [PATCH v3 2/6] clk: sifive: Use reset-simple in prci driver for PCIe driver

2021-03-31 Thread Stephen Boyd
f-by: Greentime Hu > --- Acked-by: Stephen Boyd

Re: [PATCH v3 1/6] clk: sifive: Add pcie_aux clock in prci driver for PCIe driver

2021-03-31 Thread Stephen Boyd
Quoting Greentime Hu (2021-03-31 02:26:00) > We add pcie_aux clock in this patch so that pcie driver can use > clk_prepare_enable() and clk_disable_unprepare() to enable and disable > pcie_aux clock. > > Signed-off-by: Greentime Hu > --- With robot fix Acked-by: Stephen Boyd

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-31 Thread Stephen Boyd
Quoting Stephen Boyd (2021-03-23 15:43:36) > These scm calls are never used outside of legacy ARMv7 based platforms. > That's because PSCI, mandated on arm64, implements them for modern SoCs > via the PSCI spec. Let's move them to the legacy file and only compile > the legacy file int

[PATCH v3 10/12] buildid: Mark some arguments const

2021-03-30 Thread Stephen Boyd
These arguments are never modified so they can be marked const to indicate as such. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- lib/buildid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path

2021-03-30 Thread Stephen Boyd
indicate the variable argument and that it is optional so that we can differentiate from the literal "auto" that should be passed. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Konstantin Khlebnikov Cc: Sasha Levin Signed-off-by: Stephen Boyd --- scr

[PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify

2021-03-30 Thread Stephen Boyd
We can use the vmlinux_build_id array here now instead of open coding it. This mostly consolidates code. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Dave Young Cc: Baoquan He Cc: Vivek Goyal Cc: Signed-off-by: Stephen Boyd --- include/linux

[PATCH v3 11/12] buildid: Fix kernel-doc notation

2021-03-30 Thread Stephen Boyd
Kernel doc should use "Return:" instead of "Returns" to properly reflect the return values. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- lib/buildid.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v3 06/12] x86/dumpstack: Use %pSb for backtrace printing

2021-03-30 Thread Stephen Boyd
/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/x86/kernel/dumpstack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 299c20f0a38b..7ad5eea99b2b 100644 --- a/arch/x86/kernel/dumpstack.c +++ b

[PATCH v3 07/12] scripts/decode_stacktrace.sh: Support debuginfod

2021-03-30 Thread Stephen Boyd
Cc: Andy Shevchenko Cc: Matthew Wilcox Signed-off-by: Stephen Boyd --- scripts/decode_stacktrace.sh | 81 +++- 1 file changed, 70 insertions(+), 11 deletions(-) diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh index 90398347e366

[PATCH v3 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm

2021-03-30 Thread Stephen Boyd
: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Konstantin Khlebnikov Cc: Sasha Levin Signed-off-by: Stephen Boyd --- scripts/decode_stacktrace.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/decode_stacktrace.sh b/scripts

[PATCH v3 05/12] arm64: stacktrace: Use %pSb for backtrace printing

2021-03-30 Thread Stephen Boyd
[2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64

[PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-03-30 Thread Stephen Boyd
/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- lib/Kconfig.debug | 11 +++ lib/dump_stack.c | 12 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 2779c29d9981..5f883e50f406 100644 --- a/lib/Kconfig.debug

[PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Stephen Boyd
Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- Documentation/core-api/printk-formats.rst | 9 +++ include/linux/kallsyms.h | 13 +++- include/linux/module.h

[PATCH v3 02/12] buildid: Stash away kernels build ID on init

2021-03-30 Thread Stephen Boyd
Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Dave Young Cc: Baoquan He Cc: Vivek Goyal Cc: Signed-off-by: Stephen Boyd --- include/linux/buildid.h | 3 +++ init/main.c | 1 + lib/buildid.c | 17 + 3 files changed, 21

[PATCH v3 00/12] Add build ID to stacktraces

2021-03-30 Thread Stephen Boyd
: Cc: Matthew Wilcox Cc: Petr Mladek Cc: Rasmus Villemoes Cc: Sasha Levin Cc: Sergey Senozhatsky Cc: Steven Rostedt Cc: Thomas Gleixner Cc: Vivek Goyal Cc: Will Deacon Cc: Cc: Christoph Hellwig Cc: peter enderborg Stephen Boyd (12): buildid: Add API to parse build ID out of buffer

[PATCH v3 01/12] buildid: Add API to parse build ID out of buffer

2021-03-30 Thread Stephen Boyd
Add an API that can parse the build ID out of a buffer, instead of a vma, to support printing a kernel module's build ID for stack traces. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- include/linux/buildid.h | 1 + lib

Re: [PATCH] clk: socfpga: Fix code formatting

2021-03-30 Thread Stephen Boyd
Quoting Stephen Boyd (2021-03-30 19:31:19) > This function's parameters are oddly formatted. Looks like a newline was > missed or something. Fix it. > > Cc: Dinh Nguyen > Signed-off-by: Stephen Boyd > --- Applied to clk-next

Re: [PATCH 3/3] clk: socfpga: Convert to s10/agilex/n5x to use clk_hw

2021-03-30 Thread Stephen Boyd
Quoting Dinh Nguyen (2021-03-02 13:41:51) > As recommended by Stephen Boyd, convert the Agilex/Stratix10/n5x clock > driver to use the clk_hw registration method. > > Suggested-by: Stephen Boyd > Signed-off-by: Dinh Nguyen > --- Applied to clk-next

Re: [PATCH 2/3] clk: socfpga: arria10: convert to use clk_hw

2021-03-30 Thread Stephen Boyd
Quoting Dinh Nguyen (2021-03-02 13:41:50) > As recommended by Stephen Boyd, convert the Arria10 clock driver to use > the clk_hw registration method. > > Suggested-by: Stephen Boyd > Signed-off-by: Dinh Nguyen > --- Applied to clk-next

Re: [PATCH 1/3] clk: socfpga: use clk_hw_register for a5/c5

2021-03-30 Thread Stephen Boyd
Quoting Dinh Nguyen (2021-03-02 13:41:49) > As recommended by Stephen Boyd, convert the cyclone5/arria5 clock driver > to use the clk_hw registration method. > > Suggested-by: Stephen Boyd > Signed-off-by: Dinh Nguyen > --- Applied to clk-next

[PATCH] clk: socfpga: Fix code formatting

2021-03-30 Thread Stephen Boyd
This function's parameters are oddly formatted. Looks like a newline was missed or something. Fix it. Cc: Dinh Nguyen Signed-off-by: Stephen Boyd --- drivers/clk/socfpga/clk-agilex.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/socfpga/clk-agilex.c b

Re: [PATCH] clk: imx8mq: Correct the pcie1 sels

2021-03-30 Thread Stephen Boyd
Quoting Richard Zhu (2021-03-15 01:17:48) > - The sys2_pll_50m should be one of the clock sels of PCIE_AUX clock. > Change the sys2_pll_500m to sys2_pll_50m. > - Correct one mis-spell of the imx8mq_pcie1_ctrl_sels definition, from > "sys2_pll_250m" to "sys2_pll_333m". > > Signed-off-by: Richard

Re: [PATCH] clk: imx8mp: Remove the none exist pcie clocks

2021-03-30 Thread Stephen Boyd
Quoting Richard Zhu (2021-03-15 01:17:47) > In the i.MX8MP PCIe design, the PCIe PHY REF clock comes from external > OSC or internal system PLL. It is configured in the IOMUX_GPR14 register > directly, and can't be contolled by CCM at all. > Remove the PCIE PHY clock from clock driver to clean up

Re: [PATCH] clk: imx: reference preceded by free

2021-03-30 Thread Stephen Boyd
Quoting Jian Dong (2021-03-22 20:10:34) > From: Jian Dong > > when register failed, clk will be freed, it will generate dangling pointer > problem in later reference. it should return directly. > > Signed-off-by: Jian Dong > --- Any Fixes tag?

Re: [PATCH v1] of: property: fw_devlink: Add support for remote-endpoint

2021-03-30 Thread Stephen Boyd
il.com/#t > Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by > default""") > Reported-by: Stephen Boyd > Signed-off-by: Saravana Kannan > --- Tested-by: Stephen Boyd > diff --git a/drivers/of/property.c b/drivers/of/property.c

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Stephen Boyd
Quoting Petr Mladek (2021-03-30 03:29:24) > On Tue 2021-03-23 19:04:35, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > > > Example: > >

Re: [PATCH] arm64: dts: qcom: Move rmtfs memory region

2021-03-30 Thread Stephen Boyd
> --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 0/4] clk: ti: add am33xx spread spectrum clock support

2021-03-29 Thread Stephen Boyd
Quoting Dario Binacchi (2021-03-29 09:42:17) > > As reported by the TI spruh73x RM, MPU and LCD modules support spread > spectrum clocking (SSC) on their output clocks. SSC is used to spread > the spectral peaking of the clock to reduce any electromagnetic > interference (EMI) that may be caused

Re: [PATCH v3 1/4] clk: ti: fix typo in routine description

2021-03-29 Thread Stephen Boyd
Quoting Dario Binacchi (2021-03-29 09:42:18) > Replace _omap3_noncore_dpll_program with omap3_noncore_dpll_program. > > Signed-off-by: Dario Binacchi > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/4] clk: ti: fix typo in routine description

2021-03-29 Thread Stephen Boyd
Quoting Dario Binacchi (2021-03-18 10:26:23) > Replace _omap3_noncore_dpll_program with omap3_noncore_dpll_program. > > Signed-off-by: Dario Binacchi > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 00/16] clk: st: embed clock outputs within drivers

2021-03-29 Thread Stephen Boyd
Quoting Alain Volmat (2021-03-25 00:50:02) > Most of ST clock drivers used by STi platform are updated in > order to introduce clock outputs informations within each drivers > and thus allow to avoid having to rely on clock-output-names properties > within DT clock nodes. > For that purpose,

Re: [PATCH v2] clk: qcom: camcc: Update the clock ops for the SC7180

2021-03-29 Thread Stephen Boyd
Quoting Taniya Das (2021-03-26 18:41:05) > Some of the RCGs could be always ON from the XO source and could be used > as the clock on signal for the GDSC to be operational. In the cases where > the GDSCs are parked at different source with the source clock disabled, > it could lead to the GDSC to

Re: [PATCH V2 3/5] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver

2021-03-29 Thread Stephen Boyd
Quoting Souradeep Chowdhury (2021-03-25 01:02:34) > The DCC is a DMA engine designed to store register values either in > case of a system crash or in case of software triggers manually done > by the user.Using DCC hardware and the sysfs interface of the driver > the user can exploit various

Re: [PATCH V2 2/5] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)

2021-03-29 Thread Stephen Boyd
Quoting Souradeep Chowdhury (2021-03-25 01:02:33) > The DCC is a DMA Engine designed to capture and store data > during system crash or software triggers.The DCC operates > based on user inputs via the sysfs interface.The user gives > addresses as inputs and these addresses are stored in the >

Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC

2021-03-29 Thread Stephen Boyd
Quoting Souradeep Chowdhury (2021-03-25 01:02:32) > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 000..c6e0a9c > --- /dev/null > +++

Re: [PATCH v2 2/6] clk: sifive: Use reset-simple in prci driver for PCIe driver

2021-03-29 Thread Stephen Boyd
Quoting Greentime Hu (2021-03-17 23:08:09) > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 71ab75a46491..f094df93d911 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -173,7 +173,7 @@ config RESET_SCMI > > config RESET_SIMPLE > bool "Simple

Re: [PATCH v2 0/6] Add SiFive FU740 PCIe host controller driver support

2021-03-29 Thread Stephen Boyd
Quoting Greentime Hu (2021-03-17 23:08:07) > This patchset includes SiFive FU740 PCIe host controller driver. We also > add pcie_aux clock and pcie_power_on_reset controller to prci driver for > PCIe driver to use it. > > This is tested with e1000e: Intel(R) PRO/1000 Network Card, AMD Radeon R5 >

Re: [PATCH v2] clk: socfpga: fix iomem pointer cast on 64-bit

2021-03-29 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2021-03-14 04:07:09) > Pointers should be cast with uintptr_t instead of integer. This fixes > warning when compile testing on ARM64: > > drivers/clk/socfpga/clk-gate.c: In function ‘socfpga_clk_recalc_rate’: > drivers/clk/socfpga/clk-gate.c:102:7: warning: cast

Re: [PATCH v4 1/7] dt-bindings: phy: qcom,qmp-usb3-dp-phy: move usb3 compatibles back to qcom,qmp-phy.yaml

2021-03-27 Thread Stephen Boyd
-dp-phy.yaml to describe only real "combo" USB3+DP device nodes. > > Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy > information") > Cc: Stephen Boyd > Cc: Sandeep Maheswaram > Signed-off-by: Dmitry Baryshkov > --- > Documenta

Re: [PATCH 2/5] clk: qcom: gcc: Add support for Global Clock controller found on MSM8226

2021-03-26 Thread Stephen Boyd
Quoting Bartosz Dudziak (2021-03-26 07:58:13) > Modify existing MSM8974 driver to support MSM8226 SoC. Override frequencies > which are different in this older chip. Register all the clocks to the > framework for the clients to be able to request for them. Alphabet sort includes? Preferably do

Re: [PATCH 3/5] arm: dts: qcom: Add support for MSM8226 SoC

2021-03-26 Thread Stephen Boyd
Quoting Bartosz Dudziak (2021-03-26 07:58:14) > This patch adds basic device tree support for MSM8226 SoC which belongs git grep "This patch" -- Documentation/process/submitting-patches.rst > to the Snapdragon 400 family. For now, this file adds the basic nodes > like gcc, pinctrl and other

Re: [PATCH v8 18/38] clk: scmi: port driver to the new scmi_clk_proto_ops interface

2021-03-26 Thread Stephen Boyd
Quoting Cristian Marussi (2021-03-26 06:28:44) > Port driver to the new SCMI Clock interface based on protocol handles > and common devm_get_ops(). > > Cc: Michael Turquette > Cc: Stephen Boyd > Signed-off-by: Cristian Marussi > --- Acked-by: Stephen Boyd Reviewed-by: Stephen Boyd

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

2021-03-26 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24) > On Thu, 2021-03-25 at 14:31 +0100, Marek Szyprowski wrote: > > Hi > > > > On 10.02.2021 12:44, Tudor Ambarus wrote: > > > This is a follow-up for: > > > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is > > >

Re: [PATCH] clk: bcm: rpi: Don't register as OF provider if !dev->np

2021-03-26 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2021-03-25 11:57:48) > There are two ways clk-raspberrypi might be registered: through > device-tree or through an explicit platform device registration. The > latter happens after firmware/raspberrypi's probe, and it's limited to > RPi3s, which solely use the ARM

Re: [PATCH v7 18/38] clk: scmi: port driver to the new scmi_clk_proto_ops interface

2021-03-25 Thread Stephen Boyd
Sorry didn't notice because linux-...@vger.kernel.org wasn't Cced Quoting Cristian Marussi (2021-03-16 05:48:43) > Port driver to the new SCMI Clock interface based on protocol handles > and common devm_get_ops(). > > Cc: Michael Turquette > Cc: Stephen Boyd > Signed-off-by

Re: [PATCH v2 00/12] Add build ID to stacktraces

2021-03-25 Thread Stephen Boyd
Quoting peter enderborg (2021-03-25 04:06:17) > On 3/24/21 9:55 AM, Christoph Hellwig wrote: > > On Tue, Mar 23, 2021 at 07:04:31PM -0700, Stephen Boyd wrote: > >> x5 : x4 : 0001 > >> x3 : 0008 x2 : ff93fef25a70 >

Re: [PATCH v2 00/12] Add build ID to stacktraces

2021-03-25 Thread Stephen Boyd
Quoting peter enderborg (2021-03-25 04:14:31) > > el0_sync_compat_handler+0xa8/0xcc > > el0_sync_compat+0x178/0x180 > > ---[ end trace 3d95032303e59e68 ]--- > > How will this work with the ftrace? > It won't affect ftrace, if that's the question you're asking.

[PATCH] drm/msm: Set drvdata to NULL when msm_drm_init() fails

2021-03-25 Thread Stephen Boyd
er") Cc: Dmitry Baryshkov Cc: Fabio Estevam Cc: Krishna Manikandan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index a5c6b8c23336..196907689c82 100644 --- a/drivers/g

[PATCH v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

2021-03-24 Thread Stephen Boyd
. Cc: Laurent Pinchart Cc: Douglas Anderson Cc: Steev Klimaszewski Fixes: 956e9c85f47b ("arm64: dts: qcom: c630: Define eDP bridge and panel") Signed-off-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 15:21:34) > On 24/03/2021 20.11, Stephen Boyd wrote: > > Quoting Rasmus Villemoes (2021-03-24 02:57:13) > > >> > >> Is there any reason you didn't just make b an optional flag that could > >> be specified with or w

Re: [PATCH v2 07/12] scripts/decode_stacktrace.sh: Support debuginfod

2021-03-24 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-03-24 04:27:53) > On Tue, Mar 23, 2021 at 07:04:38PM -0700, Stephen Boyd wrote: > > Now that stacktraces contain the build ID information we can update this > > script to use debuginfod-find to locate the debuginfo for the vmlinux > > and

[PATCH] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

2021-03-24 Thread Stephen Boyd
. Cc: Laurent Pinchart Cc: Douglas Anderson Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt") Signed-off-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm6

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 02:57:13) > On 24/03/2021 03.04, Stephen Boyd wrote: > > > @@ -2778,6 +2793,10 @@ static inline void layout_symtab(struct module *mod, > > struct load_info *info) > > static void add_kallsyms(struct module *mod, cons

Re: [PATCH v2 02/12] buildid: Add method to get running kernel's build ID

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 02:24:27) > On 24/03/2021 03.04, Stephen Boyd wrote: > > Add vmlinux_build_id() so that callers can print a hex format string > > representation of the running kernel's build ID. This will be used in > > the kdump and dump_stack code s

Re: [PATCH v2 00/12] Add build ID to stacktraces

2021-03-24 Thread Stephen Boyd
HTML mail? Quoting Konstantin Khlebnikov (2021-03-24 01:23:55) > 24.03.2021, 05:04, "Stephen Boyd" : >   > Looks too noisy for me. Maybe print id in the line "Modules linked in:"? > I suppose only out-of-tree modules need this? >   Please see this

Re: [PATCH v2 03/12] dump_stack: Add vmlinux build ID to stack traces

2021-03-24 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-03-24 04:22:58) > On Tue, Mar 23, 2021 at 07:04:34PM -0700, Stephen Boyd wrote: > > Add the running kernel's build ID[1] to the stacktrace information > > header. This makes it simpler for developers to locate the vmlinux with > > full debug

[GIT PULL] clk fixes for v5.12-rc4

2021-03-24 Thread Stephen Boyd
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git tags/clk-fixes-for-linus for you to fetch changes up to

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

2021-03-24 Thread Stephen Boyd
Quoting Stephen Boyd (2021-03-24 08:57:33) > Quoting sbh...@codeaurora.org (2021-03-24 08:23:55) > > On 2021-03-23 12:31, Stephen Boyd wrote: > > > Quoting Shaik Sajida Bhanu (2021-03-20 11:17:00) > > >> + > > >> + bus-width = <8&g

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

2021-03-24 Thread Stephen Boyd
Quoting sbh...@codeaurora.org (2021-03-24 08:23:55) > On 2021-03-23 12:31, Stephen Boyd wrote: > > Quoting Shaik Sajida Bhanu (2021-03-20 11:17:00) > >> + > >> + bus-width = <8>; > >> + non-removable;

Re: [PATCH] arm64: dts: qcom: trogdor: Add no-hpd to DSI bridge node

2021-03-24 Thread Stephen Boyd
Quoting Doug Anderson (2021-03-24 08:32:00) > NOTE: if you were feeling charitable you might consider sending a > patch for "sdm850-lenovo-yoga-c630.dts" as well. I don't personally > know if HPD is hooked up on that system, but presumably even if it is > it's just as useless as it is on other

Re: [PATCH] media: venus : hfi: add venus image info into smem

2021-03-24 Thread Stephen Boyd
Quoting Dikshita Agarwal (2021-03-23 22:40:57) > fill fw version info into smem to be printed as part of s/fill/Fill/ > soc info. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/venus/hfi_msgs.c | 36 > ++-- > 1 file changed, 34 insertions(+),

Re: [PATCH v1] usb: dwc3: core: Add shutdown callback for dwc3

2021-03-23 Thread Stephen Boyd
Quoting Sandeep Maheswaram (2021-03-23 12:27:32) > This patch adds a shutdown callback to USB DWC core driver to ensure that > it is properly shutdown in reboot/shutdown path. This is required > where SMMU address translation is enabled like on SC7180 > SoC and few others. If the hardware is still

<    1   2   3   4   5   6   7   8   9   10   >