Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

2021-01-20 Thread Tony Lindgren
* Emmanuel Vadot [210120 08:01]: > On Tue, 19 Jan 2021 21:03:44 -0800 > Drew Fustini wrote: > > > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins ... > Reviewed-by: Emmanuel Vadot > > Thanks, now the docs make more sense :) Looks good to me

Re: [PATCHv2] drivers: bus: simple-pm-bus: Fix compatibility with simple-bus for auxdata

2021-01-19 Thread Tony Lindgren
* Rob Herring [210119 14:51]: > On Mon, Jan 18, 2021 at 2:41 AM Tony Lindgren wrote: > > - PRM power managment interrupts that also pinctrl driver uses > > I haven't looked at it, but can't one driver go find the other node > and the interrupts it needs? There's nothing w

Re: [PATCHv2] drivers: bus: simple-pm-bus: Fix compatibility with simple-bus for auxdata

2021-01-18 Thread Tony Lindgren
* Arnd Bergmann [210118 08:30]: > On Mon, Jan 18, 2021 at 8:33 AM Tony Lindgren wrote: > > > > After converting am335x to probe devices with simple-pm-bus I noticed > > that we are not passing auxdata for of_platform_populate() like we do > > with simple-bus. > >

Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2

2021-01-17 Thread Tony Lindgren
mux) OMAP_IOPAD_OFFSET((pa), 0x0800) > > > ((dir) | (mux)) > > > +#define AM33XX_PADCONF(pa, conf, mux)OMAP_IOPAD_OFFSET((pa), 0x0800) > > > (conf) (mux) > > > > > > /* > > > * Macros to allow using the offset from the padconf physi

Re: [PATCH] drivers: bus: simple-pm-bus: Fix compability with simple-bus for auxdata

2021-01-17 Thread Tony Lindgren
* Geert Uytterhoeven [210115 09:57]: > CC DT > > On Fri, Jan 15, 2021 at 10:42 AM Tony Lindgren wrote: > > Later on we may want to consider handling simple-pm-bus directly in > > drivers/of/platform.c as then we no longer need the platform data for > > simple-pm-bus.

[PATCHv2] drivers: bus: simple-pm-bus: Fix compatibility with simple-bus for auxdata

2021-01-17 Thread Tony Lindgren
. Fixes: 5a230524f879 ("ARM: dts: Use simple-pm-bus for genpd for am3 l4_wkup") Signed-off-by: Tony Lindgren --- Changes since v1: Updated description, added devicetree list to Cc --- arch/arm/mach-omap2/pdata-quirks.c | 1 + drivers/bus/simple-pm-bus.c| 3 ++- 2 files changed, 3

Re: [PATCH][next] power: supply: cpcap-charger: Fix power_supply_put on null battery pointer

2021-01-15 Thread Tony Lindgren
reference after null check") > Fixes: 4bff91bb3231 ("power: supply: cpcap-charger: Fix missing > power_supply_put()") > Signed-off-by: Colin Ian King Oopsie, thanks for fixing it: Acked-by: Tony Lindgren > drivers/power/supply/cpcap-charger.c | 3 ++- > 1 file changed,

[PATCH] drivers: bus: simple-pm-bus: Fix compability with simple-bus for auxdata

2021-01-15 Thread Tony Lindgren
no longer need the platform data for simple-pm-bus. Fixes: 5a230524f879 ("ARM: dts: Use simple-pm-bus for genpd for am3 l4_wkup") Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/pdata-quirks.c | 1 + drivers/bus/simple-pm-bus.c| 3 ++- 2 files changed, 3 insertions(+),

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2021-01-11 Thread Tony Lindgren
Hi, * Linus Walleij [210109 21:14]: > On Sat, Jan 9, 2021 at 3:55 AM Drew Fustini wrote: > > > I discussed my use case and this patch on #armlinux earlier this week > > and Alexandre Belloni suggested looking at the pinmux-pins debugfs file. > > This sounds reasonable. > > > This made me

Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-11 Thread Tony Lindgren
* Pavel Machek [210111 08:34]: > Hi! > > > We are still missing handling for errata i689 related issues for the > > case where we never see a key up interrupt for the last pressed key. > > > > To fix the issue, we must scan the key state again after the keyboard > > controller has idled to

Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-10 Thread Tony Lindgren
* Tony Lindgren [210110 19:08]: > --- a/drivers/input/keyboard/omap4-keypad.c > +++ b/drivers/input/keyboard/omap4-keypad.c > +/* > + * Errata ID i689 "1.32 Keyboard Key Up Event Can Be Missed". > + * Interrupt may not happen for key-up events. We must clear stuck

Re: [PATCH 4/5] Input: omap4-keypad - use PM runtime autosuspend

2021-01-10 Thread Tony Lindgren
* Tony Lindgren [210111 05:13]: > * Dmitry Torokhov [210111 05:01]: > > Hi Tony, > > > > On Sun, Jan 10, 2021 at 09:05:28PM +0200, Tony Lindgren wrote: > > > @@ -350,15 +379,12 @@ static int omap4_keypad_probe(struct > > > platf

Re: [PATCH 2/5] Input: omap4-keypad - scan keys in two phases and simplify with bitmask

2021-01-10 Thread Tony Lindgren
ypad - scan keys in two phases and simplify with bitmask > > From: Tony Lindgren > > Because of errata i689 the keyboard can idle with state where no key > up interrupts are seen until after the next key press. > > This means we need to first check for any lost

Re: [PATCH 3/5] Input: omap4-keypad - move rest of key scanning to a separate function

2021-01-10 Thread Tony Lindgren
* Dmitry Torokhov [210111 04:50]: > On Sun, Jan 10, 2021 at 09:05:27PM +0200, Tony Lindgren wrote: > > Let's move rest of the key scanning code to omap4_keypad_scan_keys(). > > We will use omap4_keypad_scan_keys() also for implementing errata > > handling to cle

Re: [PATCH 4/5] Input: omap4-keypad - use PM runtime autosuspend

2021-01-10 Thread Tony Lindgren
* Dmitry Torokhov [210111 05:01]: > Hi Tony, > > On Sun, Jan 10, 2021 at 09:05:28PM +0200, Tony Lindgren wrote: > > @@ -350,15 +379,12 @@ static int omap4_keypad_probe(struct platform_device > > *pdev) > > > > error =

[PATCH 2/5] Input: omap4-keypad - scan keys in two phases and simplify with bitmask

2021-01-10 Thread Tony Lindgren
Klemm Cc: Merlijn Wajer Cc: Pavel Machek Cc: ruleh Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 69 ++- 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input

[PATCH 4/5] Input: omap4-keypad - use PM runtime autosuspend

2021-01-10 Thread Tony Lindgren
Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 49 +-- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c --- a/drivers/input

[PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-10 Thread Tony Lindgren
ruleh Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c --- a/drivers/input/keyboard/omap4-keypad.c

[PATCH 3/5] Input: omap4-keypad - move rest of key scanning to a separate function

2021-01-10 Thread Tony Lindgren
: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c --- a/drivers/input/keyboard/omap4

[PATCH 1/5] Input: omap4-keypad - disable unused long interrupts

2021-01-10 Thread Tony Lindgren
Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4

[PATCHv5 0/5] Lost key-up interrupt handling for omap4-keypad

2021-01-10 Thread Tony Lindgren
k the last pressed key is not stuck - Simplify probe with devm Changes since v2: - Drop bogus level change, that already comes from device tree - Scan keyboard in two phases and simplify using a bitmask - Use mod_delayed_work and cancel_delayed_work_sync for the quirk Tony Lindgren (5): Input: om

Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-10 Thread Tony Lindgren
* Dmitry Torokhov [210110 06:34]: > Hi Tony, > > On Wed, Jan 06, 2021 at 02:58:21PM +0200, Tony Lindgren wrote: > > @@ -301,6 +348,7 @@ static int omap4_keypad_probe(struct platform_device > > *pdev) > > } > > > > keypad_data->

Re: [PATCH 4/4] Input: omap4-keypad - simplify probe with devm

2021-01-10 Thread Tony Lindgren
> Now that input core supports devres-managed input devices we can clean > up this driver a bit. > > Signed-off-by: Dmitry Torokhov Tested-by: Tony Lindgren > --- > drivers/input/keyboard/omap4-keypad.c | 139 > + > 1 file changed, 5

Re: [PATCH 4/4] Input: omap4-keypad - simplify probe with devm

2021-01-07 Thread Tony Lindgren
* Sebastian Reichel [210106 13:44]: > On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote: > > - struct resource *res; > > > > dev_pm_clear_wake_irq(>dev); > > - > > - free_irq(keypad_data->irq, keypad_data); > > -

Re: [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2021-01-07 Thread Tony Lindgren
* H. Nikolaus Schaller [201230 13:29]: > > Am 30.12.2020 um 13:55 schrieb Adam Ford : > > On Wed, Dec 30, 2020 at 2:43 AM Tony Lindgren wrote: > >> > >> At least for 4430, trying to use the single conversion mode eventually > >> hangs the therma

Re: [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2021-01-07 Thread Tony Lindgren
* Péter Ujfalusi [201231 12:55]: > On 12/30/20 10:43 AM, Tony Lindgren wrote: > > @@ -58,7 +58,8 @@ omap4430_adc_to_temp[OMAP4430_ADC_END_VALUE - > > OMAP4430_ADC_START_VALUE + 1] = { > > const struct ti_bandgap_data omap4430_data = { > > .features = TI_

[PATCHv4 0/4] Lost key-up interrupt handling for omap4-keypad

2021-01-06 Thread Tony Lindgren
pressed key is not stuck - Simplify probe with devm Changes since v2: - Drop bogus level change, that already comes from device tree - Scan keyboard in two phases and simplify using a bitmask - Use mod_delayed_work and cancel_delayed_work_sync for the quirk Tony Lindgren (4): Input: omap4

[PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-06 Thread Tony Lindgren
ating wake-up events in runtime suspended state. Cc: Arthur Demchenkov Cc: Carl Philipp Klemm Cc: Merlijn Wajer Cc: Pavel Machek Cc: ruleh Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 105 +++--- 1 file changed, 94 inserti

[PATCH 1/4] Input: omap4-keypad - disable unused long interrupts

2021-01-06 Thread Tony Lindgren
Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4

[PATCH 2/4] Input: omap4-keypad - scan keys in two phases and simplify with bitmask

2021-01-06 Thread Tony Lindgren
Klemm Cc: Merlijn Wajer Cc: Pavel Machek Cc: ruleh Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 70 ++- 1 file changed, 47 insertions(+), 23 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input

[PATCH 4/4] Input: omap4-keypad - simplify probe with devm

2021-01-06 Thread Tony Lindgren
Simplify probe with devm. Cc: Arthur Demchenkov Cc: Carl Philipp Klemm Cc: Merlijn Wajer Cc: Pavel Machek Cc: ruleh Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/input/keyboard/omap4-keypad.c | 81 ++- 1 file changed, 30 insertions(+), 51 deletions

[PATCH] phy: cpcap-usb: Fix warning for missing regulator_disable

2020-12-30 Thread Tony Lindgren
[] (really_probe+0x104/0x4a0) (really_probe) from [] (driver_probe_device+0x58/0xb4) Signed-off-by: Tony Lindgren --- drivers/phy/motorola/phy-cpcap-usb.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy

Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low

2020-12-30 Thread Tony Lindgren
* H. Nikolaus Schaller [201223 12:33]: > With the arrival of > > commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high > and gpio descriptors") > > it was clarified what the proper state for cs-gpios should be, even if the > flag is ignored. The driver code is doing the

[PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2020-12-30 Thread Tony Lindgren
to use iopoll in the following clean-up patch. Cc: Adam Ford Cc: Carl Philipp Klemm Cc: Eduardo Valentin Cc: Merlijn Wajer Cc: Pavel Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 3 ++- drivers/thermal/ti

[PATCH 3/3] thermal: ti-soc-thermal: Use non-inverted define for omap4

2020-12-30 Thread Tony Lindgren
Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 4 ++-- drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c b

[PATCH 2/3] thermal: ti-soc-thermal: Simplify polling with iopoll

2020-12-30 Thread Tony Lindgren
We can use iopoll for checking the EOCZ (end of conversion) bit. Cc: Adam Ford Cc: Carl Philipp Klemm Cc: Eduardo Valentin Cc: Merlijn Wajer Cc: Pavel Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/ti-bandgap.c | 30

Re: [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem

2020-12-24 Thread Tony Lindgren
Hi, * Pavel Machek [201220 22:48]: > Hi! > > > Sorry about the late reply on this. > > I'm afraid I'll need some more answers in near future, but for now: > > Tony, do you remember / can you figure out what gsmtty GPS is on? I > never used it on that interface, and I can't seem to figure it

Re: [PATCH] ARM: OMAP1: OSK: fix ohci-omap breakage

2020-12-17 Thread Tony Lindgren
* Aaro Koskinen [201214 23:01]: > From: Linus Walleij > > Commit 45c5775460f3 ("usb: ohci-omap: Fix descriptor conversion") tried to > fix all issues related to ohci-omap descriptor conversion, but a wrong > patch was applied, and one needed change to the OSK board file is still > missing. Fix

Re: [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make display work again

2020-12-17 Thread Tony Lindgren
* H. Nikolaus Schaller [201212 11:59]: > This reverts > > commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make > display work again") > > which had to be intruduced after > > commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings") > > broke the GTA04

[PATCH] soc: ti: omap-prm: Fix boot time errors for rst_map_012 bits 0 and 1

2020-12-08 Thread Tony Lindgren
other type rstctrl bits also need reset on init, we need to add an instance specific reset mask for the bits to avoid resetting unwanted bits. Reported-by: Carl Philipp Klemm Cc: Philipp Zabel Cc: Santosh Shilimkar Cc: Suman Anna Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/soc/ti/

Re: [PATCH] ARM: omap2plus_defconfig: enable SPI GPIO

2020-12-07 Thread Tony Lindgren
* H. Nikolaus Schaller [201201 19:23]: > > > Am 01.12.2020 um 20:12 schrieb Andreas Kemnade : > > > > GTA04 uses that for controlling the td028ttec1 panel. So > > for easier testing/bisecting it is useful to have it > > enabled in the defconfig. > > ++ Applying into

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-07 Thread Tony Lindgren
* Doug Anderson [201204 16:43]: > Hi, > > On Fri, Dec 4, 2020 at 8:14 AM Andreas Kemnade wrote: > > > > > > Fixes: 21b2cec61c04 ("mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers > > > > that existed in v4.4") > > > > > > From the description it sounds like this problem has always existed > > >

Re: [PATCH] clk: ti: omap5: Fix reboot DPLL lock failure when using ABE TIMERs

2020-12-07 Thread Tony Lindgren
e_dpll_bypass_clk_mux to sys_32k_ck > in omap5xxx_dt_clk_init. > > A similar patch may also be needed for OMAP44xx which has similar code > in omap4xxx_dt_clk_init, but I have not added this as I have no hardware > to test on. Acked-by: Tony Lindgren

Re: [PATCH] ARM: dts: omap3-gta04: fix twl4030-power settings

2020-12-01 Thread Tony Lindgren
* Andreas Kemnade [201201 09:49]: > Things are wired up for powersaving, so lets use the corresponding > compatible and also update a deprecated property name. Thanks applying into omap-for-v5.11/dt. Tony

Re: [PATCH] ARM: dts: OMAP3: disable AES on N950/N9

2020-11-30 Thread Tony Lindgren
* Aaro Koskinen [201129 16:47]: > AES needs to be disabled on Nokia N950/N9 as well (HS devices), otherwise > kernel fails to boot. Thanks applying into fixes. Tony

Re: [PATCH] ARM: omap2plus_defconfig: drop unused POWER_AVS option

2020-11-30 Thread Tony Lindgren
* Andrey Zhizhikin [201130 14:43]: > Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the > corresponding Kconfig") moved AVS code to SOC-specific folders, and > removed corresponding Kconfig from drivers/power, leaving original > POWER_AVS config option enabled in omap2plus_defconfig

Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk/icev2: switch to new cpsw switch drv

2020-11-30 Thread Tony Lindgren
* Grygorii Strashko [201119 17:45]: > Hi Tony, > > This is the initial conversation of am335x boards to use new cpsw switch > driver. > This series adds the cpsw switch driver DT definition and > am335x-evm/evmsk/icev2 > boards are converted to use it. Thanks applying into omap-for-v5.11/dt.

Re: [PATCH v2] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot

2020-11-23 Thread Tony Lindgren
* Arnd Bergmann [201123 16:55]: > On Mon, Nov 16, 2020 at 10:04 AM Tony Lindgren wrote: > > > > * Grygorii Strashko [201030 14:47]: > > > Enable networking options required for NFS boot on TI platforms, which is > > > widely for automated test systems. > &g

Re: [PATCH 1/2] arm: Fix memleak in omap2xxx_clkt_vps_init

2020-11-19 Thread Tony Lindgren
* Youling Tang [201114 04:07]: > If the clk_register fails, we should free hw before function returns to > prevent memleak. Thanks applying both into omap-for-v5.11/soc. Tony

Re: [PATCH] ARM: OMAP2+: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare

2020-11-19 Thread Tony Lindgren
* Xu Wang [201104 08:45]: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. Thanks applying into omap-for-v5.11/soc. Tony

Re: [PATCH] ARM: OMAP2+: Remove redundant assignment to variable ret

2020-11-19 Thread Tony Lindgren
* Jing Xiangfeng [200919 06:43]: > The variable ret has been initialized with '-ENOMEM'. The assignment > in the if branch is redundant. So remove it. Thanks applying into omap-for-v5.11/soc. Tony

Re: [PATCH] ARM: OMAP1: clock: Use IS_ERR_OR_NULL() to clean code

2020-11-19 Thread Tony Lindgren
* Tang Bin [200910 14:06]: > Use IS_ERR_OR_NULL() to make the code cleaner. Applying into omap-for-v5.11/soc thanks. Tony

Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"

2020-11-19 Thread Tony Lindgren
t in case. Looks like make omap2lus_defconfig is not selecting it anyways and I never even noticed earlier: Acked-by: Tony Lindgren

Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

2020-11-19 Thread Tony Lindgren
Grygorii Strashko Acked-by: Tony Lindgren

Re: [PATCH] bus: ti-sysc: suppress err msg for timers used as clockevent/source

2020-11-19 Thread Tony Lindgren
* Grygorii Strashko [201118 14:19]: > GP Timers used as clockevent/source are not available for ti-sysc bus and > handled by Kernel timekeeping core. Now ti-sysc produces error message > every time such timer is detected: > > "ti-sysc: probe of 4804.target-module failed with error -16" > >

Re: [PATCH 0/3] Enable eQEP counter driver on BeagleBone Blue

2020-11-16 Thread Tony Lindgren
* David Lechner [201013 00:13]: > This series adds device tree nodes for the eQEP portion of the PWMSS on AM33xx > and enables it on BeagleBone Blue. > > I actually submitted these a year ago, but it looks like these patches never > got > applied with the actual eQEP driver when it was merged.

Re: [PATCH v2] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot

2020-11-16 Thread Tony Lindgren
* Grygorii Strashko [201030 14:47]: > Enable networking options required for NFS boot on TI platforms, which is > widely for automated test systems. > - enable new TI CPSW switch driver and related NET_SWITCHDEV config > - enable TI DP83867 phy > - explicitly enable PTP clock support to ensure

Re: [PATCH 2/2] ARM: omap2plus_defconfig: Enable OMAP3_THERMAL

2020-11-16 Thread Tony Lindgren
* Adam Ford [201016 15:19]: > On Fri, Sep 11, 2020 at 7:32 AM Adam Ford wrote: > > > > With the additional power management options enabled, > > this patch enables OMAP3_THERMAL by default. > > > > Signed-off-by: Adam Ford > > --- > > V3: No change > > V2: No change > > Tony, > > Can you

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-15 Thread Tony Lindgren
* Tim Harvey [201113 22:07]: > 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack registers") > appears to not only add the new clear_ack case it also attempts to > resolve the long standing ack_invert issue with this change: > > - ret = regmap_write(map, reg, data->status_buf[i]); > + if

Re: v5.10-rc3 vs. Droid 4

2020-11-15 Thread Tony Lindgren
* Pavel Machek [201114 20:59]: > Hi! > > Does anyone have Droid 4 working with 5.10-rc3? > > I tried it with the original config; I got message about culomb > counter calibration done scrolling (and boot progressing very slowly > or not at all) . So ... I disabled cpcap battery & charger >

Re: [PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend

2020-11-13 Thread Tony Lindgren
TS IRQ enabling in cpsw_ndo_open() where CPTS is > actually started. > > Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq") > Reported-by: Tony Lindgren > Signed-off-by: Grygorii Strashko Thanks this works for me: Tested-by: Tony Lindgren

Re: [PATCH V2 5/5] arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as "reserved"

2020-11-12 Thread Tony Lindgren
* Nishanth Menon [201112 01:49]: > Follow the device tree standards that states to set the > status="reserved" if an device is operational, but used by a non-linux > firmware in the system. Makes sense to me: Reviewed-by: Tony Lindgren

Re: [PATCH V2 3/5] arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto

2020-11-12 Thread Tony Lindgren
rm64: dts: ti: k3-j721e-main: Add crypto accelerator > > node") > > Fixes: b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node") > > Signed-off-by: Nishanth Menon > > Cc: Keerthy > > Acked-by: Tero Kristo Reviewed-by: Tony Lindgren

Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

2020-11-12 Thread Tony Lindgren
uot;arm64: dts: ti: k3-am654-base-board: enable USB1") > > Signed-off-by: Nishanth Menon > > Cc: Roger Quadros > > Acked-by: Roger Quadros Reviewed-by: Tony Lindgren

Re: [PATCH V2 2/5] arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi level

2020-11-12 Thread Tony Lindgren
onality, etc. are a few of the > reasons. Reviewed-by: Tony Lindgren

Re: [PATCH V2 1/5] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level

2020-11-12 Thread Tony Lindgren
onality, etc. are a few of the > reasons. Reviewed-by: Tony Lindgren

Re: [PATCH V2 1/5] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level

2020-11-12 Thread Tony Lindgren
of am654 SoC dtsi before this gets more harder > to cleanup later on and new SoCs are added. > > The dtb generated is identical with the patch and it is just cleanup to > ensure we have a clean usage model Thanks this looks good to me: Reviewed-by: Tony Lindgren

[PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-11 Thread Tony Lindgren
ack registers") Cc: Carl Philipp Klemm Cc: Laxminath Kasam Cc: Merlijn Wajer Cc: Mark Brown Cc: Pavel Machek Cc: Sebastian Reichel Cc: Tim Harvey Signed-off-by: Tony Lindgren --- drivers/mfd/motorola-cpcap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

2020-11-10 Thread Tony Lindgren
* Stephen Rothwell [201110 21:16]: > Hi all, > > In commit > > e4b5575da267 ("ARM: OMAP2+: Manage MPU state properly for > omap_enter_idle_coupled()") > > Fixes tag > > Fixes: 8ca5ee624b4c ("ARM: OMAP2+: Restore MPU power domain if > cpu_cluster_pm_enter() fails") > > has these

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-10 Thread Tony Lindgren
* Arnd Bergmann [201110 13:35]: > On Tue, Nov 10, 2020 at 1:06 PM Tony Lindgren wrote: > > > > Are these actually ARMv6? Most ARM11 cores you'd come across > > > in practice are ARMv6K (ARM1136r1, ARM1167, ARM11MPCore), > > > in particular every SoC tha

Re: [PATCH v7 09/12] ARM: dts: omap: Fix schema warnings for pwm-leds

2020-11-10 Thread Tony Lindgren
* Alexander Dahl [201005 23:36]: > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. Applying into omap-for-v5.11/dt thanks. Tony

Re: [PATCH 22/29] arm: dts: omap5: Harmonize DWC USB3 DT nodes name

2020-11-10 Thread Tony Lindgren
* Krzysztof Kozlowski [201020 12:41]: > On Tue, Oct 20, 2020 at 02:59:52PM +0300, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable

Re: [PATCH 03/29] arm: dts: am437x: Correct DWC USB3 compatible string

2020-11-10 Thread Tony Lindgren
* Krzysztof Kozlowski [201020 12:31]: > On Tue, Oct 20, 2020 at 02:59:33PM +0300, Serge Semin wrote: > > Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. > > Use it instead of the deprecated "synopsys" one. > > > > Signed-off-by: Serge Semin > > --- > >

Re: [PATCH 0/2] AMR: DTS: fix and extension for Pandaboard ES

2020-11-10 Thread Tony Lindgren
* H. Nikolaus Schaller [201030 09:09]: > ping > > > Am 03.10.2020 um 16:09 schrieb H. Nikolaus Schaller : > > > > * fix wrong pinmux offset preventing the user button from working > > * add uart connection for bluetooth wl1271 hci > > > > H. Nikolaus Schaller (2): > > ARM: dts: pandaboard:

Re: [PATCH] ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

2020-11-10 Thread Tony Lindgren
* Grygorii Strashko [201029 19:13]: > Hi Tony, > > On 01/10/2020 22:20, Grygorii Strashko wrote: > > Fix compatible the new CPSW switchdev DT node to avoid probing of legacy > > CPSW driver which fails: > > [2.781009] cpsw 4a10.switch: invalid resource > > > > Fixes: 7bf8f37aea82 ("ARM:

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-10 Thread Tony Lindgren
* Arnd Bergmann [201110 10:04]: > On Tue, Nov 10, 2020 at 10:19 AM Tony Lindgren wrote: > > * Arnd Bergmann [201109 19:10]: > > > On Mon, Nov 9, 2020 at 3:45 PM Tony Lindgren wrote: > > > > > > I know it works, my point was that I'm not sure anyone c

[PATCH 5/9] bus: ti-sysc: Implement GPMC debug quirk to drop platform data

2020-11-10 Thread Tony Lindgren
We need to enable no-reset-on-init quirk for GPMC if the config option for CONFIG_OMAP_GPMC_DEBUG is set. Otherwise the GPMC driver code is unable to show the bootloader configured timings. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 10 ++ include/linux

[PATCH 6/9] soc: ti: omap-prm: Add pm_clk for genpd

2020-11-10 Thread Tony Lindgren
In order to probe l3 and l4 interconnects with simple-pm-bus, we want genpd to manage the clocks for the interconnects. For interconnect target modules, we already have ti-sysc manage the clocks so let's skipe managing clocks for ti-sysc modules. Cc: Santosh Shilimkar Signed-off-by: Tony

[PATCH 8/9] soc: ti: pm33xx: Enable basic PM runtime support for genpd

2020-11-10 Thread Tony Lindgren
To prepare for moving to use genpd, let's enable basic PM runtime support. Cc: Dave Gerlach Cc: Santosh Shilimkar Cc: Suman Anna Signed-off-by: Tony Lindgren --- drivers/soc/ti/pm33xx.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti

[PATCH 7/9] soc: ti: omap-prm: am3: add genpd support for remaining PRM instances

2020-11-10 Thread Tony Lindgren
From: Tero Kristo Add genpd support for per, wkup, mpu, rtc and cefuse instances. Cc: Santosh Shilimkar Signed-off-by: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/soc/ti/omap_prm.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff

[PATCH 9/9] remoteproc/wkup_m3: Use reset control driver if available

2020-11-10 Thread Tony Lindgren
simply drop the related legacy reset platform data callbacks from wkup_m3 driver later on after also am437x no longer depends on it. Cc: linux-remotep...@vger.kernel.org Cc: Bjorn Andersson Cc: Dave Gerlach Cc: Philipp Zabel Cc: Suman Anna Signed-off-by: Tony Lindgren --- Please review and ack

[PATCH 3/9] clk: ti: am33xx: Keep am3 l3 main clock always on for genpd

2020-11-10 Thread Tony Lindgren
code. Later on we may want to start managing the l3 main clock with a dedicated interconnect driver instead of using simple-pm-bus and GENPD_FLAG_PM_CLK. Cc: linux-...@vger.kernel.org Cc: Michael Turquette Cc: Stephen Boyd Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/clk/ti/clk

[PATCH 1/9] ARM: OMAP2+: Check for inited flag

2020-11-10 Thread Tony Lindgren
If we have no hwmods configured and omap_hwmod_init() is not called, we don't want to call omap_hwmod_setup_all() as it will fail with checks for configured MPU at least. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/omap_hwmod.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 4/9] bus: ti-sysc: Support modules without control registers

2020-11-10 Thread Tony Lindgren
Some modules like MPU have a powerdomain and functional clock but not necessarily any control registers. Let's allow configuring interconnect target modules with no control registers. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 2/9] ARM: OMAP2+: Probe PRCM first to probe l4_wkup with simple-pm-bus

2020-11-10 Thread Tony Lindgren
In preparation for probing the interconnects with simple-pm-bus to make use of genpd, we need to probe the always-on PRCM first for the clocks needed by l4_wkup instance. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/pdata-quirks.c | 11 +++ 1 file changed, 11 insertions(+) diff

[PATCHv2 0/9] Genpd related code changes to drop am335x pdata

2020-11-10 Thread Tony Lindgren
: OMAP2+: Fix missing select PM_GENERIC_DOMAINS_OF And the related device tree changes have been posted as: [PATCH 00/18] Drop remaining pdata for am335x and use genpd Regards, Tony Tero Kristo (1): soc: ti: omap-prm: am3: add genpd support for remaining PRM instances Tony Lindgren (8): ARM

[PATCH] bus: ti-sysc: Assert reset only after disabling clocks

2020-11-10 Thread Tony Lindgren
probably no need to apply this patch as a fix. Signed-off-by: Tony Lindgren --- This can probably wait for merge window and be merged along with the other genpd related changes I have been posting. At least I have not seen this issue except with IVA resets so far. --- drivers/bus/ti-sysc.c | 24

[PATCH] soc: ti: omap-prm: Do not check rstst bit on deassert if already deasserted

2020-11-10 Thread Tony Lindgren
If a rstctrl reset bit is already deasserted, we can just bail out early not wait for rstst to clear. Otherwise we can have deassert fail for already deasserted resets. Fixes: c5117a78dd88 ("soc: ti: omap-prm: poll for reset complete during de-assert") Signed-off-by: Tony Lindgren --

[PATCHv2] bus: ti-sysc: Fix bogus resetdone warning on enable for cpsw

2020-11-10 Thread Tony Lindgren
enable and wait for softreset bit") Suggested-by: Grygorii Strashko Signed-off-by: Tony Lindgren --- Changes since v1: - Drop quirk handling and use fix suggested by Grygorii --- drivers/bus/ti-sysc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-10 Thread Tony Lindgren
* Arnd Bergmann [201109 19:10]: > On Mon, Nov 9, 2020 at 3:45 PM Tony Lindgren wrote: > > > > > > As discussed on IRC, I think it can still be done in one of these > > > ways, though admittedly none of them are perfect: > > > > > > a)

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-09 Thread Tony Lindgren
* Arnd Bergmann [201021 16:07]: > On Wed, Oct 21, 2020 at 2:57 PM Russell King - ARM Linux admin > wrote: > > On Wed, Oct 21, 2020 at 01:45:42PM +0100, Russell King - ARM Linux admin > > wrote: > > > > > - define 'current' as 'this_cpu_read_stable(current_task);' > > > > > - convert to

Re: [PATCH 4/4] bus: ti-sysc: Fix bogus resetdone warning for cpsw

2020-10-31 Thread Tony Lindgren
* Grygorii Strashko [201030 18:15]: > Hi Tony, > > On 26/10/2020 12:58, Tony Lindgren wrote: > > The cpsw SOFT_RESET register is cleard when out of reset so let's > > add SYSS_QUIRK_RESETDONE_INVERTED flag for cpsw. Otherwise we will > > get bogus "OCP softr

Re: [RESEND PATCH 2/4] usb: musb: Fix NULL check on struct musb_request field

2020-10-29 Thread Tony Lindgren
l be invalid. > > Fix it preventively by doing the NULL-check on the 'req' pointer > instead. Acked-by: Tony Lindgren

Re: [PATCH] thermal: ti-soc-thermal: Disable the CPU PM notifier for OMAP4430

2020-10-29 Thread Tony Lindgren
e > constant and steady stream of: > thermal thermal_zone0: failed to read out thermal zone (-5) Works for me and I've verified duovero still keeps hitting core ret idle: Tested-by: Tony Lindgren Regards, Tony

Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes

2020-10-27 Thread Tony Lindgren
* Nishanth Menon [201026 14:58]: > On 13:38-20201007, Peter Ujfalusi wrote: > [...] > > + status = "disabled"; > > >>> > > >>> I see that there is inconsistent usage of "disabled" in our SoC.dts > > >>> > > >>> Our generic rule has been set them to disabled in board.dtsi > > >>>

Re: [PATCH 0/9] Genpd related code changes to drop am335x pdata

2020-10-26 Thread Tony Lindgren
* Tony Lindgren [201026 11:11]: > Hi all, > > Here are the code related changes for v5.11 merge window to drop the > remaining am335x platform data. I'll be posting the related device tree > changes separately. Sorry I forgot to mention that this series depends also on a series

Re: [PATCH 9/9] remoteproc/wkup_m3: Use reset control driver if available

2020-10-26 Thread Tony Lindgren
Hi, * Philipp Zabel [201026 11:35]: > On Mon, 2020-10-26 at 13:10 +0200, Tony Lindgren wrote: > > @@ -57,6 +60,9 @@ static int wkup_m3_rproc_start(struct rproc *rproc) > > struct device *dev = >dev; > > struct wkup_m3_platform_data *pdata = dev_get_platdata(dev);

[PATCH 7/9] soc: ti: omap-prm: am3: add genpd support for remaining PRM instances

2020-10-26 Thread Tony Lindgren
From: Tero Kristo Add genpd support for per, wkup, mpu, rtc and cefuse instances. Cc: Santosh Shilimkar Signed-off-by: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/soc/ti/omap_prm.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff

[PATCH 4/9] bus: ti-sysc: Support modules without control registers

2020-10-26 Thread Tony Lindgren
Some modules like MPU have a powerdomain and functional clock but not necessarily any control registers. Let's allow configuring interconnect target modules with no control registers. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 3/9] clk: ti: am33xx: Keep am3 l3 main clock always on for genpd

2020-10-26 Thread Tony Lindgren
code. Later on we may want to start managing the l3 main clock with a dedicated interconnect driver instead of using simple-pm-bus and GENPD_FLAG_PM_CLK. Cc: linux-...@vger.kernel.org Cc: Michael Turquette Cc: Stephen Boyd Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/clk/ti/clk

<    1   2   3   4   5   6   7   8   9   10   >