RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
OK, got you. Is "operating-points-v2-kryo-cpu" good enough? > -Original Message- > From: Sudeep Holla > Sent: Thursday, May 24, 2018 17:48 > To: ilia...@codeaurora.org > Cc: Sudeep Holla ; linux...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > vire...@kern

RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
Thank you for the explanation. However, could you suggest, which condition should I check then? Device tree? > -Original Message- > From: Sudeep Holla > Sent: Thursday, May 24, 2018 17:01 > To: ilia...@codeaurora.org; vire...@kernel.org; n...@ti.com; > sb...@kernel.org; r...@kernel.org;

RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
> -Original Message- > From: Sudeep Holla > Sent: Thursday, May 24, 2018 15:52 > To: Ilia Lin ; vire...@kernel.org; n...@ti.com; > sb...@kernel.org; r...@kernel.org; mark.rutl...@arm.com; > r...@rjwysocki.net > Cc: Sudeep Holla ; linux...@vger.kernel.org; > devicet...@vger.kernel.org; li

RE: [PATCH v11 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
> -Original Message- > From: Sudeep Holla > Sent: Wednesday, May 23, 2018 16:25 > To: Ilia Lin ; vire...@kernel.org; n...@ti.com; > sb...@kernel.org; r...@kernel.org; mark.rutl...@arm.com; > r...@rjwysocki.net; linux...@vger.kernel.org; devicet...@vger.kernel.org; > linux-kernel@vger.ker

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
The nvmem will return EPROBE_DEFER, and so will my driver's init. But then no one will call the init again. > -Original Message- > From: Viresh Kumar > Sent: Wednesday, May 23, 2018 14:46 > To: Ilia Lin > Cc: Sudeep Holla ; Viresh Kumar > ; Nishanth Menon ; Stephen Boyd > ; Rob Herring

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
> -Original Message- > From: Viresh Kumar > Sent: Wednesday, May 23, 2018 14:31 > To: Ilia Lin > Cc: Sudeep Holla ; Viresh Kumar > ; Nishanth Menon ; Stephen Boyd > ; Rob Herring ; Mark Rutland > ; Rafael J. Wysocki ; linux- > p...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kern

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
> -Original Message- > From: Sudeep Holla > Sent: Wednesday, May 23, 2018 13:40 > To: Ilia Lin ; vire...@kernel.org; n...@ti.com; > sb...@kernel.org; r...@kernel.org; mark.rutl...@arm.com; > r...@rjwysocki.net; linux...@vger.kernel.org; devicet...@vger.kernel.org; > linux-kernel@vger.ker

RE: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-22 Thread ilialin
OK, I think I found out the way. Would this be correct? --- extern struct cpu_topology cpu_topology[NR_CPUS]; static struct device *qcom_cpufreq_kryo_get_cluster_lead(int cluster) { unsigned cpu;

RE: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
> -Original Message- > From: Sudeep Holla > Sent: Monday, May 21, 2018 16:05 > To: ilia...@codeaurora.org; mturque...@baylibre.com; sb...@kernel.org; > r...@kernel.org; mark.rutl...@arm.com; viresh.ku...@linaro.org; > n...@ti.com; lgirdw...@gmail.com; broo...@kernel.org; > andy.gr...@lin

RE: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
> -Original Message- > From: Sudeep Holla > Sent: Monday, May 21, 2018 15:50 > To: Ilia Lin ; mturque...@baylibre.com; > sb...@kernel.org; r...@kernel.org; mark.rutl...@arm.com; > viresh.ku...@linaro.org; n...@ti.com; lgirdw...@gmail.com; > broo...@kernel.org; andy.gr...@linaro.org; davi

RE: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
There are 2 CPU clusters in the Kryo, CPU 0 and 1 are called Silver Cluster and CPU 2 and 3 - Gold Cluster. Each cluster has single clock. The clusters differ in terms of speed capabilities, computing power and power consumption. Therefore, I define separate OPP table for each cluster, and my drive

RE: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
You are right. cpu_dev_silver != cpu_dev_gold, and I found this with my tests as well. Thank you. > -Original Message- > From: Russell King - ARM Linux > Sent: Monday, May 21, 2018 13:54 > To: Ilia Lin > Cc: viresh.ku...@linaro.org; devicet...@vger.kernel.org; linux- > p...@vger.kernel.o

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
Final version (addressing Russel's comment as well): // SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2018, The Linux Foundation. All rights reserved. */ /* * In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, * the CPU frequency subset and voltage value of each

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
Hi Viresh, If I send patches in reply, it will produce new patches, instead of answers in the thread. Please find below the file dump. ->cat drivers/cpufreq/qcom-cpufreq-kryo.c // SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2018, The Linux Foundation. All rights reserved. */ /* * In C

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
>From c5804e1d17578a63ca87cc8fd839bf756cfe3567 Mon Sep 17 00:00:00 2001 In-Reply-To: <1526555955-29960-11-git-send-email-ilia...@codeaurora.org> References: <1526555955-29960-11-git-send-email-ilia...@codeaurora.org> From: Ilia Lin Date: Thu, 17 May 2018 13:55:12 +0300 Subject: [PATCH] cpufreq: Ad

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
commit 4abe2cd7176a43c77e9a462e4f6ec51aa7552e73 Author: Ilia Lin Date: Thu May 17 13:55:12 2018 +0300 cpufreq: Add Kryo CPU scaling driver In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, the CPU frequency subset and voltage value of each OPP varies base

RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
> -Original Message- > From: ilia...@codeaurora.org > Sent: Thursday, May 17, 2018 10:51 > To: 'Viresh Kumar' ; 'Amit Kucheria' > > Cc: 'Michael Turquette' ; 'sb...@kernel.org' > ; 'Rob Herring' ; 'Mark Rutland' > ; 'n...@ti.com' ; > 'lgirdw...@gmail.com' ; 'broo...@kernel.org' > ; 'And

RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
> -Original Message- > From: Viresh Kumar > Sent: Wednesday, May 16, 2018 17:12 > To: Amit Kucheria > Cc: Ilia Lin ; Michael Turquette > ; sb...@kernel.org; Rob Herring > ; Mark Rutland ; n...@ti.com; > lgirdw...@gmail.com; broo...@kernel.org; Andy Gross > ; David Brown ; > catalin.mari

RE: [PATCH v7 10/14] dt-bindings: qcom_spmi: Add support for SAW documentation

2018-05-17 Thread ilialin
> -Original Message- > From: amit.kuche...@verdurent.com On > Behalf Of Amit Kucheria > Sent: Wednesday, May 16, 2018 16:13 > To: Ilia Lin > Cc: Michael Turquette ; sb...@kernel.org; Rob > Herring ; Mark Rutland ; Viresh > Kumar ; n...@ti.com; lgirdw...@gmail.com; > broo...@kernel.org;

RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
> -Original Message- > From: amit.kuche...@verdurent.com On > Behalf Of Amit Kucheria > Sent: Wednesday, May 16, 2018 16:13 > To: Ilia Lin > Cc: Michael Turquette ; sb...@kernel.org; Rob > Herring ; Mark Rutland ; Viresh > Kumar ; n...@ti.com; lgirdw...@gmail.com; > broo...@kernel.org;

RE: [PATCH v5 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-04 Thread ilialin
> -Original Message- > From: Viresh Kumar > Sent: Friday, May 4, 2018 09:57 > To: ilia...@codeaurora.org > Cc: mturque...@baylibre.com; sb...@kernel.org; r...@kernel.org; > mark.rutl...@arm.com; r...@rjwysocki.net; lgirdw...@gmail.com; > broo...@kernel.org; andy.gr...@linaro.org; david.b

RE: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996

2018-05-03 Thread ilialin
Kryo has single clock per cluster. I define here a shared OPP table per cluster. > -Original Message- > From: Viresh Kumar > Sent: Friday, May 4, 2018 09:04 > To: Ilia Lin > Cc: Michael Turquette ; Stephen Boyd > ; Rob Herring ; Mark Rutland > ; Rafael J. Wysocki ; Liam > Girdwood ; Mark

RE: [PATCH v5 13/14] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu

2018-05-03 Thread ilialin
> -Original Message- > From: Viresh Kumar > Sent: Friday, May 4, 2018 09:11 > To: Ilia Lin > Cc: mturque...@baylibre.com; sb...@kernel.org; r...@kernel.org; > mark.rutl...@arm.com; r...@rjwysocki.net; lgirdw...@gmail.com; > broo...@kernel.org; andy.gr...@linaro.org; david.br...@lina

RE: [PATCH v5 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-03 Thread ilialin
> -Original Message- > From: Viresh Kumar > Sent: Friday, May 4, 2018 09:08 > To: Ilia Lin > Cc: mturque...@baylibre.com; sb...@kernel.org; r...@kernel.org; > mark.rutl...@arm.com; r...@rjwysocki.net; lgirdw...@gmail.com; > broo...@kernel.org; andy.gr...@linaro.org; david.br...@linaro.o

RE: [PATCH 2/2] dt-bindings: Add support for SAW documentation

2018-03-08 Thread ilialin
Thanks for the review, Rob. I used existing drivers as reference and defined in the same way. Could you point me to a reference that is correct from your point of view? > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Wednesday, March 7, 2018 22:41 > To: Ilia Lin