Hi Ingo, Thomas,
Thanks for your review!
2016-09-08 15:33 GMT+09:00 Ingo Molnar :
>> static unsigned int flat_get_apic_id(unsigned long x)
>> {
>> - unsigned int id;
>> -
>> - id = (((x)>>24) & 0xFFu);
>> -
>> - return id;
>> + return ((x) >> 24) & 0xFFu;
>
> So while we are
* Thomas Gleixner wrote:
> On Sat, 10 Sep 2016, Ingo Molnar wrote:
> > * Thomas Gleixner wrote:
> >
> > > On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > > > * Masahiro Yamada wrote:
> > > > > static unsigned long set_apic_id(unsigned int id)
> > > > > {
> > > > > - unsigned long x;
> > > >
On Sat, 10 Sep 2016, Ingo Molnar wrote:
> * Thomas Gleixner wrote:
>
> > On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > > * Masahiro Yamada wrote:
> > > > static unsigned long set_apic_id(unsigned int id)
> > > > {
> > > > - unsigned long x;
> > > > -
> > > > /* maskout x2apic_extra_
* Thomas Gleixner wrote:
> On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > * Masahiro Yamada wrote:
> > > static unsigned long set_apic_id(unsigned int id)
> > > {
> > > - unsigned long x;
> > > -
> > > /* maskout x2apic_extra_bits ? */
> > > - x = id;
> > > - return x;
> > > + return id;
> > >
On Thu, 8 Sep 2016, Ingo Molnar wrote:
> * Masahiro Yamada wrote:
> > static unsigned long set_apic_id(unsigned int id)
> > {
> > - unsigned long x;
> > -
> > /* maskout x2apic_extra_bits ? */
> > - x = id;
> > - return x;
> > + return id;
> > }
>
> This was clearly left there to d
* Masahiro Yamada wrote:
> Remove unneeded variables and assignments. I am also removing
> unnecessary parentheses while I am here.
>
> Signed-off-by: Masahiro Yamada
> ---
>
> arch/x86/kernel/apic/apic_flat_64.c | 16 +++-
> arch/x86/kernel/apic/apic_numachip.c | 5 +
> a
Remove unneeded variables and assignments. I am also removing
unnecessary parentheses while I am here.
Signed-off-by: Masahiro Yamada
---
arch/x86/kernel/apic/apic_flat_64.c | 16 +++-
arch/x86/kernel/apic/apic_numachip.c | 5 +
arch/x86/kernel/apic/x2apic_uv_x.c | 5 +
7 matches
Mail list logo