Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-05-07 Thread Sebastian Capella
Thanks Pavel! I believe it's missed 3.15, so will need to verify again for 3.16. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-05-07 Thread Pavel Machek
On Wed 2014-04-23 09:39:48, Sebastian Capella wrote: > Hi Russell, > > Ran this overnight and no failures on >1000 hibernations. Congratulations. Looking forward to hibernate n900 on battery low :-). Pavel -- (english)

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-05-07 Thread Pavel Machek
On Wed 2014-04-23 09:39:48, Sebastian Capella wrote: Hi Russell, Ran this overnight and no failures on 1000 hibernations. Congratulations. Looking forward to hibernate n900 on battery low :-). Pavel -- (english)

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-05-07 Thread Sebastian Capella
Thanks Pavel! I believe it's missed 3.15, so will need to verify again for 3.16. Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-23 Thread Sebastian Capella
Hi Russell, Ran this overnight and no failures on >1000 hibernations. Looks good. Thanks! Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-23 Thread Sebastian Capella
Hi Russell, Ran this overnight and no failures on 1000 hibernations. Looks good. Thanks! Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-22 Thread Sebastian Capella
Hi Russell, Sorry for the delay. I've merged the omap changes onto 3.15-rc2 and tested and it looks like everything is working (so far 50 loops into/out of hibernation). Thanks! Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-22 Thread Sebastian Capella
Hi Russell, Sorry for the delay. I've merged the omap changes onto 3.15-rc2 and tested and it looks like everything is working (so far 50 loops into/out of hibernation). Thanks! Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-17 Thread Sebastian Capella
Hi Russell, It seems to work fine with your virt_to_phys on the 3.13 + OMAP patches kernel, and I checked on the 3.15-rc1 kernel + hibernation and it compiled and ran fine. I tried a couple of hibernations on this version as well and they worked (aside from the crash in kernel_halt we're

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-17 Thread Sebastian Capella
Hi Russell, It seems to work fine with your virt_to_phys on the 3.13 + OMAP patches kernel, and I checked on the 3.15-rc1 kernel + hibernation and it compiled and ran fine. I tried a couple of hibernations on this version as well and they worked (aside from the crash in kernel_halt we're

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-16 Thread Sebastian Capella
On 16 April 2014 03:12, Russell King - ARM Linux wrote: > On Wed, Mar 05, 2014 at 02:50:05AM -0800, Sebastian Capella wrote: >> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h >> index 8756e4b..d32adbb 100644 >> --- a/arch/arm/include/asm/memory.h >> +++

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-16 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 02:50:05AM -0800, Sebastian Capella wrote: > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index 8756e4b..d32adbb 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -291,6 +291,7 @@ static inline void

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-16 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 02:50:05AM -0800, Sebastian Capella wrote: diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h index 8756e4b..d32adbb 100644 --- a/arch/arm/include/asm/memory.h +++ b/arch/arm/include/asm/memory.h @@ -291,6 +291,7 @@ static inline void

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-04-16 Thread Sebastian Capella
On 16 April 2014 03:12, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Mar 05, 2014 at 02:50:05AM -0800, Sebastian Capella wrote: diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h index 8756e4b..d32adbb 100644 --- a/arch/arm/include/asm/memory.h +++

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 26.03.2014 00:36, schrieb Alexander Holler: Am 25.03.2014 19:38, schrieb Alexander Holler: reboot too. Another solution would be to unregister the reboot_notifier in the reboot_nofifier itself. I've just seen one watchdog driver (drivers/rtc/rtc-m41t80.c) which does that. But I still think

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 25.03.2014 19:38, schrieb Alexander Holler: reboot too. Another solution would be to unregister the reboot_notifier in the reboot_nofifier itself. I've just seen one watchdog driver (drivers/rtc/rtc-m41t80.c) which does that. But I still think such That, btw. is broken. ;) Right after

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Sebastian Capella
Hi Alexander, Thanks for your comments. I've posted a different solution for arm only here, that just causes a while loop in machine_power_off in the event it's called but does not halt. https://lkml.org/lkml/2014/3/24/299 On 25 March 2014 11:38, Alexander Holler wrote: > Both states, power

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 19.03.2014 22:06, schrieb Sebastian Capella: On 19 March 2014 13:47, Sebastian Capella wrote: diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index a5f702a..d96b910 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -594,7 +594,8 @@ static void

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 19.03.2014 22:06, schrieb Sebastian Capella: On 19 March 2014 13:47, Sebastian Capella sebastian.cape...@linaro.org wrote: diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index a5f702a..d96b910 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -594,7

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Sebastian Capella
Hi Alexander, Thanks for your comments. I've posted a different solution for arm only here, that just causes a while loop in machine_power_off in the event it's called but does not halt. https://lkml.org/lkml/2014/3/24/299 On 25 March 2014 11:38, Alexander Holler hol...@ahsoftware.de wrote:

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 25.03.2014 19:38, schrieb Alexander Holler: reboot too. Another solution would be to unregister the reboot_notifier in the reboot_nofifier itself. I've just seen one watchdog driver (drivers/rtc/rtc-m41t80.c) which does that. But I still think such That, btw. is broken. ;) Right after

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-25 Thread Alexander Holler
Am 26.03.2014 00:36, schrieb Alexander Holler: Am 25.03.2014 19:38, schrieb Alexander Holler: reboot too. Another solution would be to unregister the reboot_notifier in the reboot_nofifier itself. I've just seen one watchdog driver (drivers/rtc/rtc-m41t80.c) which does that. But I still think

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-24 Thread Sebastian Capella
Hi, I have no further changes here.. I will submit a separate patch to cover Ezequiel's concern. Any final comments? Otherwise, I'll submit to Russell's system. Thanks for the review! Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-24 Thread Sebastian Capella
Hi, I have no further changes here.. I will submit a separate patch to cover Ezequiel's concern. Any final comments? Otherwise, I'll submit to Russell's system. Thanks for the review! Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-20 Thread Sebastian Capella
Hi Tony, I have not used the tux-on-ice solution. The patchset I've sent is to add initial support for swsusp based hibernation for ARM. Can you please begin a new, separate thread for this? Ie. separate from the review for the swsusp hibernation patches I've submitted? I'm not sure where the

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-20 Thread Sebastian Capella
Hi Tony, I have not used the tux-on-ice solution. The patchset I've sent is to add initial support for swsusp based hibernation for ARM. Can you please begin a new, separate thread for this? Ie. separate from the review for the swsusp hibernation patches I've submitted? I'm not sure where the

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread TonyHo
Hi , I'm trying add the hibernation to Freescale imx6Q(Cortex-A9*4), and I use the patches from: http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/036055.html And the TuxOnIce patches:

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Sebastian Capella
On 19 March 2014 13:47, Sebastian Capella wrote: > diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c > index a5f702a..d96b910 100644 > --- a/kernel/power/hibernate.c > +++ b/kernel/power/hibernate.c > @@ -594,7 +594,8 @@ static void power_down(void) > case

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Sebastian Capella
On 19 March 2014 08:44, Ezequiel Garcia wrote: > Tested-by: Ezequiel Garcia Thanks! > On the other side, this board has no pm_power_off() support, which means > kernel_halt() is called after kernel_power_off(). > > I'm not sure if a NULL pm_power_off() is supported, but this makes my kernel >

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Ezequiel Garcia
On Mar 17, Sebastian Capella wrote: [..] > > Thanks, I've added it like this in arch/arm/Kconfig. I'm sure you > know, but this way also takes care of the CPU_FEROCEON in the default > list since SUSPEND_POSSIBLE already contains it. > > config ARCH_HIBERNATION_POSSIBLE > bool >

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Ezequiel Garcia
On Mar 17, Sebastian Capella wrote: [..] Thanks, I've added it like this in arch/arm/Kconfig. I'm sure you know, but this way also takes care of the CPU_FEROCEON in the default list since SUSPEND_POSSIBLE already contains it. config ARCH_HIBERNATION_POSSIBLE bool depends

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Sebastian Capella
On 19 March 2014 08:44, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Thanks! On the other side, this board has no pm_power_off() support, which means kernel_halt() is called after kernel_power_off(). I'm not sure if a

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread Sebastian Capella
On 19 March 2014 13:47, Sebastian Capella sebastian.cape...@linaro.org wrote: diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index a5f702a..d96b910 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -594,7 +594,8 @@ static void power_down(void)

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-19 Thread TonyHo
Hi , I'm trying add the hibernation to Freescale imx6Q(Cortex-A9*4), and I use the patches from: http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/036055.html And the TuxOnIce patches:

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
On 17 March 2014 13:44, Ezequiel Garcia wrote: > On Mar 17, Sebastian Capella wrote: >> On 16 March 2014 00:09, Ezequiel Garcia >> wrote: >> > On Mar 05, Sebastian Capella wrote: >> > [..] >> >> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig >> >> index 1f8fed9..83707702 100644 >> >> ---

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
Thanks Russell! On 16 March 2014 02:46, Russell King - ARM Linux wrote: > On Mon, Mar 10, 2014 at 11:32:17AM -0700, Sebastian Capella wrote: ... > Let's look at the implementations... > > #define __pa(x) __virt_to_phys((unsigned long)(x)) > static inline phys_addr_t

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Ezequiel Garcia
On Mar 17, Sebastian Capella wrote: > On 16 March 2014 00:09, Ezequiel Garcia > wrote: > > On Mar 05, Sebastian Capella wrote: > > [..] > >> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > >> index 1f8fed9..83707702 100644 > >> --- a/arch/arm/mm/Kconfig > >> +++ b/arch/arm/mm/Kconfig >

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
On 16 March 2014 00:09, Ezequiel Garcia wrote: > On Mar 05, Sebastian Capella wrote: > [..] >> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig >> index 1f8fed9..83707702 100644 >> --- a/arch/arm/mm/Kconfig >> +++ b/arch/arm/mm/Kconfig >> @@ -611,6 +611,11 @@ config CPU_USE_DOMAINS >>

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
On 16 March 2014 00:09, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: On Mar 05, Sebastian Capella wrote: [..] diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 1f8fed9..83707702 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -611,6 +611,11 @@ config

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Ezequiel Garcia
On Mar 17, Sebastian Capella wrote: On 16 March 2014 00:09, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: On Mar 05, Sebastian Capella wrote: [..] diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 1f8fed9..83707702 100644 --- a/arch/arm/mm/Kconfig +++

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
Thanks Russell! On 16 March 2014 02:46, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Mar 10, 2014 at 11:32:17AM -0700, Sebastian Capella wrote: ... Let's look at the implementations... #define __pa(x) __virt_to_phys((unsigned long)(x)) static inline

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-17 Thread Sebastian Capella
On 17 March 2014 13:44, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: On Mar 17, Sebastian Capella wrote: On 16 March 2014 00:09, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: On Mar 05, Sebastian Capella wrote: [..] diff --git a/arch/arm/mm/Kconfig

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-16 Thread Russell King - ARM Linux
On Mon, Mar 10, 2014 at 11:32:17AM -0700, Sebastian Capella wrote: > I've moved to this second implementation. I don't think I understand > the ramifications enough to add the virt_to_pfn call for arm. Let's look at the implementations... #define __pa(x) __virt_to_phys((unsigned

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-16 Thread Ezequiel Garcia
On Mar 05, Sebastian Capella wrote: [..] > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index 1f8fed9..83707702 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -611,6 +611,11 @@ config CPU_USE_DOMAINS > config IO_36 > bool > > +config

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-16 Thread Ezequiel Garcia
On Mar 05, Sebastian Capella wrote: [..] diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 1f8fed9..83707702 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -611,6 +611,11 @@ config CPU_USE_DOMAINS config IO_36 bool +config ARCH_HIBERNATION_POSSIBLE +

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-16 Thread Russell King - ARM Linux
On Mon, Mar 10, 2014 at 11:32:17AM -0700, Sebastian Capella wrote: I've moved to this second implementation. I don't think I understand the ramifications enough to add the virt_to_pfn call for arm. Let's look at the implementations... #define __pa(x) __virt_to_phys((unsigned

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-10 Thread Sebastian Capella
On 6 March 2014 20:42, Stephen Boyd wrote: > On 03/05, Sebastian Capella wrote: >> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h >> index 8756e4b..d32adbb 100644 >> --- a/arch/arm/include/asm/memory.h >> +++ b/arch/arm/include/asm/memory.h >> @@ -291,6 +291,7 @@

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-10 Thread Sebastian Capella
On 6 March 2014 20:42, Stephen Boyd sb...@codeaurora.org wrote: On 03/05, Sebastian Capella wrote: diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h index 8756e4b..d32adbb 100644 --- a/arch/arm/include/asm/memory.h +++ b/arch/arm/include/asm/memory.h @@ -291,6 +291,7

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-06 Thread Stephen Boyd
On 03/05, Sebastian Capella wrote: > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index 8756e4b..d32adbb 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -291,6 +291,7 @@ static inline void *phys_to_virt(phys_addr_t x) > */ >

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-06 Thread Sebastian Capella
Sorry to those receiving repeated emails, I'm having an issue with some of the special characters names. Quoting Sebastian Capella (2014-03-05 02:50:05) > From: Russ Dill > Enable hibernation for ARM architectures and provide ARM > architecture specific calls used during hibernation. ... Quoting

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-06 Thread Sebastian Capella
Sorry to those receiving repeated emails, I'm having an issue with some of the special characters names. Quoting Sebastian Capella (2014-03-05 02:50:05) From: Russ Dill russ.d...@ti.com Enable hibernation for ARM architectures and provide ARM architecture specific calls used during

Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-06 Thread Stephen Boyd
On 03/05, Sebastian Capella wrote: diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h index 8756e4b..d32adbb 100644 --- a/arch/arm/include/asm/memory.h +++ b/arch/arm/include/asm/memory.h @@ -291,6 +291,7 @@ static inline void *phys_to_virt(phys_addr_t x) */

[PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-05 Thread Sebastian Capella
From: Russ Dill Enable hibernation for ARM architectures and provide ARM architecture specific calls used during hibernation. The swsusp hibernation framework depends on the platform first having functional suspend/resume. Then, in order to enable hibernation on a given platform, a

[PATCH v7 2/2] ARM hibernation / suspend-to-disk

2014-03-05 Thread Sebastian Capella
From: Russ Dill russ.d...@ti.com Enable hibernation for ARM architectures and provide ARM architecture specific calls used during hibernation. The swsusp hibernation framework depends on the platform first having functional suspend/resume. Then, in order to enable hibernation on a given