Change all error-printing messages to include error name via %pe instead
of numeric error or nothing.
Signed-off-by: Michał Mirosław
---
drivers/regulator/core.c | 94 +---
1 file changed, 49 insertions(+), 45 deletions(-)
diff --git a/drivers/regulator/core.
- Convert from printk() to pr_*(),
- Add missing continuation.
Signed-off-by: Geert Uytterhoeven
Tested-by: Guenter Roeck
---
v2:
- Add Tested-by.
---
arch/sh/boards/board-sh2007.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sh/boards/board-sh2007.c b/arch
- Convert from printk() to pr_*(),
- Add missing continuations,
- Join broken messages.
Note that printk(KERN_DEBUG ...) is retained, to preserve behavior
(pr_debug() is a dummy if DEBUG is not defined).
Signed-off-by: Geert Uytterhoeven
Tested-by: Guenter Roeck
---
v2:
- Add Tested-by,
- Convert from printk() to pr_*(),
- Add missing continuations.
Signed-off-by: Geert Uytterhoeven
Tested-by: Guenter Roeck
---
v2:
- Add Tested-by.
---
arch/sh/kernel/machvec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/sh/kernel/machvec.c b/arch/sh/k
se lots of small bits of information to fly by your serial console.
Changes compared to v1[1]:
- Add Tested-by,
- Drop "sh: fault: Modernize printing of kernel messages", which was
picked up by Mike and Andrew, but subject to an unintended mutation,
- Add a fix for the mutation,
On Fri, Apr 24, 2020 at 4:14 PM Geert Uytterhoeven
wrote:
> Simplify the printing of kernel messages and make the messages more
> accurate by using the most appropriate {dev,chip,gpiod}_*() helpers.
>
> Sample impact:
>
> -gpiochip_setup_dev: registered GPIOs 496 to 511 on
On Fri, 2019-08-23 at 14:22:00 UTC, Qian Cai wrote:
> Booting a POWER9 PowerNV system generates a few messages below with
> "ptrval" due to the pointers printed without a specifier
> extension (i.e unadorned %p) are hashed to prevent leaking information
> about the kernel memory layout.
>
Michael, Aneesh, please take a take at this trivial patch.
On Fri, 2019-08-23 at 10:22 -0400, Qian Cai wrote:
> Booting a POWER9 PowerNV system generates a few messages below with
> "ptrval" due to the pointers printed without a specifier
> extension (i.e unadorned %p) are hashed to preven
Booting a POWER9 PowerNV system generates a few messages below with
"ptrval" due to the pointers printed without a specifier
extension (i.e unadorned %p) are hashed to prevent leaking information
about the kernel memory layout.
radix-mmu: Initializing Radix MMU
radix-mmu: Partition table (
This change is to fix lost and mess up of Kernel messages while restarting or
shutting down.
If the console lock is held by other CPU running while the system is restarting
or shutting down, the Kernel messages in the printk log buffer can not be
printed out to the console drivers. The Kernel
On Fri, 1 Jun 2018 12:31:44 +0200
Pavel Machek wrote:
> Hi!
>
> v4.17 on n900:
>
> [0.00] Virtual kernel memory layout:
> [0.00] vector : 0x - 0x1000 ( 4 kB)
> [0.00] fixmap : 0xffc0 - 0xfff0 (3072 kB)
> [0.00] vmalloc : 0x
On Fri 2018-06-01 13:49:41, Andy Shevchenko wrote:
> On Fri, Jun 1, 2018 at 1:31 PM, Pavel Machek wrote:
> > Hi!
> >
> > v4.17 on n900:
> >
> > [0.00] Virtual kernel memory layout:
> > [0.00] vector : 0x - 0x1000 ( 4 kB)
> > [0.00] fixmap : 0xffc00
On Fri, Jun 1, 2018 at 1:31 PM, Pavel Machek wrote:
> Hi!
>
> v4.17 on n900:
>
> [0.00] Virtual kernel memory layout:
> [0.00] vector : 0x - 0x1000 ( 4 kB)
> [0.00] fixmap : 0xffc0 - 0xfff0 (3072 kB)
> [0.00] vmalloc : 0xd
Hi!
v4.17 on n900:
[0.00] Virtual kernel memory layout:
[0.00] vector : 0x - 0x1000 ( 4 kB)
[0.00] fixmap : 0xffc0 - 0xfff0 (3072 kB)
[0.00] vmalloc : 0xd000 - 0xff80 ( 760 MB)
[0.00] lowmem : 0xc00
kernel messages split across multiple lines
Convert the clockevents driver from old-style printk() to pr_info() and
pr_cont(), to fix split kernel messages like below:
Clockevents: could not switch to one-shot mode:
dummy_timer is not functional.
Signed-off-by: Geert Uytterhoeven
From: Nicholas Piggin
[ Upstream commit 35adacd6fc48d658419522f192a3c8b2785612da ]
Platforms with a panic handler that halts the system can have problems
getting kernel messages out, because the panic notifiers are called
before kernel/panic.c does its flushing of printk buffers an console
etc
Convert the clockevents driver from old-style printk() to pr_info() and
pr_cont(), to fix split kernel messages like below:
Clockevents: could not switch to one-shot mode:
dummy_timer is not functional.
Signed-off-by: Geert Uytterhoeven
---
kernel/time/tick-oneshot.c | 11
Hi David,
> The bt_* printk macros include a \n already, so we don't need extra ones
> here.
>
> Signed-off-by: David Lechner
> ---
> drivers/bluetooth/hci_ll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
The bt_* printk macros include a \n already, so we don't need extra ones
here.
Signed-off-by: David Lechner
---
drivers/bluetooth/hci_ll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index 42142be..0f0a3a2 100644
Hi Geert,
Thanks for the patch.
On 28/11/17 13:01, Geert Uytterhoeven wrote:
> As of_node_full_name() now returns only the basename, the endpoint
> information printed became useless:
>
> adv748x 4-0070: Endpoint endpoint on port 7
> adv748x 4-0070: Endpoint endpoint on port 8
> adv7
Hi Geert,
Thanks for your patch.
On 2017-11-28 14:01:24 +0100, Geert Uytterhoeven wrote:
> As of_node_full_name() now returns only the basename, the endpoint
> information printed became useless:
>
> adv748x 4-0070: Endpoint endpoint on port 7
> adv748x 4-0070: Endpoint endpoint on port
As of_node_full_name() now returns only the basename, the endpoint
information printed became useless:
adv748x 4-0070: Endpoint endpoint on port 7
adv748x 4-0070: Endpoint endpoint on port 8
adv748x 4-0070: Endpoint endpoint on port 10
adv748x 4-0070: Endpoint endpoint on port 11
From: Geert Uytterhoeven
Convert from printk() to pr_*().
[Adjusted log message severity levels and retained bootinfo log. -- FT]
Signed-off-by: Finn Thain
---
arch/m68k/mac/config.c | 12 +---
arch/m68k/mac/misc.c | 23 +--
2 files changed, 14 insertions(+), 21
From: Geert Uytterhoeven
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Add missing continuations,
- Drop superfluous casts.
[Renamed pr_iop* macros, adjusted log message se
On Tue, Jan 10, 2017 at 05:33:38PM -0700, Logan Gunthorpe wrote:
> Now that macros are open it's pretty clear that these should print
> using the NTB struct device not the PCI one.
>
> Signed-off-by: Logan Gunthorpe
I believe that using the PCI dev here makes it more debugable, as this
is more r
On Thu, Feb 9, 2017 at 2:25 PM, Geert Uytterhoeven wrote:
> On Wed, Dec 7, 2016 at 4:08 PM, Geert Uytterhoeven
> wrote:
>> This patch series modernizes the printing of kernel messages in the m68k
>> architecture core, which is mainly about converting from printk() to
&g
On Wed, Dec 7, 2016 at 4:08 PM, Geert Uytterhoeven wrote:
> This patch series modernizes the printing of kernel messages in the m68k
> architecture core, which is mainly about converting from printk() to
> pr_*().
>
> The trigger for (finally) doing this was the user-visible break
Hi Michael,
On Sat, Dec 10, 2016 at 1:44 AM, Michael Schmitz wrote:
> Am 09.12.2016 um 01:22 schrieb Geert Uytterhoeven:
>> On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain
>> wrote:
>>> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
- Convert from printk() to pr_*(),
- Add missing cont
Now that macros are open it's pretty clear that these should print
using the NTB struct device not the PCI one.
Signed-off-by: Logan Gunthorpe
---
drivers/ntb/hw/amd/ntb_hw_amd.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/ntb/hw/amd/ntb_
Now that macros are open it's pretty clear that these should print
using the NTB struct device not the PCI one.
Signed-off-by: Logan Gunthorpe
---
drivers/ntb/hw/intel/ntb_hw_intel.c | 132 +---
1 file changed, 64 insertions(+), 68 deletions(-)
diff --git a/drive
Hi Geert,
Am 09.12.2016 um 01:22 schrieb Geert Uytterhoeven:
> On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain
> wrote:
>> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>>> - Convert from printk() to pr_*(),
>>> - Add missing continuations, to fix user-visible breakage,
>>> - Drop useless WARN
On Thu, 8 Dec 2016, I wrote:
>
> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>
> > - Convert from printk() to pr_*(),
> > - Add missing continuations,
> > - Remove #undef DEBUG.
> >
> > Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is
> > not optimized away when deb
Hi Finn, Geert,
On 08/12/16 08:53, Finn Thain wrote:
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Correct printf()-style for
Hi Geert,
On 08/12/16 01:09, Geert Uytterhoeven wrote:
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
Looks good to me, so:
Acked-by: Greg Ungerer
Regards
Greg
---
arch/m68k/68000/m68328.c | 6 +++---
arch/m68k/68000/m68EZ328.c | 6 +++---
arch/m68k/68000/m68VZ3
On Thu, 8 Dec 2016, Geert Uytterhoeven wrote:
> On Wed, Dec 7, 2016 at 11:45 PM, Finn Thain
> wrote:
> > On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> >
> >> - Introduce helpers for printing debug messages, incl. dummies for
> >> validating format strings when debugging is disabled,
> >
On Thu, 8 Dec 2016, Geert Uytterhoeven wrote:
> On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain
> wrote:
> > On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> >> - Convert from printk() to pr_*(),
> >> - Add missing continuations, to fix user-visible breakage,
> >> - Drop useless WARNING prefix
On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain wrote:
> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>> - Convert from printk() to pr_*(),
>> - Add missing continuations, to fix user-visible breakage,
>> - Drop useless WARNING prefix,
>> - Move trailing spaces to start of continuations.
>>
>
On Wed, Dec 7, 2016 at 11:45 PM, Finn Thain wrote:
> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>
>> - Introduce helpers for printing debug messages, incl. dummies for
>> validating format strings when debugging is disabled,
>> - Convert from printk() to pr_*(),
>> - Add missing conti
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Convert from printk() to pr_*(),
> - Add missing continuations,
> - Remove #undef DEBUG.
>
> Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is not
> optimized away when debugging is disabled.
>
I think that argues for us
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> Convert from printk() to pr_*().
>
> Signed-off-by: Geert Uytterhoeven
> ---
> arch/m68k/mac/config.c | 34 --
> arch/m68k/mac/misc.c | 8
> 2 files changed, 20 insertions(+), 22 deletions(-)
>
> diff
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Add missing continuations,
> - Drop superfluous casts.
>
> Signed-off-by
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> Convert from printk() to pr_*().
>
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Drop superfluous casts,
> - Add lin
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Add missing continuations,
> - Drop superfluous casts.
>
> Signed-off-by
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Drop superfluous casts.
>
> Signed-off-by: Geert Uytterhoeven
> ---
> ar
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Correct printf()-style format specifiers,
> - Drop superfluous casts,
>
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Add missing continuations, to fix user-visible breakage,
> - Drop superfl
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Add missing continuations, to fix user-visible breakage.
>
> Fixes: 4bcc59
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Convert from printk() to pr_*(),
> - Add missing continuations, to fix user-visible breakage,
> - Drop useless WARNING prefix,
> - Move trailing spaces to start of continuations.
>
> Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT f
- Convert from printk() to pr_*(),
- Add missing continuations,
- Do not print nonexistent len variable,
- Add missing sysname[] variable,
- Correct printf()-style format specifiers.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/sun3/config.c | 2 +-
arch/m68k/sun3/dvma.c
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Add missing continuations,
- Drop superfluous casts.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mac/psc.c | 32 ++
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Correct printf()-style format specifiers,
- Drop superfluous casts,
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/coldfire/m
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/bvme6000/config.c | 8
arch/m68k/bvme6000/rtc.c| 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68k/bvme6000/config.c b/arch/m68k/bvme6000/config.c
index 611d4d9ea2bd80ac..2c
b/arch/m68k/q40/config.c
index ea89a24f46000e4f..71c0867ecf20f201 100644
--- a/arch/m68k/q40/config.c
+++ b/arch/m68k/q40/config.c
@@ -84,7 +84,7 @@ static int __init q40_debug_setup(char *arg)
{
/* useful for early debugging stages - writes kernel messages into SRAM
*/
if
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Drop superfluous casts.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mac/baboon.c | 22 ++
1 file changed
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mvme16x/config.c | 32
arch/m68k/mvme16x/rtc.c| 2 +-
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/arch/m68k/mvme16x/config.c b/arch/m68k/mvme16x/config.c
in
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/68000/m68328.c | 6 +++---
arch/m68k/68000/m68EZ328.c | 6 +++---
arch/m68k/68000/m68VZ328.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/m68k/68000/m68328.c b/arch/m68k/68000/m6
- Convert from printk() to pr_*(),
- Add missing continuations, to fix user-visible breakage,
- Drop useless WARNING prefix,
- Move trailing spaces to start of continuations.
Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing continuation
lines")
Signed-off-by: Geert Uytte
- Convert from printk() to pr_*(),
- Add missing print to do_page_mapin(), as print_pte_vaddr() calls
pr_cont().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/include/asm/sun3_pgtable.h | 6 +++---
arch/m68k/mm/sun3kmap.c | 5 +++--
2 files changed, 6 insertions(+), 5 dele
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Add missing continuations,
- Drop superfluous casts.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mac/iop.c | 69 ++
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mm/init.c | 2 +-
arch/m68k/mm/memory.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/m68k/mm/init.c b/arch/m68k/mm/init.c
index b09a3cb29b68fda4..7f5dd339a311800e 100644
--- a/arch
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Add missing continuations, to fix user-visible breakage.
Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing contin
- Convert from printk() to pr_*(),
- Remove #undef DEBUG,
- Drop useless Warning prefix,
- Use TABs for indentation while at it.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/include/asm/sun3xflop.h | 14 +++---
arch/m68k/sun3x/dvma.c| 35 +--
- Convert from printk() to pr_*(),
- Add dummies for validating format strings when debugging is
disabled.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/include/asm/bug.h | 4 ++--
arch/m68k/include/asm/floppy.h | 6 +++---
arch/m68k/include/asm/math-emu.h | 10 +-
3 f
Hi all,
This patch series modernizes the printing of kernel messages in the m68k
architecture core, which is mainly about converting from printk() to
pr_*().
The trigger for (finally) doing this was the user-visible breakage
caused by commit 4bcc595ccd80decb ("printk: reinstate KERN
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mac/config.c | 34 --
arch/m68k/mac/misc.c | 8
2 files changed, 20 insertions(+), 22 deletions(-)
diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index e468
- Use pr_err_ratelimited() instead of deprecated printk_ratelimit(),
- Add dummies for validating format strings when debugging is
disabled,
- Convert from printk() to pr_*(),
- Correct printf()-style format specifiers.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/kernel/dma.c
- Convert from printk() to pr_*(),
- Add missing continuations,
- Remove #undef DEBUG.
Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is not
optimized away when debugging is disabled.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mm/kmap.c | 26
Convert from printk() to pr_*().
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/mvme147/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
index c11d38dfad08faa1..8778612d1f312d5c 100644
--- a/arch/m68k/mvme147/co
- Convert from printk() to pr_*(),
- Remove #undef DEBUG,
- Add missing continuations.
Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is not
optimized away when debugging is disabled.
Signed-off-by: Geert Uytterhoeven
---
arch/m68k/include/asm/motorola_pgtable.h | 6 +++
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Add missing continuations, to fix user-visible breakage,
- Drop superfluous casts.
Fixes: 4bcc595ccd80decb ("printk: reinstate K
Convert from printk() to pr_*().
- Introduce helpers for printing debug messages, incl. dummies for
validating format strings when debugging is disabled,
- Convert from printk() to pr_*(),
- Drop superfluous casts,
- Add linebreaks before opening braces of function bodies.
Signed-off-
On Wed, 7 Dec 2016 10:05:15 +0100, Geert Uytterhoeven
wrote:
> - Convert from printk() to pr_*(),
> - Add missing continuations, to fix user-visible breakage,
> - Drop superfluous casts (u64 has been unsigned long long on all
> architectures for many years).
Thank you. Good catch.
R
- Convert from printk() to pr_*(),
- Add missing continuations, to fix user-visible breakage,
- Drop superfluous casts (u64 has been unsigned long long on all
architectures for many years).
On rbtx4927, this restores the kernel output like:
-TX4927 SDRAMC --
- CR0:007e05
Gs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4
>> watchpoint registers.
>>
>> While this commit has been reverted in commit a0cba2179ea4c182 ("Revert
>> "printk: create pr_ functions""), it's still good practice to
>> terminate ke
:
>
> -No ATAGs?
> -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint
> registers.
> +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4
> watchpoint registers.
>
> While this commit has been reverted in commit a0cba2179ea4c182 ("Rever
Hi Joe,
On Tue, Aug 16, 2016 at 8:01 PM, Joe Perches wrote:
> On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote:
>> On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches wrote:
>> > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
>> > > Before commit 874f9c7da9a4acbc ("printk: crea
On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
>
> On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches wrote:
> >
> > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> > >
> > > Before commit 874f9c7da9a4acbc ("printk: create pr_
> > > functions"),
> > > pr_*() cal
Hi Joe,
On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches wrote:
> On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
>> Before commit 874f9c7da9a4acbc ("printk: create pr_ functions"),
>> pr_*() calls without a trailing newline characters would be printed with
>> a newline character appende
On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> Before commit 874f9c7da9a4acbc ("printk: create pr_ functions"),
> pr_*() calls without a trailing newline characters would be printed with
> a newline character appended, both on the console and in the output of
> the dmesg command.
H
oint and 4 watchpoint
registers.
While this commit has been reverted in commit a0cba2179ea4c182 ("Revert
"printk: create pr_ functions""), it's still good practice to
terminate kernel messages with newlines.
v2:
- Rebased
---
arch/arm/kernel/atags_proc.c | 2 +-
arch/arm/
ing RAM at 0x4000-0xc000 to
-0x7000Ignoring RAM at 0x0002-0x00024000
(!CONFIG_HIGHMEM)
While this commit has been reverted in commit a0cba2179ea4c182 ("Revert
"printk: create pr_ functions""), it's still good practic
The DW2102 DVB-S/S2 driver uses the info() logging function from
dvb-usb.h. This function already appends a newline to the provided log
message, causing the dmesg output from DW2102 to include blank lines.
Fix this by removing the newline in the calls to info().
Signed-off-by: Jonathan McDowell
of 256 the assignment of msg->facility in log_store()
implicitly truncates it to 0, i.e. LOG_KERN, allowing users of /dev/kmsg
to spoof kernel messages as shown below:
The following call...
# printf '<%d>Kernel panic - not syncing: beer empty\n' 0 >/dev/kmsg
...leads to t
multiple of 256 the assignment of msg->facility in log_store()
implicitly truncates it to 0, i.e. LOG_KERN, allowing users of /dev/kmsg
to spoof kernel messages as shown below:
The following call...
# printf '<%d>Kernel panic - not syncing: beer empty\n' 0 >/dev/kmsg
...
multiple of 256 the assignment of msg->facility in log_store()
implicitly truncates it to 0, i.e. LOG_KERN, allowing users of /dev/kmsg
to spoof kernel messages as shown below:
The following call...
# printf '<%d>Kernel panic - not syncing: beer empty\n' 0 >/dev/kmsg
...
a multiple of 256 the assignment of msg->facility in log_store()
implicitly truncates it to 0, i.e. LOG_KERN, allowing users of /dev/kmsg
to spoof kernel messages as shown below:
The following call...
# printf '<%d>Kernel panic - not syncing: beer empty\n' 0 >/dev/kmsg
...
multiple of 256 the assignment of msg->facility in log_store()
implicitly truncates it to 0, i.e. LOG_KERN, allowing users of /dev/kmsg
to spoof kernel messages as shown below:
The following call...
# printf '<%d>Kernel panic - not syncing: beer empty\n' 0 >/dev/kmsg
...
facility of 0 by abusing
the fact that the facility is stored in a u8 data type. By using a
facility which is a multiple of 256 the assignment of msg->facility in
log_store() implicitly truncates it to 0, i.e. LOG_KERN, allowing users
of /dev/kmsg to spoof kernel messages as shown below:
Standardize the various boot time messages printed during FPU detection:
- Use a common 'x86/fpu: ' prefix for consistency and to make it easy
to grep boot logs for FPU related messages
- Correct speling errors
- Add printout for the legacy FPU case as well
- Clarify messages
Reviewed-b
gus. String concatenation doesn't work like that.
>
> Try "%sFailed...", boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_ERR :
> KERN_INFO), etc.
Haha, indeed. The hypervisor message is empty in this case. Wei, test
this much? ;-)
---
Subject: perf: Fix bogus kernel printk
Andy spotted
r: Ingo Molnar
> CommitDate: Fri, 3 Oct 2014 06:04:41 +0200
>
> perf/x86: Tone down kernel messages when the PMU check fails in a virtual
> environment
>
> PMU checking can fail due to various reasons. On native machine, this
> is mostly caused by faulty hardware and it is reaso
Commit-ID: cc6cd47e7395bc05c5077009808b820633eb3f18
Gitweb: http://git.kernel.org/tip/cc6cd47e7395bc05c5077009808b820633eb3f18
Author: Wei Huang
AuthorDate: Wed, 24 Sep 2014 22:55:14 -0500
Committer: Ingo Molnar
CommitDate: Fri, 3 Oct 2014 06:04:41 +0200
perf/x86: Tone down kernel
Hi all,
This patch set adds context information to kernel messages from /dev/kmsg.
Two printk messages connected with KERN_CONT can be divided in multiple
lines by a different process context message. This induces two problems.
a) The owner problem
If the different context message seems like
Hi Hannes,
We want to handle the error message in userland for HA clusters, so the
error messages should be output in single(atomic) line. However, current
upstream kernel outputs SCSI error messages in multiple lines, so
current implementation is inconvenient. Even if human reads the error
messag
Hi!
I have a kind of trivial suggestion for improving the kernel messages for
ext3-fs mounts to be more consistent and useful:
Most messages for ext3-mounting include the device, like:
kernel: [ 823.233892] EXT3-fs (dm-7): using internal journal
kernel: [ 823.233899] EXT3-fs (dm-7): mounted
Use 'platform_device' in kernel messages rather than i2c client
device node.
lp8788_update_charger_params() needs additional argument, 'pdev'.
Then, remove unnecessary lp8788 private data in lp8788_irq_register().
Signed-off-by: Milo(Woogyom) Kim
---
drivers/power/lp8
On Sat, 22 Dec 2007 15:04:16 +0100
Benny Amorsen <[EMAIL PROTECTED]> wrote:
> It is a bit of a mystery why the kernel is ordering me to initialize
> the current offset of xfs_file_readdir though. I don't know how to do
> that, so I guess it's lucky that I don't use XFS. Who knows what would
> happe
[EMAIL PROTECTED] (Lennart Sorensen) writes:
> On Fri, Dec 21, 2007 at 12:55:16PM +0100, Jan Engelhardt wrote:
>> o_O I better continue believing it is the subject. Because with
>> one extra word at the front, you can make this a "complete sentence":
>>
>> Please initialize [the] current of
On Fri, Dec 21, 2007 at 12:55:16PM +0100, Jan Engelhardt wrote:
> o_O I better continue believing it is the subject. Because with
> one extra word at the front, you can make this a "complete sentence":
>
> Please initialize [the] current offset in xfs_file_readdir.
That still looks like an
On Thu, Dec 20, 2007 at 01:43:04PM -0800, Joe Perches wrote:
> Documentation/Coding Style
>
> Chapter 13: Printing kernel messages
>
> Kernel messages do not have to be terminated with a period.
'do not have to' does not mean 'should not'.
1 - 100 of 268 matches
Mail list logo
