Re: [PATCH 0/8] Introduce simple hazard pointers for lockdep

2025-06-26 Thread Boqun Feng
On Thu, Jun 26, 2025 at 03:16:49AM -0700, Christoph Hellwig wrote: > On Wed, Jun 25, 2025 at 07:08:57AM -0700, Boqun Feng wrote: > > Sure, I will put one for the future version, here is the gist: > > Thanks a lot! > > > The updater's wait can finish immediately if no one is accessing 'a', in > >

Re: [PATCH net 1/4] virtio-net: ensure the received length does not exceed allocated size

2025-06-26 Thread Bui Quang Minh
On 6/26/25 09:34, Jason Wang wrote: On Thu, Jun 26, 2025 at 12:10 AM Bui Quang Minh wrote: In xdp_linearize_page, when reading the following buffers from the ring, we forget to check the received length with the true allocate size. This can lead to an out-of-bound read. This commit adds that mi

Re: [PATCH net-next v5] page_pool: import Jesper's page_pool benchmark

2025-06-26 Thread Jakub Kicinski
On Wed, 25 Jun 2025 17:22:56 -0700 Mina Almasry wrote: > What I'm hoping to do is: > > 1. Have nipa run the benchmark always (or at least on patches that > touch pp code, if that's possible), and always succeed. > 2. The pp reviewers can always check the contest results to manually > see if there

Re: [PATCH rc v2 0/4] Fix iommufd selftest FAIL and warnings with v6.16

2025-06-26 Thread Jason Gunthorpe
On Tue, Jun 24, 2025 at 11:00:44AM -0700, Nicolin Chen wrote: > A few selftest harness changes being merged to v6.16, which exposed some > bugs and vulnerabilities in the iommufd selftest code. Fix them properly. > > Note that the patch fixing the build warnings at mfd is not ideal, as it > has po

Re: [PATCH] selftests: harness: Rework is_signed_type() to avoid collision with overflow.h

2025-06-26 Thread Vincent Mailhol
On 25/06/2025 at 08:19, Sean Christopherson wrote: > Rename is_signed_type() to is_signed_var() to avoid colliding with a macro > of the same name defined by linux/overflow.h. Note, overflow.h's version > takes a type as the input, whereas the harness's version takes a variable! > > This fixes wa

Re: [PATCH v4] arm64: Implement HAVE_LIVEPATCH

2025-06-26 Thread Song Liu
Hi Will, Thanks for your kind review! On Thu, Jun 26, 2025 at 6:21 AM Will Deacon wrote: > > On Tue, Jun 17, 2025 at 10:37:34AM -0700, Song Liu wrote: > > This is largely based on [1] by Suraj Jitindar Singh. > > I think it would be useful to preserve at least some parts of the > original commit

Re: [PATCH 1/5] torture: Remove support for SRCU-lite

2025-06-26 Thread Paul E. McKenney
On Thu, Jun 26, 2025 at 04:03:32AM -0700, Christoph Hellwig wrote: > On Thu, Jun 26, 2025 at 03:54:06AM -0700, Paul E. McKenney wrote: > > How about if I add this to the cover letter? > > Sounds good. But please also have a very short summary in the > actual commits. As-is the commit logs comple

Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-06-26 Thread Peter Xu
On Thu, Jun 26, 2025 at 10:52:39AM +0530, Ujwal Kundur wrote: > > Ujwal, can you reproduce these issues and have a look? > > > The script I mentioned in that other mail should help with this > > Sorry about the delay, I'll try to reproduce this over the weekend and > send a v6 over. > Will rebase

Re: [PATCH 0/8] Introduce simple hazard pointers for lockdep

2025-06-26 Thread Mathieu Desnoyers
On 2025-06-26 06:16, Christoph Hellwig wrote: On Wed, Jun 25, 2025 at 07:08:57AM -0700, Boqun Feng wrote: Sure, I will put one for the future version, here is the gist: Thanks a lot! The updater's wait can finish immediately if no one is accessing 'a', in other words it doesn't need to wait

Re: [PATCH 4/8] shazptr: Avoid synchronize_shaptr() busy waiting

2025-06-26 Thread Frederic Weisbecker
Le Wed, Jun 25, 2025 at 08:24:53AM -0700, Boqun Feng a écrit : > On Wed, Jun 25, 2025 at 03:56:05PM +0200, Frederic Weisbecker wrote: > > Le Tue, Jun 24, 2025 at 08:10:57PM -0700, Boqun Feng a écrit : > > > +static void synchronize_shazptr_normal(void *ptr) > > > +{ > > > + int cpu; > > > + unsigne

Re: [RFC PATCH 14/20] cxl/region: Add cxl pmem region creation routine for region persistency

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:43AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:38 +0530 Neeraj Kumar wrote: Added exported cxl_create_pmem_region routine to create cxl pmem region For function names always add () after and drop 'function/routine' etc. Ends up shorter and easier to read. Sure, Wil

Re: [RFC PATCH 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem

2025-06-26 Thread Neeraj Kumar
>"regions":[ > { >"region":"region0", >"resource":45365592064, >"size":536870912, > "type":"pmem", >"interleave_ways":

Re: [RFC PATCH 19/20] cxl/pmem_region: Prep patch to accommodate pmem_region attributes

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:53AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:43 +0530 Neeraj Kumar wrote: Created a separate file core/pmem_region.c along with CONFIG_PMEM_REGION Moved pmem_region related code from core/region.c to core/pmem_region.c For region label update, need to create device at

Re: [RFC PATCH 20/20] cxl/pmem_region: Add cxl region label updation and deletion device attributes

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:56AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:44 +0530 Neeraj Kumar wrote: Using these attributes region label is added/deleted into LSA. These attributes are called from userspace (ndctl) after region creation. These need documentation. Documentation/ABI/testing/sys

Re: [RFC PATCH 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in cxl pmem

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:48AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:42 +0530 Neeraj Kumar wrote: Add support of cxl lsa 2.1 using NDD_CXL_LABEL flag. It also creates cxl region based on region information parsed from LSA. Signed-off-by: Neeraj Kumar --- drivers/cxl/pmem.c | 59 ++

Re: [RFC PATCH 08/20] nvdimm/label: Include region label in slot validation

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:13AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:32 +0530 Neeraj Kumar wrote: slot validation routine validates label slot by calculating label checksum. It was only validating namespace label. This changeset also validates region label if present. Also validate and calc

Re: [RFC PATCH 15/20] cxl: Add a routine to find cxl root decoder on cxl bus

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:44AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:39 +0530 Neeraj Kumar wrote: Add cxl_find_root_decoder to find root decoder on cxl bus. It is used to find root decoder during region creation Signed-off-by: Neeraj Kumar --- drivers/cxl/core/port.c | 26

Re: [RFC PATCH 12/20] nvdimm/namespace_label: Skip region label during namespace creation

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:17AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:36 +0530 Neeraj Kumar wrote: During namespace creation skip presence of region label if present. Also preserve region label into labels list if present. Signed-off-by: Neeraj Kumar --- drivers/nvdimm/namespace_devs.c | 4

Re: [RFC PATCH 13/20] cxl/mem: Refactor cxl pmem region auto-assembling

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:20AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:37 +0530 Neeraj Kumar wrote: In 84ec985944ef3, For cxl pmem region auto-assembly after endpoint port probing, cxl_nvd presence was required. And for cxl region persistency, region creation happens during nvdimm_probe which

Re: [PATCH v4] arm64: Implement HAVE_LIVEPATCH

2025-06-26 Thread Will Deacon
On Tue, Jun 17, 2025 at 10:37:34AM -0700, Song Liu wrote: > This is largely based on [1] by Suraj Jitindar Singh. I think it would be useful to preserve at least some parts of the original commit message here so that folks don't have to pull it out of the list archives if they want to see more abo

Re: [RFC PATCH 07/20] nvdimm/namespace_label: Update namespace init_labels and its region_uuid

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:11AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:31 +0530 Neeraj Kumar wrote: nd_mapping->labels maintains the list of labels present into LSA. init_labels function prepares this list while adding new label init_labels() prepares Thanks, Will fix it up into LSA a

Re: [RFC PATCH 06/20] nvdimm/region_label: Add region label deletion routine

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:09AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:30 +0530 Neeraj Kumar wrote: Added cxl v2.1 format region label deletion routine. This function is used to delete region label from LSA Signed-off-by: Neeraj Kumar --- drivers/nvdimm/label.c | 75 +++

Re: [RFC PATCH 05/20] nvdimm/region_label: Add region label updation routine

2025-06-26 Thread Neeraj Kumar
On 23/06/25 10:05AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:29 +0530 Neeraj Kumar wrote: Add region label update routine Added __pmem_region_label_update region label update routine to update region label Signed-off-by: Neeraj Kumar A few trivial comments inline. Jonathan --

Re: [RFC PATCH 01/20] nvdimm/label: Introduce NDD_CXL_LABEL flag to set cxl label format

2025-06-26 Thread Neeraj Kumar
On 20/06/25 05:40PM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:25 +0530 Neeraj Kumar wrote: NDD_CXL_LABEL is introduced to set cxl LSA 2.1 label format Accordingly updated label index version Signed-off-by: Neeraj Kumar A few local comments. I'll need to read on to figure out how t

Re: [RFC PATCH 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

2025-06-26 Thread Neeraj Kumar
On 23/06/25 11:53AM, Jonathan Cameron wrote: On Tue, 17 Jun 2025 18:09:26 +0530 Neeraj Kumar wrote: In order to accommodate cxl lsa 2.1 format region label, renamed nd_namespace_label to nd_lsa_label. I would add some more information on why. I've no idea from this description whether the i

Re: [PATCH net-next v2 2/4] selftests: drv-net: Improve bpftrace utility error handling

2025-06-26 Thread Breno Leitao
On Wed, Jun 25, 2025 at 02:48:16PM -0700, Jakub Kicinski wrote: > On Wed, 25 Jun 2025 04:39:47 -0700 Breno Leitao wrote: > > cmd_obj = cmd(cmd_arr, ns=ns, host=host, shell=False) > > +if cmd_obj.ret != 0: > > +raise Exception("Warning: bpftrace command returned a non-zero > > exit

Re: [PATCH net-next v2 3/4] selftests: drv-net: Strip '@' prefix from bpftrace map keys

2025-06-26 Thread Breno Leitao
On Wed, Jun 25, 2025 at 03:07:10PM -0700, Jakub Kicinski wrote: > On Wed, 25 Jun 2025 04:39:48 -0700 Breno Leitao wrote: > > The '@' prefix in bpftrace map keys is specific to bpftrace and can be > > safely removed when processing results. This patch modifies the bpftrace > > utility to strip the '

Re: [PATCH RFT v17 3/8] selftests: Provide helper header for shadow stack testing

2025-06-26 Thread Catalin Marinas
On Mon, Jun 09, 2025 at 01:54:04PM +0100, Mark Brown wrote: > While almost all users of shadow stacks should be relying on the dynamic > linker and libc to enable the feature there are several low level test > programs where it is useful to enable without any libc support, allowing > testing withou

Re: [PATCH 2/2] rust: drop unnecessary lints caught by `#[expect(...)]`

2025-06-26 Thread Miguel Ojeda
On Thu, Jun 26, 2025 at 12:06 PM Onur Özkan wrote: > > -#[expect(clippy::unnecessary_cast)] We should avoid converting them into `expect` in the previous patch, because then it would break the build between the commits (it is not too critical if it is a Clippy one, but we still aim to kee

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 12:17, Vladimir Zapolskiy wrote: What's about MSM8953 then? Should be fixed up to match 8916. We don't have an upstream user and we, I, did the wrong thing. Please see commit c830aff08d51 ("media: dt-bindings: Add qcom,msm8953- camss"). x1e has a particular order if a new de

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Vladimir Zapolskiy
On 6/26/25 13:48, Bryan O'Donoghue wrote: On 26/06/2025 11:28, Krzysztof Kozlowski wrote: On 26/06/2025 12:19, Bryan O'Donoghue wrote: On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussi

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254

Re: [PATCH 1/5] torture: Remove support for SRCU-lite

2025-06-26 Thread Christoph Hellwig
On Thu, Jun 26, 2025 at 03:54:06AM -0700, Paul E. McKenney wrote: > How about if I add this to the cover letter? Sounds good. But please also have a very short summary in the actual commits. As-is the commit logs completly fail explain to the why, which is the most important part of a commit log

Re: [PATCH v5 2/4] media: qcom: camss: Add support for MSM8939

2025-06-26 Thread Vladimir Zapolskiy
Hello Vincent. On 6/13/25 12:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht The camera subsystem for the MSM8939 is the same as MSM8916 except with 3 CSID instead of 2, and some higher clock rates. As a quirk, this SoC needs writing values to 2 VFE VBIF registers (see downstream

Re: [PATCH 1/5] torture: Remove support for SRCU-lite

2025-06-26 Thread Paul E. McKenney
On Wed, Jun 25, 2025 at 05:05:47AM -0700, Christoph Hellwig wrote: > On Tue, Jun 24, 2025 at 09:13:56AM -0700, Paul E. McKenney wrote: > > Because SRCU-lite is being replaced by SRCU-fast, this commit removes > > support for SRCU-lite from refscale.c. > > Please explain how they different and why

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 11:28, Krzysztof Kozlowski wrote: On 26/06/2025 12:19, Bryan O'Donoghue wrote: On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussions - this is not sorted by name. Keep the

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 26/06/2025 12:19, Bryan O'Donoghue wrote: > On 26/06/2025 11:00, Krzysztof Kozlowski wrote: >>> + reg-names: >>> +items: >>> + - const: csi_clk_mux >> No, I already provided arguments in two lengthy discussions - this is >> not sorted by name. >> >> Keep the same order as in previous d

Re: [PATCH net-next v2 4/4] selftests: net: add netpoll basic functionality test

2025-06-26 Thread Breno Leitao
On Wed, Jun 25, 2025 at 03:09:19PM -0700, Jakub Kicinski wrote: > On Wed, 25 Jun 2025 04:39:49 -0700 Breno Leitao wrote: > > +raise KsftSkipEx("netpoll_poll_dev() was not called. Skipping test") > > Let's make this an Xfail. Looks like the condition doesn't trigger > in VM testing :( Exactly

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussions - this is not sorted by name. Keep the same order as in previous device, so msm8916 for example. Or any other, but listen to some req

Re: [PATCH 2/2] rust: drop unnecessary lints caught by `#[expect(...)]`

2025-06-26 Thread Onur
On Thu, 26 Jun 2025 13:04:48 +0300 Onur Özkan wrote: > From: onur-ozkan > > They are no longer needed. > > Signed-off-by: onur-ozkan Oh crap... This should be "Onur Özkan" not "onur-ozkan". I forgot to update that in my 2nd computer, which was used to send this patch.

Re: [PATCH 0/8] Introduce simple hazard pointers for lockdep

2025-06-26 Thread Christoph Hellwig
On Wed, Jun 25, 2025 at 07:08:57AM -0700, Boqun Feng wrote: > Sure, I will put one for the future version, here is the gist: Thanks a lot! > The updater's wait can finish immediately if no one is accessing 'a', in > other words it doesn't need to wait for reader 2. So basically it is the RCU con

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Vincent Knecht > --- Also, still incorrect order of patches. Bind

Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 06/06/2025 12:46, Vladimir Zapolskiy wrote: > Hello Vincent. > > On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote: >> From: Vincent Knecht >> >> Add bindings for qcom,msm8939-camss in order to support the camera >> subsystem for MSM8939. >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski Drop, you did here some unusual changes. > Signed-off-by: Vincent Knecht > --- >

Re: [PATCH 12/16] MAINTAINERS: Include dmesg.py under PRINTK entry

2025-06-26 Thread John Ogness
On 2025-06-25, Florian Fainelli wrote: > Include the GDB scripts file under scripts/gdb/linux/dmesg.py under the > PRINTK subsystem since it parses internal data structures that depend > upon that subsystem. > > Signed-off-by: Florian Fainelli > --- > MAINTAINERS | 1 + > 1 file changed, 1 inser

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-26 Thread Dmitry Vyukov
On Thu, 26 Jun 2025 at 10:32, Dmitry Vyukov wrote: > > On Wed, 25 Jun 2025 at 17:55, Sasha Levin wrote: > > > > On Wed, Jun 25, 2025 at 10:52:46AM +0200, Dmitry Vyukov wrote: > > >On Tue, 24 Jun 2025 at 22:04, Sasha Levin wrote: > > > > > >> >6. What's the goal of validation of the input argumen

Re: [PATCH] selftests: net: fix resource leak in napi_id_helper.c

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 09:03:07PM +0530, Malaya Kumar Rout wrote: > Resolve minor resource leaks reported by cppcheck in napi_id_helper.c > > cppcheck output before this patch: > tools/testing/selftests/drivers/net/napi_id_helper.c:37:3: error: Resource > leak: server [resourceLeak] > tools/test

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-26 Thread Dmitry Vyukov
On Wed, 25 Jun 2025 at 17:55, Sasha Levin wrote: > > On Wed, Jun 25, 2025 at 10:52:46AM +0200, Dmitry Vyukov wrote: > >On Tue, 24 Jun 2025 at 22:04, Sasha Levin wrote: > > > >> >6. What's the goal of validation of the input arguments? > >> >Kernel code must do this validation anyway, right. > >>

Re: [PATCH net-next v2 4/4] selftests: net: add netpoll basic functionality test

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 04:39:49AM -0700, Breno Leitao wrote: > Add a basic selftest for the netpoll polling mechanism, specifically > targeting the netpoll poll() side. > > The test creates a scenario where network transmission is running at > maximum speed, and netpoll needs to poll the NIC. Thi

Re: [PATCH net-next v2 0/4] selftest: net: Add selftest for netpoll

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 02:46:04PM -0700, Jakub Kicinski wrote: > On Wed, 25 Jun 2025 19:43:46 +0100 Simon Horman wrote: > > # # Exception| Traceback (most recent call last): > > # # Exception| File > > "/home/virtme/testing-17/tools/testing/selftests/net/lib/py/ksft.py", line > > 243, in ksft_

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Donet Tom
On Thu, Jun 26, 2025 at 12:05:11PM +0530, Dev Jain wrote: > > On 26/06/25 11:12 am, Donet Tom wrote: > > On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: > > > On 25/06/25 10:47 pm, Donet Tom wrote: > > > > On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: > > > > > On 19/06/25 1:

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 26/06/25 11:12 am, Donet Tom wrote: On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote:

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 26/06/25 11:12 am, Donet Tom wrote: On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote:

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Donet Tom
On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: > > On 25/06/25 10:47 pm, Donet Tom wrote: > > On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: > > > On 19/06/25 1:53 pm, Donet Tom wrote: > > > > On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: > > > > > On 18/06/25 8:0

Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-06-25 Thread Ujwal Kundur
> Ujwal, can you reproduce these issues and have a look? > The script I mentioned in that other mail should help with this Sorry about the delay, I'll try to reproduce this over the weekend and send a v6 over. Will rebase on Peter's patch [1] if it's been applied to mm-new already. [1] https://l

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wro

Re: [PATCH] selftests/mm: remove duplicate .gitignore entries

2025-06-25 Thread Dev Jain
On 26/06/25 7:37 am, Moon Hee Lee wrote: Remove redundant entries in .gitignore confirmed by: $ sort tools/testing/selftests/mm/.gitignore | uniq -d hugetlb_dio pkey_sighandler_tests_32 pkey_sighandler_tests_64 These entries were originally added by [1], and later duplicated by [2]. [1] htt

Re: [PATCH net 4/4] virtio-net: allow more allocated space for mergeable XDP

2025-06-25 Thread Jason Wang
On Thu, Jun 26, 2025 at 12:10 AM Bui Quang Minh wrote: > > When the mergeable receive buffer is prefilled before XDP is set, it > does not reserve the space for XDP_PACKET_HEADROOM and skb_shared_info. > So when XDP is set and this buffer is used to receive frame, we need to > create a new buffer

Re: [PATCH v3 0/5] remoteproc: imx_rproc: Support i.MX95

2025-06-25 Thread Peng Fan
protocol) >> imx-boot-imx95-19x19-lpddr5-evk-sd.bin-flash_a55 (M7 not under A55 control) >> imx-boot-imx95-19x19-lpddr5-evk-sd.bin-flash_all (M7 not under A55 control) >> >> Patchset was tested again with rebase on next-20250623 >> >> Patchset is re-based on next-20250

Re: [PATCH net 3/4] virtio-net: create a helper to check received mergeable buffer's length

2025-06-25 Thread Jason Wang
On Thu, Jun 26, 2025 at 12:10 AM Bui Quang Minh wrote: > > Currently, we have repeated code to check the received mergeable buffer's > length with allocated size. This commit creates a helper to do that and > converts current code to use it. > > Signed-off-by: Bui Quang Minh I think it would be

Re: [PATCH net 2/4] virtio-net: remove redundant truesize check with PAGE_SIZE

2025-06-25 Thread Jason Wang
On Thu, Jun 26, 2025 at 12:10 AM Bui Quang Minh wrote: > > The truesize is guaranteed not to exceed PAGE_SIZE in > get_mergeable_buf_len(). It is saved in mergeable context, which is not > changeable by the host side, This really depends on the security model. > so the check in receive path is q

Re: [PATCH net 1/4] virtio-net: ensure the received length does not exceed allocated size

2025-06-25 Thread Jason Wang
On Thu, Jun 26, 2025 at 12:10 AM Bui Quang Minh wrote: > > In xdp_linearize_page, when reading the following buffers from the ring, > we forget to check the received length with the true allocate size. This > can lead to an out-of-bound read. This commit adds that missing check. > > Fixes: 4941d47

Re: [PATCH 1/2] remoteproc: imx_dsp_rproc: Add support of recovery process

2025-06-25 Thread Shengjiu Wang
On Wed, Jun 25, 2025 at 10:39 PM Mathieu Poirier wrote: > > On Tue, 24 Jun 2025 at 21:25, Shengjiu Wang wrote: > > > > On Mon, Jun 23, 2025 at 11:11 PM Mathieu Poirier > > wrote: > > > > > > Good day, > > > > > > On Wed, Jun 18, 2025 at 02:26:43PM +0800, Shengjiu Wang wrote: > > > > when recover

Re: [PATCH net-next v5] page_pool: import Jesper's page_pool benchmark

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 16:45:49 -0700 Mina Almasry wrote: > Thank you for merging this. Kinda of a noob question: does this merge > mean that nipa will run this on new submitted patches already? Or do > I/someone need to do something to enable that? I've been clicking on > the contest for new patches

Re: [PATCH net-next v5] page_pool: import Jesper's page_pool benchmark

2025-06-25 Thread Mina Almasry
On Mon, Jun 23, 2025 at 6:19 PM wrote: > > Hello: > > This patch was applied to netdev/net-next.git (main) > by Jakub Kicinski : > > On Thu, 19 Jun 2025 18:15:18 + you wrote: > > From: Jesper Dangaard Brouer > > > > We frequently consult with Jesper's out-of-tree page_pool benchmark to > > ev

Re: [PATCH net-next v5] page_pool: import Jesper's page_pool benchmark

2025-06-25 Thread Mina Almasry
On Wed, Jun 25, 2025 at 5:03 PM Jakub Kicinski wrote: > > On Wed, 25 Jun 2025 16:45:49 -0700 Mina Almasry wrote: > > Thank you for merging this. Kinda of a noob question: does this merge > > mean that nipa will run this on new submitted patches already? Or do > > I/someone need to do something to

Re: [PATCH net-next v2 4/4] selftests: net: add netpoll basic functionality test

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 04:39:49 -0700 Breno Leitao wrote: > +raise KsftSkipEx("netpoll_poll_dev() was not called. Skipping test") Let's make this an Xfail. Looks like the condition doesn't trigger in VM testing :(

Re: [PATCH net-next v2 1/4] selftests: drv-net: add helper/wrapper for bpftrace

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 04:39:46 -0700 Breno Leitao wrote: > From: Jakub Kicinski > > bpftrace is very useful for low level driver testing. perf or trace-cmd > would also do for collecting data from tracepoints, but they require > much more post-processing. > > Add a wrapper for running bpftrace and

Re: [PATCH net-next v2 3/4] selftests: drv-net: Strip '@' prefix from bpftrace map keys

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 04:39:48 -0700 Breno Leitao wrote: > The '@' prefix in bpftrace map keys is specific to bpftrace and can be > safely removed when processing results. This patch modifies the bpftrace > utility to strip the '@' from map keys before storing them in the result > dictionary, making

Re: [PATCH net-next v2 0/4] selftest: net: Add selftest for netpoll

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 19:43:46 +0100 Simon Horman wrote: > # # Exception| Traceback (most recent call last): > # # Exception| File > "/home/virtme/testing-17/tools/testing/selftests/net/lib/py/ksft.py", line > 243, in ksft_run > # # Exception| case(*args) > # # Exception| File > "/home/vir

Re: [PATCH net-next v2 2/4] selftests: drv-net: Improve bpftrace utility error handling

2025-06-25 Thread Jakub Kicinski
On Wed, 25 Jun 2025 04:39:47 -0700 Breno Leitao wrote: > cmd_obj = cmd(cmd_arr, ns=ns, host=host, shell=False) > +if cmd_obj.ret != 0: > +raise Exception("Warning: bpftrace command returned a non-zero exit > code.") cmd should already raise CmdExitFailure, unless fail=False / fai

Re: [PATCH RFC net v2 3/3] vsock: Fix IOCTL_VM_SOCKETS_GET_LOCAL_CID to check also `transport_local`

2025-06-25 Thread Michal Luczaj
On 6/25/25 10:54, Stefano Garzarella wrote: > On Fri, Jun 20, 2025 at 09:52:45PM +0200, Michal Luczaj wrote: >> Support returning VMADDR_CID_LOCAL in case no other vsock transport is >> available. >> >> Fixes: 0e12190578d0 ("vsock: add local transport support in the vsock core") >> Suggested-by: St

Re: [PATCH RFC net v2 1/3] vsock: Fix transport_{g2h,h2g} TOCTOU

2025-06-25 Thread Michal Luczaj
On 6/25/25 10:43, Stefano Garzarella wrote: > On Fri, Jun 20, 2025 at 09:52:43PM +0200, Michal Luczaj wrote: >> vsock_find_cid() and vsock_dev_do_ioctl() may race with module unload. >> transport_{g2h,h2g} may become NULL after the NULL check. >> >> Introduce vsock_transport_local_cid() to protect

Re: [PATCH 0/3] Add support for PMXR2230 PMIC

2025-06-25 Thread Dmitry Baryshkov
On Wed, Jun 25, 2025 at 05:01:29PM +0200, Luca Weiss wrote: > On Wed Jun 25, 2025 at 4:25 PM CEST, Dmitry Baryshkov wrote: > > On Wed, Jun 25, 2025 at 11:18:36AM +0200, Luca Weiss wrote: > >> The PMXR2230 PMIC is used in conjuction with SM7635. Add binding docs > >> and the devicetree description f

Re: [PATCH 4/4] phy: qualcomm: phy-qcom-eusb2-repeater: Add support for PMIV0104

2025-06-25 Thread Abel Vesa
On 25-06-25 11:14:59, Luca Weiss wrote: > Add support for the eUSB2 repeater found on the PMIV0104. There is no > default init table for this PMIC, just the board-specific tuning > parameters are used on top of the default tuning values. > > Signed-off-by: Luca Weiss Reviewed-by: Abel Vesa

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-25 Thread Sasha Levin
On Wed, Jun 25, 2025 at 10:56:04AM +0200, Dmitry Vyukov wrote: On Tue, 24 Jun 2025 at 22:04, Sasha Levin wrote: >9. I see that syscalls and ioctls say: >KAPI_CONTEXT(KAPI_CTX_PROCESS | KAPI_CTX_SLEEPABLE) >Can't we make this implicit? Are there any other options? Maybe? I wasn't sure how we'd

Re: [PATCH 0/8] Introduce simple hazard pointers for lockdep

2025-06-25 Thread Boqun Feng
On Wed, Jun 25, 2025 at 08:25:52AM -0400, Mathieu Desnoyers wrote: > On 2025-06-24 23:10, Boqun Feng wrote: > > Hi, > > > > This is the official first version of simple hazard pointers following > > the RFC: > > > > > > https://lore.kernel.org/lkml/20250414060055.341516-1-boqun.f...@gmail.co

Re: [PATCH RFC 11/14] mm: remove "horrible special case to handle copy-on-write behaviour"

2025-06-25 Thread David Hildenbrand
On 17.06.25 17:43, David Hildenbrand wrote: Let's make the kernel a bit less horrible, by removing the linearity requirement in CoW PFNMAP mappings with !CONFIG_ARCH_HAS_PTE_SPECIAL. In particular, stop messing with vma->vm_pgoff in weird ways. Simply lookup in applicable (i.e., CoW PFNMAP) mapp

Re: [PATCH v3 0/5] remoteproc: imx_rproc: Support i.MX95

2025-06-25 Thread Rob Herring (Arm)
(Use > LMM protocol) > imx-boot-variant-alt-imx95-19x19-lpddr5-evk-sd.bin-flash_alt (Use CPU > protocol) > imx-boot-imx95-19x19-lpddr5-evk-sd.bin-flash_a55 (M7 not under A55 control) > imx-boot-imx95-19x19-lpddr5-evk-sd.bin-flash_all (M7 not under A55 control) > > Pa

Re: [PATCH 08/10] clk: qcom: Add Graphics Clock controller (GPUCC) driver for SM7635

2025-06-25 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build warnings: [auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494] url: https://github.com/intel-lab-lkp/linux/commits/Luca-Weiss/dt-bindings-clock-qcom-document-the-SM7635-Global-Clock-Controller/20250625-171703 base: 192

Re: [PATCH v2] rpmsg: char: Export alias for RPMSG ID rpmsg-raw from table

2025-06-25 Thread Mathieu Poirier
Good day, On Thu, Jun 19, 2025 at 03:57:22PM -0500, Andrew Davis wrote: > Module aliases are used by userspace to identify the correct module to > load for a detected hardware. The currently supported RPMSG device IDs for > this module include "rpmsg-raw", but the module alias is "rpmsg_chrdev". >

Re: [PATCH 1/2] remoteproc: imx_dsp_rproc: Add support of recovery process

2025-06-25 Thread Mathieu Poirier
On Tue, 24 Jun 2025 at 21:25, Shengjiu Wang wrote: > > On Mon, Jun 23, 2025 at 11:11 PM Mathieu Poirier > wrote: > > > > Good day, > > > > On Wed, Jun 18, 2025 at 02:26:43PM +0800, Shengjiu Wang wrote: > > > when recovery is triggered, rproc_stop() is called first then > > > rproc_start(), but th

Re: [PATCH net-next v4] vsock/test: Add test for null ptr deref when transport changes

2025-06-25 Thread Stefano Garzarella
On Tue, Jun 24, 2025 at 05:40:15PM +0200, Luigi Leonardi wrote: Add a new test to ensure that when the transport changes a null pointer dereference does not occur. The bug was reported upstream [1] and fixed with commit 2cb7c756f605 ("vsock/virtio: discard packets if the transport changes"). KAS

Re: [PATCH RFC 06/14] mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()

2025-06-25 Thread Oscar Salvador
On Wed, Jun 25, 2025 at 10:15:22AM +0200, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 05:43:37PM +0200, David Hildenbrand wrote: > > Just like we do for vmf_insert_page_mkwrite() -> ... -> > > insert_page_into_pte_locked(), support the huge zero folio. > > > > Signed-off-by: David Hildenbrand

Re: [PATCH v3] selftests: riscv: add misaligned access testing

2025-06-25 Thread Clément Léger
On 24/06/2025 14:46, Alexandre Ghiti wrote: > On 6/24/25 14:34, Clément Léger wrote: >> Gentle ping. > > > I put it back again on my for-next branch. Great, thanks ! > > Thanks, > > Alex > > >> >> Thanks, >> >> Clément >> >> On 22/05/2025 14:51, Clément Léger wrote: >>> This selftest tes

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-25 Thread Dmitry Vyukov
On Tue, 24 Jun 2025 at 16:05, Cyril Hrubis wrote: > > Hi! > > 6. What's the goal of validation of the input arguments? > > Kernel code must do this validation anyway, right. > > Any non-trivial validation is hard, e.g. even for open the validation > > function > > for file name would need to have

Re: [RFC PATCH v8 5/7] KVM: guest_memfd: Add slab-allocated inode cache

2025-06-25 Thread Huang, Ying
Shivank Garg writes: > Add dedicated inode structure (kvm_gmem_inode_info) and slab-allocated > inode cache for guest memory backing, similar to how shmem handles inodes. > > This adds the necessary allocation/destruction functions and prepares > for upcoming guest_memfd NUMA policy support chang

Re: [PATCH v2 0/8] irqbypass: Cleanups and a perf improvement

2025-06-25 Thread Sean Christopherson
On Fri, 16 May 2025 16:07:26 -0700, Sean Christopherson wrote: > The two primary goals of this series are to make the irqbypass concept > easier to understand, and to address the terrible performance that can > result from using a list to track connections. > > For the first goal, track the produc

Re: [PATCH v2] ksm_tests: Skip hugepage test when Transparent Hugepages are disabled

2025-06-25 Thread David Hildenbrand
On 24.06.25 05:27, Li Wang wrote: Some systems (e.g. minimal or real-time kernels) may not enable Transparent Hugepages (THP), causing MADV_HUGEPAGE to return EINVAL. This patch introduces a runtime check using the existing THP sysfs interface and skips the hugepage merging test (`-H`) when THP i

Re: [PATCH RFC 10/14] mm/memory: factor out common code from vm_normal_page_*()

2025-06-25 Thread David Hildenbrand
On 25.06.25 10:53, Oscar Salvador wrote: On Tue, Jun 17, 2025 at 05:43:41PM +0200, David Hildenbrand wrote: Let's reduce the code duplication and factor out the non-pte/pmd related magic into vm_normal_page_pfn(). To keep it simpler, check the pfn against both zero folios. We could optimize thi

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-25 Thread Dmitry Vyukov
On Tue, 24 Jun 2025 at 22:04, Sasha Levin wrote: > >9. I see that syscalls and ioctls say: > >KAPI_CONTEXT(KAPI_CTX_PROCESS | KAPI_CTX_SLEEPABLE) > >Can't we make this implicit? Are there any other options? > > Maybe? I wasn't sure how we'd describe somthing like getpid() which > isn't supposed to

Re: [PATCH 1/8] Introduce simple hazard pointers

2025-06-25 Thread Waiman Long
On 6/24/25 11:10 PM, Boqun Feng wrote: As its name suggests, simple hazard pointers (shazptr) is a simplification of hazard pointers [1]: it has only one hazard pointer slot per-CPU and is targeted for simple use cases where the read-side already has preemption disabled. It's a trade-off betwee

Re: [RFC 00/19] Kernel API Specification Framework

2025-06-25 Thread Cyril Hrubis
Hi! > > >6. What's the goal of validation of the input arguments? > > >Kernel code must do this validation anyway, right. > > >Any non-trivial validation is hard, e.g. even for open the validation > > >function > > >for file name would need to have access to flags and check file precense > > >for

Re: [PATCH 4/4] regulator: qcom-rpmh: add support for pm7550 regulators

2025-06-25 Thread Konrad Dybcio
On 6/25/25 4:10 PM, Konrad Dybcio wrote: > On 6/25/25 11:18 AM, Luca Weiss wrote: >> Add RPMH regulators exposed by Qualcomm Technologies, Inc. PM7550 PMIC. >> It has 6 FTS525 (FT-SMPS) and 23 LDOs with 3 different types. >> L1-L11 are LDO515 LV NMOS, L12-L13 are LDO515 MV PMOS, L14-L23 are >> LDO5

Re: [PATCH 3/3] arm64: dts: qcom: Add PMXR2230 PMIC

2025-06-25 Thread Konrad Dybcio
On 6/25/25 11:18 AM, Luca Weiss wrote: > Add a dts for the PMIC used e.g. with SM7635 devices. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/pmxr2230.dtsi | 63 > ++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm

Re: [PATCH 1/2] dt-bindings: remoteproc: Add C906L rproc for Sophgo CV1800B SoC

2025-06-25 Thread Rob Herring
On Sun, Jun 08, 2025 at 10:37:39AM +0800, Junhui Liu wrote: > Add C906L remote processor for CV1800B SoC, which is an asymmetric > processor typically running RTOS. > > Signed-off-by: Junhui Liu > --- > .../bindings/remoteproc/sophgo,cv1800b-c906l.yaml | 68 > ++ > 1 file c

Re: [PATCH net] vsock/uapi: fix linux/vm_sockets.h userspace compilation errors

2025-06-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 23 Jun 2025 12:00:53 +0200 you wrote: > From: Stefano Garzarella > > If a userspace application just include will fail > to build with the following errors: > > /usr/include/linux/vm_sockets.h:182:39: error

Re: [PATCH 4/8] shazptr: Avoid synchronize_shaptr() busy waiting

2025-06-25 Thread Boqun Feng
On Wed, Jun 25, 2025 at 03:56:05PM +0200, Frederic Weisbecker wrote: > Le Tue, Jun 24, 2025 at 08:10:57PM -0700, Boqun Feng a écrit : > > +static void synchronize_shazptr_normal(void *ptr) > > +{ > > + int cpu; > > + unsigned long blocking_grp_mask = 0; > > + > > + smp_mb(); /* Synchronize wi

Re: [PATCH 0/8] Introduce simple hazard pointers for lockdep

2025-06-25 Thread Boqun Feng
On Wed, Jun 25, 2025 at 05:05:11AM -0700, Christoph Hellwig wrote: > On Tue, Jun 24, 2025 at 08:10:53PM -0700, Boqun Feng wrote: > > Hi, > > > > This is the official first version of simple hazard pointers following > > the RFC: > > Can you please put an explanation of what hazard pointers are >

Re: [PATCH v2] selftests/mm: Fix UFFDIO_API usage with proper two-step feature negotiation

2025-06-25 Thread David Hildenbrand
On 24.06.25 06:24, Li Wang wrote: The current implementation of test_unmerge_uffd_wp() explicitly sets `uffdio_api.features = UFFD_FEATURE_PAGEFAULT_FLAG_WP` before calling UFFDIO_API. This can cause the ioctl() call to fail with EINVAL on kernels that do not support UFFD-WP, leading the test to

  1   2   3   4   5   6   7   8   9   10   >