On Sun, 11 Apr 2021, tawahpeggy wrote:
> remove one empty line.CHECK: Please don't use multiple blank lines
Did something go wrong with the patch generation? You say that you are
removing one line, but the diff information looks like you are adding a
file. Normally a patch has only the chang
On 11/04/2021 21:49, tawahpeggy wrote:
remove one empty line.CHECK: Please don't use multiple blank lines
Signed-off-by: tawahpeggy
---
drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
1 file changed, 0 insertion(+), 1 deletion(-)
create mode 100644 drivers/staging/comedi/comedi_pcmcia.m
On Sun, Apr 11, 2021 at 04:49:38PM -0400, tawahpeggy wrote:
> remove one empty line.CHECK: Please don't use multiple blank lines
>
> Signed-off-by: tawahpeggy
>
> ---
> drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
> 1 file changed, 0 insertion(+), 1 deletion(-)
> create mode 100644 driver
remove one empty line.CHECK: Please don't use multiple blank lines
Signed-off-by: tawahpeggy
---
drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
1 file changed, 0 insertion(+), 1 deletion(-)
create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
diff --git a/drivers/staging/comedi/co
this patchset fixes, where possible, some checkpatch errors on macros.
Delete unused macros and some unused struct fields tied
to removed macros.
Changes in v2:
- deleted unused macros
- ignored following checkpatch issues on macro:
* issues requiring to add parenth
On Tue, Feb 09, 2021 at 11:27:04AM +0530, Atul Gopinathan wrote:
> Fix the following types of checkpatch error and warning:
>
> ERROR: code indent should use tabs where possible
> WARNING: struct phy_ops should normally be const
That is 2 different things, which means this should be
Fix the following types of checkpatch error and warning:
ERROR: code indent should use tabs where possible
WARNING: struct phy_ops should normally be const
Signed-off-by: Atul Gopinathan
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
drivers/staging/hikey9xx/hi6421v600-regulator.c
On 2020/6/17 3:02, Jaegeuk Kim wrote:
> ERROR:INITIALISED_STATIC: do not initialise statics to NULL
>
> Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 1e02a8c106b0a..4dca9e4567348 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2
On Tue, 2019-10-08 at 12:02 +0800, Zhenzhong Duan wrote:
> Hi,
>
> When I run checkpatch.pl with a patch doing reverting operation, it
> reports a false positive error, Should I ignore the error or it's a bug?
Ignore it.
Hi,
When I run checkpatch.pl with a patch doing reverting operation, it
reports a false positive error, Should I ignore the error or it's a bug?
0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch
---
ERROR: Please use git
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/s
Cleaned up the code to resolve the checkpatch error else should follow
close brace '}' from the following files:
mlme_linux.c
recv_linux.c
sdio_intf.c
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6 ++
drivers/staging/rtl8723bs/os_dep/re
On Sun, Jun 16, 2019 at 09:19:49AM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
>
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
> d
Cleaned up the code to resolve the checkpatch error else should follow
close brace '}' from the following files:
mlme_linux.c
recv_linux.c
sdio_intf.c
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6 ++
drivers/staging/rtl8723bs/os_dep/re
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/s
On Sun, Jun 16, 2019 at 01:13:11AM -0700, Joe Perches wrote:
> On Sat, 2019-06-15 at 14:29 -0700, Shobhit Kukreti wrote:
> > Cleaned up the code from the following files to get rid of
> > check patch error "that open brace { should be on the previous line"
>
> It's fine you are modifying brace sty
On Sat, 2019-06-15 at 14:29 -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
It's fine you are modifying brace styles, but:
> diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/s
On Thu, Jun 13, 2019 at 07:12:10PM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
>
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
> d
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/s
This patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#343: FILE: drivers/cpuidle/cpuidle.c:343:
+EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
WARNING: EXPORT_SYMBOL(foo); should immediate
On Thu, Sep 7, 2017 at 2:40 PM, gaurav jindal
wrote:
> this patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
>
> WARNING: line over 80 characters
> #311: FILE: drivers/cpuidle/cpuidle.c:311:
> + /* Make sure all changes finished before we switch to
this patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: line over 80 characters
#311: FILE: drivers/cpuidle/cpuidle.c:311:
+ /* Make sure all changes finished before we switch to new idle
*/
WARNING: EXPORT_SYMBOL(foo); should immediately fol
On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.
> diff --git a/drivers/cpuidle/cpuidle.c b/dri
This patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: line over 80 characters
#311: FILE: drivers/cpuidle/cpuidle.c:311:
+ /* Make sure all changes finished before we switch to new idle
*/
WARNING: EXPORT_SYMBOL(foo); should immediately fol
this commit removes the checkpatch error in cpuidle_enable_device
function. With removal of error, this commit makes the calling of
cpuidle_curr_governor->enable more smooth.
Signed-off-by: gaurav jindal
---
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb
On Sat, Feb 04, 2017 at 01:42:48PM +0900, Youngdo Lee wrote:
> Fix checkpatch error:
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Youngdo Lee
> ---
> drivers/staging/fbtft/fbtft-bus.c | 5 +++--
> 1 file changed, 3 insertions(+),
Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Youngdo Lee
---
drivers/staging/fbtft/fbtft-bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c
b/drivers/staging/fbtft/fbtft-b
On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote:
> 19.12.2016, 08:35, "Greg KH" :
> > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
> >> These changes where identified by checkpatch.pl as needed changes to
> >> align the code with the linux development coding style
19.12.2016, 08:35, "Greg KH" :
> On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
>> These changes where identified by checkpatch.pl as needed changes to
>> align the code with the linux development coding style. The several
>> lines of text where aligned with the precending paren
Hi Ozgur,
On 12/12/16 10:46, Ozgur Karatas wrote:
> Hello all,
>
> I tested to mmu.c and I have fixed to some errors.
>
> mmu.c:510: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ozgur Karatas
> ---
> arch/arm/kvm/mmu.c | 2 +-
>
> diff --git a/arch/arm/kvm/mmu.
Hello all,
I tested to mmu.c and I have fixed to some errors.
mmu.c:510: ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Ozgur Karatas
---
arch/arm/kvm/mmu.c | 2 +-
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
index a5265ed..a83cf47 100644
--- a/arch/arm/kvm/m
Fix error message by checkpath.pl
open brace '{' following struct/enum go on the same line
Patch applied by running fix inplace capability of checkpatch:
checkpatch.pl -f *.[ch] --types OPEN_BRACE --fix-inplace
Signed-off-by: Anson Jacob
---
drivers/usb/gadget/function/rndis.c| 3 +-
drive
convert spaces to tab
fix the following error messages from checkpatch.pl
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
Signed-off-by: Anson Jacob
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion(+),
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof Kozl
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof Kozl
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof Kozl
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof Kozl
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof Kozl
Hello Laxman,
On 02/02/2016 10:16 AM, Laxman Dewangan wrote:
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
---
Reviewed-b
On 02.02.2016 22:16, Laxman Dewangan wrote:
> Fix following check patch error in rtc-max77686 driver:
> - Alignment should match open parenthesis.
> - braces {} should be used on all arms of this statement.
> - Prefer using the BIT macro
>
> Signed-off-by: Laxman Dewangan
> ---
> drivers/rtc/rtc
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
---
drivers/rtc/rtc-max77686.c | 25 +
1 file changed,
Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
Signed-off-by: Geliang Tang
Reviewed-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On 05/07/2015 09:27 AM, Jaime Arrocha wrote:
-- Forwarded message --
From: Jaime Arrocha
Date: Wed, May 6, 2015 at 4:08 PM
Subject: [PATCH] staging: comedi: drivers: das16m1.c: checkpatch error fix
To: g...@kroah.com
Cc: abbo...@mev.co.uk, hswee...@visionengravers.com,
de
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-by: Jaime Arrocha
---
drivers/staging/comedi/drivers/das16m1.c |4 ++--
1 file changed, 2 insertions(+), 2 del
On Mon, May 04, 2015 at 11:44:58PM -0700, Joe Perches wrote:
> On Tue, 2015-05-05 at 07:01 +0100, Okash Khawaja wrote:
> > This patch fixes the checkpatch.pl error:
>
> Please fix the space/tab use too.
>
> Your email client seems to have converted all the tabs
> to spaces.
>
> default should us
This patch fixes these checkpatch.pl errors:
ERROR: trailing statements should be on next line
ERROR: switch and case should be at the same indent
More specifically, the fix has been applied to the five occurances of the
errors listed below.
ERROR: trailing statements should be on next line
#11
On Tue, 2015-05-05 at 07:01 +0100, Okash Khawaja wrote:
> This patch fixes the checkpatch.pl error:
Please fix the space/tab use too.
Your email client seems to have converted all the tabs
to spaces.
default should use the same indent as the case statements
> diff --git a/drivers/net/wireless/
This patch fixes the checkpatch.pl error:
ERROR: trailing statements should be on next line
More specifically, the fix has been applied to the four occurances of the error
listed below.
ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+
Okash Khawaja writes:
> On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote:
>> Okash Khawaja writes:
>>
>> > This patch fixes the checkpatch.pl error:
>> >
>> > ERROR: trailing statements should be on next line
>> >
>> > More specifically, the fix has been applied to the four occurances
On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote:
> Okash Khawaja writes:
>
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: trailing statements should be on next line
> >
> > More specifically, the fix has been applied to the four occurances of the
> > error listed below.
Okash Khawaja writes:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing statements should be on next line
>
> More specifically, the fix has been applied to the four occurances of the
> error listed below.
>
> ERROR: trailing statements should be on next line
> #1101: FILE: drivers
This patch fixes the checkpatch.pl error:
ERROR: trailing statements should be on next line
More specifically, the fix has been applied to the four occurances of the error
listed below.
ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+
Error: Missing a blank line after declarations
Singed-off-by: pushpendra.si...@smartplayin.com
to: pramod.gu...@smartplayin.com
cc: kiran.pad...@smartplayin.com
cc: chowdegowda...@smartplayin.com
---
drivers/staging/media/tlg2300/pd-alsa.c | 2 ++
1 file changed,
On 28/12/14 18:56, Andreas Siegling wrote:
This patch will fix the following checkpatch errors/warnings in
drivers/staging/comedi/ which are brought by wrong spacing:
ERROR: trailing whitespace
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space bef
On 28/12/14 18:56, Andreas Siegling wrote:
This patch fixes all occurrences of 8 whitespaces instead of a tab.
It will remove the 8 whitespaces and replace them with a tab, thereby
the checkpatch-error:
ERROR: code indent should use tabs where possible
is removed from all files
This patch will fix the following checkpatch errors/warnings in
drivers/staging/comedi/ which are brought by wrong spacing:
ERROR: trailing whitespace
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space before tabs
Signed-off-by: Andreas Siegling
Si
This patch fixes all occurrences of 8 whitespaces instead of a tab.
It will remove the 8 whitespaces and replace them with a tab, thereby
the checkpatch-error:
ERROR: code indent should use tabs where possible
is removed from all files in drivers/staging/comedi/
It also brings some
Athira Lekshmi writes:
> Fixed the checkpatch error:
> ERROR: spaces required around that '>'
>
> Signed-off-by: Athira Lekshmi
> ---
> drivers/staging/rtl8723au/core/rtw_cmd.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> dif
Fixed the checkpatch error:
ERROR: spaces required around that '>'
Signed-off-by: Athira Lekshmi
---
drivers/staging/rtl8723au/core/rtw_cmd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
b/drivers/staging/r
On Tue, Nov 11, 2014 at 03:28:57PM +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes following
> Error.
>
> ERROR: that open brace { should be on the previous line
This patch does much more than that :(
--
To unsubscribe from this list: send the line "unsubscribe lin
This is a patch to the rtw_cmd.c file that fixes following
Error.
ERROR: that open brace { should be on the previous line
Signed-off-by: Sanjeev Sharma
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 79 +++-
1 file changed, 38 insertions(+), 41 deletions(-)
diff --g
On Mon, Sep 08, 2014 at 09:55:58AM -0500, Morgan Phillips wrote:
> Change array initialization format to fix style error.
> from:
> u8 foo[] =
> {1, 2, 3};
> to:
checkpatch is giving a warning here , but looks like a false positive.
thanks
sudip
>
Change array initialization format to fix style error.
from:
u8 foo[] =
{1, 2, 3};
to:
u8 foo[] = {
1, 2, 3
};
Signed-off-by: Morgan Phillips
---
Changes since v2:
* adds a more ver
On Mon, Sep 08, 2014 at 08:51:18AM -0500, Morgan Reece wrote:
> Hi Sudip,
>
> I searched through the logs for examples of messages where people had just
> fixed checkpatch errors. I found lots like this, so went the format, ex:
>
> commit 588a12d789e1a9b8193465c09f32024c0d43a849
> Author: Filipe
On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote:
> Signed-off-by: Morgan Phillips
no commit message ?
thanks
sudip
> ---
> drivers/media/usb/gspca/sn9c20x.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/usb/gspca/sn9c20x.c
>
Signed-off-by: Morgan Phillips
---
drivers/media/usb/gspca/sn9c20x.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/usb/gspca/sn9c20x.c
b/drivers/media/usb/gspca/sn9c20x.c
index 41a9a89..95467f0 100644
--- a/drivers/media/usb/gspca/sn9c20x.c
+++ b/dr
This patch removes a checkpatch error by adding a line below
the definitions of the character array buf and the pointer path.
Signed-off-by: Nicholas Krause
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers
This is part of an effort to clean-up the MFD subsystem.
ERROR: space required after that ',' (ctx:VxV)
+#define MSP_GPIO(bit,reg) ((DM355EVM_MSP_ ## reg) << 3 | (bit))
^
total: 1 errors, 0 warnings, 437 lines checked
Signed-off-by: Lee Jones
---
drivers/mfd/dm355evm_
This removes a error I get when I run checkpatch on this file, relating
to the asterisk for declaritations needing to be next to the name of the
variable/structure and not the type of variable/structure.
---
arch/alpha/boot/tools/mkbb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
parate patches ?
patch 1: remove useless returns
patch 2: too long lines
patch 3: fix sleep ranges
etc.
> > > /* TODO: we should not delay such a long time. Ask for help from
> > SD3 */
> > > - usleep_range(1000, 1000);
> > > + usleep_range(1000, 2
On Tue, Jul 08, 2014 at 11:34:18AM +0530, sanjeev sharma wrote:
> From: sanjeevs1
^
No.
>
> This is a patch to the r819xU_phy.c file that fixes up all the Error/Warning
> found by the checkpatch.pl tool
Split it into one thing per patch.
>
> Signed-off-by: Sanjeev Sharma
> -
From: sanjeevs1
This is a patch to the r819xU_phy.c file that fixes up all the Error/Warning
found by the checkpatch.pl tool
Signed-off-by: Sanjeev Sharma
---
drivers/staging/rtl8192u/r819xU_phy.c | 76 +--
1 file changed, 36 insertions(+), 40 deletions(-)
dif
From: "Lad, Prabhakar"
this patch fixes following checkpatch warning, and alongside
renames the DAVINCIHD_DISPLAY_H to VPIF_DISPLAY_H.
WARNING: Unnecessary space before function pointer arguments
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpif_display.h |8
ERROR: else should follow close brace '}'
+ }
+ else {
Signed-off-by: Tomas Winkler
---
drivers/misc/mei/amthif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c
index 2052609..b8deb34 100644
--- a/drivers/mi
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/
Sorry for confusing you.
Actually 1-3 patches already merged to staging-next branch.
And then I had a request resending the rest of the series.
So I just sent 4-7 again. Sorry, I should rebase these patches and
make a series newly.
I will send patches again properly.
I think this patches need to
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
>
> checkpatch.pl error in linux.c:
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/cxt1e1/linux.c | 31 +++
> 1 files changed, 19 insertions(+), 1
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/
Yes, it need to add brace in inner loop.
I will send again.
Thanks for review.
Daeseok Youn
2014-03-04 18:04 GMT+09:00, Dan Carpenter :
> On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
>> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>> ci = (ci_t *)(netdev_priv(hi-
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
> ci = (ci_t *)(netdev_priv(hi->ndev));
> for (j = 0; j < ci->max_port; j++)
> for (k = 0; k < MUSYCC_NCHANS; k++)
> -
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Daeseok Youn
---
d
On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote:
> In rtllib_debug.h we fixed the following checkpatch error:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> We fixed this with a do {} while (0), because otherwise the compiler
In rtllib_crypt_tkip.c we fixed the following checkpatch error:
ERROR: space required after that ','
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
In rtllib_debug.h we fixed the following checkpatch error:
ERROR: Macros with complex values should be enclosed in parenthesis
We fixed this with a do {} while (0), because otherwise the compiler complained.
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers
On 2013/7/30 11:10, Joe Perches wrote:
> On Tue, 2013-07-30 at 11:04 +0800, Li Zefan wrote:
>> On 2013/7/30 10:36, Joe Perches wrote:
>>> On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote:
On 2013/7/30 9:58, Joe Perches wrote:
> So what are these TRACE_ defines that need
> excluding fr
On Tue, 2013-07-30 at 11:04 +0800, Li Zefan wrote:
> On 2013/7/30 10:36, Joe Perches wrote:
> > On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote:
> >> On 2013/7/30 9:58, Joe Perches wrote:
> >>> So what are these TRACE_ defines that need
> >>> excluding from the "complex values" check?
> >>>
> >>>
On 2013/7/30 10:36, Joe Perches wrote:
> On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote:
>> On 2013/7/30 9:58, Joe Perches wrote:
>>> So what are these TRACE_ defines that need
>>> excluding from the "complex values" check?
>>>
>>> Anything other than
>>>
>>> TRACE_SYSTEM
>>> TRACE_INCLUDE_FILE
On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote:
> On 2013/7/30 9:58, Joe Perches wrote:
> > So what are these TRACE_ defines that need
> > excluding from the "complex values" check?
> >
> > Anything other than
> >
> > TRACE_SYSTEM
> > TRACE_INCLUDE_FILE
> > TRACE_INCLUDE_PATH
> >
> > ?
> >
On 2013/7/30 9:58, Joe Perches wrote:
> On Tue, 2013-07-30 at 09:30 +0800, Li Zefan wrote:
>> On 2013/7/30 3:52, Sarah Sharp wrote:
>>> Hi Andy and Joe,
>>>
>>> Checkpatch is complaining when code adds new trace events macros:
>>>
>>> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/
On Tue, 2013-07-30 at 09:30 +0800, Li Zefan wrote:
> On 2013/7/30 3:52, Sarah Sharp wrote:
> > Hi Andy and Joe,
> >
> > Checkpatch is complaining when code adds new trace events macros:
> >
> > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> > Applying: xhci: add trace
On 2013/7/30 3:52, Sarah Sharp wrote:
> Hi Andy and Joe,
>
> Checkpatch is complaining when code adds new trace events macros:
>
> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> Applying: xhci: add traces for debug messages in xhci_address_device()
> ERROR: Macros wit
On Mon, 2013-07-29 at 14:23 -0700, Sarah Sharp wrote:
> On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote:
> > On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote:
[]
> > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> > > Applying: xhci: add traces for debu
On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote:
> On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote:
> > Hi Andy and Joe,
>
> Hi Sarah.
>
> > Checkpatch is complaining when code adds new trace events macros:
> >
> > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/
On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote:
> Hi Andy and Joe,
Hi Sarah.
> Checkpatch is complaining when code adds new trace events macros:
>
> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> Applying: xhci: add traces for debug messages in xhci_address_dev
1 - 100 of 144 matches
Mail list logo
